Nicolas Chevobbe
de82cf7714
Bug 1605162 - Test that context selector is updated when pausing in a remote frame. r=Honza.
...
Differential Revision: https://phabricator.services.mozilla.com/D71527
2020-07-10 09:19:48 +00:00
Farooq AR
4fabbe2929
Bug 1646027 - Request mimeType should be sent on response start. r=Honza,bomsy,devtools-backward-compat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D82206
2020-07-10 07:48:54 +00:00
Daisuke Akatsuka
f384956392
Bug 1650658: Revert PerformanceController to have toolbox. r=loganfsmyth
...
Differential Revision: https://phabricator.services.mozilla.com/D82829
2020-07-09 23:16:09 +00:00
Tom Prince
2c52622b85
Bug 1651731: [lint] Add a bunch more types of files that should never be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,preferences-reviewers,agi,sylvestre,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D82953
2020-07-09 21:28:49 +00:00
Csoregi Natalia
55e9fe527f
Backed out 3 changesets (bug 1645234) for causing leaks. CLOSED TREE
...
Backed out changeset 6097753dbefa (bug 1645234)
Backed out changeset f74844ba692a (bug 1645234)
Backed out changeset a90a3c1efdc5 (bug 1645234)
2020-07-10 01:54:09 +03:00
Andrea Marchesini
3c1b71a6e4
Bug 1651618 - Use cookie 'SameSite' attribute with capital 'S' everywhere, r=flod,fluent-reviewers,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,whimboo,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D82872
2020-07-09 20:40:15 +00:00
Johann Hofmann
a2b45ec970
Bug 1645234 - Add a test for document.requestStorageAccess error messages. r=nchevobbe
...
Depends on D79788
Differential Revision: https://phabricator.services.mozilla.com/D80972
2020-07-09 20:13:04 +00:00
Johann Hofmann
d2abd7c95a
Bug 1645234 - Add learn more link to storage access API warnings. r=nchevobbe
...
Depends on D79597
Differential Revision: https://phabricator.services.mozilla.com/D79788
2020-07-09 20:12:57 +00:00
Micah Tigley
af6e13372c
Bug 1648616 - Remove code path separation for old-RDM test helpers. r=gl
...
Depends on D82428
Differential Revision: https://phabricator.services.mozilla.com/D82429
2020-07-09 20:20:25 +00:00
Micah Tigley
47a80c7dfa
Bug 1648616 - Remove all references to "usingBrowsingUI" option in RDM tests. r=gl
...
Depends on D82427
Differential Revision: https://phabricator.services.mozilla.com/D82428
2020-07-09 20:20:17 +00:00
Micah Tigley
bc9e0dd52e
Bug 1648616 - Remove tests for old RDM. r=gl
...
Differential Revision: https://phabricator.services.mozilla.com/D82427
2020-07-09 20:19:57 +00:00
Julian Descottes
7b9705ac23
Bug 1650336 - Add the session id to the WebconsoleAddMessages marker label r=nchevobbe
...
An issue with the current approach is that labels are a bit too big for the marker chart sidebar in the profiler UI.
An issue was filed to address this at https://github.com/firefox-devtools/profiler/issues/2638
Differential Revision: https://phabricator.services.mozilla.com/D82772
2020-07-09 16:36:18 +00:00
Yura Zenevich
ff699eadb0
Bug 1649307 - ensure that we do not prevent defaults or stop propagation for events that are for the remote frame target. r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D82630
2020-07-09 16:00:32 +00:00
Razvan Maries
b0c852f91a
Backed out 2 changesets (bug 1647735) for GetViewportInfo perma failures. CLOSED TREE
...
Backed out changeset deb2f679f4fb (bug 1647735)
Backed out changeset bb88c365b828 (bug 1647735)
2020-07-09 18:45:22 +03:00
Micah Tigley
a785e38a2a
Bug 1647735 - Add a test for checking that ICB fallback width uses the larger viewport width. r=bradwerth
...
Differential Revision: https://phabricator.services.mozilla.com/D82540
2020-07-09 00:40:15 +00:00
Nicolas Chevobbe
d7fdb5bb73
Bug 1644186 - Add server support for Error messages resources. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D81356
2020-07-09 12:39:22 +00:00
Itiel
bd28d23ce6
Bug 1651443 - Always align the codemirror lines to the left r=Honza
...
Differential Revision: https://phabricator.services.mozilla.com/D82774
2020-07-09 12:04:32 +00:00
Razvan Maries
3ed03d134b
Backed out changeset 162bc74a2c75 (bug 1644186) for perma failures on browser_webconsole_stubs_page_error.js. CLOSED TREE
2020-07-09 15:20:24 +03:00
Andreea Pavel
4d223b739e
Backed out 3 changesets (bug 1645234) for failing browser_webconsole_requestStorageAccess_errors.js on a CLOSED TREE
...
Backed out changeset ad1f8a4d64cf (bug 1645234)
Backed out changeset 6de9007aa306 (bug 1645234)
Backed out changeset 87d5d468c7f2 (bug 1645234)
2020-07-09 13:05:14 +03:00
Nicolas Chevobbe
cf209b6c53
Bug 1644186 - Add server support for Error messages resources. r=ochameau.
...
Differential Revision: https://phabricator.services.mozilla.com/D81356
2020-07-09 08:55:49 +00:00
Johann Hofmann
4d4f4b4de2
Bug 1645234 - Add a test for document.requestStorageAccess error messages. r=nchevobbe
...
Depends on D79788
Differential Revision: https://phabricator.services.mozilla.com/D80972
2020-07-09 08:55:05 +00:00
Johann Hofmann
cb1b24c051
Bug 1645234 - Add learn more link to storage access API warnings. r=nchevobbe
...
Depends on D79597
Differential Revision: https://phabricator.services.mozilla.com/D79788
2020-07-09 08:54:58 +00:00
Daisuke Akatsuka
6959f8e469
Bug 1625930: Add a test for count function of EventEmitter instance r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D82802
2020-07-08 23:20:09 +00:00
Daisuke Akatsuka
4e9744b43d
Bug 1625930: Add test getAllResources of ResourceWatcher API. r=ochameau
...
Depends on D78242
Differential Revision: https://phabricator.services.mozilla.com/D82150
2020-07-08 22:58:41 +00:00
Daisuke Akatsuka
09ed9781f1
Bug 1625930: Add test ResourceWatcher for STYLESHEET type. r=ochameau
...
Depends on D78241
Differential Revision: https://phabricator.services.mozilla.com/D78242
2020-07-08 15:13:05 +00:00
Daisuke Akatsuka
80b6400e07
Bug 1625930: Apply ResourceWatcher to source map. r=ochameau
...
Depends on D78240
Differential Revision: https://phabricator.services.mozilla.com/D78241
2020-07-08 23:07:33 +00:00
Daisuke Akatsuka
d1f58c00a9
Bug 1625930: Apply ResourceWatcher to StyleEditor. r=ochameau
...
Depends on D78239
Differential Revision: https://phabricator.services.mozilla.com/D78240
2020-07-09 04:37:54 +00:00
Daisuke Akatsuka
1498e73db8
Bug 1625930: Implement ResourceWatcher for stylesheet. r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D78239
2020-07-08 15:13:12 +00:00
Matthew Gaudet
763196a86c
Bug 1651420 - Adding private fields to an object is side-effectful and should be marked as such r=loganfsmyth
...
Note: Until private fields are enabled by default, this test case will take the
early return. However, I have tested locally that it fails without the fix, and
passes with the fix.
Differential Revision: https://phabricator.services.mozilla.com/D82786
2020-07-09 02:14:02 +00:00
Dorel Luca
3e4da6b273
Backed out changeset 00e12ae2d596 (bug 1649910) for Browser-chrome failures in browser/browser_ext_devtools_inspectedWindow_targetSwitch.js. CLOSED TREE
2020-07-09 03:58:43 +03:00
Nika Layzell
22c8ce6573
Bug 1650837 - Part 8: Avoid unnecessary sendQuery for DevToolsFrameParent:packet, r=jdescottes
...
The reply was never used, and due to other changes in this bug, was causing
ignored exceptions to be thrown occasionally when a query was sent immediately
before unregistering the actor.
Differential Revision: https://phabricator.services.mozilla.com/D82615
2020-07-08 09:41:56 +00:00
Itiel
37e074cdb6
Bug 1651450 - Fix the navigation buttons direction and url input in about:debugging for RTL r=jdescottes
...
Differential Revision: https://phabricator.services.mozilla.com/D82780
2020-07-08 19:21:24 +00:00
Alexandre Poirot
6c430374e4
Bug 1649910 - Emit "switched-target" only after we fully attached to the new target. r=jdescottes
...
The previous code, emitting the event from Toolbox.onTargetAvailable,
wasn't waiting for the call to TargetList.startListening which is done
from TargetList.onTargetAvailable.
Differential Revision: https://phabricator.services.mozilla.com/D82664
2020-07-08 22:57:36 +00:00
Kris Maglione
2faa43dd5c
Bug 1647438: Remove nsIDOMWindowUtils.containerElement. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D81771
2020-07-02 15:03:44 +00:00
Sebastian Hengst
aa6404a088
Bug 1559315
- Temporarily disable browser_rules_authored_color.js on Windows opt. r=gbrown DONTBUILD
...
Differential Revision: https://phabricator.services.mozilla.com/D82775
2020-07-08 20:21:04 +00:00
Hubert Boma Manilla
b271ba8b01
Bug 1649632 - Update the slow icon tooltip r=Honza,victoria
...
Differential Revision: https://phabricator.services.mozilla.com/D81817
2020-07-08 18:16:18 +00:00
Julian Descottes
0e4d7862d4
Bug 1651319
- Cleanup devtools calls to JSWindowActor sendAsyncMessage r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D82677
2020-07-08 18:52:17 +00:00
Alexandre Poirot
2bffbc8732
Bug 1625027 - Use Browser Element's ID instead of Browsing Context ID. r=jdescottes,nchevobbe
...
This allows to better support navigating to a new BrowsingContext within the same Tab.
Overall, framework codebase is tracking a Browser Element and should use browserId.
Targets may end up being specific to one BrowsingContext/WindowGlobal,
so they may rather use browsingContextID.
Differential Revision: https://phabricator.services.mozilla.com/D81862
2020-07-08 14:23:16 +00:00
Julian Descottes
b225cf5e85
Bug 1647366 - Add a test for Inspect Element with nested remote frames r=rcaliman,ochameau
...
Depends on D80910
Differential Revision: https://phabricator.services.mozilla.com/D80911
2020-07-08 14:24:06 +00:00
Julian Descottes
c32dffdf40
Bug 1647366 - Re-enable context menu tests that were skipped for fission r=ochameau,perftest-reviewers,Bebe
...
Depends on D80909
Differential Revision: https://phabricator.services.mozilla.com/D80910
2020-07-08 14:12:33 +00:00
Julian Descottes
58fcf13c2e
Bug 1647366 - Check parent browsing context ids to find a valid BrowsingContextTarget r=ochameau,rcaliman
...
WatcherFront's `getBrowsingContextTarget` can be called for a browsing context id which doesn't match an existing DevTools target.
For the following frame hierarchy:
```
root (example.com)
frame1 (example.org)
frame2 (example.org)
```
Both frame1 and frame2 have the same origin and will run in the same process. This means that devtools will only create a single BrowsingContextTarget for both.
But each frame has its own browsing context id, and the BrowsingContextTargetActor by default will only know about the browsing context id of the topmost frame (frame 1).
If we try to directly get the browsing context target for frame2's bc ID, the current implementation will not find anything.
This can easily happen with the "Inspect Element" feature which will extract the browsing context id from a contentDomReference.
See the following method will on the inspector front: https://searchfox.org/mozilla-central/rev/a87a1c3b543475276e6d57a7a80cb02f3e42b6ed/devtools/client/fronts/inspector.js#178
Differential Revision: https://phabricator.services.mozilla.com/D80909
2020-07-08 14:49:31 +00:00
Bogdan Tara
75881e8400
Backed out 6 changesets (bug 1625930) for test_eventemitter_basic.js failures CLOSED TREE
...
Backed out changeset 30a3da9f613c (bug 1625930)
Backed out changeset d4e4c3ddcc43 (bug 1625930)
Backed out changeset 0133d9c58323 (bug 1625930)
Backed out changeset 1c9cf53f2a89 (bug 1625930)
Backed out changeset f63839eff636 (bug 1625930)
Backed out changeset a6bef105a2c2 (bug 1625930)
2020-07-08 18:08:27 +03:00
Kyle Knaggs
967178f81b
Bug 1645887 - Fix text copied by 'Copy to clipboard' and 'Copy source text' context menu items r=davidwalsh
...
This patch addresses the issue reported by [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1645887 | Bug 1645887 ]] where the context menu items in the `Editor` were not copying the expected text to the clipboard.
Regarding the context menu in the `Editor` this patch modifies the menu items so that:
1. 'Copy to clipboard' => Copies the text that has been selected by a user to the clipboard.
2. 'Copy source text' => Copies all of the text from a source to the clipboard.
In addition to the above fix, this patch also modifies a related item in the `Tab` context menu so that:
1. The text for the ‘Copy to clipboard’ menu item is now replaced with ‘Copy source text’.
As with the context menu in the `Editor`, the pre-existing ‘Copy to clipboard’ menu item in the `Tab` copied all of the text from a source to the clipboard. However, instead of modifying the functionality of this menu item, the decision was made to replace the ‘Copy to clipboard’ text with ‘Copy source text’. This was done as the `Tab` and its context menu typically provides the user with general information about the file being displayed instead of being concerned with details such as the state of the editor.
{F2332380}
Differential Revision: https://phabricator.services.mozilla.com/D81887
2020-07-08 14:40:29 +00:00
Daisuke Akatsuka
8e979c2529
Bug 1625930: Add test getAllResources of ResourceWatcher API. r=ochameau
...
Depends on D78242
Differential Revision: https://phabricator.services.mozilla.com/D82150
2020-07-03 11:35:53 +00:00
Daisuke Akatsuka
77d64ed1e3
Bug 1625930: Add test ResourceWatcher for STYLESHEET type. r=ochameau
...
Depends on D78241
Differential Revision: https://phabricator.services.mozilla.com/D78242
2020-07-03 08:12:53 +00:00
Daisuke Akatsuka
38a7ac44c7
Bug 1625930: Apply ResourceWatcher to source map. r=ochameau
...
Depends on D78240
Differential Revision: https://phabricator.services.mozilla.com/D78241
2020-07-08 14:05:13 +00:00
Daisuke Akatsuka
899ed9d38e
Bug 1625930: Apply ResourceWatcher to StyleEditor. r=ochameau
...
Depends on D78239
Differential Revision: https://phabricator.services.mozilla.com/D78240
2020-07-08 14:05:42 +00:00
Daisuke Akatsuka
124d4687f9
Bug 1625930: Implement ResourceWatcher for stylesheet. r=ochameau
...
Differential Revision: https://phabricator.services.mozilla.com/D78239
2020-07-08 14:05:29 +00:00
Bogdan Tara
a33ac518b9
Backed out changeset 4d7e94b15360 (bug 1646027) for browser_webconsole_stubs_network_event.js failures CLOSED TREE
2020-07-08 14:16:02 +03:00
Farooq AR
ec6505b9a1
Bug 1646027 - Request mimeType should be sent on response start. r=Honza,bomsy,devtools-backward-compat-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D82206
2020-07-08 09:42:44 +00:00