Now that we do process normal traversal even in the case of throttled animation
flush so that we don't need to do special handling for the case.
Note about the comment in has_current_styles():
the remaining animation hints is not caused by either this patch or the
previous patch in this patch series, it's been there in the first place, but
it should be fixed somehow later. See bug 1389675.
MozReview-Commit-ID: JojHufxNCiS
The old process ran "before" and "after" steps as root. The
mozharness script doesn't run as root, which required some small
changes to not run Sonatype Nexus as root. Everything else is a
straight-forward move of the scripts out of the `android-gradle-build`
image and into `taskcluster/scripts`.
MozReview-Commit-ID: CqnNI33OKmb
--HG--
rename : taskcluster/docker/android-gradle-build/bin/after.sh => taskcluster/scripts/builder/build-android-dependencies/after.sh
rename : taskcluster/docker/android-gradle-build/bin/before.sh => taskcluster/scripts/builder/build-android-dependencies/before.sh
rename : taskcluster/docker/android-gradle-build/bin/repackage-jdk-centos.sh => taskcluster/scripts/builder/build-android-dependencies/repackage-jdk-centos.sh
extra : rebase_source : f94e6b9b780f96038c60d3825039a0f94add0404
We really want the Android build image to inherit from desktop-build,
but that isn't possible with the current `docker-image: in-tree:`
support. Therefore, way back in the mists of time, I culted
android-gradle-build from desktop-build. This moves it back (mostly)
in line with desktop-build, which has advanced.
MozReview-Commit-ID: 6GmuxHjhAbv
--HG--
extra : rebase_source : 265937bc9ba3bc4c18756b6c675100a62929bafe
There's little value in a more complicated process for setting the
underlying Docker image for a `run: using: mozharness` job.
This uncovered a typo (extraneous comma) in a Mac OS X repackage job.
MozReview-Commit-ID: DGOs1NvuS32
--HG--
extra : rebase_source : cd7a8402259139f37ec649bb5dc39317fe2fc3cb
We're going to start tracking the restyle root on the presshell, so we'll need
one. This should be fine, since if the presshell doesn't exist yet we can't
have done the initial style, and if it's already been destroyed we don't need
restyle state anymore.
MozReview-Commit-ID: EfNVloI9ENQ
Deduplicating code is nice, and it will help us when we make the bit
propagation more complicated in upcoming patches.
MozReview-Commit-ID: KIQnNJVayrM
This function is large enough that it doesn't really make sense to have inline,
and we'll be adding more to it in the coming patches.
MozReview-Commit-ID: AnDfzwsMvNy
Before, a non-runnable watchman would result in configure
error.
A trivial refactor to ignore `watchman version` errors would still
result in setting WATCHMAN and exposing its presence to downstream
consumers.
Since we want WATCHMAN tied to a working watchman install, we
refactor the code so that binary location and its version test
are in the same function. They are either both defined or none
of them are.
MozReview-Commit-ID: 7wvBvYuOlmJ
--HG--
extra : rebase_source : d9cc648cdb8253bf8e413ec0fa5e969aa68f75b9
The buggy animation handling isn't a regression, since currently we pass
UnstyledChildrenOnly in those cases, which blocks the animation traversal
in Servo_TraverseSubtree.
In general I really wanted to handle these two paths together. But there's
enough broken with the NewChildren path that I wanted to scope the buginess
as tightly as possible. And I really need to separate the handling here from
StyleDocument() to make the restyle root stuff work.
MozReview-Commit-ID: 9F0mcQl7AAX
This makes things a bit easier to follow, and sets the stage for eliminating
PrepareAndTraverseSubtree and making StyleDocument restyle-root-aware.
MozReview-Commit-ID: 40ORrqAuXni
Our home panel context menu is shared by classic top sites, history and bookmark panels.
For acitivty stream, we've added a new context menu, and a new type of pins. However,
old context menu is still used for history and bookmarks. New style of pins allows for
items to be pinned from those panels to activity stream. This requires having both "classic"
pin buttons for old Top Sites panel, as well as the new AS Pin button.
However, initial implementation forgot to disable the new AS Pin button for the classic
Top Sites panel context menu. This caused two "pin site" menu items to appear, and the
AS one would crash the browser if it's interacted with.
We'll be unifying context menus at some point, and removing the old Top Sites code,
and so this simple patch should be sufficient.
MozReview-Commit-ID: 3cxVTv6QP8L
--HG--
extra : rebase_source : 967ad0512f7362286218cb038ce237c9e5c59aa8
Add a raw payload section when looking at a non main ping.
MozReview-Commit-ID: 2dU8apRfzLP
--HG--
extra : rebase_source : 473ef7167c98a93a121d003d1c3a3e0404621cb6
And add tests to confirm that activeTab works for both
_execute_browser_action and _execute_page_action.
MozReview-Commit-ID: HDTDZXCvukc
--HG--
extra : rebase_source : 1a59270afa7b87979329d0fed197238e6655a647
Failure to catch this error broke bholley's PR https://github.com/servo/servo/pull/18048http://build.servo.org/builders/linux-dev/builds/8616/steps/shell__1/logs/stdio.
Logs below for posterity.
```
Current Rust nightly version: 599be0d18f4c6ddf36366d2a5a2ca6dc65886896
Current Rust stable version: 1.19.0
Removing /home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434
Error running mach:
['clean-nightlies', '--keep', '3', '--force']
The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You should consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
OSError: [Errno 2] No such file or directory:
'/home/servo/.servo/cargo/13d94d5fa8129a34f5c77a1bcd76983f5aed2434'
File
"/home/servo/buildbot/slave/linux-dev/build/python/servo/bootstrap_commands.py",
line 334, in clean_nightlies
delete(full_path)
File "/home/servo/buildbot/slave/linux-dev/build/python/servo/util.py", line
28, in delete
os.remove(path)
```
I don't know how the builder got into the edge case where the old nightly wasn't there for deletion, but in the case that removal fails for some reason, mach should just keep going. In the incredibly unlikely event that the failure to remove the file has consequences down the line, we'll have the failed remove in the log for troubleshooting.
Also this passed tidy so if I failed to python I'll need to fix tidy as well as this.
Source-Repo: https://github.com/servo/servo
Source-Revision: 3ed6c22e45df06bf381356b394d01493fc0322a2
--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : cf30cf007ef6e071b1852fbbd8b3b9f20b3f536d
Removes nsIDOMHTMLEmbedElement and all references. HTML elements are
now handled by WebIDL. With the deprecation of extensions, XPCOM
interfaces to HTML elements are no longer needed.
MozReview-Commit-ID: DI4XVvdgPDI
--HG--
extra : rebase_source : 74bd92619e3d1db04c3dd40ec3022474fe1d647c
Cameron McCormack
Hiroyuki Ikezoe
Bobby Holley
Nick Alexander
Gregory Szorc
Masatoshi Kimura
Manish Goregaokar
Tomislav Jovanovic
Jonathan Guillotte-Blouin
Matthew Noorenberghe
Jared Wein
Wes Kocher
Adam Gashlin
Bob Silverberg
Grigory Kruglov
flyingrub
Rob Wu
Dennis Schubert
Chenxia Liu
E. Dunham
Michael Kaply
Matt Brubeck
Kyle Machulis