Граф коммитов

13929 Коммитов

Автор SHA1 Сообщение Дата
Haik Aftandilian 70da961450 Bug 1431441 - Part 5 - Parameterize access to the windowserver in the Mac content sandbox policy r=Alex_Gaynor
Only allow access to "com.apple.windowserver.active" when the pref
"security.sandbox.content.mac.disconnect-windowserver" is set to true.

Depends on D6721

Differential Revision: https://phabricator.services.mozilla.com/D7357

--HG--
extra : moz-landing-system : lando
2018-10-02 19:43:06 +00:00
Haik Aftandilian 7977abcd65 Bug 1431441 - Part 4 - ASSERT the sandbox is already enabled r=Alex_Gaynor
When early initialization of the sandbox is enabled, assert that the sandbox has already been enabled in ContentProcess::Init().

Depends on D6720

Differential Revision: https://phabricator.services.mozilla.com/D6721

--HG--
extra : moz-landing-system : lando
2018-10-02 19:41:30 +00:00
Haik Aftandilian ef9150c083 Bug 1431441 - Part 3 - Start the Mac content sandbox earlier r=Alex_Gaynor
Pass sandbox parameters to content processes on the command
line allowing for early sandbox startup. Limited to Nightly
until confirmed to be stable and ready to ride the trains.

Enable early sandbox startup by default on Nightly and use
pref "security.sandbox.content.mac.earlyinit" to disable
early startup for debugging purposes.

Once early startup is stable, the original sandbox startup
code can be removed.

Depends on D6719

Differential Revision: https://phabricator.services.mozilla.com/D6720

--HG--
extra : moz-landing-system : lando
2018-10-02 20:29:46 +00:00
Haik Aftandilian a99a3fe58d Bug 1431441 - Part 2 - Remove rules for APP_BINARY_PATH and APP_DIR Mac sandbox parameters r=Alex_Gaynor
Simplify the content sandbox policy by removing APP_BINARY_PATH and APP_DIR Mac sandbox parameters and their associated rules in the policy. Keep APP_PATH which is a parent directory of APP_BINARY_PATH and APP_DIR.

Depends on D6717

Differential Revision: https://phabricator.services.mozilla.com/D6719

--HG--
extra : moz-landing-system : lando
2018-10-02 19:40:46 +00:00
Daniel Varga 2e77181988 Merge mozilla-central to autoland. a=merge on a CLOSED TREE
--HG--
extra : rebase_source : 62429b85fcd6af71ca898dc36c3f0f4a2c4ee5ae
2018-10-03 00:49:53 +03:00
Dana Keeler 9c05614e43 bug 1493427 - use the docShell to call OnSecurityChange in nsSecureBrowserUIImpl::OnLocationChange r=Gijs
When navigating to an about: page that doesn't exist (e.g.
"about:somethingthatdoesnotexist"), the docShell will call
nsSecureBrowserUIImpl::OnLocationChange with a request that is null.
Consequently, we can't use that to QueryInterface to a nsISecurityEventSink to
call OnSecurityChange. The previous implementation would use the prior
request's nsISecurityEventSink, which was a bug but luckily this produced the
correct behavior. Since the original docShell the nsSecureBrowserUIImpl was
initialized with is what needs to be notified, we can just QueryInterface that
to an nsISecurityEventSink and call OnSecurityChange directly instead.

Differential Revision: https://phabricator.services.mozilla.com/D6951

--HG--
rename : browser/base/content/test/siteIdentity/browser_tls_handshake_failure.js => browser/base/content/test/siteIdentity/browser_navigation_failures.js
extra : moz-landing-system : lando
2018-10-02 20:26:40 +00:00
Gurzau Raul ede1418858 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-02 19:08:39 +03:00
Andrew McCreight 837f0af066 Bug 1493737 - Fix many trivial calls to do_QueryInterface r=smaug
If class A is derived from class B, then an instance of class A can be
converted to B via a static cast, so a slower QI is not needed.

Differential Revision: https://phabricator.services.mozilla.com/D6861

--HG--
extra : moz-landing-system : lando
2018-10-01 21:38:01 +00:00
Brindusan Cristian 9b5034705f Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-10-02 01:04:29 +03:00
Brindusan Cristian f8087305eb Merge inbound to mozilla-central. a=merge 2018-10-02 00:55:00 +03:00
Dana Keeler 0c4b612622 Bug 1493788 - remove other mozilla-specific dependencies from certificate transparency implementation r=jcj
This patch removes the remaining mozilla-specific dependencies from the
certificate transparency implementation.

Depends on D6845

Differential Revision: https://phabricator.services.mozilla.com/D6846

--HG--
extra : moz-landing-system : lando
2018-10-01 16:20:57 +00:00
Dana Keeler 1661adeb86 Bug 1493788 - convert mozilla::Vector to std::vector in certificate transparency implementation r=jcj
In order to make our certificate transparency implementation standalone, we
have to remove mozilla-specific dependencies such as mozilla::Vector.

Depends on D6844

Differential Revision: https://phabricator.services.mozilla.com/D6845

--HG--
extra : moz-landing-system : lando
2018-10-01 20:27:13 +00:00
Dana Keeler 24a8ad1851 Bug 1493788 - move certificate/binary transparency implementation to its own directory r=jcj
Our current certificate transparency implementation (and the start of the binary
transparency implementation) can almost be used by itself as a standalone
library (for comparison, mozilla::pkix already has this property, as evidenced
by the "Library('mozillapkix')" line in security/pkix/moz.build and the
"'mozillapkix'" line in the USE_LIBS section of
security/manager/ssl/tests/unit/tlsserver/cmd/moz.build).

These changes make this code re-usable as a library so that we'll be able to use
it in the updater to verify binary/certificate transparency information.

This first patch simply moves the code to its own directory.

Differential Revision: https://phabricator.services.mozilla.com/D6844

--HG--
rename : security/certverifier/BTInclusionProof.h => security/ct/BTInclusionProof.h
rename : security/certverifier/BTVerifier.cpp => security/ct/BTVerifier.cpp
rename : security/certverifier/BTVerifier.h => security/ct/BTVerifier.h
rename : security/certverifier/Buffer.cpp => security/ct/Buffer.cpp
rename : security/certverifier/Buffer.h => security/ct/Buffer.h
rename : security/certverifier/CTDiversityPolicy.cpp => security/ct/CTDiversityPolicy.cpp
rename : security/certverifier/CTDiversityPolicy.h => security/ct/CTDiversityPolicy.h
rename : security/certverifier/CTKnownLogs.h => security/ct/CTKnownLogs.h
rename : security/certverifier/CTLog.h => security/ct/CTLog.h
rename : security/certverifier/CTLogVerifier.cpp => security/ct/CTLogVerifier.cpp
rename : security/certverifier/CTLogVerifier.h => security/ct/CTLogVerifier.h
rename : security/certverifier/CTObjectsExtractor.cpp => security/ct/CTObjectsExtractor.cpp
rename : security/certverifier/CTObjectsExtractor.h => security/ct/CTObjectsExtractor.h
rename : security/certverifier/CTPolicyEnforcer.cpp => security/ct/CTPolicyEnforcer.cpp
rename : security/certverifier/CTPolicyEnforcer.h => security/ct/CTPolicyEnforcer.h
rename : security/certverifier/CTSerialization.cpp => security/ct/CTSerialization.cpp
rename : security/certverifier/CTSerialization.h => security/ct/CTSerialization.h
rename : security/certverifier/CTUtils.h => security/ct/CTUtils.h
rename : security/certverifier/CTVerifyResult.cpp => security/ct/CTVerifyResult.cpp
rename : security/certverifier/CTVerifyResult.h => security/ct/CTVerifyResult.h
rename : security/certverifier/MultiLogCTVerifier.cpp => security/ct/MultiLogCTVerifier.cpp
rename : security/certverifier/MultiLogCTVerifier.h => security/ct/MultiLogCTVerifier.h
rename : security/certverifier/SignedCertificateTimestamp.cpp => security/ct/SignedCertificateTimestamp.cpp
rename : security/certverifier/SignedCertificateTimestamp.h => security/ct/SignedCertificateTimestamp.h
rename : security/certverifier/SignedTreeHead.h => security/ct/SignedTreeHead.h
rename : security/certverifier/moz.build => security/ct/moz.build
rename : security/certverifier/tests/gtest/BTSerializationTest.cpp => security/ct/tests/gtest/BTSerializationTest.cpp
rename : security/certverifier/tests/gtest/CTDiversityPolicyTest.cpp => security/ct/tests/gtest/CTDiversityPolicyTest.cpp
rename : security/certverifier/tests/gtest/CTLogVerifierTest.cpp => security/ct/tests/gtest/CTLogVerifierTest.cpp
rename : security/certverifier/tests/gtest/CTObjectsExtractorTest.cpp => security/ct/tests/gtest/CTObjectsExtractorTest.cpp
rename : security/certverifier/tests/gtest/CTPolicyEnforcerTest.cpp => security/ct/tests/gtest/CTPolicyEnforcerTest.cpp
rename : security/certverifier/tests/gtest/CTSerializationTest.cpp => security/ct/tests/gtest/CTSerializationTest.cpp
rename : security/certverifier/tests/gtest/CTTestUtils.cpp => security/ct/tests/gtest/CTTestUtils.cpp
rename : security/certverifier/tests/gtest/CTTestUtils.h => security/ct/tests/gtest/CTTestUtils.h
rename : security/certverifier/tests/gtest/MultiLogCTVerifierTest.cpp => security/ct/tests/gtest/MultiLogCTVerifierTest.cpp
rename : security/certverifier/tests/gtest/moz.build => security/ct/tests/gtest/moz.build
extra : moz-landing-system : lando
2018-10-01 16:20:41 +00:00
Julien Vehent 92ca2d1e89 Bug 1494431 - Pin *.firefox.com to mozilla services whitelisted roots r=keeler,jcj
Put the entire *.firefox.com domain in the list of sites covered by the mozilla services whitelisted roots, which currently include Digicert and Let's Encrypt.

Differential Revision: https://phabricator.services.mozilla.com/D7219

--HG--
extra : moz-landing-system : lando
2018-09-28 23:37:51 +00:00
ffxbld 428aa0f16f No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D7276

--HG--
extra : moz-landing-system : lando
2018-10-01 12:34:47 +00:00
trisha 565dcd8412 Bug 1484761 - Change "security certificates" to "certificates" on the new cert error pages r=johannh
--HG--
extra : rebase_source : a48cbe38cbbaa7d5c0190af83dcc54fd37876526
2018-09-27 17:04:41 +08:00
EKR 030f8b7c79 Bug 1495120 - Wire up ESNI r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D7221

--HG--
extra : source : d2edbb87f3d283ab2c2fb6f8ad3408f792a6bd27
2018-09-28 22:37:20 +00:00
J.C. Jones b5cc135a82 Bug 1488622 - land NSS 94bcc2706b98 UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : 761520ca901dabbf0a908a886732155d0d40d468
2018-10-01 07:44:32 -07:00
arthur.iakab f0410f8d4b Merge mozilla-central to mozilla-inbound 2018-09-29 01:00:35 +03:00
Ehsan Akhgari 5f0be07390 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 14:46:02 -04:00
Ehsan Akhgari 355485be9f Bug 1493563 - Part 4: Present the old state and the content blocking log to the security event sink; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6594
2018-09-28 14:46:02 -04:00
Noemi Erli 4419e20e14 Backed out 12 changesets (bug 1493563) for failures in test_css-logic-getCssPath.html CLOSED TREE
Backed out changeset d2e83655082f (bug 1493563)
Backed out changeset 1ce58f004593 (bug 1493563)
Backed out changeset 344298c73ee7 (bug 1493563)
Backed out changeset 02b8b073f7d7 (bug 1493563)
Backed out changeset 3ef707008502 (bug 1493563)
Backed out changeset bb2720a401fe (bug 1493563)
Backed out changeset ce0211be57a1 (bug 1493563)
Backed out changeset 83d6c2bf8dc6 (bug 1493563)
Backed out changeset 1844af4cc25b (bug 1493563)
Backed out changeset c8ab17addb7a (bug 1493563)
Backed out changeset a1ff0cd62563 (bug 1493563)
Backed out changeset 932b41e211e0 (bug 1493563)
2018-09-28 21:31:18 +03:00
J.C. Jones 0708336637 Bug 1488622 - land NSS a706ba3c4fa9 UPGRADE_NSS_RELEASE, r=me
--HG--
rename : security/nss/automation/taskcluster/docker-clang-3.9/bin/checkout.sh => security/nss/automation/taskcluster/docker-builds/bin/checkout.sh
rename : security/nss/automation/taskcluster/docker-clang-3.9/bin/checkout.sh => security/nss/automation/taskcluster/docker-clang-format/bin/checkout.sh
rename : security/nss/automation/taskcluster/docker-clang-3.9/bin/checkout.sh => security/nss/automation/taskcluster/docker-fuzz32/bin/checkout.sh
rename : security/nss/automation/taskcluster/docker-clang-3.9/bin/checkout.sh => security/nss/automation/taskcluster/docker-interop/bin/checkout.sh
extra : rebase_source : 2ba3e1b2bfe96388e73e8bbf4ce0b37c530270a1
2018-09-28 09:17:37 -07:00
Ehsan Akhgari f0108e78c2 Bug 1493563 - Part 5: Present the old state and the content blocking log to the web progress listeners; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6595
2018-09-28 13:24:41 -04:00
Ehsan Akhgari 4895fd4963 Bug 1493563 - Part 4: Present the old state and the content blocking log to the security event sink; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D6594
2018-09-28 13:24:40 -04:00
Dana Keeler 6004dbc02b bug 1492188 - avoid using the directory service off the main thread when loading loadable roots r=jcj
Differential Revision: https://phabricator.services.mozilla.com/D6692

--HG--
extra : moz-landing-system : lando
2018-09-27 22:45:56 +00:00
Coroiu Cristina 62682de0ba Backed out changeset 39762ef5d56e (bug 1493427) for frequent talos chrome failures a=backout
--HG--
rename : browser/base/content/test/siteIdentity/browser_navigation_failures.js => browser/base/content/test/siteIdentity/browser_tls_handshake_failure.js
2018-09-28 07:29:39 +03:00
Coroiu Cristina 71988c7b7e Merge inbound to mozilla-central a=merge 2018-09-28 00:36:46 +03:00
Dana Keeler b3b9e414bc bug 1493427 - use the docShell to call OnSecurityChange in nsSecureBrowserUIImpl::OnLocationChange r=Gijs
When navigating to an about: page that doesn't exist (e.g.
"about:somethingthatdoesnotexist"), the docShell will call
nsSecureBrowserUIImpl::OnLocationChange with a request that is null.
Consequently, we can't use that to QueryInterface to a nsISecurityEventSink to
call OnSecurityChange. The previous implementation would use the prior
request's nsISecurityEventSink, which was a bug but luckily this produced the
correct behavior. Since the original docShell the nsSecureBrowserUIImpl was
initialized with is what needs to be notified, we can just QueryInterface that
to an nsISecurityEventSink and call OnSecurityChange directly instead.

Differential Revision: https://phabricator.services.mozilla.com/D6951

--HG--
rename : browser/base/content/test/siteIdentity/browser_tls_handshake_failure.js => browser/base/content/test/siteIdentity/browser_navigation_failures.js
extra : moz-landing-system : lando
2018-09-27 17:26:00 +00:00
ffxbld dbf253a4b5 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D7081

--HG--
extra : moz-landing-system : lando
2018-09-27 12:07:07 +00:00
Boris Zbarsky 891631d98c Bug 1494524. Stop using the same function for both webidl and xpidl selectionChanged on treeviews. r=mccr8 2018-09-27 13:46:25 -04:00
shindli 14c2437eec Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-27 00:57:23 +03:00
Gijs Kruitbosch 76afb51661 Bug 1493655 - make nsISecureBrowserUI initialize from a docshell instead of a window, r=keeler,nika
This also removes the (afaict, unused) stub implementation from TabParent. The netwerk header
inclusions were necessary because those files included TabParent.h and through it,
nsISecureBrowserUI, but now TabParent.h no longer does that.

Differential Revision: https://phabricator.services.mozilla.com/D6829

--HG--
extra : moz-landing-system : lando
2018-09-26 17:48:38 +00:00
Mark Goodwin 41b314b255 Bug 1492414 - Modify CertBlocklist interface to a form that should work with Rust XPCom bindings r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D6260

--HG--
extra : moz-landing-system : lando
2018-09-21 13:10:40 +00:00
Andrew McCreight de17b449c6 Bug 1494079 - Clean up some code in ShowProtectedAuthPrompt r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D6852

--HG--
extra : moz-landing-system : lando
2018-09-25 22:54:37 +00:00
Haik Aftandilian f2fa2012f9 Bug 1491940 - [Mac] Allow Adobe DRM content to play with the Mac Flash sandbox r=Alex_Gaynor
Add an whitelisted write-access path regex to the Flash plugin sandbox.

Differential Revision: https://phabricator.services.mozilla.com/D6679

--HG--
extra : moz-landing-system : lando
2018-09-24 17:22:49 +00:00
ffxbld 78dd007268 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D6652

--HG--
extra : moz-landing-system : lando
2018-09-24 12:05:01 +00:00
J.C. Jones 5110974f9e Bug 1488622 - land NSS 2c85f81f9b5e UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : ac309461f5909fcf7b617bc768d73c0cd7911385
2018-09-22 17:04:35 -07:00
Dragana Damjanovic 9cadc84486 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
--HG--
extra : rebase_source : be79870960953ef9535ccb6a440515ec4a8232d5
extra : histedit_source : 8096ab2eaf246cbbeb97bace0531b86b8c69ff66
2018-09-22 23:54:11 +03:00
Gurzau Raul 07d30b811f Backed out changeset dc225279994a (bug 1473736) for web platform leaks 2018-09-21 04:30:10 +03:00
Dana Keeler 984d5aecee bug 1492424 - check if the TLS handshake failed in nsSecureBrowserUIImpl r=Gijs
The site identity security indicator machinery treats connections where the TLS
handshake failed as insecure (also referred to as "unknown identity"). Before
bug 1468222, such cases were easily detectable as the SSLStatus field of the
relevant nsITransportSecurityInfo would be null. When we merged nsISSLStatus
into nsITransportSecurityInfo, we didn't take this differentiation into account.
This patch brings back the prior behavior by checking if the securityInfo's
securityState indicates that the handshake failed (i.e. it is
STATE_IS_INSECURE).

Differential Revision: https://phabricator.services.mozilla.com/D6316

--HG--
extra : moz-landing-system : lando
2018-09-21 00:17:47 +00:00
Dragana Damjanovic 70e0646d75 Bug 1473736 - Implement necko part of ESNI r=mak,kmag,mcmanus
Implement necko part of ESNI

Differential Revision: https://phabricator.services.mozilla.com/D2716

--HG--
extra : moz-landing-system : lando
2018-09-20 20:53:28 +00:00
Andreea Pavel f5f6c0b588 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-21 00:54:47 +03:00
Nathan Froyd e7b3b3140d Bug 1415980 - make hash keys movable and not copyable; r=erahm
Everything that goes in a PLDHashtable (and its derivatives, like
nsTHashtable) needs to inherit from PLDHashEntryHdr. But through a lack
of enforcement, copy constructors for these derived classes didn't
explicitly invoke the copy constructor for PLDHashEntryHdr (and the
compiler didn't invoke the copy constructor for us). Instead,
PLDHashTable explicitly copied around the bits that the copy constructor
would have.

The current setup has two problems:

1) Derived classes should be using move construction, not copy
   construction, since anything that's shuffling hash table keys/entries
   around will be using move construction.

2) Derived classes should take responsibility for transferring bits of
   superclass state around, and not rely on something else to handle that.

The second point is not a huge problem for PLDHashTable (PLDHashTable
only has to copy PLDHashEntryHdr's bits in a single place), but future
hash table implementations that might move entries around more
aggressively would have to insert compensation code all over the
place. Additionally, if moving entries is implemented via memcpy (which
is quite common), PLDHashTable copying around bits *again* is
inefficient.

Let's fix all these problems in one go, by:

1) Explicitly declaring the set of constructors that PLDHashEntryHdr
   implements (and does not implement). In particular, the copy
   constructor is deleted, so any derived classes that attempt to make
   themselves copyable will be detected at compile time: the compiler
   will complain that the superclass type is not copyable.

This change on its own will result in many compiler errors, so...

2) Change any derived classes to implement move constructors instead of
   copy constructors. Note that some of these move constructors are,
   strictly speaking, unnecessary, since the relevant classes are moved
   via memcpy in nsTHashtable and its derivatives.
2018-09-20 11:20:36 -04:00
ffxbld 1263cc5298 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D6386

--HG--
extra : moz-landing-system : lando
2018-09-20 12:47:19 +00:00
Bogdan Tara 86023d88c4 Merge inbound to mozilla-central. a=merge 2018-09-20 07:13:05 +03:00
J.C. Jones a456c6d9a9 Bug 1488622 - land NSS fe738aae0bcc UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : c5e74447ceed1014ab1a3bb6abbdc28ac12fa11a
2018-09-19 09:43:03 -07:00
Bogdan Tara 9f17cab93a Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-20 01:03:35 +03:00
Dana Keeler d13840ed4c bug 1490982 - filter out OnLocationChange events that aren't top-level in nsSecureBrowserUIImpl r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D5920

--HG--
extra : moz-landing-system : lando
2018-09-19 19:57:37 +00:00
Noemi Erli efdd6a208a Backed out changeset 7aa742bff8fb (bug 1473736) for xpcshell failures and bc failures in browser_urlbarSearchSingleWordNotification.js 2018-09-18 22:07:58 +03:00
Dragana Damjanovic f000a5b4b0 Bug 1473736 - Implement necko part of ESNI r=mcmanus
Implement necko part of ESNI

Differential Revision: https://phabricator.services.mozilla.com/D2716

--HG--
extra : moz-landing-system : lando
2018-09-17 23:08:14 +00:00
Bogdan Tara 7ebba39407 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-18 01:02:05 +03:00
Dana Keeler 0f23e1458f bug 1488593 - move family safety root detection to background thread r=dipen,jcj
A previous patch in this bug made the incorrect assumption that we had disabled
the family safety root detection/importing feature by default. In reality, we
enabled it by default in bug 1282871.

In bug 1487258 we moved enterprise root loading to a background thread so as to
not block the main thread. This patch does the same with the family safety
feature.

Differential Revision: https://phabricator.services.mozilla.com/D5484

--HG--
extra : moz-landing-system : lando
2018-09-17 15:38:43 +00:00
Jed Davis 2fcf5c7252 Bug 1489735 - Quietly deny sched_setaffinity in content process sandbox r=gcp
Differential Revision: https://phabricator.services.mozilla.com/D5908

--HG--
extra : moz-landing-system : lando
2018-09-17 16:43:52 +00:00
Gurzau Raul c03510c273 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-09-17 19:48:54 +03:00
Masatoshi Kimura cddaaa8ed5 Bug 1491849 - Disable C5045 only if optimization is disabled. r=dmajor
I also changed security/certverifier/moz.build a bit while I am here:
* Using '-Xclang' to pass through '-Wall' on clang-cl.
* Now clang-cl will take clang/gcc path because most '-wd****' options have no
  effect on clang-cl. '-wd4010' will have an effect, but we already have the
  corresponding clang/gcc option ('-Wno-unused-parameter').

--HG--
extra : source : df566a1bd9087cc0bfc03fe19fd9d21bf58f5d9c
2018-09-15 21:20:32 +09:00
ffxbld 8c2208f569 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D6021

--HG--
extra : moz-landing-system : lando
2018-09-17 13:15:55 +00:00
Ehsan Akhgari fa81a39327 Bug 1491558 - Remove the XPCOM registration for nsThreadPool; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D5943
2018-09-15 12:13:57 -04:00
Dana Keeler 364a010e05 bug 748809 - remove nsIAssociatedContentSecurity and nsISecurityInfoProvider r=mayhemer,jrmuizel
nsIAssociatedContentSecurity and nsISecurityInfoProvider are unused as of
bug 832834, so this patch removes them.

Differential Revision: https://phabricator.services.mozilla.com/D5693

--HG--
extra : moz-landing-system : lando
2018-09-13 17:13:43 +00:00
ffxbld 1bd8340b0a No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D5758

--HG--
extra : moz-landing-system : lando
2018-09-13 12:14:37 +00:00
Dana Keeler fae63f9b28 Bug 1487228 - (2/2) avoid holding CERTCertList instances long-term in nsNSSCertList r=jcj
Each instance of CERTCertList creates a PLArena with a chunk size of 2048 bytes,
but only needs space for 3 pointers per certificate in the list. The majority of
the time Gecko uses CERTCertList, we'll store ~3 certificates (although in some
cases we do store a few hundred, such as in tests or the certificate manager).
This is fairly inefficient. This patch starts the process of avoiding using
CERTCertList in Gecko by converting nsNSSCertList (i.e. nsIX509CertList) (as
well as nsNSSCertListEnumerator) to use a more efficient data structure to hold
references to certificates long-term. Future follow-up patches could (and
should) update certificate verification APIs in PSM to avoid CERTCertList as
well.

Depends on D5096

Differential Revision: https://phabricator.services.mozilla.com/D5097

--HG--
extra : moz-landing-system : lando
2018-09-12 18:14:03 +00:00
Dana Keeler 8f21632c33 Bug 1487228 - (1/2) remove nsIX509CertList.getRawCertList r=jcj
nsIX509CertList.getRawCertList is only used once and doesn't provide
particularly unique functionality (its one use can easily be re-worked in terms
of other APIs). Removing this API will ease refactoring work to avoid holding
long-lived references to CERTCertList instances in nsNSSCertList.

Differential Revision: https://phabricator.services.mozilla.com/D5096

--HG--
extra : moz-landing-system : lando
2018-09-12 17:54:45 +00:00
Bogdan Tara a23c3959b6 Merge inbound to mozilla-central. a=merge 2018-09-12 06:22:14 +03:00
Martin Thomson d1614a402d Bug 1487279 - Pref to control TLS downgrade check, r=keeler
Background here is that we are disabling a piece of the downgrade protection in TLS 1.3 and we want to turn it on.  We don't know if that is safe, so a pref (and an associated experiment) seems prudent.  This is that pref.

Differential Revision: https://phabricator.services.mozilla.com/D4629

--HG--
extra : moz-landing-system : lando
2018-09-11 18:01:50 +00:00
Ted Mielczarek d59bc31677 Bug 1399877 - globally define MOZ_DLL_PREFIX/MOZ_DLL_SUFFIX; r=gps
Several source files use DLL_PREFIX/DLL_SUFFIX defines, and they all set
them in moz.build using `DEFINES`.  This is problematic for the WSL
build because the quoting gets lost somewhere between bash and cl.exe.
We cannot simply set them globally in moz.configure because their
stringified definitions would conflict with the `set_config` of
DLL_PREFIX/DLL_SUFFIX.  Therefore, we globally define
MOZ_DLL_PREFIX/MOZ_DLL_SUFFIX and change all define-related uses of
DLL_PREFIX/DLL_SUFFIX to use their MOZ-equivalents instead.
2018-09-11 13:31:20 -04:00
Cosmin Sabou de7676288a Merge mozilla-inbound to mozilla-central. a=merge 2018-09-11 13:06:37 +03:00
Dipen Patel aeed887ff8 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704

--HG--
extra : moz-landing-system : lando
2018-09-11 00:07:30 +00:00
ffxbld 61242498b1 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D5411

--HG--
extra : moz-landing-system : lando
2018-09-10 12:53:41 +00:00
Daniel Varga 1539df295b Merge mozilla-inbound to mozilla-central a=merge 2018-09-08 06:53:43 +03:00
Csoregi Natalia 0400fe7b57 Backed out changeset bd8baf88f373 (bug 1468222) for test_security-info-parser.js failures. CLOSED TREE 2018-09-08 03:16:25 +03:00
Dipen Patel 0679e09a9a Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704

--HG--
extra : moz-landing-system : lando
2018-09-07 22:50:17 +00:00
Mike Hommey 32627430f6 Bug 1489363 - Replace some string.Append* with AppendLiteral. r=froydnj
Depends on D5224

Differential Revision: https://phabricator.services.mozilla.com/D5225

--HG--
extra : moz-landing-system : lando
2018-09-07 22:12:04 +00:00
Bogdan Tara 30c8b1bee3 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-09-07 00:59:25 +03:00
ffxbld d5e21d1dc3 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D5141

--HG--
extra : moz-landing-system : lando
2018-09-06 12:40:37 +00:00
Dana Keeler 36505cb883 bug 1488593 - disable family safety detection by default r=jcj
As of bug 1346297, we don't collect telemetry for the family safety root
feature. At this point, it makes the most sense to disable the entire feature by
default.

Differential Revision: https://phabricator.services.mozilla.com/D4994

--HG--
extra : moz-landing-system : lando
2018-09-05 23:58:21 +00:00
Tiberius Oros a325c6ef11 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-09-06 01:27:49 +03:00
Andreea Pavel 36c5e5b56a Backed out changeset df1f14eb13ef (bug 1488593) for build bustages on a CLOSED TREE 2018-09-06 01:17:56 +03:00
Dana Keeler 8f28b1fc59 bug 1488593 - disable family safety detection by default r=jcj
As of bug 1346297, we don't collect telemetry for the family safety root
feature. At this point, it makes the most sense to disable the entire feature by
default.

Differential Revision: https://phabricator.services.mozilla.com/D4994

--HG--
extra : moz-landing-system : lando
2018-09-05 20:05:11 +00:00
Dana Keeler 3c7bb27e9f bug 1487258 - load enterprise roots on a background at startup r=jcj
Loading enterprise roots could potentially take a while, so we certainly
shouldn't do it on the main thread at startup. Note that this doesn't address
the case where a user enables the feature while Firefox is running. This isn't
great but since it's an about:config preference rather than a first-class
preference exposed in about:preferences, we can probably get away with it for
now.

Differential Revision: https://phabricator.services.mozilla.com/D4708

--HG--
extra : moz-landing-system : lando
2018-09-05 17:15:53 +00:00
J.C. Jones 3def42e421 Bug 1488622 - land NSS 229a3a57f42a UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : 4f7f3eaabf04e02d91d483158c9220929a316da6
2018-09-05 08:20:33 -07:00
Dana Keeler 8b93bfbb06 bug 832834 - reimplement nsSecureBrowserUIImpl r=franziskus,Felipe
It turns out nsSecureBrowserUIImpl is considerably more complicated than it
needs to be. This patch reimplements it in terms of OnLocationChange only, which
is all it needs to produce the same behavior as before.

Differential Revision: https://phabricator.services.mozilla.com/D3548

--HG--
extra : moz-landing-system : lando
2018-09-05 17:12:36 +00:00
Jonathan Kingston 2ce3b8373f Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 3e184da8273decac0f3e7d88be89125a2a027588
extra : intermediate-source : ddea69395fbca528529f4491bc8ea7c701ff45b4
2018-08-29 15:48:52 +01:00
Brindusan Cristian 1db0587c0e Backed out 10 changesets (bug 1485305) for browser-chrome failures on docshell/test/browser/browser_loadURI.js. CLOSED TREE
Backed out changeset 50439ec01661 (bug 1485305)
Backed out changeset a05e40ef7215 (bug 1485305)
Backed out changeset c99b97b4348b (bug 1485305)
Backed out changeset 75220b2f6669 (bug 1485305)
Backed out changeset e698f2fc1c1a (bug 1485305)
Backed out changeset acce14683c13 (bug 1485305)
Backed out changeset 323773a395cc (bug 1485305)
Backed out changeset 1b74152cabc1 (bug 1485305)
Backed out changeset 4b5c9d5929fc (bug 1485305)
Backed out changeset 238d92348159 (bug 1485305)
2018-09-19 18:47:27 +03:00
Jonathan Kingston c161024465 Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 5a82993174e363a1e06cd35fcec98fddd6250d64
2018-08-29 15:48:52 +01:00
Kris Maglione 1c20e8cbbb Bug 1486147: Part 2 - Update JS string enumerator callers to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D4270

--HG--
extra : rebase_source : 2adadcc8e51a7bce1da02f4bee1333b77bfa9944
extra : histedit_source : 9df920fd186f8c96a5d8b9cbff53ea9529f26ee0
2018-08-24 16:22:40 -07:00
Ehsan Akhgari 8ee774da84 Bug 1487396 - Part 1: Enable the secure browser UI object to keep track of the newly added content blocking states for each document; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D4809
2018-09-04 14:20:22 -04:00
shindli fd77c051cb Backed out changeset 99e8a7cd7726 (bug 1484761) as requested by the developer on IRC on a CLOSED TREE 2018-09-04 09:09:49 +03:00
Daniel Varga f46d581d52 Merge mozilla-inbound to mozilla-central. a=merge 2018-09-04 00:54:07 +03:00
ffxbld 9e951cf226 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D4852

--HG--
extra : moz-landing-system : lando
2018-09-03 13:16:32 +00:00
trisha 88400e06ef Bug 1484761 - Change "security certificates" to "certificates" on the new cert error pages r=johannh 2018-08-31 19:12:02 +05:30
Kai Engert 05d5185f12 Bug 1470914, NSS_3_39_RTM, no code changes, only version number, r=me
UPGRADE_NSS_RELEASE
DONTBUILD
2018-08-31 15:41:00 +02:00
Dave Townsend e63bb1c465 Bug 1487246: Enable the eslint no-sequences rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D4681

--HG--
extra : rebase_source : ae253571d7d47c4a113a98a8b7c29bf712a0d764
2018-08-29 16:15:33 -07:00
J.C. Jones 0f1a889215 Bug 1488622 - cleanup incorrectly-landed .orig files UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : 900e72219bf53a84f136f482a25fefd280a6b13b
2018-09-07 11:49:21 -07:00
arthur.iakab d2e647e133 Backed out 10 changesets (bug 1485305)for failing browser chrome tests on browser_loadDisallowInherit.js
Backed out changeset 138b8596a9cd (bug 1485305)
Backed out changeset d9f04aeeeef7 (bug 1485305)
Backed out changeset cd063d8afe4e (bug 1485305)
Backed out changeset 2f8a5a03ccb5 (bug 1485305)
Backed out changeset 8085d1eefd7c (bug 1485305)
Backed out changeset 3aaccb374a59 (bug 1485305)
Backed out changeset 3a111e9e5c9c (bug 1485305)
Backed out changeset 61aa1cfb0b01 (bug 1485305)
Backed out changeset bca973d90acc (bug 1485305)
Backed out changeset 4eb33bf25d6f (bug 1485305)
2018-09-18 20:30:07 +03:00
Jonathan Kingston 23bfc5f0ef Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : edc4d8898d26a199fb230489a644b88c2fd8f739
2018-08-29 15:48:52 +01:00
Tiberius Oros 3235f6720f Backed out 10 changesets (bug 1485305) for failures at browser/content/browser.js on a CLOSED TREE
Backed out changeset 63c50fd60ae4 (bug 1485305)
Backed out changeset bf0f2adb765e (bug 1485305)
Backed out changeset 721871bb64f1 (bug 1485305)
Backed out changeset e9da73786c5f (bug 1485305)
Backed out changeset e02038177b6b (bug 1485305)
Backed out changeset 35bd32f99f60 (bug 1485305)
Backed out changeset f40900bf8621 (bug 1485305)
Backed out changeset 03632075ac2c (bug 1485305)
Backed out changeset 2fee48378f73 (bug 1485305)
Backed out changeset 6263695b3cb8 (bug 1485305)
2018-09-18 14:46:54 +03:00
Jonathan Kingston f1ecf040f7 Bug 1485305 - misc Ensure loadURI always passes a triggeringPrincipal() r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D4560

--HG--
extra : source : 5911bc1f2f1fb6d576fba38af242f9d8cb412b16
2018-08-29 15:48:52 +01:00
Kris Maglione 74481e8af4 Bug 1479035: Part 1 - Don't create event queues for stub nsThread wrappers. r=froydnj
Most of the times when we automatically create nsThread wrappers for threads
that don't already have them, we don't actually need the event targets, since
those threads don't run XPCOM event loops. Aside from wasting memory, actually
creating these event loops can lead to leaks if a thread tries to dispatch a
runnable to the queue which creates a reference cycle with the thread.

Not creating the event queues for threads that don't actually need them helps
avoid those foot guns, and also makes it easier to figure out which treads
actually run XPCOM event loops.

MozReview-Commit-ID: Arck4VQqdne

--HG--
extra : source : a03a61d6d724503c3b7c5e31fe32ced1f5d1c219
extra : intermediate-source : 5152af6ab3e399216ef6db8f060c257b2ffbd330
extra : histedit_source : ef06000344416e0919f536d5720fa979d2d29c66%2C4671676b613dc3e3ec762edf5d72a2ffbe6fca3f
2018-07-27 15:13:12 -07:00
Narcis Beleuzu 72f96acd7b Backed out 2 changesets (bug 1479035) for assertion failure: mEvents. CLOSED TREE
Backed out changeset 89a0c0874d40 (bug 1479035)
Backed out changeset 5152af6ab3e3 (bug 1479035)
2018-09-26 23:40:13 +03:00
Kris Maglione 81eb50cf31 Bug 1479035: Part 1 - Don't create event queues for stub nsThread wrappers. r=froydnj
Most of the times when we automatically create nsThread wrappers for threads
that don't already have them, we don't actually need the event targets, since
those threads don't run XPCOM event loops. Aside from wasting memory, actually
creating these event loops can lead to leaks if a thread tries to dispatch a
runnable to the queue which creates a reference cycle with the thread.

Not creating the event queues for threads that don't actually need them helps
avoid those foot guns, and also makes it easier to figure out which treads
actually run XPCOM event loops.

MozReview-Commit-ID: Arck4VQqdne

--HG--
extra : rebase_source : fcf8fa50e748c4b54c3bb1997575d9ffd4cbaae1
extra : source : a03a61d6d724503c3b7c5e31fe32ced1f5d1c219
2018-07-27 15:13:12 -07:00
Dana Keeler 1d12fc8a92 bug 1487517 - un-do ciphersuite hiding from bug 1279479 and bug 1316300 r=mt
In bug 1279479 and bug 1316300 we hid some ciphersuites from TLS 1.3
handshakes, assuming we would fall back to TLS 1.2 if the peer needed them.
However, as of bug 1479501, we don't fall back by default, so this just means
we can't negotiate these ciphersuites. This patch un-hides these ciphersuites
from the TLS 1.3 handshake.

Differential Revision: https://phabricator.services.mozilla.com/D4725

--HG--
extra : moz-landing-system : lando
2018-08-31 00:18:36 +00:00
J.C. Jones f27f0bf4d1 Bug 1486838 - Enable EV treatment for Symantec/DigiCert cross signatures r=keeler
There is a late-breaking EV compatibility concern with cross signatures for EV
certificates:

Firefox's EV handling code always validates EV using the first EV policy OID
expressed in a certificate. For compatibility certificates issued under a cross-
signed root, if the first EV policy OID matches the original Symantec EV policy
OID, then Firefox will attempt to verify that the root CA matches the original
Symantec EV CA -- which it won't, as the root will be one of DigiCert's. Without
a patch, EV treatment will break.

This patch removes all EV policy OIDs for roots mentioned in TrustOverride-
SymantecData.inc, letting the moz::pkix algorithm pick other EV policy OIDs to
validate. I verified that I removed all affected OIDs using the BASH shell
commands:

$ cd security/certverifier
$ grep "CN=" TrustOverride-SymantecData.inc | sed -e 's/.*\(CN=.*\).*/\1/' |
  sort | uniq | while read r; do
    echo $r; grep "$r" ExtendedValidation.cpp;
  done

Reviewers should help me ensure that I did not remove any unexpected EV policy
OIDs.

Differential Revision: https://phabricator.services.mozilla.com/D4709

--HG--
extra : moz-landing-system : lando
2018-08-30 18:29:39 +00:00
Henri Sivonen 580f807a65 Bug 1487310 - Let XPCOM strings manage their own buffer in LossyUTF8ToUTF16(). r=keeler
This does not change the outward behavior of LossyUTF8ToUTF16(). Both
ToNewUnicode() and CopyASCIItoUTF16() convert from Latin1 to UTF-16.

MozReview-Commit-ID: 8SDgvoGaN4A

Differential Revision: https://phabricator.services.mozilla.com/D4639

--HG--
extra : moz-landing-system : lando
2018-08-30 17:29:51 +00:00
ffxbld 055f6b25a3 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D4660

--HG--
extra : moz-landing-system : lando
2018-08-30 12:53:09 +00:00
Alexander Surkov b27e40d606 Bug 1486674 - get rid of nsIDOMXULCheckboxElement, r=smaug 2018-08-30 08:17:11 +08:00
Narcis Beleuzu 3b0f157728 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-10-12 00:59:25 +03:00
Jim Mathies 494b622f3f Bug 1497643 - Enable Chromium sandbox option MITIGATION_IMAGE_LOAD_PREFER_SYS32 for content processes. r=bowen 2018-10-11 09:23:03 -05:00
J.C. Jones 80120fa560 Bug 1488622 - land NSS 8f6014565b91 UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : 1180690809ff920138698dd60c6c9177fa8d4331
2018-09-06 10:42:40 -07:00
Nicholas Nethercote e51afbee7e Bug 1486690 - Remove unnecessary checks after moz_xrealloc() calls. r=glandium
--HG--
extra : rebase_source : c036680008cef1f87ed94700f9146022ce879e53
2018-08-28 15:56:23 +10:00
Nicholas Nethercote ac5efebb4b Bug 1486690 - Remove unnecessary checks after moz_xmalloc() calls. r=glandium
There are surprisingly many of them.

(Plus a couple of unnecessary checks after `new` calls that were nearby.)

--HG--
extra : rebase_source : 47b6d5d7c5c99b1b50b396daf7a3b67abfd74fc1
2018-08-28 15:56:01 +10:00
Kai Engert e699c5e39a Bug 1470914, NSS_3_39_BETA2, r=me
UPGRADE_NSS_RELEASE

--HG--
extra : amend_source : fd3d0d2da3b2c64e41ae8c15b1b203479eef7e04
2018-08-28 16:18:25 +02:00
ffxbld 73e4fdc8f6 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D4325

--HG--
extra : moz-landing-system : lando
2018-08-27 12:53:01 +00:00
Johann Hofmann a05ff7f01f Bug 1484246 - Part 1 - Add more explanation to certificate errors caused by Symantec distrust. r=Gijs,keeler
Differential Revision: https://phabricator.services.mozilla.com/D3877

--HG--
extra : rebase_source : 0f45bb71e4e2d9437c687a991c55f33ab492b7bf
2018-08-21 15:04:02 +02:00
Brendan Dahl f6923ccc24 Bug 1485426 - Use createXULElement instead of createElement in XUL docs. r=bgrins
Preparing for transitioning to XHTML.

MozReview-Commit-ID: JLlmUxsvhIB

Differential Revision: https://phabricator.services.mozilla.com/D4265

--HG--
extra : moz-landing-system : lando
2018-08-25 00:16:27 +00:00
David Keeler 1cd81e4c5a bug 1485087 - remove the option to use the TLS session cache from nsITLSServerSocket r=jryans,mayhemer
As initially implemented, nsITLSServerSocket by default enabled the use of the
TLS session cache provided by NSS. However, no consumers of nsITLSServerSocket
actually used it. Because it was an option, though, PSM had to jump through some
hoops to a) make it work in the first place and b) not have NSS panic on
shutdown. Furthermore, it meant increased memory usage for every user of Firefox
(and again, nothing actually used the feature, so this was for naught).

In bug 1479918, we discovered that if PSM shut down before Necko, NSS could
attempt to acquire a lock on the session cache that had been deleted, causing a
shutdown hang. We probably should make it less easy to make this mistake in NSS,
but in the meantime bug 1479918 needs uplifting and this workaround is the
safest, most straight-forward way to achieve this.

Differential Revision: https://phabricator.services.mozilla.com/D3919

--HG--
extra : moz-landing-system : lando
2018-08-24 16:00:34 +00:00
Tiberius Oros 2ee9341d01 Merge inbound to mozilla-central. a=merge 2018-08-24 12:43:45 +03:00
J.C. Jones 366b9d8e49 Bug 1470914 - land NSS 5bc69334e84f UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : de61d7531f52cc1c46b76dd67679bc453d962a53
2018-08-23 11:10:42 -07:00
Cosmin Sabou 469b620e12 Merge mozilla-central to autoland. a=merge
--HG--
rename : testing/web-platform/tests/css/compositing/support/parsing-testcommon.js => testing/web-platform/tests/css/compositing/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-backgrounds/support/parsing-testcommon.js => testing/web-platform/tests/css/css-backgrounds/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-box/support/parsing-testcommon.js => testing/web-platform/tests/css/css-box/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-cascade/support/parsing-testcommon.js => testing/web-platform/tests/css/css-cascade/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-color/support/parsing-testcommon.js => testing/web-platform/tests/css/css-color/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-images/support/parsing-testcommon.js => testing/web-platform/tests/css/css-images/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-masking/support/parsing-testcommon.js => testing/web-platform/tests/css/css-masking/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-shapes/support/parsing-testcommon.js => testing/web-platform/tests/css/css-shapes/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-transforms/support/parsing-testcommon.js => testing/web-platform/tests/css/css-transforms/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-ui/support/parsing-testcommon.js => testing/web-platform/tests/css/css-ui/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/css-writing-modes/support/parsing-testcommon.js => testing/web-platform/tests/css/css-writing-modes/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/filter-effects/support/parsing-testcommon.js => testing/web-platform/tests/css/filter-effects/parsing/support/parsing-testcommon.js
rename : testing/web-platform/tests/css/motion/support/parsing-testcommon.js => testing/web-platform/tests/css/motion/parsing/support/parsing-testcommon.js
rename : third_party/rust/crossbeam-deque/.cargo-checksum.json => third_party/rust/crossbeam-deque-0.2.0/.cargo-checksum.json
rename : third_party/rust/crossbeam-deque/.travis.yml => third_party/rust/crossbeam-deque-0.2.0/.travis.yml
rename : third_party/rust/crossbeam-deque/CHANGELOG.md => third_party/rust/crossbeam-deque-0.2.0/CHANGELOG.md
rename : third_party/rust/crossbeam-deque/Cargo.toml => third_party/rust/crossbeam-deque-0.2.0/Cargo.toml
rename : third_party/rust/bitflags-0.7.0/LICENSE-APACHE => third_party/rust/crossbeam-deque-0.2.0/LICENSE-APACHE
rename : third_party/rust/crossbeam-deque/README.md => third_party/rust/crossbeam-deque-0.2.0/README.md
rename : third_party/rust/crossbeam-deque/src/lib.rs => third_party/rust/crossbeam-deque-0.2.0/src/lib.rs
rename : third_party/rust/crossbeam-epoch/.cargo-checksum.json => third_party/rust/crossbeam-epoch-0.3.1/.cargo-checksum.json
rename : third_party/rust/crossbeam-epoch/.travis.yml => third_party/rust/crossbeam-epoch-0.3.1/.travis.yml
rename : third_party/rust/crossbeam-epoch/CHANGELOG.md => third_party/rust/crossbeam-epoch-0.3.1/CHANGELOG.md
rename : third_party/rust/crossbeam-epoch/Cargo.toml => third_party/rust/crossbeam-epoch-0.3.1/Cargo.toml
rename : third_party/rust/tokio-io/LICENSE-APACHE => third_party/rust/crossbeam-epoch-0.3.1/LICENSE-APACHE
rename : third_party/rust/crossbeam-epoch/README.md => third_party/rust/crossbeam-epoch-0.3.1/README.md
rename : third_party/rust/crossbeam-epoch/examples/sanitize.rs => third_party/rust/crossbeam-epoch-0.3.1/examples/sanitize.rs
rename : third_party/rust/crossbeam-epoch/src/atomic.rs => third_party/rust/crossbeam-epoch-0.3.1/src/atomic.rs
rename : third_party/rust/crossbeam-epoch/src/collector.rs => third_party/rust/crossbeam-epoch-0.3.1/src/collector.rs
rename : third_party/rust/crossbeam-epoch/src/default.rs => third_party/rust/crossbeam-epoch-0.3.1/src/default.rs
rename : third_party/rust/crossbeam-epoch/src/deferred.rs => third_party/rust/crossbeam-epoch-0.3.1/src/deferred.rs
rename : third_party/rust/crossbeam-epoch/src/epoch.rs => third_party/rust/crossbeam-epoch-0.3.1/src/epoch.rs
rename : third_party/rust/crossbeam-epoch/src/garbage.rs => third_party/rust/crossbeam-epoch-0.3.1/src/garbage.rs
rename : third_party/rust/crossbeam-epoch/src/guard.rs => third_party/rust/crossbeam-epoch-0.3.1/src/guard.rs
rename : third_party/rust/crossbeam-epoch/src/internal.rs => third_party/rust/crossbeam-epoch-0.3.1/src/internal.rs
rename : third_party/rust/crossbeam-epoch/src/lib.rs => third_party/rust/crossbeam-epoch-0.3.1/src/lib.rs
rename : third_party/rust/crossbeam-epoch/src/sync/list.rs => third_party/rust/crossbeam-epoch-0.3.1/src/sync/list.rs
rename : third_party/rust/crossbeam-epoch/src/sync/queue.rs => third_party/rust/crossbeam-epoch-0.3.1/src/sync/queue.rs
rename : third_party/rust/crossbeam-utils/.cargo-checksum.json => third_party/rust/crossbeam-utils-0.2.2/.cargo-checksum.json
rename : third_party/rust/crossbeam-utils/CHANGELOG.md => third_party/rust/crossbeam-utils-0.2.2/CHANGELOG.md
rename : third_party/rust/crossbeam-utils/Cargo.toml => third_party/rust/crossbeam-utils-0.2.2/Cargo.toml
rename : third_party/rust/bitflags-0.7.0/LICENSE-APACHE => third_party/rust/crossbeam-utils-0.2.2/LICENSE-APACHE
rename : third_party/rust/crossbeam-utils/src/atomic_option.rs => third_party/rust/crossbeam-utils-0.2.2/src/atomic_option.rs
rename : third_party/rust/crossbeam-utils/src/lib.rs => third_party/rust/crossbeam-utils-0.2.2/src/lib.rs
rename : third_party/rust/crossbeam-utils/src/scoped.rs => third_party/rust/crossbeam-utils-0.2.2/src/scoped.rs
rename : third_party/rust/bitflags-0.7.0/LICENSE-APACHE => third_party/rust/indexmap/LICENSE-APACHE
rename : third_party/rust/lazycell/.cargo-checksum.json => third_party/rust/lazycell-0.4.0/.cargo-checksum.json
rename : third_party/rust/lazycell/CHANGELOG.md => third_party/rust/lazycell-0.4.0/CHANGELOG.md
rename : third_party/rust/lazycell/Cargo.toml => third_party/rust/lazycell-0.4.0/Cargo.toml
rename : third_party/rust/bitflags-0.7.0/LICENSE-APACHE => third_party/rust/lazycell-0.4.0/LICENSE-APACHE
rename : third_party/rust/lazycell/LICENSE-MIT => third_party/rust/lazycell-0.4.0/LICENSE-MIT
rename : third_party/rust/lazycell/README.md => third_party/rust/lazycell-0.4.0/README.md
rename : third_party/rust/lazycell/src/lib.rs => third_party/rust/lazycell-0.4.0/src/lib.rs
rename : third_party/rust/bitflags-0.7.0/LICENSE-APACHE => third_party/rust/rand-0.3.22/LICENSE-APACHE
rename : third_party/rust/bitflags-0.7.0/LICENSE-MIT => third_party/rust/rand-0.3.22/LICENSE-MIT
rename : third_party/rust/rand/appveyor.yml => third_party/rust/rand-0.3.22/appveyor.yml
rename : third_party/rust/slab/.cargo-checksum.json => third_party/rust/slab-0.3.0/.cargo-checksum.json
rename : third_party/rust/slab/Cargo.toml => third_party/rust/slab-0.3.0/Cargo.toml
rename : third_party/rust/slab/README.md => third_party/rust/slab-0.3.0/README.md
rename : third_party/rust/slab/src/lib.rs => third_party/rust/slab-0.3.0/src/lib.rs
rename : third_party/rust/tokio-io/src/read_to_end.rs => third_party/rust/tokio-io/src/io/read_to_end.rs
rename : third_party/rust/tokio-io/src/read_until.rs => third_party/rust/tokio-io/src/io/read_until.rs
extra : rebase_source : 4c022c31e626832d12535d88e7caea452419ac2f
2018-08-24 00:44:17 +03:00
Cosmin Sabou 3211507dfb Merge mozilla-inbound to mozilla-central. a=merge 2018-08-24 00:40:14 +03:00
Gurzau Raul ac1914ecba Backed out 6 changesets (bug 1421501) for bustages on security/nss/lib/freebl/mpi/mp_comba.c on a CLOSED TREE
Backed out changeset cae4910806c7 (bug 1421501)
Backed out changeset 600a005d3613 (bug 1421501)
Backed out changeset 7381597721d2 (bug 1421501)
Backed out changeset 1ee0d35a041f (bug 1421501)
Backed out changeset 772dea1abb7f (bug 1421501)
Backed out changeset c119767aec7b (bug 1421501)
2018-08-23 17:13:42 +03:00
Kris Maglione 3a5c05e76f Bug 1484496: Part 5e - Convert remaining nsISimpleEnumerator users to use JS iteration. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D3733

--HG--
extra : rebase_source : c0fac176d7b3d840c4dbb14f8d95ccfc7f83a5a8
extra : histedit_source : a92c40117d0808a3ad68c972f622a7a42c9ae8ba
2018-08-18 18:13:14 -07:00
Kris Maglione 2dee0aae3c Bug 1484496: Part 4b - Add intrinsic type information to most nsSimpleEnumerators. r=froydnj
This allows JS callers to automatically get the correct types during
interation, without having to explicitly specify them.

Differential Revision: https://phabricator.services.mozilla.com/D3728

--HG--
extra : rebase_source : b708f382d8ea571d199c669bfed5b5a7ca9ffac4
extra : histedit_source : 7df6feb82088c8a5ca45dc28fe4d2b852c177fee
2018-08-18 21:06:32 -07:00
Kris Maglione 65c28aa0ad Bug 1484496: Part 2 - Add common base class for all nsISimpleEnumerator implementations. r=froydnj
In order to allow JS callers to use nsISimpleEnumerator instances with the JS
iteration protocol, we'll need to additional methods to every instance. Since
we currently have a large number of unrelated implementations, it would be
best if they could share the same implementation for the JS portion of the
protocol.

This patch adds a stub nsSimpleEnumerator base class, and updates all existing
implementations to inherit from it. A follow-up will add a new base interface
to this class, and implement the additional functionality required for JS
iteration.

Differential Revision: https://phabricator.services.mozilla.com/D3725

--HG--
extra : rebase_source : ad66d7b266856d5a750c772e4710679fab9434b1
extra : histedit_source : a83ebffbf2f0b191ba7de9007f73def6b9a955b8
2018-08-18 14:22:47 -07:00
Landry Breuil aa545e34c8 Bug 1457092 - Implement sandboxing on OpenBSD. r=gcp, r=jld
Add StartOpenBSDSandbox method calling pledge() syscall,
and use it where we're sandboxing processes.

The pledge subsets are coming from two new prefs:
- security.sandbox.pledge.content for the content process
- security.sandbox.pledge.main for the main process

--HG--
extra : rebase_source : 60da70e2d335755fda6126a6b7de7aad41eebb7e
2018-08-23 07:35:00 -04:00
Robert Helmer a8e1af1e15 Bug 1421501 - export NSS [Init,Shutdown]Context symbols r=fkiefer
MozReview-Commit-ID: Kmhn1dBSYUD

--HG--
extra : rebase_source : 0b89ae88453de99d2e3a8a347fea5afd82aa07bf
2018-08-09 08:35:48 -07:00
Cosmin Sabou 0bd06ad763 Backed out 7 changesets (bug 1421501) for causing build bustages. CLOSED TREE
Backed out changeset 492f05d220b1 (bug 1421501)
Backed out changeset 844232d77d0d (bug 1421501)
Backed out changeset 3affc66728b0 (bug 1421501)
Backed out changeset 4d7c3c02ce8d (bug 1421501)
Backed out changeset e27d93ac79a0 (bug 1421501)
Backed out changeset a6c9888b5179 (bug 1421501)
Backed out changeset f7f9e47f0608 (bug 1421501)
2018-08-23 22:46:07 +03:00
Robert Helmer 7a1006824c Bug 1421501 - export NSS [Init,Shutdown]Context symbols r=fkiefer
MozReview-Commit-ID: Kmhn1dBSYUD

--HG--
extra : rebase_source : 1deef9e50a578b4ff24f3d44fafe4992838d0ceb
2018-08-09 08:35:48 -07:00
ffxbld 1eb4a76ba4 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D4071

--HG--
extra : moz-landing-system : lando
2018-08-23 13:31:44 +00:00
Dipen Patel 1e7897dcaa Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=Gijs,keeler
- Remove the viewCert method from nsICertificateDialogs
- Remove all associated C++ code
- Directly invoke UI window where it was previous called.
- Update tests

MozReview-Commit-ID: 9b62Go0DjE9

Differential Revision: https://phabricator.services.mozilla.com/D3358

--HG--
extra : moz-landing-system : lando
2018-08-22 17:38:33 +00:00
Gian-Carlo Pascutto ac0adb0b5e Bug 1480755 - Add support for new Mesa device probing. r=jld
MozReview-Commit-ID: CD9ATGHUOZ1

Differential Revision: https://phabricator.services.mozilla.com/D3910

--HG--
extra : moz-landing-system : lando
2018-08-22 01:52:44 +00:00
J.C. Jones 9ddc263762 Bug 1470914 - land NSS d3f512d4f76e UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : b1659503f5e91eae88beb66f129719960303c7fa
2018-08-21 11:07:22 -07:00
Robert Helmer 84023e4e83 Bug 1421501 - export NSS [Init,Shutdown]Context symbols r=fkiefer
MozReview-Commit-ID: Kmhn1dBSYUD

--HG--
extra : rebase_source : 1deef9e50a578b4ff24f3d44fafe4992838d0ceb
2018-08-09 08:35:48 -07:00
Dana Keeler 58da26473a bug 1411458 - add a test for bug 1411458 r=jcj
MozReview-Commit-ID: LrZN4DATEVP

--HG--
extra : rebase_source : f71a1278484a97e38a7c44fdf47cc0c690a0716b
2017-10-25 11:33:03 -07:00
arthur.iakab cb046df12d Backed out changeset 163c65f9c522 (bug 1484761)for browser chrome failures on browser_aboutCertError.js 2018-10-08 20:44:33 +03:00
trisha 229b14cdfe Bug 1484761 - Change "security certificates" to "certificates" on the new cert error pages r=johannh 2018-09-27 17:04:41 +08:00
Franziskus Kiefer a52a8495f9 Bug 1479787 - use NSS mozpkix in Firefox, r=mt,keeler,glandium
Differential Revision: https://phabricator.services.mozilla.com/D2725
Differential Revision: https://phabricator.services.mozilla.com/D2860

--HG--
extra : rebase_source : 189c13c2a3104c106fcabad5998af6cb2e20d4a5
2018-10-02 14:59:34 +02:00
Franziskus Kiefer 526b07f729 Bug 1479787 - delete mozpkix, r=mt,keeler
Differential Revision: https://phabricator.services.mozilla.com/D2722

--HG--
extra : rebase_source : 36c2762f851f3925b5157de762d9b44cc5ef81fc
2018-10-02 12:40:22 +02:00
Dorel Luca 07c6e76122 Merge mozilla-inbound to mozilla-central. a=merge 2018-08-21 12:54:24 +03:00
Mike Hommey e685fe000f Bug 1341222 - Fix building in-tree NSS against system NSPR. r=froydnj 2018-08-21 07:25:11 +09:00
Haik Aftandilian 25e42d1fc7 Bug 1484051 - Limit Mac Flash sandbox file-access mds rules r=Alex_Gaynor 2018-08-17 15:05:47 -07:00
Dragana Damjanovic ae60f1a2d4 Bug 1480704 - Detect the presents of a MITM. r=mikedeboer,keeler
Bug 1480704 - Detect the presents of a MITM.

Differential Revision: https://phabricator.services.mozilla.com/D2715

--HG--
extra : moz-landing-system : lando
2018-08-17 22:12:17 +00:00
Tiberius Oros 246f2b4fab Merge inbound to mozilla-central. a=merge 2018-08-17 00:32:50 +03:00
Jed Davis c6eafa306d Bug 1480554 - Fix missing include in SandboxOpenedFiles.cpp. r=gcp 2018-08-16 09:15:56 -06:00
Jed Davis 5e630f7ccf Bug 1481978 - Change IPC CloseSuperfluousFds to prevent accidentally heap-allocating closures. r=glandium
Closures are nice but -- as pointed out in bug 1481978 comment #2 --
it's a footgun to take a std::function argument in a context where heap
allocation isn't safe.

Fortunately, non-capturing closures convert to C function pointers,
so a C-style interface with a void* context can still be relatively
ergonomic.
2018-08-15 19:08:40 -06:00
Kai Engert fdf57fee14 Bug 1470914, land NSS beta snapshot 6349fa699c3b UPGRADE_NSS_RELEASE, r=me 2018-08-15 14:42:53 +02:00
Haik Aftandilian fd21ba0b31 Bug 1483058 - [Mac] Camera not accessible by Adobe Flash applets r=Alex_Gaynor
Allow access to services needed for the Flash plugin to access cameras.

Differential Revision: https://phabricator.services.mozilla.com/D3357

--HG--
extra : moz-landing-system : lando
2018-08-14 19:58:12 +00:00
Henri Sivonen 3edc601325 Bug 1402247 - Use encoding_rs for XPCOM string encoding conversions. r=Nika,erahm,froydnj.
Correctness improvements:

 * UTF errors are handled safely per spec instead of dangerously truncating
   strings.

 * There are fewer converter implementations.

Performance improvements:

 * The old code did exact buffer length math, which meant doing UTF math twice
   on each input string (once for length calculation and another time for
   conversion). Exact length math is more complicated when handling errors
   properly, which the old code didn't do. The new code does UTF math on the
   string content only once (when converting) but risks allocating more than
   once. There are heuristics in place to lower the probability of
   reallocation in cases where the double math avoidance isn't enough of a
   saving to absorb an allocation and memcpy.

 * Previously, in UTF-16 <-> UTF-8 conversions, an ASCII prefix was optimized
   but a single non-ASCII code point pessimized the rest of the string. The
   new code tries to get back on the fast ASCII path.

 * UTF-16 to Latin1 conversion guarantees less about handling of out-of-range
   input to eliminate an operation from the inner loop on x86/x86_64.

 * When assigning to a pre-existing string, the new code tries to reuse the
   old buffer instead of first releasing the old buffer and then allocating a
   new one.

 * When reallocating from the new code, the memcpy covers only the data that
   is part of the logical length of the old string instead of memcpying the
   whole capacity. (For old callers old excess memcpy behavior is preserved
   due to bogus callers. See bug 1472113.)

 * UTF-8 strings in XPConnect that are in the Latin1 range are passed to
   SpiderMonkey as Latin1.

New features:

 * Conversion between UTF-8 and Latin1 is added in order to enable faster
   future interop between Rust code (or otherwise UTF-8-using code) and text
   node and SpiderMonkey code that uses Latin1.

MozReview-Commit-ID: JaJuExfILM9
2018-08-14 14:43:42 +03:00
David Keeler d2cf0c7ffc bug 1479918 - fix HSTS update script to only access XHR headers after each request has completed r=sfraser
When the HSTS preload script was reworked to use async/await in bug 1436369,
`fetchstatus` would create an asynchronous xml http request and then attempt to
access a response header from it. However, there was nothing to ensure that the
request had completed before this code ran. This patch ensures that the request
has completed before the response header is used.

This patch also replaces a lingering instance of `Ci.nsISSLStatusProvider` that
should have been changed to `Ci.nsITransportSecurityInfo` in bug 1475647.

Finally, this patch removes the old, redundant getHSTSPreloadList.js in
security/manager/tools as well as the unused nsSTSPreloadList.errors file in
security/manager/ssl.

Differential Revision: https://phabricator.services.mozilla.com/D2807

--HG--
extra : moz-landing-system : lando
2018-08-13 20:25:21 +00:00
David Keeler f9c800c5c1 bug 1460062 - Enforce Symantec distrust in Firefox 63 r=franziskus
This patch implements the Symantec distrust plan on Nightly only for now.

Differential Revision: https://phabricator.services.mozilla.com/D2959

--HG--
extra : moz-landing-system : lando
2018-08-13 14:59:47 +00:00
Martin Thomson 59b2975f6c Bug 1479501 - Disable TLS version fallback, r=ekr
--HG--
extra : source : 91fcd26d7794d96c757a44cdffe6e799ccdc6d3a
extra : amend_source : f72f8d7c6500b3fe825dd24d676558438609e699
2018-08-10 12:10:35 +10:00
ffxbld 6107a2a1fc No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D3490

--HG--
extra : moz-landing-system : lando
2018-08-16 10:57:34 +00:00
Franziskus Kiefer 83ef3e317f Bug 1470914 - land NSS 01d970fe9048 UPGRADE_NSS_RELEASE, r=me 2018-08-10 10:13:05 +02:00
ffxbld 92a9c277ad No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D2997
2018-08-09 09:45:18 -04:00
Dipen Patel b78f5b5ec5 Bug 1468224 - remove dialogs from nsIX509CertDB PKCS12File methods. r=keeler
- enhance nsIX509CertDB.importPKCS12File to accept a password and return error code.
- enhance nsIX509CertDB.exportPKCS12File to accept a password and return error code.
- remove password and error prompts being invoked in C++ layer to Javascript layer.
- update unit tests
- add unit test for importing certs with empty string password and no passwords.
- remove unused code

MozReview-Commit-ID: 23ypAzBarOp

--HG--
extra : rebase_source : df608a240c6fa7ce4278145861e57882f0803e02
2018-08-02 20:57:07 -07:00
Kris Maglione 25c94b46d8 Bug 1481021: Part 1 - Fix tests that rely on permissive COWs or SpecialPowers side-effects in frame script scopes. r=bz
Right now, a lot of test code relies on side-effects of SpecialPowers being
loaded into frame script globals. In particular:

- It forces permissive COWs from those scopes, which allows frame scripts to
  pass objects from those scopes to unprivileged content that they otherwise
  wouldn't.
- It imports a bunch of helper modules and WebIDL globals which would
  otherwise not be available.

Fortunately, this seems to only impact test code at this point. But there's a
real down-the-road risk of it impacting shipping code, which ends up working
in automation due to the side-effects of SpecialPowers, but failing in real
world use.

MozReview-Commit-ID: G27eSSOHymX

--HG--
extra : rebase_source : 1702e63fed719fc92def2bdbbb8a7c53572432db
extra : source : 41bedc526dd6ec6b7e8c7be1c832ac60c81d6263
2018-08-07 14:13:06 -07:00
Ciure Andrei 9f8ebbde60 Merge inbound to mozilla-central. a=merge 2018-08-07 00:58:13 +03:00
ffxbld de6c35a6a2 No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D2771
2018-08-06 15:09:53 -04:00
Franziskus Kiefer 3695d15b7d Bug 1478668 - follow-up fixing error-case returns, r=keeler
--HG--
extra : rebase_source : c2a73c701c68529e0473566b3035b525ff48a932
2018-08-06 11:18:01 +02:00
Masatoshi Kimura 3b21b7868b Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
--HG--
extra : rebase_source : c09366fb93e5b0f72abe1e99d3094e3d96a934fb
extra : intermediate-source : 5950c9d63c3b4fd63a25464a7b50944aaec7079f
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Narcis Beleuzu 4684ccf98e Merge inbound to mozilla-central. a=merge 2018-08-03 01:28:14 +03:00
David Keeler 23a3da73fa bug 1476473 - disable EV treatment for DocuSign roots r=franziskus
Differential Revision: https://phabricator.services.mozilla.com/D2255

--HG--
extra : moz-landing-system : lando
2018-08-02 07:39:14 +00:00
Cosmin Sabou de8c2bd891 Backed out changeset 5950c9d63c3b (bug 1090497) for build bustages on several files. CLOSED TREE 2018-08-02 19:59:53 +03:00
Masatoshi Kimura feea19030c Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj
--HG--
extra : rebase_source : a62521fdc66def4e4d5d7bf52e68365a786b5c55
extra : source : ca1b9a2bcc4381795f556fea2fb59066567c30f3
2018-07-31 22:10:07 +09:00
Franziskus Kiefer e279c84c4e Bug 1470914 - land NSS e2a0d66b122f UPGRADE_NSS_RELEASE, r=me
--HG--
extra : rebase_source : 078fe0962637a3888c6a874e2f5d3690ae5aaaab
2018-08-02 12:53:56 +02:00
Noemi Erli 8f66a71e70 Merge inbound to mozilla-central. a=merge 2018-08-02 11:54:46 +03:00
dvarga 956d57e7f2 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-08-02 01:26:29 +03:00
Nika Layzell 7a9f60fafb Bug 1479484 - Part 1: Add make_dafsa.py to the virtualenv's python path, r=froydnj
Summary:
The plan is to also expose perfecthash.py from this module on the python path.
This also allows us to stop using explicit module loading to load make_dafsa.py.

make_dafsa.py was moved into tools/ to avoid any extra python files from
accidentally ending up on the python path.

Reviewers: froydnj!

Tags: #secure-revision

Bug #: 1479484

Differential Revision: https://phabricator.services.mozilla.com/D2614


--HG--
rename : xpcom/ds/make_dafsa.py => xpcom/ds/tools/make_dafsa.py
2018-08-01 17:54:41 -04:00
David Keeler 249a65b3d3 bug 1433409 - avoid acquiring nsNSSComponent.mMutex when we don't have to r=franziskus
In some cases, nsNSSComponent functions were acquiring nsNSSComponent's mMutex
to check mNSSInitialized to see if it had been initialized. It turns out this is
unnecessary in some cases because those functions are only callable if
nsNSSComponent has been initialized. This fixes those instances and renames
'mNSSInitialized' to 'mNonIdempotentCleanupMustHappen' to make it clear exactly
what that boolean represents.

Differential Revision: https://phabricator.services.mozilla.com/D2577

--HG--
extra : moz-landing-system : lando
2018-08-01 20:56:28 +00:00
ffxbld 6a905af472 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D2501
2018-08-01 16:18:31 -04:00
Franziskus Kiefer e6061725f9 Bug 1478668 - windows key store adapter, r=keeler
OS key-store adapter for Windows Credential Manager.
It looks like Windows doesn't allow locking the credential manager without locking the desktop. So `lock` and `unlock` are no-ops here.

Depends on D2487.

Differential Revision: https://phabricator.services.mozilla.com/D2550

--HG--
extra : moz-landing-system : lando
2018-08-01 09:34:59 +00:00
Dorel Luca fa7b36bf43 Backed out changeset e80000bf992c (bug 1478668) for build bustage 2018-08-01 12:26:14 +03:00
Franziskus Kiefer 2b958d46de Bug 1478668 - windows key store adapter, r=keeler
OS key-store adapter for Windows Credential Manager.
It looks like Windows doesn't allow locking the credential manager without locking the desktop. So `lock` and `unlock` are no-ops here.

Depends on D2487.

Differential Revision: https://phabricator.services.mozilla.com/D2550

--HG--
extra : moz-landing-system : lando
2018-08-01 07:52:13 +00:00
Bogdan Tara bd351673a5 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-01 01:05:56 +03:00
David Keeler 6cb94e9111 bug 1478667 - implement OS key-store adapter for OS X r=franziskus,spohl
This implements support for OS-backed storage of secrets using the OS X keychain
APIs.

Differential Revision: https://phabricator.services.mozilla.com/D2487

--HG--
extra : moz-landing-system : lando
2018-07-31 20:52:56 +00:00
Jed Davis 09db14abce Bug 1439057 - Tighten /dev/shm access in Linux content sandbox policy. r=gcp
This patch uses the shared memory name prefixes introduced in bug 1447867
to prevent access to /dev/shm files of other applications or other
processes within the same browser instance.

When a shared memory implementation that doesn't use shm_open is available
(specifically, the memfd_create support to be added in bug 1440203),
/dev/shm access is completely denied.

MozReview-Commit-ID: L2ylG5KrXTU
2018-07-31 10:41:29 -06:00
David Keeler 89db979440 bug 1475084 - add tests for tampered COSE signatures in add-ons r=dveditz
Differential Revision: https://phabricator.services.mozilla.com/D2148

--HG--
extra : moz-landing-system : lando
2018-07-30 21:48:53 +00:00
Kris Maglione 031076f2f3 Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
2018-05-21 16:58:23 -07:00
Kris Maglione 02ba563399 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : source : 0d69b4fb1ed43751cfcbc0b4f2fe3b6a49bc0494
extra : histedit_source : d0ce31513ffaae2fd7f01f6567a97b6d2d96b797%2Cfff837de7a00fa90809d2c3e755097180dfd56d8
2018-05-20 18:10:16 -07:00
Narcis Beleuzu 561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione cb1ee1e34d Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
2018-05-21 16:58:23 -07:00
Kris Maglione 636f1839e5 Bug 1463016: Part 5 - Add domWindow property to DocShellTreeItem and update callers to use it. r=nika
MozReview-Commit-ID: FRRAdxLHRtG

--HG--
extra : rebase_source : 36565ef5e74360aad14062005e5bdab2939e888b
2018-05-20 18:10:16 -07:00
Jeff Gilbert 0e128a3868 Bug 1470985 - s/PodEqual/ArrayEqual/ from ArrayUtils.h. - r=waldo
We can't use memcmp to compare PODs, largely because of undefined
padding. The rest of the Pod* functions are fine though, since we're
replicating or zeroing PODs.

MozReview-Commit-ID: LSspAi8qCWw
2018-07-27 14:11:18 -07:00
Kai Engert 81bf621fb6 Bug 1470914, NSS 3.39 beta revision be5c5d3ad5f6 UPGRADE_NSS_RELEASE r=me 2018-07-27 15:08:55 +02:00
Csoregi Natalia 3708e71462 Merge inbound to mozilla-central. a=merge 2018-07-27 00:58:11 +03:00
Franziskus Kiefer 4b196d2f5b Bug 1472104 - autograph COSE test-case, r=keeler
This adds a test with an extension signed by autorgraph with cose and pk7.

Differential Revision: https://phabricator.services.mozilla.com/D1855

--HG--
extra : moz-landing-system : lando
2018-07-26 09:18:38 +00:00
Dipen Patel 7641beb1f8 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : 9c400bed3c9d29a186fc987c9bd0ffceb37bfd94
2018-07-13 11:48:55 -07:00
Andreea Pavel da179a7f47 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2018-07-25 18:13:30 +03:00
Sebastian Hengst bd900ee36a Merge mozilla-inbound to mozilla-central. a=merge 2018-07-25 17:16:53 +03:00
Kai Engert b8bea43ef3 Bug 1470914, NSS 3.39 beta revision 4a086733554e UPGRADE_NSS_RELEASE r=me 2018-07-25 15:17:58 +02:00
Jed Davis ec4764f25f Bug 1243108 - Work around Linux kernel bug causing broker responses to be dropped. r=gcp
MozReview-Commit-ID: LX2kEXybFGW

--HG--
extra : rebase_source : 922af6565786ec0eb4d041606d094b4a3fde739b
2018-07-19 18:20:03 -06:00
Franziskus Kiefer 3d0b306faa Bug 1464828 - DAR API with libsecret and NSS back-end, r=keeler,m_and_m,froydnj
This implements an API in `nsIOSKeyStore.idl` and `OSKeyStore.cpp` to encrypt and decrypt bytes with a key that is stored in the OS key store.
There are two OS adapters in this patch.
Libsecret is used on Linux if available.
The NSS key store is used as fallback if no OS specific key store is implemented.

Differential Revision: https://phabricator.services.mozilla.com/D1858

--HG--
extra : rebase_source : 99d7d646968a46a13ffa61885bb246f6d3e443e4
2018-07-26 16:05:35 +02:00
Boris Zbarsky 754087a992 Bug 1446940 part 5. Stop getting docshells from windows via getInterface in dom/editor/etc code. r=kmag 2018-08-01 13:07:11 -04:00
David Keeler 8dc4d88166 bug 1475775 - clean up old NSS DB file after upgrade if necessary r=franziskus,mattn
Reviewers: franziskus, mattn

Bug #: 1475775

Differential Revision: https://phabricator.services.mozilla.com/D2202

--HG--
rename : security/manager/ssl/tests/unit/test_sdr_preexisting_with_password.js => security/manager/ssl/tests/unit/test_sdr_upgraded_with_password.js
rename : security/manager/ssl/tests/unit/test_sdr_preexisting_with_password/key3.db => security/manager/ssl/tests/unit/test_sdr_upgraded_with_password/key3.db
extra : rebase_source : 8c736b786e3bf22644bc7c14bf6d6ce20ddd38ad
extra : amend_source : 8fccc2f496d9cb99915725f09e2fbe81217326bb
2018-07-17 13:51:00 -07:00
Xidorn Quan afa56fd579 Bug 1476475 - Use -W4 for certverifier with clang-cl. r=froydnj
MozReview-Commit-ID: 9OVJ2CFO0Qb

--HG--
extra : rebase_source : 3f0b89c6e8f54e34afa19c74a0574a258912c940
2018-07-20 16:34:56 +10:00
trisha fbed68adb3 Bug 1463759 Change the copy of certificate error pages r=johannh
MozReview-Commit-ID: LbZBwSk1xX4

--HG--
extra : rebase_source : 27329d727b15b7310df81494d16de38bd0760d42
2018-07-04 18:15:43 +05:30
David Keeler 85865937f5 bug 1300420 - add enterprise root support for OS X r=spohl,franziskus
If the preference security.enterprise_roots.enabled is set to true, the platform will import trusted TLS certificates from the OS X keystore.

Differential Revision: https://phabricator.services.mozilla.com/D2169

--HG--
extra : moz-landing-system : lando
2018-07-20 19:28:09 +00:00
shindli 70ab23ecd2 Backed out changeset d126a6593e8f (bug 1475647) for mozmake.exe bustage on a CLOSED TREE 2018-07-24 02:55:53 +03:00
Dipen Patel b0259a189f Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL

--HG--
extra : rebase_source : b15f75e39d04c8485b4eb63416fd1f1e4175fafe
2018-07-13 11:48:55 -07:00
Cosmin Sabou f3e8c47ce5 Backed out changeset 469f678d1f15 for xpcshell failures on test_remote_settings_poll.js. CLOSED TREE 2018-07-23 15:26:37 +03:00
ffxbld 176487d89b No Bug, mozilla-central repo-update HSTS HPKP remote-settings - a=repo-update r=mtabara
Differential Revision: https://phabricator.services.mozilla.com/D2292

--HG--
extra : moz-landing-system : lando
2018-07-23 10:10:21 +00:00