https://clang.llvm.org/docs/DiagnosticsReference.html#wbitfield-enum-conversion
This clang warning caught a real layout bug related to implicitly truncated enums in the table border style code (bug 1485179):
layout/tables/nsTableFrame.cpp:5318:14 [-Wbitfield-enum-conversion] bit-field 'ownerElem' is not wide enough to store all enumerators of 'BCBorderOwner'
layout/tables/nsTableFrame.cpp:5358:16 [-Wbitfield-enum-conversion] bit-field 'ownerElem' is not wide enough to store all enumerators of 'BCBorderOwner'
layout/tables/nsTableFrame.cpp:5374:18 [-Wbitfield-enum-conversion] bit-field 'subElem' is not wide enough to store all enumerators of 'BCBorderOwner'
layout/tables/nsTableFrame.cpp:5385:18 [-Wbitfield-enum-conversion] bit-field 'subElem' is not wide enough to store all enumerators of 'BCBorderOwner'
Also update the comment linking to clang and gcc's warning documentation.
Differential Revision: https://phabricator.services.mozilla.com/D12513
--HG--
extra : moz-landing-system : lando
Calling this function is just a waste of time since we will check
third-partiness a few statements further down.
Differential Revision: https://phabricator.services.mozilla.com/D13500
--HG--
extra : moz-landing-system : lando
The browser_addons_debug_bootstrapped addon is completely removed because it is already
covered for webextensions with browser_addons_debug_webextensions.js
Other have either been migrated to use webextensions.
Differential Revision: https://phabricator.services.mozilla.com/D13255
--HG--
extra : moz-landing-system : lando
I'm pretty sure the FIXME I left in the outline-style code is a bug,
but I want to clean this up further and I didn't want to fix it without adding
a test.
Differential Revision: https://phabricator.services.mozilla.com/D12859
--HG--
extra : moz-landing-system : lando
This also adds a telemetry count for the grid highlighter being turned on by the
markup view, which was not in place when we added the telemetry for the grid
highlighter.
ICEntries and the fallback stub space are now stored in ICScript. The ICScript*
is stored in TypeScript to not increase sizeof(JSScript).
We need this for bug 1499324 but it also lets us greatly simplify the
BaselineDebugModeOSR code as this patch shows.
Note: some ICScript method definitions are still in BaselineJIT.cpp instead of
BaselineIC.cpp to make this patch easier to review. We could move them to
BaselineIC.cpp as a follow-up change.
Differential Revision: https://phabricator.services.mozilla.com/D11746
--HG--
extra : moz-landing-system : lando
Without knownTracksTime, StreamTracks::GetFirstTrackEnd() returns
STREAM_TIME_MAX for an empty StreamTracks, so PullNewData() thinks no new data
is needed.
This circumvents that by always checking whether tracks need data.
Differential Revision: https://phabricator.services.mozilla.com/D12928
--HG--
extra : moz-landing-system : lando
If zero tests are selected to run while --repeat-until-unexpected is specified, wptrunner can get into a fast infinite loop of running nothing until killed by the user.
This patch should stop that from happening by breaking the loop after the first iteration of nothing finishes.
Differential Revision: https://phabricator.services.mozilla.com/D13204
--HG--
extra : moz-landing-system : lando
This is all the style-system work needed for this.
This implements the concept of legacy shorthands, teaches tests to understand
it, and adds a few more tests for these properties in particular.
The WPT even caught a few WebKit / Blink bugs:
https://bugs.chromium.org/p/chromium/issues/detail?id=906336https://bugs.webkit.org/show_bug.cgi?id=191803
This doesn't change the layout behavior for page-break-before: always, since
it'd stop breaking in multicol and such. Similarly, break-before / break-after:
column and page still behave the same, I'll file followups for those given
comment 22.
Differential Revision: https://phabricator.services.mozilla.com/D12211
--HG--
extra : moz-landing-system : lando
This patch replace the LWT aliases with their related non-deprecated alias in all the theme API tests
that don't seem to be specifically testing the LWT aliases (e.g. browser_ext_themes_lwtsupport.js is
leaved unmodified for this reason).
The main reason to replace them in the "not stricly LWT-related" tests before their final removal
(currently planned for Firefox 69) is that the deprecation warnings will make these tests more
noisy (and so they may be making harder to investigate failures, without any actual gain in terms
of coverage).
Depends on D12297
Differential Revision: https://phabricator.services.mozilla.com/D12783
--HG--
extra : moz-landing-system : lando
The addon manager has a bunch of handling for "strict compatibility" --
an option for individual profiles and addons to control exactly how
compatibility is handled. However, WebExtensions don't use or expose
this feature. We want to retain this capability for other projects that
use the addon manager but since it cannot be tested with WebExtensions,
this patch converts its tests to use the new extension loading hook added
in the previous patch.
--HG--
extra : rebase_source : 023ef88b35d02f02976681894e9f052146f8b66c
extra : histedit_source : e6ff774d3639fe580f97bc7aa6df6f15a42d1a61
This patch doesn't currently prevent a static theme which uses the LWT aliases from
being installed successfully but, as the first step for their deprecation and removal,
it starts to log a warning message when these aliases are being used (e.g. when
installing the static theme extension from "about:debugging", these warnings are being
shown to the theme author).
A similar linting warning is going to be emitted on AMO submissions
(See https://github.com/mozilla/addons-linter/issues/2259), and it will
be turned it into a linting error once AMO should start to prevent new static
theme submittions from using the LWT aliases.
Differential Revision: https://phabricator.services.mozilla.com/D12297
--HG--
extra : moz-landing-system : lando
Chris Peterson
Dão Gottwald
Gian-Carlo Pascutto
William Lachance
Ehsan Akhgari
Julian Descottes
Cosmin Sabou
Andi-Bogdan Postelnicu
Sylvestre Ledru
Noemi Erli
Johann Hofmann
arthur.iakab
Emilio Cobos Álvarez
Jeff Walden
Eitan Isaacson
Felipe Gomes
Razvan Maries
Gabriel Luong
Andrew Swan
Lee Salzman
Jan de Mooij
Timothy Guan-tin Chien
Daniel Holbert
Andreea Pavel
Markus Stange
Andreas Pehrson
Wes Kocher
Adam Holm
Diego Pino Garcia
Luca Greco