Changes:
- Callout now changed to a triangle.
- Finally found a way to make the GCLI window 80% of viewport width (80vw).
- overflow-x is now hidden as the output width should be plenty wide enough to display any text.
The implementation is much prettier and works far better than it previously did. It is still not perfect e.g. when the output is scrollable we lose the triangular callout. I believe this was intentional in an effort to fit as much text in the output box as possible.
MozReview-Commit-ID: 3xEl9nmU47Z
--HG--
extra : rebase_source : 9ace56cd010b52df243c4dd5fbfdabdd6f808fd5
This is easy to test:
Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp
I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.
MozReview-Commit-ID: 5897IV7epax
--HG--
rename : browser/base/content/gcli_sec_bad.svg => devtools/client/themes/images/gcli_sec_bad.svg
rename : browser/base/content/gcli_sec_good.svg => devtools/client/themes/images/gcli_sec_good.svg
rename : browser/base/content/gcli_sec_moderate.svg => devtools/client/themes/images/gcli_sec_moderate.svg
extra : rebase_source : 2aeb4c295a8e1b256cf2f53337b05496ef63f239
This is easy to test:
Green tick marks (gcli_sec_good.svg) and Red Crosses (gcli_sec_bad.svg):
1. Go to https://csp-evaluator.withgoogle.com/
2. Shift+F2
3. security csp
I couldn't find a way to show the Orange Minus (gcli_sec_moderate.svg) but the path is changed in line with the other images and I did test it programatically so it will be fine.
MozReview-Commit-ID: 5897IV7epax
--HG--
rename : browser/base/content/gcli_sec_bad.svg => devtools/client/themes/images/gcli_sec_bad.svg
rename : browser/base/content/gcli_sec_good.svg => devtools/client/themes/images/gcli_sec_good.svg
rename : browser/base/content/gcli_sec_moderate.svg => devtools/client/themes/images/gcli_sec_moderate.svg
extra : rebase_source : b550cd4184f2c9e77b1d5df2cf5c67c1296b8ade
It appears the new debugger UI is working for the Browser Toolbox case, so let's
turn it on to match our approach with web content.
MozReview-Commit-ID: HT6qoIrwAHX
--HG--
extra : rebase_source : 4791025b3f77e412bb4fe8745f64aa4c5b69a809
Grid fragments returned by the chrome-only el.getGridFragments() API
may sometimes in fact be empty. When they are, the returned object still
looks like a fragment, but has either no rows or no columns.
So this commit simply adds a quick check on this in the css grid highlighter
before attempting to highlight a grid fragment.
MozReview-Commit-ID: GjsGu9hpU5G
--HG--
extra : rebase_source : 355073b26035ce02db11f51497c74f7746d35a77
The TAB handler for the source editor used to add indentSize - 1 spaces, unless the caret
was on the beginning of a line. This only ever works if you are pressing TAB after writing
one character. Otherwise we should always calculate the necessary spaces based on the caret
position (modulo indentSize)
MozReview-Commit-ID: EdcM4IhhyMk
--HG--
extra : rebase_source : 99957d8683f172d65213052e36281a24c7dffd2a
This changeset makes the classname variables-view-scope no longer able to
receive the focus. When tabbing through the variables view, going from the
variables-view-scope to the first variables-view-variable item has no
visual impact as their container occupy the same space.
Having to TAB twice without providing user feedback feels buggy.
MozReview-Commit-ID: It4EOV45A40
--HG--
extra : rebase_source : 5f865283613073fe72de98d012274a8d74dfe88f
- Fixed a bug on `getNodeBounds` that would makes the calculation wrong in case
of nested frames.
- Centralized all the transformation in `updateCurrentMatrix` function,
including the scaling due the zoom and display's pixel ratio, and the
translation to the top left corner of the node inspected.
- Added the transformation from the inspected node to the `currentMatrix`.
- Added `drawLine` and `drawRect` functions, that takes a matrix as argument.
- Position the line's number to the grid itself even when we've infinite lines
(it's not a regression, it is intended since if a grid is transformed, we
could have weird results otherwise, so we decided to uniform the behaviors).
MozReview-Commit-ID: 7OUfb6u63Qj
Ricky Chien
Julian Descottes
Michael Ratcliffe
Sebastian Hengst
Phil Ringnalda
J. Ryan Stinnett
Tom Tromey
Jan Odvarko
Patrick Brosset
Vangelis Katsikaros
Iris Hsiao
Brian Grinstead
Matt R
Wes Kocher
Matteo Ferretti
Carsten "Tomcat" Book
Boris Zbarsky
Daisuke Akatsuka
Ruturaj K. Vartak