gecko-dev/xpcom/io
Chris Peterson 30c0c4add0 Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj
clang's -Wcomma warning warns about suspicious use of the comma operator such as calling a function for side effects within an expression. Check NS_SUCCEEDED() to use HasMoreElement() in an expression and confirm that it actually returned a legitimate out parameter.

xpcom/io/nsLocalFileUnix.cpp:725:48 [-Wcomma] possible misuse of comma operator here
xpcom/io/nsLocalFileUnix.cpp:1053:39 [-Wcomma] possible misuse of comma operator here

MozReview-Commit-ID: aebrgc5Wqk

--HG--
extra : rebase_source : 18a2bbeb55ff106cdcb88e4889c7fd2745952a31
extra : source : e62ac5b8744d342948ab12f21f369d21f857a706
2017-04-03 11:05:57 -07:00
..
Base64.cpp Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj 2016-12-02 13:46:53 -08:00
Base64.h Bug 1275309 (part 1) - Add a variant of Base64Decode(). r=erahm. 2016-08-04 11:49:46 +10:00
CocoaFileUtils.h Bug 1305339 - part 2: use URI flags to determine if data is from the web, r=mstange,bz 2016-10-03 13:52:19 +01:00
CocoaFileUtils.mm Bug 1310518 - fix crashes when downloading files without referrer/source URL, r=mstange 2016-10-28 17:38:29 +01:00
FileUtilsWin.cpp Bug 1328569 - Don't call UnmapViewOfFile() with a null address. r=froydnj 2017-01-04 18:42:51 +08:00
FileUtilsWin.h
SlicedInputStream.cpp Bug 1355369 - SlicedInputStream must implement AsyncWait correctly, r=smaug 2017-04-12 13:49:08 +02:00
SlicedInputStream.h Bug 1355369 - SlicedInputStream must implement AsyncWait correctly, r=smaug 2017-04-12 13:49:08 +02:00
SnappyCompressOutputStream.cpp
SnappyCompressOutputStream.h
SnappyFrameUtils.cpp Bug 1275016 - Rename Endian.h to EndianUtils.h to avoid #include confusion with Android's endian.h stdlib header. r=froydnj 2016-05-22 13:31:11 -07:00
SnappyFrameUtils.h
SnappyUncompressInputStream.cpp
SnappyUncompressInputStream.h
SpecialSystemDirectory.cpp Bug 1344629 - Part 6: Rewrite unnecessary uses of nsLiteralString. r=dbaron 2017-03-14 15:26:27 +13:00
SpecialSystemDirectory.h Bug 1331171 - Part 1: Remove StartupSpecialSystemDirectory() workaround for Windows XP. r=jimm 2017-01-14 01:12:02 -08:00
crc32c.c
crc32c.h
moz.build Bug 1288997 - memory blob should not be shared across processes - part 2 - SlicedInputStream, r=froydnj 2016-07-25 22:41:02 +02:00
nsAnonymousTemporaryFile.cpp Bug 1346583 - Remove the PContent::Msg_OpenAnonymousTemporaryFile sync IPC; r=billm 2017-03-21 09:27:48 -04:00
nsAnonymousTemporaryFile.h
nsAppDirectoryServiceDefs.h Bug 1346716 - Remove the entry for "mimeTypes.rdf" in the directory service. r=mak 2017-03-30 15:51:18 +01:00
nsAppFileLocationProvider.cpp Bug 1295053 (part 3) - Don't use NS_METHOD for xpcom IO functions. r=froydnj. 2016-08-15 14:30:32 +10:00
nsAppFileLocationProvider.h Bug 1295053 (part 3) - Don't use NS_METHOD for xpcom IO functions. r=froydnj. 2016-08-15 14:30:32 +10:00
nsBinaryStream.cpp Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj. 2016-08-12 17:36:22 +10:00
nsBinaryStream.h
nsDirectoryService.cpp Bug 1287623, part 2 - Use StaticRefPtr for nsDirectoryService::gService. r=froydnj 2016-07-21 09:54:16 -07:00
nsDirectoryService.h Bug 1287623, part 2 - Use StaticRefPtr for nsDirectoryService::gService. r=froydnj 2016-07-21 09:54:16 -07:00
nsDirectoryServiceAtomList.h
nsDirectoryServiceDefs.h
nsDirectoryServiceUtils.h
nsEscape.cpp Backed out changeset 5739a7f790f2 (bug 1333899) for failing reftest svg-image-datauri-1.html on Linux opt and pgo. r=backout 2017-02-22 10:00:50 +01:00
nsEscape.h Backed out changeset 5739a7f790f2 (bug 1333899) for failing reftest svg-image-datauri-1.html on Linux opt and pgo. r=backout 2017-02-22 10:00:50 +01:00
nsIAsyncInputStream.idl
nsIAsyncOutputStream.idl Bug 1289811 - Give nsIOutputStreamCallback a [function] attribute. r=nfroyd 2016-07-28 14:18:00 -04:00
nsIBinaryInputStream.idl
nsIBinaryOutputStream.idl
nsICloneableInputStream.idl
nsIConverterInputStream.idl
nsIConverterOutputStream.idl
nsIDirectoryEnumerator.idl
nsIDirectoryService.idl
nsIFile.idl Backed out changeset c8fe57b085bd (bug 1333631) 2017-01-30 23:17:34 +01:00
nsIIOUtil.idl
nsIInputStream.idl Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj. 2016-08-12 17:36:22 +10:00
nsIInputStreamTee.idl
nsILineInputStream.idl
nsILocalFile.idl
nsILocalFileMac.idl
nsILocalFileWin.idl Bug 1279240 - move path parsing of commandline handlers for mimetypes/protocols to nsILocalFileWin, r=froydnj 2016-09-30 17:18:41 +01:00
nsIMultiplexInputStream.idl
nsIOUtil.cpp
nsIOUtil.h
nsIObjectInputStream.idl
nsIObjectOutputStream.idl
nsIOutputStream.idl Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj. 2016-08-12 17:36:22 +10:00
nsIPipe.idl Bug 1295825 (part 2) - Use [must_use] and MOZ_MUST_USE in nsIPipe.idl. r=froydnj. 2016-08-17 16:52:48 +10:00
nsISafeOutputStream.idl
nsIScriptableBase64Encoder.idl
nsIScriptableInputStream.idl
nsISeekableStream.idl
nsIStorageStream.idl
nsIStreamBufferAccess.idl
nsIStringStream.idl Bug 1315173 - Make nsIStringInputStream a builtinclass, r=valentin, r=njn 2016-11-07 08:45:42 +01:00
nsIUnicharInputStream.idl Bug 1294645 - Don't use NS_CALLBACK for callbacks in nsI{Input,Output,UnicharInput},Stream.idl. r=froydnj. 2016-08-12 17:36:22 +10:00
nsIUnicharLineInputStream.idl
nsIUnicharOutputStream.idl
nsInputStreamTee.cpp Bug 1060419 - make log_print use Printf.h, r=froydnj 2016-12-15 20:16:31 -07:00
nsLinebreakConverter.cpp Bug 1270310 - Part 2: Pass buffer length to Assign call in ConvertStringLineBreaks. r=froydnj 2016-05-05 15:52:16 -07:00
nsLinebreakConverter.h
nsLocalFile.h
nsLocalFileCommon.cpp
nsLocalFileUnix.cpp Bug 1356843 - Fix -Wcomma warnings in xpcom/io/nsLocalFileUnix.cpp. r=froydnj 2017-04-03 11:05:57 -07:00
nsLocalFileUnix.h
nsLocalFileWin.cpp Bug 1353544 - Replace usage of PR_BEGIN_MACRO in xpcom. r=froydnj 2017-04-05 18:06:44 -07:00
nsLocalFileWin.h Bug 1279240 - move path parsing of commandline handlers for mimetypes/protocols to nsILocalFileWin, r=froydnj 2016-09-30 17:18:41 +01:00
nsMultiplexInputStream.cpp Bug 1347557 - Move 2 static methods about the IPC serialization of streams into an helper class, r=qdot 2017-03-21 07:47:25 +01:00
nsMultiplexInputStream.h
nsNativeCharsetUtils.cpp Bug 1278156 - Remove useless null check in xp_iconv(). r=froydnj. 2016-06-03 14:59:16 +10:00
nsNativeCharsetUtils.h
nsPipe.h
nsPipe3.cpp Bug 1060419 - make log_print use Printf.h, r=froydnj 2016-12-15 20:16:31 -07:00
nsScriptableBase64Encoder.cpp
nsScriptableBase64Encoder.h
nsScriptableInputStream.cpp Bug 1258498: Use fallible allocation in nsScriptableInputStream::ReadBytes. r= froydnj 2016-03-21 13:49:18 -07:00
nsScriptableInputStream.h
nsSegmentedBuffer.cpp
nsSegmentedBuffer.h
nsStorageStream.cpp Bug 1060419 - make log_print use Printf.h, r=froydnj 2016-12-15 20:16:31 -07:00
nsStorageStream.h Bug 1295053 (part 3) - Don't use NS_METHOD for xpcom IO functions. r=froydnj. 2016-08-15 14:30:32 +10:00
nsStreamUtils.cpp Bug 1331804 - Add more runnable names (r=ehsan) 2017-01-24 16:34:37 -08:00
nsStreamUtils.h Bug 1295053 (part 3) - Don't use NS_METHOD for xpcom IO functions. r=froydnj. 2016-08-15 14:30:32 +10:00
nsStringStream.cpp Bug 1318165 - nsStringStream should report correctly the size of the internal buffer, r=njn 2016-11-25 08:24:51 +01:00
nsStringStream.h Bug 1240436 - Part3: Remove NS_NewStringInputStream to prevent misuse. r=froydnj 2016-04-14 18:55:50 +08:00
nsUnicharInputStream.cpp
nsUnicharInputStream.h
nsWildCard.cpp
nsWildCard.h