gecko-dev/security/certverifier
J.C. Jones f27f0bf4d1 Bug 1486838 - Enable EV treatment for Symantec/DigiCert cross signatures r=keeler
There is a late-breaking EV compatibility concern with cross signatures for EV
certificates:

Firefox's EV handling code always validates EV using the first EV policy OID
expressed in a certificate. For compatibility certificates issued under a cross-
signed root, if the first EV policy OID matches the original Symantec EV policy
OID, then Firefox will attempt to verify that the root CA matches the original
Symantec EV CA -- which it won't, as the root will be one of DigiCert's. Without
a patch, EV treatment will break.

This patch removes all EV policy OIDs for roots mentioned in TrustOverride-
SymantecData.inc, letting the moz::pkix algorithm pick other EV policy OIDs to
validate. I verified that I removed all affected OIDs using the BASH shell
commands:

$ cd security/certverifier
$ grep "CN=" TrustOverride-SymantecData.inc | sed -e 's/.*\(CN=.*\).*/\1/' |
  sort | uniq | while read r; do
    echo $r; grep "$r" ExtendedValidation.cpp;
  done

Reviewers should help me ensure that I did not remove any unexpected EV policy
OIDs.

Differential Revision: https://phabricator.services.mozilla.com/D4709

--HG--
extra : moz-landing-system : lando
2018-08-30 18:29:39 +00:00
..
tests/gtest Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj 2018-06-01 17:59:07 +02:00
BRNameMatchingPolicy.cpp
BRNameMatchingPolicy.h
BTInclusionProof.h Bug 1343202 - Utility function for decoding an InclusionProof structure; r=ckerschb,keeler 2017-08-18 09:50:49 +02:00
BTVerifier.cpp Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
BTVerifier.h Bug 1343202 - Utility function for decoding an InclusionProof structure; r=ckerschb,keeler 2017-08-18 09:50:49 +02:00
Buffer.cpp Bug 1343202 - Move Buffer definition into its own file; r=keeler,rbarnes 2017-08-17 09:23:29 +02:00
Buffer.h Bug 1343202 - Move Buffer definition into its own file; r=keeler,rbarnes 2017-08-17 09:23:29 +02:00
CTDiversityPolicy.cpp
CTDiversityPolicy.h
CTKnownLogs.h
CTLog.h
CTLogVerifier.cpp
CTLogVerifier.h
CTObjectsExtractor.cpp Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
CTObjectsExtractor.h
CTPolicyEnforcer.cpp
CTPolicyEnforcer.h
CTSerialization.cpp Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
CTSerialization.h
CTUtils.h Bug 1343202 - Utility function for decoding an InclusionProof structure; r=ckerschb,keeler 2017-08-18 09:50:49 +02:00
CTVerifyResult.cpp
CTVerifyResult.h
CertVerifier.cpp bug 1470030 - convert manually-written nsINSSComponent definition to idl r=fkiefer 2018-06-20 16:43:18 -07:00
CertVerifier.h Bug 1453795 - PSM-Security - Initialize member fields in classes/ structures. r=keeler 2018-06-18 12:31:47 +03:00
ExtendedValidation.cpp Bug 1486838 - Enable EV treatment for Symantec/DigiCert cross signatures r=keeler 2018-08-30 18:29:39 +00:00
ExtendedValidation.h bug 1421084 - part 4/4 - remove nsNSSShutDown.h and (hopefully) all references to it r=mt,ttaubert 2018-01-24 14:44:01 -08:00
MultiLogCTVerifier.cpp Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
MultiLogCTVerifier.h
NSSCertDBTrustDomain.cpp Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj 2018-06-01 10:45:27 +02:00
NSSCertDBTrustDomain.h bug 1464520 - hard-code the builtin roots module name to avoid a dependency on l10n in nsNSSComponent r=fkiefer,jcj 2018-05-25 11:22:48 -07:00
OCSPCache.cpp
OCSPCache.h
OCSPVerificationTrustDomain.cpp
OCSPVerificationTrustDomain.h
SignedCertificateTimestamp.cpp Bug 1343202 - Move Buffer definition into its own file; r=keeler,rbarnes 2017-08-17 09:23:29 +02:00
SignedCertificateTimestamp.h Bug 1343202 - Move Buffer definition into its own file; r=keeler,rbarnes 2017-08-17 09:23:29 +02:00
SignedTreeHead.h
TrustOverride-AppleGoogleDigiCertData.inc Bug 1434300 - Add the DigiCert whitelisted SPKIs r=keeler 2018-02-21 14:08:59 -05:00
TrustOverride-GlobalSignData.inc Bug 1409259 - Refactor "TrustOverrides" header for existing trust overrides r=keeler 2017-10-16 23:17:52 -07:00
TrustOverride-StartComAndWoSignData.inc Bug 1409259 - Refactor "TrustOverrides" header for existing trust overrides r=keeler 2017-10-16 23:17:52 -07:00
TrustOverride-SymantecData.inc Bug 1434300 - Add a utility to match certificates based on SPKI r=fkiefer,keeler 2018-02-21 14:08:44 -05:00
TrustOverride-TestImminentDistrustData.inc Bug 1439378 - Re-enable the imminent distrust browser-console test r=fkiefer,keeler 2018-02-26 15:55:35 -07:00
TrustOverrideUtils.h Bug 1470985 - s/PodEqual/ArrayEqual/ from ArrayUtils.h. - r=waldo 2018-07-27 14:11:18 -07:00
moz.build Bug 1090497 - Re-enable warnings as errors on clang-cl. r=froydnj 2018-07-31 22:10:07 +09:00