gecko-dev/widget/cocoa
Emilio Cobos Álvarez 9210241675 Bug 1872399 - Remove window shadow rim from cocoa window panels. r=mac-reviewers,mstange
macOS will draw a thin rim / border around the contents, and there's no
easy way to disable this behavior.

That's fine for native-like menus / tooltips, but not for panels where
we draw custom borders. For those, this rim looks odd on top of our
border.

There's [1] with exactly this question, but that's ancient and no longer
works.

Some decompilation of AppKit might have been involved in figuring this
out, but since we're already overriding shadowOptions, it probably seems
reasonable to do this, rather than giving up on macOS' native shadows,
in particular because that would need custom hit-testing (the
-moz-input-region-margin code) which seems non-trivial to do on macOS
too...

I did it in the most forward-compatible way possible (just overriding if
there was a key).

[1]: https://stackoverflow.com/questions/6167692/nswindow-shadow-outline

Differential Revision: https://phabricator.services.mozilla.com/D197455
2024-01-17 16:29:10 +00:00
..
crashtests
cursors
docs Bug 1845144 Part 1: Update build configs with minimum macOS 10.15 target, update docs. r=glandium 2023-08-02 02:26:14 +00:00
resources/MainMenu.nib
AppearanceOverride.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
AppearanceOverride.mm Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
CFTypeRefPtr.h
CustomCocoaEvents.h
DesktopBackgroundImage.h
DesktopBackgroundImage.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
GfxInfo.h
GfxInfo.mm Bug 1837824 - Nightly fails to start in macOS Sonoma virtual machine r=jrmuizel,haik 2023-10-31 06:14:16 +00:00
MOZIconHelper.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
MOZIconHelper.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
MOZMenuOpeningCoordinator.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
MOZMenuOpeningCoordinator.mm Bug 1804978: Prevent release assert crashes due to a race when opening context menus on macOS. r=mstange 2024-01-16 20:26:31 +00:00
MacThemeGeometryType.h Bug 1861954 - Remove vibrancy on the osx sidebar. r=desktop-theme-reviewers,dao 2023-11-01 09:05:51 +00:00
MediaHardwareKeysEventSourceMac.h
MediaHardwareKeysEventSourceMac.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
MediaHardwareKeysEventSourceMacMediaCenter.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
MediaHardwareKeysEventSourceMacMediaCenter.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
MediaKeysEventSourceFactory.cpp Bug 1847154 - cocoa: remove some unnecessary OnMojaveOrLater() and OnCatalinaOrLater() version checks. r=mac-reviewers,bradwerth 2023-08-10 15:27:05 +00:00
NativeKeyBindings.h
NativeKeyBindings.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
NativeMenuMac.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
NativeMenuMac.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
NativeMenuSupport.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
OSXNotificationCenter.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
OSXNotificationCenter.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
ScreenHelperCocoa.h
ScreenHelperCocoa.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
TextInputHandler.h Bug 1872505 - Use NSString in InsertText* paths. r=m_kato 2024-01-02 08:37:26 +00:00
TextInputHandler.mm Bug 1872505 - Use NSString in InsertText* paths. r=m_kato 2024-01-02 08:37:26 +00:00
TextRecognition.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
VibrancyManager.h Bug 1861954 - Remove vibrancy on the osx sidebar. r=desktop-theme-reviewers,dao 2023-11-01 09:05:51 +00:00
VibrancyManager.mm Bug 1861954 - Remove vibrancy on the osx sidebar. r=desktop-theme-reviewers,dao 2023-11-01 09:05:51 +00:00
ViewRegion.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
ViewRegion.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
WidgetTraceEvent.mm
components.conf Bug 1859643 - Remove nsSoundProxy. r=spohl,win-reviewers 2023-11-06 16:27:07 +00:00
metrics.yaml Bug 1832454: Remove the startup.is_restored_by_macos glean metric. r=chutten 2023-06-15 17:46:16 +00:00
moz.build Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
mozView.h
nsAppShell.h Backed out changeset 4bbe309179a5 (bug 1866098) for causing bc failures related to browser_startup. CLOSED TREE 2023-11-30 06:32:21 +02:00
nsAppShell.mm Backed out changeset 4bbe309179a5 (bug 1866098) for causing bc failures related to browser_startup. CLOSED TREE 2023-11-30 06:32:21 +02:00
nsBidiKeyboard.h
nsBidiKeyboard.mm
nsChangeObserver.h
nsChildView.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsChildView.mm Bug 1872997 - [cocoa] Don't trigger mouseenter/leave events for windows that ignore mouse events. r=mac-reviewers,mstange 2024-01-10 22:51:28 +00:00
nsClipboard.h Bug 1856052 - Remove unused parameter from SetNativeClipboardData; r=geckoview-reviewers,win-reviewers,spohl,mhowell,m_kato 2023-10-17 13:15:31 +00:00
nsClipboard.mm Bug 1862956 - Use `FlavorsTransferableCanExport` to get the available flavor list from cached transferable; r=nika,spohl 2023-11-03 16:50:11 +00:00
nsCocoaFeatures.h Bug 1844845 - Remove OnSierraExactly(), OnHighSierraOrLater(), OnMojaveOrLater(), and OnCatalinaOrLater(). r=mac-reviewers,bradwerth 2023-09-12 05:39:05 +00:00
nsCocoaFeatures.mm Bug 1844845 - Remove OnSierraExactly(), OnHighSierraOrLater(), OnMojaveOrLater(), and OnCatalinaOrLater(). r=mac-reviewers,bradwerth 2023-09-12 05:39:05 +00:00
nsCocoaUtils.h Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsCocoaUtils.mm Bug 1853370 - Replace deprecated constants r=mstange,spohl 2023-09-15 20:42:43 +00:00
nsCocoaWindow.h Bug 1872399 - Remove window shadow rim from cocoa window panels. r=mac-reviewers,mstange 2024-01-17 16:29:10 +00:00
nsCocoaWindow.mm Bug 1872399 - Remove window shadow rim from cocoa window panels. r=mac-reviewers,mstange 2024-01-17 16:29:10 +00:00
nsColorPicker.h
nsColorPicker.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsCursorManager.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsCursorManager.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsDeviceContextSpecX.h Bug 1833244 p1. Create infrastructure to pass page dimensions to PrintTarget::BeginPage. r=dholbert,geckoview-reviewers,jonalmeida 2023-07-10 14:26:12 +00:00
nsDeviceContextSpecX.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsDragService.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsDragService.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsFilePicker.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsFilePicker.mm Bug 1853370 - Replace deprecated constants r=mstange,spohl 2023-09-15 20:42:43 +00:00
nsLookAndFeel.h
nsLookAndFeel.mm Bug 1871514 - Improve macOS control colors. r=mac-reviewers,emilio 2024-01-10 22:22:52 +00:00
nsMacCursor.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsMacCursor.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMacDockSupport.h
nsMacDockSupport.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMacFinderProgress.h
nsMacFinderProgress.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMacSharingService.h
nsMacSharingService.mm Bug 1853370 - Replace deprecated constants r=mstange,spohl 2023-09-15 20:42:43 +00:00
nsMacUserActivityUpdater.h
nsMacUserActivityUpdater.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMacWebAppUtils.h
nsMacWebAppUtils.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMenuBarX.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsMenuBarX.mm Bug 1478347: Ensure that macOS-provided menu items are available in the Edit menu, especially in multi-language environments where Firefox may have a different language than the OS. r=mstange 2023-11-28 03:11:40 +00:00
nsMenuGroupOwnerX.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsMenuGroupOwnerX.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMenuItemIconX.h
nsMenuItemIconX.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsMenuItemX.h
nsMenuItemX.mm Bug 1478347: Ensure that macOS-provided menu items are available in the Edit menu, especially in multi-language environments where Firefox may have a different language than the OS. r=mstange 2023-11-28 03:11:40 +00:00
nsMenuParentX.h
nsMenuUtilsX.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsMenuUtilsX.mm Bug 1870924: Prevent crashes when trying to access the menu bar in headless mode. r=mac-reviewers,bradwerth 2023-12-23 06:52:28 +00:00
nsMenuX.h Bug 1858409 - only show autofill/services menus when appropriate, r=mac-reviewers,reusable-components-reviewers,mstange,emilio,tgiles 2023-12-14 08:27:56 +00:00
nsMenuX.mm Bug 1858409 - only show autofill/services menus when appropriate, r=mac-reviewers,reusable-components-reviewers,mstange,emilio,tgiles 2023-12-14 08:27:56 +00:00
nsNativeThemeCocoa.h Bug 1861954 - Remove vibrancy on the osx sidebar. r=desktop-theme-reviewers,dao 2023-11-01 09:05:51 +00:00
nsNativeThemeCocoa.mm Bug 1870481 - Restore unified toolbar window looks. r=mac-reviewers,desktop-theme-reviewers,dao,spohl 2023-12-18 16:19:36 +00:00
nsNativeThemeColors.h Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsPIWidgetCocoa.idl
nsPrintDialogX.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsPrintDialogX.mm Bug 1853370 - Replace deprecated constants r=mstange,spohl 2023-09-15 20:42:43 +00:00
nsPrintSettingsServiceX.h
nsPrintSettingsServiceX.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsPrintSettingsX.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsPrintSettingsX.mm Bug 1865485. Rename nsIPrintSettings::HasOrthogonalSheetsAndPages to HasOrthogonalPagesPerSheet. r=dholbert 2023-11-20 09:14:50 +00:00
nsSandboxViolationSink.h
nsSandboxViolationSink.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsSound.h
nsSound.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsStandaloneNativeMenu.h
nsStandaloneNativeMenu.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsSystemStatusBarCocoa.h
nsSystemStatusBarCocoa.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsToolkit.h
nsToolkit.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsTouchBar.h Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsTouchBar.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsTouchBarInput.h Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsTouchBarInput.mm Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsTouchBarInputIcon.h Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsTouchBarInputIcon.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsTouchBarUpdater.h
nsTouchBarUpdater.mm Bug 1851946 - Remove outdated mac SDK-version checks. r=mac-reviewers,media-playback-reviewers,bradwerth,alwu 2023-09-08 01:44:07 +00:00
nsUserIdleServiceX.h Bug 1836980 - Move the check for late instantiation to UserIdleService[type] specializations. r=kmag,xpcom-reviewers,geckoview-reviewers,m_kato 2023-06-07 06:27:52 +00:00
nsUserIdleServiceX.mm Bug 1851529 - Set clang-format ColumnLimit consistently. r=sylvestre,necko-reviewers,kershaw 2023-09-05 11:23:01 +00:00
nsWidgetFactory.h
nsWidgetFactory.mm
nsWindowMap.h Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
nsWindowMap.mm Bug 1846205 - Use key state change to send activate/deactivate event when a modal window is opened; r=spohl,mac-reviewers 2023-09-26 08:50:14 +00:00