gecko-dev/widget
Masayuki Nakano df8f5c37dc Bug 1430628 - TextInputHandler::HandleCommand() should use native key event when it dispatches a keypress event either initializing with native event or creating fake event r=m_kato
TextInputHandler::HandleCommand() has two bugs.  One is, checking whether
the key event has caused composition events.  Even if it caused composition
events, we decided to dispatch keypress event for emulating native behavior.
Therefore, this patch removes the check of
|currentKeyEvent->CanDispatchKeyPress()|.

The other is, for making content handle dispatching keypress event as given
command, it needs to dispatch a keypress event whose key combination will
cause the command.  However, HandleCommand() needs to set native key event
since content may not refer key combination for some edit actions, they just
refer command which is computed with native key event with NativeKeyBindings.
Therefore, even if current native key event has already caused dispatching
some events, HandleCommand() needs to set
WidgetKeyboardEvent::mNativeKeyEvent to current native key event for
NativeKeyBindings.  Although it must be rare case, given key could be
not related to the command or not key could cause the command.  In this
case, and perhaps in all cases, we should set all commands of dispatching
keypress event before dispatching it.  Howevever, this needs more work,
so, we shouldn't do it in this bug to making it possible to uplift.
Therefore, this patch makes always set mNativeKeyEvent to current native
key event.  So, just warning it when command is caused without native
key event.

MozReview-Commit-ID: 2MvDTw4ruAu

--HG--
extra : rebase_source : 02a4ca980530aa16fa0e1aecd6d18fa42873c1dc
extra : source : 1e3137db3fe9822f34b98d59fb928497caca466a
2018-01-24 19:13:01 +09:00
..
android Merge autoland to mozilla-central. a=merge 2018-01-24 23:54:03 +02:00
cocoa Bug 1430628 - TextInputHandler::HandleCommand() should use native key event when it dispatches a keypress event either initializing with native event or creating fake event r=m_kato 2018-01-24 19:13:01 +09:00
crashtests Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
gtk Bug 1418361 - push GTK window background color rect for WR. r=nical 2018-01-22 08:01:09 -05:00
gtkxtbin Bug 1381253 - Remove redundant control flow declarations rs=ehsan 2017-07-15 19:03:04 +02:00
headless Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE 2018-01-24 22:04:59 -08:00
reftests Bug 1417200: Make -moz-border-colors chrome only. r=xidorn 2017-12-01 23:25:01 +01:00
tests Backed out 3 changesets (bug 1431533) for Android mochitest bustage. CLOSED TREE 2018-01-24 22:04:59 -08:00
uikit Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj 2017-11-05 19:37:28 -08:00
windows Bug 1425458 - Resource timing entries Workers - part 0 - NS_NewChannel, r=smaug 2018-01-24 17:17:31 +01:00
x11 Bug 1355089 - add BUG_COMPONENT to widget/* files. r=mstange,jimm 2017-04-14 05:54:36 -04:00
xremoteclient Bug 1430018 - Fixed wrong profile param name at DBusRemoteClient::DoSendDBusCommandLine(), r=jhorak 2018-01-12 12:57:37 +01:00
BasicEvents.h Bug 1425441 - Move relatedTarget to WidgetEvent, r=stone 2017-12-18 19:08:11 +02:00
CommandList.h Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato 2017-12-02 14:53:10 +09:00
CompositorWidget.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
CompositorWidget.h Bug 1425842 - Rename X11CompositorWidget to GtkCompositorWidget and implement WindowSurfaceWayland support, r=jhorak 2017-12-18 20:20:02 +01:00
ContentCache.cpp Bug 1422230 - part 2: ContentCacheInParent should allow to query content relative to composition string even after sending eCompositionCommit(AsIs) event but not yet handled in the remote process r=m_kato 2018-01-12 15:05:24 +09:00
ContentCache.h Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
ContentEvents.h Bug 1425441 - Move relatedTarget to WidgetEvent, r=stone 2017-12-18 19:08:11 +02:00
EventClassList.h Bug 1314388 - Remove SVGZoomEvent; r=longsonr,smaug 2017-04-04 15:36:22 +03:00
EventForwards.h Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato 2017-12-02 14:53:10 +09:00
EventMessageList.h Bug 1359017 - onmessageerror for WindowEventHandlers in case StructuredClone algorithm fails when deserializing, r=masayuki, r=smaug 2017-09-13 05:59:06 +02:00
FontRange.h Bug 1377169 - Turn gfxRect into a typedef. r=jrmuizel 2017-07-05 11:22:00 -04:00
GfxDriverInfo.cpp BUG 1428174 - Add Qualcomm to Windows GPU Whitelist r=jrmuizel 2018-01-05 17:28:02 -08:00
GfxDriverInfo.h BUG 1428174 - Add Qualcomm to Windows GPU Whitelist r=jrmuizel 2018-01-05 17:28:02 -08:00
GfxInfoBase.cpp Add tiling and paint worker count information to about:support. (bug 1432516, r=milan) 2018-01-23 15:52:13 -06:00
GfxInfoBase.h Add tiling and paint worker count information to about:support. (bug 1432516, r=milan) 2018-01-23 15:52:13 -06:00
GfxInfoCollector.cpp
GfxInfoCollector.h
GfxInfoWebGL.cpp
GfxInfoWebGL.h
GfxInfoX11.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
GfxInfoX11.h Backed out changeset cf43cacdb262 (bug 1294232) for XPCShell failures 2016-09-21 14:24:26 +08:00
IMEData.h Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
InProcessCompositorWidget.cpp Bug 1413217 - Fix some includes etc. in widget code. r=jimm 2017-10-12 17:03:35 +01:00
InProcessCompositorWidget.h Bug 1329362 - part 2, Add accessor functions for EGLNativeWindowType, ANativeWindow, and EGLSurface to AndroidCompositorWidget r=dvander,kats 2017-01-27 09:32:24 -08:00
InputData.cpp Bug 951793 - Obey overscroll-behavior for swipe navigation. r=mstange 2017-11-25 01:29:15 +01:00
InputData.h Bug 951793 - Obey overscroll-behavior for swipe navigation. r=mstange 2017-11-25 01:29:15 +01:00
LSBUtils.cpp Bug 1401786 - Move base::LaunchApp options into a LaunchOptions struct, like upstream Chromium. r=billm 2017-09-08 20:35:06 -06:00
LSBUtils.h Bug 1289561 - Implement LSB release annotation in crash reports. r=jrmuizel 2016-07-26 14:23:47 -04:00
LookAndFeel.h Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE 2017-11-23 01:17:07 +02:00
MiscEvents.h Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00
MouseEvents.h Bug 1425441 - Move relatedTarget to WidgetEvent, r=stone 2017-12-18 19:08:11 +02:00
NativeKeyToDOMCodeName.h Bug 1389598 - Part 4: Remove remaining gonk refs. r=froydnj 2017-08-11 17:45:18 -07:00
NativeKeyToDOMKeyName.h Bug 1386825 - Part 4: Remove remaining instances of MOZ_B2G. r=froydnj 2017-08-08 14:41:09 -07:00
PCompositorWidget.ipdl
PlatformWidgetTypes.ipdlh Bug 1373739 - Make macOS compatible with the headless WPT changes. r=bdahl 2017-07-28 23:20:21 -07:00
PluginWidgetProxy.cpp Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm 2017-02-09 11:53:50 -05:00
PluginWidgetProxy.h Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm 2017-02-09 11:53:50 -05:00
PuppetBidiKeyboard.cpp
PuppetBidiKeyboard.h
PuppetWidget.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
PuppetWidget.h Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
Screen.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
Screen.h Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
ScreenManager.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
ScreenManager.h Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame 2017-04-13 07:20:35 +09:00
SharedWidgetUtils.cpp
SystemTimeConverter.h
TextEventDispatcher.cpp Bug 1422230 - part 1: TextEventDispatcher should manage if dispatched composition events have been handled by remote content and TSFTextStore refer the state r=m_kato 2018-01-12 11:31:53 +09:00
TextEventDispatcher.h Bug 1422230 - part 1: TextEventDispatcher should manage if dispatched composition events have been handled by remote content and TSFTextStore refer the state r=m_kato 2018-01-12 11:31:53 +09:00
TextEventDispatcherListener.h Bug 1296220 Rename nsIMEUpdatePreference to mozilla::widget::IMEUpdatePreference r=m_kato 2017-04-11 21:24:55 +09:00
TextEvents.h Bug 1423773 - Part 1: Remove usage of nsStringGlue.h. r=glandium 2017-12-06 16:52:51 -08:00
TextRange.h Bug 1386411 - Part 3: Inline some helper functions in Selection.cpp; r=bzbarsky 2017-08-03 17:05:19 -04:00
TouchEvents.h
VsyncDispatcher.cpp Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 2017-06-26 14:19:58 -07:00
VsyncDispatcher.h
WidgetEventImpl.cpp Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato 2017-12-02 14:53:10 +09:00
WidgetMessageUtils.h
WidgetTraceEvent.h
WidgetUtils.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
WidgetUtils.h Bug 1151753 - Set program class name when not using --class command line option. r=karlt 2017-10-25 15:58:49 +09:00
WindowSurface.h Bug 1319554 - allow WindowSurfaceX11Image to render to any visual format. r=rhunt 2016-12-01 12:15:58 -05:00
WindowSurfaceX11SHM.cpp
WindowSurfaceX11SHM.h
moz.build Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsAppShellSingleton.h
nsAutoRollup.cpp Bug 1343977 - Ensure that synthetic mouseclicks generated from touch gestures don't reopen rollups. r=botond,enndeakin+6102 2017-03-13 10:44:59 -04:00
nsAutoRollup.h Bug 1413217 - Fix some includes etc. in widget code. r=jimm 2017-10-12 17:03:35 +01:00
nsBaseAppShell.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
nsBaseAppShell.h
nsBaseClipboard.cpp Bug 1261299 - Implement nsIClipboard methods in nsClipboard.mm with methods specific for osx. (EmptyClipboard, SetData) methods modified from nsBaseClipboard to also set the current selection cache. r=jimm 2016-08-11 16:43:32 -04:00
nsBaseClipboard.h Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsBaseDragService.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
nsBaseDragService.h Bug 1295272 - Discard internal DataTransferItem data in nsBaseDragService::EndDragSession - r=enndeakin 2016-11-28 11:39:22 +00:00
nsBaseFilePicker.cpp Bug 1390428 (part 9) - Remove nsXPIDLCString. r=erahm. 2017-08-17 15:29:03 +10:00
nsBaseFilePicker.h Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj 2017-11-05 19:37:28 -08:00
nsBaseScreen.cpp Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsBaseScreen.h Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsBaseWidget.cpp Bug 1430797 - Follow-up to address review comment. r=mstange 2018-01-17 08:59:38 -05:00
nsBaseWidget.h Bug 1377321 - Only use WebRender for top-level windows and remote content. r=kats 2018-01-15 14:38:19 +01:00
nsClipboardHelper.cpp
nsClipboardHelper.h
nsClipboardProxy.cpp Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsClipboardProxy.h
nsColorPickerProxy.cpp Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsColorPickerProxy.h Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm 2016-11-15 04:26:00 +01:00
nsContentProcessWidgetFactory.cpp Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsDeviceContextSpecProxy.cpp Bug 1414834 - re-land print IPC changes from bug 1319423; r=bobowen 2017-11-03 14:37:15 -04:00
nsDeviceContextSpecProxy.h Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj 2017-11-05 19:37:28 -08:00
nsDragServiceProxy.cpp backout Bug 1414204 because of regressions, r=backout 2018-01-03 18:42:50 +02:00
nsDragServiceProxy.h backout Bug 1414204 because of regressions, r=backout 2018-01-03 18:42:50 +02:00
nsFilePickerProxy.cpp Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsFilePickerProxy.h Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsGUIEventIPC.h Bug 1401111 - Use ContiguousEnumSerializer for EventMessage ParamTraits; r=botond 2017-12-01 13:00:56 -05:00
nsHTMLFormatConverter.cpp Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods. r=froydnj 2017-10-21 23:53:02 +09:00
nsHTMLFormatConverter.h Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsIAppShell.idl
nsIApplicationChooser.idl
nsIBaseWindow.idl Bug 1402255 - Change nsIBaseWindow::title from wstring to AString. r=janv. 2017-09-25 13:10:51 +10:00
nsIBidiKeyboard.idl
nsIClipboard.idl
nsIClipboardDragDropHookList.idl
nsIClipboardDragDropHooks.idl
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDeviceContextSpec.h
nsIDisplayInfo.idl
nsIDragService.idl Bug 1361579 - Remove nsISimpleContentPolicy. r=Ehsan 2017-08-03 17:50:00 +09:00
nsIDragSession.idl Bug 1309596, add an updateDragImage method to modify the drag feedback image during the drag, r=smaug 2016-12-23 18:09:44 -05:00
nsIFilePicker.idl Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsIFormatConverter.idl Bug 1310017 - Remove nsISupportsArray usage from nsITransferable and nsIFormatConverter. r=smaug 2016-10-16 12:43:56 -07:00
nsIGfxInfo.idl Add tiling and paint worker count information to about:support. (bug 1432516, r=milan) 2018-01-23 15:52:13 -06:00
nsIGfxInfoDebug.idl
nsIIdleService.idl
nsIIdleServiceInternal.idl
nsIJumpListBuilder.idl Bug 1354143 - Commit jump list on lazy idle thread. r=florian,jimm 2017-05-24 16:38:57 +08:00
nsIJumpListItem.idl
nsIKeyEventInPluginCallback.h
nsIMacDockSupport.idl
nsIMacWebAppUtils.idl
nsINativeMenuService.h Bug 1423167: Move most attribute-related methods from nsIContent to Element. r=bz 2017-12-06 16:05:59 +01:00
nsIPluginWidget.h
nsIPrintDialogService.h
nsIPrintSession.idl
nsIPrintSettings.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrintSettingsService.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrintSettingsWin.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrinterEnumerator.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIRollupListener.h
nsIScreen.idl Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsIScreenManager.idl Bug 1356023 - Remove nsIScreenManager.systemDefaultScale. r=jfkthame 2017-04-13 07:20:35 +09:00
nsISound.idl
nsIStandaloneNativeMenu.idl
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl Bug 1387802 - Remove [deprecated] methods from nsITaskbarPreviewController. r=jimm 2017-08-06 13:35:02 +09:00
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl Bug 1387802 - Remove [deprecated] methods from nsITaskbarPreviewController. r=jimm 2017-08-06 13:35:02 +09:00
nsITransferable.idl Bug 1361579 - Remove nsISimpleContentPolicy. r=Ehsan 2017-08-03 17:50:00 +09:00
nsIWidget.h Bug 1293362 - Part 4: Generate runtime bindings for calling xpcom methods from rust, r=froydnj 2018-01-23 17:27:26 -05:00
nsIWidgetListener.cpp Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange 2017-10-18 21:50:47 -04:00
nsIWidgetListener.h Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange 2017-10-18 21:50:47 -04:00
nsIWinTaskbar.idl
nsIWindowsUIUtils.idl
nsIdleService.cpp Bug 1404198: Part 2d - Switch to NS_NewTimer* in widget. r=njn 2017-10-15 23:12:54 -07:00
nsIdleService.h
nsNativeTheme.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
nsNativeTheme.h Bug 1399956 - Add basic hard coded GTK theme in headless. r=jrmuizel 2017-10-16 16:15:45 -07:00
nsPrimitiveHelpers.cpp Bug 1390428 (part 2, attempt 2) - Remove more nsXPIDLCString local variables. r=erahm. 2017-08-21 20:01:27 +10:00
nsPrimitiveHelpers.h Bug 1393547 - Add missing nsACString declarations in widget/nsPrimitiveHelpers.h. r=mconley 2017-08-24 11:18:00 -04:00
nsPrintSession.cpp
nsPrintSession.h
nsPrintSettingsImpl.cpp Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsPrintSettingsImpl.h Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsPrintSettingsService.cpp Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsPrintSettingsService.h Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsShmImage.cpp Bug 1397918 - don't use versions of libxcb before 1.11.1. r=karlt 2017-09-22 00:10:35 -04:00
nsShmImage.h Bug 1321129 - make nsShmImage stride compatible with XShm. r=karlt 2017-02-21 10:00:52 -05:00
nsSoundProxy.cpp Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsSoundProxy.h Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsTransferable.cpp Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods. r=froydnj 2017-10-21 23:53:02 +09:00
nsTransferable.h Backed out 3 changesets (bug 335545) for asan failures in test_bug1123480.xul a=backout 2017-09-26 15:26:07 -07:00
nsWidgetInitData.h Backout 84bcb5742e0c (bug 1405577) to replace with a slimmer patch. r=me 2017-12-04 15:06:26 -05:00
nsWidgetsCID.h Bug 144114 part 4 - Remove NS_PRINTOPTIONS_CID. r=bobowen 2017-12-19 11:21:53 +00:00
nsXPLookAndFeel.cpp Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE 2017-11-23 01:17:07 +02:00
nsXPLookAndFeel.h Bug 1387594 - Add system colors for use in conjunction with -moz-font-smoothing-background-color and vibrant -moz-appearances. r=dbaron 2017-09-14 23:09:48 +02:00