gecko-dev/browser
Gijs Kruitbosch 582b8ef5c5 Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk
In search.js, _updateSuggestionCheckboxes is already hooked up to update this checkbox
based on the preference value, including change handlers for when it changes. As a result,
having both the preference attribute and the 'manual' JS means that the actual checked and
disabled state races with which code sets the value first.

The search suggestion order preference already doesn't have a preference attribute and is
only ever updated via the JS. It seems sensible to do the same here.

MozReview-Commit-ID: Cm8evlembt7

--HG--
extra : rebase_source : 41a55211c08c911ac234ea3cbe004391d86e4a3b
2018-02-16 17:30:34 +00:00
..
app No bug, Automated blocklist update from host bld-linux64-spot-302 - a=blocklist-update 2018-02-20 11:59:29 -08:00
base Bug 1434621 - part 1: vertically center title bar buttons on Linux. r=stransky 2018-02-21 16:39:59 +01:00
branding Bug 1435458 - Preprocess the official firefox-branding.js. r=glandium 2018-02-09 17:48:05 -08:00
components Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk 2018-02-16 17:30:34 +00:00
config Backed out changeset b33237dcbabf (bug 1439365) for mochitest failures at browser/components/resistfingerprinting/test/mochitest/test_animation_api.html on a CLOSED TREE 2018-02-20 16:16:33 +02:00
docs Bug 1388902 remove socialapi share, r=florian 2017-08-16 08:54:21 -07:00
experiments Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
extensions Bug 1433485 - Update test prefs for telemetry; r=mythmon,dexter 2018-02-21 10:57:04 -07:00
fonts
installer Bug 1438270 - Remove nsIDOMDocumentXBL. r=bz 2018-02-14 20:10:45 +01:00
locales Bug 1437230 - Remove feed binding and build DOM using JS. r=Gijs 2018-02-19 12:45:03 +00:00
modules Backed out changeset 29569f02015d 2018-02-20 20:27:32 +01:00
themes Bug 1434621 - part 1: vertically center title bar buttons on Linux. r=stransky 2018-02-21 16:39:59 +01:00
tools/mozscreenshots Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
.eslintrc.js Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop 2018-02-07 16:16:09 +00:00
LICENSE
Makefile.in
app.mozbuild
build.mk
confvars.sh Bug 1415206 - Remove RustURL from Gecko r=bagder 2017-11-07 17:11:08 +01:00
defs.mk
moz.build Backed out 2 changesets (bug 1403519) for bustage on \python\mozbuild\mozbuild\test\frontend\test_reader.py on a CLOSED TREE 2018-01-17 07:23:40 +02:00
moz.configure