gecko-dev/browser/components
Gijs Kruitbosch 582b8ef5c5 Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk
In search.js, _updateSuggestionCheckboxes is already hooked up to update this checkbox
based on the preference value, including change handlers for when it changes. As a result,
having both the preference attribute and the 'manual' JS means that the actual checked and
disabled state races with which code sets the value first.

The search suggestion order preference already doesn't have a preference attribute and is
only ever updated via the JS. It seems sensible to do the same here.

MozReview-Commit-ID: Cm8evlembt7

--HG--
extra : rebase_source : 41a55211c08c911ac234ea3cbe004391d86e4a3b
2018-02-16 17:30:34 +00:00
..
about Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled. r=ursula 2018-02-13 16:53:50 -08:00
build Bug 1352497 - Remove about:healthreport. r=gfritzsche,nechen 2017-11-28 11:38:15 +01:00
contextualidentity Backed out 2 changesets (bug 1417138) for failing test_message_manager_ipc.html on Android. CLOSED TREE 2018-02-16 20:37:36 +02:00
controlcenter/content Bug 1414244 - Part 6 - Fold the "photonpanelmultiview" binding into "panelmultiview". r=Gijs 2017-11-21 14:21:32 +00:00
customizableui Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug 2018-02-15 04:15:39 +09:00
dirprovider Bug 1405670 - remove support for NS_APP_SEARCH_DIR_LIST and NS_APP_SEARCH_DIR from the directory service, r=adw. 2017-11-17 12:05:20 +01:00
downloads Bug 1436508 part 10. Remove use of nsIDOMKeyEvent in JS. r=masayuki 2018-02-09 11:17:09 -05:00
enterprisepolicies Bug 1433485 - Update test prefs for telemetry; r=mythmon,dexter 2018-02-21 10:57:04 -07:00
extensions Bug 1438663 - Disable browser/components/extensions/test/browser/test-oop-extensions/browser_ext_popup_focus.js for frequent failures. r=aryx 2018-02-21 11:36:00 +02:00
feeds Bug 1436808: Apply Meta CSP to content privileged about: pages. r=gijs,freddyb 2018-02-09 11:42:21 +01:00
migration Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE 2018-02-20 23:01:54 +02:00
newtab Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled. r=ursula 2018-02-13 16:53:50 -08:00
originattributes Bug 1433324 - Part 3. Assume true for browser.newtabpage.activity-stream.enabled. r=ursula 2018-02-13 16:53:50 -08:00
places Bug 1439313 - delay loading Places treeview.js until necessary. r=florian 2018-02-19 18:31:19 +01:00
preferences Bug 1438180 - don't update the url bar search suggestions pref directly, r=jaws,f=myk 2018-02-16 17:30:34 +00:00
privatebrowsing Bug 1433324 - Part 1. Assume true for browser.newtabpage.activity-stream.aboutHome.enabled. r=ursula 2018-02-13 14:48:49 -08:00
resistfingerprinting Backed out changeset 5db4200c90a8 (bug 1438953)for mochitest failures at browser/components/resistfingerprinting/test/mochitest/test_animation_api.html 2018-02-20 16:46:58 +02:00
safebrowsing/content/test Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
search Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug 2018-02-15 04:15:39 +09:00
sessionstore Bug 1435394 - Disable browser/components/sessionstore/test/browser_upgrade_backup.js for frequent failures on Linux debug & asan. r=jmaher 2018-02-21 11:29:36 +02:00
shell Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
syncedtabs Bug 1439194 - Implement a separate state for login failed in the sidebar. r=markh 2018-02-20 09:58:05 +08:00
tests Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8 2018-02-08 12:57:31 -05:00
translation Bug 1011480 - Remove CommonUtils.laterTickResolvingPromise() and replace it by Async.promiseYield() and Async.jankYielder(). r=eoger 2018-02-20 10:31:58 +08:00
uitour Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8 2018-02-08 12:57:31 -05:00
.eslintrc.js Bug 1421968 - Enable ESLint rule mozilla/use-services by default, but whitelist it for various directories still to be fixed. r=mossop 2017-11-28 19:24:12 +00:00
BrowserComponents.manifest
distribution.js Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian 2018-02-06 09:36:57 -08:00
moz.build Bug 1167237 - Remove nsIBrowserGlue.sanitize() and nsIBrowserGlue. r=johannh 2018-02-06 14:23:03 +01:00
nsBrowserContentHandler.js Bug 1336227 - Show about:blank as soon as possible during startup (pref'ed off), r=mconley. 2018-02-10 15:07:48 +01:00
nsBrowserGlue.js Bug 1404688 - Make headerURL optional and remove text-shadow when there is no headerURL. r=jaws 2018-02-15 13:37:30 +00:00
nsIBrowserHandler.idl