gecko-dev/layout
Timothy Nikkel a64e3a50db Bug 1872002. Don't descend into popups in MaybeCreateDisplayPortInFirstScrollFrameEncountered. r=layout-reviewers,emilio
When building the display list for popup frames we hit this early return

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/nsIFrame.cpp#4089

because menupopups are given top layer style here

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/toolkit/content/xul.css#370

The place where top layer items would get added to the display list is

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/ViewportFrame.cpp#163

However that iterates the toplayer list from the document which does not contain menupopups; it contains things like popover, fullscreen, dialog.

However, if not culled by that toplayer early return, popups would be culled by this popup specific early return a few lines later

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/nsIFrame.cpp#4110

So I think using a popup check here is the right way to go.

Differential Revision: https://phabricator.services.mozilla.com/D197313
2023-12-30 04:47:11 +00:00
..
base Bug 1872002. Don't descend into popups in MaybeCreateDisplayPortInFirstScrollFrameEncountered. r=layout-reviewers,emilio 2023-12-30 04:47:11 +00:00
build Bug 779684 - part 2: Get rid of `nsFrameTraversal` and `nsIFrameTraversal` r=emilio 2023-12-24 06:01:19 +00:00
docs Bug 1847086 - Document that layout reftests have SpecialPowers access. r=botond 2023-08-15 00:20:54 +00:00
forms Bug 1800077 - Add a missing include to fix non-unified builds. 2023-12-21 23:02:52 +01:00
generic Bug 1816581 - part 6: Move the static methods used for moving caret or considering caret geometry into new utility class r=emilio 2023-12-27 04:42:12 +00:00
inspector Bug 1871540 - Fix an inspector assertion when inspecting ::cue pseudos. r=dshin 2023-12-22 18:02:56 +00:00
ipc
mathml Bug 1519636 - Reformat recent changes to the Google coding style r=emilio,media-playback-reviewers,padenot 2023-12-04 10:09:36 +00:00
media
painting Bug 1854010 - Restrict fixed/sticky hit test info to items fixed to the root. r=hiro,botond 2023-12-28 01:33:59 +00:00
printing Bug 1869217. Don't use the @page rules that match the first page as the page defaults. r=emilio 2023-12-11 17:53:41 +00:00
reftests Bug 1871412 - Fix scroll container checks for automatic minimum size and grid stretching checks. r=dholbert 2023-12-26 20:49:16 +00:00
style Bug 1872006 - Don't clip range input overflow. r=dholbert 2023-12-29 05:56:14 +00:00
svg Bug 1872241 - Remove svgFloatSize and use gfx::Size instead r=emilio 2023-12-28 12:59:10 +00:00
tables Bug 1871608 Part 3 - Remove one addition unused methods and cleanup a comment. r=jwatt 2023-12-22 22:53:51 +00:00
tools Bug 1839051 - Remove include nsQuickSort.h from some more files. r=emilio 2023-12-11 06:53:28 +00:00
xul Bug 1868868 - The value of thumb position changed by reflow should be consistent to nsSliderFrame::CurrentPositionChanged, r=emilio 2023-12-12 12:11:13 +00:00
moz.build