gecko-dev/layout/base
Timothy Nikkel a64e3a50db Bug 1872002. Don't descend into popups in MaybeCreateDisplayPortInFirstScrollFrameEncountered. r=layout-reviewers,emilio
When building the display list for popup frames we hit this early return

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/nsIFrame.cpp#4089

because menupopups are given top layer style here

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/toolkit/content/xul.css#370

The place where top layer items would get added to the display list is

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/ViewportFrame.cpp#163

However that iterates the toplayer list from the document which does not contain menupopups; it contains things like popover, fullscreen, dialog.

However, if not culled by that toplayer early return, popups would be culled by this popup specific early return a few lines later

https://searchfox.org/mozilla-central/rev/08899071a2c8a573ac47ac632869bb92269b3ec3/layout/generic/nsIFrame.cpp#4110

So I think using a popup check here is the right way to go.

Differential Revision: https://phabricator.services.mozilla.com/D197313
2023-12-30 04:47:11 +00:00
..
crashtests Bug 1865918 p3. Update CreateContentViewer to reflect nsIDocumentViewer's new name. r=emilio 2023-11-22 13:50:57 +00:00
gtest Bug 1804375 - Re-enable clang -Wnull-dereference warnings in gtest. r=firefox-build-system-reviewers,glandium 2022-12-13 03:57:35 +00:00
tests Bug 1866011 p2. Rename nsIDocShell.contentViewer. r=emilio,credential-management-reviewers,devtools-reviewers,sgalich 2023-11-24 09:10:52 +00:00
AccessibleCaret.cpp Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 2023-07-09 11:34:05 +00:00
AccessibleCaret.h Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 2023-07-09 11:34:05 +00:00
AccessibleCaretEventHub.cpp Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 2023-07-09 11:34:05 +00:00
AccessibleCaretEventHub.h
AccessibleCaretLogger.h
AccessibleCaretManager.cpp Bug 1816581 - part 6: Move the static methods used for moving caret or considering caret geometry into new utility class r=emilio 2023-12-27 04:42:12 +00:00
AccessibleCaretManager.h Bug 1824886 - Rewrite AnonymousContent to use a shadow tree. r=smaug,TYLin,sfoster,devtools-reviewers,nchevobbe 2023-07-09 11:34:05 +00:00
ArenaObjectID.h
AutoProfilerStyleMarker.h Bug 1843534 - Avoid taking unnecessary timestamps when thread is not being profiled for markers. r=julienw 2023-08-09 10:28:37 +00:00
Baseline.cpp Bug 1835562 - Fix synthesized baseline from border-box when line is inverted. r=dholbert 2023-07-31 15:38:27 +00:00
Baseline.h Bug 1809568 - Part 2: Provide `GetNaturalBaselineBOffset` with baseline export context. r=emilio 2023-05-17 12:56:54 +00:00
CaretAssociationHint.h Bug 1816581 - part 1: Make `CaretAssociationHint` an enum class r=emilio 2023-12-27 04:42:09 +00:00
ContainStyleScopeManager.cpp Bug 1830127 - Revert changeset 63b04ce7cf57 (bug 1808995) and remove associated WPT tests, because the behavior implemented there deviated from the Counter-Styles spec. r=emilio 2023-05-05 12:58:33 +00:00
ContainStyleScopeManager.h Bug 1849204 - Add generic atom hash keys that use the better distributed atom hash, and use it across the tree. r=mstange,xpcom-reviewers,credential-management-reviewers,sgalich,nika 2023-08-18 18:43:27 +00:00
DepthOrderedFrameList.cpp Bug 1797752 - Fix a comment as per review feedback that I missed. 2022-12-29 14:04:15 +01:00
DepthOrderedFrameList.h Bug 1797752 - Make sure container queries make forward progress. r=Oriol 2022-12-29 10:01:22 +00:00
DisplayPortUtils.cpp Bug 1872002. Don't descend into popups in MaybeCreateDisplayPortInFirstScrollFrameEncountered. r=layout-reviewers,emilio 2023-12-30 04:47:11 +00:00
DisplayPortUtils.h Bug 1781007 - Skip calling RestrictToRootDisplayPort in the case where the scroll container has empty displayport margins. r=tnikkel 2023-10-05 06:38:55 +00:00
FrameProperties.h Bug 1848714 - Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio 2023-08-15 14:24:19 +00:00
GeckoMVMContext.cpp Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
GeckoMVMContext.h Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
GeometryUtils.cpp
GeometryUtils.h
LayoutConstants.h Bug 1870572 - Use constexpr variables instead of macro to define layout constants. r=layout-reviewers,emilio 2023-12-18 18:18:28 +00:00
LayoutLogging.cpp
LayoutLogging.h
LayoutTelemetryTools.cpp
LayoutTelemetryTools.h
MVMContext.h Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
MediaEmulationData.h
MobileViewportManager.cpp Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
MobileViewportManager.h
MotionPathUtils.cpp Bug 1836831 - don't try to resolve ray with StrokeBox when non-scaling-stroke is in effect r=boris 2023-12-06 09:19:01 +00:00
MotionPathUtils.h Bug 1598158 - Add IsClosedLoop() for SVGGeometryElement. r=emilio 2023-08-07 22:04:02 +00:00
OverflowChangedTracker.h
PositionedEventTargeting.cpp Bug 1839922 - Remove usage of {Has,Get}Attr(kNameSpaceID_None, ..). r=edgar 2023-06-23 10:01:32 +00:00
PositionedEventTargeting.h
PresShell.cpp Bug 1816581 - part 1: Make `CaretAssociationHint` an enum class r=emilio 2023-12-27 04:42:09 +00:00
PresShell.h Bug 1807253 - unreliable timing for content-visibility:auto, r=emilio 2023-11-27 08:26:46 +00:00
PresShellForwards.h Bug 1835864 - Make printing / paged mode deal with multiple canvas backgrounds properly. r=dholbert 2023-08-10 12:59:00 +00:00
PresShellInlines.h Bug 1844755 - Consider to not create ServoStyleSet for data documents, r=emilio 2023-10-23 16:10:41 +00:00
PresState.ipdlh Bug 1556358 - Part 2: Save and restore custom element form data. r=edgar 2023-06-28 04:31:22 +00:00
RelativeTo.h
RestyleManager.cpp Bug 1868931 - Repaint XUL checkbox and radio for active state too. r=emilio 2023-12-08 09:49:12 +00:00
RestyleManager.h Bug 1792501: Part 6 - :has invalidation for :empty and :nth (Without of). r=emilio 2023-09-14 22:21:26 +00:00
ScrollStyles.cpp
ScrollStyles.h
ScrollTypes.h
ShapeUtils.cpp Bug 1823475 - Drop DefaultPosition and omit "at <position>" if it is not specified. r=devtools-reviewers,emilio 2023-09-26 21:05:20 +00:00
ShapeUtils.h Bug 1842277 - Compute <basic-shape-rect> to the equivalent inset() function. r=devtools-reviewers,emilio 2023-07-12 20:16:47 +00:00
StackArena.cpp
StackArena.h
StaticPresData.cpp Bug 1853392 - Simplify font-size-adjust: from-font handling. r=jfkthame 2023-09-15 22:17:25 +00:00
StaticPresData.h
SurfaceFromElementResult.h Bug 1781527: apply code formatting via Lando 2023-07-10 00:29:39 +00:00
TouchManager.cpp Bug 1857906. Remove some unused code in layout/base/TouchManager.cpp. r=emilio 2023-10-09 12:38:19 +00:00
TouchManager.h
UnitTransforms.h Bug 1715179 - Propagate transform matrix and relevant zoom values to convert CSSRect/CSSPoint in OOPIF to top level content document cooords. r=botond 2023-12-04 09:31:23 +00:00
Units.h Bug 1840485 - Change the type of BaseMargin::{top,right,bottom,left} to Coord. r=botond 2023-07-01 02:23:21 +00:00
ViewportUtils.cpp
ViewportUtils.h
WordMovementType.h
ZoomConstraintsClient.cpp Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
ZoomConstraintsClient.h
moz.build Bug 1816581 - part 1: Make `CaretAssociationHint` an enum class r=emilio 2023-12-27 04:42:09 +00:00
nsAutoLayoutPhase.cpp
nsAutoLayoutPhase.h
nsBidiPresUtils.cpp Bug 1364813 - Remove IsFrameOfType, use non-virtual checks. r=jwatt 2023-11-26 22:17:28 +00:00
nsBidiPresUtils.h Bug 1821735 part 3: Change nsBidiPresUtils::ProcessText aBidiEngine param to a reference instead of a pointer. r=jfkthame 2023-03-10 21:58:44 +00:00
nsCSSColorUtils.cpp
nsCSSColorUtils.h
nsCSSFrameConstructor.cpp Bug 1364813 - Remove IsFrameOfType, use non-virtual checks. r=jwatt 2023-11-26 22:17:28 +00:00
nsCSSFrameConstructor.h Bug 1364813 - Remove IsFrameOfType, use non-virtual checks. r=jwatt 2023-11-26 22:17:28 +00:00
nsCaret.cpp Bug 1816581 - part 6: Move the static methods used for moving caret or considering caret geometry into new utility class r=emilio 2023-12-27 04:42:12 +00:00
nsCaret.h Bug 1816581 - part 6: Move the static methods used for moving caret or considering caret geometry into new utility class r=emilio 2023-12-27 04:42:12 +00:00
nsChangeHint.h Bug 1844466 - Speed up and simplify cumulative changehint computation. r=boris,hiro 2023-08-03 09:04:11 +00:00
nsCompatibility.h
nsCounterManager.cpp Bug 1830127 - Revert changeset 63b04ce7cf57 (bug 1808995) and remove associated WPT tests, because the behavior implemented there deviated from the Counter-Styles spec. r=emilio 2023-05-05 12:58:33 +00:00
nsCounterManager.h Bug 1856795 - Remove redundant member init r=emilio 2023-10-15 15:29:02 +00:00
nsDocumentViewer.cpp Bug 1870512 - Simplify ShouldAttachToTopLevel(), and revert patch for bug 1869891. r=tnikkel 2023-12-20 18:32:38 +00:00
nsFrameManager.cpp Bug 1851787 - Plumb a DestroyContext through all functions that can destroy frames. r=dholbert 2023-09-08 15:11:17 +00:00
nsFrameManager.h Bug 1851787 - Plumb a DestroyContext through all functions that can destroy frames. r=dholbert 2023-09-08 15:11:17 +00:00
nsFrameTraversal.cpp Bug 779684 - part 3: Make `nsFrameIterator` non-refcountable r=emilio 2023-12-24 06:01:19 +00:00
nsFrameTraversal.h Bug 779684 - part 3: Make `nsFrameIterator` non-refcountable r=emilio 2023-12-24 06:01:19 +00:00
nsGenConList.cpp
nsGenConList.h
nsIDocumentViewerPrint.h
nsILayoutHistoryState.idl Bug 1802288 - remove trailing whitespaces in idl/webidl files r=credential-management-reviewers,webidl,smaug,sgalich 2022-12-28 09:52:44 +00:00
nsIPercentBSizeObserver.h
nsIPreloadedStyleSheet.idl
nsIReflowCallback.h
nsIStyleSheetService.idl
nsLayoutDebugger.cpp
nsLayoutHistoryState.cpp
nsLayoutUtils.cpp Bug 1872241 - Remove svgFloatSize and use gfx::Size instead r=emilio 2023-12-28 12:59:10 +00:00
nsLayoutUtils.h Bug 1865995 p5. Rename GetContentViewerSize to match nsIDocumentViewer's new name. r=emilio,geckoview-reviewers,owlish 2023-11-23 21:35:20 +00:00
nsPresArena.cpp Bug 1848714 - Use unsafe methods in hot code paths to access and remove elements from nsTArray when it is guaranteed to be safe, r=emilio 2023-08-15 14:24:19 +00:00
nsPresArena.h
nsPresArenaObjectList.h
nsPresContext.cpp Bug 1867152 - Fix the assertion in nsPresContext::UserInputEventsAllowed r=smaug 2023-12-12 22:49:38 +00:00
nsPresContext.h Bug 1863574 - patch 2 - Create an RFPTarget option to control whether the resolution of CSS generics is subject to font-visibility restrictions. r=jwatt 2023-12-07 10:29:34 +00:00
nsPresContextInlines.h Bug 1844755 - Consider to not create ServoStyleSet for data documents, r=emilio 2023-10-23 16:10:41 +00:00
nsQuoteList.cpp
nsQuoteList.h
nsRefreshDriver.cpp Bug 1870008 - make high rate mode handling dynamic, r=farre 2023-12-18 15:40:09 +00:00
nsRefreshDriver.h Bug 1870008 - make high rate mode handling dynamic, r=farre 2023-12-18 15:40:09 +00:00
nsRefreshObservers.cpp Bug 1868456: Improve ManagedPostRefreshObserver invariants. r=emilio 2023-12-06 02:09:29 +00:00
nsRefreshObservers.h Bug 1837244: Assert that AddRefreshObserver/RemoveRefreshObserver calls are balanced. r=tnikkel 2023-06-07 23:24:22 +00:00
nsStyleChangeList.cpp
nsStyleChangeList.h
nsStyleSheetService.cpp Bug 1520118 - Remove support for style sheets loaded from the category manager. r=layout-reviewers,emilio 2023-11-10 13:48:12 +00:00
nsStyleSheetService.h Bug 1520118 - Remove support for style sheets loaded from the category manager. r=layout-reviewers,emilio 2023-11-10 13:48:12 +00:00