gecko-dev/browser
Drew Willcoxon 14225c1014 Bug 1678765 - Fix broken "Search with" action text for heuristic results that are restyled to look like search results. r=harry
This was a little harder than it seemed like it should be because we show/hide
the title separator in two places, in `UrlbarView.updateRow` and in the CSS.
This patch gets rid of the show/hide in `updateRow`, so now we show/hide only in
the CSS. The decision to show/hide in `updateRow` was based on whether the
result has action text (`actionSetter`) or is a URL (`setURL`). We already had a
`has-url` attribute that corresponds directly to `setURL`, so adding a similar
`has-action` attribute that corresponds to `actionSetter` lets us show/hide only
in the CSS.

The second part of this patch is to actually fix the bug. For that, the existing
`show-action-text` attribute does part of what we want in the CSS: It forces the
action to be shown when a one-off is selected and there's no selected row. In
addition to that, we need to show the action when both a restyled search and a
one-off are selected, so this adds a new `restyled-search` attribute. We need
both attributes because we do not want to show the action for a restyled search
when some other row plus a one-off are selected (to match the current behavior).

Depends on D97843

Differential Revision: https://phabricator.services.mozilla.com/D98429
2020-12-07 22:43:02 +00:00
..
actors Bug 1678987 - Make page style menu deal with <link disabled> better. r=mconley 2020-12-04 01:34:15 +00:00
app Bug 1679272 - Include ScopeExit.h exactly where used. r=andi 2020-12-07 14:25:59 +00:00
base Bug 1677801, adds UTM parameters to about dialog r=bigiri 2020-12-07 21:16:33 +00:00
branding Bug 1677801, adds UTM parameters to about dialog r=bigiri 2020-12-07 21:16:33 +00:00
components Bug 1678765 - Fix broken "Search with" action text for heuristic results that are restyled to look like search results. r=harry 2020-12-07 22:43:02 +00:00
config Bug 1680091 - Update WNP rules for 84 release and beyond. r=mtabara 2020-12-03 13:17:41 +00:00
docs Bug 1664849 - Extend ad impression/click telemetry to organic SERPS. r=daleharvey 2020-11-20 13:40:09 +00:00
extensions Bug 1666739 - Add site-specific PiP toggle visibility threshold to the WebCompat add-on. r=mstriemer,webcompat-reviewers,denschub,twisniewski 2020-12-04 19:43:54 +00:00
fonts
fxr
installer Bug 1652412 - Do not set as deault .pdf, .svg, ftp:, and mailto: handlers on Windows 7. r=mhowell 2020-12-03 23:05:01 +00:00
locales Bug 1678336 - Fix 'Remove All' string in remove all logins dialog to use singular case. r=sfoster,fluent-reviewers,flod 2020-12-07 14:54:07 +00:00
modules Bug 1681124: Remove unintentional logging code landed in bug 1675329. r=Gijs 2020-12-07 18:32:16 +00:00
themes Bug 1678765 - Fix broken "Search with" action text for heuristic results that are restyled to look like search results. r=harry 2020-12-07 22:43:02 +00:00
tools/mozscreenshots Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie 2020-11-12 18:01:03 +00:00
.eslintrc.js
LICENSE
Makefile.in
app.mozbuild
build.mk
confvars.sh
defs.mk
l10n-registry.manifest
moz.build
moz.configure