gecko-dev/browser/themes
Drew Willcoxon 14225c1014 Bug 1678765 - Fix broken "Search with" action text for heuristic results that are restyled to look like search results. r=harry
This was a little harder than it seemed like it should be because we show/hide
the title separator in two places, in `UrlbarView.updateRow` and in the CSS.
This patch gets rid of the show/hide in `updateRow`, so now we show/hide only in
the CSS. The decision to show/hide in `updateRow` was based on whether the
result has action text (`actionSetter`) or is a URL (`setURL`). We already had a
`has-url` attribute that corresponds directly to `setURL`, so adding a similar
`has-action` attribute that corresponds to `actionSetter` lets us show/hide only
in the CSS.

The second part of this patch is to actually fix the bug. For that, the existing
`show-action-text` attribute does part of what we want in the CSS: It forces the
action to be shown when a one-off is selected and there's no selected row. In
addition to that, we need to show the action when both a restyled search and a
one-off are selected, so this adds a new `restyled-search` attribute. We need
both attributes because we do not want to show the action for a restyled search
when some other row plus a one-off are selected (to match the current behavior).

Depends on D97843

Differential Revision: https://phabricator.services.mozilla.com/D98429
2020-12-07 22:43:02 +00:00
..
addons Bug 1679136 - fix separator colour in alpenglow light and dark, r=jaws 2020-12-02 20:29:23 +00:00
linux Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim 2020-11-26 21:54:32 +00:00
osx Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim 2020-11-26 21:54:32 +00:00
shared Bug 1678765 - Fix broken "Search with" action text for heuristic results that are restyled to look like search results. r=harry 2020-12-07 22:43:02 +00:00
windows Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim 2020-11-26 21:54:32 +00:00
LICENSE
moz.build Bug 1654103: Standardize on Black for Python code in `mozilla-central`. 2020-10-26 18:34:53 +00:00