gecko-dev/storage
Nathan Froyd 8a2948e596 Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm
When people write:

  array.AppendElement(nsDependentString(...));

(resp. nsDependentCString), it's not clear whether they expect the newly
constructed dependent string to live in the array, or whether they're
just making a nsString-like holder whose contents can be freely copied
into the array's newly-created nsString.  Sometimes the latter is what
you prefer, and sometimes the former.  In all cases, however, the latter
behavior is what you get.

Let's try to make that behavior more explicit by pre-constructing
nsString elements and then using Assign to show that copying is taking
place.  This patch involves no functional change in behavior (it ought
to be epsilon faster due to using AppendElements, rather than repeatedly
calling AppendElement).
2015-11-18 10:25:19 -05:00
..
build Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium. 2015-08-27 20:44:53 -07:00
test Bug 1217982 - Remove for-each from storage/. r=mak 2015-10-19 03:53:14 +09:00
FileSystemModule.cpp Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
FileSystemModule.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
IStorageBindingParamsInternal.h Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
SQLCollations.cpp Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
SQLCollations.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
SQLiteMutex.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
StatementCache.h Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
StorageBaseStatementInternal.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
StorageBaseStatementInternal.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
TelemetryVFS.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
VacuumManager.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
VacuumManager.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
Variant.h Bug 968520 - Add mozilla::fallible to FallibleTArray::AppendElements calls. r=froydnj 2015-05-28 11:07:43 -07:00
Variant_inl.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
moz.build Bug 1198334 (part 1) - Replace the opt-in FAIL_ON_WARNINGS with the opt-out ALLOW_COMPILER_WARNINGS. r=glandium. 2015-08-27 20:44:53 -07:00
mozIStorageAggregateFunction.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageAsyncConnection.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageAsyncStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBaseStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBindingParams.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageBindingParamsArray.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageCompletionCallback.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageConnection.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageError.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageFunction.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStoragePendingStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageProgressHandler.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageResultSet.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageRow.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageService.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatement.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementCallback.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementParams.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageStatementRow.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageVacuumParticipant.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozIStorageValueArray.idl Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozStorageArgValueArray.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageArgValueArray.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageAsyncStatement.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatement.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementExecution.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementExecution.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementJSHelper.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageAsyncStatementJSHelper.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageAsyncStatementParams.cpp Bug 1140482 - Add JSPROP_RESOLVING. Give NativeDefineProperty standard behavior in cases where a non-resolving define needs to trigger a resolve hook. r=Waldo. 2015-05-01 14:03:17 -05:00
mozStorageAsyncStatementParams.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageBindingParams.cpp Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak. 2015-10-29 16:04:41 -07:00
mozStorageBindingParams.h Bug 1186791 (part 1) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak. 2015-10-29 16:04:41 -07:00
mozStorageBindingParamsArray.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageBindingParamsArray.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageConnection.cpp Bug 1186791 (part 3) - Replace nsBaseHashtable::EnumerateRead() calls in storage/ with iterators. r=mak. 2015-10-29 16:43:34 -07:00
mozStorageConnection.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageError.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageError.h Bug 1182996 - Fix and add missing namespace comments. rs=ehsan 2015-07-13 08:25:42 -07:00
mozStorageHelper.h Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
mozStoragePrivateHelpers.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStoragePrivateHelpers.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageResultSet.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageResultSet.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageRow.cpp Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageRow.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageSQLFunctions.cpp Bug 1219238 - remove AutoArray from mozStorageSQLFunctions.cpp; r=mak 2015-10-27 21:22:52 -04:00
mozStorageSQLFunctions.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageService.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageService.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatement.cpp Bug 1225923 - part 1 - convert all needs-to-copy instances of AppendElement(nsDependentString(...)); r=erahm 2015-11-18 10:25:19 -05:00
mozStorageStatement.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatementData.h Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatementJSHelper.cpp Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat 2015-10-18 01:24:48 -04:00
mozStorageStatementJSHelper.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageStatementParams.cpp Bug 1140482 - Add JSPROP_RESOLVING. Give NativeDefineProperty standard behavior in cases where a non-resolving define needs to trigger a resolve hook. r=Waldo. 2015-05-01 14:03:17 -05:00
mozStorageStatementParams.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
mozStorageStatementRow.cpp Bug 1184564 part 2 - Use Value instead of jsval in dom/ and storage/. r=bz 2015-07-18 21:45:35 +02:00
mozStorageStatementRow.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00
storage.h Bug 1164717 - Flatten storage/public/ directory. r=mak 2015-05-19 10:47:29 -07:00
style.txt Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
variantToSQLiteT_impl.h Bug 1164717 - Flatten storage/src/ directory. r=mak 2015-05-19 10:47:33 -07:00