gecko-dev/widget
Masayuki Nakano b87a7f9729 Bug 1447866 - GeckoEditableSupport::SendIMEDummyKeyEvent() should set native key bindings to none before dispatching keyboard events which are marked as "processed by IME" r=esawin
When EditorEventListener receives keyboard events, it tries to execute
native key bindings which are stored by each keyboard event.  For performance
reason in e10s, TabParent initializes native key binding information of every
keyboard event before sending it to the remote process.  Therefore,
PuppetWidget checks if every keyboard event has native key binding information.
However, the native key binding information of dummy keyboard events marked as
"processed by IME" on Android are never initialized before sending PuppetWidget.
Therefore, we hit MOZ_ASSERT in PuppetWidget.

This patch makes GeckoEditableSuppor::SendIMEDummyKeyEvent() set native key
binding information to "none" before dispatching every keyboard event since
keyboard events during composition shouldn't cause any edit actions.

MozReview-Commit-ID: Bk532ahCQP6

--HG--
extra : rebase_source : 939c1befd4b587681192b6827e7c7fa52619d498
2018-03-23 11:54:01 +09:00
..
android Bug 1447866 - GeckoEditableSupport::SendIMEDummyKeyEvent() should set native key bindings to none before dispatching keyboard events which are marked as "processed by IME" r=esawin 2018-03-23 11:54:01 +09:00
cocoa Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE 2018-03-22 20:06:24 +01:00
crashtests Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
gtk Bug 1448271 - Update some names of #include guards r=nical 2018-03-23 22:40:04 +09:00
gtkxtbin Bug 1381253 - Remove redundant control flow declarations rs=ehsan 2017-07-15 19:03:04 +02:00
headless Bug 1447788 - add missing override keyword, rs=bustage-fix, a=Aryx on CLOSED TREE 2018-03-21 23:50:56 +01:00
reftests Bug 1417200: Make -moz-border-colors chrome only. r=xidorn 2017-12-01 23:25:01 +01:00
tests Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE 2018-03-25 15:29:54 +03:00
uikit Bug 1446711 part 7. Switch the nsIDOMMouseEvent::MOZ_SOURCE_* constants over to MouseEventBinding. r=qdot 2018-03-20 00:16:06 -04:00
windows Bug 1448271 - Update some names of #include guards r=nical 2018-03-23 22:40:04 +09:00
x11
xremoteclient Bug 1418770 - Truncate DBus names used for remote service to DBUS_MAXIMUM_NAME_LENGTH, r=jhorak 2018-02-13 13:59:39 +01:00
BasicEvents.h Bug 1413102 - Ensure Shadow DOM boundaries are dealt properly in event handling, r=masayuki 2018-02-15 12:08:42 +02:00
CommandList.h Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato 2017-12-02 14:53:10 +09:00
CompositorWidget.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
CompositorWidget.h Bug 1425842 - Rename X11CompositorWidget to GtkCompositorWidget and implement WindowSurfaceWayland support, r=jhorak 2017-12-18 20:20:02 +01:00
ContentCache.cpp Bug 1422230 - part 2: ContentCacheInParent should allow to query content relative to composition string even after sending eCompositionCommit(AsIs) event but not yet handled in the remote process r=m_kato 2018-01-12 15:05:24 +09:00
ContentCache.h Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
ContentEvents.h Bug 1433008 - Make AnimationEventInfo, InternalTransitionEvent and InternalAnimationEvent movable. r=masayuki 2018-01-30 09:26:48 +09:00
EventClassList.h
EventForwards.h Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato 2017-12-02 14:53:10 +09:00
EventMessageList.h Bug 1359017 - onmessageerror for WindowEventHandlers in case StructuredClone algorithm fails when deserializing, r=masayuki, r=smaug 2017-09-13 05:59:06 +02:00
FontRange.h Bug 1377169 - Turn gfxRect into a typedef. r=jrmuizel 2017-07-05 11:22:00 -04:00
GfxDriverInfo.cpp Bug 1432610 - Disable D2D on Win7 on Intel Haswell for old graphics drivers r=jrmuizel 2018-03-22 15:33:52 +09:00
GfxDriverInfo.h Bug 1432610 - Disable D2D on Win7 on Intel Haswell for old graphics drivers r=jrmuizel 2018-03-22 15:33:52 +09:00
GfxInfoBase.cpp Bug 1441270 - Remove unused WebGL parameter getters. r=jgilbert 2018-02-26 20:35:12 +01:00
GfxInfoBase.h Bug 1441270 - Remove unused WebGL parameter getters. r=jgilbert 2018-02-26 20:35:12 +01:00
GfxInfoCollector.cpp
GfxInfoCollector.h
GfxInfoX11.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
GfxInfoX11.h Bug 1441270 - Remove unused WebGL parameter getters. r=jgilbert 2018-02-26 20:35:12 +01:00
IMEData.h Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
InProcessCompositorWidget.cpp Bug 1413217 - Fix some includes etc. in widget code. r=jimm 2017-10-12 17:03:35 +01:00
InProcessCompositorWidget.h
InputData.cpp Bug 1446711 part 7. Switch the nsIDOMMouseEvent::MOZ_SOURCE_* constants over to MouseEventBinding. r=qdot 2018-03-20 00:16:06 -04:00
InputData.h Bug 1446851. Get rid of nsIDOMWheelEvent. r=qdot 2018-03-20 00:16:05 -04:00
LSBUtils.cpp Bug 1401786 - Move base::LaunchApp options into a LaunchOptions struct, like upstream Chromium. r=billm 2017-09-08 20:35:06 -06:00
LSBUtils.h
LookAndFeel.h Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE 2017-11-23 01:17:07 +02:00
MiscEvents.h Bug 1400460 - Rename nsIAtom as nsAtom. r=hiro. 2017-10-03 09:05:19 +11:00
MouseEvents.h Bug 1446711 part 7. Switch the nsIDOMMouseEvent::MOZ_SOURCE_* constants over to MouseEventBinding. r=qdot 2018-03-20 00:16:06 -04:00
NativeKeyToDOMCodeName.h Bug 1389598 - Part 4: Remove remaining gonk refs. r=froydnj 2017-08-11 17:45:18 -07:00
NativeKeyToDOMKeyName.h Bug 1446809 - Remove some b2g leftover in widget/NativeKeyToDOMKeyName.h r=froydnj 2018-03-18 19:30:05 +01:00
PCompositorWidget.ipdl
PlatformWidgetTypes.ipdlh Bug 1373739 - Make macOS compatible with the headless WPT changes. r=bdahl 2017-07-28 23:20:21 -07:00
PluginWidgetProxy.cpp
PluginWidgetProxy.h
PuppetBidiKeyboard.cpp
PuppetBidiKeyboard.h
PuppetWidget.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
PuppetWidget.h Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
Screen.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
Screen.h Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
ScreenManager.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
ScreenManager.h
SharedWidgetUtils.cpp
SystemTimeConverter.h Bug 1447549 - avoid crashing windows debug builds at startup when ::GetMessageTime returns 0, r=jimm. 2018-03-21 23:35:00 +01:00
TextEventDispatcher.cpp Bug 1446401 - Start to dispatch "keydown" event and "keyup" event even during in composition in Nightly and early Beta r=smaug 2018-02-28 22:19:09 +09:00
TextEventDispatcher.h Bug 1433101 - part 1: Add new pref which disables keypress event for non-printable keys only for the default event group in web content r=smaug 2018-01-25 23:27:07 +09:00
TextEventDispatcherListener.h
TextEvents.h Bug 1036008 - Use alternative ASCII capable keyboard layout information to decide keyCode even if the key produces an ASCII punctuation character r=smaug 2018-02-16 15:54:07 +09:00
TextRange.h Bug 1386411 - Part 3: Inline some helper functions in Selection.cpp; r=bzbarsky 2017-08-03 17:05:19 -04:00
TouchEvents.h Bug 1436508 part 16. Remove nsIDOMSimpleGestureEvent. r=masayuki 2018-02-09 11:17:10 -05:00
VsyncDispatcher.cpp Bug 1372405 - Provide names for all runnables in the tree (r=froydnj) 2017-06-26 14:19:58 -07:00
VsyncDispatcher.h
WidgetEventImpl.cpp bug 1447196, canceling pointerdown should not affect to scrollbar handling, r=masayuki 2018-03-23 17:31:13 +02:00
WidgetMessageUtils.h
WidgetTraceEvent.h
WidgetUtils.cpp Bug 1423559: Use BaseRect access methods instead of member variables in widget/ r=mstange 2018-01-10 11:14:16 -05:00
WidgetUtils.h Bug 1151753 - Set program class name when not using --class command line option. r=karlt 2017-10-25 15:58:49 +09:00
WindowSurface.h
WindowSurfaceX11SHM.cpp
WindowSurfaceX11SHM.h
moz.build Bug 1418749 - Add a TaskbarProgress implementation for gtk3/x11. r=paolo,karlt 2018-03-08 18:43:00 +02:00
nsAppShellSingleton.h
nsAutoRollup.cpp
nsAutoRollup.h Bug 1413217 - Fix some includes etc. in widget code. r=jimm 2017-10-12 17:03:35 +01:00
nsBaseAppShell.cpp Bug 1402519 - Remove MOZ_CRASHREPORTER directives from widget; r=froydnj 2017-11-23 10:59:04 +01:00
nsBaseAppShell.h
nsBaseClipboard.cpp
nsBaseClipboard.h Backed out 22 changesets (bug 1399787) for shutdown leaks on windows 7 debug tc-M without e10s r=backout on a CLOSED TREE 2017-12-08 13:09:56 +02:00
nsBaseDragService.cpp Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor 2018-03-21 17:39:04 -04:00
nsBaseDragService.h Bug 1446711 part 8. Get rid of nsIDOMMouseEvent. r=qdot 2018-03-20 00:16:07 -04:00
nsBaseFilePicker.cpp Bug 1390428 (part 9) - Remove nsXPIDLCString. r=erahm. 2017-08-17 15:29:03 +10:00
nsBaseFilePicker.h Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj 2017-11-05 19:37:28 -08:00
nsBaseScreen.cpp Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsBaseScreen.h Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsBaseWidget.cpp Bug 1448490 - Make the layers id a struct instead of a uint64_t. r=mattwoodrow 2018-03-24 19:06:01 -04:00
nsBaseWidget.h Bug 1441498 - Protect mCompositorVsyncDispatcher by lock. r=kats 2018-03-07 10:53:05 -05:00
nsClipboardHelper.cpp
nsClipboardHelper.h
nsClipboardProxy.cpp Bug 1340039 - Set contentPolicyType when copying image, and pass it between processes. r=smaug 2018-03-14 16:44:36 +08:00
nsClipboardProxy.h
nsColorPickerProxy.cpp
nsColorPickerProxy.h
nsContentProcessWidgetFactory.cpp Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsDeviceContextSpecProxy.cpp Bug 1432409 part 1 - Prevent nsDeviceContextSpecProxy using RemotePrintJobChild if initialization fails. r=dholbert 2018-02-16 14:53:26 +00:00
nsDeviceContextSpecProxy.h Bug 1436263 - Part 3: Remove `virtual` from final virtual function declarations. r=froydnj 2018-02-08 21:22:43 -08:00
nsDragServiceProxy.cpp Bug 1437118 - Null-check principalURI returned by URI getter. r=froydnj 2018-02-16 03:20:26 +09:00
nsDragServiceProxy.h Bug 1436902 part 3. Replace usage of NS_IMPL_ISUPPORTS_INHERITED0 with NS_INLINE_DECL_REFCOUNTING_INHERITED when possible. r=mccr8 2018-02-12 15:44:40 -05:00
nsFilePickerProxy.cpp Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsFilePickerProxy.h Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsGUIEventIPC.h Bug 1401111 - Use ContiguousEnumSerializer for EventMessage ParamTraits; r=botond 2017-12-01 13:00:56 -05:00
nsHTMLFormatConverter.cpp Bug 1313150 - Remove |weak| parameter from nsIMutableArray methods. r=froydnj 2017-10-21 23:53:02 +09:00
nsHTMLFormatConverter.h
nsIAppShell.idl
nsIApplicationChooser.idl
nsIBaseWindow.idl Bug 1402255 - Change nsIBaseWindow::title from wstring to AString. r=janv. 2017-09-25 13:10:51 +10:00
nsIBidiKeyboard.idl
nsIClipboard.idl
nsIClipboardDragDropHookList.idl
nsIClipboardDragDropHooks.idl
nsIClipboardHelper.idl
nsIClipboardOwner.idl
nsIColorPicker.idl
nsIDeviceContextSpec.h
nsIDisplayInfo.idl
nsIDragService.idl Bug 1445417 part 2. Stop using nsIDOMDragEvent in nsIDragService. r=mystor 2018-03-16 22:25:25 -04:00
nsIDragSession.idl Bug 1444686 part 11. Remove nsIDOMDataTransfer from dragsession. r=mystor 2018-03-13 16:24:00 -04:00
nsIFilePicker.idl Bug 1387800 - Remove [deprecated] nsIFilePicker.show(). r=qdot 2017-08-06 13:15:31 +09:00
nsIFormatConverter.idl
nsIGfxInfo.idl Bug 1441270 - Remove unused WebGL parameter getters. r=jgilbert 2018-02-26 20:35:12 +01:00
nsIGfxInfoDebug.idl
nsIGtkTaskbarProgress.idl Bug 1418749 - Add a TaskbarProgress implementation for gtk3/x11. r=paolo,karlt 2018-03-08 18:43:00 +02:00
nsIIdleService.idl
nsIIdleServiceInternal.idl
nsIJumpListBuilder.idl Bug 1354143 - Commit jump list on lazy idle thread. r=florian,jimm 2017-05-24 16:38:57 +08:00
nsIJumpListItem.idl
nsIKeyEventInPluginCallback.h
nsIMacDockSupport.idl
nsIMacWebAppUtils.idl
nsINativeMenuService.h Bug 1423167: Move most attribute-related methods from nsIContent to Element. r=bz 2017-12-06 16:05:59 +01:00
nsIPluginWidget.h
nsIPrintDialogService.h
nsIPrintSession.idl
nsIPrintSettings.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrintSettingsService.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrintSettingsWin.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIPrinterEnumerator.idl Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsIRollupListener.h
nsIScreen.idl Bug 1350643 - Part 3: Add GetDPI to nsIScreen & ScreenDetails. r=kanru 2017-06-06 18:09:34 +08:00
nsIScreenManager.idl
nsISound.idl
nsIStandaloneNativeMenu.idl
nsISystemStatusBar.idl
nsITaskbarOverlayIconController.idl
nsITaskbarPreview.idl
nsITaskbarPreviewButton.idl
nsITaskbarPreviewController.idl Bug 1387802 - Remove [deprecated] methods from nsITaskbarPreviewController. r=jimm 2017-08-06 13:35:02 +09:00
nsITaskbarProgress.idl
nsITaskbarTabPreview.idl
nsITaskbarWindowPreview.idl Bug 1387802 - Remove [deprecated] methods from nsITaskbarPreviewController. r=jimm 2017-08-06 13:35:02 +09:00
nsITransferable.idl Bug 1437281 - OSX dragging image to desktop changes OSX File associations r=mystor 2018-03-22 14:04:23 -07:00
nsIWidget.h Bug 1293362 - Part 4: Generate runtime bindings for calling xpcom methods from rust, r=froydnj 2018-01-23 17:27:26 -05:00
nsIWidgetListener.cpp Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange 2017-10-18 21:50:47 -04:00
nsIWidgetListener.h Bug 1373581: Make transition into and out of native fullscreen smoother on macOS. r=mstange 2017-10-18 21:50:47 -04:00
nsIWinTaskbar.idl
nsIWindowsUIUtils.idl
nsIdleService.cpp Bug 1404198: Part 2d - Switch to NS_NewTimer* in widget. r=njn 2017-10-15 23:12:54 -07:00
nsIdleService.h
nsNativeTheme.cpp Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE 2018-03-22 20:06:24 +01:00
nsNativeTheme.h Bug 1399956 - Add basic hard coded GTK theme in headless. r=jrmuizel 2017-10-16 16:15:45 -07:00
nsPrimitiveHelpers.cpp Bug 1390428 (part 2, attempt 2) - Remove more nsXPIDLCString local variables. r=erahm. 2017-08-21 20:01:27 +10:00
nsPrimitiveHelpers.h Bug 1393547 - Add missing nsACString declarations in widget/nsPrimitiveHelpers.h. r=mconley 2017-08-24 11:18:00 -04:00
nsPrintSession.cpp
nsPrintSession.h
nsPrintSettingsImpl.cpp Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsPrintSettingsImpl.h Bug 1407103 - Convert wstring attributes to AString in widget/nsIPrint*.idl. r=bobowen. 2017-10-09 10:08:09 +11:00
nsPrintSettingsService.cpp Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsPrintSettingsService.h Bug 144114 part 3 - Clean up the headers of the nsPrintSettingsService subclasses. r=bobowen 2017-12-19 11:05:37 +00:00
nsShmImage.cpp Bug 1397918 - don't use versions of libxcb before 1.11.1. r=karlt 2017-09-22 00:10:35 -04:00
nsShmImage.h
nsSoundProxy.cpp Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsSoundProxy.h Bug 1401678 - Proxy nsISound::beep() and nsISound::play() calls from the content process to the parent process and beep away there. r=bkelly 2018-01-16 13:24:51 +01:00
nsTransferable.cpp Bug 1433030 - Initialize nsTransferable::mPrivateData with false r=jdm 2018-03-07 10:21:50 +01:00
nsTransferable.h Bug 335545 - Make DataStruct non-copyable r=mstange 2018-02-25 17:36:08 +01:00
nsWidgetInitData.h Backed out 2 changesets (bug 1447056) for devtools failures on browser_toolbox_hosts_size.js. CLOSED TREE 2018-03-24 06:58:41 +02:00
nsWidgetsCID.h Bug 1418749 - Add a TaskbarProgress implementation for gtk3/x11. r=paolo,karlt 2018-03-08 18:43:00 +02:00
nsXPLookAndFeel.cpp Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE 2017-11-23 01:17:07 +02:00
nsXPLookAndFeel.h Bug 1387594 - Add system colors for use in conjunction with -moz-font-smoothing-background-color and vibrant -moz-appearances. r=dbaron 2017-09-14 23:09:48 +02:00