54f0d1b711
Tests : Unused parameters cleanup
...
I removed unused parameters in the tests wherever it was trivial to do so. I'm trying to get the easy ones out of the way before we get into more involved discussions around this.
Review URL: https://codereview.appspot.com/7394055
git-svn-id: http://skia.googlecode.com/svn/trunk@7891 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 19:17:41 +00:00
4e0d96b655
revert fontconfig gyp change for now (need to install it on housekeeper and chromeos bots)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7890 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 19:17:07 +00:00
ff436617d8
Sort GL extension strings and search to find.
...
Review URL: https://codereview.chromium.org/12316141
git-svn-id: http://skia.googlecode.com/svn/trunk@7889 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 19:07:32 +00:00
f0e92f3814
enable fontconfig by default in ports.gyp
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7888 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 19:06:52 +00:00
f71a2335f9
use fontconfig fonthost for skia (in prep for using in chrome)
...
Review URL: https://codereview.chromium.org/12319150
git-svn-id: http://skia.googlecode.com/svn/trunk@7887 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 19:06:30 +00:00
89e6f5bacf
Assign color=0 in GrDrawState.cpp to stop tools from raising false alarms about uninit reads.
...
We were assigning color to oldColor but it in turn would never be read because the valid flags
would be cleared.
R=jvanverth@google.com
Review URL: https://codereview.chromium.org/12313150
git-svn-id: http://skia.googlecode.com/svn/trunk@7886 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 18:43:47 +00:00
29b19e53cf
Change SkTileGride geometry calculations to match the Chromium compositor.
...
This patch changes the semantics of tileWidth/Height to include the border region, and
uses an offset to take into account the fact that there is no outer border for outer
tiles. This patch also fixes a previous bug where the right column and bottom row were
considered to be included in bounds that are expressed as an SkIRect.
Companion Chromium CL required for roll: https://codereview.chromium.org/12221077/
TEST=TileGrid unit test
Review URL: https://codereview.appspot.com/7350050
git-svn-id: http://skia.googlecode.com/svn/trunk@7885 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 18:35:16 +00:00
d1c53aae59
Revert r7883
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7884 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 17:46:09 +00:00
676aef05ab
Use SkSet to fix issue when pdf generates an exp number of resources.
...
The problem fixed - http://code.google.com/p/skia/issues/detail?id=940 - is that getResources will recursively obtain all child resource recursively without checking for duplicates.
If we have lots of duplicates, then we try to build a very large vector (exponential with the number of nodes usually) and sooner or later we end up using too much memory and crash.
A possible solution could have been to make sure resources do not have duplicates, but that requirement is impractical, and it this leaves the solution fragile, if there is any issue in the tree, we crash.
When we emit the pdf, the large number of duplicates is not an issue, because SkPDFCatalog::addObject will deal with duplicates.
I have run the gm with --config pdf, and the images are 100% same bits, while the pdfs have the same size but some very small changes, the order of some objects.
Review URL: https://codereview.appspot.com/6744050
git-svn-id: http://skia.googlecode.com/svn/trunk@7883 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 16:54:44 +00:00
94ba6c62c7
Replace A8 with RGBA8 when renderable A8 isn't supported
...
https://codereview.appspot.com/7372053/
git-svn-id: http://skia.googlecode.com/svn/trunk@7882 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 16:43:49 +00:00
0f0d9b720e
GM : Unused parameters cleanup
...
I removed unused parameters in the gms wherever it was trivial to do so. I'm
trying to get the easy ones out of the way before we get into more involved
discussions around this.
Review URL: https://codereview.appspot.com/7398056
git-svn-id: http://skia.googlecode.com/svn/trunk@7881 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 15:41:12 +00:00
5661c5ba0d
Build freetype as a standalone_static_library
...
Needed by external applications which don't use our libraries in-place.
Review URL: https://codereview.chromium.org/12328138
git-svn-id: http://skia.googlecode.com/svn/trunk@7879 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 14:12:55 +00:00
221179d176
Whitespace change (SkipBuildbotRuns)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7878 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 13:24:35 +00:00
485dcdf58a
Whitespace change (SkipBuildbotRuns)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7877 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 13:24:22 +00:00
f9680ed787
Whitespace change (SkipBuildbotRuns)
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7876 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 13:24:12 +00:00
12eea2b10d
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7875 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-27 07:10:10 +00:00
ee619a059a
fix getFamilyName by calling FcFreeTypeQuery
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7874 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 22:58:09 +00:00
8d38d516c0
Fixed sk_getMetrics_utf32_xy function
...
The unused parameters x and y here seems to be a mistake.
Review URL: https://codereview.appspot.com/7386055
git-svn-id: http://skia.googlecode.com/svn/trunk@7873 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 21:56:19 +00:00
1744f97ea7
Use glGetStringi to get extensions when available.
...
Review URL: https://codereview.chromium.org/12328111
git-svn-id: http://skia.googlecode.com/svn/trunk@7872 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 21:46:32 +00:00
8d33a24cfe
implement CreateTypefaceFromFile
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7869 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 17:11:07 +00:00
098b7ff264
git-svn-id: http://skia.googlecode.com/svn/trunk@7868 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 17:01:26 +00:00
92abe48f24
move SampleTypeface into gm/typefacestyles
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7867 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 16:57:16 +00:00
03ba084373
Whitespace change to test commit-queue
...
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/12328109
git-svn-id: http://skia.googlecode.com/svn/trunk@7866 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 16:25:04 +00:00
9868e7cfd0
Removing blank lines from codereview.settings.
...
depot_tools/checkout.py does not like blank lines:
https://github.com/beurdouche/tools/blob/master/depot_tools/checkout.py#L38
Due to blank lines in our codereview.settings it was not returning the correct VIEW_VC and due to this the 'Commited' line was not showing up in changes submitted by the commit-queue.
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7388061
git-svn-id: http://skia.googlecode.com/svn/trunk@7865 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 16:01:21 +00:00
7ff5c841bf
shape ops work in progress
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7864 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 15:56:05 +00:00
b1c65b62bf
git-svn-id: http://skia.googlecode.com/svn/trunk@7863 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 15:50:51 +00:00
f47dd74da3
Rename template param to SkSTArray to be consistent with its base class, SkTArray.
...
R=jvanverth@google.com
Review URL: https://codereview.appspot.com/7372050
git-svn-id: http://skia.googlecode.com/svn/trunk@7862 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 15:40:01 +00:00
9c58f46c42
Add files omitted from gcl change in r7860.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7861 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 14:45:41 +00:00
8f9436161a
Consolidate functions common the the null and debug GL interfaces.
...
R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7400053
git-svn-id: http://skia.googlecode.com/svn/trunk@7860 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 14:34:43 +00:00
52a3d810d6
Whitespace change to test commit queue
...
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/12326121
git-svn-id: http://skia.googlecode.com/svn/trunk@7859 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 13:13:44 +00:00
2876a59078
Pointing CODE_REVIEW_SERVER to Chromium Rietveld.
...
(SkipBuildbotRuns)
Review URL: https://codereview.appspot.com/7382058
git-svn-id: http://skia.googlecode.com/svn/trunk@7858 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 12:01:28 +00:00
5ca3bd0cbb
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7857 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-26 07:01:22 +00:00
80f5465083
git-svn-id: http://skia.googlecode.com/svn/trunk@7856 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 22:19:20 +00:00
e5f48243bd
Fix a bunch of warnings, mainly around rowBytes.
...
My recent change changed the way SkBitmap::fRowBytes is stored,
and parameter/return values referring to rowBytes were changed
to type size_t. Change the storage back, and eliminate warnings
resulting from returning a size_t.
Review URL: https://codereview.appspot.com/7396059
git-svn-id: http://skia.googlecode.com/svn/trunk@7855 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 21:47:41 +00:00
10863051df
remove duplicate impl for getFileName() on SkFDStream
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7854 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 21:02:21 +00:00
ff57afc64b
Fixed the hash key comparison function.
...
Review URL: https://codereview.appspot.com/7378065
git-svn-id: http://skia.googlecode.com/svn/trunk@7853 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 20:42:44 +00:00
d71fe99fe4
check-point: skiafy SkFontHost_fontconfig from chrome
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7852 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 20:38:07 +00:00
789c6f291e
add --tmpDir foo option to tests, to allow unittests that want to write/read files
...
use tmpDir in SkStream tests
git-svn-id: http://skia.googlecode.com/svn/trunk@7851 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 20:24:24 +00:00
6e4e65066a
Give GrDrawTarget a back ptr to its owning GrContext.
...
Review URL: https://codereview.appspot.com/7395055
git-svn-id: http://skia.googlecode.com/svn/trunk@7850 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 20:12:45 +00:00
04115a102c
Add an SkSet class to be used by Pdf only, for now - reverted because of triggering heap corruption on Win7, original coe review: https://codereview.appspot.com/6749054
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7849 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 20:07:24 +00:00
7b5b18d48a
don't #include <unistd.h> if we're windows
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7848 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 18:46:11 +00:00
fc573abd5c
don't try to access filedescriptors on windows
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7847 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 18:41:26 +00:00
1a6880597e
move SkFDStream out of images into core
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7846 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 18:17:12 +00:00
12d588a7f2
Remove bogus ability for creating an SkPicturePlayback to fail.
...
Change SkPicturePlayback::parseBufferTag to return void, since
it can never return false.
Change SkPicturePlayback::parseStreamTag to return void, since
the only way it can return false is if parseBufferTag returns
false, or if creating a sub picture failed, both of which are
nonsensical.
Due to the above, there is no reason for creating an
SkPicturePlayback to fail, so remove the isValid parameter.
Update subclasses in SkDebuggerGUI.
Review URL: https://codereview.appspot.com/7388050
git-svn-id: http://skia.googlecode.com/svn/trunk@7844 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 16:05:00 +00:00
0ba4bf427a
Use size_t for rowBytes.
...
Previously, we were using uint32_t sometimes, int sometimes, and
size_t sometimes. Switch to using size_t, since we are actually
talking about a number of bytes.
In copyPixelsTo, use 0 as a flag to use the internal rowBytes,
which is more consistent with setConfig.
Review URL: https://codereview.appspot.com/7370047
git-svn-id: http://skia.googlecode.com/svn/trunk@7843 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 16:02:36 +00:00
9447103029
Always round text position correctly.
...
https://codereview.appspot.com/7383049/
Will require rebaseline of fontscaler GM.
Must add SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX to Chromium
until ~150 layout tests can be rebaselined.
git-svn-id: http://skia.googlecode.com/svn/trunk@7842 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 15:55:13 +00:00
570ed6466c
Whitespace change to test commit queue
...
(SkipBuildbotRuns)
Review URL: https://chromiumcodereview.appspot.com/12340051
git-svn-id: http://skia.googlecode.com/svn/trunk@7841 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 13:32:31 +00:00
ffb91da3e7
Fixed '#if with no expression' warning/error
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7840 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-25 01:38:01 +00:00
58433de862
Sanitizing source files in Skia_Periodic_House_Keeping
...
git-svn-id: http://skia.googlecode.com/svn/trunk@7839 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-23 07:02:45 +00:00
9f123162f7
Fix debugger build.
...
Review URL: https://codereview.appspot.com/7375050
git-svn-id: http://skia.googlecode.com/svn/trunk@7838 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-02-22 22:37:31 +00:00
sugoi@google.com
reed@google.com
bsalomon@google.com
junov@chromium.org
edisonn@google.com
robertphillips@google.com
borenet@google.com
rmistry@google.com
skia.committer@gmail.com
commit-bot@chromium.org
caryclark@google.com
scroggo@google.com
bungeman@google.com