6cb74f2b86
Adjusts Ubuntu bench multi_4_threads values. Widens range to cope with the new average instead of 25th.
...
BUG=
R=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/108653014
git-svn-id: http://skia.googlecode.com/svn/trunk@12736 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 14:55:02 +00:00
3b85deb9c3
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12734 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 07:01:56 +00:00
83c6a22525
remove last remnant of SK_SCALAR_IS_FIXED code
...
move SkScalarMean into its only caller, reducing out public API exposure
BUG=
Review URL: https://codereview.chromium.org/117133004
git-svn-id: http://skia.googlecode.com/svn/trunk@12733 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 05:19:22 +00:00
6e252d49c9
move SkScalarMean into its only caller, reducing out public API exposure
...
BUG=
Review URL: https://codereview.chromium.org/117973002
git-svn-id: http://skia.googlecode.com/svn/trunk@12732 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 05:06:52 +00:00
e15b2f5296
move SkScalarLog2 into its only client, in a move to reduce our public API surface area
...
BUG=
Review URL: https://codereview.chromium.org/93643004
git-svn-id: http://skia.googlecode.com/svn/trunk@12731 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 04:59:26 +00:00
0fc0dea333
Add a setTimer() function.
...
Seemed simple, but required adding a Global class that contains all the global state (instance and context) for our running V8 instance. Also moved canvas.inval to be just inval() at the global level.
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/103143009
git-svn-id: http://skia.googlecode.com/svn/trunk@12730 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-18 04:45:37 +00:00
4e8f1e56b1
[PDF] Fix clipping in xfermode improvement.
...
In some cases, the wrong clip (src clip instead of initial clip) was used.
Switch almost exclusively to initial clip because it is safe and generates a smaller result.
BUG=chromium:328009
R=reed@google.com , bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/116423004
git-svn-id: http://skia.googlecode.com/svn/trunk@12729 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:38:28 +00:00
b09bfcb7b1
add virtual destructor for SkExample to fix build error.
...
The original SkExample have virtual function draw(), but have no virtual destructor. This may lead to memory leak when free the instance of derived class of SkExample. The latest skia code show error when build SkiaExamples by "ninja -C out/Release SkiaExamples":
error: ‘class SkExample’ has virtual functions and accessible non-virtual destructor.
R=caryclark@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/98463013
git-svn-id: http://skia.googlecode.com/svn/trunk@12728 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 23:37:38 +00:00
658e1b38b9
Fixing valgrind error
...
After an error in the stream prevented the deserialization of SkRect members, there was no check to see if there was an error state before testing the validity of these uninitialized SkRect members. Added the check to fix the valgrind error.
BUG=
R=robertphillips@google.com , sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/114493005
git-svn-id: http://skia.googlecode.com/svn/trunk@12727 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:32:42 +00:00
d6c1d58763
Remove bleed from ignored-tests.txt
...
BUG=skia:1880
Review URL: https://codereview.chromium.org/103213011
git-svn-id: http://skia.googlecode.com/svn/trunk@12726 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:27:39 +00:00
62bb849a88
Mark bleed gpu as ignore failure on Xoom (Release version)
...
BUG=skia:1938
Review URL: https://codereview.chromium.org/117633002
git-svn-id: http://skia.googlecode.com/svn/trunk@12725 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:20:41 +00:00
c1c6a4f552
Mark bleed gpu as ignore failure on Xoom
...
BUG=skia:1938
Review URL: https://codereview.chromium.org/116093005
git-svn-id: http://skia.googlecode.com/svn/trunk@12724 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 21:13:00 +00:00
ef74fa189b
Fixed more fuzzer issues
...
- Added the "isAvailable" function to check how much bytes are remaining in the stream before doing potentially large mallocs. That way, we can signal a bad stream instead of crashing.
- Added data validation in SkImageInfo.cpp
- Added NULL pointer check in displacement
- Modified the fuzzer for randomized bitmap types
BUG=328934,329254
R=senorblanco@google.com , senorblanco@chromium.org , reed@google.com , sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/116773002
git-svn-id: http://skia.googlecode.com/svn/trunk@12723 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:49:46 +00:00
7d0b613191
Mark 8888/565 bleed GMS as ignore-failure
...
BUG=skia:1934
Review URL: https://codereview.chromium.org/117563003
git-svn-id: http://skia.googlecode.com/svn/trunk@12722 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:30:17 +00:00
b6a1c0154d
Adjusts Win7 bench tile_256x256_multi_4_threads. Using 8f4d230.
...
BUG=
R=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/117523002
git-svn-id: http://skia.googlecode.com/svn/trunk@12721 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 20:23:22 +00:00
26deb23e15
change SkScalarRound to SkScalarRoundToInt
...
BUG=
Review URL: https://codereview.chromium.org/105073006
git-svn-id: http://skia.googlecode.com/svn/trunk@12720 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 19:50:57 +00:00
e1ca705cac
deprecate SkScalarRound (and its ilk), use SkScalarRound[ToInt,ToScalar]. #define SK_SUPPORT_DEPRECATED_SCALARROUND for legacy clients
...
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/111353003
git-svn-id: http://skia.googlecode.com/svn/trunk@12719 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 19:22:07 +00:00
3fb15f4d21
Bench rebaseline for Ubuntu. Also manually adjust one entry for Nexus7.
...
BUG= https://code.google.com/p/skia/issues/detail?id=1871
R=robertphillips@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/106593003
git-svn-id: http://skia.googlecode.com/svn/trunk@12718 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 18:39:27 +00:00
50ad8e4d8e
rebaseline_server: return rebaseline results faster, and reload UI page automatically after
...
Old way:
Wait until server has loaded the updated results before telling the user the rebaseline
was successful, and trust the user to reload the page before submitting more baselines.
New way:
Make server load the updated results in a separate thread, and automatically reload the page
so that the user can submit more baselines if she wants to.
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=bsalomon@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/117453002
git-svn-id: http://skia.googlecode.com/svn/trunk@12717 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 18:06:13 +00:00
588be53706
Added five small images to the resources/encoding.
...
1428 bytes total.
For use in testing https://codereview.chromium.org/93703004/
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/107863005
git-svn-id: http://skia.googlecode.com/svn/trunk@12716 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:40:13 +00:00
55f6b24eb8
Add unreviewed skimage expectations for Test-Win8-ShuttleA-GTX660-x86-Release-NVPR
...
NOTRY=True
BUG=
R=scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/110663006
git-svn-id: http://skia.googlecode.com/svn/trunk@12715 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:35:13 +00:00
bf8ba65cca
Add Win8 bots to rebaseline.py, add baselines for Win8
...
NOTRY=True
BUG=
R=epoger@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/117433003
git-svn-id: http://skia.googlecode.com/svn/trunk@12714 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 17:29:33 +00:00
8f4d2306fa
remove SK_SCALAR_IS_[FLOAT,FIXED] and assume floats
...
To keep the CL (slightly) managable, this does not make any changes to
existing macros (e.g. SkScalarMul). Just tackling #ifdef constructs this
time around.
BUG=
R=bsalomon@google.com , caryclark@google.com
Review URL: https://codereview.chromium.org/117053002
git-svn-id: http://skia.googlecode.com/svn/trunk@12712 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:44:46 +00:00
a34b638b90
Rebaseline gpu and pdf bleed GM images
...
BUG=1880
Review URL: https://codereview.chromium.org/100023006
git-svn-id: http://skia.googlecode.com/svn/trunk@12711 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:37:07 +00:00
4952516abe
Create empty GM expectations for all Win8 builders
...
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/117233003
git-svn-id: http://skia.googlecode.com/svn/trunk@12710 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:33:35 +00:00
bbd893dcc3
Fix handling of aggregate times in TimerData::getResult
...
https://codereview.chromium.org/117393002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12709 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 16:32:51 +00:00
442fa37ffd
Rebaseline innocuous image changes on Android.
...
Review URL: https://codereview.chromium.org/117343002
git-svn-id: http://skia.googlecode.com/svn/trunk@12708 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 15:34:17 +00:00
3cf7e93b67
Revert r12694 (Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows - https://codereview.chromium.org/111403003 ) due to Chromium-side compilation errors
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12707 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 15:13:55 +00:00
77887af13f
Prevent crash in Lua bindings.
...
SkPaint::getTypeface() can return NULL; paint:getTypeface() would
attempt to refcount that value before storing it on the Lua stack
and crash. This is a minimal workaround that fixes the crash.
R=reed@google.com , tomhudson@google.com , robertphillips@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/109793010
git-svn-id: http://skia.googlecode.com/svn/trunk@12706 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 14:28:19 +00:00
090601c917
Make bench_pictures' timing more GPU friendly
...
https://codereview.chromium.org/113873005/
git-svn-id: http://skia.googlecode.com/svn/trunk@12705 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 13:40:20 +00:00
495dc860bf
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12703 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-17 07:01:45 +00:00
46ec81572b
The register keyword is deprecated in C++, even at -O0, registers are used automatically.
...
Having the register keyword there causes a warning about deprecated keywords when using clang (and possibly future gcc versions), and isn't needed.
Patch originally submitted to AOSP
https://android-review.googlesource.com/#/c/72501
R=mtklein@google.com , scroggo@google.com , reed@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/93703005
git-svn-id: http://skia.googlecode.com/svn/trunk@12702 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 23:51:11 +00:00
c285864fb7
Add new baselines for Win8 decoding tests.
...
Taken from server, and unreviewed.
Review URL: https://codereview.chromium.org/114813005
git-svn-id: http://skia.googlecode.com/svn/trunk@12700 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 23:09:20 +00:00
cea08483de
Bench rebaseline for Nexus7 and Win7. Expected values are from versions afada4c and 48d94b8.
...
BUG=
R=robertphillips@google.com , rmistry@google.com
Author: bensong@google.com
Review URL: https://codereview.chromium.org/107663007
git-svn-id: http://skia.googlecode.com/svn/trunk@12699 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 22:58:40 +00:00
79b7eeebdf
Tweaks in how to apply bitmap filter levels in GPU.
...
Fix fallback to MIP from bicubic for bitmap shaders
Skip MIP level generation on GPU when not minifying
Add medium quality and mixed up/down matrix test cases to filterbitmap tests
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/103913012
git-svn-id: http://skia.googlecode.com/svn/trunk@12697 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 21:02:29 +00:00
0207683157
Remove an assert that assumes too much.
...
The resulting bitmap may look funny, but it may not be our bug, and
the assert is making it difficult to use SKP files.
TBR=robertphillips@google.com , rmistry@google.com , bensong@google.com
BUG=skia:1905
Review URL: https://codereview.chromium.org/111463006
git-svn-id: http://skia.googlecode.com/svn/trunk@12696 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 20:02:03 +00:00
4ad1e97b85
Add a print function in the global JS scope for debugging.
...
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/100583005
git-svn-id: http://skia.googlecode.com/svn/trunk@12695 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 19:55:01 +00:00
6ed67789c5
Updated GLintptr and GLsizeiptr to be the appropriate types on 64 bit Windows
...
BUG=326382
R=reed@google.com , bsalomon@google.com
Author: bajones@chromium.org
Review URL: https://codereview.chromium.org/111403003
git-svn-id: http://skia.googlecode.com/svn/trunk@12694 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 19:47:16 +00:00
477ed38504
rebaseline android images that use bicubic effect
...
Review URL: https://codereview.chromium.org/116573002
git-svn-id: http://skia.googlecode.com/svn/trunk@12693 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 18:51:33 +00:00
48d94b8ce5
Add command line flag for optionally loading JS from external files.
...
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/111853008
git-svn-id: http://skia.googlecode.com/svn/trunk@12692 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 18:24:51 +00:00
afada4c2e6
Refreshed SKPs to version 17. Triggering rebuilds.
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12690 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 17:14:02 +00:00
cbe1b54c30
Supports the cap height for FreeType even when TT OS2 version is 1.
...
BUG=http://crbug.com/318645
R=bungeman@google.com , reed@google.com
Review URL: https://codereview.chromium.org/101333004
git-svn-id: http://skia.googlecode.com/svn/trunk@12689 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 17:02:39 +00:00
7d7f31433b
Use GrTextureDomain in GrBicubicEffect to perform non-bleeding HQ filter drawBitmap.
...
R=senorblanco@chromium.org , robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/99203011
git-svn-id: http://skia.googlecode.com/svn/trunk@12687 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 15:18:11 +00:00
3c12840b23
remove SkFP.h and replace SkFP with SkScalar stop respecting SK_SOFTWARE_FLOAT, assume its always false stop respecting SK_SCALAR_SLOW_COMPARES, assume its always false
...
BUG=
R=caryclark@google.com
Review URL: https://codereview.chromium.org/116183002
git-svn-id: http://skia.googlecode.com/svn/trunk@12686 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 14:17:40 +00:00
96f5fa02e9
Sanitizing source files in Housekeeper-Nightly
...
git-svn-id: http://skia.googlecode.com/svn/trunk@12685 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-16 07:01:40 +00:00
4f3c305a5b
Fix some presubmit warnings.
...
I found this while running a modified version of v8's tools/presubmit.py
script.
samplecode/SampleImage.cpp does not end with a single new line.
samplecode/SampleImageDir.cpp does not end with a single new line.
src/ports/SkFontHost_sandbox_none.cpp does not end with a single new line.
tests/FlatDataTest.cpp does not end with a single new line.
tests/ImageCacheTest.cpp has trailing whitespaces in line 31.
* Removed three empty files.
* Add single new line to FlatDataTest.cpp
* Removed trailing whitespace in ImageCacheTest.cpp
BUG=None
TEST=None
R=bsalomon@google.com
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/111503008
git-svn-id: http://skia.googlecode.com/svn/trunk@12684 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-14 15:12:48 +00:00
cfd90d6073
Use SkScalar when aligning glyphs in user space.
...
Drawing text from paths is done in user space and not in device space.
All operations in user space should be performed with SkScalars.
BUG=327031
R=reed@google.com
Review URL: https://codereview.chromium.org/113123005
git-svn-id: http://skia.googlecode.com/svn/trunk@12682 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-13 21:26:02 +00:00
c0784dbd40
remove SkScalarCompare type and header
...
BUG=
R=fmalita@chromium.org
Review URL: https://codereview.chromium.org/113193004
git-svn-id: http://skia.googlecode.com/svn/trunk@12681 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-13 21:16:12 +00:00
a3f882c475
render_pictures: add --writeJsonSummaryPath
...
Known issues:
- JSON summary will be empty if --writePath not specified also
- testNames within summary do not include the config (8888, gpu, etc.)
BUG=
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/98643007
git-svn-id: http://skia.googlecode.com/svn/trunk@12680 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-13 20:52:36 +00:00
e132f5031f
bump picture format to 17 to go with PixelRef Info CL
...
BUG=
Review URL: https://codereview.chromium.org/106763004
git-svn-id: http://skia.googlecode.com/svn/trunk@12678 2bbb7eff-a529-9590-31e7-b0007b416f81
2013-12-13 19:58:46 +00:00
commit-bot@chromium.org
skia.committer@gmail.com
reed@google.com
bsalomon@google.com
halcanary@google.com
robertphillips@google.com
scroggo@google.com
rmistry@google.com
bungeman@google.com
tfarina@chromium.org