Граф коммитов

434 Коммитов

Автор SHA1 Сообщение Дата
Mike Williams 37446df7ce
Merge pull request #351 from mozilla/update-docs-deploy-node
chore: update docs-deploy to supported dep versions
2024-10-09 11:24:43 -04:00
Mike Williams 4b757ca742
done testing, revert config to normal filters 2024-10-09 11:13:42 -04:00
Mike Williams f643372a34
test docs-deploy 2024-10-09 11:09:17 -04:00
Mike Williams bd3295e6e1
chore: update docs-deploy to supported dep versions 2024-10-09 10:06:04 -04:00
Mike Williams 8d610f9b98
Merge pull request #325 from mozilla/custom-query-validation
add warning if wrong analysis_unit in custom query
2024-09-25 10:29:41 -04:00
Mike Williams c6285de478
raise ValueError to be handled by caller (with suppress flag) 2024-09-24 13:52:06 -04:00
Mike Williams 2a7347f538
add warning if wrong analysis_unit in custom query 2024-09-19 11:56:06 -04:00
Mike Williams e378d37f0b
Merge pull request #324 from mozilla/rename-analysis-id
use analysis_id instead of client/profile_group for consistency
2024-09-19 11:25:47 -04:00
Mike Williams 582a00bf51
fix non-desktop queries 2024-09-18 15:29:05 -04:00
Mike Williams 6f2b0c52ea
use analysis_id instead of client/profile_group for consistency 2024-09-18 14:38:38 -04:00
Mike Williams 3a0192cc36
Merge pull request #323 from mozilla/exposure-signal-profile-group
add analysis unit to exposure signal; consistent id usage in query builders
2024-09-17 15:52:11 -04:00
Mike Williams 653b3da224
add test for DS query builder 2024-09-17 15:48:15 -04:00
Mike Williams c35c8b7729
add analysis unit to exposure signal; consistent id usage in query builders 2024-09-16 15:39:18 -04:00
Mike Williams 88c1e21b37
Merge pull request #322 from mozilla/fix-build
bug: fix build by installing proper reqs in CI
2024-09-16 13:11:45 -04:00
Mike Williams 10a86f0439
bug: fix build by installing proper reqs in CI 2024-09-16 12:37:33 -04:00
Mike Williams 73b4a48f4a
Merge pull request #321 from mozilla/DS-3787-analysis-unit-segments
add analysis unit support for segments
2024-09-13 18:11:15 -04:00
Mike Williams cbc08aeeea
revert bad test 2024-09-13 18:00:03 -04:00
Mike Williams dafba6f2a6
add test for analysis_unit in segments 2024-09-13 17:52:23 -04:00
Mike Williams fa9f3e4e02
add analysis unit support for segments 2024-09-13 17:33:09 -04:00
Jared Snyder 395416ca77
Update deps (#320)
* update requirements

* ran ruff check --fix after ruff update
2024-09-12 14:21:06 -05:00
Mike Williams 04f7d739f7
Merge pull request #318 from mozilla/small-improvements
types in experiment.py; fix incomplete test; sort/organize deps
2024-09-04 17:11:18 -04:00
Mike Williams 65157253fb
fix imports 2024-09-04 16:42:09 -04:00
Mike Williams bdffec6a20
types in experiment.py; fix incomplete test; sort/organize deps 2024-09-04 16:39:41 -04:00
Daniel Berry 6340796107
Remove downsampling restriction for group level experiments (#295)
* Remove downsampling restriction for group level experiments

* removes now-outdated test case
2024-08-23 08:04:06 -07:00
Daniel Berry 8abcbb587a
DS-3791: Groupid aggregation (#273)
* first draft

* clean up typing for experiment.py

* ruff

* added some tests

* dedent to lint

* added unit tests

* more tests

* more unit tests

* Update pyproject.toml

* Update pyproject.toml

* Update pyproject.toml

* Update pyproject.toml

* cleanup

* more cleanup, additional test

* refactor, AnalysisUnit -> ExperimentalUnit

* refactor enum levels

* update docstring

* combined client/group query strings into one, added check for downsampling

* Update src/mozanalysis/metrics.py

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

* Update src/mozanalysis/metrics.py

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

* Update src/mozanalysis/experiment.py

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

* Update src/mozanalysis/experiment.py

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

* cleanup

* rename unit from GROUP to PROFILE_GROUP

* stricter typing, eliminates unexpected runtype type differences

* linting

* mypy validation for metrics.py

* ExperimentalUnit -> AnalysisUnit

* make string multiline

* change timelimits analysis windows type

* TimeSeriesResult analysis window parameter match TimeSeries

* Update metrics.py

* update metric-config-parser

* import AnalysisUnit from metric-config-parser

* update test

* circle's ruff out of sync with dependencies

* ruff fix

* missed .value

* Update metrics.py

* removed analysis_unit converter

---------

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
2024-08-22 08:34:49 -07:00
Jared Snyder 595cca318f
update deps (#294) 2024-08-12 13:32:14 -05:00
Daniel Berry 4eabf792e0
Update config.py (#272)
* Update config.py

* updated tests

* linting

* found one more test

* linting

* Update src/mozanalysis/config.py

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

* update other error messages

* unit tests more specific

---------

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
2024-08-01 10:16:12 -07:00
Mike Williams 7cd31a1588
Merge pull request #270 from mozilla/minor-test-update
chore: more precise errors in tests; README typos
2024-07-11 12:21:39 -04:00
Mike Williams e051d5b680
chore: more precise errors in tests; README typos 2024-07-11 12:07:56 -04:00
Daniel Berry 3c47d60ece
Additional failure cases (#269)
* changes

* updated tests

* fixed errors from new user experiment

* updates

* linting

* improvements to typing

* added doc strings

* added new test case

* ruff

* responses to PR comments

* forgot types file
2024-07-10 15:04:49 -07:00
Daniel Berry 4bc4184579
When covariate missing, fall back to unadjusted inferences (#268)
* switched to warn, added test cases

* cleared up type of message
2024-07-08 13:57:42 -07:00
Daniel Berry 208ad7e9e6
Update test_linear_model_functions.py (#266)
* Update test_linear_model_functions.py

* linting

* fixes

* fixes for new test cases

* added test case

* fixed test case, errors out now

* should cause test to pass
2024-07-02 13:10:55 -07:00
Daniel Berry 2e5a1184e5
Improve the performance of linear model inferences (#250)
* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* updates

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* Update linear_models.py

* wip

* seems to be working even on large dataset

* starting cleanup

* more cleanup

* more cleanup

* more cleanup

* cleanup

* refactored into OLS subclass

* broken again...

* first attempt with sparse

* wip, running consistently with a bit of extra memory

* cleanup

* more cleanup

* fixed unit tests

* refactored into helper class

* added tests for MozOLS

* added parameters to avoid surprising inplace modifications

* moved datagrid out to its own function

* cleanup

* fix merge artifacts

* Update functions.py

* added tests comparing relative inferences with and without the data compression

* fixed test case
2024-07-01 07:51:21 -07:00
Jared Snyder 19d673f763
updated deps (#253)
* updated deps

* update pyproject.toml to allow marginaleffects and ruff to get updates

* revert marginaleffects and unpin ruff
2024-06-20 14:52:25 -05:00
Jared Snyder 5e723ef0b7
remove configloader helper objects (#233)
* remove configloader helper objects

* linting:

* removed deprecated doc files from sphinx

* fixed mistake in docstring

* removed redundant tests

* remove path modification from conftest.py and consolidated desktop metric creation

* linting

* actually add stuff to the file I created instead of being a moron

* import lists in test

* consolidated lists in config_loader_lists
2024-05-22 11:11:44 -05:00
dependabot[bot] 32737a55e4
--- (#232)
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jared Snyder <jsnyder@mozilla.com>
2024-05-21 10:39:00 -05:00
dependabot[bot] abf5f00a58
--- (#231)
updated-dependencies:
- dependency-name: requests
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-05-21 10:35:28 -05:00
Jared Snyder 891cb4501b
Improving dependency management as per ADR 0001 (#228)
* feat: replace setup.py with pyproject.toml and added requirements.txt

* updated tox.ini to fix codecov

* enable dependabot

* enable dependabot

* added more details to README

* added dev optional dependencies and update requirements.txt to use them

* added build package to remove setup.py from circleci config

* TESTING CI

* TESTING CI

* FIXING CI: add twine to test deps

* FIXING CI: separated out dev requirements

* FIXING CI: add indirect dependency to make pip happy

* TESTING CI: add readme to pyproject.toml to stop warnings

* REVERT changes to circleci now that testing is done

* added more to readme

* constrain requirements-dev with requirements

* cleaned up README installation section

* cleaned up README installation section

* Update README.md

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>

---------

Co-authored-by: Mike Williams <102263964+mikewilli@users.noreply.github.com>
2024-05-21 09:06:57 -05:00
Daniel Berry 97d7932df6
Merge pull request #229 from mozilla/covariate-quality-check
Add additional tests and fallback logic when covariate is degenerate
2024-05-20 13:39:11 -07:00
Daniel Berry 2bb9a5df59
Update linear_models.py 2024-05-20 13:36:29 -07:00
Daniel Berry f5e37623ad linting 2024-05-20 19:38:21 +00:00
Daniel Berry b56f25e87e added check for bad branches 2024-05-20 19:36:02 +00:00
Daniel Berry 2b278f2f8e added check that all branches appear in output 2024-05-20 12:22:12 -07:00
Daniel Berry 276eea1f49 clean up previous attempt 2024-05-20 12:01:01 -07:00
Daniel Berry 39503914da linting 2024-05-20 18:58:58 +00:00
Daniel Berry bd668ae5e0 added fallback logic 2024-05-20 18:55:21 +00:00
Daniel Berry 952df78587 first pass 2024-05-20 10:41:07 -07:00
Daniel Berry adeb867a41
Merge pull request #227 from mozilla/danielkberry-patch-3
Fix marginaleffects version
2024-05-15 10:23:53 -07:00
Jared Snyder 416e87d1e1
min version for metric-config-parser 2024-05-15 12:15:19 -05:00
Jared Snyder ea840f369d pin mozilla-metric-config-parser to fix local tests 2024-05-15 12:09:43 -05:00