c7473a799d
Fix bug # 145858 - imported bookmarked issue with NetPositive. Change required to old bug fix to get search results resolving correctly with aggregation. r=sergei_d@fi.tartu.ee sr=darin
2007-09-12 17:50:16 +00:00
185df99689
Move FROZEN ContractID into nsXPCOM.h and define r=rpotts, sr=alec, b=166426
2007-09-12 17:50:15 +00:00
5352d67a2f
Bug 161945 clean up simple mac build warnings
...
r=dbradley sr=bz
2007-09-12 17:50:14 +00:00
d018a94103
bug 157624 - freeze nsISupportsPrimitives, which includes changing nsISupport[C]String over to using A[C]String and fixing consumers
...
r=dougt, sr=darin
2007-09-12 17:50:13 +00:00
8428ccef92
Fix bug 159889: replace the hardcode of "@mozilla.org/preferences;1" with NS_PREF_CONTRACTID
...
Patch by leon.zhang@sun.com
r=Henry, sr=alecf
2007-09-12 17:50:12 +00:00
21aed548a7
2nd patch for bug 158080
...
Description: replace the hardcode of "@mozilla.org/embedcomp/window-watcher;1" with NS_WINDOWWATCHER_CONTRACTID
Patch by Henry.Jia@sun.com
r=anto, sr=alecf
2007-09-12 17:50:11 +00:00
e032a4d827
bug 157624 - prep for freezing nsISupports* primitives by renaming the string classes appropriately
...
nsISupportsString -> nsISupportsCString
nsISupportsWString -> nsISupportsString
r=dougt, sr=jag
2007-09-12 17:50:10 +00:00
39c32c5f8f
Bug 151837 Export Bookmarks in Bookmark Manager saves nothing
...
r=pierrechanial@netscape.net , sr=blake, a=asa
Must not delete/rename the temp file if tempFile == aBookmarksFile
2007-09-12 17:50:09 +00:00
54bb2c0a52
address reviewer comments (whitespace)
2007-09-12 17:50:08 +00:00
6da8aea318
bug 145858 patch by sergei_d@fi.tartu.ee r=timeless a=asa
...
Imported NetPositive Bookmarks are not loaded properly anymore
2007-09-12 17:50:07 +00:00
4894ea8c1a
Fix all of the warnings about member initializer ordering in constructors (bug 156135). r=timeless, sr=jag.
2007-09-12 17:50:06 +00:00
e0a3f7d4d0
Fix for 86501 - bookmarks truncated when disk full
...
Make bookmarks check on the success of the file stream write before overwriting the old bookmarks file with the new one.
r=darin, sr=brendan
2007-09-12 17:50:05 +00:00
fadb0d99e2
bug 115473 r=pavlov sr=brendan
...
Remove timer priorities
2007-09-12 17:50:04 +00:00
851056dee6
Bug 139471 Rewrite of the personal toolbar drag and drop observer patch=pierrechanial@netscape.net, r=timeless, sr=ben
...
(maybe you should increment the version number to 2.1)
2007-09-12 17:50:03 +00:00
0ba50d189e
Fix for bug 86501 - bookmarks.html file is truncated to 0-length when shutting down with a full profile disk. Write bookmarks to a temporary file, and rename that to 'bookmarks.html' only if the write operation succeeded. r=bryner, sr=jag.
2007-09-12 17:50:02 +00:00
c6027def9e
fixing XP_WIN bookmarks bustage
2007-09-12 17:50:01 +00:00
a59ce831a1
Bug 129428: Paste doesn't work in bookmark manager. Patch by ben@netscape.com, r=pierrechanial@netscape.net, sr=jag
2007-09-12 17:50:00 +00:00
de043ff664
fixes bug 129279 "nsIFile unicode/utf8/ascii task"
...
r=dougt sr=alecf
2007-09-12 17:49:59 +00:00
579b0eb86e
Fix two bugs:
...
- 130614 [adt2] Trunk crashes on startup on Win95 @ nsBookmarksService::ParseFavoritesFolder
On older Windows installs, IE4 is not present and as a result there's no system
favorites folder. Insert a null check so that we only parse a system favorites folder
if one exists.
r=bryner, sr=hyatt
- 127476 [adt1] Non-ASCII characters in IE Favorites are imported as garbage.
IE stores Favorite Name as the non-extension part of the file name (baseName). The
code was using GetFileBaseName, which returns a CString (dumb!). Converted to
extract the bookmark name from the unicode leaf name.
r=ftang, sr=hyatt
2007-09-12 17:49:58 +00:00
40a46904d8
fixes bug 130079 "Importing IE favorites turns spaces into %20 (URL-encoded)"
...
patch=andreas.otte@debitel.net r=ben sr=darin
2007-09-12 17:49:57 +00:00
ffa5313e8c
Bug 119599: add UI for bookmark groups in the File Bookmark dialog. r=bryner, sr=hewitt, a=asa
2007-09-12 17:49:56 +00:00
7823ce6ae6
Remove xp_core.h & xp_mem.h and all build references to them.
...
Remove cruft from xp_mcom.h & xp_str.h.
Bug #38061 r=brendan sr=alecf a=valeski
2007-09-12 17:49:55 +00:00
82eb217257
b=128508 "freeze nsIChannel nsIRequest" r=gagan, sr=rpotts, a=asa
2007-09-12 17:49:54 +00:00
b1ed30ee65
a further nsString api reduction: remove the last case-insensitive PRUnichar*-to-PRUnichar* comparisons, moving to new API, and remove old methods from nsString. r=dougt, sr=jag a=scc
2007-09-12 17:49:53 +00:00
b5ff201f12
Bug 106386 rid source of misspellings
...
r=db48x sr=blake a=asa
2007-09-12 17:49:52 +00:00
02896cb288
Landng boomar groups. 119599 r ben sr jag a asa
2007-09-12 17:49:51 +00:00
04cc28d1b1
Fix build bustage. r=bryner, sr=blake
2007-09-12 17:49:50 +00:00
dc0de3e526
Fix for 128815 - numerous bookmarks improvements, including fixes for bugs: 77411, 114142, 126748, 128571.
...
r=blake, sr=hyatt, a=asa
2007-09-12 17:49:49 +00:00
2715df8383
fixes bug 124042 "support internationalized URIs" r=dougt, sr=alecf, a=asa
2007-09-12 17:49:48 +00:00
8086c8fed5
bug 127091 - big string cleanup, removing old APIs
...
- removing Assign/AppendWithConversion for single-characters
- removing unused StripChars
- removing ReplaceChar[s] for non-matching chars
- removing CompressSet
- removing nsCString::Find/FindCharInSet/RFind for unichar strings
- removing lots of EqualsWithConversion
r=dp, sr=jag
a=asa
2007-09-12 17:49:47 +00:00
55127bfd41
Use PR_TRUE instead of true.
...
Fixing OS/2 & AIX tinderbox bustage
2007-09-12 17:49:46 +00:00
9d7288ec13
Fix for 106326 - better handling of IE favorites. Adding support for one-time import of
...
IE favorites in addition to dynamic root which is now off by default.
Also update the nsIBookmarkService API to support IDL naming conventions, and enhance API
with utility methods requested and required by clients.
r=rjc, sr=hyatt
2007-09-12 17:49:45 +00:00
84de0c1865
Fix bug # 125361: bookmarks issue. r=tingley sr=ben
2007-09-12 17:49:44 +00:00
a7c1dda9fa
eliminate nsCRT::strlen for char* strings (part 4), bug 124536 r=dp sr=brendan
2007-09-12 17:49:43 +00:00
86fe92b055
Remove more no-longer-needed nsComponentManager::RegisterComponent calls. Remove remnants of NS_IMPL_IDS macro, associated with long-gone NS_DECLARE_ID. b=125782 r=dougt rs=jag
2007-09-12 17:49:42 +00:00
efe5303ffb
Fix bug # 125122: Synthetic bmk type issue. r/sr=ben
2007-09-12 17:49:41 +00:00
fa970cc4a3
Fix bug # 124743: RDF SEQs. r=tingley sr=ben
2007-09-12 17:49:40 +00:00
010c8d99b4
Relanding the Compare --> Equals conversion. a=mcafee
2007-09-12 17:49:39 +00:00
74a769821b
Testing performance impact of backout of what's left of the patch from
...
bug 115289. See bug 123947 for details. a=mcafee
2007-09-12 17:49:38 +00:00
07f015de0f
Make sure to escape bookmark folder names before writing them out to the
...
file. Bug 65098, patch by Hugh Kennedy <kennedyh@engin.umich.edu>,
r=bzbarsky, sr=shaver
2007-09-12 17:49:37 +00:00
aae3878e10
Fix bug # 124322: bookmark optimizations (cut down on # of assertions for common node types, and make scheduler far more lightweight.) r=pavlov sr=ben
2007-09-12 17:49:36 +00:00
47d57c2cf7
Convert Compare() to Equals() where possible now that we can do
...
case-insensitive Equals(). Bug 115289, r=alecf, sr=jag
2007-09-12 17:49:35 +00:00
e59fc59d85
First part of fix for bug 107575 - remove nsString::FindChar because there is already an nsAString::FindChar, and remove the "ignore case" option in RFindChar
...
r=dougt, sr=jag
2007-09-12 17:49:34 +00:00
6c7c1d4cf1
Bug 113228: Replace ns{C}String::To{Upper,Lower}Case with global versions. r=bzbarsky, sr=jst
2007-09-12 17:49:33 +00:00
38503b819a
Bug 104158: Use NS_LITERAL_STRING instead of XXXWithConversion("..."). r=bryner, rs=alecf
2007-09-12 17:49:32 +00:00
24f92ae1ab
Adding new files for conversion to CW7 and XML project files. Bug 98349 r=pink/sr=sfraser.
2007-09-12 17:49:31 +00:00
fdabca49ab
Fix bug #108809 . r=ben sr=hyatt
2007-09-12 17:49:30 +00:00
fef7bcccc0
bug 107900, r=jag, sr=ben, return bool from ReadBookmarks()
2007-09-12 17:49:29 +00:00
cd307b5677
bug 14824, r=rjc, sr=blake, add LoadBookmarks() and initDatasource() protected member functions
2007-09-12 17:49:28 +00:00
00edc6750f
bug 107900, r=jag, sr=ben, return true if we loaded bookmarks, otherwise
...
return false
2007-09-12 17:49:27 +00:00
076a068d11
bug 108539, r=jag, sr=sfraser, need to call NS_IF_RELEASE(mInner) to prevent leak of datasource, also cleaned up create instance call
2007-09-12 17:49:26 +00:00
80373b741f
bug 14824, r=rjc, sr=blake, don't read bookmarks.html in nsBookmarksService::Init(), load bookmarks once in ReadBookmarks()
2007-09-12 17:49:25 +00:00
0c2f935d3c
bug 68329, r=jag, sr=sfraser, resurrected an old patch from sfraser which
...
cleans up a lot of the string stuff, had help from jag to clean string
stuff even more
2007-09-12 17:49:24 +00:00
8e7c7994c9
Bug 53057: Fixing up users of implicit |CharT*| conversion operators for nsCString to use |.get()| instead, rr=dbaron, rs=scc
2007-09-12 17:49:23 +00:00
98c4135221
99163 - removing nsObserverService.h includes. Also fixing 106090, extra methods on nsObserverService. r=shaver@mozilla.org, sr=jband@netscape.com
2007-09-12 17:49:22 +00:00
3e43809d80
Best fix for 87864, prevent duplicate bookmarks from being processed when loading a bookmarks file.
...
This code was originally removed from 6.1 because performance issues with IndexOf, which have recently been addressed. r=pchen, sr=waterson
2007-09-12 17:49:21 +00:00
8db27a119d
Fix bug # 49142: speed up bookmarks menu creation on Mac. r=pink, sr=sfraser.
2007-09-12 17:49:20 +00:00
b726997b8f
nsIObserver and nsIObserverService API freeze. r=rpotts@netscape.com, alecf@netscape.com. bug 99163
2007-09-12 17:49:19 +00:00
d206004cd3
Bug 81444: eliminate |null_nsCOMPtr|. Eliminating all callers, r=syd, rs=mozbot.
2007-09-12 17:49:18 +00:00
660fc70aa8
fix some dumb dependencies for bug 102290
...
r=jag, sr=darinf
2007-09-12 17:49:17 +00:00
ccb4043540
Bug 100476: Convert uses of member functions ToNewUnicode, ToNewCString and ToNewUTF8String to their global versions and remove support from nsCString and nsString. r=dbaron, rs=scc
2007-09-12 17:49:16 +00:00
e240b68b71
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2007-09-12 17:49:15 +00:00
df6b1072e0
- fix js error when pasting into a bookmarks folder due to missing method.
...
(implement method exposing BookmarkParser::CreateAnonymousResource)
r=hixie, sr=blake, a=asa
part of 79904
2007-09-12 17:49:14 +00:00
e4d915de85
forgot this. oops
2007-09-12 17:49:13 +00:00
0a74f81b97
Bug 86734: Remove NS_WITH_SERVICE. r=dbaron, rs=scc, a=asa
2007-09-12 17:49:12 +00:00
84160a4c33
Bug 88413: Remove |GetUnicode()| from nsString (and replace it with |get()|). r=dbaron, rs=scc.
...
This removes all call-sites I can currently fix. Tomorrow I'll try to get someone to checkin my changes to security/ and I'll get some help with the Netscape side of things.
nsString::GetUnicode()'s final death-blow will be dealt soon. Please keep this in mind as you add new code :-)
2007-09-12 17:49:11 +00:00
99e8678028
bug #85271 : sr=waterson, r={beard, jag, dbaron}, a=asa. Eliminate features of |nsXPIDLC?String| that keep it out of the string hierarchy (i.e., using assigment to rebind ownership, static |Copy| members, and |getter_Shares|), fixing some leaks in the process.
2007-09-12 17:49:10 +00:00
d9d3404f1f
Fix for 78020 - Chromeless window when opening updated bookmarked page
...
Make bookmarks-service open a Navigator window with uri as argument using
WindowWatcher interface.
r=pchen, sr=blake, a=chofmann
2007-09-12 17:49:09 +00:00
84df9c7322
bewildered BeOS 5.0 Depend on 06/03 10:47
...
Build Error Summary
c++ -o nsBookmarksService.o -c -DOSTYPE=\"BeOS5.0\" -DOSARCH=\"BeOS\" -DMOZ_REFLOW_PERF -DMOZ_REFLOW_PERF_DSP -DOJI -I../../../../dist/include -I../../../../dist/include -I/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/obj-i686-pc-beos/dist/include/nspr -fPIC -frtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wno-multichar -Wno-ctor-dtor-privacy -pedantic -Wno-long-long -pipe -DDEBUG -DDEBUG_cltbld -DTRACING -g -DMOZILLA_CLIENT -include ../../../../config-defs.h -Wp,-MD,.deps/nsBookmarksService.pp /boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp: In method `nsresult nsBookmarksService::ReadBookmarks()':
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:4112: no matching function for call to `BookmarkParser::SetIEFavoritesRoot (nsCString)'
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:403: candidates are: BookmarkParser::SetIEFavoritesRoot(nsCString &) <near match>
make[5]: *** [nsBookmarksService.o] Error 1
picky compiler. i'm amazed that any of the code in there works. this is a bustage fix that will only affect XP_BEOS.
2007-09-12 17:49:08 +00:00
af82a93573
- fix js error when pasting into a bookmarks folder due to missing method.
...
(implement method exposing BookmarkParser::CreateAnonymousResource)
- allow user to remove Imported IE favorites folder by setting a pref
so that it is not automatically imported on startup.
r=hixie, sr=blake, a=asa
part of 79904, 22642
2007-09-12 17:49:07 +00:00
55babd3f6e
78882 - Dragging a bookmark into the personal toolbar causes all items to be deleted, r=ben, sr=alecf
2007-09-12 17:49:06 +00:00
8b860109dd
Make it possible to set the location of the bookmarks file. Bug 31623. r=timeless, sr=waterson. Pref for this is browser.bookmarks.file - you need to edit your pref.js manually. I seem to remember you need to double your backslashes on Windows...
2007-09-12 17:49:05 +00:00
ca0cf43a77
fix for 74969. r=blake, waterson
2007-09-12 17:49:04 +00:00
b877deb0b9
Http branch landing: changes to other files (bug 76866) r=gagan,sr=dougt,a=chofmann
2007-09-12 17:49:03 +00:00
c596aedf93
mozilla diffs r=tao, sr=alecf, commercial diffs r=syd, sr=syd/shaver. lower-casing JS calls to createBundle. removing un-used nsILocale param from nsIStringBundle::CreateBundle(). 76332
2007-09-12 17:49:02 +00:00
589fe6065e
Backing out fix from bug 31623. a=blizzard
2007-09-12 17:49:01 +00:00
6acf69f382
fix Bugzilla Bug 31623 Location of Bookmarks file cannot be changed
...
fix by gervase.markham@univ.ox.ac.uk
r=timeless, sr=waterson, a=asa
2007-09-12 17:49:00 +00:00
421acf24f0
#70334
...
r=alecf, sr=waterson
Personal toolbar doesn't migrate on DBCS systems - use NS_ConvertUTF8toUCS2
2007-09-12 17:48:59 +00:00
a2c22df54d
Patch to finalize necko loadFlags and fix HTTP validation correctness w.r.t.
...
cache validation preferences and browsing via history. r=gagan,gordon.
Fixes several bugs that I would mention here if bugzilla weren't down ;-)
2007-09-12 17:48:58 +00:00
4c4a3a4b16
Don't UTF-8 encode bookmark URLs twice.
...
b = 54866
r = sgehani (checking in for waterson)
sr = alecf
2007-09-12 17:48:57 +00:00
4c9d765322
replacing use of evil hidden window with embedding-copacetic window watcher. bug 71895 r=blizzard,hyatt,javi,various
2007-09-12 17:48:56 +00:00
ae13163878
Necko API changes, bug 74221. r=valeski, sr=rpotts.
2007-09-12 17:48:55 +00:00
e02e5c8740
removing use of nsNetSupportDialog. bug 72112 continued. r=hyatt,morse,mstoltz,various
2007-09-12 17:48:54 +00:00
59bf4faf02
Bug 65212 - profile support for kiosk mode. Also, removing profile change observer strings from header to cut dependencies. r=valeski@netscape.com, sr=alecf@netscape.com
2007-09-12 17:48:53 +00:00
f13562e57c
#70817 r/sr = bienvenu, alecf. Pass the strm as reference instead of a copy.
2007-09-12 17:48:52 +00:00
6fd34280e3
Preparation of removing nsCString::GetBuffer. Landing everything but the actual commenting out of nsCString::GetBuffer. bug=64016, r=timeless, sr=scc
2007-09-12 17:48:51 +00:00
8d03577318
Relanding Necko Changes.
...
Revising nsIChannel to allow for overlapped i/o. This consists of three parts:
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
r=darin@netscape.com
sr=rpotts@netscape.com
2007-09-12 17:48:50 +00:00
220bc127d4
Bug 69009. Don't look for duplicates when reading in bookmarks. r=ben, sr=alecf.
2007-09-12 17:48:49 +00:00
f1121fcfd2
fix build bustage in bug 67680, adding PRInt32
2007-09-12 17:48:48 +00:00
f926812eac
Bug 67680, remove CreateFolder method from nsIBookmarksService. r=jag, a=alecf.
2007-09-12 17:48:47 +00:00
8ac69ecf95
Back out dougt's channel changes
2007-09-12 17:48:46 +00:00
9f838983d5
Revising nsIChannel to allow for overlapped i/o. This consists of three parts:
...
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
The full details of the change on written up in the netlib newsgroup.
r=darin@netscape.com
sr=rpotts@netscape.com
2007-09-12 17:48:45 +00:00
72f75c0eb1
Bookmarks Window Updates, includes fixes for
...
27495, 38004, 42080, 43146, 43753, 47494, 50835, 53403, 55447, 55448, 55787
r=blake, a=hyatt
2007-09-12 17:48:44 +00:00
954ad46209
Make sure to use netPositive variables instead of IE ones.
...
Thanks to Takashi Toyoshima <toyohim@be-in.org> for the patch.
Bug #65131 r=cls
2007-09-12 17:48:43 +00:00
0f91b78a53
Part of bug 35559 - dynamic profile switching
r=valeski@netscape.com, sr=waterson@netscape.com
2007-09-12 17:48:42 +00:00
79e59e2681
cleanup, fix TRUE/FALSE refs: bug 63834 r=bryner sr=brendan@mozilla.org
2007-09-12 17:48:41 +00:00
00f513b7f0
Convert correct usage of |nsCOMPtr<T>::operator&| to use |address_of| since the operator& will soon become private. b=59414 r=disttsc@bart.nl sr=waterson@netscape.com
2007-09-12 17:48:40 +00:00
c5faa16c14
oops, fix it a little more
2007-09-12 17:48:39 +00:00
9eff51515d
fix BeOS bustage (this code not in the mac/win/unix builds)
2007-09-12 17:48:38 +00:00
3c840e7753
fix the orange by changing the timers to member variables of the service singletons, rather
...
than static nsCOMPtrs!
r=sspitzer
a=fixing bustage
2007-09-12 17:48:37 +00:00
f96bcd48c4
backing edburns out to open up the tree.
...
sorry ed. a=granrose
2007-09-12 17:48:36 +00:00
5e11b748bb
bug=59530
...
sr=waterson
r=valeski
This fix removes the two instances of the unsafe practice of having
static nsCOMPtr instances, either as static data members or or file
static variables. This practice prevents the proper ref-counting of
such instances, and leads to accessing the instances after their
ref-count has gone to 0.
The following files are in this fix:
widget/timer/src/windows/nsTimer.cpp
xpfe/components/bookmarks/src/nsBookmarksService.cpp
xpfe/components/bookmarks/src/nsBookmarksService.h
widget/timer/src/windows/nsWindowsTimer.h
2007-09-12 17:48:35 +00:00
f856d8f363
Stupid stupid MSVC. Fix Win build bustage. r/a=me
2007-09-12 17:48:34 +00:00
fe769433da
Fix bug # 58421: bookmarks parsing. r=dbaron sr=waterson
2007-09-12 17:48:33 +00:00
4795ffffb6
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2007-09-12 17:48:32 +00:00
745ca1eb64
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2007-09-12 17:48:31 +00:00
d2a622afaa
Fix bug # 57017: choosing PT folder loops if already marked as PT folder. r=ben sr=waterson
2007-09-12 17:48:30 +00:00
123d4afb9a
Bug 57764. Call UnregisterDataSource() in dtor. r=rjc, sr=alecf
2007-09-12 17:48:29 +00:00
9c7b1679f6
Fix bug # 55166: bookmark description loss. r=waterson sr=pavlov
2007-09-12 17:48:28 +00:00
91b5996e7a
Bug 37275, Changing value of all progids, and changing everywhere a progid
...
is mentioned to mention a contractid, including in identifiers.
r=warren
2007-09-12 17:48:27 +00:00
5f4cba00fa
Removed bogus printfs, and fixed the fragment name of the merged components DLL. r=bryner
2007-09-12 17:48:26 +00:00
33563d4177
46775. consolodating xpfe components into a root module to reduce system overhead bloat. built on win, linux, mac. precheckin tests on windows. general testing on mac and linux.
2007-09-12 17:48:25 +00:00
28644d0a28
Fix bug # 50057: initial bookmarks menu problem with IE Favorites on Mac. r=me
2007-09-12 17:48:24 +00:00
858b61aa93
Adding newline to end of file to fix nebiros (SunOS/sparc 5.7) bustage from valeski's checkin.
2007-09-12 17:48:23 +00:00
d031c864c0
Fix bug # 51021. r=me
2007-09-12 17:48:22 +00:00
3110ec9f7a
Fix for bug 46861. nsIDOMWindow is now split into two interfaces: a public interface (still called nsIDOMWindow) for embedders and an internal interface (nsIDOMWindowInternal) for internal use. The union of the two interfaces is still visible from JavaScript. r=jst@netscape.com
2007-09-12 17:48:21 +00:00
0f2d9c137d
fixing mac bustage
2007-09-12 17:48:20 +00:00
375c104dcd
fixing bustage
2007-09-12 17:48:19 +00:00
19f8adc96b
46775. preparing for linkage changes. these changes move class definitions into their own .h files so they can be used in other directories (not exported) for building purposes. I also utilized module/factory macros when possible
2007-09-12 17:48:18 +00:00
2ee0baedb3
Fix bug # 49495: bookmark parser optimizations. r=waterson
2007-09-12 17:48:17 +00:00
3d9196ec85
Bug 46777. Redesigned stream interfaces to allows stream observers to be decoupled from pipe implementation. Needed for embedding to fix 'spin' problem. r=rpotts,valeski,ruslan
2007-09-12 17:48:16 +00:00
498f62920c
Fix bug # 35022: slow bookmark operations. r=waterson
2007-09-12 17:48:15 +00:00
23302e2ae7
Converted use of nsIFileLocator to nsIDirectoryService
r=valeski
2007-09-12 17:48:14 +00:00
88b5905d8e
Bug 46053. Add [begin|end]UpdateBatch() to nsIRDFObserver; case-normalize the resot of the nsIRDFObserver methods; update implemetors, users. r=bienvenu,rjc,dmose,slamm
2007-09-12 17:48:13 +00:00
5772fb63d8
Fix bug # 39161: when adding a new bookmark, set its default type if it doesn't have one. r=me
2007-09-12 17:48:12 +00:00
f4c9dd166e
Added nsIRDFDataSource::HasArcIn/HasArcOut. Changed nsXULTemplateBuilder.cpp to use it (ifdef'd for now). Speed up folder loading by about 24%. r=waterson,alecf
2007-09-12 17:48:11 +00:00
72ddc1fe67
Register bookmarks datasource with RDF service *last*, because an other failure will leave the RDF service with a dangling pointer. Also, add assertion if we're unable to create a timer, because this is an *extremely* common platform porting error. r=rjc
2007-09-12 17:48:10 +00:00
8b842ea12e
the 'url has changed' alert in OnStopRequest now asks the channel for an nsIPrompt before defaulting to nsNetSupportDialog. bugs 25684,44171. r=rjc@netscape.com
2007-09-12 17:48:09 +00:00
7eb8f6b3d6
Fix leak of a string. r=waterson
2007-09-12 17:48:08 +00:00
047e3a9790
Ensure gRefCnt is initialized to zero. Code from ericb@neoplanet.com, approval=me
2007-09-12 17:48:07 +00:00
60cf7a8123
Moved declaration of 'nsresult rv' for platforms w/o REPEATING_TIMERS (BeOS). Again.
2007-09-12 17:48:06 +00:00
d49efa45ec
18022, bookmark doc charset caching
...
r=rjc, ftang, a=ftang
2007-09-12 17:48:05 +00:00
ca7211505c
Make --without-dbgrinfo-modules work properly.
...
Fixes for platforms without REPEATING_TIMERS (BeOS). r=pavlov a=leaf
2007-09-12 17:48:04 +00:00
3d467e5df3
changes all usages of NS_NewTimer to CreateInstance
2007-09-12 17:48:03 +00:00
8fc8fe8115
Changes to unify nsINetPrompt with nsIPrompt, making single sign-on work. Single sign-on API changes. Fixes bugs 34583, 34720, 34725, 24746, 33094. r=sspitzer,morse
2007-09-12 17:48:02 +00:00
403fccfd8e
string backsliding. r=mjudge
2007-09-12 17:48:01 +00:00
f7f389bc3a
Enable option to play sound on bookmark schedule status change.
2007-09-12 17:48:00 +00:00
3c83c98fc4
Fix nsCAutoString usage.
2007-09-12 17:47:59 +00:00
40a5d610ec
Fix bug # 36795: fix uninitialized return variable.
2007-09-12 17:47:58 +00:00
86f25c949d
Fix memory leak (of an atom) which ruslan introduced.
2007-09-12 17:47:57 +00:00
7979f5657f
AddBookmark() now takes an additional type parameter.
2007-09-12 17:47:56 +00:00
9b7041e31b
Fix 37800
2007-09-12 17:47:55 +00:00
5bb2a8b81c
making string conversions explicit. scc
2007-09-12 17:47:54 +00:00
2cde54dabb
dist...chrome restructuring
2007-09-12 17:47:53 +00:00
50d1bce7f5
making string conversions explicit
2007-09-12 17:47:52 +00:00
21d74065a3
Add support for importing/exporting bookmarks.
2007-09-12 17:47:51 +00:00
cd3e51d3bb
Internally, force all "shortcuts" to be lowercase (due to RDF APIs being case-significant). When looking for a shortcut match, first lowercase it, then look through graph... this allows for a case-insignificant match.
2007-09-12 17:47:50 +00:00
bdbaa00427
When using bookmark timers, set channel load attributes to always validate.
2007-09-12 17:47:49 +00:00
0933626f79
Small bookmark timer fix (I believe this was broken a while ago when repeating timers were implemented.)
2007-09-12 17:47:48 +00:00
13f903ac3a
Small tweak for GetFolderViaHint()
2007-09-12 17:47:47 +00:00
af6a4c2d0e
Add support for "Set as New Internet Search Folder" context menu command... which means, you can set a bookmark folder to use when bookmarking search queries.
2007-09-12 17:47:46 +00:00
0e967f84a1
Necko API changes: primarily nsIChannel, changing initialization parameters to accessors. Got javascript: evaluation to happen at the right time (when AsyncRead is called) as well as on the right thread.
2007-09-12 17:47:45 +00:00
a9996bba51
Fix bug # 33678: require a valid URL when adding a new URL. Also, ensure that IsBookmarked() works for all URIs (not just bookmarks, but folders too) so that when looking for a folder by type, we can use IsBookmarked() to verify that the folder actually exists in the bookmarks hierarchy chain.
2007-09-12 17:47:44 +00:00
d016525010
Fix bug # 33664: UMR in bookmarks.
2007-09-12 17:47:43 +00:00
6612b12d4a
Use .get() when comparing native ptr and nsCOMPtr.
2007-09-12 17:47:42 +00:00
6ea8e135a3
Add support for "Set New Bookmark Folder" and "Set Personal Toolbar Folder" context menu commands.
2007-09-12 17:47:41 +00:00
19409978c9
Add RDF command separator support.
2007-09-12 17:47:40 +00:00
444c3ca7b3
When using various bookmark commands, now prompt for arguments. Prevent invalid arguments (for example, disallow deletion of the "Personal Toolbar Folder").
2007-09-12 17:47:39 +00:00
9c15ddc213
Stronger implementation of isBookmarked() method.
2007-09-12 17:47:38 +00:00
152cd824cc
Add "IsBookmarked" method.
2007-09-12 17:47:37 +00:00
e164d34632
Slight change for RDF command format on bookmarks.
2007-09-12 17:47:36 +00:00
250810cc23
Fix bug # 22521: context menus should work on background of bookmarks window and background of bookmarks sidebar panel.
2007-09-12 17:47:35 +00:00
20852f3eba
On Mac, mark IE Favorites folders with a unique type so that they can be distinguished for regular bookmark folders.
2007-09-12 17:47:34 +00:00
916c80eb71
Part of fix for bug # 29212: prevent recursion when writing out bookmarks.
2007-09-12 17:47:33 +00:00
4ef50a7018
Fix bug # 31624 (add Mac IE favorites foreign charset alias resolution support) and bug # 29135 (default to adding new bookmark items under the root node if there is no selection). Review: me
2007-09-12 17:47:32 +00:00
84448ef044
removed calls to deprecated string methods
2007-09-12 17:47:31 +00:00
e1f42321ae
remove NS_DECLARE_ID and replace (where needed) with NS_DEFINE_CID.
...
DECLARE was declaring kPlatformCharsetCID as extern const, and
DEFINE declares it as static const. These 2 are incompatible.
r= ftang@netscape.com
a= dp@netscape.com
2007-09-12 17:47:30 +00:00
6e4bd55eef
Changed nsIAppShellService and nsIWindowMediator to talk in terms of nsIXULWindow instead of nsIWebShellWindow. Also removed the function nsIAppShellService::RunModalDialog since windows should be created using the nsIDOMWindow::OpenDialog. r=danm a=jevering
2007-09-12 17:47:29 +00:00
dea9f106a1
Fix bug # 27818: small escape changes.
2007-09-12 17:47:28 +00:00
955b534566
Fix bug # 27039: small escape changes. Helps JavaScript URLs which are bookmarked.
2007-09-12 17:47:27 +00:00
8e97496018
Removed unused include.
2007-09-12 17:47:26 +00:00
097ec7ec1a
Back out rjc's checkin which broke bookmarks. (whenever you quit we lost your bookmarks)
...
a=sleestack
2007-09-12 17:47:25 +00:00
5bc7f28bd8
Part of fix for bug # 24416: use temp file when writing out bookmarks to try and reduce loss of data due to any crashes.
2007-09-12 17:47:24 +00:00
df73d2b962
removed errant |QueryInterface()|s in favor of appropriate macros, as part of bug#23737. Changed |NS_DEFINE_IID| to |NS_DEFINE_CID| where appropriate; or else removed it, and fixed up clients to use |NS_GET_IID| in the appropriate spots. Built and ran pre-checkin tests. r=pinkerton
2007-09-12 17:47:23 +00:00
3d9daa9cd4
- Converting to Generic Module
...
- Removing unneccessary defines of IID and CID
r=rjc
2007-09-12 17:47:22 +00:00
1789af085f
Bug 24499, 15586. Hold strong ref to nsIRDFXMLSinkObservers; add onError() method to nsIRDFXMLSinkObserver API; be sure to notify observers in synchronous load case. r=shaver
2007-09-12 17:47:21 +00:00
7a5d9b1f03
Landing nsIFile.
2007-09-12 17:47:20 +00:00
0e8e2dbc1e
Fix bustage
2007-09-12 17:47:19 +00:00
0a16b7e685
Repeating, prioritised timer implementation for Windows and Gtk (bug 22979). author={Win32=michael.lowe@bigfoot.com, Gtk=alex@cendio.se}, r={kmcclusk,rods,sfraser,et al} a=brendan
2007-09-12 17:47:18 +00:00
caf7c2c48a
Fixed assertion/malfunction when timers are set on bookmarks because the bookmark service's QI didn't return nsIStreamListener. r=rjc
2007-09-12 17:47:17 +00:00
8e0c1d6954
Fix bug # 23689: flush bookmarks after adding new nodes.
2007-09-12 17:47:16 +00:00
e050c205f5
Even if pref string is an empty string, if it wasn't null, need to free it.
2007-09-12 17:47:15 +00:00
ebc768ce63
Check preference string to make sure its not an empty string before using.
2007-09-12 17:47:14 +00:00
39110352d0
Converting usage of ::GetIID() to NS_GET_IID().
...
Bug #20232 , r=scc@netscape.com
2007-09-12 17:47:13 +00:00
b9c07b0535
When trying to determine the name of the Personal Toolbar Folder, first check user preferences, then the bookmark service's string bundle, and finally fallback to a hard-coded string.
2007-09-12 17:47:12 +00:00
3842c593f9
Add support for the "custtoolbar.personal_toolbar_folder" preference which, if set, indicates what the name of the Personal Toolbar folder is.
2007-09-12 17:47:11 +00:00
b0d689e53e
Hack fix for bug # 21175: bookmarks without schemes now get "http://" as their default scheme.
2007-09-12 17:47:10 +00:00
4b4218993a
Build bustage patch for SUNWspro so the compiler doesn't choke
...
seeing an "extern" and "static" definition of kPlatformCharsetCID.
Removes duplicate definition of PlatformCharsetCID and uses the
one from nsIPlatformCharset.h. r=sspitzer
2007-09-12 17:47:09 +00:00
d5dcf771da
Fix bug # 20817: use default platform charset when reading in bookmarks until if/when we find a META charset tag that says to use something else. Review: ftang@netscape.com
2007-09-12 17:47:08 +00:00
57c9b8f25d
Part of fix for bug # 21677: read in bookmarks AFTER trying to get bookmarks string bundle. Approval: chofmann
2007-09-12 17:47:07 +00:00
92ddfeb16a
Fix bug # 21677: Use a string bundle so that hard-coded strings in nsBookmarksService.cpp can be removed. Approval: chofmann
2007-09-12 17:47:06 +00:00
59e85b4564
Landing no_neckoutil2_branch. Bug #11159 . Removes neckoutil_s.lib from build which helps beos and openvms.
2007-09-12 17:47:05 +00:00
3a0333437a
nsBookmarksService must accept RDF nextVal assertions, otherwise the RDF container utilities can't successfully add/remove items from RDF sequences.
2007-09-12 17:47:04 +00:00
c706ff5c59
Back off on nsCOMPtr use for mInner because of funky release
...
sequence. Fixes crash on shutdown.
2007-09-12 17:47:03 +00:00
740687e422
Bug 9246. Give bookmark URLs the tough love they need. Fix changing a bookmark's URL, fix setting a bookmark's URL when one wasn't set before. Prohibit removal of a bookmark's URL. r=rjc.
2007-09-12 17:47:02 +00:00
9372ea031a
Fix bug # 12114 [an internal timer no longer refcnt's the nsBookmarksService, preventing a leak; instead, we cancel the timer in the DTOR] and bug # 18250 [speed up loading of bookmarks on startup by deferring loading of IE favorites.html (on Mac) until needed, and try to read in the entire file in one read request if memory is available, otherwise fall back to parsing line by line]. Review: waterson@netscape.com
2007-09-12 17:47:01 +00:00
ddcc844234
updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org
2007-09-12 17:47:00 +00:00
0fa5aa3bf2
Changed NS_ENSURE_NOT to NS_ENSURE_FALSE to reflect API change. r=hyatt
2007-09-12 17:46:59 +00:00
ff4917d44a
Fix bug # 15435: prevent long ( > 255) URL corruption. Also convert over to a nsIModule. Review: dp@netscape.com
2007-09-12 17:46:58 +00:00
ef39b5e9cd
a bunch of changes, all reviewed by mscott.
...
fix some bugs with next, back, and cancel in the profile manager.
(#15223 , #15271 )
re-write all callers of nsProfile::GetCurrentProfileDir() to use the file locator.
(#15063 )
more profile code clean up. (#15042 )
rename the old 4.x history.dat file. it's called history.dat in 5.0, but the file
formats are different. (binary in 4.x, vs mork in 5.0)
2007-09-12 17:46:57 +00:00
rjc%netscape.com
dougt%netscape.com
timeless%mac.com
alecf%netscape.com
henry.jia%sun.com
kyle.yuan%sun.com
cbiesinger%web.de
bryner%netscape.com
ben%netscape.com
darin%netscape.com
jaggernaut%netscape.com
seawood%netscape.com
hyatt%netscape.com
cathleen%netscape.com
dbaron%fas.harvard.edu
bzbarsky%mit.edu
ccarlen%netscape.com
pchen%netscape.com
gerv%gerv.net
scc%mozilla.org
hewitt%netscape.com
valeski%netscape.com
tor%cs.brown.edu
mkaply%us.ibm.com
sgehani%netscape.com
danm%netscape.com
naving%netscape.com
disttsc%bart.nl
waterson%netscape.com
cls%seawood.org
jgmyers%netscape.com
sspitzer%netscape.com
edburns%acm.org
warren%netscape.com
rayw%netscape.com
sfraser%netscape.com
vidur%netscape.com
jbetak%netscape.com
pavlov%netscape.com
scc%netscape.com
ruslan%netscape.com
mjudge%netscape.com
rickg%netscape.com
jdunn%netscape.com
tbogard%aol.net
mscott%netscape.com
dp%netscape.com
michael.lowe%bigfoot.com
pp%ludusdesign.com
dmose%mozilla.org