076a068d11
bug 108539, r=jag, sr=sfraser, need to call NS_IF_RELEASE(mInner) to prevent leak of datasource, also cleaned up create instance call
2007-09-12 17:49:26 +00:00
80373b741f
bug 14824, r=rjc, sr=blake, don't read bookmarks.html in nsBookmarksService::Init(), load bookmarks once in ReadBookmarks()
2007-09-12 17:49:25 +00:00
0c2f935d3c
bug 68329, r=jag, sr=sfraser, resurrected an old patch from sfraser which
...
cleans up a lot of the string stuff, had help from jag to clean string
stuff even more
2007-09-12 17:49:24 +00:00
8e7c7994c9
Bug 53057: Fixing up users of implicit |CharT*| conversion operators for nsCString to use |.get()| instead, rr=dbaron, rs=scc
2007-09-12 17:49:23 +00:00
98c4135221
99163 - removing nsObserverService.h includes. Also fixing 106090, extra methods on nsObserverService. r=shaver@mozilla.org, sr=jband@netscape.com
2007-09-12 17:49:22 +00:00
3e43809d80
Best fix for 87864, prevent duplicate bookmarks from being processed when loading a bookmarks file.
...
This code was originally removed from 6.1 because performance issues with IndexOf, which have recently been addressed. r=pchen, sr=waterson
2007-09-12 17:49:21 +00:00
8db27a119d
Fix bug # 49142: speed up bookmarks menu creation on Mac. r=pink, sr=sfraser.
2007-09-12 17:49:20 +00:00
b726997b8f
nsIObserver and nsIObserverService API freeze. r=rpotts@netscape.com, alecf@netscape.com. bug 99163
2007-09-12 17:49:19 +00:00
d206004cd3
Bug 81444: eliminate |null_nsCOMPtr|. Eliminating all callers, r=syd, rs=mozbot.
2007-09-12 17:49:18 +00:00
660fc70aa8
fix some dumb dependencies for bug 102290
...
r=jag, sr=darinf
2007-09-12 17:49:17 +00:00
ccb4043540
Bug 100476: Convert uses of member functions ToNewUnicode, ToNewCString and ToNewUTF8String to their global versions and remove support from nsCString and nsString. r=dbaron, rs=scc
2007-09-12 17:49:16 +00:00
e240b68b71
Relicensing Round 1, Take 2. Most C-like NPL files -> NPL/GPL/LGPL. Bug 98089.
2007-09-12 17:49:15 +00:00
df6b1072e0
- fix js error when pasting into a bookmarks folder due to missing method.
...
(implement method exposing BookmarkParser::CreateAnonymousResource)
r=hixie, sr=blake, a=asa
part of 79904
2007-09-12 17:49:14 +00:00
e4d915de85
forgot this. oops
2007-09-12 17:49:13 +00:00
0a74f81b97
Bug 86734: Remove NS_WITH_SERVICE. r=dbaron, rs=scc, a=asa
2007-09-12 17:49:12 +00:00
84160a4c33
Bug 88413: Remove |GetUnicode()| from nsString (and replace it with |get()|). r=dbaron, rs=scc.
...
This removes all call-sites I can currently fix. Tomorrow I'll try to get someone to checkin my changes to security/ and I'll get some help with the Netscape side of things.
nsString::GetUnicode()'s final death-blow will be dealt soon. Please keep this in mind as you add new code :-)
2007-09-12 17:49:11 +00:00
99e8678028
bug #85271 : sr=waterson, r={beard, jag, dbaron}, a=asa. Eliminate features of |nsXPIDLC?String| that keep it out of the string hierarchy (i.e., using assigment to rebind ownership, static |Copy| members, and |getter_Shares|), fixing some leaks in the process.
2007-09-12 17:49:10 +00:00
d9d3404f1f
Fix for 78020 - Chromeless window when opening updated bookmarked page
...
Make bookmarks-service open a Navigator window with uri as argument using
WindowWatcher interface.
r=pchen, sr=blake, a=chofmann
2007-09-12 17:49:09 +00:00
84df9c7322
bewildered BeOS 5.0 Depend on 06/03 10:47
...
Build Error Summary
c++ -o nsBookmarksService.o -c -DOSTYPE=\"BeOS5.0\" -DOSARCH=\"BeOS\" -DMOZ_REFLOW_PERF -DMOZ_REFLOW_PERF_DSP -DOJI -I../../../../dist/include -I../../../../dist/include -I/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/obj-i686-pc-beos/dist/include/nspr -fPIC -frtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth -Wno-multichar -Wno-ctor-dtor-privacy -pedantic -Wno-long-long -pipe -DDEBUG -DDEBUG_cltbld -DTRACING -g -DMOZILLA_CLIENT -include ../../../../config-defs.h -Wp,-MD,.deps/nsBookmarksService.pp /boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp: In method `nsresult nsBookmarksService::ReadBookmarks()':
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:4112: no matching function for call to `BookmarkParser::SetIEFavoritesRoot (nsCString)'
/boot/home/tinderbox/BeOS_5.0_Depend/mozilla/xpfe/components/bookmarks/src/nsBookmarksService.cpp:403: candidates are: BookmarkParser::SetIEFavoritesRoot(nsCString &) <near match>
make[5]: *** [nsBookmarksService.o] Error 1
picky compiler. i'm amazed that any of the code in there works. this is a bustage fix that will only affect XP_BEOS.
2007-09-12 17:49:08 +00:00
af82a93573
- fix js error when pasting into a bookmarks folder due to missing method.
...
(implement method exposing BookmarkParser::CreateAnonymousResource)
- allow user to remove Imported IE favorites folder by setting a pref
so that it is not automatically imported on startup.
r=hixie, sr=blake, a=asa
part of 79904, 22642
2007-09-12 17:49:07 +00:00
55babd3f6e
78882 - Dragging a bookmark into the personal toolbar causes all items to be deleted, r=ben, sr=alecf
2007-09-12 17:49:06 +00:00
8b860109dd
Make it possible to set the location of the bookmarks file. Bug 31623. r=timeless, sr=waterson. Pref for this is browser.bookmarks.file - you need to edit your pref.js manually. I seem to remember you need to double your backslashes on Windows...
2007-09-12 17:49:05 +00:00
ca0cf43a77
fix for 74969. r=blake, waterson
2007-09-12 17:49:04 +00:00
b877deb0b9
Http branch landing: changes to other files (bug 76866) r=gagan,sr=dougt,a=chofmann
2007-09-12 17:49:03 +00:00
c596aedf93
mozilla diffs r=tao, sr=alecf, commercial diffs r=syd, sr=syd/shaver. lower-casing JS calls to createBundle. removing un-used nsILocale param from nsIStringBundle::CreateBundle(). 76332
2007-09-12 17:49:02 +00:00
589fe6065e
Backing out fix from bug 31623. a=blizzard
2007-09-12 17:49:01 +00:00
6acf69f382
fix Bugzilla Bug 31623 Location of Bookmarks file cannot be changed
...
fix by gervase.markham@univ.ox.ac.uk
r=timeless, sr=waterson, a=asa
2007-09-12 17:49:00 +00:00
421acf24f0
#70334
...
r=alecf, sr=waterson
Personal toolbar doesn't migrate on DBCS systems - use NS_ConvertUTF8toUCS2
2007-09-12 17:48:59 +00:00
a2c22df54d
Patch to finalize necko loadFlags and fix HTTP validation correctness w.r.t.
...
cache validation preferences and browsing via history. r=gagan,gordon.
Fixes several bugs that I would mention here if bugzilla weren't down ;-)
2007-09-12 17:48:58 +00:00
4c4a3a4b16
Don't UTF-8 encode bookmark URLs twice.
...
b = 54866
r = sgehani (checking in for waterson)
sr = alecf
2007-09-12 17:48:57 +00:00
4c9d765322
replacing use of evil hidden window with embedding-copacetic window watcher. bug 71895 r=blizzard,hyatt,javi,various
2007-09-12 17:48:56 +00:00
ae13163878
Necko API changes, bug 74221. r=valeski, sr=rpotts.
2007-09-12 17:48:55 +00:00
e02e5c8740
removing use of nsNetSupportDialog. bug 72112 continued. r=hyatt,morse,mstoltz,various
2007-09-12 17:48:54 +00:00
59bf4faf02
Bug 65212 - profile support for kiosk mode. Also, removing profile change observer strings from header to cut dependencies. r=valeski@netscape.com, sr=alecf@netscape.com
2007-09-12 17:48:53 +00:00
f13562e57c
#70817 r/sr = bienvenu, alecf. Pass the strm as reference instead of a copy.
2007-09-12 17:48:52 +00:00
6fd34280e3
Preparation of removing nsCString::GetBuffer. Landing everything but the actual commenting out of nsCString::GetBuffer. bug=64016, r=timeless, sr=scc
2007-09-12 17:48:51 +00:00
8d03577318
Relanding Necko Changes.
...
Revising nsIChannel to allow for overlapped i/o. This consists of three parts:
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
r=darin@netscape.com
sr=rpotts@netscape.com
2007-09-12 17:48:50 +00:00
220bc127d4
Bug 69009. Don't look for duplicates when reading in bookmarks. r=ben, sr=alecf.
2007-09-12 17:48:49 +00:00
f1121fcfd2
fix build bustage in bug 67680, adding PRInt32
2007-09-12 17:48:48 +00:00
f926812eac
Bug 67680, remove CreateFolder method from nsIBookmarksService. r=jag, a=alecf.
2007-09-12 17:48:47 +00:00
8ac69ecf95
Back out dougt's channel changes
2007-09-12 17:48:46 +00:00
9f838983d5
Revising nsIChannel to allow for overlapped i/o. This consists of three parts:
...
1. Factoring nsIChannel into a protocol specific part, the nsIChannel, and a socket specific, the nsITransport.
2. Derive the nsIChannel from a nsIRequest.
2. Changes the notification system from necko and the URILoader to pass the nsIRequest interface instead of nsIChannel interface.
This goal stems from wanting to be able to have active AsyncRead and AsyncWrite operations on nsSocketTransport.
This is desired because it would greatly simplify the task of maintaining persistent/reusable socket connections
for FTP, HTTP, and Imap (and potentially other protocols). The problem with the existing nsIChannel interface is
that it does not allow one to selectively suspend just one of the read or write operations while keeping the other active.
The full details of the change on written up in the netlib newsgroup.
r=darin@netscape.com
sr=rpotts@netscape.com
2007-09-12 17:48:45 +00:00
72f75c0eb1
Bookmarks Window Updates, includes fixes for
...
27495, 38004, 42080, 43146, 43753, 47494, 50835, 53403, 55447, 55448, 55787
r=blake, a=hyatt
2007-09-12 17:48:44 +00:00
954ad46209
Make sure to use netPositive variables instead of IE ones.
...
Thanks to Takashi Toyoshima <toyohim@be-in.org> for the patch.
Bug #65131 r=cls
2007-09-12 17:48:43 +00:00
0f91b78a53
Part of bug 35559 - dynamic profile switching
r=valeski@netscape.com, sr=waterson@netscape.com
2007-09-12 17:48:42 +00:00
79e59e2681
cleanup, fix TRUE/FALSE refs: bug 63834 r=bryner sr=brendan@mozilla.org
2007-09-12 17:48:41 +00:00
00f513b7f0
Convert correct usage of |nsCOMPtr<T>::operator&| to use |address_of| since the operator& will soon become private. b=59414 r=disttsc@bart.nl sr=waterson@netscape.com
2007-09-12 17:48:40 +00:00
c5faa16c14
oops, fix it a little more
2007-09-12 17:48:39 +00:00
9eff51515d
fix BeOS bustage (this code not in the mac/win/unix builds)
2007-09-12 17:48:38 +00:00
3c840e7753
fix the orange by changing the timers to member variables of the service singletons, rather
...
than static nsCOMPtrs!
r=sspitzer
a=fixing bustage
2007-09-12 17:48:37 +00:00
f96bcd48c4
backing edburns out to open up the tree.
...
sorry ed. a=granrose
2007-09-12 17:48:36 +00:00
5e11b748bb
bug=59530
...
sr=waterson
r=valeski
This fix removes the two instances of the unsafe practice of having
static nsCOMPtr instances, either as static data members or or file
static variables. This practice prevents the proper ref-counting of
such instances, and leads to accessing the instances after their
ref-count has gone to 0.
The following files are in this fix:
widget/timer/src/windows/nsTimer.cpp
xpfe/components/bookmarks/src/nsBookmarksService.cpp
xpfe/components/bookmarks/src/nsBookmarksService.h
widget/timer/src/windows/nsWindowsTimer.h
2007-09-12 17:48:35 +00:00
f856d8f363
Stupid stupid MSVC. Fix Win build bustage. r/a=me
2007-09-12 17:48:34 +00:00
fe769433da
Fix bug # 58421: bookmarks parsing. r=dbaron sr=waterson
2007-09-12 17:48:33 +00:00
4795ffffb6
Bug 47207. Backing out logging/PRINTF changes until we can fix stopwatch.h, introduce double parens, etc.
2007-09-12 17:48:32 +00:00
745ca1eb64
Bug 47207. Changing printf to PRINTF to use new logging facility. r=valeski,sr=waterson
2007-09-12 17:48:31 +00:00
d2a622afaa
Fix bug # 57017: choosing PT folder loops if already marked as PT folder. r=ben sr=waterson
2007-09-12 17:48:30 +00:00
123d4afb9a
Bug 57764. Call UnregisterDataSource() in dtor. r=rjc, sr=alecf
2007-09-12 17:48:29 +00:00
9c7b1679f6
Fix bug # 55166: bookmark description loss. r=waterson sr=pavlov
2007-09-12 17:48:28 +00:00
91b5996e7a
Bug 37275, Changing value of all progids, and changing everywhere a progid
...
is mentioned to mention a contractid, including in identifiers.
r=warren
2007-09-12 17:48:27 +00:00
5f4cba00fa
Removed bogus printfs, and fixed the fragment name of the merged components DLL. r=bryner
2007-09-12 17:48:26 +00:00
33563d4177
46775. consolodating xpfe components into a root module to reduce system overhead bloat. built on win, linux, mac. precheckin tests on windows. general testing on mac and linux.
2007-09-12 17:48:25 +00:00
28644d0a28
Fix bug # 50057: initial bookmarks menu problem with IE Favorites on Mac. r=me
2007-09-12 17:48:24 +00:00
858b61aa93
Adding newline to end of file to fix nebiros (SunOS/sparc 5.7) bustage from valeski's checkin.
2007-09-12 17:48:23 +00:00
d031c864c0
Fix bug # 51021. r=me
2007-09-12 17:48:22 +00:00
3110ec9f7a
Fix for bug 46861. nsIDOMWindow is now split into two interfaces: a public interface (still called nsIDOMWindow) for embedders and an internal interface (nsIDOMWindowInternal) for internal use. The union of the two interfaces is still visible from JavaScript. r=jst@netscape.com
2007-09-12 17:48:21 +00:00
0f2d9c137d
fixing mac bustage
2007-09-12 17:48:20 +00:00
375c104dcd
fixing bustage
2007-09-12 17:48:19 +00:00
19f8adc96b
46775. preparing for linkage changes. these changes move class definitions into their own .h files so they can be used in other directories (not exported) for building purposes. I also utilized module/factory macros when possible
2007-09-12 17:48:18 +00:00
2ee0baedb3
Fix bug # 49495: bookmark parser optimizations. r=waterson
2007-09-12 17:48:17 +00:00
3d9196ec85
Bug 46777. Redesigned stream interfaces to allows stream observers to be decoupled from pipe implementation. Needed for embedding to fix 'spin' problem. r=rpotts,valeski,ruslan
2007-09-12 17:48:16 +00:00
498f62920c
Fix bug # 35022: slow bookmark operations. r=waterson
2007-09-12 17:48:15 +00:00
23302e2ae7
Converted use of nsIFileLocator to nsIDirectoryService
r=valeski
2007-09-12 17:48:14 +00:00
88b5905d8e
Bug 46053. Add [begin|end]UpdateBatch() to nsIRDFObserver; case-normalize the resot of the nsIRDFObserver methods; update implemetors, users. r=bienvenu,rjc,dmose,slamm
2007-09-12 17:48:13 +00:00
5772fb63d8
Fix bug # 39161: when adding a new bookmark, set its default type if it doesn't have one. r=me
2007-09-12 17:48:12 +00:00
f4c9dd166e
Added nsIRDFDataSource::HasArcIn/HasArcOut. Changed nsXULTemplateBuilder.cpp to use it (ifdef'd for now). Speed up folder loading by about 24%. r=waterson,alecf
2007-09-12 17:48:11 +00:00
72ddc1fe67
Register bookmarks datasource with RDF service *last*, because an other failure will leave the RDF service with a dangling pointer. Also, add assertion if we're unable to create a timer, because this is an *extremely* common platform porting error. r=rjc
2007-09-12 17:48:10 +00:00
8b842ea12e
the 'url has changed' alert in OnStopRequest now asks the channel for an nsIPrompt before defaulting to nsNetSupportDialog. bugs 25684,44171. r=rjc@netscape.com
2007-09-12 17:48:09 +00:00
7eb8f6b3d6
Fix leak of a string. r=waterson
2007-09-12 17:48:08 +00:00
047e3a9790
Ensure gRefCnt is initialized to zero. Code from ericb@neoplanet.com, approval=me
2007-09-12 17:48:07 +00:00
60cf7a8123
Moved declaration of 'nsresult rv' for platforms w/o REPEATING_TIMERS (BeOS). Again.
2007-09-12 17:48:06 +00:00
d49efa45ec
18022, bookmark doc charset caching
...
r=rjc, ftang, a=ftang
2007-09-12 17:48:05 +00:00
ca7211505c
Make --without-dbgrinfo-modules work properly.
...
Fixes for platforms without REPEATING_TIMERS (BeOS). r=pavlov a=leaf
2007-09-12 17:48:04 +00:00
3d467e5df3
changes all usages of NS_NewTimer to CreateInstance
2007-09-12 17:48:03 +00:00
8fc8fe8115
Changes to unify nsINetPrompt with nsIPrompt, making single sign-on work. Single sign-on API changes. Fixes bugs 34583, 34720, 34725, 24746, 33094. r=sspitzer,morse
2007-09-12 17:48:02 +00:00
403fccfd8e
string backsliding. r=mjudge
2007-09-12 17:48:01 +00:00
f7f389bc3a
Enable option to play sound on bookmark schedule status change.
2007-09-12 17:48:00 +00:00
3c83c98fc4
Fix nsCAutoString usage.
2007-09-12 17:47:59 +00:00
40a5d610ec
Fix bug # 36795: fix uninitialized return variable.
2007-09-12 17:47:58 +00:00
86f25c949d
Fix memory leak (of an atom) which ruslan introduced.
2007-09-12 17:47:57 +00:00
7979f5657f
AddBookmark() now takes an additional type parameter.
2007-09-12 17:47:56 +00:00
9b7041e31b
Fix 37800
2007-09-12 17:47:55 +00:00
5bb2a8b81c
making string conversions explicit. scc
2007-09-12 17:47:54 +00:00
2cde54dabb
dist...chrome restructuring
2007-09-12 17:47:53 +00:00
50d1bce7f5
making string conversions explicit
2007-09-12 17:47:52 +00:00
21d74065a3
Add support for importing/exporting bookmarks.
2007-09-12 17:47:51 +00:00
cd3e51d3bb
Internally, force all "shortcuts" to be lowercase (due to RDF APIs being case-significant). When looking for a shortcut match, first lowercase it, then look through graph... this allows for a case-insignificant match.
2007-09-12 17:47:50 +00:00
bdbaa00427
When using bookmark timers, set channel load attributes to always validate.
2007-09-12 17:47:49 +00:00
0933626f79
Small bookmark timer fix (I believe this was broken a while ago when repeating timers were implemented.)
2007-09-12 17:47:48 +00:00
13f903ac3a
Small tweak for GetFolderViaHint()
2007-09-12 17:47:47 +00:00
af6a4c2d0e
Add support for "Set as New Internet Search Folder" context menu command... which means, you can set a bookmark folder to use when bookmarking search queries.
2007-09-12 17:47:46 +00:00
0e967f84a1
Necko API changes: primarily nsIChannel, changing initialization parameters to accessors. Got javascript: evaluation to happen at the right time (when AsyncRead is called) as well as on the right thread.
2007-09-12 17:47:45 +00:00
a9996bba51
Fix bug # 33678: require a valid URL when adding a new URL. Also, ensure that IsBookmarked() works for all URIs (not just bookmarks, but folders too) so that when looking for a folder by type, we can use IsBookmarked() to verify that the folder actually exists in the bookmarks hierarchy chain.
2007-09-12 17:47:44 +00:00
d016525010
Fix bug # 33664: UMR in bookmarks.
2007-09-12 17:47:43 +00:00
6612b12d4a
Use .get() when comparing native ptr and nsCOMPtr.
2007-09-12 17:47:42 +00:00
6ea8e135a3
Add support for "Set New Bookmark Folder" and "Set Personal Toolbar Folder" context menu commands.
2007-09-12 17:47:41 +00:00
19409978c9
Add RDF command separator support.
2007-09-12 17:47:40 +00:00
444c3ca7b3
When using various bookmark commands, now prompt for arguments. Prevent invalid arguments (for example, disallow deletion of the "Personal Toolbar Folder").
2007-09-12 17:47:39 +00:00
9c15ddc213
Stronger implementation of isBookmarked() method.
2007-09-12 17:47:38 +00:00
152cd824cc
Add "IsBookmarked" method.
2007-09-12 17:47:37 +00:00
e164d34632
Slight change for RDF command format on bookmarks.
2007-09-12 17:47:36 +00:00
250810cc23
Fix bug # 22521: context menus should work on background of bookmarks window and background of bookmarks sidebar panel.
2007-09-12 17:47:35 +00:00
20852f3eba
On Mac, mark IE Favorites folders with a unique type so that they can be distinguished for regular bookmark folders.
2007-09-12 17:47:34 +00:00
916c80eb71
Part of fix for bug # 29212: prevent recursion when writing out bookmarks.
2007-09-12 17:47:33 +00:00
4ef50a7018
Fix bug # 31624 (add Mac IE favorites foreign charset alias resolution support) and bug # 29135 (default to adding new bookmark items under the root node if there is no selection). Review: me
2007-09-12 17:47:32 +00:00
84448ef044
removed calls to deprecated string methods
2007-09-12 17:47:31 +00:00
e1f42321ae
remove NS_DECLARE_ID and replace (where needed) with NS_DEFINE_CID.
...
DECLARE was declaring kPlatformCharsetCID as extern const, and
DEFINE declares it as static const. These 2 are incompatible.
r= ftang@netscape.com
a= dp@netscape.com
2007-09-12 17:47:30 +00:00
6e4bd55eef
Changed nsIAppShellService and nsIWindowMediator to talk in terms of nsIXULWindow instead of nsIWebShellWindow. Also removed the function nsIAppShellService::RunModalDialog since windows should be created using the nsIDOMWindow::OpenDialog. r=danm a=jevering
2007-09-12 17:47:29 +00:00
dea9f106a1
Fix bug # 27818: small escape changes.
2007-09-12 17:47:28 +00:00
955b534566
Fix bug # 27039: small escape changes. Helps JavaScript URLs which are bookmarked.
2007-09-12 17:47:27 +00:00
8e97496018
Removed unused include.
2007-09-12 17:47:26 +00:00
097ec7ec1a
Back out rjc's checkin which broke bookmarks. (whenever you quit we lost your bookmarks)
...
a=sleestack
2007-09-12 17:47:25 +00:00
5bc7f28bd8
Part of fix for bug # 24416: use temp file when writing out bookmarks to try and reduce loss of data due to any crashes.
2007-09-12 17:47:24 +00:00
df73d2b962
removed errant |QueryInterface()|s in favor of appropriate macros, as part of bug#23737. Changed |NS_DEFINE_IID| to |NS_DEFINE_CID| where appropriate; or else removed it, and fixed up clients to use |NS_GET_IID| in the appropriate spots. Built and ran pre-checkin tests. r=pinkerton
2007-09-12 17:47:23 +00:00
3d9daa9cd4
- Converting to Generic Module
...
- Removing unneccessary defines of IID and CID
r=rjc
2007-09-12 17:47:22 +00:00
1789af085f
Bug 24499, 15586. Hold strong ref to nsIRDFXMLSinkObservers; add onError() method to nsIRDFXMLSinkObserver API; be sure to notify observers in synchronous load case. r=shaver
2007-09-12 17:47:21 +00:00
7a5d9b1f03
Landing nsIFile.
2007-09-12 17:47:20 +00:00
0e8e2dbc1e
Fix bustage
2007-09-12 17:47:19 +00:00
0a16b7e685
Repeating, prioritised timer implementation for Windows and Gtk (bug 22979). author={Win32=michael.lowe@bigfoot.com, Gtk=alex@cendio.se}, r={kmcclusk,rods,sfraser,et al} a=brendan
2007-09-12 17:47:18 +00:00
caf7c2c48a
Fixed assertion/malfunction when timers are set on bookmarks because the bookmark service's QI didn't return nsIStreamListener. r=rjc
2007-09-12 17:47:17 +00:00
8e0c1d6954
Fix bug # 23689: flush bookmarks after adding new nodes.
2007-09-12 17:47:16 +00:00
e050c205f5
Even if pref string is an empty string, if it wasn't null, need to free it.
2007-09-12 17:47:15 +00:00
ebc768ce63
Check preference string to make sure its not an empty string before using.
2007-09-12 17:47:14 +00:00
39110352d0
Converting usage of ::GetIID() to NS_GET_IID().
...
Bug #20232 , r=scc@netscape.com
2007-09-12 17:47:13 +00:00
b9c07b0535
When trying to determine the name of the Personal Toolbar Folder, first check user preferences, then the bookmark service's string bundle, and finally fallback to a hard-coded string.
2007-09-12 17:47:12 +00:00
3842c593f9
Add support for the "custtoolbar.personal_toolbar_folder" preference which, if set, indicates what the name of the Personal Toolbar folder is.
2007-09-12 17:47:11 +00:00
b0d689e53e
Hack fix for bug # 21175: bookmarks without schemes now get "http://" as their default scheme.
2007-09-12 17:47:10 +00:00
4b4218993a
Build bustage patch for SUNWspro so the compiler doesn't choke
...
seeing an "extern" and "static" definition of kPlatformCharsetCID.
Removes duplicate definition of PlatformCharsetCID and uses the
one from nsIPlatformCharset.h. r=sspitzer
2007-09-12 17:47:09 +00:00
d5dcf771da
Fix bug # 20817: use default platform charset when reading in bookmarks until if/when we find a META charset tag that says to use something else. Review: ftang@netscape.com
2007-09-12 17:47:08 +00:00
57c9b8f25d
Part of fix for bug # 21677: read in bookmarks AFTER trying to get bookmarks string bundle. Approval: chofmann
2007-09-12 17:47:07 +00:00
92ddfeb16a
Fix bug # 21677: Use a string bundle so that hard-coded strings in nsBookmarksService.cpp can be removed. Approval: chofmann
2007-09-12 17:47:06 +00:00
59e85b4564
Landing no_neckoutil2_branch. Bug #11159 . Removes neckoutil_s.lib from build which helps beos and openvms.
2007-09-12 17:47:05 +00:00
3a0333437a
nsBookmarksService must accept RDF nextVal assertions, otherwise the RDF container utilities can't successfully add/remove items from RDF sequences.
2007-09-12 17:47:04 +00:00
c706ff5c59
Back off on nsCOMPtr use for mInner because of funky release
...
sequence. Fixes crash on shutdown.
2007-09-12 17:47:03 +00:00
740687e422
Bug 9246. Give bookmark URLs the tough love they need. Fix changing a bookmark's URL, fix setting a bookmark's URL when one wasn't set before. Prohibit removal of a bookmark's URL. r=rjc.
2007-09-12 17:47:02 +00:00
9372ea031a
Fix bug # 12114 [an internal timer no longer refcnt's the nsBookmarksService, preventing a leak; instead, we cancel the timer in the DTOR] and bug # 18250 [speed up loading of bookmarks on startup by deferring loading of IE favorites.html (on Mac) until needed, and try to read in the entire file in one read request if memory is available, otherwise fall back to parsing line by line]. Review: waterson@netscape.com
2007-09-12 17:47:01 +00:00
ddcc844234
updated xPL license boilerplate to v1.1, a=chofmann@netscape.com,r=endico@mozilla.org
2007-09-12 17:47:00 +00:00
0fa5aa3bf2
Changed NS_ENSURE_NOT to NS_ENSURE_FALSE to reflect API change. r=hyatt
2007-09-12 17:46:59 +00:00
ff4917d44a
Fix bug # 15435: prevent long ( > 255) URL corruption. Also convert over to a nsIModule. Review: dp@netscape.com
2007-09-12 17:46:58 +00:00
ef39b5e9cd
a bunch of changes, all reviewed by mscott.
...
fix some bugs with next, back, and cancel in the profile manager.
(#15223 , #15271 )
re-write all callers of nsProfile::GetCurrentProfileDir() to use the file locator.
(#15063 )
more profile code clean up. (#15042 )
rename the old 4.x history.dat file. it's called history.dat in 5.0, but the file
formats are different. (binary in 4.x, vs mork in 5.0)
2007-09-12 17:46:57 +00:00
f8a928b36b
Fix bug # 15062. Review: waterson. Approval: chofmann.
2007-09-12 17:46:56 +00:00
f2df05414a
whoops, accidentally checked this in.
2007-09-12 17:46:55 +00:00
e78cc2d991
fix for #14999 . remove the profile appcore
2007-09-12 17:46:54 +00:00
5cce150c61
make ReadBookmarks() part of the nsIBookmarksService interface. I need this so I can call it from the profile code, so that after migration, the user has their 4.x bookmarks. one bug remains, is that when you call ReadBookmarks() more then once it should re-set the bookmarks, instead of adding to it.
2007-09-12 17:46:53 +00:00
36698a39c4
Use ToNewUTF8String(). [Missed a spot]
2007-09-12 17:46:52 +00:00
2839078f04
Fix signed/unsigned warning.
2007-09-12 17:46:51 +00:00
af37627d5b
Fix bug #5871 : now write out bookmark file in "UTF-8" encoding, along with:
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
To support this, when reading in the bookmark file, we look to see if a META charset is specified and, if it is, we'll try and get a decoder for it to use when processing the rest of the file.
2007-09-12 17:46:50 +00:00
736d9dd8ed
Disallow quotes in etag.
2007-09-12 17:46:49 +00:00
0921097ea0
Removed obsolete include.
2007-09-12 17:46:48 +00:00
983ab7a0af
Add folder check.
2007-09-12 17:46:47 +00:00
2311ff066d
Fix bug # 13197: escape bookmark title as well as descriptions.
2007-09-12 17:46:46 +00:00
395894bce4
Convert some NS_ASSERTIONS into warnings, so that I can start up without debugger breaks.
2007-09-12 17:46:45 +00:00
311795d439
open new browser window with nsIDOMWindow.Open
2007-09-12 17:46:44 +00:00
80d3e14894
Fix silly warning.
2007-09-12 17:46:43 +00:00
abbc7ee110
Don't forget const.
2007-09-12 17:46:42 +00:00
3972493c86
Landing support for "bookmark schedules".
2007-09-12 17:46:41 +00:00
42e855f5ce
Use nsCRT::free() instead of delete[].
2007-09-12 17:46:40 +00:00
01a10cbe70
Only write out attributes that actually have a value.
2007-09-12 17:46:39 +00:00
2de9ee04dd
Move uses xpfe/components interfaces to using NS_DECL_NSIFOO macro. Several interfaces in xpfe/components declared their own NS_DECL_IFOO macros; I moved those to generated NS_DECL_NSIFOO and will remove the definitions in a subsequent checkin to prevent any risk of mid-checkin skew.
2007-09-12 17:46:38 +00:00
786ce81397
For debug-only, find default bookmarks file in its new home.
2007-09-12 17:46:37 +00:00
c8dc0e1e42
Darn nsCOMPtr usage.
2007-09-12 17:46:36 +00:00
38d9102f1d
Add support for changing a bookmark's URL.
2007-09-12 17:46:35 +00:00
6413621013
ANSI C++ fix. Fixes HP-UX build with aCC. Use 'friend class nsFoo' rather than 'friend nsFoo'.
2007-09-12 17:46:34 +00:00
d09437f491
replaced calls to deprecated string API
2007-09-12 17:46:33 +00:00
35e5717bb4
Support importing of NetPositive bookmarks under the BeOS.
2007-09-12 17:46:32 +00:00
01a12722ef
Const this!
2007-09-12 17:46:31 +00:00
76318d43aa
Cleanup. Use GetValueConst() more, allow returning IE favorites URLs (on Mac), fix memory leak.
2007-09-12 17:46:30 +00:00
73f05129fb
Back out the code where, under Windows, try and munge imported IE Favorites names to not include a ".url". I'm going to put the code elsewhere.
2007-09-12 17:46:29 +00:00
a1662ed9a6
Under Windows, try and munge imported IE Favorites names to not include a ".url".
2007-09-12 17:46:28 +00:00
57dc263d57
When looking for a bookmark file, first try PROFILE_DIR/bookmarks.html and if that doesn't exist, then try PROFILE_DIR/bookmark.htm
Do this because of differences in names on various platforms in older browser versions, when importing bookmarks into this version leaves us with naming differences.
We don't want to force the import process to change the bookmark filename, as that might break third party applications which mess with the bookmark file and expect the old name.
2007-09-12 17:46:27 +00:00
11057357cd
Get rid of warning by using PRUint32s instead of comparing signed and unsigned values.
2007-09-12 17:46:26 +00:00
44d97397ea
Fix.
2007-09-12 17:46:25 +00:00
8a82aad577
More bookmark command support.
2007-09-12 17:46:24 +00:00
ebf005cc36
Start implementing some bookmark commands (for context menus, UI, etc.)
2007-09-12 17:46:23 +00:00
7e60abbe86
Small command API cleanup.
2007-09-12 17:46:22 +00:00
0cd37355e3
Add support for updating a bookmark's "Last Visited" date when its URL is loaded.
2007-09-12 17:46:21 +00:00
7814284a17
Change bookmarks service progid slightly.
2007-09-12 17:46:20 +00:00
55e5176bf0
Initial revision. Not yet in the build.
2007-09-12 17:46:19 +00:00
f7ee4fe460
As bookmark properties change, update the "Last Modified" attribute to the current date/time.
2007-09-12 17:41:28 +00:00
6e49ea2188
Use 64-bit LL_MUL instead of LL_MUL32
2007-09-12 17:41:27 +00:00
6ab4b80cb0
Temporary fix for build bustage.
2007-09-12 17:41:26 +00:00
797d4d307b
Add support for int and date Literals.
2007-09-12 17:41:25 +00:00
39e142f9b7
Bug 9431. Don't return failure if can't find bookmarks file.
2007-09-12 17:41:24 +00:00
a0a7b108ba
Bug 9401. Don't include debug backstop bookmarks in a release build. a=chofmann.
2007-09-12 17:41:23 +00:00
8a06330d6c
Duh. Write them to the correct place, as well.
2007-09-12 17:41:22 +00:00
129cbf35c5
Bug 7921. Look in profile directory _first_ before falling back to 'default' bookmarks file.
2007-09-12 17:41:21 +00:00
8ef30b773b
Fix bug #9232 .
2007-09-12 17:41:20 +00:00
7b311673f7
Fix a bunch of whitespace as an experiment in pleasing RJC's broken editor. More importantly, fix 7144, 5221, 7921.
2007-09-12 17:41:19 +00:00
c1407d417b
Don't lose CRs in bookmark descriptions.
2007-09-12 17:41:18 +00:00
c8e22258bb
Handle bookmark descriptions properly (including escaping text before writing out, and unescaping when reading back in.)
2007-09-12 17:41:17 +00:00
0daefe4db9
Implement some commands for bookmarks.
2007-09-12 17:41:16 +00:00
7242bb1f06
Return an empty command enumerator instead of throwing an assertion.
2007-09-12 17:41:15 +00:00
51b31129ea
Added new method GetAllCmds() which uses a nsISimpleEnumerator instead of GetAllCommands() which uses a nsIEnumerator. Migration to GetAllCmds() can be done in the future.
2007-09-12 17:41:14 +00:00
68a6ba7487
fix build bustage
2007-09-12 17:41:13 +00:00
04f84e7fc9
Expunge EqualsResource() and EqualsLiteral().
2007-09-12 17:41:12 +00:00
31b0c33b54
Land RDF_19990617_BRANCH. Add Change() and Move() methods to nsIRDFDataSource; add OnChange() and OnMove() methods to nsIRDFObserver. Factor nsIRDFDatasource::Init() and ::Flush() into nsIRDFRemoteDataSource. Change ownership model s.t. a datasource reference counts its observers. Miscellaneous XPCOM fixage.
2007-09-12 17:41:11 +00:00
cba4ddc275
Be sure to write out bookmarks.html to the same place we read it in from! Bookmarks were moved from mozilla/rdf/ to mozilla/xpfe/components/bookmarks and bookmarks.html is now stored inside of $DIST/res/samples instead of the old $DIST/res/rdf
2007-09-12 17:41:10 +00:00
16e83afff6
Fix importing of "IE favorites" on Windows which was broken by mcmullen when he checked in a supposed fix for something that wasn't broken.
2007-09-12 17:41:09 +00:00
f49b1c2b49
Fix crash parsing IE favorites.
2007-09-12 17:41:08 +00:00
bb426efbc0
Clean up compiler warning.
2007-09-12 17:41:07 +00:00
ab883f55f1
Debug to get running properly.
2007-09-12 17:41:06 +00:00
9531a870cf
Initial revision. Not yet in the build.
2007-09-12 17:41:05 +00:00
7978a6cd44
Bug 358599: Avoid content viewer eviction crash from tabbrowser, r+sr=Neil
2007-09-10 03:18:35 +00:00
1be25c0b7d
Bug 395206 Remove unused prefixhidden, tborient and tbalign attributes (tbpack was removed in bug 282188) r=mconnor sr=jag
2007-09-07 22:45:47 +00:00
7e76774d39
Bug 393842 Move xpfe/components/search to suite/common r=kairo,sr=neil
2007-09-07 14:25:04 +00:00
8b0614d7c4
Bug 374862 Port xpfe/components/search/src to frozen linkage. Original patch by Mook, one minor fixup by me,r=Neil,sr=biesi
2007-09-06 22:07:52 +00:00
45dd093e78
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-09-06 22:07:51 +00:00
94bcfbc2e7
Cycle-collect through the internet search datasource. Bug 383942, r+sr=neil
2007-09-06 22:07:50 +00:00
7583f68b23
Part of bug 374862 Port xpfe/components/search/src to frozen linkage (Remove AssignWithConversion usage) r=neil,sr=cbiesinger
2007-09-06 22:07:48 +00:00
77a3bb6275
Fix for bug 372713 (Add cycle collection to RDF datasources). r=bsmedberg, sr=dbaron.
2007-09-06 22:07:47 +00:00
6bef001410
Bug 374862 Port xpfe/components/search/src to frozen linkage (purely mechanical parts) p=Mook <mook.moz+mozbz@gmail.com>,r=Neil,sr=biesi
2007-09-06 22:07:46 +00:00
9c2362f3e4
fix for bug #356487
...
make MOZ_PLACES (if enabled) only build the places based history UI, use MOZ_PLACES_BOOKMARKS to turn off the places based bookmarks UI.
also addresses bugs:
bug #330923 : "View -> Sidebar menu" is empty if you build with places
bug #355738 : implement history sidebar on top of places backend
bug #356175 : hook up the history menu to the places backend
bug #356453 : add back "Clear Private Data" menu item
bug #356630 : add back "History | Show in Sidebar" menu item
bug #356631 : remove "search in history" and "view all history" menu items
bug #357301 : add back history and bookmark sidebar toolbar button items, remove places toolbar button
bug #358831 : history sidebar, right mouse button click should not expand / collapse item
r=dietrich, r=gavin
2007-09-06 22:07:45 +00:00
561bdf4f5b
fix for bug #341654 : search bookmarks broken if you disable places. r=vlad
2007-09-06 22:07:44 +00:00
8fa0791d0e
Seamonkey-only bustage from bug 347183 - I'm currently building a tree with this, but it should be right
2007-09-06 22:07:43 +00:00
78625f54c6
Bug 347160: SeaMonkey crashes, when submitting request in google.de. r=timeless
2007-09-06 22:07:42 +00:00
a17a032950
Bug 333313: oom mlk in InternetSearchDataSource::BeginSearchRequest, patch by Phil Ringnalda <philringnalda@gmail.com>, r=timeless, sr=jag
2007-09-06 22:07:41 +00:00
b86a1c012a
fixing build bustage that results when places is enabled. patch by sullivan@gmail.com, r=darin
2007-09-06 22:07:40 +00:00
aa8fc533f0
bug 183156 remove *UCS2* functions, replacing them with *UTF16* ones
...
r+sr=darin
2007-09-06 22:07:39 +00:00
bcb6a9add8
Bug 318889: broken multisearch; r=bsmedberg, sr=jag
2007-09-06 22:07:38 +00:00
70a09bec25
Fix leaks due to nsISupportsArray misuse. Bug 323377, patch by Martijn Wargers
...
<martijn.martijn@gmail.com>, r=pike, sr=bzbarsky
2007-09-06 22:07:37 +00:00
fc68c01ed8
Bug 243214 - Cleanup of nsInternetSearchService, r=pike sr=alecf
2007-09-06 22:07:36 +00:00
c9c908331d
Bug 106386 Correct misspellings in source code
...
patch by unknown@simplemachines.org r=timeless rs=brendan
2007-09-06 22:07:35 +00:00
5c3e7b0086
bug 311195 - When update URL is 404, engine update ignores updateCheckDays, patch by O. Atsushi (Torisugari) (torisugari@gmail.com), r=me, sr=neil, a=asa
2007-09-06 22:07:34 +00:00
29ebc83a60
Bug 302000 - browser.search.order.* doesn't work with searchplugins stored in profile. patch from O. Atsushi (Torisugari) <torisugari@gmail.com>, r=bsmedberg, sr=neil.
2007-09-06 22:07:33 +00:00
5ecc547097
bug 290254 - search engine isn't validated for the first time until updateCheckDays after first use, r=me, sr=neil
2007-09-06 22:07:32 +00:00
2132d92f46
289362 - replacing dictionary.com with answers.com as the dictionary handler for 1.5 following abusive practices towards firefox users on the part of dictionary.com (popups etc). Patch adds support to the internet search service for search URLs whose parameter formats are effectively redirects, not query strings, e.g. http://www.foo.com/%s vs. currently supported http://www.foo.com/search?foo=%s only... r=bsmedberg, a=cbeard
2007-09-06 22:07:31 +00:00
0f8deb6907
Bug 299825 Search plugins in App directory are updated into Profile directory (resulting in double Search Bar entries)
...
patch by torisugari@gmail.com r=timeless sr=neil
2007-09-06 22:07:30 +00:00
d14aafb418
bug 271097 - backend fix to enable turning off searchplugin auto-update, patch by O. Atsushi (torisugari@gmail.com), r=shaver/me, a=shaver
2007-09-06 22:07:29 +00:00
eaeff8d030
bug 123315 - user-added searchplugins should be installed into the profile, r=bsmedberg, sr=shaver, a=bsmedberg
2007-09-06 22:07:28 +00:00
447b0cf25a
Bug 296430 - Allow extensions to ship searchplugins, final patch to read searchplugins from a dirservice nsISimpleEnumerator key, r=mkaply a=asa
2007-09-06 22:07:27 +00:00
17fc855a98
Have separate states for new search plugin install and search plugin update and only remove old files for updates. b=290038 r=mconnor sr=brendan a=roc
2007-09-06 22:07:26 +00:00
08e22106d8
removing additional instances of deprecated nsServiceManager:: methods, bug 219400
2007-09-06 22:07:25 +00:00
983b668cc9
bug 290037 search action protocol should match method r=bengoodger,sr=dbaron,a=asa
2007-09-06 22:07:24 +00:00
59b5b27c05
Bug 288640 - xpfe/components/search is app-specific, not part of the toolkit. Remove bad dependencies by moving it to tier_99 and only building it for Seamonkey/Firefox r=Neil a=asa
2007-09-06 22:07:23 +00:00
d3976e5566
Bug 282057 - brand.dtd/properties live in the wrong chrome package... xulrunner apps cannot provide these files, which means they can't use various toolkit features r=darin moa=Neil (seamonkey)
2007-09-06 22:07:22 +00:00
07dc253341
Bug 173634 flawfinder warnings in xp_str.h: kill xp_str.h, xp_path.h and clean out old/dead defines/code
...
r=mkaply sr=alecf
Removing dead code guarded by: BUG_21013 MORK_USE_XP_STDLIB notdef OLDWAY UNREADY_CODE
Removing *Apple*Decode* files which aren't being built
2007-09-06 22:07:21 +00:00
ac2089e1d3
Make people that want empty strings use EmptyC?String(). Bug 232691, patch by
...
Daniel Kraft <d@daniel-kraft.net>, r=jst, sr=bzbarsky
2007-09-06 22:07:20 +00:00
8349b109f5
fixes bug 219400 "remove callers of nsServiceManager:: methods" r=bsmedberg
2007-09-06 22:07:19 +00:00
8815e286a6
eliminating uses of deprecated nsComponentManager:: methods (bug 267040), r=bsmedberg
2007-09-06 22:07:18 +00:00
f741f86f0a
263928, 263412 - define default distribution ID in configure.in, not in nsISS for better availability/reliability. r=vlad
2007-09-06 22:07:17 +00:00
pchen%netscape.com
jaggernaut%netscape.com
dougt%netscape.com
ben%netscape.com
rjc%netscape.com
alecf%netscape.com
gerv%gerv.net
scc%mozilla.org
timeless%mac.com
hewitt%netscape.com
darin%netscape.com
valeski%netscape.com
tor%cs.brown.edu
mkaply%us.ibm.com
sgehani%netscape.com
danm%netscape.com
ccarlen%netscape.com
naving%netscape.com
disttsc%bart.nl
waterson%netscape.com
cls%seawood.org
jgmyers%netscape.com
dbaron%fas.harvard.edu
sspitzer%netscape.com
edburns%acm.org
warren%netscape.com
rayw%netscape.com
sfraser%netscape.com
vidur%netscape.com
jbetak%netscape.com
pavlov%netscape.com
scc%netscape.com
ruslan%netscape.com
mjudge%netscape.com
rickg%netscape.com
jdunn%netscape.com
tbogard%aol.net
mscott%netscape.com
dp%netscape.com
michael.lowe%bigfoot.com
pp%ludusdesign.com
dmose%mozilla.org
bruce%cybersight.com
mccabe%netscape.com
slamm%netscape.com
ajschult%verizon.net
neil%parkwaycc.co.uk
bugzilla%standard8.plus.com
jwalden%mit.edu
bzbarsky%mit.edu
bugzilla%standard8.demon.co.uk
peterv%propagandism.org
sspitzer%mozilla.org
benjamin%smedbergs.us
gavin%gavinsharp.com
darin%meer.net
cbiesinger%web.de
mnyromyr%tprac.de
bsmedberg%covad.net
timeless%mozdev.org
mconnor%steelgryphon.com
mozilla.mano%sent.com
ben%bengoodger.com
dbaron%dbaron.org
dveditz%cruzio.com