76e998252a
Bug 583847 - Weave should be using createAsyncStatement instead of createStatement [r=mconnor]
2010-08-09 18:38:18 +02:00
5a745d9fdb
Bug 583852 - Weave should not be querying on places views [r=mconnor]
...
Query moz_places, moz_historyvisits *and* moz_places_temp, moz_historyvisits_temp instead of the slower views.
If the temp tables aren't available (bug 552023), just query the regular tables.
Fixed some style and syntax nits.
2010-08-09 18:38:18 +02:00
96c792a8d4
Bug 583852 - Weave should not be querying on places views [r=mconnor]
...
Tests for the history store.
2010-08-09 18:38:18 +02:00
ac08f9116f
Bug 585190 - Fix tracker tests on m-c [r=mconnor]
...
Ensure that the bookmark tracker test starts out with a clean slate.
Svc.History.removeAllPages(), as called by the history tracker test during clean up, needs the "UHist" alias registered, which isn't available by default in xpcshell.
2010-08-06 23:25:59 +02:00
6cefdc1625
Bug 487558 - Use satchel notifications to track form data [r=mconnor]
2010-08-06 17:31:36 +02:00
9f3ccbe46f
Bug 584241 - Disable trackers when client isn't configured [r=mconnor]
...
Tests and test fixes.
--HG--
rename : services/sync/tests/unit/test_engines_forms_store.js => services/sync/tests/unit/test_forms_store.js
2010-08-06 17:31:21 +02:00
57c4f23de7
Bug 584241 - Disable trackers when client isn't configured [r=mconnor]
2010-08-06 17:30:58 +02:00
905ac1573e
Bug 584722 - Make test_uploadOutgoing_failed (test_syncengine_sync.js) async [r=mconnor]
2010-08-06 16:55:06 +02:00
55360ab174
Bug 584478 - Resource alias registered too early [r=mconnor]
2010-08-05 18:31:58 +02:00
c163a5ae51
Bug 578835 - wipeServer doesn't deal well with failure [r=mconnor]
...
Have wipeServer() abort if it encounters a server error (anything other than 200 or 404) and throw an exception. Don't catch any exceptions wipeServer() throws, let them bubble up to the callers.
2010-08-05 18:24:45 +02:00
3960a68871
Bug 584486 - Changing password via web leads to unknown error [r=mconnor]
2010-08-05 16:52:17 +02:00
e97c6b419f
Bug 584402 - Audit references across XPCOM borders [r=mconnor]
...
Use weak references for observers.
2010-08-04 21:07:53 +02:00
bf06e6e72e
Bug 584402 - Audit references across XPCOM borders [r=mconnor]
...
Nuke refs to XPCOM services on shutdown.
2010-08-04 21:07:27 +02:00
213217a82e
Bug 584369 - history sync is busted on tip, r=philiKON
2010-08-04 11:07:50 -04:00
967ecb4058
[mq]: weakRefForms
2010-08-04 10:42:09 -04:00
e414ab20ea
Bug 545752 - DB Statements aren't finalized in HistoryStore [r=mconnor]
...
Also nullifies the cached service so we don't leak.
2010-08-04 14:59:34 +02:00
c719dfb93c
Bug 584040 - Fix leaky tests [r=mconnor]
...
Make sure we explicitly nullify the cached services in the BookmarksStore & BookmarksTracker.
Also, explicitly finalize the statement if it was created.
2010-08-04 14:50:44 +02:00
9c826435e5
Bug 584040 - Fix leaky tests [r=mconnor]
...
Avoid holding on to the original nsIFormHistory2 service object in FormNotifier.js and explicitly null the reference on shutdown.
2010-08-03 19:57:53 +02:00
d3c2e2f9f5
Bug 584170 - Make test_service_cluster.js less prone to timing problems [r=mconnor]
2010-08-03 22:20:40 +02:00
c745f15b21
Bug 583985 - Disable leaky sync tests
2010-08-03 00:45:28 -07:00
3f12eea216
Bug 583949 - Fix leaks in Firefox Sync unit tests (followup)
2010-08-03 00:43:42 -07:00
a21643b91e
Bug 583949 - Fix leaks in Firefox Sync unit tests
2010-08-02 22:37:13 -07:00
a9b1ddd250
Bug 583829 - Log4Moz.getLogger() should always be called with a name
2010-08-02 22:06:29 +02:00
db32010a7b
Bug 582083 - Should inspect POST responses for failed WBOs [r=Mardak]
...
Make sure records that failed to upload continue to be marked in the tracker so that they'll be uploaded again in the next sync.
2010-07-31 13:28:00 +02:00
0102c7f8db
Bug 580158 - Change Firefox Sync behavior in Private Browsing mode [r=mconnor]
...
Don't disable sync when in private browsing. When in explicit private browsing mode (either via menu item or -private command line flag), have tabs engine not provide data.
2010-07-19 23:07:45 -07:00
f35d794526
Bug 579510 - Make sure multi-byte passwords are stored and sent correctly [r=mconnor]
...
UTF8-encode passwords when creating accounts, changing passwords, and when authenticating. Detect old low-byte only passwords on the server and reupload them as UTF8.
2010-07-20 00:28:54 +02:00
b4834f3185
Add missing test_service_passphraseUTF8 from bug 558963
2010-07-02 14:44:00 +02:00
68aa673b35
Bug 579209 - Blue "i" for delayed node assignment disappears on sync [r=mconnor]
...
Explicitly set the NO_SYNC_NODE sync status to keep the "i".
2010-07-15 17:02:06 -07:00
b9854306a3
Bug 578825 - sync should only sort on mobile clients, r=Mardak
2010-07-14 18:18:24 -04:00
9dc70679d2
Bug 569744 - Delayed loading of service.js causes test failures [r=Mardak]
...
Explicitly set username pref so that when service.js starts up (which it does after 10s, thanks to Weave.js) it doesn't reset the WeaveID's username to ''.
2010-07-14 18:36:13 +02:00
c4e977df64
Bug 558963, part 2, UTF-8 encode passphrase and rewrap keys if needed, r=mconnor
2010-07-03 14:13:40 -04:00
138373b089
Bug 558963, part 1, add UTF-8 helpers and tests, r=mconnor
2010-07-03 14:11:58 -04:00
1727a9b2ee
Bug 576554 - Need manifests to register XPCOM components on trunk, r=mconnor
2010-07-03 13:26:57 -04:00
7ab5af457a
Bug 576084 - Firefox Sync failing to load on Android: error creating resource://services-sync substitution, r=mconnor
...
No need for the file URI dance, just use the resource:// directly.
2010-07-01 16:44:32 -07:00
9039f07964
Bug 575423 - Forced syncs fail to upload some history [r=mconnor]
...
Select from views to get disk and memory data now that async makes it not block.
2010-06-29 11:18:21 -07:00
ffecc37699
Bug 573740 - Register resource://services-sync before xpcshell tests get run [r=Mardak]
...
Don't try to create the alias too early, add-on chrome registration might not have happened yet, so do it during testing.
2010-06-23 16:28:10 +02:00
d66903d744
Bug 569744 - Delayed loading of service.js causes test failures [r=Mardak]
...
Have FakeCryptoService.generateRandomIV() return 24 bytes so that Weave.Service._checkCrypto() believes it's the real deal. Fix undeclared variable.
2010-06-23 12:36:48 +02:00
20d8fc6912
Bug 573740 - Register resource://services-sync before xpcshell tests get run [r=mconnor]
...
Add the alias to resource://services-sync when loading the component instead of waiting for app-startup, which doesn't fire for xpcshell tests.
2010-06-22 19:11:20 -07:00
736c131289
Bug 573870 - Be less strict about what the path/root of an exception stack file can be [r=mconnor]
...
Just match anything that doesn't look like another stack file entry.
2010-06-22 16:29:47 -07:00
db7fbb993d
Bug 573842 - Work around non-null terminated string issue for decrypted strings [r=mconnor]
...
Just wrap with empty strings until bug 573841 is fixed.
2010-06-22 19:09:29 -07:00
57cf89779b
Bug 573679 - Fix tests to pass on trunk
...
Get a profile for xpcshell tests so that login manager works (and probably other stuff). Fix up anno test from this change to use a real bookmark id.
2010-06-22 18:28:37 -07:00
4fe565e763
Bug 573679 - Fix tests to pass on trunk
...
Use Utils.delay instead of setTimeout.
2010-06-22 16:49:33 -07:00
40395cd760
Bug 573679 - Fix tests to pass on trunk
...
Switch around which lazy services we use to test with but cover even more data types.
2010-06-22 16:48:55 -07:00
1467b9dd9d
Bug 573679 - Fix tests to pass on trunk
...
Just take parts of a static string instead of randomly generating bytes and btoa-ing.
2010-06-22 16:47:44 -07:00
9dfb68cb2a
Bug 573679 - Fix tests to pass on trunk
...
Use do_load_httpd_js for xpcshell tests and have consumers directly call new nsHttpServer().
2010-06-22 13:18:10 -07:00
cccc303a13
Bug 573691 - Flatten/split components and prefs for services vs ui separation [r=mconnor]
...
Move about:weave-tabs component to ui/firefox and flatten structure of the components. Split prefs for services vs firefox.
2010-06-22 08:14:15 -07:00
7dd2541360
Bug 573668 - Register appinfo with correct OS for tests
...
Register a fake AppInfo with correct OS if it doesn't exist yet. Just use Svc.Crypto instead of trying to dynamically pick the contract id. Name the head files so they load in appinfo -> helper -> http order.
--HG--
rename : services/sync/tests/unit/bookmark_setup.js => services/sync/tests/unit/head_appinfo.js
rename : services/sync/tests/unit/head_first.js => services/sync/tests/unit/head_helpers.js
2010-06-22 00:20:31 -07:00
8239271894
Bug 573679 - Fix tests to pass on trunk
...
Create a bookmark so that the url will exist when setting annotations.
2010-06-21 23:56:56 -07:00
666b6ac9de
Bug 573194 - AboutWeaveTabs still references chrome://weave/content/firefox/tabs.xul [r=Mardak]
...
Split off about: chrome aliasing from other services aliases.
2010-06-21 16:46:57 -07:00
75bfb7059a
Bug 571902 - Land sync and crypto components on trunk [r=mconnor]
...
If resource://services-sync isn't defined yet, alias it to resource://gre/modules/services-sync.
2010-06-18 14:11:14 -07:00
64264d8ec0
Bug 573108 - Remove references to chrome://weave from services [r=mconnor]
...
Remove openWindow/Dialog helpers and inline into ui bits for prefs-common and pass arguments into generic-change.
2010-06-18 13:59:30 -07:00
a8135a264a
Bug 557589 - code audit and create unit test plan for service.js [r=mconnor]
...
Part 5: Tests for checkUsername, createAccount, changePassword
2010-06-17 16:47:13 +01:00
2caf470608
Bug 557589 - code audit and create unit test plan for service.js [r=mconnor]
...
Part 4: Get rid of superfluous attribute, introduce constants for password/passphrase realms, add/improve tests for login(), logout(), persistLogin().
2010-06-17 04:12:38 +01:00
1e214b9bf7
Bug 557589 - code audit and create unit test plan for service.js [r=mconnor]
...
Part 3: Tests for Weave.Service._{find|set|update}Cluster()
2010-06-09 11:07:54 -07:00
6a68634cbf
Bug 572436 - Get rid of app-specific hacks (switch (Svc.AppInfo.ID)) in sync library [r=mconnor]
...
Set relevant default preferences programmatically in app specific overlays, making app-specific code paths in the sync library unnecessary.
2010-06-16 23:11:40 +01:00
fc5e76f590
Bug 573015 - Get rid of 'attic' and 'need-work' tests [r=mconnor]
2010-06-18 09:39:03 -07:00
52ec13eb30
Bug 572970 - Hardcode some pre-processed values for .in files like prefs and constants [r=mconnor]
...
* Rename constants.js.in to constants.js.
* Get rid of unused DEFAULT_SERVER variable
* Hardcode STORAGE_VERSION. The three other variable substitutions are add-on specific.
2010-06-18 09:13:02 -07:00
f0e9206527
Bug 572970 - Hardcode some pre-processed values for .in files like prefs and constants [r=mconnor]
...
* Rename prefs.js.in to prefs.js
* Hardcode server_url
2010-06-18 09:13:02 -07:00
ce6de55601
Bug 570636 - Decide how to co-exist as a sync add-on and built-in sync [r=mconnor]
...
Migrate prefs from extensions.weave. to services.sync. when loading the service for the first time before migration.
2010-06-16 14:30:13 -07:00
0cbfa6f197
Bug 570636 - Decide how to co-exist as a sync add-on and built-in sync [r=mconnor]
...
Map the modules directory to services-sync instead of weave and update imports.
2010-06-16 14:30:08 -07:00
2256714107
Bug 568677 - Failure to get CryptoMeta assumes it's missing [r=mconnor]
...
Explicitly check the status code to make sure we stop syncing on non-404 crypto meta failures. Add tests to check correct behavior of 404 and non-404 errors during syncStartup.
2010-06-14 15:16:53 -07:00
9529fb34fa
Bug 562878 - Override for machine name [r=mconnor]
...
Allow setting of the computer name during Firefox account setup and from prefs. Also allow setting device name from Fennec prefs. Fix up strings for Fennec.
2010-06-11 11:36:51 -07:00
67eff5457d
Bug 570180 - Setup wizard sets passphrase='foo' [r=mconnor]
...
Promote _verifyLogin to a public method so we have a way to query login status even with a non-existent or invalid passphrase.
2010-06-14 21:03:39 +01:00
2a116ee59d
Bug 570573 - Clean up uses of switch (Svc.AppInfo.ID) for app-specific hacks (Part 2) [r=mconnor]
...
Weave.Service.onStartup now triggers autoconnect after a fixed delay specified in a preference. If that preference is absent, nothing happens and apps are responsible for triggering autoconnect in a weave:service:ready observer themselves. Provide such observers for Firefox and Fennec.
2010-06-10 17:04:49 -07:00
eb4e7c1045
Bug 570573 - Clean up uses of switch (Svc.AppInfo.ID) for app-specific hacks (Part 1) [r=mconnor]
...
Weave.Service._registerEngines now reads the list of engines from a preference so that apps can specify it this way. The switch logic stays as fallback for the addon case.
2010-06-09 17:22:03 -07:00
cdf449bd0f
Bug 546551 - Weave status bar notifications are too busy [r=mconnor]
...
Remove status bar icon/text for setup/connect/sync status. Add menuitem for setting up sync instead of drilling down a 1-item submenu that leads to a button. Remove unused Engine.displayName and related strings.
2010-06-14 10:30:37 -07:00
6af153cd30
Bug 566061 - After server syncing, lightweight themes do not get applied to Chrome [r=mconnor]
...
Make sure the pref exists (is a bool) before trying to access its value.
2010-06-10 10:57:49 -07:00
587c8c9d4c
Bug 569355 - source code reorg, redux [r=mconnor]
...
Split the code structure to service/{crypto,sync} and ui/{fennec,firefox}. Update the top level makefile to build the addon staging directory to merge various parts of directories.
2010-06-09 17:03:31 -07:00
1d9a29c0dd
Bustage fix for bug 570635 to check null for item.guid instead of item.
2010-06-09 16:10:38 -07:00
dfe20796ec
Bustage fix for bug 570635 to allow more time for the timeout to trigger.
2010-06-09 15:38:17 -07:00
4d4c161152
Bug 570635 - Use async queries for fetching form data [r=mconnor]
...
Create a Utils.queryAsync to wrap executeAsync that fetches all rows and columns by name. Update form and history engines to use it.
2010-06-09 09:35:01 -07:00
38dd746086
Bug 569740 - Tab Characters within Usernames Can Cause Connectivity Issues & Security Events [r=mconnor]
...
Strip tabs from username since tabs are stripped from URIs and the username is part of all URIs.
2010-06-08 19:05:05 -07:00
c8aa414112
Bug 557589 - code audit and create unit test plan for service.js [r=mconnor]
...
Part 2: Tests for module startup, Weave.Service attributes.
2010-06-04 17:05:55 +01:00
8d8af96450
Bug 557589 - code audit and create unit test plan for service.js [r=mconnor]
...
Part 1: Get rid of unused '_syncInProgress' attribute, unnecessary getters and setters.
2010-06-04 16:38:38 +01:00
2a67f37141
Bug 570152 - engine.js tests should completely reset preferences [r=mconnor]
...
Switch to resetBranch("") instead of resetting individual prefs.
2010-06-04 16:38:38 +01:00
a6fcc6bd87
Bug 570137 - test_engine fails on Minefield [r=mconnor]
...
Setting an attribute that has a getter no longer throws an exception in Minefield, it's just ignored.
2010-06-04 15:14:27 +01:00
79b588a085
Bug 569730 - Can't log in a 2nd computer [r=Mardak]
...
Fix a regression introduced with the status.js refactoring (bug 557590).
2010-06-04 14:44:04 +01:00
bffd21b356
Bug 568136 - Migration requires client to check for a node again after a 401 [r=mconnor]
...
Allow observers to watch for resource 401s and to specify a new uri to request. Test to make sure "weave:resource:status:401" gets notified and resource handles uri changes.
2010-06-03 18:37:07 -07:00
0d1ac1b621
Bug 569746 - Test with sync with smaller numbers to speed up testing
...
Reduce test run time (w/ coverage tool) from 25 minutes to 2 minutes while maintaining the same code coverage by processing hundreds instead of thousands of records.
2010-06-02 16:51:48 -07:00
2de3b0d76b
Bug 565411 - Accept max_results as a parameter to allow configuring the number of history items. [r=mconnor]
2010-06-02 15:18:01 -07:00
8ca541a1a3
Bug 565411 - Sync 5000 most frecent pages instead of 1000 recent for first sync [r=mconnor]
...
Use an async sql query to get uris by frecency instead of query result nodes, and wrap it with sync/async to keep the sync interface without blocking UI. Rough timings of getAllIDs: old 1k = 1.6sec blocking; old 5k = 2.7sec blocking; new 1k = .2sec non-block; new 5k = .6sec non-block.
2010-05-13 11:44:19 -07:00
0da67a3a0c
Bug 566575 - Some tests FAIL on first run and PASS or hang on subsequent runs [r=mconnor]
...
Update to httpd.js from mozilla-central. server.stop() now expects a callback parameter, so pass a no-op where it's used.
2010-06-01 15:25:23 -07:00
ada4345433
Bug 557596 - code audit and create unit test plan for resource.js [r=mconnor]
...
Lots of resource tests, Resource.serverTime initialized to null, Resource.headers normalized to lowercase.
2010-06-01 15:15:53 -07:00
46b96f4455
Bug 557590 - code audit and create unit test plan for status.js [r=mconnor]
...
Initialize status values in status.js + tests for status.js.
2010-06-01 15:12:25 -07:00
1a8a8ad8e5
Bug 557588 - code audit and create unit test plan for engines.js [r=mconnor]
...
Tests for SyncEngine.sync(), incl some additions to harness.
2010-06-01 15:07:50 -07:00
dafa05caeb
Bug 557588 - code audit and create unit test plan for engines.js [r=mconnor]
...
Tests for EngineMangerSvc, Engine and SyncEngine sans sync().
2010-06-01 15:06:16 -07:00
bf1483e06b
Bug 569428 - Add tests for FormEngine (Store)
2010-06-01 12:44:51 -07:00
42d5f65cf3
Bug 557591 - Add tests for Utils.sha1.
2010-06-01 11:59:21 -07:00
e9dcf1dbb5
Bug 557591 - Add tests for Utils.anno with invalid uris.
2010-06-01 11:30:11 -07:00
55e055bb98
Bug 568707 - "key is not defined" results in broken form history service [r=mconnor]
...
Pretend to call a function with "key" to keep it around.
2010-05-27 17:32:15 -07:00
6c55e65cf7
Bug 567650 - missed weave rebranding, r=Mardak
...
--HG--
extra : rebase_source : b9a8ec3eec5639c9b73fcb705bd52961d7816ba0
2010-05-27 14:11:16 -04:00
8fd0b69ca3
Bug 568518 - Unhelpful log messages [r=mconnor]
...
Remove "Server attack" from exceptions.
2010-05-27 11:04:30 -07:00
d658d7f0cb
Bug 568440 - sync errors when resetting sync at the same time as other syncs are occurring [r=mconnor]
...
Clear out cached crypto and keys if info collections says they've been modified.
2010-05-27 11:04:26 -07:00
69526a658b
Bug 568256 - form history changes breaks form sync, FF search bar, probably more [r=mconnor]
...
Check for both old and new class IDs and use the one that exists when wrapping. Also add FormTracker as the observer object so that its notify function is correctly called by nsHTMLFormElement.
--HG--
extra : rebase_source : 470430eaa643415e635836db3c38fb639a4e44b6
2010-05-26 11:56:04 -07:00
21899cdb80
Bug 567364 - final tweaks, r=Mardak
...
--HG--
extra : rebase_source : d103816fec7641a6f5a672a6b8557f2bbbb56566
2010-05-21 17:41:19 -04:00
975a3a25f8
Bug 567371 - replace server and replace local options does not sync certain Passwords/bookmarks [r=mconnor]
...
Make sure to clear local cache when deleting crypto records from the server. Handle missing crypto by deleting any existing data and reuploading. Fix broken records by uploading new ones.
2010-05-21 12:15:58 -07:00
668a13002f
Add tests for Utils.jsonSave and Utils.jsonLoad.
2010-05-20 18:03:19 -07:00
b88a69b137
Bug 557591 - Add tests for Utils.makeURI.
2010-05-19 09:40:45 -07:00
ed64fcea5f
Bug 557591 - Add tests for Utils.sha256HMAC.
2010-05-18 13:40:12 -07:00
15d82d14a7
Bug 557591 - Add tests for Utils.stackTrace.
2010-05-17 14:17:32 -07:00
Philipp von Weitershausen
Mike Connor
Paul O’Shannessy
Justin Dolske
Edward Lee