d5e036ecd2
Added a hook for installing new user fields so that setupInstall handlers don't have to go through the same process multiple times. Also corrected an obvious error (using a variable after checking that it couldn't be used...).
2001-09-19 18:43:06 +00:00
7c5a6e0734
Correcting the misspelling of the package names ('Components' not 'Component') to match the directory.
2001-09-19 18:29:39 +00:00
f650602a79
Corrected the order of return values (newPassword) and removed the extraneous argument (output).
2001-09-19 18:11:03 +00:00
25c3d3b7f3
Cached the SMTP object to improve performance.
2001-09-19 18:05:28 +00:00
00afd76821
Made the outputter be a simple service rather than a service instance to improve performance.
2001-09-19 18:01:23 +00:00
e18f084c7e
Corrected an oversight in the service instance creation code: if a service acts as both a service instance and a normal service, it needs a special constructor to force the creation of the instance, otherwise if the service is created first it will be used again for the instances.
2001-09-19 17:56:15 +00:00
aaebfe1839
Fix for bug 97971 - Sanity check should check statuses, resolutions, everconfirmed & number of votes.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-09-19 15:06:43 +00:00
a20ddcac97
Adding branch page
2001-09-18 23:24:28 +00:00
9945e649fa
patch from Pavel Hlavnicka pavel@gingerall.cz
...
fix ordering of user footer and menu
2001-09-17 18:58:14 +00:00
fba452acb3
Fix for bug 90333: Bugzilla now displays an appropriate error message if a user hits process_bug.cgi without specifying any bugs to change.
...
Patch by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-17 18:55:31 +00:00
592ee5528d
Fixed error messages to be more accurate.
2001-09-17 00:13:16 +00:00
a43434e27e
Fix to make the tests generate the list of files to test instead of having to update the list manually whenever a file is added
...
or removed. The main logic is in t/Support/Files.pm, changes to the test files are needed to allow it to function properly.
NOT_PART_OF_BUILD. No review needed for tests at this time.
2001-09-16 18:35:18 +00:00
6953c1e8f3
Make this file test for exec calls in addition to system calls that are
...
one-argument and are therefore insecure.
NOT_PART_OF_BUILD, no review needed.
2001-09-16 17:52:19 +00:00
13bed907d6
Fix for bug 97877: changed* operators now work for attachment statuses on query form.
...
Fix by Myk Melez <myk@mozilla.org>
r=jake@acutex.net
2001-09-15 07:26:21 +00:00
c524d1adcb
Fix for bug 30731 - Reassigning closed bugs from the mass change page caused their status to be set to new.
...
r= myk@mozilla.org , zach@zachlipton.com
2001-09-14 21:50:08 +00:00
d8400a256e
bugzilla wasn't catching mozilla on 98 which was annoying. r=jake
2001-09-13 20:41:59 +00:00
1b759fae9a
Fix for bug 58436 - javascript strict warnings in query.cgi
...
Patch by Christian Reis <kiko@async.com.br>
r= caillon@returnzero.com , jake@acutex.net
2001-09-13 20:04:40 +00:00
84e5eab357
Bugzilla Bug 99465 FreeBSD not recognized!
...
r=jake
2001-09-13 18:21:07 +00:00
383f5cba05
Make Bugzilla support <link> tag for buglists. Bug 87818. r=jake, caillon.
2001-09-10 21:26:05 +00:00
732604001c
Fix for bug 76140 - Adding some more sanity checks.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= caillon@returnzero.com , jake@acutex.net
2001-09-10 15:20:11 +00:00
831a0dc3ba
Fix for bug 97657 - in defparams.pl, the sillyness sub should be called defparams_pl_sillyness
...
Patch by David D. Kilzer <ddkilzer@theracingworld.com>
r= jake@acutex.net
2001-09-10 14:57:12 +00:00
f9d35d29b3
Fix for bug 71664 - Don't complain about a bad keyword cache for a bug that doesn't exist.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= afranke@ags.uni-sb.de , jake@acutex.net
2001-09-10 14:12:10 +00:00
598b67df77
Fix for bug 95060 - Correct the instructions on how to view your current votes.
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= jake@acutex.net x2
2001-09-10 14:00:48 +00:00
f1977072a4
Fix for bug 8647 - Add an option to the query page to sort by Last Changed date.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net x2
2001-09-10 13:49:26 +00:00
9035927484
First stab at an e-mail output service. Also added support for checking addresses for validity and used that when creating a new account.
2001-09-09 21:02:33 +00:00
eb7921111d
Oops. Forgot to check this is.
2001-09-09 19:48:15 +00:00
1bdb52ce4f
Reduced the ErrorContext from 2 to 1. 2 is too much.
2001-09-09 19:48:14 +00:00
b09d3910bb
corrected a comment, corrected the spelling of a method call, and added a placeholder in 'login.failed' which will eventually have to be replaced by code which finds the list of contact methods.
2001-09-09 19:47:04 +00:00
573aee3d11
Added ErrorContext to the Expat arguments so that well formedness errors are easier to track down.
2001-09-09 19:38:24 +00:00
c128f0735b
Corrected and improved some comments.
...
Corrected a problem with scope and the 'escape' attribute of <text> elements.
Renamed 'shrink' and 'expand' to the slightly more accurate 'flatten' and 'rounden'. (ahem)
Changed the ordering of symbol unescaping in roundening to be less (not?) susceptible to incorrect expansion.
Changed the ordering of symbol escaping in flattening to be consistent with the unescape order when roundening.
Made <text> trim one leading and one trailing newline in text nodes if xml:space="default" (makes COSES files neater).
Added a 'coses: original keys' hash to values whose keys are sanitised
Made the 'escape' values be lower case instead of upper case (makes COSES files neater).
2001-09-09 19:36:23 +00:00
93e947211d
Corrected the SQL for 'SHOW COLUMNS FROM' so that it actually works...
2001-09-09 19:21:17 +00:00
10ba6f53e5
Added a string data source which gets the strings from a file instead of from the database, useful as a fallback.
2001-09-09 19:19:05 +00:00
8a6d55c4de
Made the error message printed when no string expander can be found more explicit (it now mentions the name and type of the string).
2001-09-09 19:08:58 +00:00
2d98944b83
Added a comment clarification.
2001-09-09 19:06:13 +00:00
d571cc1375
Changed the magic piping array so that it is more consistent by removing the special casing of when there is only one return value.
2001-09-09 19:04:37 +00:00
e40dafc029
Added the message level number to the debug output to help gauge what level is useful.
2001-09-09 17:55:21 +00:00
2418906f94
Added header and stylistic note.
...
Clarified some of the text.
Made the use of quotes more consistent.
Wrote Chapter 5, "USING GET SERVICE".
Added an empty Chapter 10, "THE SERVICE REFERENCE".
2001-09-09 17:48:07 +00:00
e4012ce728
Fix for bug 98468: sample email regexp for username-only address changed from ^[^@]*$ to ^[^@]+$ and the default emailregexp changed from ^[^@]*@[^@]*\\.[^@]*$ to ^[^@]+@[^@]+\\.[^@]+$
...
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net x2
2001-09-07 03:25:33 +00:00
9ec346a74d
refix for bug 91808: previous patch for this bug used an INNER JOIN construct in the SQL, which is not supported by the
...
minimum version of MySQL that we require.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-07 01:32:13 +00:00
c8107279a3
better documentation both internal and external. Reevaluate the steps
...
to make a build each iteration to allow builds to create time stamped output.
catch some errrors using eval so that they will appear in the tinderbox mail and not as fatal errors. Strip a few more 'dangerous variables' from the environment.
2001-09-06 18:15:53 +00:00
2ed0e662aa
Fix for bug 30597 - Hyperlinking the number of votes was causing some confusion because it was such a small link, yet the most useful. Instead, we now have a link labeled "Show votes for this bug".
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com , jake@acutex.net
2001-09-06 12:42:47 +00:00
3a1384b065
Fix for bug 42337: Adding the usual red box for errors uploading attachments.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= louie@ximian.com , justdave@syndicomm.com
2001-09-06 03:20:34 +00:00
efcb9c7db1
Fix for bug 69616: If you have tweakparams privs, the "Sanity check" link was listed with a group of items that said "Edit" so
...
it appeared as if you were going to edit the sanity checks if you clicked on it, when in fact you were going to run them.
This patch rewords the links so Sanity check is in a group by itself in the block of links on the right.
Patch by Matthew Tuck <matty@chariot.net.au>
r= justdave x2
2001-09-06 02:19:04 +00:00
b91182e74e
Adding a test for safe system and exec calls. Part of this code by Dave.
2001-09-05 01:43:25 +00:00
cbc7b5ba25
Add a little 1; to the end of this.
2001-09-04 04:28:24 +00:00
5b949c45ef
Actually make the strict checking work.
2001-09-03 22:11:43 +00:00
ac55bba9b4
add tests for use strict;
2001-09-03 22:04:09 +00:00
eb7cb06e59
Enforce -w. This file will also be used to enforce use strict;
2001-09-03 21:43:22 +00:00
d65dd7c7ac
Rename 1.t to 1compile.t as per bug 97976.
2001-09-03 20:17:40 +00:00
a154cf3f21
Remove processmail from the list. It was causing problems with taint.
2001-09-03 19:39:37 +00:00
e96fdf8569
Ok, really this time. This should work :)
2001-09-03 19:26:58 +00:00
4fc953535a
Backout of this to get things back to normal
2001-09-03 18:50:56 +00:00
a9bf8e83e2
Use Support::Files for the test items.
No review needed at this time for tests as per Dave.
2001-09-03 18:35:19 +00:00
744c3c158b
Addition of Files.pm which will be used shortly by 1.t (soon to be 1compile.t) which contains the list of files to test. This is important so that we can bring it into other tests which check files for content, etc...
No review required for tests as of now as per Dave.
2001-09-03 18:33:03 +00:00
2c55fae775
Fix for bug 98024: t/1.t should use $^X instead of hard-coded path to perl.
...
Patch by ddkilzer@theracingworld.com (David D. Kilzer, ddk). Review by Zach Lipton (zach@zachlipton.com ) no 2nd review required.
2001-09-03 17:58:53 +00:00
eed4aabd7a
Fix for bug 91808: Additional sanitycheck tests for the duplicates table.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net , caillon@returnzero.com
2001-09-03 01:08:05 +00:00
5c71444e32
Added a --verbose option to runtests.sh that the tinderbox scripts can use to get all the warnings and errors and whatnot into the build log. Also corrected several syntax and logic errors in the 1.t test file.
2001-09-01 03:06:15 +00:00
8a4dfb84a5
Fix for bug 42810 - Bugzilla would choke if your product name contained a ' mark.
...
Patch by Christian Reis <kiko@async.com.br>
r= justdave@syndicomm.com , caillon@returnzero.com
2001-08-31 23:51:35 +00:00
825d57d288
Fix for bug 96603: Grammatical error in bug_status.html. Simple one word fix.
...
Patch by Christopher Aillon (caillon@returnzero.com ). r1=Christian Reis (kiko@async.com.br ),
r2=Zach Lipton (zach@zachlipton.com ) though not really needed for this patch.
2001-08-31 23:37:36 +00:00
dbd90ba1be
Fix for bug 97764: Fixes errant sending of mail on attachment changes to users who do not want to receive mail about their own changes.
...
Patch by Jake <jake@acutex.net>.
r=myk@mozilla.org ; no second review needed.
2001-08-31 21:40:33 +00:00
23212ed017
Adding runtests.sh and 1.t to start the testing suite. No bug has been
...
filed on this issue. NOT_PART_OF_BUILD.
2001-08-31 17:41:38 +00:00
4c94f5c6c3
Fix for bug 97721: Bugzilla now requires Perl 5.005 (previous requirement was Perl 5.004). This is due to the use of Template Toolkit for templatizing the pages for easier local customization. The new attachment tracker that was checked in earlier tonight uses the templates. Also included on this patch is a check for AppConfig, which is a prerequisite for Template Toolkit, because the Makefile.PL for Template Toolkit won't run without it, and it doesn't tell CPAN that it has prereqs, which causes confusion if you're installing from CPAN.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-31 06:08:43 +00:00
19a5a3e365
Fix for bug 75840: syncshadowdb -syncall now properly shuts down Bugzilla during the sync process so mysql doesn't get overloaded while the tables are locked. This patch also adds some funtionality to the script to allow you to specify an alternate temp directory on the command line, in case you have a large database and need it made to a different filesystem for space reasons.
...
Patch by Dawn Endico <endico@mozilla.org> and Jake Steenhagen <jake@acutex.net>
r= justdave@syndicomm.com
2001-08-31 05:49:01 +00:00
41268ed110
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
...
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 04:19:32 +00:00
34ed0df3d8
Fix for bug 84338: initial implementation of attachment tracker, which lets users flag attachments with statuses.
...
Patch by Myk Melez <myk@mozilla.org>
r=justdave@syndicomm.com
2001-08-31 03:54:37 +00:00
70b600ce7e
Fix for bug 26189: "cannot view images with lxr". The image-handling code was running too early and didn't have access to the "raw" URL parameter by which images get displayed.
...
Patch by Dawn Endico <endico@mozilla.org>
r=myk@mozilla.org
2001-08-31 00:46:09 +00:00
983ad23402
Fix for bug 96534: The version, component, and milestone select lists on the query page were slow to reflow when you changed the product in the first select list. This patch is a complete rewrite from scratch of the javascript used on query.cgi, which results in an approximately 700% speed increase in the reflow time when changing the selected product.
...
Patch by Chris Lahey <clahey@ximian.com> and Christian Reis <kiko@async.com.br>
Javascript changes r= caillon@returnzero.com , louie@ximian.com
Perl changes r= jake@acutex.net , justdave@syndicomm.com
2001-08-30 22:56:53 +00:00
c6459e2072
merge this sample with code I am really using, to demonstrate how to build
...
tar files for each build and use the -D in CVS.
2001-08-30 18:54:25 +00:00
94050ac3cb
Fix for bug 28736 - Bugmail will now show the summary for the bug that changed in the "This bug depends on bug X, which changed state" messages.
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-30 03:14:24 +00:00
7d1487e8ed
Bumping version to 2.15 for development
2001-08-29 21:41:50 +00:00
72c5f424e5
moving version to 2.14 (golden) to roll the tarball.
2001-08-29 19:52:13 +00:00
4a68b9ae59
Updating release notes for 2.14
...
Release Notes written by Matthew Tuck <matty@chariot.net.au>
r= justdave@syndicomm.com , jake@acutex.net
2001-08-29 19:39:01 +00:00
423e261089
Typo in perl modify string, added "#!" to /usr/bin/perl strings.
2001-08-29 18:13:42 +00:00
e9d3e04bff
Buncha' release updates. Moved all images to
...
./images so we don't have multiple copies of the
same image, fixed these doc bugs (in no particular order):
94949
97070
97071
97114
96498
95970
96677
94953
96501
96679
97068
97191
97192
2001-08-29 17:25:41 +00:00
6929a0dcaf
*** empty log message ***
2001-08-29 16:07:08 +00:00
1296d0bf87
Fixing a couple typoes
2001-08-28 17:55:14 +00:00
8b3f62a485
Re-fix for bug 87769: the original patch checked in for this prevented any votes from being changed at all. This corrects that so votes can be changed again while still trapping the error the original patch was designed to catch.
...
Patch by Christoper Aillon <caillon@returnzero.com>
r= justdave@syndicomm.com
2001-08-28 09:19:16 +00:00
af99f4f812
All code patches targetted for 2.14 have been checked in. Bumping version
...
number to 2.14rc to indicate release candidate status.
2001-08-26 23:06:45 +00:00
796b6cf561
Fix for bug 92266: Prevent dataloss in the bugs_activity table by wrapping
...
entries into additional entries if they're too long to fit.
Patch by Dave Miller <justdave@syndicomm.com>
r= jake@acutex.net
2001-08-26 22:58:34 +00:00
0c11288732
Bug 96085 - bypassing group security checks using duplicate bugs
...
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-26 18:51:45 +00:00
83ff039814
Fix for bug 87769 - doeditvotes.cgi can nuke votes
...
Patch by Christopher Aillon <christopher@aillon.com>
r= jake@acutex.net
2001-08-25 18:53:31 +00:00
51d56e60fb
Fix for bug 95634 - Improvements to Param('voteremovedmail')
...
Patch by Matthew Tuck <matty@chariot.net.au>
r= jake@acutex.net
2001-08-25 00:12:12 +00:00
5206e0b6ac
Fix for bug 95235: variables with untrusted content were being echoed back to the user in error messages. Those variables are now run through html_quote() first.
...
Patch by Gavin Shelley <gavins@iplbath.com>
r= justdave@syndicomm.com
2001-08-24 17:32:25 +00:00
1e367845e7
Adding some pretty images for the Bugzilla Guide warning,
...
note, caution, and tip entries.
2001-08-23 14:30:20 +00:00
4eb813cb2d
Big checkin of docs to resolve every
...
known outstanding doc bug! Yay release.
Still many things to fix. Aren't there always?
2001-08-22 03:44:35 +00:00
f22a315477
Bug 96063 - the old method of doing this barfed on long URL strings.
2001-08-21 00:36:54 +00:00
94ad120a76
Fix for bug 96085: don't allow unauthorized users to access restricted bugs that do not have a QA contact.
...
Patch by Myk Melez <myk@mozilla.org>
r=Jake <jake@acutex.net>
2001-08-20 20:36:10 +00:00
87e2b74b56
current as of mon aug 20
2001-08-20 18:59:56 +00:00
262f3cf591
catch io errors from storable and give better discriptions.
2001-08-20 18:57:12 +00:00
caf8704094
Fix for bug 95890: Correctly convert/record keyword changes in the bugs_activity table for keywords containing a plus sign or other
...
regular expression meta-characters. Myk's first ever Bugzilla checkin!
Patch by Dave Miller <justdave@syndicomm.com> and Myk Melez <myk@mozilla.org>.
r=myk@mozilla.org ,justdave@syndicomm.com
2001-08-19 18:26:21 +00:00
65e904febe
Refixing bug 95875 - The code that breakes the typed in CC list into individual lists is now slightly more robust and allows perl to handle the splitting more efficiently (by using a space as the delimiter).
...
r= myk@mozilla.org
2001-08-18 03:35:36 +00:00
4655038d3a
Fix for bug 95857: process_bugs.cgi sees blank address in cc: line (would show up as __UNKNOWN__)
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-18 01:49:02 +00:00
2f772f1b84
Fix for bug 95747 - CC List validation (for additions) wasn't happening until after the bug's changes were in the process of being commited. This caused problems if a typo was made in the e-mail address.
...
r= myk@mozilla.org
2001-08-17 20:18:33 +00:00
1f0d8fe308
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-17 12:42:34 +00:00
44f95ac895
Fix for bug 95743: the role-accessible checkboxes were getting cleared if a user with group access had to log in to make changes to a public bug.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 11:15:04 +00:00
a70b156a17
Fix for bug 95731: "INSERT INTO shadowlog" failed because "Table 'shadowlog' not locked", fixed typo in lock tables command.
...
Patch by Myk Melez <myk@mozilla.org>
r= justdave@syndicomm.com
2001-08-17 08:38:54 +00:00
c44843283c
Fix for bug 95546. MySQL versions before 3.23 don't support INNER JOINs
...
Patch by Myk Melez <myk@mozilla.org>
r= jake@acutex.net
2001-08-16 15:28:33 +00:00
007829877b
Fix for bug 95535: the token generator for password resets is allowing the & character to be used for tokens, but wasn't escaping them for the URL it emailed to users to use to get in to reset their password.
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:52:55 +00:00
d12bd21adf
Fix for bug 87779: thanks to the new password reset code, there was no clear way to create a new Bugzilla account from the login screen. There is now a link to createaccount.cgi from the login screen, and the text around the password reset button has been edited so it doesn't sound like you can get a new account by using it (because you can't)
...
Patch by Dave Miller <justdave@syndicomm.com>
r= myk@mozilla.org
2001-08-16 06:43:21 +00:00
ea3bc4ddbb
Fix for bug 95304: Add a buglist link to the top of duplicates.cgi
...
Patch by Gervase Markham <gerv@mozilla.org>
r= justdave@syndicomm.com
2001-08-16 02:54:49 +00:00
ian%hixie.ch
jake%acutex.net
mcafee%netscape.com
rginda%netscape.com
myk%mozilla.org
zach%zachlipton.com
timeless%mac.com
gerv%gerv.net
justdave%syndicomm.com
kestes%walrus.com
barnboy%trilobyte.net