зеркало из https://github.com/mozilla/pjs.git
33c6c4e5d5
r=jkeiser sr=jst <timeless> *shrug* i'm not actively trying to defend this patch, it's the right thing to do for the given contract <jkeiser> timeless: I dunno, doing *x = blah; when you don't need to do it is definitely more expensive than if (!x) <timeless> you aren't even allowed to do what you suggest, the contract explicitly forbids it [clarification, the caller isn't allowed to rely on this] if i tried to do what you suggest, shaver would kill me :) <jkeiser> timeless: so shaver is the guy to ask here? <timeless> yeah if you're concerned about it if you care measure. i care about crashing and contract violations the contract was (out foo). which according to what shaver said when i asked him and my memory of that, didn't allow 0. <shaver> it doesn't allow 0 <jst> right <shaver> we check it all over the place in the code, because we're sheep <dmose> baaa |
||
|---|---|---|
| .. | ||
| macbuild | ||
| public | ||
| resources/locale | ||
| src | ||
| tests | ||
| .cvsignore | ||
| Makefile.in | ||
| jar.mn | ||
| makefile.win | ||