Граф коммитов

1502 Коммитов

Автор SHA1 Сообщение Дата
Martin Giger ea05927888 Bug 1792869 - Convert XPCOMUtils imports to esm in mailnews/. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D159063

--HG--
extra : rebase_source : 332a690910fc8c17ac702d3af4e3693faede08e0
extra : amend_source : cd0bb3cabc7d2322bec1024b82f5fd89b5fe6899
2022-10-12 21:41:55 +11:00
Ben Campbell 4d55e8b6b9 Bug 1791459 - test_converterImap.js to add_setup. r=mkmelin
Also tidies up a little cruft.

Differential Revision: https://phabricator.services.mozilla.com/D158894

--HG--
extra : amend_source : 885d0ed5e4ca73fb278ad34dfccbb3ea81487e36
2022-10-11 21:47:27 +11:00
Ping Chen 329b6919c2 Bug 1762690 - Fix test_stopMovingToLocalFolder.js for macOS by normalizing folder path. r=mkmelin
Introduce MsgProtocolInfo.sys.mjs to reuse code between nntp/pop3/imap protocol info modules.

Differential Revision: https://phabricator.services.mozilla.com/D158739

--HG--
extra : moz-landing-system : lando
2022-10-06 08:26:29 +00:00
Ping Chen 11a11a69e8 Bug 1762690 - Enable test_imapAutoSync and test_imapHighWater for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D158442

--HG--
extra : moz-landing-system : lando
2022-10-06 08:26:28 +00:00
Ben Campbell f5d7560958 Bug 1793313 - Fix bad end-of-message detection when saving news messages offline. r=mkmelin
The problem was that NntpClient was handling escaping the "." message
termination, but that nsNewsFolder::NotifyDownloadedLine() was scanning for
"." lines to finish messages. So the folder would screw up when a message
body contained a lone "." line.

The changes in detail:
- Adds notifyDownloadBegin()/notifyDownloadEnd() calls to nsIMsgNewsFolder.
- In NntpClient.jsm:
  - Now calls notifyDownloadBegin()/notifyDownloadEnd() to denote message
    boundaries.
  - No longer sends a "." final line to the folder.
  - Tries to call notifyDownloadEnd() with an error code if an error occurs.
- adds an status param to nsMsgDBFolder::EndNewOfflineMessage(), and a code
  path to clean up upon errors. News folder now uses this to handle rolling
  back if an error occurs, but IMAP still relies on magic (checking the size
  of the message written so far).
- nsNewsFolder::NotifyDownloadedLine() no longer looks for a lone "." to
  denote the end of a message. The relevant code was split out into
  NotifyDownloadBegin() and NotifyDownloadEnd().
- Added some comments to try and clarify the offline message writing vars in
  nsMsgDBFolder.

Differential Revision: https://phabricator.services.mozilla.com/D158486

--HG--
extra : absorb_source : 14534b426ccbe4239cb916c35c057ed46f3f6a4e
2022-10-03 08:26:21 +00:00
Rob Lemley c098c97425 Bug 1792817 - Port bug 1792365: Migrate some toolkit module imports to ESM. r=mkmelin
../mach tb-esmify --upstream-imports calendar --prefix=toolkit/
../mach tb-esmify --upstream-imports chat --prefix=toolkit/
../mach tb-esmify --upstream-imports mail --prefix=toolkit/
../mach tb-esmify --upstream-imports mailnews --prefix=toolkit/

Differential Revision: https://phabricator.services.mozilla.com/D158363

--HG--
extra : amend_source : e4e2791bd957bf16ed1907589c3c18ad5f0ec618
2022-09-30 20:44:14 +10:00
Ping Chen 9ebcd51097 Bug 1762690 - Enable test_folderOfflineFlags and test_gmailAttributes for imap-js. r=benc
Differential Revision: https://phabricator.services.mozilla.com/D158075

--HG--
extra : histedit_source : 927d634cefd403581665449f96c541c9ded9c46b
2022-09-28 23:39:56 +00:00
Ping Chen ebdf431aa1 Bug 1762690 - Enable test_dod for imap-js. r=benc
Call parseAdoptedMsgLine only when downloading for offline.

Differential Revision: https://phabricator.services.mozilla.com/D158015

--HG--
extra : histedit_source : 35326dad81be0a671851946449b9af9ab7267b5d
2022-09-23 10:48:40 +00:00
Ping Chen 4e2fca8472 Bug 1762690 - Enable test_subfolderLocation.js and test_syncChanges.js for imap-js. r=benc
Differential Revision: https://phabricator.services.mozilla.com/D158014

--HG--
extra : histedit_source : cec23344f7a4c79fd0c04c72818b77561b6027d1
2022-09-28 23:29:52 +00:00
Ping Chen bfa31777c4 Bug 1762690 - Enable test_stopMovingToLocalFolder.js for imap-js. r=benc
Differential Revision: https://phabricator.services.mozilla.com/D157703

--HG--
extra : histedit_source : 0541cda47290275e3d8bc0e0bbd8f675697f4d89
2022-09-23 10:47:29 +00:00
Ping Chen cc536d6dc2 Bug 1735803 - Convert server hostname to lowercase before connecting. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D158179
2022-09-27 05:39:23 +00:00
Ping Chen 0cfa55c10b Bug 1762690 - Disable three tests for imap-js. r=mkmelin,benc
Chunking and download on demand need some more work.

Differential Revision: https://phabricator.services.mozilla.com/D157826
2022-09-21 12:56:45 +00:00
Ping Chen 3377c17524 Bug 1791706 - Port 1790451 - use the concrete type nsITransportSecurityInfo for nsIChannel.securityInfo. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D157780

--HG--
extra : moz-landing-system : lando
2022-09-21 08:02:02 +00:00
Ping Chen 7a43318c4b Bug 1762690 - Fetch headers first, then fetch body on demand in ImapClient. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157582

--HG--
extra : moz-landing-system : lando
2022-09-20 03:59:54 +00:00
Magnus Melin fa1931d4a7 Bug 1791169 - Backed out changeset 9d358a4c4bb5 for causing bug 1776823. rs=backout 2022-09-19 20:32:28 +10:00
Ping Chen b5195b31cb Bug 1762688 - Disable test_offlineCopy for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157577

--HG--
extra : amend_source : 23527deda120ce430b223c605996d2e820da5a66
2022-09-18 19:52:58 +10:00
Ping Chen 6c772a01a4 Bug 1762688 - Enable test_nsIMsgFolderListenerIMAP.js for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157401

--HG--
extra : amend_source : 40e44acbb770366cbebca908859665eb86aea60f
2022-09-16 20:43:03 +10:00
Ping Chen 96987724b2 Bug 1762688 - Enable test_listClosesDB and test_listSubscribed for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157295

--HG--
extra : amend_source : 6949689182daf4d0599664b55130814936df4f7f
2022-09-16 20:42:08 +10:00
Magnus Melin 95a1aeb0e8 Backed out changeset 6533be800ca3 (bug 1762688) for test failures on debug. rs=backout 2022-09-15 20:38:55 +10:00
Ping Chen 3623a53969 Bug 1762688 - Enable test_listClosesDB and test_listSubscribed for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157295

--HG--
extra : amend_source : 5caa070dc8aba7dbecda282b08daef3e6fe5998f
2022-09-15 16:45:53 +10:00
Ping Chen 4dd9439427 Bug 1762688 follow-up - Fix eslint error. r=#thunderbird-reviewers,john.bieling
Differential Revision: https://phabricator.services.mozilla.com/D157289

--HG--
extra : amend_source : f2755de38501d98c903fe5693ef565f583490f0c
2022-09-14 20:29:37 +10:00
Ping Chen 867d68bc49 Bug 1762688 - Enable test_imapStatusCloseDBs for imap-js. r=mkmelin
Implement nsIMsgProtocolInfo in ImapProtocolInfo.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D157192

--HG--
extra : moz-landing-system : lando
2022-09-14 04:43:12 +00:00
Ping Chen 8bfea5ca02 Bug 1762688 - Enable test_imapUrls for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157029

--HG--
extra : moz-landing-system : lando
2022-09-14 04:43:11 +00:00
Ben Campbell 345e8742e4 Bug 1787963 - Fix offline local->IMAP message move operation. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D157071
2022-09-12 21:47:47 +00:00
Gene Smith 8f99c6d58c Bug 1776823 - Fix for autosync sometimes stops or doesn't occur at all. r=BenC
- Fix parsing for imap UNSEEN in SELECT command -- it's not number of unseen.
- Make sure only UNSEEN from imap STATUS is used -- it is number of unseen
- Make sure imap STATUS has occurred before using the stored UNSEEN value.
- Store imap untagged EXISTS and MESSAGES from imap STATUS to same variable.
- Store imap untagged RECENT and RECENT from imap STATUS to same variable.
- Avoid autosync lockup if folder update finds no new headers to fetch.
- Force folder update if .msf is empty or missing on initial access.
- Add more MOZ_LOG for better debugging.

Differential Revision: https://phabricator.services.mozilla.com/D156392

--HG--
extra : moz-landing-system : lando
2022-09-11 23:07:04 +00:00
Alessandro Castellani 3f54316f94 Bug 1789943 - Port Bug 1760580 Implement CancelWithReason methods. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D156906
2022-09-08 22:44:22 +00:00
Ping Chen a94906f0e7 Bug 1762688 - Disable test_imapStatusCloseDBs.js for imap-js. r=mkmelin,benc
Differential Revision: https://phabricator.services.mozilla.com/D156649

--HG--
extra : amend_source : b75e2ba3c8b7e0cb4c790506e23dd5e91527e639
2022-09-07 20:41:15 +10:00
Ping Chen 6abbf423bc Bug 1762688 - Enable test_imapStoreMsgOffline for imap-js. r=mkmelin
Implement ImapService.downloadMessagesForOffline.

Differential Revision: https://phabricator.services.mozilla.com/D156536

--HG--
extra : moz-landing-system : lando
2022-09-07 05:19:18 +00:00
Ping Chen a39413215f Bug 1762688 - Enable test_imapID.js and test_imapClientid.js for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D156291

--HG--
extra : amend_source : f1ff7edbf17b4dcf12acd5cad18bb81f7f509693
extra : absorb_source : 90aba8cda2fa5fbb3d3148b6e397efc093a03f4b
2022-09-06 20:03:04 +10:00
Ping Chen d5b368e0ea Bug 1762688 - Enable test_imapHdrStreaming.js for imap-js. r=mkmelin
Implement ImapMessageService.streamHeaders.

Differential Revision: https://phabricator.services.mozilla.com/D156290

--HG--
extra : amend_source : ba049620bba035e311e0769b3414719f7fb0dbcd
2022-09-06 20:02:35 +10:00
Ben Campbell 874af419f6 Bug 1787963 - Copy message to msgStore as part of local->IMAP offline copy op. r=mkmelin
This patch addresses a couple of issues in nsImapMailFolder::CopyMessagesOffline(),
which handles copying messages to IMAP folders when in Offline mode:
1) It uses nsIMsgFolder.HasMessageOffline() to see if a full local copy of a
   message is available in the source folder. But the local folder implementation
   of HasMessagesOffline() would always return false. So copy operations from
   a local folder would never copy the full message across to the msgStore of
   the destination IMAP folder. This patch adds a local folder implementation
   of HasMessageOffline().
   (The roots of this issue is down to pointless differences between the way
   local folders and IMAP folder handle message storage on disk).
2) The CopyOfflineMsgBody() routine used to actually copy the message between
   the local folder msgStore and the IMAP folder msgStore would corrupt the
   message data. I've replaced it with a much simpler dumb copy.

The upshot is that after the offline copy, a full message will appear in the
destination IMAP folder. It's a required first step, but it doesn't fix the
rest of the bug - the moved message disappearing during the IMAP sync after going
back into online mode.

Differential Revision: https://phabricator.services.mozilla.com/D156269

--HG--
extra : amend_source : ecd95fb9c75652659f2542b79a2f4ff5dbe5c863
2022-09-05 20:31:34 +10:00
Ping Chen 05ec66220c Bug 1762688 - Enable test_imapFolderCopy.js for imap-js. r=mkmelin,benc
Implement ImapService.moveFolder.

Differential Revision: https://phabricator.services.mozilla.com/D156046

--HG--
extra : amend_source : 7e932c7758deb8f2bc1700519bb32caa890114c8
2022-09-01 20:44:15 +10:00
Ping Chen 81be03390e Bug 1762688 - Enable test_imapFilterActions.js for imap-js. r=mkmelin
Implement ImapMessageService.CopyMessage and ImapService.storeCustomKeywords.

Differential Revision: https://phabricator.services.mozilla.com/D155559

Depends on D155778

--HG--
extra : histedit_source : 66ae8bce6a45ebbfd47d654966375f7cfa9b2086
2022-08-27 11:51:36 +00:00
Ping Chen 9926265fa5 Bug 1762688 - Use nsIImapFlagAndUidState interfaces instead of GetFlagsForUID in nsImapMailFolder. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D155778

--HG--
extra : histedit_source : 363cf84aac6620bc93c5f3334964d6b0913db45b
2022-08-29 23:47:07 +00:00
Ben Campbell bbb6fec901 Bug 1787650 - Fix crash on null listener in IMAP compaction/expunge. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D155801
2022-08-29 22:09:00 +00:00
Magnus Melin 4762867b8e Bug 1782719 - Don't mark NotJunk flagged mails as junk (e.g. Yahoo.). r=benc
Differential Revision: https://phabricator.services.mozilla.com/D155667

--HG--
extra : rebase_source : 5333f215f81bc5af2c9bab04ad7560c15039c984
2022-08-29 11:49:07 +10:00
Magnus Melin 293cbd8b23 Bug 1786662 - Fix usages of securityInfo in protocols. r=rnons
Differential Revision: https://phabricator.services.mozilla.com/D155577

--HG--
extra : rebase_source : f1dc9f271c9a23ec11fddd0191bb11aebc6672d9
extra : amend_source : fb9c55edfd4b3be410940d01a8ea907ac253c892
2022-08-26 15:59:40 +10:00
Ping Chen 05769e8fe1 Bug 1786920 - Show hostname in pop3 password dialog, prevent showing multiple auth dialogs. r=mkmelin
The bug is server.hostname should be server.hostName.
Take the chance to refactor MsgIncomingServer and MailAuthenticator a bit to prevent showing multiple auth dialogs for the same server.

Differential Revision: https://phabricator.services.mozilla.com/D155534

--HG--
extra : amend_source : 67039c16f44a4c3bb2062fd67b50c32b99e9d7b9
2022-08-25 20:43:19 +10:00
John Bieling 646ba07646 Bug 1644038 - Fix messageDisplay API, tabs API and messages API to properly handle external emails. r=darktrojan
Differential Revision: https://phabricator.services.mozilla.com/D148120

--HG--
extra : amend_source : a060617f34f94498ab264741e81d63afb772b8ea
2022-08-25 20:40:20 +10:00
Ping Chen a7bafb2391 Bug 1786655 - Use PascalCase for class names in Imapd.jsm. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D155442

--HG--
extra : rebase_source : bcc41a11e32b07b08bd360c27a453ca0eaf98a26
extra : amend_source : 8ec9673ee8ebd90cbc843c5407cead88f2d3af57
2022-08-24 20:26:33 +10:00
Ping Chen 2f8bd68359 Bug 1786655 - Use PascalCase for class names in {Smtpd,Nntpd,Pop3d}.jsm. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D155443

--HG--
extra : rebase_source : 8c643aaf5259ce46ce813022af97717bfe5d828b
extra : amend_source : 9cb9163749ccd3846169ffbfd066fac64de507a9
2022-08-24 20:26:12 +10:00
Geoff Lankow f1f2595cf0 Bug 1786662 - Port bug 1784098 - explore making securityInfo concrete in necko interfaces. r=rnons
Port of https://hg.mozilla.org/mozilla-central/rev/197147c8c1a4 and https://hg.mozilla.org/mozilla-central/rev/8fafb15791c6

Differential Revision: https://phabricator.services.mozilla.com/D155436

--HG--
extra : moz-landing-system : lando
2022-08-24 02:09:31 +00:00
Magnus Melin b7695aae07 Bug 1785003 - Fix resource leak in nsImapMailFolder::CompactAll. r=benc
Differential Revision: https://phabricator.services.mozilla.com/D154710
2022-08-16 01:27:55 +00:00
Ping Chen bc5488ca86 Bug 1762688 - Enable test_imapCopyTimeout.js for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D154953
2022-08-18 01:14:32 +00:00
Ping Chen 20bd72ed9f Bug 1762688 - Enable test_imapContentLength.js for imap-js. r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D154847
2022-08-17 01:22:00 +00:00
Ping Chen 69f494b016 Bug 1762688 - Enable test_gmailOfflineMsgStore and test_imapAttachmentSaves for imap-js. r=mkmelin
Implement DisplayMessage in ImapMessageService.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D154583

--HG--
extra : amend_source : c78ae1ec1ce7b3d9d8e7c979c060839f9dce8f6a
2022-08-16 20:28:48 +10:00
Ping Chen 3a57c93d66 Bug 1762690 - Enable test_filterCustomHeaders.js for imap-js. r=mkmelin
Improve literal string parsing in ImapResponse.jsm.

Differential Revision: https://phabricator.services.mozilla.com/D154479

--HG--
extra : amend_source : 97680f7f1c103b0b447b9ef5a7657f592e0e49d3
2022-08-12 20:25:16 +10:00
Ben Campbell 23fa3b6ce7 Bug 1782374 - Ensure correct listener notification in nsImapMailFolder::CompactAll(). r=mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D154081
2022-08-09 11:23:20 +00:00
Kai Engert 9a93867602 Bug 1629669 - Rework nsImapProtocol::GetPassword to avoid deadlock, and better protect m_passwordObtained/m_passwordStatus. r=benc,mkmelin
Differential Revision: https://phabricator.services.mozilla.com/D154019

--HG--
extra : amend_source : e2bd2d6e89ca13e20a20e66567fc161ed060b4ce
2022-08-10 20:28:41 +10:00
Gene Smith 34843ca8f0 Bug 1764770 - Regression fix for bad TLS certificate override for imap. r=mkmelin
Fixes the regression caused by changes in bug 1768121 so that the bad
certificate override dialog now appears when "Get Messages" is clicked.

Differential Revision: https://phabricator.services.mozilla.com/D154140
2022-08-09 19:04:50 +00:00