Geoff Lankow
8c9c7ff446
Bug 1741542 - Give the name of the changed property in nsIDBChangeListener.onHdrPropertyChanged. r=mkmelin
...
I modified the nsIDBChangeListener interface to pass the name of the changed property when a property changes. This wasn't strictly necessary but it is a useful optimisation.
Change listeners aren't even notified if a change happens to a nsMsgHdr object directly (it writes straight to the database and doesn't tell anybody) but that doesn't seem to be a major problem as the changes I'm interested in go through nsMsgDatabase.
Differential Revision: https://phabricator.services.mozilla.com/D131319
--HG--
extra : rebase_source : dfbf9a5a89582782fdacb92558c209233ef2ce43
extra : histedit_source : 4b58f65c41cc8d770661f3c767b38935f78a13f4
2021-11-17 15:46:56 +13:00
Rachel Martin
8e08ba891c
Bug 1741619 - Change most URI APIs to from raw string to smart string. r=mkmelin
...
--HG--
extra : rebase_source : 182d285562d18b88558a4a26a508a40956b75ed4
2021-11-19 20:23:48 +02:00
Rachel Martin
62b0329bc2
Bug 1741559 - Replace use of nsCString().get() with PromiseFlatCString().get() in mailnews. r=mkmelin
...
--HG--
extra : rebase_source : e5b7270dc94d93064b7a61adc7f864ea853ce34d
2021-11-19 20:21:45 +02:00
Mark Banner
07e0b844e0
Bug 1739784 - Fix nsIMsgFolder.getUriForMsg, nsIMsgMessengerService.DisplayMessage and nsIMsgMessengerServices.streamMessage to handle non-ascii URIs. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D130554
--HG--
extra : moz-landing-system : lando
2021-11-08 12:39:28 +00:00
Magnus Melin
85333d993b
Bug 1668926 - fix unitialized pointer field in nsImapMailboxSpec::nsImapMailboxSpec. r=benc
...
CID 137604 Uninitialized pointer field
The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In nsImapMailboxSpec::nsImapMailboxSpec(): A pointer field is not initialized in the constructor
Differential Revision: https://phabricator.services.mozilla.com/D130032
--HG--
extra : rebase_source : 6b45a707e4cf15976a0e4537ac4960f107e0ab4c
2021-10-31 21:56:18 +02:00
Magnus Melin
0a4b246081
Bug 1668926 - fix unitialized members in nsImapProtocol::nsImapProtocol. r=benc
...
CID 1137611 Uninitialized scalar field
The field will contain an arbitrary value left over from earlier computations.
In nsImapProtocol::nsImapProtocol(): A scalar field is not initialized by the constructor
Differential Revision: https://phabricator.services.mozilla.com/D130031
--HG--
extra : rebase_source : b0399ef34290aacf4cdbcaa89f053f09d6d058fa
2021-10-31 21:48:29 +02:00
Magnus Melin
9f46e749fc
Bug 1543184 - try to fix crash in [@ shutdownhang | nsSyncStreamListener::Available]. r=benc
...
Differential Revision: https://phabricator.services.mozilla.com/D130030
--HG--
extra : rebase_source : b1bba1febf3f9d040e1040d144200de970f7ee48
2021-11-01 14:24:03 +02:00
Magnus Melin
37baa8dd18
Backed out changeset 70c0061f9f84 (bug 1734847) for test failures. r=backout DONTBUILD
...
mailnews/search/test/unit/test_quarantineFilterMove.js is crashing
--HG--
extra : amend_source : 72c9e867d7410a6d108ec8dc1c6d1a3e2dfe74e1
2021-11-05 15:39:56 +02:00
Magnus Melin
ec7feb64d7
Bug 1734847 - Backed out changeset 2c8857af0eb3 (bug 1728924) for causing .msf corruption. rs=backout
...
--HG--
extra : rebase_source : d13d982f3bcb91f3dac099d64b517e578638691a
2021-11-05 12:30:19 +02:00
Mark Banner
c4fe00d87f
Bug 689544 - Change nsIMsgMessageService:OpenAttachment to handle UTF8 strings to allow it to be called direct from JS. r=mkmelin
...
This also avoids unnecessary nsCString -> char* -> nsCString conversions.
Differential Revision: https://phabricator.services.mozilla.com/D129709
--HG--
extra : amend_source : b8aac5503307de18819c70c55559bc1b24c65e2d
2021-10-28 12:59:49 +03:00
Magnus Melin
5924ba7952
Bug 1668926 - coverity - fix logically dead code in nsImapUrl::AllocateCanonicalPath. r=benc
...
CID 1137379 Logically dead code
notnull: At condition currentPath, the value of currentPath cannot be nullptr.
Differential Revision: https://phabricator.services.mozilla.com/D128573
--HG--
extra : rebase_source : b0e27f072d019c50f3cf3c263c35c41293721d8c
extra : amend_source : 2eef04ba1c6d88d6ec06da21f7cd67fe0cfbbae0
2021-10-20 13:27:40 +03:00
Magnus Melin
4505a5eb2f
Bug 1734363 - remove unused nsIImapService.fetchMessage() additionalHeader param. r=benc
...
Differential Revision: https://phabricator.services.mozilla.com/D127770
--HG--
extra : rebase_source : 5d6b2c66ce7eb7a91fadbcfbae926efd93369b50
2021-10-07 10:18:14 +03:00
Magnus Melin
255fb96aab
Bug 1734363 - remove unused nsIMsgMessageService.DisplayMessageForPrinting(). r=benc
...
Removing it, and including some clang-formats
Differential Revision: https://phabricator.services.mozilla.com/D127640
--HG--
extra : rebase_source : baa4bebfe648d45d8f86fd2287fef5999483aebb
2021-10-06 14:11:33 +03:00
Ben Campbell
f4bc63cba0
Bug 1733849 - Use nsIMsgFolder.getSlicedOfflineFileStream() instead of getOfflineFileStream(). r=mkmelin
...
This is an intermediate step. We want to get all the message-reading code
working with streams that contain just a single message, rather than with an
unwieldly mbox stream + offset/size combo.
Then we'll remove getOfflineFileStream() entirely and rename
getSlicedOfflineFileStream() to replace it.
Differential Revision: https://phabricator.services.mozilla.com/D127372
2021-10-04 22:25:50 +00:00
Ben Campbell
7c3a61c344
Bug 1733504 - Remove unused aLocalOnly param from nsIMsgFolder.fetchMsgPreviewText(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D127189
--HG--
extra : amend_source : 8f265434f337a7ade95130b6c830a5529ba372b1
2021-10-03 13:52:15 +03:00
Martin Giger
d1c1e35fc5
Bug 1713786 - Do mime detection instead of charset override. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D126814
--HG--
extra : moz-landing-system : lando
2021-10-01 22:09:51 +00:00
Ben Campbell
19824555f1
Bug 1683590 - Remove nsISupport use in nsIFolderListener.OnItemAdded/Removed callbacks. r=mkmelin
...
Breaks up OnItemAdded() and OnItemRemoved() into folder and message-specific
versions. Also tidies up naming of the callback functions in the .idl while
we're here e.g. OnItemEvent() becomes onFolderEvent().
Differential Revision: https://phabricator.services.mozilla.com/D126593
--HG--
extra : rebase_source : 09c95d139bc512626e7974b95b94fa91cead0ef6
2021-10-01 12:46:34 +03:00
Magnus Melin
5a9a321948
Backed out changeset 89021f52292d (bug 1683590) for build bustage. rs=backout
...
--HG--
extra : amend_source : 2c883d9c7c36aef0d5c3b4a0a489331049079147
2021-09-29 13:42:41 +03:00
Ben Campbell
0bc654a66d
Bug 1683590 - Remove nsISupport use in nsIFolderListener.OnItemAdded/Removed callbacks. r=mkmelin
...
Breaks up OnItemAdded() and OnItemRemoved() into folder and message-specific
versions. Also tidies up naming of the callback functions in the .idl while
we're here e.g. OnItemEvent() becomes onFolderEvent().
Differential Revision: https://phabricator.services.mozilla.com/D126593
--HG--
extra : amend_source : 7e86abd0191c081cbce48965b6d064f146fc7f88
2021-09-29 12:30:19 +03:00
Ben Campbell
d52485e055
Bug 1683590 - Remove nsISupport use in nsIMsgFolder.NotifyItemAdded/NotifyItemRemoved. r=mkmelin
...
Removes .NotifyItemAdded() and .NotifyItemRemoved() which both used nsISupports
and replaces them with specific folder and nsIMsgDBHdr versions.
Still calls the nsISupports-based nsIFolderListener OnItemAdded/OnItemRemoved()
callbacks but lays the groundwork for doing the same thing there.
Differential Revision: https://phabricator.services.mozilla.com/D126579
--HG--
extra : amend_source : f390dc67387ec358cf77b9b0825f42a706610f7f
2021-09-29 12:30:01 +03:00
Ben Campbell
54966cc799
Bug 1731170 - Fix memory leak in nsImapMailFolder::GetFolderOwnerUserName(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D126178
--HG--
extra : amend_source : 00f7c8dcd07a802c83e1c439e5d19091712d0359
2021-09-22 13:48:54 +03:00
Ben Campbell
920afd26df
Bug 1668926 - Fix overlapping buffer in memory copy in nsImapNamespaceList::AllocateCanonicalFolderName(). r=mkmelin
...
Also:
- Moves the two Allocate*() member fns from public to private.
- Removes the unused GetFolderNameWithoutNamespace().
- Converts GenerateFullFolderNameWithDefaultNamespace() to return nsCString rather than char*, to fix a memory leak in nsImapService.
CID 1473469 Overlapping buffer in memory copy
Results in an undefined behavior
In nsImapNamespaceList::AllocateCanonicalFolderName(char const *, char): Buffers may be overlapping in a string copy function
Differential Revision: https://phabricator.services.mozilla.com/D125908
--HG--
extra : amend_source : 0e02849e42154d8d3e3ac9bcc61a902d2c6b8d81
2021-09-20 12:59:19 +03:00
Gene Smith
203ffb32c5
Bug 1708981 - Improve new mail detection for imap IDLE and non-Inbox folders. r=benc
2021-09-14 13:23:00 +03:00
Ben Campbell
792036556e
Bug 1728924 - Remove nsIMsgParseMailMsgState.envelopePos. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D124438
--HG--
extra : amend_source : f6f2b30b86c94fd23886457ac36c7c9352325e75
2021-09-03 13:38:59 +03:00
Ben Campbell
a55334b4ed
Bug 1728703 - Remove redundant nsMsgDBFolder::GetOfflineMsgFolder(). r=mkmelin
...
Also removes getOfflineMsgFolder() from nsIMsgFolder as the only
implementation is internal to nsImapMailFolder.
Differential Revision: https://phabricator.services.mozilla.com/D124286
--HG--
extra : amend_source : 2568f722bbb0164c12aa45e06a79d3c9e8d896d0
2021-09-03 13:37:42 +03:00
Ben Campbell
72c2f9a280
Bug 1728495 - Remove unused srcFolder in nsCopyMessageStreamListener. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D124287
--HG--
extra : amend_source : 8e2c27b4fc768b8148e31b197a538fe511d7bda7
2021-09-03 13:36:55 +03:00
Ben Campbell
97a1cf2adf
Bug 1728464 - Remove redundant message param in nsICopyMessageListener.beginCopy(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D124147
Depends on D124146
--HG--
extra : histedit_source : d956459fdedd438cc09806efefabfb0e81ee1413
2021-08-31 23:28:20 +00:00
Ben Campbell
264dd6d903
Bug 1728464 - Use more robust temp-file generation in nsImapMailFolder::BeginCopy(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D124146
--HG--
extra : histedit_source : 462b9ad47beaafa3836d0e3d08a80546a83d264c
2021-08-31 23:28:08 +00:00
Ben Campbell
e62c604c96
Bug 1728495 - Remove unused nsISupport param in nsICopyMessageStreamListener.Init(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D124155
--HG--
extra : histedit_source : b2a1748be354a5e84d1f5c19a170716715aae51e
2021-09-01 04:09:30 +00:00
Ben Campbell
18cd382596
Bug 1727022 - Fix addSubFolder() use in test_listClosesDB.js. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D123309
--HG--
extra : histedit_source : 37b5f3277c3493afa550393fb6f258dbea84b8df
2021-08-27 05:42:12 +00:00
Ben Campbell
d259f78052
Bug 1727467 - Some minor nsDependentCString fixups in nsImapHostSessionList. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D123907
2021-08-30 22:04:56 +00:00
Ben Campbell
0da4ff5cc3
Bug 1727467 - Use nsCString to store nsImapBodyShell folder name instead of allocating char buffer. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D123589
--HG--
extra : histedit_source : 018210b6ce29c09ab49a169c48e8f48406f412de
2021-08-29 21:52:23 +00:00
Ben Campbell
5becd6f79a
Bug 1727875 - nsImapMailFolder::AddSubfolder() shouldn't destroy .onlineName. r=mkmelin
...
This patch just remove the offending line. It turns out the onlineName is
already set correctly by this time in AddSubfolder(). So it was redundant, as
well as wrong.
It appears the onlineName calculation is performed on-demand, in
GetDBFolderInfoAndDB().
Differential Revision: https://phabricator.services.mozilla.com/D123845
--HG--
extra : histedit_source : 032f6a77bcbae76fdbb20cc85e906a02ef8e5b49
2021-08-27 05:31:36 +00:00
Gene Smith
3a67c1626c
Bug 163964 - Run initial folder discovery in own URL so messages open faster. r=benc
2021-08-25 13:59:51 -04:00
Ben Campbell
beb00d6e0a
Bug 1668926 - fix uninitialized fields in nsImapBodyShell ctor. r=mkmelin
...
CID 1473470 Uninitialized pointer field
The pointer field will point to an arbitrary memory location, any attempt to write may cause corruption.
In nsImapBodyShell::nsImapBodyShell(nsImapProtocol *, nsIMAPBodypartMessage *, unsigned int, unsigned int, char const *): A pointer field is not initialized in the constructor
Differential Revision: https://phabricator.services.mozilla.com/D123580
2021-08-25 03:08:54 +00:00
Ben Campbell
e506c473c2
Bug 1668926 - fix Resource leak in nsImapServerResponseParser::namespace_data(). r=mkmelin
...
CID 450527 Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource.
In nsImapServerResponseParser::namespace_data(): Leak of memory or pointers to system resources
Differential Revision: https://phabricator.services.mozilla.com/D123574
2021-08-25 00:23:38 +00:00
Ben Campbell
3cca5ff130
Bug 1668926 - fix Dereference after null check in nsImapMockChannel::OnCacheEntryAvailable. r=mkmelin
...
CID 1478010 Dereference after null check
Either the check against null is unnecessary, or there may be a null pointer dereference.
In nsImapMockChannel::OnCacheEntryAvailable(nsICacheEntry *, bool, nsresult): Pointer is checked against null but then dereferenced anyway
Differential Revision: https://phabricator.services.mozilla.com/D123566
2021-08-25 00:10:32 +00:00
Ben Campbell
c4f87ae30b
Bug 1724849 - Tidy up nsMsgDBFolder::CreateDirectoryForFolder(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D123308
--HG--
extra : moz-landing-system : lando
2021-08-24 04:07:46 +00:00
Ben Campbell
d7f1d74436
Bug 418551 - Convert nsFolderCache from mork (panacea.dat) to JSON. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D121493
--HG--
extra : histedit_source : 0c077e7dd257d14c7906eb0426531e6343c61c4f
2021-08-19 06:02:34 +00:00
Magnus Melin
9ea240eeda
Backed out changeset 313d232c4038 (Bug 163964) for test failures. rs=backout
...
At least
comm/mail/components/extensions/test/xpcshell/test_ext_accounts.js
comm/mail/components/extensions/test/xpcshell/test_ext_folders.js
comm/mailnews/imap/test/unit/test_imapHighWater.js
2021-08-23 16:54:15 +03:00
Gene Smith
d2841c080c
Bug 163964 - Run initial folder discovery in own URL so messages open faster. r=benc
2021-08-23 12:43:24 +03:00
Magnus Melin
ba4277f631
Bug 1668926 - fix unused rv in nsImapProtocol::UploadMessageFromFile. r=benc
...
Coverify: CID 1468064 (#2 of 2): Unused value (UNUSED_VALUE)returned_value: Assigning value from this->SendData(")\r\n", false) to rv here, but that stored value is overwritten before it can be used
Differential Revision: https://phabricator.services.mozilla.com/D122699
--HG--
extra : rebase_source : dfa114bf776defd07d7ba7945d3e526ecdfe0c91
2021-08-15 21:45:47 +03:00
Magnus Melin
58a099eb8a
Bug 1668926 - fix unused rv in nsImapMailFolder::CopyMessagesOffline. r=benc
...
CID 1473461 (#1 of 1): Unused value (UNUSED_VALUE)returned_value: Assigning value from this->GetClearedOriginalOp(sourceOp.operator nsIMsgOfflineImapOperation *(), nsGetterAddRefs<nsIMsgOfflineImapOperation>(getter_AddRefs(originalOp)).operator nsIMsgOfflineImapOperation **(), nsGetterAddRefs<nsIMsgDatabase>(getter_AddRefs(originalDB)).operator nsIMsgDatabase **()) to rv here, but that stored value is overwritten before it can be used.
Differential Revision: https://phabricator.services.mozilla.com/D122700
--HG--
extra : rebase_source : f30f245755ee29e2403d83a8b7cd35ae630b6edb
2021-08-15 21:57:56 +03:00
Magnus Melin
40f8bb1d8d
Bug 1668926 - fix unchecked return value in nsImapMailFolder::RenameLocal. r=benc
...
CID 1417617 (#1 of 1): Unused value (UNUSED_VALUE)returned_value: Assigning value from this->CreateDirectoryForFolder(nsGetterAddRefs<nsIFile>(getter_AddRefs(dirFile)).operator nsIFile **()) to rv here, but that stored value is overwritten before it can be used.
In nsImapMailFolder::RenameLocal(nsTSubstring<char> const &, nsIMsgFolder *): A value assigned to a variable is never used.
Differential Revision: https://phabricator.services.mozilla.com/D122706
--HG--
extra : rebase_source : 38ceb5643bbf410f0c41cf272c6373daec820870
2021-08-15 22:52:00 +03:00
Magnus Melin
38b317a01f
Bug 1668926 - fix unused return value in nsImapMailFolder::FillInFolderProps. r=benc
...
CID 1364639 (#1 of 1): Unused value (UNUSED_VALUE)returned_value: Assigning value from bundle->FormatStringFromName("imapOtherUsersFolderTypeDescription", params, folderTypeDesc) to rv here, but that stored value is overwritten before it can be used.
Differential Revision: https://phabricator.services.mozilla.com/D122707
--HG--
extra : rebase_source : 719cc8af472f1ecadc6a83a4ae75c53b96a9a8fe
2021-08-15 23:06:36 +03:00
Rob Lemley
14320fcf03
Bug 1712986 - Port bug 1712971: Authentication code updates. r=darktrojan
...
Differential Revision: https://phabricator.services.mozilla.com/D116031
2021-05-26 23:40:33 +00:00
Ben Campbell
905a42dc04
Bug 1719996 - Remove nsImapService assumption that message output stream is seekable. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D119941
--HG--
extra : histedit_source : 42a679133b86a3796ab5d36715a8546b32fe2566
2021-07-15 04:49:20 +00:00
Ben Campbell
72229ac0b4
Bug 1719996 - Remove nsImapMailFolder assumption that message output stream is seekable. r=mkmelin
...
This removes an nsIMsgHdr.setMessageOffset() call. That call was redundant - it's handled
already inside the mbox mailstore.
Differential Revision: https://phabricator.services.mozilla.com/D119940
--HG--
extra : histedit_source : 8d917c9bd73f2d26e1dc90d6d2cc14e098204e3a
2021-07-15 04:49:07 +00:00
Ben Campbell
43432e28fe
Bug 1718998 - Comment-only patch. Notes on folder copying in IMAP. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D119034
--HG--
extra : moz-landing-system : lando
2021-07-05 10:12:09 +00:00
Gene Smith
e73c3e2368
Bug 1682370 - fix a memory leak as a follow-up to STARTTLS response changes. r=benc
2021-06-28 13:31:09 +03:00
Gene Smith
ea1278fae6
Bug 1682370 - Discard/ignore IMAP lines received before before STARTTLS response. r=benc
...
--HG--
extra : amend_source : aa209c6e2e49f8306ab1aef9b0f741a4df3184e3
extra : histedit_source : 2b2b5d506fd0e99788ebf7901bb19fbd8682b02e
2021-06-14 22:38:12 -04:00
Rob Lemley
e6b3059ecd
Backed out changeset 9c6e83848221 (bug 1682370) for Windows build failures. r=backout a=rjl
2021-06-17 19:48:34 -04:00
Gene Smith
de872baf69
Bug 1682370 - Discard/ignore IMAP lines received before before STARTTLS response. r=benc
2021-06-14 22:38:12 -04:00
Ben Campbell
f5d26bc87d
Bug 1643208 - Rename nsIMsgCopyService.copyFolders() to nsIMsgCopyService.copyFolder(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D117610
--HG--
extra : amend_source : c472b294931c52b86acfec6734a8b9e7a615f874
2021-06-15 16:59:21 +03:00
Ben Campbell
660ed07b28
Bug 1715433 - Use initial-lowercase-letter naming convention in nsIMsgCopyService. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D117256
--HG--
extra : amend_source : 9466d9ce3ff06bc5a7ca014c514d70e023b421b4
2021-06-09 12:57:51 +03:00
Geoff Lankow
60a1660d4d
Backed out changeset 805cd9bba5f6 (bug 1712986) due to bug 1705659 backout.
...
Also this landed with the wrong m-c bug number in the commit message.
2021-06-01 15:57:37 +12:00
Rob Lemley
5d02b8c220
Bug 1712986 - Port bug 1712971: Authentication code updates. r=darktrojan
...
Differential Revision: https://phabricator.services.mozilla.com/D116031
2021-05-26 23:40:33 +00:00
Ben Campbell
a1020954d6
Bug 1712025 - Tidy up an oddly-named variable in nsImapIncomingServer::PossibleImapMail(). r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D115559
--HG--
extra : amend_source : 4483a723e379adc5b4ae66a530f0989b6fc36383
2021-05-20 08:58:20 +03:00
Magnus Melin
a508668de2
Bug 1711670 - Port bug 1711078 to Thunderbird - Mark immutable nsIPrincipal fields as `const`. rs=bustage-fix DONTBUILD
...
Port of https://hg.mozilla.org/mozilla-central/rev/f8e166c5eb17
Differential Revision: https://phabricator.services.mozilla.com/D115354
--HG--
extra : amend_source : f1229691a118a45e3963aed8b3d543075f8c6cb2
2021-05-18 15:48:47 +03:00
Ben Campbell
1df0227998
Bug 1706387 - Make sure all mailnews nsIChannel implementations have loadInfo set. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D114911
--HG--
extra : amend_source : 0c3e551b1396d6cef6f9c84b58ca9d9553c29434
2021-05-12 13:26:20 +03:00
Magnus Melin
1a43a2fbe7
Bug 1694662 - adjust Thunderbird tests for changes in 1694662. rs=bustage-fix
...
--HG--
extra : amend_source : b73906c53e95d5f0b889012182f57964826e90f1
2021-05-01 13:54:55 +03:00
Magnus Melin
d12e06b2f5
Bug 1694662 - Port "Remove HTTP cache backing for AppCache" to Thunderbird. rs=bustage-fix
...
--HG--
extra : rebase_source : bfb3884feb85457f6a79dab0de2013ba3a3f05fd
2021-04-30 21:51:46 +03:00
Gene Smith
5c2abe79ee
Bug 1705765 - Fix regression to allow creation and rename of imap folders containing ascii ampersand. r=benc
2021-04-22 12:57:31 +03:00
Gene Smith
5384dd39ad
Bug 1690093 - Allow imap APPEND of folder to not yet authenticated account. r=BenB
...
--HG--
extra : histedit_source : d396bcfc2a8ff734571f22606e6633ff03d99282
2021-04-15 17:15:38 -04:00
Ben Campbell
aff1f4853d
Bug 1692919 - Remove leftover nsIArray helper BuildIdsAndKeyArray2() in nsImapMailFolder. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D112899
--HG--
extra : amend_source : d9b7a3e6d80618a11a259fd7886ff97707c1065b
2021-04-21 12:46:24 +03:00
Ben Campbell
5515c6f131
Bug 1704471 - Have nsISubscribableServer.getChildURIs() return an array rather than an enumerator. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D112134
Depends on D112129
2021-04-15 21:53:57 +00:00
Magnus Melin
f0da37f65c
Bug 1668926 - fix for "Using uninitialized value flagOperation" in nsImapOfflineSync::ProcessFlagOperation. r=benc
...
CID 450452 (#1 of 1): Uninitialized scalar variable (UNINIT)5. uninit_use: Using uninitialized value flagOperation
Differential Revision: https://phabricator.services.mozilla.com/D111613
--HG--
extra : rebase_source : 466bf728667444f7d14e4aa058a85480db0416c1
2021-04-11 15:11:58 +03:00
Magnus Melin
8e10e7e2ed
Bug 1668926 - fix "Using uninitialized value newFlags" issue in nsImapOfflineSync::ProcessFlagOperation. r=benc
...
CID 451007 (#1 of 1): Uninitialized scalar variable (UNINIT)6. uninit_use: Using uninitialized value newFlags.
Differential Revision: https://phabricator.services.mozilla.com/D111612
--HG--
extra : rebase_source : d01d64854d851952d88499c2febc873a3e4bc739
2021-04-11 14:54:30 +03:00
Magnus Melin
344a5435fc
Bug 1668926 - fix null pointer dereference in nsIMAPBodypartLeaf::ShouldFetchInline. r=benc
...
CID 1473460 (#1 of 1): Dereference before null check (REVERSE_INULL)check_after_deref: Null-checking this->m_parentPart suggests that it may be null, but it has already been dereferenced on all paths leading to the check
Differential Revision: https://phabricator.services.mozilla.com/D111618
--HG--
extra : rebase_source : 07c9056f9ce8c08784e0596d5b912a824583fa9f
2021-04-11 20:19:01 +03:00
Magnus Melin
4f24274521
Bug 1668926 - fix uninitialized members in nsImapBodyShell::nsImapBodyShell. r=benc
...
uninit_member: Non-static class member m_folderName is not initialized in this constructor nor in any functions that it calls.
uninit_member: Non-static class member m_showAttachmentsInline is not initialized in this constructor nor in any functions that it calls.
CID 1473470 (#3 of 3): Uninitialized scalar field (UNINIT_CTOR)9. uninit_member: Non-static class member m_contentModified is not initialized in this constructor nor in any functions that it calls.
Differential Revision: https://phabricator.services.mozilla.com/D111614
--HG--
extra : rebase_source : d4dab1f651879fb486573ee5b1348b82c884702c
2021-04-11 15:51:15 +03:00
Martin Giger
69907a5a50
Bug 1696659 - Replace uses of OS.* with IOUtils and friends. r=mkmelin
...
Except for chat's logger.jsm (and test), ext-compose.js (no IOUtils in extension API implementations)
and converterWorker (uses OS.File.open to read and write big files).
Differential Revision: https://phabricator.services.mozilla.com/D111298
--HG--
extra : moz-landing-system : lando
2021-04-12 22:54:06 +00:00
Magnus Melin
b02c872895
Bug 1678109 - get rid of the mailnews IOUtils.jsm module. r=freaktechnik
...
Differential Revision: https://phabricator.services.mozilla.com/D108933
--HG--
extra : rebase_source : d8bd49f8dd04b4b142c9975fe18a422da89587e9
2021-03-18 14:28:05 +02:00
Magnus Melin
40f55a133b
Bug 1518536 - remove most of iteratorUtils.jsm usage. r=benc
...
Differential Revision: https://phabricator.services.mozilla.com/D109083
--HG--
extra : rebase_source : 6baaec6ef5e4918ca1ff76b16b8ed8d8b034cce9
2021-03-24 12:49:43 +02:00
Ben Campbell
1521d401a3
Bug 1602326 - Tidy up error handling for callers of nsIMsgFolder.getOfflineFileStream(). r=mkmelin
...
Biggest churn is in nsImapMockChannel::ReadFromLocalCache() - this patch
switches it to use NS_ENSURE_SUCCESS() early-outs rather than big nested
if (NS_SUCCEEDED(rv))... clauses.
2021-03-12 12:50:34 +02:00
Ben Campbell
39fe2d503a
Bug 1697658 - Port bug 1634281 - Replace nsDataHashtable with nsTHashMap. rs=bustage-fix r=darktrojan
...
Differential Revision: https://phabricator.services.mozilla.com/D107951
--HG--
extra : moz-landing-system : lando
2021-03-11 00:46:30 +00:00
Ben Campbell
667c7ade15
Bug 1602326 - Make sure nsIMsgFolder.getOfflineFileStream() returns a stream or an error code. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D107308
--HG--
extra : moz-landing-system : lando
2021-03-10 09:44:06 +00:00
Emilio Cobos Álvarez
dd6e002e7b
Bug 1696776 - Plumb failed security info around from the smtp service, so that the dialog actually has the right cert. r=rnons
2021-03-07 01:20:45 +01:00
Magnus Melin
778c608f67
Bug 1695274 - followup - clang-format. rs=clang-format
2021-03-01 18:59:57 +02:00
Rob Lemley
c39dd2bbb3
Bug 1695274 - Port bug 1691913: More bustage fixes. rs=bustage-fix
...
--HG--
extra : amend_source : 76bee10b881e1d858bcc30cb4aa7e20ffc20dc43
extra : histedit_source : 505498ff88f4d21ac2db51db7abad5bbe3f6a4df
2021-02-26 16:11:08 -05:00
Alessandro Castellani
98b717ed89
Bug 1695274 - Port bug 1691913: Rename nsBaseHashtable::Put to InsertOrUpdate. r=mkmelin
...
--HG--
extra : histedit_source : 41e749b241430122b5e877122194dbc6cf018b73
2021-02-26 10:23:03 -08:00
Richard Marti
79757af9de
Bug 1695274 - Port bug 1691913: Rename nsBaseHashtable::Put to InsertOrUpdate. r=aleca,rjl
...
--HG--
extra : histedit_source : 01dc507d9c91c23ca95f6b1624deecb1bf9c908f
2021-02-26 18:26:46 +01:00
Ben Campbell
0169d0e2e3
Bug 1682942 - Replace nsISimpleEnumerator message enumeration in nsIMsgDBView, nsIMsgFolder and nsIMsgDatabase. r=mkmelin
...
Added an equivalent class - nsIMsgEnumerator - which still has the same
getNext()/hasMoreElements() methods as nsISimpleEnumerator. However, this new
getNext() returns nsIMsgHdr objects directly, rather than nsISupports, so
callers don't have to jump through extra QI hoops.
2021-02-26 12:41:47 +02:00
Henry Wilkes
e5bf5649cf
Bug 1667338 - Switch url from out parameter to return value in nsIMsgMessageService.GetUrlForUri. r=mkmelin
...
A return value is more convenient for calling in javascript.
Also renamed interface definition from GetUrlForUri to getUrlForUri to conform to javascript naming conventions.
Differential Revision: https://phabricator.services.mozilla.com/D106271
--HG--
extra : amend_source : 7ff0c6889942d16dff1e87c25c1d04b195373f64
2021-02-26 12:34:20 +02:00
Ben Campbell
d12d30fb7e
Bug 1682942 - Use JS iterable protocol instead of nsISimpleEnumerator for nsIMsgDatabase.EnumerateMessages() calls. r=mkmelin
2021-02-19 11:00:03 +13:00
Geoff Lankow
7b9a707751
Port bug 1678255 - Add new argument to nsIExternalProtocolService.LoadURI calls. rs=bustage-fix
2021-02-23 17:51:20 +13:00
ISHIKAWA, Chiaki
1db1b0f3a1
Bug 1596036: Check GetOfflineFileStream() return value always first. r=benc
2021-02-22 22:35:57 +13:00
Magnus Melin
4347b17567
Bug 1692610 - follow-up to clang format. rs=clang-format
...
Also from some other bugs...
2021-02-21 12:49:43 +02:00
Ben Campbell
db2a48bb1e
Bug 1692919 - Remove leftover MsgGetHeadersFromKeys2() helper (added for Bug 1583030). r=mkmelin
2021-02-17 13:02:31 +02:00
Ben Campbell
5afc64da10
Bug 1682941 - Remove nsISimpleEnumerator from nsIMsgFolder.subFolders property. r=mkmelin
2021-02-12 21:31:17 +13:00
Rob Lemley
c9a297627a
Bug 1692610 - Port bug 1690615: Update calls to createTransport. rs=bustage-fix
...
--HG--
extra : rebase_source : bfff07ef55fb0cf177456f2983aba693127c54ee
2021-02-12 17:54:17 -05:00
Ben Campbell
a3199d0143
Bug 1664572 - Remove cruft in nsImapIncomingServer::DeleteNonVerifiedFolders(). r=mkmelin
2021-02-12 22:29:57 +02:00
Gene Smith
edc13af1e3
Bug 1688782 - Change encoding from MUTF-7 to UTF-8 if necessary when running EnsureExists URL. r=benc
2021-02-01 16:03:07 -05:00
Geoff Lankow
77781cf2b4
Bug 1687847 - Set nsIChannel::DISPOSITION_ATTACHMENT on newsgroup attachments too. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D103733
--HG--
extra : amend_source : 03347e53d031693bf0e94694cdd24f079c0deef3
2021-02-02 12:30:58 +02:00
Gene Smith
07a99d0475
Bug 1618455 - Change the imap append timeout from hardcoded 20s to 1/5th of mailnews.tcptimeout. r=mkmelin
2021-02-02 12:28:05 +02:00
Klaus B
0a6f9184ed
Bug 1687727 - Fixes to IMAP folder name encoding. r=benc
...
Fix code issues from bug 1571672 (rev. 0054ea73e658).
Fixed trash folder selection of folder with non-ASCII name on server without UTF8=ACCEPT capability.
Introduce nsIMsgImapMailFolder.shouldUseUtf8FolderName and use where needed.
Replace heuristic in am-server.js.
Remove or correct comments related to MUTF-7/UTF-8.
2021-01-25 12:55:15 +02:00
Klaus B
3a87589a7b
Bug 1687727 - Unify spelling of UTF-8 and MUTF-7 in IMAP code. r=benc
2021-01-25 12:54:35 +02:00
Geoff Lankow
aa3f56a5df
Bug 1687847 - Set nsIChannel::DISPOSITION_ATTACHMENT on attachments so they open when expected. r=mkmelin
...
The presence of this flag forces a docShell to pass loading onto the external helper app service. In some special cases we don't want this, so I've white-listed certain content types.
Differential Revision: https://phabricator.services.mozilla.com/D102892
--HG--
extra : moz-landing-system : lando
2021-01-25 09:19:28 +00:00
Klaus B
b3bfd88458
Bug 1580262 - Move assigning null byte. r=benc
2021-01-25 14:37:31 +13:00
Klaus B.
bf56e5a82c
Bug 1580262 - Fix off by one in nsImapUrl::unescapeSlashes. r=mkmelin,emilio
2021-01-24 00:43:41 +01:00
Klaus B
5e2a193b81
Bug 1580262 - Add a more robust nsImapUrl::UnescapeSlashes(). r=mkmelin
2021-01-23 12:48:12 +02:00
Ben Campbell
edcd3030b5
Bug 1687412 - Fix up string types in folder creation to better handle unicode URIs. r=mkmelin
2021-01-21 12:47:10 +02:00
Ben Campbell
6bc9041f3e
Bug 1687542 - Replace nsMsgKeyArray with nsTArray<nsMsgKey>. r=mkmelin
2021-01-20 21:24:27 +02:00
Klaus B
8ca094cd70
Bug 1686034 - Follow-up: Simplify string processing. r=mkmelin
2021-01-19 12:56:27 +02:00
Ping Chen
fc61427cdc
Bug 1686034 - Use AUTF8String for uri attribute/arguments to support non-ASCII msg folder. r=mkmelin
...
The problem is since bug 1571672, mailbox file can be non-ASCII, as a result msg uri is non-ASCII. But the functions for querying msg from an URI still only accepts char*.
Main changes are three idl files:
nsIMsgMailNewsUrl.idl: to fix msgHdr
nsIMsgMailSeesion.idl: to fix view source
nsIMsgMessageService.idl: to fix save as
Other changes are to make it compile.
Differential Revision: https://phabricator.services.mozilla.com/D101706
2021-01-19 12:56:14 +02:00
Ben Campbell
125a96b9f1
Bug 1682941 - Remove redundant nsIMsgFolder::GetMessages() implementations. r=mkmelin
...
nsImapMailFolder, nsLocalMailFolder and nsNewsFolder all had their own
GetMessages() which all did exactly the same thing.
2021-01-18 12:29:33 +02:00
Ben Campbell
75aaa96983
Bug 1683549 - Remove redundant m_message member from nsImapMailCopyState. r=mkmelin
2021-01-13 12:57:04 +02:00
Ben Campbell
6abbe6d259
Bug 1683549 - Remove redundant m_totalCount member from nsImapMailCopyState. r=mkmelin
2021-01-13 12:56:45 +02:00
Ben Campbell
248545d735
Bug 1683549 - Tidy away some unnecessary QI casting in nsImapMailFolder message copying. r=mkmelin
2021-01-13 12:54:53 +02:00
Ping Chen
a2bceb1659
Bug 944367 - Replace all Log.jsm usages with console.createInstance. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D100226
--HG--
extra : moz-landing-system : lando
2020-12-26 20:04:18 +00:00
Gene Smith
946d1b476f
Bug 1676141 - Add an alert for non-overridable TLS errors. r=benc
2020-12-19 12:23:13 +02:00
Gene Smith
4af22df686
Bug 1622640 - (CVE-2020-15685) Preclude malicious STARTTLS response injections. r=benc
2020-12-18 12:15:03 +02:00
Ben Campbell
ee79f6c3fd
Bug 1681009 - Remove nsIMutableArray use from nsIMsgMailView, nsIMsgFilter and nsIMsgSearchSession. r=mkmelin
2020-12-07 17:26:44 +13:00
Ben Campbell
a09229121a
Bug 1612239 - Remove nsIArray usage from nsIMsgFolder. r=mkmelin
...
--HG--
extra : amend_source : 5c6bd195120cd6ded0571a3ec88a6575020f9ed2
2020-12-03 13:41:57 +13:00
Ben Campbell
8abe3ca335
Bug 1612245 - Remove nsIArray usage from nsIAutoSyncState. r=mkmelin
2020-12-04 12:48:50 +02:00
Ben Campbell
7ef33cbbeb
Bug 1612239 - Remove nsIArray usage in nsIMsgFolder.DownloadMessagesForOffline(). r=mkmelin
2020-11-30 12:39:19 +02:00
Ben Campbell
bfc7644683
Bug 1612239 - Remove nsIArray usage in nsIMsgCopyService.CopyMessages(). r=mkmelin
2020-11-29 12:51:55 +02:00
Magnus Melin
8ff6c815af
Bug 73387 - rename IMAP files and classes to be consistently Imap. r=gds
...
# nsIIMAPHostSessionList
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -exec sed -i -E 's/nsIIMAPHostSessionList/nsIImapHostSessionList/g' {} \;
# nsIMAPNamespace
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -exec sed -i -E 's/nsIMAPNamespace/nsImapNamespace/g' {} \;
# nsIMAPGenericParser
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -exec sed -i -E 's/nsIMAPGenericParser/nsImapGenericParser/g' {} \;
# nsIMAPHostSessionList
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -exec sed -i -E 's/nsIMAPHostSessionList/nsImapHostSessionList/g' {} \;
# nsIMAPBodyShell
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -exec sed -i -E 's/nsIMAPBodyShell/nsImapBodyShell/g' {} \;
--HG--
rename : mailnews/imap/public/nsIIMAPHostSessionList.h => mailnews/imap/public/nsIImapHostSessionList.h
rename : mailnews/imap/src/nsIMAPBodyShell.cpp => mailnews/imap/src/nsImapBodyShell.cpp
rename : mailnews/imap/src/nsIMAPBodyShell.h => mailnews/imap/src/nsImapBodyShell.h
rename : mailnews/imap/src/nsIMAPGenericParser.cpp => mailnews/imap/src/nsImapGenericParser.cpp
rename : mailnews/imap/src/nsIMAPGenericParser.h => mailnews/imap/src/nsImapGenericParser.h
rename : mailnews/imap/src/nsIMAPHostSessionList.cpp => mailnews/imap/src/nsImapHostSessionList.cpp
rename : mailnews/imap/src/nsIMAPHostSessionList.h => mailnews/imap/src/nsImapHostSessionList.h
rename : mailnews/imap/src/nsIMAPNamespace.cpp => mailnews/imap/src/nsImapNamespace.cpp
rename : mailnews/imap/src/nsIMAPNamespace.h => mailnews/imap/src/nsImapNamespace.h
2020-11-26 11:43:35 +02:00
Magnus Melin
938ba4544d
Bug 1679148 - fix includes to unbust builds after bug 1673931. r=bustage-fix
2020-11-24 23:46:27 +02:00
Ben Campbell
bbe5eca289
Bug 1586494 - Release nsImapMailCopyState directly after IMAP copy to fix shutdown crash. r=mkmelin
...
There's a degree of speculation involved in this patch :-)
From the crash logs, it looks like it all falls apart because of an nsImapUrl
which is holding onto a pointer to an nsImapMailCopyState object and being
released the IMAP thread. (the nsImapUrl in turn is being held by the
nsImapProtocol object which inhabits the IMAP thread).
I think it happens because some references (possibly cyclic) are being held on
past the end of the copy operation. And this patch helps by disconnecting the
nsImapMailCopyState from the nsImapUrl after a copy.
It's all a bit twisty - the copy-related code is fantastically convoluted.
This patch it clears out the copyState attribute on the nsImapUrl, which is
sometimes an nsImapMailCopyState, but sometimes not. The fix in a slightly
ugly place, but it was the only place I was confident of being inside an
operation where copyState is an nsImapMailCopyState and not something else!
2020-11-19 12:18:09 +13:00
Ping Chen
d3f2d3ae4d
Bug 1671880 - Part 2: Remove charset attribute from msg folder. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D97110
--HG--
extra : amend_source : 4cd4e5518281266aaca3ae51daad1636e977ddef
2020-11-19 14:38:45 +02:00
Ben Campbell
07e1ef8693
Bug 1676320 - Rename nsICopyMsgStreamListener.idl to match nsICopyMessageStreamListener. r=mkmelin
...
--HG--
rename : mailnews/base/public/nsICopyMsgStreamListener.idl => mailnews/base/public/nsICopyMessageStreamListener.idl
2020-11-10 12:42:49 +02:00
Ben Campbell
5d1c166ed3
Bug 1612237 - Rename nsIMsgFilterCustomAction.apply() to applyAction(). r=mkmelin
2020-11-09 08:46:26 +02:00
Ben Campbell
865c628072
Bug 1612237 - Remove nsIArray use in nsIMsgFilterCustomAction.apply(). r=mkmelin
2020-11-09 08:46:08 +02:00
Rob Lemley
74c6535302
Bug 1672798 - Run black formatting on mozbuild and mozconfigure files. r=mkmelin
...
Bringing some sanity to our Python scripts.
Differential Revision: https://phabricator.services.mozilla.com/D95402
--HG--
extra : rebase_source : 7eed46d79663fa1f261bd64d9bc1c83c4867bfc4
extra : histedit_source : b8b700c76ab2fee92eb426b5a5b69dc86376e60f
2020-10-30 14:28:33 -04:00
Ben Campbell
149dbb2b09
Bug 1674077 - Move IMAP GUI stringbundle access to main thread. r=mkmelin
2020-11-05 12:12:19 +02:00
Gene Smith
7ee88ad010
Bug 1671806 - Avoid IMAP log "... is resumed/has been resumed" when no suspend occurred. r=mkmelin
2020-10-19 12:46:45 +03:00
Magnus Melin
dacddff1a0
Bug 217434 - followup - apply clang-format. rs=clang-format
2020-10-16 13:50:12 +03:00
Daniel Le
39749fb540
Bug 217434 - nsImapMockChannel supports Suspend and Resume. r=BenC DONTBUILD
...
Per suggestions at https://bugzilla.mozilla.org/show_bug.cgi?id=217434#c5 :
- nsImapMockChannel::Suspend sets mSuspended
- nsImapMockChannel::{Resume,Cancel} unset mSuspended and notify the
associated nsImapProtocol thread that waits on mSuspendedMonitor
- nsImapProtocol::CreateNewLineFromSocket is blocked until the
associated m_mockChannel is resumed (or cancelled)
Differential Revision: https://phabricator.services.mozilla.com/D92343
--HG--
extra : rebase_source : 5537abe90b07d2f2af5525552193911debfeea15
extra : amend_source : 68697aea2e1f0369c0d277810830693e1e4bb2f2
2020-10-16 13:39:54 +03:00
Ping Chen
9632f42ffd
Bug 1211292 - Return Promise in nsIMsgSend and nsIMsgCompose. r=mkmelin
2020-10-16 13:36:07 +03:00
Magnus Melin
10eba65ee2
Backed out changeset 5c87be1d969d (bug 1211292) for windows build failures. r=me DONTBUILD
2020-10-15 13:57:12 +03:00
Ping Chen
cf55b5ae33
Bug 1211292 - Return Promise in nsIMsgSend and nsIMsgCompose. r=mkmelin DONTBUILD
2020-10-15 12:28:44 +03:00
Magnus Melin
3f12e880ef
Bug 1668926 - fix null pointer dereference in nsImapProtocol::RenameHierarchyByHand. r=gene
...
CID 1260145 (#1 of 1): Dereference after null check (FORWARD_NULL)18. var_deref_model: Passing null pointer currentName to RenameMailboxRespectingSubscriptions, which dereferences it.
2020-10-12 13:52:37 +03:00
Magnus Melin
1f7fbf3442
Bug 1668926 - fix null pointer dereference in nsImapProtocol::DiscoverAllAndSubscribedBoxes. r=gene
...
CID 450532 (#1 of 1): Dereference after null check (FORWARD_NULL)
41. var_deref_model: Passing null pointer ns to GetPrefix, which dereferences it
I.e. ns->GetPrefix would crash if ns was null
2020-10-12 13:52:28 +03:00
Magnus Melin
7784ba1d6f
Bug 1668926 - remove dead code (userCancelled). r=gene
...
CID 1260144 (#1 of 1): 'Constant' variable guards dead code (DEADCODE)
2020-10-12 13:52:20 +03:00
Magnus Melin
84991336f0
Bug 1661560 - don't assert-crash on LoadImapURL failures which can happen especially in tests if the server was removed mid flight. r=gene
2020-10-10 13:51:29 +03:00
Gene Smith
781317a7df
Bug 1571672 - Add support for imap capability UTF8=ACCEPT (RFC 6855). r=mkmelin
2020-10-07 22:51:37 +03:00
Kai Engert
b37544ac51
Bug 1667120 - Prevent null pointer crash in nsImapProtocol::CreateNewLineFromSocket. r=mkmelin DONTBUILD
...
--HG--
extra : amend_source : ae38c938b81fba5967092ab546a9fbc0139f21ef
2020-09-24 19:48:27 +02:00
Ben Campbell
0d2ba8fa67
Bug 1612239 - nsIArray removal in nsIMsgFolder.deleteSubFolders(). r=mkmelin
...
--HG--
extra : rebase_source : 33a234282db6b2b339d4ecd0f78ddc8a883a0e38
2020-09-18 13:17:23 +03:00
Ben Campbell ext:(%2C%20Khushil%20Mistry%20%3Ckhushil324%40gmail.com%3E%2C%20Magnus%20Melin%20%3Cmkmelin%2Bmozilla%40iki.fi%3E)
7b7fa274d4
Bug 1590473 - Add failedSecInfo attr to nsIMsgMailNewsUrl for bad-cert handling on IMAP & POP3 and fix account setup for self-signed certificates. r=mkmelin
2020-09-17 20:25:02 +03:00
Magnus Melin
0600293a65
Bug 1664858 - followup - allow null messages arg to nsImapMailFolder::InitCopyState. rs=test-bustage-fix
...
comm/mailnews/db/gloda/test/unit/test_index_messages_imap_online.js showed failures
2020-09-16 16:07:19 +03:00
Magnus Melin
b498142eea
Bug 1664858 - fix Crash in [@ MsgHdrsToTArray]. r=benc DONTBUILD
2020-09-15 13:56:48 +03:00
Mark Banner
8154f3e47f
Bug 810814 - Enable opening pdf attachments within Thunderbird. r=mkmelin
...
Differential Revision: https://phabricator.services.mozilla.com/D86538
--HG--
extra : moz-landing-system : lando
2020-08-16 11:54:11 +00:00
Ben Campbell
f82e33ba2e
Bug 1586494 - Remove redundant code in nsImapMailCopyState dtor. r=mkmelin
2020-08-10 23:16:18 +03:00
Joshua Cranmer
1862f41cb1
Bug 875059, part 6: Move mailnews/base/util to mailnews/base/src. r=mkmelin
...
Depends on D85674
Differential Revision: https://phabricator.services.mozilla.com/D85675
--HG--
rename : mailnews/base/util/ABQueryUtils.jsm => mailnews/base/src/ABQueryUtils.jsm
rename : mailnews/base/util/ErrUtils.jsm => mailnews/base/src/ErrUtils.jsm
rename : mailnews/base/util/IOUtils.jsm => mailnews/base/src/IOUtils.jsm
rename : mailnews/base/util/JXON.jsm => mailnews/base/src/JXON.jsm
rename : mailnews/base/util/JsTreeSelection.jsm => mailnews/base/src/JsTreeSelection.jsm
rename : mailnews/base/util/MailServices.jsm => mailnews/base/src/MailServices.jsm
rename : mailnews/base/util/MailnewsMigrator.jsm => mailnews/base/src/MailnewsMigrator.jsm
rename : mailnews/base/util/MsgDBCacheManager.jsm => mailnews/base/src/MsgDBCacheManager.jsm
rename : mailnews/base/util/OAuth2.jsm => mailnews/base/src/OAuth2.jsm
rename : mailnews/base/util/OAuth2Providers.jsm => mailnews/base/src/OAuth2Providers.jsm
rename : mailnews/base/util/ServiceList.h => mailnews/base/src/ServiceList.h
rename : mailnews/base/util/Services.cpp => mailnews/base/src/Services.cpp
rename : mailnews/base/util/Services.h => mailnews/base/src/Services.h
rename : mailnews/base/util/TemplateUtils.jsm => mailnews/base/src/TemplateUtils.jsm
rename : mailnews/base/util/TraceHelper.jsm => mailnews/base/src/TraceHelper.jsm
rename : mailnews/base/util/converterWorker.js => mailnews/base/src/converterWorker.js
rename : mailnews/base/util/folderUtils.jsm => mailnews/base/src/folderUtils.jsm
rename : mailnews/base/util/hostnameUtils.jsm => mailnews/base/src/hostnameUtils.jsm
rename : mailnews/base/util/iteratorUtils.jsm => mailnews/base/src/iteratorUtils.jsm
rename : mailnews/base/util/mailstoreConverter.jsm => mailnews/base/src/mailstoreConverter.jsm
rename : mailnews/base/util/nsImapMoveCoalescer.cpp => mailnews/base/src/nsImapMoveCoalescer.cpp
rename : mailnews/base/util/nsImapMoveCoalescer.h => mailnews/base/src/nsImapMoveCoalescer.h
rename : mailnews/base/util/nsMsgCompressIStream.cpp => mailnews/base/src/nsMsgCompressIStream.cpp
rename : mailnews/base/util/nsMsgCompressIStream.h => mailnews/base/src/nsMsgCompressIStream.h
rename : mailnews/base/util/nsMsgCompressOStream.cpp => mailnews/base/src/nsMsgCompressOStream.cpp
rename : mailnews/base/util/nsMsgCompressOStream.h => mailnews/base/src/nsMsgCompressOStream.h
rename : mailnews/base/util/nsMsgDBFolder.cpp => mailnews/base/src/nsMsgDBFolder.cpp
rename : mailnews/base/util/nsMsgDBFolder.h => mailnews/base/src/nsMsgDBFolder.h
rename : mailnews/base/util/nsMsgFileStream.cpp => mailnews/base/src/nsMsgFileStream.cpp
rename : mailnews/base/util/nsMsgFileStream.h => mailnews/base/src/nsMsgFileStream.h
rename : mailnews/base/util/nsMsgI18N.cpp => mailnews/base/src/nsMsgI18N.cpp
rename : mailnews/base/util/nsMsgI18N.h => mailnews/base/src/nsMsgI18N.h
rename : mailnews/base/util/nsMsgIdentity.cpp => mailnews/base/src/nsMsgIdentity.cpp
rename : mailnews/base/util/nsMsgIdentity.h => mailnews/base/src/nsMsgIdentity.h
rename : mailnews/base/util/nsMsgIncomingServer.cpp => mailnews/base/src/nsMsgIncomingServer.cpp
rename : mailnews/base/util/nsMsgIncomingServer.h => mailnews/base/src/nsMsgIncomingServer.h
rename : mailnews/base/util/nsMsgKeyArray.cpp => mailnews/base/src/nsMsgKeyArray.cpp
rename : mailnews/base/util/nsMsgKeyArray.h => mailnews/base/src/nsMsgKeyArray.h
rename : mailnews/base/util/nsMsgKeySet.cpp => mailnews/base/src/nsMsgKeySet.cpp
rename : mailnews/base/util/nsMsgKeySet.h => mailnews/base/src/nsMsgKeySet.h
rename : mailnews/base/util/nsMsgLineBuffer.cpp => mailnews/base/src/nsMsgLineBuffer.cpp
rename : mailnews/base/util/nsMsgLineBuffer.h => mailnews/base/src/nsMsgLineBuffer.h
rename : mailnews/base/util/nsMsgMailNewsUrl.cpp => mailnews/base/src/nsMsgMailNewsUrl.cpp
rename : mailnews/base/util/nsMsgMailNewsUrl.h => mailnews/base/src/nsMsgMailNewsUrl.h
rename : mailnews/base/util/nsMsgProtocol.cpp => mailnews/base/src/nsMsgProtocol.cpp
rename : mailnews/base/util/nsMsgProtocol.h => mailnews/base/src/nsMsgProtocol.h
rename : mailnews/base/util/nsMsgReadStateTxn.cpp => mailnews/base/src/nsMsgReadStateTxn.cpp
rename : mailnews/base/util/nsMsgReadStateTxn.h => mailnews/base/src/nsMsgReadStateTxn.h
rename : mailnews/base/util/nsMsgTxn.cpp => mailnews/base/src/nsMsgTxn.cpp
rename : mailnews/base/util/nsMsgTxn.h => mailnews/base/src/nsMsgTxn.h
rename : mailnews/base/util/nsMsgUtils.cpp => mailnews/base/src/nsMsgUtils.cpp
rename : mailnews/base/util/nsMsgUtils.h => mailnews/base/src/nsMsgUtils.h
rename : mailnews/base/util/nsNewMailnewsURI.cpp => mailnews/base/src/nsNewMailnewsURI.cpp
rename : mailnews/base/util/nsNewMailnewsURI.h => mailnews/base/src/nsNewMailnewsURI.h
rename : mailnews/base/util/nsStopwatch.cpp => mailnews/base/src/nsStopwatch.cpp
rename : mailnews/base/util/nsStopwatch.h => mailnews/base/src/nsStopwatch.h
extra : moz-landing-system : lando
2020-08-04 20:15:39 +00:00
Magnus Melin
c897bc5680
Bug 1653118 - followup - clang-format. rs=clang-format
...
Possibly not all caused this bug
2020-08-07 23:17:19 +03:00
Richard Marti
cf003fb7b5
Bug 1657436 - Port bug 1528649: Remove the context parameter from nsInputStreamPump::AsyncRead. DONTBUILD r=rjl
2020-08-05 20:11:25 +02:00
Ben Campbell
8dc57157bf
Bug 1612239 - nsIArray removal in nsIMsgFolder addKeywordsToMessages()/removeKeywordsFromMessages(). r=mkmelin DONTBUILD
2020-07-20 17:02:48 +12:00
aceman
43ee2f80ee
Bug 1655132 - printf nsresult using PRIx32 and static_cast in a few places in nsImapProtocol.cpp. r=mkmelin
2020-07-28 09:32:01 -07:00
Ben Campbell
79cebb76dd
Bug 1590473 - IMAP fix to avoid login attempt if connection is broken. r=mkmelin DONTBUILD
2020-07-26 09:55:11 +03:00
Gene Smith
9b4acea337
Bug 1654995 - Chunk starting offset wrong after m_chunkSize changes. r=mkmelin
...
This caused some attachments to have missing data.
2020-07-26 09:53:54 +03:00
Gene Smith
9f453dd597
Bug 1611624 - Ensure all imap capabilities are known after authentication (support IDLE for iCloud). r=mkmelin DONTBUILD
...
At least one popular imap server (Apple's iCloud) fails to reveal its
full capability set in the initial greeting and with authentication.
This caused an iCloud user to notice that IMAP idle was not working so
immediate notification of received messages never occurred in TB.
This patch causes capabilties to be explicitly requested if they are
not returned as part of the authentication response to ensure that
IDLE and other important capabilities are know and used in TB.
The additional capability request is added to the CLIENTID unit test since
"fakeserver" behaves in this respect the same way as iCloud.
2020-07-22 12:57:04 +03:00
Magnus Melin
5edba8a2dd
Bug 1651165 - Rename nsIIdleService to nsIUserIdleService in Thunderbird code. rs=bustage-fix
...
Port https://hg.mozilla.org/mozilla-central/rev/2a646a7936e7
2020-07-21 15:07:03 +03:00
Ben Campbell
a1a8e33ae7
Bug 1590473 - Fix upward propagation of IMAP read errors (e.g. SSL bad cert). r=mkmelin
2020-07-21 13:48:44 +03:00
Magnus Melin
8f90c0c70c
Backed out changeset 7cdeeeff5f4d (bug 1611624) for test failures in comm/mailnews/imap/test/unit/test_imapClientid.js. r=backout
2020-07-20 23:41:30 +03:00
Gene Smith
771b880a26
Bug 1611624 - Ensure all imap capabilities are known after authentication. r=mkmelin
...
At least one popular imap server (Apple's iCloud) fails to reveal its
full capability set in the initial greeting and with authentication.
This caused an iCloud user to notice that IMAP idle was not working so
immediate notification of received messages never occurred in TB.
This patch causes capabilties to be explicitly requested if they are
not returned as part of the authentication response to ensure that
IDLE and other important capabilities are know and used in TB.
2020-07-20 21:23:35 +03:00
Alessandro Castellani
d8dd202c6c
Bug 1653118 - Port bug 1366973 - Rename security flags within nsILoadInfo to not contain '_DATA_'. rs=bustage-fix
...
--HG--
extra : amend_source : 5a49356a43141f3f622db2de96100ec8649fac50
2020-07-15 15:41:10 -07:00
Geoff Lankow
0a60d34265
Bug 1652371 - Port bug 1649221 and bug 1649554. rs=bustage-fix CLOSED TREE
...
--HG--
extra : amend_source : cfc6361ee102cb0ee2e0c5b3497ec4a9b71688ca
2020-07-13 11:45:03 +12:00
Geoff Lankow
9e8f8a48c3
Bug 1651536 - Fix build bustage: 'base/process_util.h' file not found. rs=bustage-fix
2020-07-09 11:35:55 +12:00
Geoff Lankow
53ccb07a4a
Bug 1651271 - Fix test_converterImap.js by ignoring the erroneous deprecation warning it produces. rs=bustage-fix DONTBUILD
...
--HG--
extra : amend_source : 109bff73bb21ed417e5a42e8784a13908bf15509
2020-07-08 15:07:32 +12:00
Magnus Melin
7336730297
Bug 1648802 - Replace Thunderbird constant uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros . r=sg
...
# NS_LITERAL_CSTRING(ABC) -> nsLiteralCString(ABC)
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -regex ".*\.\(c\|h\|cpp\|mm\)$" -exec sed -i -E 's/NS_LITERAL_CSTRING\(([^\)]*)\)/nsLiteralCString(\1)/g' {} \;
# NS_LITERAL_STRING(FOO) -> NS_LITERAL_STRING_FROM_CSTRING(FOO)
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -regex ".*\.\(c\|h\|cpp\|mm\)$" -exec sed -i -E 's/NS_LITERAL_STRING\(([^\)]*)\)/NS_LITERAL_STRING_FROM_CSTRING(\1)/g' {} \;
+ some manual adjustments
+ clang-format
2020-07-03 20:34:57 +03:00
Ping Chen
b3ca7aea8c
Bug 1636665 - Support petabyte in imap folder quote size and percentage calculations. r=mkmelin
2020-07-02 19:23:43 +03:00
Magnus Melin
ebdfde4d2e
Bug 1648802 - Replace Thunderbird uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals.. r=sg
...
compare https://phabricator.services.mozilla.com/D80861#change-Yu2oZ2Beo1MA
# NS_LITERAL_CSTRING("foo") -> "foo"_ns
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -regex ".*\.\(c\|h\|cpp\|mm\)$" -exec sed -i -E 's/NS_LITERAL_CSTRING\("([^\)]+)"\)/"\1"_ns/g' {} \;
# NS_LITERAL_STRING("foo") -> u"foo"_ns
find . -type f -not -path "*.hg/*" -not -path "third_party/*" -regex ".*\.\(c\|h\|cpp\|mm\)$" -exec sed -i -E 's/NS_LITERAL_STRING\("([^\)]+)"\)/u"\1"_ns/g' {} \;
+ manual replacements at least in
mailnews/imap/src/nsImapService.cpp
mailnews/local/src/nsPop3Sink.cpp
mailnews/extensions/fts3/src/nsFts3Tokenizer.cpp
mailnews/base/test/TestMsgStripRE.cpp
mailnews/base/util/nsMsgIncomingServer.cpp
mailnews/base/util/nsMsgDBFolder.cpp
mailnews/mime/src/mimemult.cpp
mailnews/mime/src/mimethtm.cpp
mailnews/compose/src/nsMsgCompose.cpp
mailnews/import/text/src/nsTextImport.cpp
mailnews/import/outlook/src/nsOutlookMail.cpp
mailnews/import/winlivemail/nsWMUtils.cpp
mailnews/import/becky/src/nsBeckyUtils.cpp
mailnews/extensions/smime/src/nsCertPicker.cpp
calendar/base/backend/libical/calUtils.cpp
suite/components/shell/nsWindowsShellService.cpp
mail/components/search/nsMailWinSearchHelper.cpp
+ clang-format
2020-07-01 16:15:43 +03:00
Magnus Melin
1ff29ab2c2
Bug 1648802 - preparation patch - clang-format. rs=clang-format. DONTBUILD
2020-07-01 16:09:58 +03:00
Jorg K
93db6b3c14
Bug 1647104 - Fix typos in chat, common, db, editor, mail, mailnews found with codespell. rs=comment-only,typo-fix r=mkmelin DONTBUILD
...
This excludes OpenPGP code in mail/extensions.
2020-06-21 20:27:10 +02:00
Kai Engert
6c7626bd9a
Bug 1647104 - Backed out changeset 9ca3551392f6. a=mkmelin
2020-06-22 14:09:32 +02:00
longsonr
94487559be
Bug 1580480 - Fix IMAP fetch chunk size so that it adjusts based on network bandwidth. Reverts an inadvertent change from bug 773782. r=mkmelin DONTBUILD
2020-06-22 13:32:12 +03:00
Jorg K
1a94f7447e
Bug 1647104 - Fix typos in chat, common, db, editor, mail, mailnews found with codespell. rs=comment-only,typo-fix DONTBUILD
2020-06-21 20:27:10 +02:00
Ben Campbell
edb8e187f9
Bug 1643561 - Reformat C++ to M-C clang-format rules (mainly PointerAlignment: Left). rs=mkmelin
...
--HG--
extra : rebase_source : b016214d8010531b3e277be07bdccbbbf1637e29
extra : amend_source : c056647392ab31b921b4d19029e694391ffd1894
2020-06-20 10:26:35 +12:00
Ben Campbell
9d992aa957
Bug 1612239 - Remove nsIArray use in nsIMsgFolder markMessagesRead, markMessagesFlagged, setLabelForMessages, setJunkScoreForMessages. r=mkmelin
2020-06-05 23:47:16 +12:00
Ben Campbell
adf336206c
Bug 1612239 - Remove nsIArray usage from nsIMsgFolder.getFoldersWithFlags(). r=mkmelin
2020-06-05 23:24:18 +03:00
Ben Campbell
fbb3a9701a
Bug 1612239 - Remove nsIArray use from nsIMsgCopyService.copyFolders. r=mkmelin
2020-06-04 22:36:27 +03:00
Magnus Melin
771b2328aa
Bug 1642966 - Port bug 1606797 to Thunderbird (nsIExternalProtocolService::loadURI now takes 3 args). rs=bustage-fix DONTBUILD
2020-06-03 16:07:42 +03:00
Ben Campbell
24d7049dd2
Bug 1612239 - Remove nsIArray usage from nsIMsgFolderCompactor. r=mkmelin
2020-05-28 16:20:15 +12:00
Ben Campbell
efd6582a5a
Bug 1612239 - Remove nsIArray usage from nsIMsgFolder.descendants. r=mkmelin
2020-06-01 13:58:48 +03:00
Ping Chen
9e9c4d9878
Bug 1494584 - show other users on IMAP folder sharing tab. r=mkmelin
...
--HG--
extra : rebase_source : 4370c82083b4e90b633e9ef8f27fec3dc3edee4b
2020-05-28 19:03:58 +03:00
Geoff Lankow
239949f709
Port bug 1641245 - Make string comparators not virtual. rs=bustage-fix
...
--HG--
extra : rebase_source : 37fbc2421c805891dd1f0a68ca826471a8d86e9b
extra : amend_source : c19bbe4a00ece7b4fd9a454885e9bb1c140074b2
extra : histedit_source : 69509a206ac2663b393c12e373cce03c9b5832d9
2020-05-28 16:11:57 +12:00
Ben Campbell
93c523a2c4
Bug 1612239 - Remove nsIArray usage for msgsMoveCopyCompleted notification. r=mkmelin DONTBUILD
2020-05-19 12:58:38 +03:00
Magnus Melin
602626596b
Bug 1638634 - fix startup Crash in [@ nsImapMailFolder::AddSubfolderWithPath]. r=benc
2020-05-17 14:30:54 +03:00
Gene Smith
5493261453
Bug 1613623 - For IMAP, no longer allow STARTTLS when server sends PREAUTH greeting. (relanding) r=mkmelin DONTBUILD
2020-05-18 13:35:16 +03:00
Ben Campbell
b3f07efa7b
Bug 1636047 - Handle non-copyable nsTArray and AutoTArray (introduced in bug 1626570). r=mkmelin
2020-05-08 13:33:19 +03:00
Magnus Melin
835c479515
Backed out changeset 18d58b4ea283 (bug 1613623) to sort out potential regression. r=backout DONTBUILD
2020-05-04 16:43:52 +03:00
Jorg K
ccdb16a068
Bug 1633205 - Pay attention to HasRe flag in nsImapMailFolder::SetPendingAttributes() and nsMsgLocalMailFolder::EndCopy(). r=benc DONTBUILD
2020-04-28 12:32:19 +02:00
Ben Campbell
0992f803c3
Bug 1612239 - Remove nsIArray use in nsIMsgFolderListener.msgsClassified(). r=mkmelin
2020-04-22 15:04:54 +12:00
Ben Campbell
d9cc983e28
Bug 1627437 - Add attributes to cope with [can_run_script] methods in nsITransaction (Bug 1619914). r=mkmelin DONTBUILD
2020-04-20 13:49:34 +03:00
Ben Campbell
76156bb896
Bug 1612239 - Remove nsIArray usage from various calls related to message deletion. r=mkmelin
2020-04-19 12:52:38 +03:00
Geoff Lankow
5d3b169dd2
Port bug 1621359 - Update .idl files to work with ply3. rs=bustage-fix
2020-04-15 16:59:17 +12:00
Geoff Lankow
e209f0fc8f
Port bug 1620594 part 1: Change NS_ReleaseOnMainThreadSystemGroup to NS_ReleaseOnMainThread. rs=bustage-fix
...
--HG--
extra : amend_source : 28b6afaaceb561daf078588ca1c671e022ad7ea1
extra : histedit_source : 9b46a1a1b3bdb2cd4ad6e125262ba70a7a3bb4ce
2020-04-08 10:46:32 +12:00
Ben Campbell
143b1e4232
Bug 1614846 - Remove nsIArray use in nsIMsgAccountManager.getIdentitiesForServer(). r=mkmelin
2020-04-02 13:39:46 +03:00
Geoff Lankow
d4b9498837
Bug 1614846 follow-up - Use size_t instead of uint32_t to un-break Windows 64-bit builds. rs=bustage-fix
2020-04-01 20:16:01 +13:00
Ben Campbell
24d3883902
Bug 1614846 - Remove nsIArray use in nsIMsgAccountManager.allServers. r=mkmelin
...
--HG--
extra : histedit_source : 46d8ceb77a0e906928f6c6b904d5046922dc9a79
2020-03-28 07:53:42 +13:00
Gene Smith ext:(%2C%20Magnus%20Melin%20%3Cmkmelin%2Bmozilla%40iki.fi%3E)
76628268ff
Bug 841906 - make all the quotas the IMAP server sends us show up in the folder props. r=aleca,mkmelin
2020-03-31 16:20:25 +03:00
Magnus Melin
f8194bc981
Bug 1625679 - Port bug 1551306: Remove context parameter from nsIProgressEventSink.onProgress() and nsIProgressEventSink.onStatus(). r=Paenglab
2020-03-28 21:18:59 +02:00
Ben Campbell
ea1625e0c7
Bug 1622979 - Ongoing comment improvements in IMAP code. r=mkmelin
2020-03-17 11:13:18 +13:00
Magnus Melin
fc050bd8b2
Bug 1624095 - fix bustage from bug 1620632: error: incomplete type 'nsIMAPMessagePartID' used in type trait expression. rs=bustage-fix
2020-03-21 14:42:09 +02:00
Ben Campbell
0cfdc14a22
Bug 1280662 - Fix uninitialised var in nsImapProtocol::GetMessageSize(). r=mkmelin DONTBUILD
2020-03-20 12:59:23 +02:00
Ben Campbell
e8292a8c0b
Bug 1622979 - Improved code comments in IMAP code. r=mkmelin
2020-03-16 18:39:23 +13:00
Magnus Melin
cc92d6e091
Bug 1621587 - remove external API compatibility functions from nsMsgUtils.h. r=benc DONTBUILD
...
#define MsgLowerCaseEqualsLiteral(str, l) (str).LowerCaseEqualsLiteral(l)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgLowerCaseEqualsLiteral\((.+), (.+)\)/\1.LowerCaseEqualsLiteral(\2)/g" {} \;
sed -i -E "s/MsgLowerCaseEqualsLiteral\(([^,]+), */\1.LowerCaseEqualsLiteral(/g" mailnews/base/util/nsMsgDBFolder.cpp mailnews/compose/src/nsURLFetcher.cpp
#define MsgRFindChar(str, ch, len) (str).RFindChar(ch, len)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgRFindChar\(([^,]+), */\1.RFindChar(/g" {} \;
#define MsgCompressWhitespace(str) (str).CompressWhitespace()
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgCompressWhitespace\(([^,]+)\)/\1.CompressWhitespace()/g" {} \;
#define MsgReplaceSubstring(str, what, replacement) (str).ReplaceSubstring(what, replacement)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgReplaceSubstring\(([^,]+), */\1.ReplaceSubstring(/g" {} \;
#define MsgIsUTF8(str) mozilla::IsUtf8(str)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i 's/MsgIsUTF8/mozilla::IsUtf8/g' {} \;
#define MsgNewInterfaceRequestorAggregation(aFirst, aSecond, aResult) NS_NewInterfaceRequestorAggregation(aFirst, aSecond, aResult)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i 's/MsgNewInterfaceRequestorAggregation/NS_NewInterfaceRequestorAggregation/g' {} \;
#define MsgNewNotificationCallbacksAggregation(aCallbacks, aLoadGroup, aResult) NS_NewNotificationCallbacksAggregation(aCallbacks, aLoadGroup, aResult)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i 's/MsgNewNotificationCallbacksAggregation/NS_NewNotificationCallbacksAggregation/g' {} \;
#define MsgReplaceChar(aString, aNeedle, aReplacement) (aString).ReplaceChar(aNeedle, aReplacement)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgReplaceChar\(([^,]+), */\1.ReplaceChar(/g" {} \;
#define MsgFind(str, what, ignore_case, offset) (str).Find(what, ignore_case, offset)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgFind\(([^,]+), */\1.Find(/g" {} \;
#define MsgCountChar(aString, aChar) (aString).CountChar(aChar)
find . -type f -not -path "*.hg/*" -regex ".*\.\(c\|h\|cpp\)$" -exec sed -i -E "s/MsgCountChar\(([^,]+), */\1.CountChar(/g" {} \;
# Find files using mozilla:IsUTF8 but not including the header
grep --exclude-dir=.hg -rl "mozilla::IsUtf8" | xargs grep -L "mozilla/Utf8.h"
# Now remove defines from mailnews/base/util/nsMsgUtils.h manually
# + remove IsUtf8 from nsMSgUtils.h
cd ..
./mach clang-format -p comm/mailnews
2020-03-16 12:54:02 +02:00
Ben Campbell
502dd14fca
Bug 1586494 - Workaround for mainthread assertion in nsImapMockChannel dtor. r=jorgk
...
Differential Revision: https://phabricator.services.mozilla.com/D48916
--HG--
extra : moz-landing-system : lando
2020-03-10 10:43:34 +00:00
Ben Campbell
cdc5f11293
Bug 1614846 - Tweaks requested by clang-format. r=mkmelin
...
--HG--
extra : rebase_source : a0f81bbc5e3ee412a5ed6699d4e9b615fda1e78e
extra : histedit_source : ed61c2e701057264874a8c9564c682b2ed310c8b
2020-02-13 13:21:14 +13:00
Ben Campbell
64f99a59c4
Bug 1614846 - remove nsIArray use in nsIMsgAccountManager (part one: accounts). r=mkmelin
...
--HG--
extra : histedit_source : 0ae61a3d840bf390ad0175c1048195915e692910
2020-02-16 08:48:01 +13:00