8fa463b109
Do not GENERATE_INFOPLIST_FILE for FinderSyncExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
fe3104c2a8
Correctly initialise internal data members for FinderSync
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
736e65934c
Define FinderSync internal data members as private interface extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
e0da34d36c
Use modern dot notation to access _inBuffer properties
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
535402a866
Add quotes to processed line in FinderSyncExt to easily demarcate received line start and end
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
a0088dcd11
Fix parsing of in buffer lines in FinderSyncExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
2acec8f4a0
Clean up FinderSyncExt processInBuffer
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-07-24 12:12:29 +02:00
9d830e94f9
Fix typos found by codespell
...
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
2023-06-21 08:47:13 +02:00
60e785ad4e
Fix xcodebuild parallel build warning
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-06-14 09:07:29 +02:00
c316ecca91
Simplify variables for propery build paths for FP
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-06-06 22:12:07 +08:00
7937986bc6
Fix Debug builds of File Provider module
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-06-06 22:12:07 +08:00
b7d9826877
Build macOS shell extensions with debug configuration in xcodebuild when CMAKE build type set to debug
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
ace8dbc833
Add support for thumbnails in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
7d47e2371b
Add convenience method to get thumbnailUrl in NextcloudItemMetadataTable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
486c1a2556
Split local file related metadata management into own extension in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
4cb1e08d89
Split directory item metadata handling in database to new NextcloudFilesDatabaseManager extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
2b55b43e7b
Correctly report child item count for folders in FileProviderItem
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
16a28a7ccb
Add convenience method for NextcloudFilesDatabaseManager to get child items of a directory
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:39 +08:00
0c78630703
Fix query of childDirectoriesForDirectory in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
6797e12f6e
Properly report modification date for FileProviderItem
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
e245ec0d2a
Set interpolated log strings in FileProvider logs to public
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
7e1ebed8c7
Split client interfacing code into FileProviderExtension extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
ebf96e3e81
Make NKError extension code more Swift-like, clean up
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
0f578fabdd
Use specific signalEnumerator method in FileProviderExtension item renaming instead of reinventing wheel
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:38 +08:00
a7344ba3fd
Fix unused/unmodified variable definition warnings in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
67daae2626
Ensure we return deleted metadata directory copy rather than live fire realm object in recursive delete of NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
766ecf410f
Parallelise conversion of NKFiles to NextcloudItemMetadataTables
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
7550ed7a1b
Properly handle metadata delete after item deletion in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
c088f0eb81
Fix recursive metadata delete in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
2853b88258
Move NKFile to metadata conversion methods to a new extension for NextcloudItemMetadataTable, where they are better placed
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
6169594864
Prevent multi-thread modification of the same array with serial array modification dispatch queue when enumerating items in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
9c1a035e3c
Reintegrate sync engine into FileProviderEnumerator class
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
bd50f753fa
Simplify initial item enumeration, no need to fetch from database in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:37 +08:00
fe7ca12d9c
Perform slow metadata to FileProviderItem conversion concurrently in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:36 +08:00
808f976ae9
Fix children serverurl rename in file provider nc files database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:36 +08:00
384093cbc6
Remove redundant double read of serverUrl when often we always want to do a depth 1 read in NextcloudSyncEngine
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:36 +08:00
27a177ab35
Make sure to include new metadatas in folders to scan for changes in recursive scan of NextcloudSyncEngine
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 16:02:36 +08:00
34a43fea69
Make sure to notify when folder moved in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:57 +08:00
9fadc89ff0
Fix unsetting of etags on directories (and only) directories on update
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:57 +08:00
02e1d6a47f
Fix recursive directory metadata renaming order
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:57 +08:00
9cc05457c0
Do not do specific enumeration of items working set in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:57 +08:00
289f7f2c9f
Ensure we do not set etag if we have set updateDirectoryEtags to false in NextcloudFilesDatabaseManager updateItemMetadatas
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:57 +08:00
35570a3160
Move remote sync functionality out of enumerator and into separate NextcloudSyncEngine class
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
1524fc01f0
Progressively enumerate items as we get them for working set
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
5154a57ac6
Move conversion from NSData to NSFileProviderPage to separate func
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
6202f3d70a
Split metadata parsing to complete enumerator into own function
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
8c729fb2f9
Simplify enumerateItems of working set by using fullRecursiveScan in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
b369b5d515
Handle invalidation of enumerator during long recursive scans in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
213893b13f
Fix recursive scan when scanChangesOnly is false in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
d0b4b6853c
Move deleted/updated conflict check to fullRecursiveScan in FileProviderEnumerator+RemoteSync
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
3c2c360a2e
Properly report and handle critical errors during recursive enumeration in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:56 +08:00
245129de99
Move remote sync stuff in FileProviderEnumerator to own file
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
b2d2f9586e
Properly report deleted metadatas in recursive directory delete in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
a779fe76cb
Favour straight return in updateItemMetadatas rather than unnecessary completionHandler in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
0526079504
Fix renaming directories remotely fixing local sync state in file provider
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
29b495335b
Do not update etags for child folders acquired in a depth 1 readServerUrl in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
872186248a
Remove redundant directory metadata tables in File Provider
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
2e70c82663
Prevent premature running of completion handler when modifying folder in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
3538ce9424
Change fullRecursiveScan function to enable more than just look for changes, also do proper full scan
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
97d2b354df
Ensure we are not marking items as both updated and deleted in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:55 +08:00
2c64e4b6bd
Ensure xcodebuild uses the Info.plist file verbatim
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:54 +08:00
0bdbc956bc
Fix FileProviderExt bundle identifier
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:54 +08:00
9bcc017fb8
Only set CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt for release configuration.
...
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
2023-05-12 13:29:54 +08:00
ecd55ae37d
Set CODE_SIGN_INJECT_BASE_ENTITLEMENTS=NO in FileProviderExt.
...
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
2023-05-12 13:29:54 +08:00
a859107ec0
Disable automatically manage signing in FileProviderExt target.
...
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
2023-05-12 13:29:54 +08:00
169b1a765e
Use Nextcloud team id.
...
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
2023-05-12 13:29:54 +08:00
d3c3181c0d
Ensure we are logging error description itself and not NKError wrapper or any Error type
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:53 +08:00
4f1f4388af
Rewrite modifyItem to make it non-blocking on the main thread in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:29:53 +08:00
ccad81949a
Make enumeration of working set changes non-blocking in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
60005d89bc
Ensure we are editing realm database on main thread in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
52fe107ec5
Fix blocking main thread when enumerating working set items in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
073db8182b
Log errors in fetching local temporary file provider path
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
762aee8e41
Simplify temp local file creation while fetching contents, use File Provider volume
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
8661841c44
Remove unnecessary local file operations in FileProviderExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
221848f230
Properly set cancellation, pausing, and resuming handlers on FileProviderExtension task progress
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
607d72615d
Add ability to set handlers from AlamoFire request on Progress extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:46 +08:00
d4d5c8f8da
Removed unused tracking of outstanding session and ocID related tasks
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:45 +08:00
a7616502ae
Do not copy pause, cancel, and resuming handlers in Progress extension copyCurrentStateToProgress by default
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:45 +08:00
5e8d7217a9
Warn when retrieved size of file upload is different to the expected size in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:45 +08:00
b8224212ca
Ensure item upload/download states are properly set and reset in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:45 +08:00
23e623ef0a
Make it possible to disable building file provider module
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:28:45 +08:00
f16f89118e
Set deployment target for FileProviderExt to macOS 11.0
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
4e536dcd65
Ensure upload errors for modified files are recorded in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
f4be264eee
Ensure existing metadatas being uploaded are set to uploading status in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
9083f982d9
Use completion handler to retrieve updated metadata after status change, fixing race condition in FileProviderDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
7967ced04e
Properly handle logging interpolation in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
c88fb7fb3e
Do not hide interpolated log strings in FileProviderSocketLineProcessor
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
5ae1936328
Handle different interpolated string types differently in FileProviderExtension logging
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
89164d99ec
Make privacy level of interpolated strings in FileProviderEnumerator logging more granular
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:35 +08:00
3082850e68
Ensure errors are always publicly displayed in unified logging of File Provider
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
545fe6d56e
Finish replacing NSLog with use of Logger in LocalFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
810c7d0b19
Also use logger in FileProviderSocketLineProcessor
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
854b11e477
Use Logger materialisedFileHandling for logging in FileProviderMaterialisedEnumerationObserver
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
5c72c6a2e9
Replace NSLog in FileProviderExtension with use of Logger
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
75f18b8bd5
Use enumeration category and logger for FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
b16bf24949
Improve logging in files database manager with use of Logger
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
0f6ceef06f
Add a logger extensions to use system unified logging in File Provider components
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:34 +08:00
8994f31cb9
Remove unnecessary full reimport after initial account configuration in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
7863ba8594
Improve error handling in fetchContents if path is not available FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
68044891f0
Properly respond to errors in working set enumerateItems in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
287c98f7f5
Add directoryMetadataLogString convenience method for logging in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
134e373f1b
Do not delete "no longer existing files" when doing enumeration of items in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
b532b96937
Add helper itemMetadataLogString static func for logging in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
2ca2609e0c
Properly write item metadata status update to database in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:33 +08:00
412fd0887e
Provide file provider errors in FileProviderExtension methods
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
b9b408d606
Fix general error handling in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
3873ad126d
Use NKError extension properties instead of magic numbers in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
1ee6d1a1cc
Improve handling of no changes return in readFileOrFolder throughout FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
6ffbb5abf6
Properly handle stopping when finding matching etags in readServerUrl of FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
d639baeea0
Add no changes error code in NKError extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:31 +08:00
a0c819fdbe
Make NKError extension conversion more legible
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
109258f3ce
Use NKError extension method in FileProviderEnumerator enumerate methods
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
fdaf0d5aa5
Add NKError extension to make conversion to FileProviderError easier
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
6ef4f8a4f4
Implement better error handling in enumerator changes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
d1008df429
Respond to materializedItemsDidChange in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
20363bd241
Add completion handler to materialised observer
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
61890ddd72
Added FileProviderMaterialisedEnumerationObserver to handle clean up operations after materialisation changes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
52f5b6a524
Split up the huge NextcloudFilesDatabaseTables file into separate files for each table schema
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:30 +08:00
32e5dbad4a
Rename misleading FileProviderFilesUtils to LocalFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:29 +08:00
c24ed9b7ac
Remove isFileSynced function which does not work as intended
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:29 +08:00
1d1578447e
Move parentItemIdentifierMetadata helper method to the database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:29 +08:00
3ec9968fc2
Move file provider database files into own folder
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:29 +08:00
287a4e4c0b
Unauthenticate the file provider extension when account is logged out
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:29 +08:00
c593bd8a50
Fix variable related warnings in FileProvider
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:27 +08:00
c4d3c4ba88
Improve reliability of modifyItem in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:27 +08:00
882e58aa64
Don't compare un-persisted properties of NextcloudItemMetadataTable in isInSameRemoteState, fixing constant updating of metadatas
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:27 +08:00
1cc0cf7129
Fix compatibility with latest NextloudKit version TypeClassFile in NKCommon
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:27 +08:00
81fb05298c
Be efficient in working set enumeration by only enumerating for new items or changes folders that have been explored already
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:26 +08:00
79d89c21c7
Ensure no metadatas get deleted when updating metadata for scanned directory in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:26 +08:00
d3f2094866
Remove workarounds no longer needed for Realm thread crashing
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
17fea88450
Replace full depth scanning of changes on every enumerate changes request with smarter recursive algorithm
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
1a48e4e06e
Fix root cause of threading issues with metadata updates
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
7c8aab38d2
Fix erroneous deletion of metadata when updating serverUrl subject directory
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
2ac3a22523
Further improve/cleanup/simplify file provider extension init
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
3e269a958b
Fix crash on thread clash with Realm when enumerating changes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
147e06c40a
Fix return of updated and deleted metadatas in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:25 +08:00
f427750f2c
Ensure metadata handled in FileProviderItem is copy, preventing crashing due to accessing live table from different thread
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
24d6c5071c
Create sortedDirectoryMetadatas convenience method in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
64e32b48eb
Add convenience method to get child directories from database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
65ab13c0f9
Ensure we don't saturate the server with propfind requests
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
390403ef5e
Properly report pagination for working set enumeration
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
b52b82134e
Enumerate all known folders as workingSet enumeration
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
7302c953d8
Rewrite working set handling to make it match the server remote, per Apple recommendation
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
32e81a693e
Add method to get all item metadatas in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
24b328f57b
Add method to get all directory metadatas in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:24 +08:00
b73c1d72fb
Better handle initial set up of the file provider extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
03c1731fb5
Handle 404 errors from readFileOrFolder as special deletion case in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
25a09e1704
Use ocIds for directory metadata deletion, prevent deletion if no such directory found in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
65ed3ad846
Use ocIds for item metadata deletion in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
2b92e9b546
Improve handling of nil values in CompleteChangesObserver
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
47d50af140
Enumerate changed in the working set
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
1ffdc5f1c5
Refactor change enumeration completion into separate static function
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
e2943ab043
Delete new updated items that are now E2EE
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:23 +08:00
2cf4033f9b
Enumerate changes for normal serverUrls in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
53649c2933
Rename completeObserver to completeEnumerationObserver
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
60dbf167b9
Fix the serverUrl used to fetch database item metadatas on enumerateItems
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
7734316416
Fix accidental purge of all metadatas caused by trying to call updateDirectoryMetadatasFromItemMetadatas when reading the root container
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
d478320dd3
Refactor readFileOrFolder to be more adaptible to enumerating items or changes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
61dd51ae02
Properly delete directory and all children when updating folder metadatas in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
e7e850094b
Also report all new, updated, and deleted metadatas from updateItemMetadatas in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
a10b563eb7
Report new item metadatas and updated item metadatas in processItemMetadatasToUpdate in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:22 +08:00
fc376b5fe6
Report deletedItemMetadatas in processItemMetadatasToDelete in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
76311cc66f
Properly handle readFileOrFolder of file vs folder
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
cc72cc361c
Keep track of additional details about enumerating item in the FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
d22b8e0eb7
Enumerate materialised items when system requests working set
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
3316d19b90
Add convenience method to get local file metadatas for an account in NextcloudItemMetadataTable form in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
a18c6dc258
Add convenience method to get all local file metadatas for an account in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
17f52982bd
Properly report progress for download and upload operations in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
628ff92dec
Add a Progress extension with convenience methods for copying progress data from one progress object to another
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
53d2fc0c1e
Prevent creation of symbolic link items in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:21 +08:00
ca298eff87
Handle version item requests in fetchContents of FileProviderExtension per the documentation
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
54587e8c07
Clarify current use of sync anchor in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
06b59b6756
Correctly fulfill delete item requests on server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
3e0a9e9912
Support reparenting file provider items correctly
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
a146b65f76
Properly handle several modify item fields at once in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
020c5d5104
Only try upload of modified item in FileProviderExtension if that had its contents changed and we have a valid content url
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
0f2fbf7518
Handle renaming of both files and folders correctly in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
c7660b50df
Add convenience method to rename file item metadatas in database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:20 +08:00
5f24527270
Properly handle renaming folders in FileProviderExtension modifyItem
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
c3f79eecc6
Add methods to rename directory metadata and propagate modifications to all children in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
47d98a44a8
Add methods to delete metadata types in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
c6cc87a4b8
Extension can now upload modifications to items on the server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
992ef7b62b
Add ability for extension to create items correctly on the server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
7d2c21c772
Don't unnecessarily fetch item metadata when fetching contents
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
81dd5966f8
Unprivate direcotryMetadataFromItemMetadata in database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
dc2e14d57b
Add convenience method to add directory metadata to database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:19 +08:00
91ad815a6b
Add working file content fetching
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
b70e9d11bb
Add convenience method to add local file metadata from item metadata to database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
293512560e
Add convenience method to add item metadata status
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
90d5c8f54e
Add convenience method to update item metadata status
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
3342fb77c8
Add convenience properties to NextcloudItemMetadataTable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
230b55d7e9
Stop using NextcloudKit.shared and NKCommon.shared, use specific NextcloudKit instance instead to prevent clashing between different FileProvider domains
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
f0524d44e1
Switch to NCKit work/unsharedify-nckit branch
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
98afd95e59
Fix Realm crashes when trying to delete certain objects
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
6a258c0c37
Properly handle errors when trying to read server url in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:18 +08:00
3be08bb15e
Fix scanning of child directories in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:17 +08:00
476d6a2456
Don't unnecessarily fail to get serverUrl for enumerated item in FileProviderEnumerator when this can be acquired straight from the itemMetadata
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:17 +08:00
c4580183e7
Only reimport entire file provider domain if there have been no recorded files when ncAccount is configured
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:17 +08:00
9c18d36f41
Add convenience method to check if any file metadatas have been stored for account in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:17 +08:00
74222daa2a
Don't unnecessarily fail to provide parentItemIdentifier in NextcloudFileProviderFilesUtils when we can get the root container straight from the item metadata in question
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:17 +08:00
5c01109004
Switch to develop branch of NextcloudKit
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
06f2714a95
Improve and fix enumerator signalling after initial account setup in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
ff25f940ec
Fix URL path composition for utility methods in NextcloudFileProviderFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
ceb9aa3b65
Fix try/catch indentation in NextcloudFileDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
7cb49393fe
Fix NextcloudItemMetadataTable status query type
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
38d1b95bd2
Fix the webDavUrl for NextcloudAccount
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
2f5d0e6fe9
Set up NextcloudKit account in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
325878b696
Improve logging in FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:16 +08:00
67de82913e
Keep track of requested enumerators when account is being configured, notify them as changed once account is set up
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
ba86824c7e
Improve FileProvider logging
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
31732c2fb2
Added missing network entitlement to FileProviderExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
a046eca3c3
Use safer separator for account details socket message
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
f01b6a545f
Fix path handling for file provider database setup
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
e7e985f355
Correctly register object schemas in Realm database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
1cb7da9bac
Send account details over socket and simplify NextcloudAccount members, turn all to Strings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
81b5c33571
Complete item method of FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
d801bfc8f5
Complete basic barebones enumeration
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:15 +08:00
5f0a4883fc
Use NSLog instead of print in FileProvider
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
176303dcf1
Use more modern Realm @Persisted
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
d0ac36faab
Make record updating methods safer by checking for existing metadatas internally
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
57d585201e
Add method to get directory tables from database in manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
7ff2379e3d
Make sure to create copies of Realm objects to prevent issues with live-fire objects
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
496b94a9a7
Add comparison helper to NextcloudDirectoryMetadataTable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
c4014e8b6a
Add parent directory server url data to directory table
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
d9e368cbe7
Refactor updateDirectoryMetadatas in the database manager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:14 +08:00
3354f3e4de
Add updateDirectoryMetadatasFromItemMetadatas to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
316ef61d83
Split off update and creation process of updateItemMetadatas of NextcloudFilesDatabaseManager to private method
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
4d2da1037d
Split off deletion process of updateItemMetadatas of NextcloudFilesDatabaseManager to private method
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
39f4b7a8e4
Add updateItemMetadatas method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
e929940b47
Add convenience isInSameRemoteState method for NextcloudItemMetadataTable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
f2970e2da7
Add itemMetadatas method to NextcloudFilesDatabaseManager with status as parameter
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
06a5e4df85
Add NKFile to NextcloudItemMetadataTable converter methods to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
55f533dc3d
Add clarifying comments to NextcloudFilesDatabaseTables
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:13 +08:00
f466fd6652
Add itemMetadatas method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
df53aa2492
Add directoryMetadata method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
9e2c8f355d
Add ncKitAccount property to NextcloudAccount
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
2b5425390d
Add completeObserver method to FileProviderEnumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
7d1b275d50
Fill out FileProviderItem
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
0e3d565151
Add localFileMetadataFromOcId method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
63bcd02512
Add NextcloudLocalFileMetadataTable derived from iOS app
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
f15187c8b4
Rename NextcloudFileMetadataTable to NextcloudItemMetadataTable to more accurately match functionality
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:12 +08:00
9ff66bb94f
Add isFileSynced helper func to FileProviderFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
5f9f0311d1
Add transfer status enum to NextcloudFileMetadataTable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
1a27f3c249
Add convenience parentItemIdentifierFromMetadata convenience function to NextcloudFileProviderFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
d7b9d7f215
Add convenience createFileOrDirectoryLocally func to NextcloudFileProviderFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
08436a129e
Added convenience functions to create paths for NC files (and create directories and placeholder files if inexistent)
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
83230baeaa
Use pathForFileProviderExtData in NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
730c30f324
Add pathForFileProviderExtData convenience method to NextcloudFileProviderFilesUtils
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
487b47fbf7
Use pathForAppGroupContainer func in FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
583b91c986
Add NextcloudFileProviderFilesUtils for file-related utility funcs
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:11 +08:00
4b48f0c429
Use server dav files URL in enumerator
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
9f6c2df4e3
Complete FileProviderEnumerator init, get correct serverUrl for enumerator item identifier
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
fa7e441d81
Add directoryMetadataForFile method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
3122dba6f9
Refactor NextclouDFilesDatabaseManager methods slightly for consision
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
18119b32bf
Add database table for directory from iOS NC
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
1ffc5949aa
Add getFileMetadataFromFileProviderItemIdentifier method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
8e90f66918
Add getFileMetadataFromOcId method to NextcloudFilesDatabaseManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
5337d5d654
Add basic NextcloudFilesDatabaseManager for FileProvider files
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
41fe92ebd2
Add NextcloudFilesDatabaseTables for FileProvider files database
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:10 +08:00
9095df2482
Make ncAccount in FileProviderExtension an optional, make state of FileProviderDomainAccountData immediately on init
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
a8dfafabde
Make localSocketClient of FileProviderExtension a lazy var
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
e319516b89
Add URLSession to FileProviderExtension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
4efb234f68
macosx: Add NextcloudKit and Realm dependencies
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
9b54e6414f
Grab account keychain entry identifier data from socket in FileProviderExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
f795666d4b
Add FileProviderDomainNextcloudAccountData that grabs account info from keychain
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
39850ab145
Move FinderSync-specific GET_STRINGS initial call out of LocalSocketClient and into FinderSync
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
cf606f19a6
Add ability for FileProvider app extension to reply to file provider domain identifier request
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:09 +08:00
ad665ff06c
Add sendMessage method to LocalSocketClient public API
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:08 +08:00
8ea09cb9d7
Clean up public API of LocalSocketClient
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:08 +08:00
ada4b98a93
Added working socket connection between desktop client local socket server and app extension socket client
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:08 +08:00
f20b11745d
Modify FinderSyncExt to move components into shared Framework that can be used in FileProviderExt
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:08 +08:00
16394d13d2
Clean up LocalSocketClient code in shell extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:08 +08:00
a7ec2c325e
Rename OwnCloudFinderSync Xcode projext to NextcloudIntegration
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:07 +08:00
ed85334b62
Fix faulty quoting in shell integration CMakeLists
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:06 +08:00
d10b208655
Set connection status for file provider domains
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:06 +08:00
dcd1628ce8
Ensure file provider domains appear in finder sidebar
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:06 +08:00
9a86bb2be3
Add file provider init code
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-12 13:21:06 +08:00
f7239ebdca
Don't bother doing init procedure on FinderSync in macosx shell integration of invalid self
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 16:24:35 +01:00
521a026e03
Correctly init LineProcessor in macosx shell integration
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 16:24:35 +01:00
5892075df7
Avoid the Get-Task-Allow Entitlement (macOS Notarization)
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 21:31:56 +01:00
19a2f8cc7d
Add support for macOS to flake
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-12-13 16:42:35 +01:00
46381f5ddc
Update macOS shell integration deployment targets
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-29 11:35:35 +01:00
a74f9b367d
Ensure the dispatch source only gets deallocated after the dispatch_source_cancel is done
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-01 13:15:40 +02:00
1f04073e7c
Fix possible overflow on lineWritten
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-19 12:40:59 +02:00
683e7794a3
Fix crashing of finder sync extension caused by dispatch_source_cancel of nullptr
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 12:48:23 +02:00
628ee10008
Implement local socket to communicate with finder extension
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-17 11:46:57 +00:00
ec64246dc7
Only build app bundle if requested
...
For development a app bundle is not needed. The app bundle is only
needed for distribution and macdeployqt takes a lot of time.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-23 11:41:29 +00:00
113ba716e6
Compile finder extensions for arm and x86
...
Fix: https://github.com/nextcloud/desktop/issues/3967
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-16 08:54:48 +00:00
f8a8e3f2f9
target names are not changed in branded builds only the output filenames
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-15 15:22:29 +02:00
7fb0a82e69
macOS build: Avoid the Get-Task-Allow Entitlement (Notarization)
...
Setting CODE_SIGN_INJECT_BASE_ENTITLEMENTS to NO is required for macOS
Notarization.
See: https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution/resolving_common_notarization_issues
And upstream: 97f4af32ae
2019-11-17 21:33:04 +01:00
d3cbe63801
macOS: Implement new dynamic Finder menu items #6328
2018-06-05 20:40:40 +02:00
81c20352e1
Use new ECMAddAppIcon macro for application icons.
...
cmake/modules/ECMAddAppIcon.cmake is heavily patched to support sidebar icons, OUTFILE_BASE parameter and to not include 64 and 64@2x icons on macOS which are not supported. All changes are made in a way that we can upstream this.
2018-01-13 13:58:17 +01:00
ca2ffd4fb3
SocketAPI: Change strings to a consistent _MENU_TITLE postfix
2017-07-07 10:49:51 +02:00
3b20684dc7
shell/macos: Remove legacy (< 10.10) overlay icons
...
Having to update the plugins to add a submenu in the context menu,
it's more cost-effective to remove support for legacy macOS versions
than implementing and testing this setup.
2017-07-07 10:49:51 +02:00
b6db9789ee
shell/macos: Use a submenu to include private link actions
2017-07-07 10:49:51 +02:00
cb5cfb8cf6
shell/macOS: Make sure the root folder's cache is cleared on disconnect
...
The SocketAPI now only sends status pushes for paths requested by the
shell. We have to make sure that Finder doesn't just show the entry
from its cache after a reconnect.
2017-01-18 12:15:52 +01:00
ebd2a15711
shell/macOS: Remove backslashes from the extension display name
...
Tell cmake not to escape shell strings adding backslashes before
spaces by passing the VERBATIM optiton. Also add the quotes to
whole command line arguments to prevent quotes from appearing on the
XCode side, because of the VERBATIM option.
This only affects themed clients since the default theme doesn't
have space in its APPLICATION_NAME.
2017-01-18 12:15:52 +01:00
6a9655aab6
OS X: Fix overlay installation on El Capitan #4650
...
The sleep is somehow needed, probably for pkg to rebuild its DB?
The case fix fixes a warning but did not fix the issue itself.
2016-04-15 16:58:58 +02:00
d1649ce4df
OS X: Allow ampersand in APPLICATION_NAME #4657
2016-04-15 11:30:49 +02:00
17c645ce43
Hide environment variables when running the FinderSync icns script
...
This otherwise shows up in the console for each incremental build.
2016-03-30 18:00:22 +02:00
6c283c7a48
OS X: Use app icon for "Share with ..." Finder menu #4472
...
This works for both plain ownCloud and themed clients.
2016-03-30 15:26:43 +02:00
439eddb523
OS X shell: Don't allow sharing sync roots #3505
2016-01-14 16:25:19 +01:00
bae552f386
Minor shell integration typos
...
all in comments or other places that have no effect on the user.
2015-09-10 17:14:08 +05:45
5e657aadee
Fix Finder crashing when showing the context menu on OS X <= 10.9
...
OwnCloudFinderRequestManager::_shareMenuTitle was not retained anymore
after the FinderSync refactoring which would cause it to contain any
kind of garbage value for some reason.
Fix the issue by also enabling ARC for RequestManager.m.
We can't enable ARC for the whole project since Finder.h is included
by many .m files and it's not trivial to port to ARC.
2015-09-09 17:45:24 +02:00
dcf7e8a631
shell_i: Don't request statuses on UPDATE_VIEW
...
Now that the client is pushing all changes of state, we don't need
to track the requested URLs anymore and risk that the way that we
reseted that list could leave a few entries in Finder's cache outdated.
We can remove the same code from other platforms in a later release,
a bit earlier than a week before beta1.
2015-07-31 21:59:58 +02:00
360a0eeee1
OS X overlays deploy.sh: Update output
2015-06-29 15:16:43 +02:00
9797782682
shell_i: Build the extension with the '-' identity by default
...
This allows developers to build and run the extension by default.
Official packages bundles will be re-signed after the build, we
The SocketApi prefix can be set at configure time through cmake and
should match the key that will be used to sign the whole .app bundle
(including the embedded FindexSync .appex bundle).
2015-06-22 13:55:19 +02:00
121577340a
shell_i: Cleanup and build fix
...
Don't use absolute paths for resources
2015-06-22 13:55:19 +02:00
0320627263
shell_i: Use a more specific name for ContentManager
...
Since we use that class to lookup the NSBundle using bundleForClass
use a more specific name to avoid any clash with any othe liferay
extension. I couldn't figure out from the documentation if that is
only resolved using the class name, but found some warnings on
stackoverflow and better be safe than sorry for what it costs.
2015-06-19 16:50:11 +02:00
85938ab1f1
shell_i: Remove the ICON_PATH socket API message #2340
...
It was only used on OS X and couldn't be used by the FinderSync
extension since that one runs in a sandbox. So use the same system
to load images in the legacy extension by shipping them in the
extension bundle instead of the owncloud.app bundle.
This is also given that the legacy extension needs padded icons
while the FinderSync one needs unpadded icons.
2015-06-17 17:15:50 +02:00
e111e11dab
shell_i: Add english labels
2015-06-17 14:32:34 +02:00
db38bf4a0c
shell_i: Avoid always rebuilding SyncStateFinder.osax #2482
...
The archive buildaction causes this. Use the default build while
forcing the Release configuration instead.
In both cases the result will end up in SYMROOT.
2015-06-17 14:32:34 +02:00
52f64358c7
shell_i: Use proper non-padded icons #2340
2015-06-16 15:30:42 +02:00
02f6dbba46
shell_i: Add a FinderSync-based implementation #2340
...
This uses the new official API to show overlay icons and add our
custom context menu entry instead of hooking directly into the
Finder process and intercept drawind routines.
A dummy desktopclient target is also in the project to allow debugging
directly in Xcode while the official client can be started from the
command line. Otherwise Xcode won't allow attaching to the debugee.
Dummy icon files have been added while we get proper icon produced.
We can't use the old icons since what we use for the legacy shell
integration is already padded according to where the badge should
appear on the full icon.
2015-06-15 15:28:21 +02:00
bfcfdeec64
shell_i: Use an NSConnection instead of a local socket #2340
...
This prepares the switch to the official FinderSync API on Yosemite
which requires the extension to run in a sandbox. This complicates
the usage of a local socket to communicate with a non-sandboxed GUI
client. An NSConnection is easier to use in this case, which we can
use as long as the server name (i.e. Mach port registered name) is
prefixed with the code signing Team Identifier.
A placeholder server implementation is also added to the client's
SocketApi which basically reproduces the interface of a QLocalSocket.
Most of the references to individual sockets we're only using
QIODevice methods so the type was simply reduced. A typedef to
replace the QLocalServer was the only other part needed.
2015-06-15 15:28:17 +02:00
9ef8658122
shell_integration on OSX: Avoid too many RETRIEVE_FILE_STATUS following UPDATE_VIEW #3122
...
Do not request the status of all entries in the cache. Instead force Finder
to request the ones that it deems necessary by keeping the old statuses
in a separate dictionary which are only used while the new status arrives.
2015-05-06 16:56:50 +02:00
0a67719f2f
shell_integration on OSX: Do not fill the cache with unsolicited statuses #3122
2015-05-06 16:56:50 +02:00
04d820f9cf
shell_integration on OSX: Remove dead code
...
removeIcons isn't called and clearFileNameCacheForPath was always
called with a "nil" path.
Remove the return value of askForIcon which was always 0, and use
that value explicitly at the only call site.
Remove the "-1" code path in iconByPath since setIcons prevents
-1 from getting into _fileNamesCache in all cases.
2015-05-06 16:56:50 +02:00
931dd59844
Don't hardcode the source directory in deploy.sh
2015-05-06 16:56:50 +02:00
a98ab6f51d
shell_integration: Remove OwnCloud from public strings on OSX
...
Also removed it from commented out logs just in case.
2015-02-25 12:13:28 +01:00
ccf4298c81
shell_integration: Cleanup our uses of NSLog
...
Remove info messages and make sure that error messages
have an OwnCloud prefix since they will be reported by
Finder's process.
2015-02-17 18:23:30 +01:00
0b461e2275
shell_integration: Fix the overlay icons in the column view
...
Based on 79a713ea643e13e95f52bfe2adbbaf4a5ca92f8a in upstream liferay-nativity.
2015-02-17 18:20:16 +01:00
3a1501dea4
OS X: Connect to newest possible overlay icon socket
...
This is for branded ownCloud clients which use a different file name.
2015-02-04 18:44:00 +01:00
bb215ad095
OS X: Don't show menu item outside sync folder
...
As per #2732
2015-01-29 21:13:09 +01:00
a999884adf
osx integration: adapt to socket api changes
2015-01-23 16:13:16 +01:00
c54621eb19
OS X: Share menu for Finder
2015-01-23 12:00:31 +01:00
414ac5433d
Merge branch '1.7'
...
Conflicts:
binary
doc/accountsetup.rst
doc/architecture.rst
doc/navigating.rst
doc/owncloudcmd.rst
doc/troubleshooting.rst
2015-01-05 14:40:53 +01:00
f195648b90
OS X: Fix overlay icons
...
a3e7f513e6
2014-12-15 11:34:44 +01:00
d5f2c36abd
Mirall -> (Desktop) Client
2014-12-08 17:54:32 +01:00
0d9ae241c9
OwnCloudFinder: Rename to SyncStateFinder
...
Project file names stay the same, only the output file(s) changed
2014-10-23 12:19:19 +02:00
f8f5a7ceaa
OS X Overlay Icons: Fix static analyzer warnings
2014-10-10 11:44:40 +02:00
b01839e9a4
OS X: Remove dead JSON code
2014-10-10 11:44:40 +02:00
6fbd28d228
Merge branch 'overlayicon_cache' into 1.7
2014-10-08 11:02:58 +02:00
ef019cdbfa
OS X Overlay Icons: Fix Finder plugin crash
...
By enabling ARC for GCDAsyncSocket (as we should have done before
https://github.com/robbiehanson/CocoaAsyncSocket/wiki/ARC ) there
is no chance anymore for a situation where the to-be-written NSData*
is deleted before the socket has had a chance to write it.
Interestingly, this only happened after switching to local sockets,
probably because of how immediatly the NSData* would be sent.
This commit also keeps the debug symbols for the Finder plugin.
2014-10-03 07:23:43 +02:00
b6d97cfffb
OS X Overlay Icons: Introduce a short term cache for rendered icons
...
This is for #2093
2014-10-01 13:21:29 +02:00
147fa60f81
Merge branch 'socketapi_localsocket' into 1.7
2014-10-01 12:34:22 +02:00
02f971b534
OS X Overlay Icons: Fix request for sync dir itself
2014-09-30 12:53:35 +02:00
f8b73eb9d9
SocketApi: Port OS X to use local sockets
2014-09-30 07:36:20 +02:00
0539098371
OS X: Update GCDAsyncSocket
...
The two files are from the fork from
https://github.com/jdiehl/CocoaAsyncSocket/tree/socketUN
It supports unix domain sockets.
SHA1 was 7e97fc876522c7bf2a2a434cf40579ae9daf9da5
2014-09-30 07:09:39 +02:00
8915f94931
Mac Overlays: handle filenames with slashes properly.
...
There are filenames with slashes on MacOSX, they can be created
in Finder. Internally they are converted to colons.
2014-09-25 12:24:32 +02:00
688b8dcc38
MacOverlays: Pass isDir flag to isRegisteredPath method
...
With that, a path can be added to directories to also detect the
sync top directory.
This fixes bug #2053
2014-09-23 10:25:11 +02:00
280edee1db
cmake: fix typo
2014-09-23 10:25:11 +02:00
2fddf05515
OS X: Overlay Icons: Load from bundle-specific path
...
The client (in this case mirall) tells the Finder plugin where to get the icons.
This enables installation in different locations and in branded clients.
2014-09-12 15:09:47 +02:00
91d1864840
OS X: Overlay Icons: Less verbose debug output
2014-09-12 15:09:46 +02:00
0edd4d3c02
OS X: Overlay icons: Don't show if folder is not marked as being an oC folder
2014-09-12 11:46:53 +02:00
4ce03e8b61
OS X: Fix Overlay icon retrieval
...
Re-retrieve all icons for a path in case we receive UPDATE_VIEW.
(But in contrast to previous code, don't delete the icons which then
would have caused screen flickering)
2014-09-07 11:38:23 +02:00
b6f42a91f4
OS X: Fix Finder bundle NVTY->OWNC
2014-08-28 15:45:07 +02:00
d69049ce10
OS X: Fix Finder plugin
2014-08-28 10:21:56 +02:00
2f34b046d0
Overlay Icons: Improve OS X version, improve general feedback
...
Now the update phase of the syncing algorithm pushes stuff the notification socket too.
2014-08-27 19:15:43 +02:00
79b547b83b
Icon Overlay OS X: Complain if icon couldnt be loaded
2014-08-26 17:21:15 +02:00
Claudio Cambra
Dimitri Papadopoulos
Ivan Sein
Claudio Cambra
Felix Weilbach
Matthieu Gallien
Michael Schuster
Markus Goetz
Dominik Schmidt
Christian Kamm
Jocelyn Turcotte
Phil Davis
Olivier Goffart
Daniel Molkentin
Klaas Freitag