Continuing to chip away at numerous varieties of build-time warnings and make minor code cleanup changes.
- Add a runtime ID to Stride.Samples.Tests so the compiler generates the same architecture as its dependencies.
- In Stride.Samples.Tests, remove link to AttachedChildProcessJob.cs as its not needed and results in a duplicate symbol warning.
- In AssetPropertGraph, actually use the isDisposed field.
- In several projects, us the released version of System.Collections.Immutable rather than the prerelease.
- In Stride.Core.Design, allow it to see the internal NativeLockFile compiled into Stride.Core.IO and avoid the duplicate symbol warning.
- Correct a few cases of sealed classes having protected members.
- As hygene, move ParticleBufferState to its own .cs
- In ParticleVertexBuilder, remove the unused indexStructSize
- Across multiple test projects, use the release version of Microsoft.NET.Test.Sdk rather than the prerelease version.
Address CPP compiler warnings by explicitly casting values after examining safety or by changing the type used. Also removed some commented out debugging code.
Fixes the following warnings:
- CS0108 'OldCollectionDescriptor.IsCollection(Type)' hides inherited member 'CollectionDescriptor.IsCollection(Type)'. Use the new keyword if hiding was intended.
- CS0162 Unreachable code
- CS0168 The variable 'e' is declared but never used
- CS0169 The field 'foo' is never used
- CS0184 The given expression is never of the provided ('ProjectViewModel') type
Plus some minor using cleanup and making code a tad more consistent.
1) HttpResponseMessage (return from HttpClient.GetAsync) should be disposed so added using statements as appropriate. In some cases the code was slightly rearranged for readability with this update.
2) Since the BaseUrl is never actually used elsewhere, removed updating it in ReleaseNotesViewModel.cs
3) Removed unneeded setting of stream pointers to their head immediately after creation since they will be that way already.
4) In NewsPageViewModel.cs, converted the use of MemoryStream to the return type of ReadAsStreamAsync, Stream, since it allows for the same usage in the following code and avoids a potentially risky cast.
1) Replaced all insances of WebRequest with HttpClient plus the appropriate Get + Read operations.
2) Replaced the use of WebClient with HttpClient plus Get + stream read.
3) Removed semi-problematic refereces and the SDK specifier as they caused the compiler to generate a number of warnings. All these are not needed in .NET 6.
The launcher executable was moved to a new tools directory as part of the fix for #1139. Older packages did not contain a tools directory so added code to check for the existence of a target directory before delving into it.
Also tightened up the code in the affected area and removed an unused using statement.
James Rinker
James Rinker
Eideren
Sebastian Gregor
Marian Dziubiak
Tebjan Halm
allcontributors[bot]
Ikko Ashimine
Jorn Theunissen