Граф коммитов

1207 Коммитов

Автор SHA1 Сообщение Дата
Rob Mensching b40e9a32c2 WiX Toolset v3.14.1 2024-03-22 12:27:49 -07:00
Rob Mensching 6d372e5169 Protect elevated working folder from malicious data
When running elevated, Burn uses the Windows Temp folder as its working folder
to prevent normal processes from tampering with the files. Windows Temp does
allow non-elevated processes to write to the folder but they cannot see the
files there. Unfortunately, contrary to our belief, non-elevated processes
can read the files in Windows Temp by watching for directory changes. This
allows a malicious process to lie in wait, watching the Windows Temp folder
until a Burn process is launched elevated, then attack the working folder.
Mitigate that attack by protecting the working folder to only elevated users.

Managed custom actions also fall back to using the Windows Temp folder in
some cases and thus can be exposed in a similar fashion as an elevated Burn
process. Remove that possibility.
2024-03-22 01:04:33 -07:00
Bob Arnson 93eeb5f683 Don't follow junctions when recursing directories.
When deleting directories recursively, an elevated custom action
following junctions in a user-writable location could recurse into
any directory, including some that you might not want to be deleted.
Therefore, avoid recursing into directories that are actually
junctions (aka "reparse points").

This applies to:

- The RemoveFoldersEx custom action (which doesn't actually do deletions
but would instruct elevated MSI to delete on your behalf).
- DTF's custom action runner.
2024-03-22 01:03:57 -07:00
Rob Mensching ae624c0359 Revert the mergemod.cub to pre-ARM64 builds to fix MSM validation
When introducing ARM64 support into the Windows Installer, Microsoft broke
the ICE CUBe files in various ways. To minimize the impact of the breakage
move the mergemod.cub file back to pre-ARM64 support. Validating ARM64 Merge
Modules is not likely to work but that option is better than the regression.

Fixes wixtoolset/issues#8065
2024-03-22 00:45:01 -07:00
Rob Mensching cb776056bb Do not follow junctions when recursively deleting directories
This will prevent elevated processes from accidentally following a junction
from a user-writable directory to a per-machine directory and erroneously
deleting the per-machine contents.
2024-02-06 12:09:39 -08:00
Rob Mensching ea94ed02e4 Modernize signing infrastructure 2024-01-29 01:09:51 -08:00
Bob Arnson 5eaf0dfdcc Mitigate .local DLL redirection Windows bug. 2024-01-29 01:09:51 -08:00
Ben Walding c5117b5850
Update links (#548)
* Update links

It's an older code but it checks out.

* Tweak URLs

Co-authored-by: Bob Arnson <bob@firegiant.com>
2022-11-15 20:53:10 -05:00
WixBuild 6b461364c4 WixBuild: Version 3.14.0.6526 2022-05-26 08:29:17 -07:00
Herrum cb516f2430
Added Dutch translation for UtilExtension. (#541) 2022-04-03 22:10:45 -04:00
Evan Zhou 2a0077bd1b added zh-cn.wxl into WixUtilExtension.dll 2022-04-03 22:06:06 -04:00
Bob Arnson 9871b10614 VS2022 support 2022-03-19 20:06:30 -04:00
Rob Mensching b496a8fdc2 Add CLA Bot as workflow 2021-10-18 06:56:01 -07:00
WixBuild c02e48ec30 WixBuild: Version 3.14.0.5722 2021-09-22 09:05:36 -07:00
Sean Hall 19030abcd8 Fix building bundles on FIPS-enabled machines. 2021-09-21 10:45:51 -07:00
Sean Hall 03d9a66371 Update NetFx package groups for their SHA2 updates. 2021-09-21 10:45:46 -07:00
WixBuild 45a9443408 WixBuild: Version 3.14.0.5721 2021-09-21 08:53:28 -07:00
Vilius Šumskas 9168791f7b Add Lithuanian translation for UtilExtension 2021-09-15 17:56:36 -04:00
Heath Stewart 74333b141a Correct sample for SetProperty/@Sequence
Since the deferred custom action is scheduled only in `InstallExecuteSequence`, the `SetProperty/@Sequence` attribute must be set to "execute" since the default is "both". This leads to a LGHT0001 error about a missing `ActionRow` that can be difficult to diagnose.
2021-09-15 17:53:13 -04:00
Sean Hall 38c8293f76 Update documentation that NativeMachine was added in v3.14.
Also recommend NativeMachine over ProcessorArchitecture when available.
Fix style nits.
2021-09-14 14:13:21 -05:00
Sean Hall d91b0b867c
Merge pull request #538 from ericstj/addNativeMachine
Add NativeMachine to Burn and WIX_NATIVE_MACHINE to UtilExtension
2021-09-14 14:11:42 -05:00
Eric StJohn e77c30df95 Don't set NativeMachine variables when IsWow64Process2 is unavailable 2021-09-13 13:49:05 -07:00
Eric StJohn 75699d898b Add NativeMachine to Burn and WIX_NATIVE_MACHINE to UtilExtension 2021-08-28 10:34:10 -07:00
Bob Arnson 58abd6993a Drop XP support for v3.14 => v4 transition. 2021-07-18 20:52:37 -04:00
Bob Arnson 376423b810 WIXBUG:6143 - Correct Payload/@SuppressSignatureVerification doc.
Fixes https://github.com/wixtoolset/issues/issues/6143.
2021-03-28 20:31:27 -04:00
Bob Arnson 68c503edce Add null check so we don't crash if we don't know the package id. 2021-03-26 10:33:33 -04:00
Sean Hall 6e0bab12e1
Merge pull request #525 from rseanhall/6299-overflow-exception
WIXBUG:6299 - Fix OverflowException in ReadUInt32
2021-02-22 20:54:02 -06:00
Sean Hall 88d8159c7b
Merge pull request #527 from drolevar/fix_image_drawing
WIXBUG4931 Fix drawing of image static controls
2021-02-22 20:53:48 -06:00
Andrij Abyzov 3b6a99a30c WIXBUG4931 Fix drawing of image static controls 2021-02-09 17:56:32 +01:00
Sean Hall 4f4b7d9484 WIXBUG:6299 - Fix OverflowException in ReadUInt32. 2020-12-14 15:06:57 -06:00
Jürgen Fischer 2ed6d7906c Another fix for ru-ru.wxl 2020-07-29 08:39:03 -04:00
Jozef Izso ed63c19dd8 Add support for two new controls: SuccessInstallDescription and SuccessInstallIllustration 2020-06-11 17:32:36 -04:00
Sean Hall c3326747d9 WIXFEAT:5575 Add MSI properties for 4.7 and 4.7.1. 2020-06-11 17:14:26 -04:00
Sean Hall a0b2b2f746 WIXFEAT:5575,5977 - Add .NET 4.7.2 and .NET 4.8 to NetFxExtension. 2020-06-11 17:14:26 -04:00
David Taylor 7ddb89efe2 Fix typo in CloseApps.cpp 2020-06-10 19:13:17 -07:00
vasa911 978c7d36e1 fix typo in ru-ru.wxs 2020-06-10 19:54:06 -04:00
vasa911 7cd6966931 Change culture property from "en-us" to "ru-ru" in ru-ru.xml 2020-06-10 19:54:06 -04:00
vasa911 69b0244532 Add reference to ru-ru.wxl in .wixproj file 2020-06-10 19:54:06 -04:00
Vadym a51cdba963 Add support for ru-ru in utilextensions
In order to fix error:
The localization variable !(loc.msierrSecureObjectsUnknownType) is unknown.  Please ensure the variable is defined.
in UtilExtension.wxs  when using ru-Ru localization.
2020-06-10 19:54:06 -04:00
Zoli 8ab724f659 Fix #4250
Support paths in quotes for registry entries.
2020-06-10 19:38:24 -04:00
Jozef Izso 95838b9b50 Localize missing entries in Slovak translation 2020-06-10 19:12:16 -04:00
seph f68fa8ee70 Update documentation to include CNDL1150 warning
This imports the [1150](e8504c54e4) error message into the documentation.

Fixes #5964
2020-06-10 19:11:14 -04:00
Blair L Murri 3f92e7ce06 Fixes wixtoolset/issues#6031
wix4 is separate
2020-06-10 19:05:18 -04:00
Rob Mensching 102d2f6433 Remove unusued tools with security flaws
Fixes wixtoolset/issues#5594
2020-06-08 14:49:44 -07:00
Jozef Izso 2bd14f0417 Add WindowsBuildNumber variable which is set to dwBuildNumber from RtlGetVersion()
Implements #6026
2020-05-27 19:08:14 -04:00
WixBuild 7ab72f4723 WixBuild: Version 3.14.0.4118 2020-05-18 14:08:41 -07:00
Sean Hall d44e926a00 WIXBUG:4342 - Force cancel if m_fShowingInternalUiThisPackage
Add critical section for m_fShowingInternalUiThisPackage since OnExecutePackageBegin happens on the Burn thread and OnClose happens on the UI thread.
2020-05-11 21:54:22 +10:00
Sean Hall fccd916cb3 WIXBUG:6158 - Fix bug with m_fShowingInternalUiThisPackage
where it was calculated with the bundle action instead of the package action.
2020-05-11 21:54:22 +10:00
Bob Arnson 750cfc9e8f Deprecate WixGamingExtension (going away in WiX v4). 2020-05-01 21:26:56 -04:00
Nikola Milosavljevic (CLR) e0049d7a81 Use IsWow64Process2 if available to determine Wow64 process 2020-05-01 18:44:56 -04:00