Add the text "“This repository is no longer actively maintained or developed.” to
the README for this public repo. UITools is the last remaining client that uses
this code & it now embeds the source in its repo.
For compliance we can't use the default public NuGet feed.
Instead, use the same feeds (some of them) that are used for xamarin-android (https://github.com/xamarin/xamarin-android/blob/main/NuGet.config), another public repo.
Also disable building for Mac, since it's no longer needed.
NSTableView.FullWidth is only explicitly supported on Big Sur
and later, so don't set it for older versions of macOS.
For older versions of macOS, FullWidth is apparently the default
so doesn't need to be specified.
This updates the layout UI tweaks included in
https://github.com/xamarin/Xamarin.PropertyEditing/pull/817.
Fixes AB#1776438s
When using the latest internal .NET SDK the build will fail since
Xamarin.PropertyEditing cannot resolve the latest packages since
all internal package sources are cleared. Resulting in a build failure:
error NU1102: Unable to find package Microsoft.NETCore.App.Ref with version (= 6.0.14)
* Show proper expanded icon by default
Fix so that when a category is expanded by default the UI shows the proper icon (the expanded icon, not collapsed).
There are two main changes here:
Remove the code added in 96561f1 to support custom disclosures for Catalina. That's no longer required in newer versions of macOS. Now we just let AppKit handle setting the right disclosure icon.
Add call to UpdateExpansions in OnPropertiesChanged, so that the default expansion state is correct when the property editor context changes, ensuring that categories are autoexpanded when they are supposed to be.
Fixes AB#1559942
If a predefined property value is set that doesn't match
one of the standard options, then set it as the valueName,
same as if it was passed in the ValueDescriptor. This fixes
showing the custom value in the property editor UI.
Fixes AB#1600201.
Proppy's intention may have been that custom values like
this should be set in the ValueDescriptor instead of Value -
I'm not sure about that. However the Forms XAML code
doesn't do that. Given that, and the fact that there's no harm
is allowing custom values to be specified in the Value instead
of just ValueDescriptor, we now support both.
* Avoid excess margins on left/right of property editor
The property editor (for reasons I don't fully understand,
but maybe due to move away from a Gtk wrapper)
has noticably wider margins on the left & right in 17.x
as compared to 8.x. It's especially noticable on the
right hand side.
This change fixes that, setting the property table style to
NSTableViewStyleFullWidth, so rows fill the full width of
the table. It also adjusts the left and right margins and
space between the labels and controls, per design
recommendations.
* Hide Name UI unless object is nameable
The Name field should only show in the property UI
if the object is nameable - which it normally isn’t.
The Name UI is properly hidden on VS Windows - it
just wasn’t on Mac. That’s fixed now.
Fixes AB#1615257
* Tweak margins
* Use a variable width for the property search filter
Make VSMac have variable width for the property search
area instead of the fixed width of 150. That makes
it behave more like Windows, where the width is also
variable, allowing more space for the user to type.
Also, the left/right/top margins around the search control
are tweaked, per design input from Hylke.
It also fixes AB#1522517.
* Update to use Leading/Trailing instead of Left/Right
* Update margins
* Remove some of the spacing on right of search control
Remove the call to UpdateExpansions after ReloadData in response to
OnPropertiesChanged (e.g. called when selection changes). This
doesn't seem necessary, as when views are recreated their
expansion status is set correctly originally and AppKit
remembers expansion state after.
Further, this fixes AB#1521131, where the Name and Type rows are
sometimes blank - apparently expanding manually, and doing it
synchronously like that, causes the NSOutlineView
to get confused and not show the top row sometimes.
Bret Johnson
Mike Bond
Matt Sylvia
James Parsons
Matt Ward
Michael Cummings (MSFT)
Sandy Armstrong
Connor Adsit
Jose Medrano
