Also adapted Build Agent and MSBuild Tasks to the new Messaging changes
This brings important changes in Xamarin.Messaging to fix an SSH incompatibility with macOS Ventura and also to fix some issues with the iOS remote build with multi targeting dotnet scenarios and also scenarios mixing dotnet and traditional Xamarin projects in the same VS session
Backport of #16419
Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
Current versions in this branch:
Microsoft.iOS 16.1.1419-net7.0-xcode14.1+sha.51ad25e7b64
Microsoft.tvOS 16.1.1419-net7.0-xcode14.1+sha.51ad25e7b64
Microsoft.MacCatalyst 16.1.1419-net7.0-xcode14.1+sha.51ad25e7b64
Microsoft.macOS 13.0.1974-net7.0-xcode14.1+sha.51ad25e7b64
Compare with the `release/6.0.4xx-xcode14.1` branch version numbers (from #16431):
Microsoft.iOS 16.1.179+sha.2107639a131
Microsoft.tvOS 16.1.179+sha.2107639a131
Microsoft.MacCatalyst 16.1.179+sha.2107639a131
Microsoft.macOS 13.0.734+sha.2107639a131
the buffer is >1000 commits.
Also adapted Build Agent and MSBuild Tasks to the new Messaging changes
This brings important changes in Xamarin.Messaging to fix an SSH incompatibility with macOS Ventura and also to fix some issues with the iOS remote build with multi targeting dotnet scenarios and also scenarios mixing dotnet and traditional Xamarin projects in the same VS session
Backport of #16419
Co-authored-by: Mauro Agnoletti <mauro.agnoletti@gmail.com>
When a property is declared as ArgumentSemantic.Copy, we'll copy the input value in property setters.
Unfortunately this makes UIKit crash, because for
UITextField.SelectedTextRange UIKit might use a custom UITextRange subclass,
with a broken 'copy' implementation (doesn't copy all the fields), that
subsequently makes the app crash.
On the other hand, UITextRange doesn't conform to NSCopying, and as such is in
theory not necessarily copyable, and thus I believe the bug is really that the
property is declared as a 'copy' property.
Fixes https://github.com/xamarin/xamarin-macios/issues/15677.
Backport of #16201
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Then I had to bump the Xamarin.iOS version too, so that we have the same commit distance for both, otherwise this happens:
```
*** The commit distance for Xamarin.iOS (111) and Xamarin.Mac (0) are different.
*** To fix this problem, bump the revision (the third number) for both IOS_PACKAGE_NUMBER and MAC_PACKAGE_NUMBER in Make.versions.
*** Once fixed, you need to commit the changes for them to pass this check.
```
Remove the argument to specify the GitHub comments file, because it's overwritten with a computed value (i.e. completely ignored), and thus confusing what's supposed to happen in the calling script.
Also compute the default earlier, so that it's set to the expected value by the time we have error reporting that will try to write to the comments file.
This way the api diff job can be re-run and not fail because the artifact
already exists:
> ##[error]Artifact 'DropMetadata-ChangeDetection' already exists. If the build is producing multiple Drops, the Drop Metadata Container Name should be unique for each Drop.
Unfortunately builds fail often in CI due to random network errors. So try to
make downloading with curl a bit more resilient by re-trying downloads a few
times before giving up.
Bumps
[xamarin/backport-bot-action](https://github.com/xamarin/backport-bot-action)
from 1.0 to 1.1.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="c27c1d5a07"><code>c27c1d5</code></a>
Scope env to step</li>
<li><a
href="da97d664ca"><code>da97d66</code></a>
Inputs -> secrets</li>
<li><a
href="7d536aa14f"><code>7d536aa</code></a>
Update inputs -> secrets</li>
<li><a
href="69c12fcadc"><code>69c12fc</code></a>
Create reusable workflow to replace composite action</li>
<li>See full diff in <a
href="https://github.com/xamarin/backport-bot-action/compare/v1.0...v1.1">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This test requires another platform to be enabled in addition to the current
platform being tested: that other platform is iOS when testing macOS, and
macOS for all other platforms.
This can be seen in the target frameworks for the referenced library projects:
MacCatalyst/Library.csproj: <TargetFrameworks>net$(BundledNETCoreAppTargetFrameworkVersion)-macos;netstandard2.1</TargetFrameworks>
iOS/Library.csproj: <TargetFrameworks>net$(BundledNETCoreAppTargetFrameworkVersion)-macos;netstandard2.1</TargetFrameworks>
macOS/Library.csproj: <TargetFrameworks>net$(BundledNETCoreAppTargetFrameworkVersion)-ios;netstandard2.1</TargetFrameworks>
tvOS/Library.csproj: <TargetFrameworks>net$(BundledNETCoreAppTargetFrameworkVersion)-macos;netstandard2.1</TargetFrameworks>
We can't process a common-fx.ignore file for a given framework if that
framework isn't included in any of the platforms we're building for.
Example: we can't process common-AppKit.ignore when only iOS is enabled,
because none of the errors listed in common-AppKit.ignore will be reported for
an iOS build.
Alex Soto
Rolf Bjarne Kvinge
VS MobileTools Engineering Service 2
Manuel de la Pena
GitHub Actions Autoformatter
dependabot[bot]
Simon Rozsival