A recent package update broke the tool so we are adding a lock file to
ensure we have a reliable execution.
For details the newer version of
https://www.npmjs.com/package/shiki?activeTab=versions version 1.23.0
introduced a new dependency in https://github.com/shikijs/shiki/pull/832
which no longer compiles.
```
node_modules/oniguruma-to-es/types/parse.d.ts(61,49): error TS2339: Property 'orphan' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,31): error TS2339: Property 'atomic' does not exist on type '{}'.
node_modules/oniguruma-to-es/types/parse.d.ts(96,39): error TS2339: Property 'flags' does not exist on type '{}'.
```
Until we figure out what the best way to fix those issues we are pinning
to the older version using a lock file.
### Packages impacted by this PR
- @azure/communication-sms
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates @azure/communication-sms to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure-rest/communication-job-router
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates the @azure-rest/communication-job-router package to ESM and
vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure-rest/communication-messages
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates the @azure-rest/communication-messages package to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
A few fixes as a result of the identity ESM migration:
1. Missing `ctx` parameter that's now fixed
2. Default vitest config excludes managed identity tests. Adding a
separate vitest config for managed identity test runs fixes this
### Packages impacted by this PR
- @azure/communication-email
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates the @azure/communication-email package to ESM/vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/communication-identity
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates the @azure/communication-identity package to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
None
### Issues associated with this PR
None
### Describe the problem that is addressed by this PR
Using the JavaScript Debug Terminal and auto-attaching to every
subprocess results in a long wait time to hit breakpoints when debugging. To
improve the experience, we can include a launch.json configuration that allows
running vitest tests and only attaching to the vitest process itself.
Because we need the test proxy running, using dev-tool is the
recommended way to run tests. This PR adds the proper configuration
to support that scenario.
While here I also went ahead and removed `node_modules` from VSCode's
exclusion list so they show up in the file explorer. Happy to revert that but I
find it difficult to dig into dependencies and set breakpoints in node modules
when they are hidden.
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Removed runName support from the wsEndpoint
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
Added X-MS-Package-Version header to connect session API for language
and package version decoding.
### Need to discuss
The getReporterVersion function returns the reporter version, which
includes a special character ("."). This caused tests to fail with the
error: "Invalid character in header content ["x-ms-package-version"]."
Therefore, the characters were escaped.
Since we are passing the header from the package, this needs to be
handled by the server. We are encoding it here, but it needs to be
decoded on the server side.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
yes
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/identity-broker
@azure/identity
### Issues associated with this PR
#31338
### Describe the problem that is addressed by this PR
Migrates identity and identity-broker to ESM, tshy, and Vitest
### Packages impacted by this PR
@azure/core-client-rest
@azure/ts-http-runtime
### Issues associated with this PR
N/A - found in passing
### Describe the problem that is addressed by this PR
The existing regex for finding template values to replace assumes only
`\w` characters are allowed in the template, but
`-` should be valid for a template name
This PR is used to update the Sinon library version for Chat JS SDK.
**Why is this change needed?**
We updated the Sinon Library Version of Signaling Client Code Repo to
resolve a government alert. And Chat SDK will depend on signaling
client. If they have the same dependency installed, the dependency
version should be the same.
As a result, we are supposed to update the library version of JS SDK for
version number alignment.
**Testing**
1.Unit tests passed after the change
2.E2E test passed using the sample app
### Packages impacted by this PR
- @azure/communication-job-router
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates @Azure/communication-job-router to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
For packages that have been migrated to ESM, Rolled up dts files are no
longer used but they are still packaged because our `files` field
include an entry of `dist/`. Since they are not used anymore, this PR
stops generating them, instead of more complicated approach of excluding
them from `npm pack`.
### Packages impacted by this PR
### Issues associated with this PR
### Describe the problem that is addressed by this PR
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/communication-phone-numbers
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Upgrades @azure/communication-phone-numbers to use ESM and vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
* ensure that ChangedServices value within the generated pr diff is always properly an array of strings
* upload the changed services as an attachment named AdditionalTags in save-package-properties.yml, to allow PipelineWitness to tag public builds during log processing
---------
Co-authored-by: Scott Beddall <scbedd@microsoft.com>
Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Patrick Hallisey <hallipr@gmail.com>
### Packages impacted by this PR
- @azure-tools/communication-recipient-verification
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Moves @azure-tools/communication-recipient-verification to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure-tools/communication-short-codes
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrate @azure-tools/communication-short-codes to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure-tools/communication-tiering
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Moves the package to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure-tools/communication-toll-free-verification
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates the package to ESM/vitest.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/microsoft-playwright-testing
### Issues associated with this PR
### Describe the problem that is addressed by this PR
Upload buffer and upload file methods weren't awaited and hence
sometimes missed resulting in 404 in webapp.
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
- @azure/communication-alpha-ids
### Issues associated with this PR
- https://github.com/Azure/azure-sdk-for-js/issues/31338
### Describe the problem that is addressed by this PR
Migrates @azure/communication-alpha-ids to ESM/vitest
### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
### Are there test cases added in this PR? _(If not, why?)_
### Provide a list of related PRs _(if any)_
### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_
### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
#31185
This PR adds `enableCAE: true` by default. The updated logic for
`BearerAuthenticationPolicy` is as follows:
- Check if initial response returns a challenge
- If CAE challenge, handle it and return whatever response received next
- If not CAE challenge and a custom challenge handler is provided
through `authorizeRequestOnChallenge`, use custom handler to handle the
challenge. If there is another CAE challenge after, handle it and return
whatever response next. At max, the policy will resolve 2 challenges (1
non-CAE and 1 CAE challenge)
Scott Beddall
Wes Haggard
Lazar
ZiWei Chen
Matthew Podwysocki
Maor Leger
Kashish Gupta
Azure SDK Bot
angellan-msft
Jeremy Meng
Juntu Chen
hamshavathimunibyraiah
Minh-Anh Phan
Albert Cheng
Siddharth Singha Roy
Daniel Jurek