f95e1d8ea0
chore: fix textured window conditional on macOS ( #44728 )
2024-11-20 10:34:46 -06:00
eba0edf81e
build: allow unbundling of Node.js dependencies ( #44754 )
2024-11-20 11:34:37 -05:00
8223ebc111
test: run script to help target discovery and reduce flakes ( #44741 )
2024-11-20 08:55:09 -06:00
54d53bfa51
fix: tooltips in WCO caption buttons ( #44721 )
...
fix: tooltips in WCO capton buttons
2024-11-20 12:45:08 +01:00
8ed48e2295
build(deps): bump mikefarah/yq from 4.44.3 to 4.44.5 ( #44714 )
...
Bumps [mikefarah/yq](https://github.com/mikefarah/yq ) from 4.44.3 to 4.44.5.
- [Release notes](https://github.com/mikefarah/yq/releases )
- [Changelog](https://github.com/mikefarah/yq/blob/master/release_notes.txt )
- [Commits](bbdd97482f...bc5b54cb1d
2024-11-20 10:49:50 +01:00
43ed763f18
chore: bump chromium to 133.0.6846.0 (main) ( #44665 )
...
* chore: bump chromium in DEPS to 133.0.6836.0
* chore: bump chromium in DEPS to 133.0.6838.0
* chore: update patches
* 6006096: [Sync ESB] Integrate Chrome Toast UI
https://chromium-review.googlesource.com/c/chromium/src/+/6006096
* Confine enable_device_bound_sessions buildflag to //net
https://chromium-review.googlesource.com/c/chromium/src/+/6014679
* revert [api] Delete deprecated struct FastApiTypedArray
https://chromium-review.googlesource.com/c/v8/v8/+/5982984
Also
https://chromium-review.googlesource.com/c/v8/v8/+/5979766/1
* fixup revert [api] Delete deprecated struct FastApiTypedArray
* Migrate remaining NOTREACHED()s in chrome/
https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* [Reland][Extensions] Remove ExtensionHostDelegate::GetJavaScriptDialogManager()
https://chromium-review.googlesource.com/c/chromium/src/+/6020106
* Remove NOTREACHED_IN_MIGRATION()
https://chromium-review.googlesource.com/c/chromium/src/+/6021996
* Remove Lock screen apps [#8 ] : remove lock screen extension
https://chromium-review.googlesource.com/c/chromium/src/+/6005846
* Reland "Add CrashReporterClient::GetProductInfo(ProductInfo*)"
https://chromium-review.googlesource.com/c/chromium/src/+/6012631
* Ozone/Wayland: remove lacros specific window states
https://chromium-review.googlesource.com/c/chromium/src/+/6011215
* chore: bump chromium in DEPS to 133.0.6840.0
* chore: bump chromium in DEPS to 133.0.6841.0
* chore: bump chromium in DEPS to 133.0.6844.0
* implement virtual WebContents::CanUserEnterFullscreen
* OnSearchifyStateChange -> OnSearchifyStarted
* regen libc++ filenames
* chore: bump chromium in DEPS to 133.0.6846.0
* chore: update patches
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
Co-authored-by: Samuel Maddock <smaddock@slack-corp.com>
2024-11-19 19:52:20 -08:00
ac61c74ddc
fix: bugprone-narrowing-conversions warnings in NativeImage ( #44708 )
...
* fix: bugprone-narrowing-conversions warning in NativeImage::memory_usage_
- fix signed / unsigned math by using base/numerics/safe_conversions
- make memory_usage_ an int64_t so it can safely take the size_t
returned by computeByteSize()
Warning fixed by this commit:
../../electron/shell/common/api/electron_api_native_image.cc:155:26: warning: narrowing conversion from 'size_t' (aka 'unsigned long') to signed type 'int32_t' (aka 'int') is implementation-defined [bugprone-narrowing-conversions]
155 | new_memory_usage = image_skia->bitmap()->computeByteSize();
* fix: bugprone-narrowing-conversions warnings in NativeImage::CreateFromBitmap()
`SkImageInfo::MakeN32()` and `SkBitmap::allocN32Pixels()` both take int
width and height args, but we were feeding them unsigned ints.
../../electron/shell/common/api/electron_api_native_image.cc:508:36: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:508:43: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
508 | auto info = SkImageInfo::MakeN32(width, height, kPremul_SkAlphaType);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:25: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:524:32: warning: narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
524 | bitmap.allocN32Pixels(width, height, false);
| ^
../../electron/shell/common/api/electron_api_native_image.cc:528:48: warning: narrowing conversion from 'double' to 'float' [bugprone-narrowing-conversions]
528 | gfx::ImageSkia::CreateFromBitmap(bitmap, scale_factor);
2024-11-19 16:04:18 -06:00
1cf5e6d88c
fix: cyclical #include dependency between autofill_popup.h and autofill_popup_view.h ( #44705 )
...
fix: AutofillPopup warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
refactor: reduce #indclude scope in autofill_popup.h and autofill_popup_view.h
2024-11-19 13:45:18 -06:00
48c9149a52
fix: utility process exit code for graceful termination (reland) ( #44726 )
...
* chore: reland "fix: utility process exit code for graceful termination"
This reverts commit 1cae73ba09
2024-11-20 02:48:15 +09:00
0d6743e79b
fix: destroy url loader wrapper when JS env exits ( #44574 )
...
* fix: destroy url loader wrapper when JS env exits
* Revert "fix: destroy url loader wrapper when JS env exits"
This reverts commit 419151a98a4b401b03c6
2024-11-19 11:32:48 -05:00
7a5e9613d2
build: rework header generation in Node.js ( #44657 )
...
* build: rework header generation in Node.js
* build: fix patch location error
* fix: set --root-dir correctly
2024-11-19 10:57:38 -05:00
9d1be5f824
build(deps): bump the npm_and_yarn group across 2 directories with 1 update ( #44701 )
...
Bumps the npm_and_yarn group with 1 update in the / directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [cross-spawn](https://github.com/moxystudio/node-cross-spawn ).
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
Updates `cross-spawn` from 7.0.3 to 7.0.6
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md )
- [Commits](https://github.com/moxystudio/node-cross-spawn/compare/v7.0.3...v7.0.6 )
---
updated-dependencies:
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
- dependency-name: cross-spawn
dependency-type: indirect
dependency-group: npm_and_yarn
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-19 15:06:42 +01:00
4b3d1caae4
fix: improve single-pixel resize handling on Windows ( #44700 )
...
Co-authored-by: Niklas Wenzel <dev@nikwen.de>
2024-11-19 13:24:07 +01:00
2cea2282eb
build(deps): bump slackapi/slack-github-action from 1.27.0 to 2.0.0 ( #44715 )
...
Bumps [slackapi/slack-github-action](https://github.com/slackapi/slack-github-action ) from 1.27.0 to 2.0.0.
- [Release notes](https://github.com/slackapi/slack-github-action/releases )
- [Commits](37ebaef184...485a9d42d3
2024-11-19 11:45:56 +01:00
8efc4c7a56
build(deps): bump github/codeql-action from 3.27.1 to 3.27.4 ( #44713 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.1 to 3.27.4.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](4f3212b617...ea9e4e3799
2024-11-19 11:45:09 +01:00
febf305a4f
chore: fix unsupported major comment in issue automation ( #44706 )
2024-11-19 10:52:08 +01:00
1cae73ba09
chore: Revert "fix: utility process exit code for graceful termination" ( #44717 )
...
Revert "fix: utility process exit code for graceful termination (#44698 )"
This reverts commit 36e1a0bf00
2024-11-18 22:13:23 -06:00
10d967028a
docs: Make ipcRenderer and ipcMain listener API docs consistent ( #44651 )
...
* docs: Make ipcRenderer and ipcMain listener API docs consistent
* test: add some unit tests for ipcRenderer/ipcMain listener behavior
* fix: Mark on/off methods as primary and addListener/removeListener as aliases
* fix: clear all listeners before running ipcMain removeAllListeners tests
2024-11-18 14:44:30 -08:00
aa7a5e6ca9
docs: document why to use the loadBrowserProcessSpecificV8Snapshot fuse ( #44680 )
...
Fixes #44450
2024-11-18 14:36:41 -08:00
58dc990f7a
chore: fix multi-version parsing in issue assignment ( #44679 )
...
* chore: fix multi-version parsing
* chore: tweak for review
2024-11-18 21:25:20 +01:00
36e1a0bf00
fix: utility process exit code for graceful termination ( #44698 )
2024-11-18 23:57:06 +09:00
d320840a54
build: re-enable `container_overflow` ASAN check ( #44699 )
...
build: re-enable container_overflow ASAN check
2024-11-18 09:22:17 -05:00
dd50afa8c2
fix: `utilityProcess` pid should be `undefined` after exit ( #44677 )
...
fix: utilityProcess pid should be undefined after exit
2024-11-18 10:06:27 +01:00
15ff999bdc
build: update appveyor image to latest version ( #44675 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-15 14:54:00 -05:00
a15e42e9ff
chore: cleanup following internal switch to `readPackageJSON` ( #44644 )
...
chore: cleanup following internal switch to readPackageJSON
2024-11-15 11:36:18 -05:00
aca84be970
chore: update extensions features ( #44653 )
...
* chore: update extensions features
* restore header
2024-11-15 11:32:43 -05:00
4fb5aab2ef
fix: revert required portal version for file chooser dialogs ( #44426 )
...
* feat: add support for configuring xdg portal version at runtime
* doc: update command-line-switches.md
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* doc: required portal version for defaultPath support
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
* doc: update more occurrances
* fix: remove warning from save dialogs
* doc: update command-line-switches.md
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-15 09:31:33 -05:00
27fe6cc97f
fix: `WebContentsView` removal should compare directly ( #44656 )
...
* fix: WebContentsView removal should compare directly
* fixup view comparision
* chore: use erase_if
* Apply review suggestions
---------
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-14 22:11:20 -05:00
b1957f52e3
chore: bump chromium to 132.0.6834.0 (main) ( #44602 )
...
* chore: bump chromium in DEPS to 132.0.6827.0
* chore: bump chromium in DEPS to 132.0.6828.0
* chore: bump chromium in DEPS to 132.0.6830.0
* chore: bump chromium in DEPS to 132.0.6832.0
* chore: bump chromium in DEPS to 132.0.6834.0
* chore: update chromium patches
* 5977022: Apply os setting of overlay scrollbar to web instances | https://chromium-review.googlesource.com/c/chromium/src/+/5977022
* 5991440: Cleanup //ui/compositor from LaCros support code. | https://chromium-review.googlesource.com/c/chromium/src/+/5991440
* chore: update all patches
* 6000058: Add base_subdirs to file_chooser.mojom NativeFileInfo | https://chromium-review.googlesource.com/c/chromium/src/+/6000058
* 6009949: Rename NOTREACHED_NORETURN() uses to NOTREACHED() | https://chromium-review.googlesource.com/c/chromium/src/+/6009949
* 5966419: [freezing] Expose frozen state to extensions (3/3 - add frozen to chrome.tabs.Tab).
https://chromium-review.googlesource.com/c/chromium/src/+/5966419
Also https://chromium-review.googlesource.com/c/chromium/src/+/6006424
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>
2024-11-14 18:18:11 +01:00
8a67e77f03
build: fix python warnings "SyntaxWarning: invalid escape sequence '\w'" ( #44650 )
...
* fix: SyntaxWarning: invalid escape sequence '\w'
* chore: remove some unused imports
* fix: E711 warning 'Comparison to should be '
2024-11-14 12:27:20 +01:00
41b5d7e312
refactor: unfilter unresponsive events ( #44629 )
...
* feat: internal -unresponsive event
* Reland "refactor: JSify BrowserWindow unresponsive handling"
This reverts commit ef7ae78ed4
2024-11-13 17:59:13 -08:00
946ab5f1d7
build: reland bump Node.js to v22.9.0 ( #44597 )
...
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
2024-11-13 15:34:30 +01:00
0fd16dc9e2
fix: WCO buttons hidden on Linux in fullscreen ( #44621 )
...
Closes https://github.com/electron/electron/issues/44569 .
Fixes an issue where the WCO buttons were hidden on Linux in fullscreen mode
but not on Windows or macOS. The Windows behavior is the expected one, so this
commit makes the Linux behavior consistent.
2024-11-13 15:11:58 +01:00
a120d87570
fix: add theme data source for devtools. ( #44114 )
...
* fix: add theme data source for devtools.
* chore: add ut.
* chore: remove recording histograms
* fix: add theme data source for devtools.
* chore: separate files
* chore: separate files
* chore: remove pragma once
* chore: fix lint issue.
2024-11-13 13:23:37 +01:00
d380cda14a
ci: remove from issue triage on issue transferred ( #44631 )
2024-11-13 12:05:11 +01:00
80ff7a14c6
test: exercise fuller `globalShortcut` matrix ( #44488 )
...
test: test fuller globalShortcut matrix
2024-11-12 15:31:39 -05:00
7a79d4c96e
feat: add optional animation parameter to BrowserWindow.setVibrancy ( #35987 )
...
adds optional animation parameter to BrowserWindow.setVibrancy
2024-11-12 09:03:30 -08:00
a6390b539c
build(deps): bump github/codeql-action from 3.27.0 to 3.27.1 ( #44611 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.0 to 3.27.1.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](662472033e...4f3212b617
2024-11-12 10:29:59 -05:00
777e547922
fix: segfault when moving WebContentsView between BrowserWindows ( #44599 )
...
* fix: segfault when moving WebContentsView between BrowserWindows
* chore: actually enable fix
* fixup segfault when moving WebContentsView between BrowserWindows
2024-11-11 18:44:13 -05:00
c6c430bff1
build(deps): bump dsanders11/project-actions from 1.3.0 to 1.4.0 ( #44566 )
...
Bumps [dsanders11/project-actions](https://github.com/dsanders11/project-actions ) from 1.3.0 to 1.4.0.
- [Release notes](https://github.com/dsanders11/project-actions/releases )
- [Changelog](https://github.com/dsanders11/project-actions/blob/main/.releaserc.json )
- [Commits](eb760c4889...438b25e007
2024-11-11 21:30:31 +01:00
928c0301e7
build: update appveyor image to latest version ( #44606 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-11 13:56:59 -05:00
6e3a5daf62
chore: bump chromium to 132.0.6826.0 (main) ( #44584 )
...
* chore: bump chromium in DEPS to 132.0.6821.0
* chore: bump chromium in DEPS to 132.0.6822.0
* chore: update patches
* chore: bump chromium in DEPS to 132.0.6824.0
* chore: update patches
* 5998172: Migrate remaining NOTREACHED()s in chrome/ | https://chromium-review.googlesource.com/c/chromium/src/+/5998172
* 5872484: Pass along accelerators for menu items coming from DevTools | https://chromium-review.googlesource.com/c/chromium/src/+/5872484
* chore: update patches
* 5872913: Enable `raw_span` clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
* fixup! picture-in-picture import
* 5912245: [video pip] Add progress bar to 2024 UI | https://chromium-review.googlesource.com/c/chromium/src/+/5912245
* fixup! 5872913: Enable raw_span clang plugin [1/2] | https://chromium-review.googlesource.com/c/chromium/src/+/5872913
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
2024-11-08 16:12:42 -08:00
f9a04012b9
build: revert bump Node.js to v22.9.0 ( #44596 )
...
* Revert "chore: bump Node.js to v22.9.0 (#44281 )"
This reverts commit c63d0d61e7
2024-11-07 19:20:50 -08:00
4b57a8fb1a
chore: remove revert_mojo_force_blink_headers_to_only_be_included_in_blink.patch ( #44589 )
2024-11-07 12:30:57 -08:00
e3d75b3087
build: also lint mjs files ( #44581 )
2024-11-06 18:46:09 -05:00
ea7b0a4cc8
build: update appveyor image to latest version ( #44570 )
...
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
2024-11-06 13:54:39 -05:00
2002472b10
chore: remove unused gin::Converter<char[]>::ToV8(isolate, const char*) ( #44568 )
...
No longer needed after #44498
2024-11-06 08:49:25 -06:00
adbd25f699
chore: bump chromium to 132.0.6820.0 (main) ( #44544 )
...
* chore: bump chromium in DEPS to 132.0.6817.0
* chore: update chromium patches
* 5979290: Temoporarily disable crel on arm. | https://chromium-review.googlesource.com/c/chromium/src/+/5979290
* 5981701: Include callback.h instead of callback_forward.h | https://chromium-review.googlesource.com/c/chromium/src/+/5981701
* 5964918: [v8 code cache] Add a wpt_internal test demonstrating the code cache 304 problem | https://chromium-review.googlesource.com/c/chromium/src/+/5964918
* 5969697: Add NetworkTrafficAnnotationTag to PreconnectManager | https://chromium-review.googlesource.com/c/chromium/src/+/5969697
* chore: update remaining patches
* chore: bump chromium in DEPS to 132.0.6818.0
* chore: update patches
* 5983492: MPArch GuestView: Have executeScript target correct frame | https://chromium-review.googlesource.com/c/chromium/src/+/5983492
* chore: bump chromium in DEPS to 132.0.6820.0
* chore: update patches
* 5989717: Revert "win: Remove special check for 10.0.22621.2428 Win SDK version" | https://chromium-review.googlesource.com/c/chromium/src/+/5989717
* 5968218: Send PDF Searchifier running state to browser to show UX elements. | https://chromium-review.googlesource.com/c/chromium/src/+/5968218
* build: also update the MSVS_HASH for WOA
---------
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
Co-authored-by: VerteDinde <vertedinde@electronjs.org>
2024-11-05 16:46:57 -08:00
3090e40c09
chore: remove executable flag from docs/api/app.md file permissions ( #44548 )
...
chore: set docs/api/app.md file permissions to 644
md files should not be executable
2024-11-05 11:48:23 -05:00
4f2fb7b1a0
docs: clarify that sessions use cache by default ( #44547 )
2024-11-05 10:27:19 -06:00
Shelley Vohr
Sam Maddock
dependabot[bot]
electron-roller[bot]
Charles Kerr
Robo
David Sanders
Will Anderson
Niklas Wenzel
electron-appveyor-updater[bot]
Sam Maddock
Keeley Hammond
BILL SHEN
Gellert Hegyi
John Kleinschmidt
Samuel Attard