### Summary of the changes
Now that https://github.com/dotnet/roslyn/pull/72237 has merged on the
Roslyn side, we need to update Razor to consume the source package
version. This will allow us to delete the nuget package version
-
Fixes:
Fixes#10158
I recommend reviewing commit-by-commit.
Razor has had a `BatchingWorkQueue` for a long while that has dubious
semantics. It is used by three features:
- `OpenDocumentGenerator` - Listens for document updates, computes
generated output for each, and notifies listeners when a document has
been processed.
- `WorkspaceSemanticTokensRefreshPublisher` - Called in the server to
send the client `semanticTokens/refresh` notifications. This really sort
of abuses `BatchingWorkQueue` just for debouncing and only send
notifications every 250 milliseconds.
- `WorkspaceProjectStateChangeDetector` - Listens for Roslyn workspace
and Razor project manager changes and calls into
`IProjectWorkspaceStateGenerator.Update(...)` when a change occurs.
This change fully replaces `BatchingWorkQueue` with a copy of Roslyn's
`AsyncBatchingWorkQueue`, which has consistent semantics and has been
battle-hardened for years. I've updated `OpenDocumentGenerator` and
`WorkspaceProjectStateChangeDetector` above to use
`AsyncBatchingWorkQueue`. For `WorkspaceSemanticTokensRefreshPublisher`
(now `WorkspaceSemanticTokensRefreshNotifier`), I've removed the
`BatchingWorkQueue` altogether and replaced it with simpler logic that
debounces and calls `Task.Delay(...)`.
Many thanks to @CyrusNajmabadi for his help with
`AsyncBatchingWorkQueue`.
@dotnet/razor-compiler: The only relevant compiler changes are in shared
code.
@ToddGrun shared a couple PerfView stacks with me where the Razor
compiler was allocating `List<SyntaxToken>` instances in the tokenizer.
To remove those allocation, this change replaces `List<SyntaxToken>s`
throughout the parsers and tokenizer, and uses
`PooledArrayBuilder<SyntaxToken>` instead. In addition, I removed a
couple of `Concat` calls and replaced them with pooled `StringBuilders`.
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24161.1 -> To Version 8.0.0-beta.24161.7
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.24158.4 -> To Version 8.0.0-beta.24161.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Reapply "Don't rebuild when doing rid-specific publishing, just publish (#9925)" (#10014)
This reverts commit c5c96a26b1.
* Slim down the built rids for vertical builds and only reduce overbuilding on a vertical build (where we won't have the other AppHost RIDs anyway).
Also re-enable building the language servers in VMR non-sourcebuild builds.
* Fix bad copy-paste job
* Just use the regular RuntimeIdentifier property as PublishRuntimeIdentifier doesn't seem like it wants to work nicely.
* fix typo
* Pass TargetRid differently
* PR feedback and preserve existing properties
Now that the protocol packages have mapper types, this moves to use those instead of having our own definition. Follow up needed for new obsolete APIs introduced by package upgrade
It turns out that our System.Immutable.Collections package version was
already bumped to 8.0.0 with the Roslyn update. This PR bumps our pinned
version of System.Immutable.Collections to match, and also bumps
Microsoft.Extensions.ObjectPool.
* Don't rebuild when doing rid-specific publishing, just publish
Before this change, every transitive dependency of these projects were getting rebuilt for each specified RID in addition to the RIDless builds.
* Add rzls to the non-Windows solution filter so we build it (as now publish depends on the build having already happened)
* We were still publishing the razor server and telemetry packages in the dotnet/razor source-build leg, but they aren't included in the source-build intermediates and aren't used by any other portion of source-build. Additionally, they're already marked as `DotNetBuildFromSource != true`, so I believe the intent is to not publish them in source-build anyway.
This change removes the final dependency on ITextBufferProjectService,
which was the ProjectPathProvider. Now that the dependencies have all
been removed, the service is deleted as well.
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.24067.1 -> To Version 9.0.0-alpha.1.24075.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Add telemetry for time-to-first diagnostic
By adding this Diagnostic kind to our set of capabilities, the VS Win system lights up to gather the time to first diagnostic event, so we can track changes in that time. This will effectively be for our entire diagnostic process, not just syntactic diagnostics as the name of the constants implies.
Adds a simple unittest for the endpoint.
Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.23620.2 -> To Version 8.0.0-beta.24059.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Finalizes AB#1786418
Unified settins has been in for a while, but we needed to consume the 17.9 preview packages to be able to subscribe to the change events. This adds that, updates the structures we use to help keep it easy to follow, and adds a readme for people adding new options.
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23612.2 -> To Version 9.0.0-beta.23613.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23611.2 -> To Version 9.0.0-beta.23612.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.23611.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23565.2 -> To Version 9.0.0-alpha.1.23608.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This is a fairly large change that is mostly contained to the Razor
tooling tests. Here is a summary of the changes:
* All of the "*.Test.Common" projects have been merged into the
Test.Common.Tooling project.
* Utilities that are only needed by .NET Framework layers are compiled
only under net472.
* "LanguageServer.Test" no longer targets net7.0-windows and
net8.0-windows. Instead, it multi-targets net70, net80, and net472. This
allows many of the language server tests to be run on non-Windows
platforms.
* Any dependencies between test projects have been removed.
* The LegacyDispatcher has been removed from tests.
* Razor's copies of `UIFactAttribute` have been removed.
In order to push all test utilities into Test.Common.Tooling, it
_temporarily_ compiles to a different assembly name. This is because
ExternalAccess.Razor in Roslyn doesn't yet provide IVT to
Test.Common.Tooling. Eventually, this will be removed.
@dotnet/razor-compiler: This change really doesn't have much impact on
the compiler, but you're welcome to take a look.
* Update dependencies from https://github.com/dotnet/arcade build 20231204.3
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23601.1 -> To Version 9.0.0-beta.23604.3
* Update dependencies from https://github.com/dotnet/arcade build 20231205.1
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23601.1 -> To Version 9.0.0-beta.23605.1
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23577.2 -> To Version 9.0.0-beta.23578.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23572.2 -> To Version 9.0.0-beta.23577.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23570.1 -> To Version 9.0.0-beta.23572.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23567.1 -> To Version 9.0.0-beta.23570.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23558.1 -> To Version 9.0.0-alpha.1.23565.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23560.1 -> To Version 9.0.0-beta.23563.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23552.1 -> To Version 9.0.0-alpha.1.23558.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23558.3 -> To Version 9.0.0-beta.23559.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23557.7 -> To Version 9.0.0-beta.23558.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23556.4 -> To Version 9.0.0-beta.23557.7
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23553.1 -> To Version 9.0.0-beta.23556.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23527.1 -> To Version 9.0.0-alpha.1.23552.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23551.1 -> To Version 9.0.0-beta.23552.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23531.4 -> To Version 9.0.0-beta.23551.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23531.1 -> To Version 9.0.0-beta.23531.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.XliffTasks
From Version 9.0.0-beta.23528.2 -> To Version 9.0.0-beta.23531.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23519.2 -> To Version 9.0.0-alpha.1.23527.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20231027.4
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23527.1 -> To Version 9.0.0-beta.23527.4
* Update Version.Details.xml
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23525.2 -> To Version 9.0.0-beta.23527.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23523.1 -> To Version 1.0.0-beta.23525.5 (parent: Microsoft.DotNet.Arcade.Sdk
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23524.1 -> To Version 9.0.0-beta.23525.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This turned out to be quite a rabbit hole to go down. This morning, I
noticed that an OmniSharp package was still referenced by our unit
tests. I decided to get rid of that but found that it was necessary
because our unit tests reference a very old version of the Web Tools
language server assemblies, which still depend on OmniSharp. So, I
needed to update those to the latest. However, updating Web Tools
required reworking all of the reflection code that interacts with the
Web Tools langauge server. Ultimately, I ended up introducing a small
reflection framework so that code interacting with Web Tools types can
be strongly typed.
Note: This may result in NGEN failures when inserted into VS because we
no longer ship or NGEN the following binaries:
* MediatR.dll
* Microsoft.Extensions.Configuration.Binder.dll
* Microsoft.Extensions.Options.ConfigurationExtensions.dll
* OmniSharp.Extensions.JsonRpc.dll
* OmniSharp.Extensions.LanguageProtocol.dll
* OmniSharp.Extensions.LanguageServer.dll
* OmniSharp.Extensions.LanguageServer.Shared.dll
* System.Reactive.dll
This turned out to be quite a rabbit hole to go down. This morning, I
noticed that an OmniSharp package was still referenced by our unit
tests. I decided to get rid of that but found that it was necessary
because our unit tests reference a very old version of the Web Tools
language server assemblies, which still depend on OmniSharp. So, I
needed to update those to the latest. However, updating Web Tools
required reworking all of the reflection code that interacts with
the Web Tools langauge server. Ultimately, I ended up introducing
a small reflection framework so that code interacting with Web Tools
types could be strongly typed.
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23518.2 -> To Version 9.0.0-beta.23524.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23516.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23516.5 -> To Version 9.0.0-beta.23517.7
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23509.1 -> To Version 1.0.0-beta.23516.1 (parent: Microsoft.DotNet.Arcade.Sdk
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
This pull request updates the following dependencies
[marker]: <> (Begin:a0cb50dc-7d38-4a32-e166-08db18b91f66)
## From https://github.com/dotnet/arcade
- **Subscription**: a0cb50dc-7d38-4a32-e166-08db18b91f66
- **Build**: 20231016.5
- **Date Produced**: October 16, 2023 10:43:47 PM UTC
- **Commit**: a672b7bba499394acf218dc59171e2d53e754237
- **Branch**: refs/heads/main
[DependencyUpdate]: <> (Begin)
- **Updates**:
- **Microsoft.DotNet.Arcade.Sdk**: [from 9.0.0-beta.23504.4 to
9.0.0-beta.23516.5][18]
- **Microsoft.DotNet.XliffTasks**: [from 1.0.0-beta.23502.1 to
1.0.0-beta.23509.1][19]
[18]: f1868a684e...a672b7bba4
[19]:
0f36b29fb7...4f761bf529
[DependencyUpdate]: <> (End)
- **Updates to .NET SDKs:**
- Updates sdk.version to 8.0.100-rtm.23506.1
- Updates tools.dotnet to 8.0.100-rtm.23506.1
[marker]: <> (End:a0cb50dc-7d38-4a32-e166-08db18b91f66)
[marker]: <> (Begin:Coherency Updates)
## Coherency Updates
The following updates ensure that dependencies with a
*CoherentParentDependency*
attribute were produced in a build used as input to the parent
dependency's build.
See [Dependency Description
Format](https://github.com/dotnet/arcade/blob/master/Documentation/DependencyDescriptionFormat.md#dependency-description-overview)
[DependencyUpdate]: <> (Begin)
- **Coherency Updates**:
- **Microsoft.DotNet.XliffTasks**: from 1.0.0-beta.23502.1 to
1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk)
[DependencyUpdate]: <> (End)
[marker]: <> (End:Coherency Updates)
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23504.4 -> To Version 9.0.0-beta.23516.5
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23502.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
Microsoft.DotNet.Arcade.Sdk
From Version 9.0.0-beta.23504.4 -> To Version 9.0.0-beta.23510.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23502.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 9.0.0-alpha.1.23465.1 -> To Version 9.0.0-alpha.1.23472.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Fred Silberberg <frsilb@microsoft.com>
This change uses a similar approach to Roslyn's `TemporaryArray<T>` to
avoid retrieving an `ImmutableArray<T>.Builder` from the pool for arrays
of 4 or fewer elements. The first four items added to the builder are
stored on the stack.
As part of this change, I've added a new `Razor.Diagnostics.Analyzers`
project that should contain any analyzers that we write specifically for
the Razor repo. These shouldn't be deployed; they're for internal
consumption only. I've added a variant of the
`TemporaryArrayAsRefAnalyzer` from the `Roslyn.Diagnostics.Analyzers` to
enforce that `PooledArrayBuilder<T>.AsRef()` can only be called on local
builders in a using statement.
Microsoft.SourceBuild.Intermediate.source-build-reference-packages
From Version 8.0.0-alpha.1.23457.1 -> To Version 9.0.0-alpha.1.23465.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Microsoft.DotNet.Arcade.Sdk
From Version 8.0.0-beta.23428.2 -> To Version 8.0.0-beta.23429.1
Dependency coherency updates
Microsoft.DotNet.XliffTasks
From Version 1.0.0-beta.23423.1 -> To Version 1.0.0-beta.23426.1 (parent: Microsoft.DotNet.Arcade.Sdk
dotnet-maestro[bot]
David Barbet
Rikki Gibson
Dustin Campbell
Jan Jones
David Wengier
dotnet-maestro[bot]
Fredric Silberberg
Jeremy Koritzinsky
Andrew Hall
Viktor Hofer
David Wengier
Shen Chen
Ella Hathaway
Phil Allen
Alexander Köplinger
David Barbet
Allison Chou
Shen Chen
Maryam Ariyan