Replace "Go Authors" with "The Go Authors." to be consistent with the
standard copyright header at https://go.dev/doc/contribute#copyright.
There were also a couple instances of a double space and double "the".
Change-Id: Ife7a80dd40f1a760ba85cbfee270356d46cfc53f
Reviewed-on: https://go-review.googlesource.com/c/build/+/472376
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
This change adds license headers to files which are missing them.
A modified version of the addlicense tool was used to add these headers:
https://github.com/google/addlicense
The command issued was:
addlicense -c "Go Authors" -l bsd *
Change-Id: Id6fd17c587f99b3ff0ef5f5f35befcfe5aaeef72
Reviewed-on: https://go-review.googlesource.com/c/build/+/409614
Run-TryBot: Carlos Amedee <carlos@golang.org>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Alex Rakoczy <alex@golang.org>
The appengine command is no longer needed since
the coordinator is serving the build dashboard.
The key package is now unused.
For golang/go#34744.
Change-Id: I74218bac6b7457434975d13842e59e150fc078be
Reviewed-on: https://go-review.googlesource.com/c/build/+/336792
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
This script was used on two cron-part.yaml files
which are gone as of CL 46832 and CL 208397.
For golang/go#34744.
Change-Id: If8dd34391e57e011909d22142a4f6c979b8bb51f
Reviewed-on: https://go-review.googlesource.com/c/build/+/336389
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The build dashboard can be used to view builds for the main Go repo
and other golang.org/x repos. The isUntested invocation was invalid
for repos other than the main one, which was causing results for some
tested configurations to become hidden (incorrectly replaced by '•').
Larger changes are needed before there's sufficient data to compute
the GoBranch value for all repos reliably, so for now, just update
the isUntested invocation to apply only for the main repo.
This prioritizes the ability to view test results over the ability
to see that some builds are intentionally missing because they are
configured not to run. Doing both is a part of future work.
For golang/go#40290.
For golang/go#34744.
For golang/go#28643.
Change-Id: Id43cb47abacb1036f578efbb8232ae17ad40eca9
Reviewed-on: https://go-review.googlesource.com/c/build/+/244137
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The UI's json view makes some assumptions about the main commit data
coming from the Go Gerrit repo, resulting in misreporting the commit
repo and missing result data. Update this logic to handle other repos.
Since jsonView was untested, a minimal test is added that validates its
handling of the go repo, and reproduces the bug reported in
golang/go#35515 for a subrepo.
Fixesgolang/go#35515
Change-Id: I10f01b92bbdabe866e776217e02d64cb5c040389
Reviewed-on: https://go-review.googlesource.com/c/build/+/232897
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
The linux-amd64-staticlockranking builder was added pre-emptively so
that it could be tested and used during the development of a CL that
implements a new feature. It's expected to fail until that work is
completed. Mark it as a builder with a known issue, golang/go#38029.
The new BuildConfig.KnownIssue field can be used by builders being
added in the future so that if they fail at first, it doesn't take
away time for people looking at build.golang.org, which we always
aim to have as green as possible¹.
¹ https://groups.google.com/d/msg/golang-dev/y0yM_Xi665Q/hUpBiUPiCAAJFixesgolang/go#38283
For golang/go#38029
For golang/go#37937
For golang/go#11811
Change-Id: Iba1606c7021ffa7e67ddbaae2fc6b65f4e46ab34
Reviewed-on: https://go-review.googlesource.com/c/build/+/227379
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This hides a bunch of old columns, especially from x/foo repos pages.
And it gives each x/foo release branch section at the bottom its own
set of builders.
Change-Id: I97ea93beb5ce4d89afcef9726c0d73aea745b275
Reviewed-on: https://go-review.googlesource.com/c/build/+/211117
Reviewed-by: Alexander Rakoczy <alex@golang.org>
It's the only func not used by the template. Looking at the git
history, I don't see it ever being used.
Change-Id: Id074712996589fc3a7a517fd7ae47bc84a292904
Reviewed-on: https://go-review.googlesource.com/c/build/+/211317
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
The dev_appserver.py is no longer available in Go 1.12+, so update
instructions so others know how to hack on this codebase.
The new --fake-results flag means anybody can hack on it locally
without any special access.
Change-Id: I3e395814bf7275bd3b24615d2a37f9c6ac186508
Reviewed-on: https://go-review.googlesource.com/c/build/+/211097
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
In CL 210977 I broke the log handler's ability to see old pre-git
failures. They're stored in a different datastore namespace.
Change-Id: I494e2227f0aa8510490ff7e7075cb1d71d27e4f3
Reviewed-on: https://go-review.googlesource.com/c/build/+/211079
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Fixes a TODO.
The coordinator RPC should be temporary, but a) who ever knows how
long temporary is, and b) it's easy enough to do, and c) faster is
nicer.
Updates golang/go#34744
Change-Id: Id7216e1c67dc04152565bb8c5d6181cde674a12e
Reviewed-on: https://go-review.googlesource.com/c/build/+/210997
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
The old App Engine datastore API and the new Cloud datastore API have
different behaviors with regard to indexing []byte properties.
Both APIs say the same:
https://godoc.org/google.golang.org/appengine/datastore#hdr-Propertieshttps://godoc.org/cloud.google.com/go/datastore#hdr-Properties
> All fields are indexed by default. Strings or byte slices longer
> than 1500 bytes cannot be indexed; fields used to store long strings
> and byte slices must be tagged with "noindex" or they will cause Put
> operations to fail.
But empirically only the new cloud API actually returns an error when
putting a >1500 []byte value into a field without noindex. Not sure
why.
Updates golang/go#34744
Change-Id: I15c938e91c92304eb7074de99c19f8e93182283e
Reviewed-on: https://go-review.googlesource.com/c/build/+/210998
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This implements bullets 4 and 5 from the plan to unify the dashboard &
coordinator:
https://github.com/golang/go/issues/34744#issuecomment-563398753
Previously the coordinator would POST to the dashboard regularly, for
each active build, to say "I'm still working on this build! Write that
to memcache!". And then if somebody loaded https://build.golang.org/
it would do a big memcache multi-get to populate the little blue
gopher links to their status pages on the coordinator.
This instead turns it around. We no longer POST from the coordinator
to the dashboard, and we no longer use any memcache (which also means
migrating to the App Engine Go 1.13 runtime is easier, which drops
the built-in memcache support). Instead, the dashboard now does a GET
to the coordinator to get the list of active builds.
This also adds test coverage, which we didn't have before.
Updates golang/go#34744
Change-Id: I97a486ec362a7a00d29076c81a88d6417b138c1b
Reviewed-on: https://go-review.googlesource.com/c/build/+/210838
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This removes yet another list of all our repos.
(Goal is to simplify https://github.com/golang/go/wiki/CreatingSubRepository)
Most of the work was in earlier CL 208697.
Updates golang/go#36047
Change-Id: I9147b959fe6574e2f809091d08d360051b69402e
Reviewed-on: https://go-review.googlesource.com/c/build/+/210461
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
I forgot to run the tests when writing CL 210287, which were the quick fixes
found when deploying CL 208697.
Change-Id: Icdbc8afac89358c30c370fd9e1d1a3fd6df95db7
Reviewed-on: https://go-review.googlesource.com/c/build/+/210377
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Historically, the build.golang.org was the entire build system, and it
maintained a parallel copy of that git history in its datastore. It
was always buggy and incomplete and things like force pushes were
scary because the datastore mirror could get out of sync. It was also
a lot of code to support that sync.
This changes build.golang.org to instead get the git history from
maintnerd, and then we can remove all the HTTP handlers around
updating it, and can remove all the gitmirror code to call it to
maintain it.
Now build.golang.org only keeps build results, keyed on the commit
hash. It's much less code, but is still an App Engine app for now.
(but it's getting small enough, that porting it to
cloud.google.com/go/datastore is looking very simple)
This also adds a new "repos" package to unify the configuration of the
various Go repos. There were incomplete & redundant copies all over
the place.
Updates golang/go#34744Fixesgolang/go#35828Fixesgolang/go#31236 (New branch=mixed support adds this when desired)
Fixesgolang/go#35944
Change-Id: Ifb39417287df3dea052ba8510566d80b4bc75d51
Reviewed-on: https://go-review.googlesource.com/c/build/+/208697
Reviewed-by: Bryan C. Mills <bcmills@google.com>
tagHandler isn't used by anything. Delete. Less code to update.
And document who calls the other handlers.
Also, remove the auth requirement from the /init handler. It's
harmless to call without auth, and the login restriction went away
with the Go 1.12+ runtime anyway, so deleting it gets us closer to
being able to use the Go 1.12/Go 1.13 runtimes. (The plan is to delete
most the code, port the small remaining bit to the cloud.google.com/go
libraries so we can update to Go 1.12/Go 1.13+, and then at that
point, since the cloud.google.com/go code will run anywhere, we can
just run it in the same process as the coordinator.)
Updates golang/go#34744
Change-Id: I929c70945a3e9e27b38b1d5899c7860470361927
Reviewed-on: https://go-review.googlesource.com/c/build/+/208678
Reviewed-by: Bryan C. Mills <bcmills@google.com>
During my earlier deletion spree over the past few CLs I wasn't
testing on real data (with production data) and didn't catch that
datastore returns an error when you load an old entity into a struct
that has since removed a field.
So filter those out.
(I could've also restored those fields, perhaps with a dummy named
interface{} type, but this code is temporary, and I'd prefer fewer
fields to think about. And this was a good opportunity to re-read the
code.)
I also still had references to the always-empty-string Prefix field in
the template.
Change-Id: I4fd9002d6d1bae2a08f4c53ec34651a7fe5db344
Reviewed-on: https://go-review.googlesource.com/c/build/+/208399
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.
Some of this was missed in CL 208319.
Updates golang/go#34744
Change-Id: I35adf4296b849dabed9d974e7eb58eeedc7d4293
Reviewed-on: https://go-review.googlesource.com/c/build/+/208397
Reviewed-by: Andrew Gerrand <adg@golang.org>
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced,
starting with deleting dead code.
Updates golang/go#34744
Change-Id: I6cddbb44a63597a308f1d4399d21e5b70a8d83bf
Reviewed-on: https://go-review.googlesource.com/c/build/+/208324
Reviewed-by: Andrew Gerrand <adg@golang.org>
It hasn't worked in years.
This is part of a series of CLs to clean up the build.golang.org App
Engine app in prep for it to be modernized, refactored, and replaced.
Updates golang/go#34744
Updates golang/go#12509
Change-Id: I9f8445046961ccbe97f7b9c85c0772393bf7d547
Reviewed-on: https://go-review.googlesource.com/c/build/+/208322
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Gerrand <adg@golang.org>
This moves the /key handler to generate build keys to a standalone
tool. The old way has been largely broken for years (when using the
build.golang.org domain) due to internal App Engine changes. We have
to access it via https://build-dot-golang-org.appspot.com/key instead
to get authenticated.
Also, the App Engine go112 runtime doesn't support authenticated
handlers, so more reason to move off App Engine.
This CL is part of a series to move off the the build.golang.org App
Engine app that mirrors the git history into Datastore Entities, which
is full of complication and bugs.
These early steps are about removing a bunch of code from the App
Engine app so the important bits are easy to see and refactor.
Updates golang/go#34744
Change-Id: Iaf8e2bf458b5fea45bf05026d8a6eaf0ead88ec2
Reviewed-on: https://go-review.googlesource.com/c/build/+/208320
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This was the performance/benchmark code from ~three generations ago.
It's unused and unmaintained. It broke when we moved from mercurial to
git, IIRC.
I'm attempting to modernize this code (for golang/go#34744) but it'd
be easier if there's less code to deal with.
Updates golang/go#34744
Change-Id: Ib4999830b05df9ffad9b46964022325404350b47
Reviewed-on: https://go-review.googlesource.com/c/build/+/208319
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
It already does trybots and we try to keep it passing everywhere, so
let's see if that's true.
Fixesgolang/go#30640
Change-Id: I9f888efd68eac223f4339736938c74480715a28b
Reviewed-on: https://go-review.googlesource.com/c/build/+/207852
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is a follow-up to CL 199800. That change started to consider more
builders as active to allow release-branch-only builders to run.
However, it also made those builders show up as new empty columns when
viewing builds for the master branch. There are quite a few old FreeBSD
builders that only run on release-branch.go1.12, and it's too disruptive
to have them appear everywhere. So, hide them when viewing the master
branch of Go repo in the UI.
There can be more UI improvements to be made, and this can become too
much of a whack-a-mole to address them one by one. The scope of this CL
is to fix the most disruptive high priority problem for now. Further
improvements will happen later, with merging of app/appengine and
cmd/coordinator codebases in mind.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: I3df75f8b2bbd5f6fe8097c181ee8a1b1b4354dc9
Reviewed-on: https://go-review.googlesource.com/c/build/+/199878
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
The filtering of builders in commitBuilders was too strict,
causing post-submit builders that are configured to run on
release-branches only to not get included in the list of
builders.
This change makes the following builders no longer skipped:
darwin-amd64-10_10
freebsd-386-10_3
freebsd-386-10_4
freebsd-386-11_1
freebsd-amd64-10_3
freebsd-amd64-10_4
freebsd-amd64-11_1
nacl-386
nacl-amd64p32
We may need to adjust the build.golang.org UI after to avoid
including unhelpful columns, but this is a first step to get
nacl builders to run on release branches again.
Updates golang/go#34738
Updates golang/go#34744
Change-Id: Iaf2b93aedd5f44b48b9a63b57f12549fe50b1637
Reviewed-on: https://go-review.googlesource.com/c/build/+/199800
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Also, because this is the first CL in this package to add tests, add a
helper to return the right template filename depending on the
environment (go test vs prod) so tests don't panic in init.
Fixesgolang/go#34097
Updates golang/go#34116
Change-Id: I4b3e83c2417611cfbdc32e27941dbb90687eb509
Reviewed-on: https://go-review.googlesource.com/c/build/+/194643
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Deploying in GOPATH mode is not supported, so explicitly specify
GO111MODULE=on to use module mode regardless of local setup.
Fixesgolang/go#34107
Change-Id: I5bc2518c4cd4c329eea65684fec96aae5b0bf808
GitHub-Last-Rev: 93f780cd58
GitHub-Pull-Request: golang/build#23
Reviewed-on: https://go-review.googlesource.com/c/build/+/193597
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Per release policy¹, we only support and test the two latest
major versions (currently Go 1.13 and Go 1.12).
Previously:
• CL 164218 removed Go 1.10.
• CL 133895 removed Go 1.9.
• CL 95555 removed Go 1.8.
• CL 77931 removed Go 1.7.
• CL 37466 removed Go 1.6.
• CL 31767 removed Go 1.5.
• CL 20843 removed Go 1.4.
¹ https://golang.org/doc/devel/release.html#policyFixesgolang/go#34096
Change-Id: I8ac7fcb6527e86706bdb7f140e3f05d3262f2476
Reviewed-on: https://go-review.googlesource.com/c/build/+/193477
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Starting October 1, App Engine will not allow apps using the 1.9
runtime to be deployed.
In module mode on go111 AppEngine, paths have changed to be relative to
the go.mod file.
More information can be found at
https://cloud.google.com/appengine/docs/standard/go111/go-differences
Change-Id: I3e291f20559ec8d3c5e8f51b756bd3b23b0c70bd
Reviewed-on: https://go-review.googlesource.com/c/build/+/192103
Run-TryBot: Alexander Rakoczy <alex@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
This app is now running as a service called "build" instead of
on a named version in the default service. Update the app.yaml and
deployment instructions to account for this.
Change-Id: I5d68128e89bad6782982380b2012300a492ddb34
Reviewed-on: https://go-review.googlesource.com/c/build/+/191975
Reviewed-by: Alexander Rakoczy <alex@golang.org>
This reverts commit CL 190902.
Reason for revert: it breaks deploys due to filesystem changes in go111
Change-Id: Ic357050da2707be1c53d79af6f0062ff4feaffbb
Reviewed-on: https://go-review.googlesource.com/c/build/+/191974
Reviewed-by: Alexander Rakoczy <alex@golang.org>
Currently, the subheading2 cells in the subrepo tables are shifted by
one to the left due to the additional cell for the Go commit. There are
4 fixed <th> cells while there are 5 <td> cells (subrepo commit, Go
commit, user, time and description).
Make the first <th> have a colspan of 2 in case of the subrepo table so
the subheading2 cells align correctly.
Change-Id: I1ca7157cecf6530cff5883154f367684b0695081
Reviewed-on: https://go-review.googlesource.com/c/build/+/183217
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Make the headers fill the screen's width by making the body have
display: inline-block and min-width: 100%. Before, scrolling to
the right extended past the screen's width, which caused the
blue table headers to cut off.
Change-Id: I2f186ca044d07a4dfd3ec6cbe3f57a9feee05c99
Reviewed-on: https://go-review.googlesource.com/c/build/+/125475
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
It was previously master, Go 1.11, then Go 1.12, which puts Go 1.11 in
the middle of two things that came after it.
Change-Id: I5c67bff7f0ab4269f1db3d4c7e8197df36dc12cb
Reviewed-on: https://go-review.googlesource.com/c/build/+/170779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
I forgot the sub-repo sub-heading in CL 160657. This adds it.
Change-Id: I5cab4fe978ae662a9150e34acc802caff61de54a
Reviewed-on: https://go-review.googlesource.com/c/164677
Reviewed-by: Andrew Bonventre <andybons@golang.org>
So people can see linux-amd64-nocgo vs linux-amd64-noopt, etc.
Currently it only works on mouseover on desktop, and few people know that.
Add a new row to make it explicit.
While at it:
* remove some dead code
* make this testable locally, detecting dev_appserver mode and populating some
fake data
* remove the s/amd64/x86/ in the subheadings. that's just confusion and we don't
do that to other longer fields like arm64 or ppc64le, etc
Change-Id: Id3de9406f383c93202be2e298f07d5c4fef8ae85
Reviewed-on: https://go-review.googlesource.com/c/160657
Reviewed-by: Andrew Bonventre <andybons@golang.org>
Dmitri Shuralyov
Carlos Amedee
Rob Findley
Brad Fitzpatrick
Alexander Rakoczy
Andrew Bonventre
Tobias Klauser
Akhil Indurti