Граф коммитов

701 Коммитов

Автор SHA1 Сообщение Дата
Daniel Smith 23998966ce
add error text argument to OT creation fail email (#4212) 2024-08-13 09:43:09 -07:00
Jason Robbins c9b8d27335
Avoid a 404 because there is no ot_requests.css. (#4143) 2024-07-19 07:17:07 -07:00
Daniel Smith 65f3633b3f
intent template adjustments and fixes (#4112) 2024-07-16 20:36:46 -07:00
Jeffrey Yasskin 79e7561c7c
Unify all JS building into the Rollup pipeline with module output. (#3991)
This should make it easier to Typescriptify js-src and any JS depending
on files in that directory.
2024-06-24 13:31:02 -07:00
Jeffrey Yasskin a299afd7ed
Put the spinner under the "new features page" link. (#3920)
So that users can click to the new features page while the old is still loading.
2024-05-29 12:42:12 -07:00
Daniel Smith 50551c5d72
Add new "OT activation failed" email template (#3870) 2024-05-15 19:56:33 -07:00
Daniel Smith 29b4b9ecc5
Dialog for initiating extension opens directly from email link (#3874)
* Dialog for initiating extension opens directly

* remove logs

* lint

* fix test
2024-05-15 19:43:03 -07:00
Daniel Smith 66af8cce27
2024-05-09 deployment bug fixes (#3867)
* Fix date format for automated email

* Update sendemail.py

* Update sendemail.py
2024-05-10 11:40:17 -07:00
Daniel Smith 0b02f64138
New email template for automated OT activation (#3858)
* Add new "Created and activated" email template

* rename class

* Add Route to main.py

* update contacts list

* rename class
2024-05-09 20:15:30 -07:00
Daniel Smith 3b36ef2bc5
New email template for automated origin trial creation, activation pending (#3856)
* "creation processed but not activated" template

* tests

* Add Route in main.py

* use StageDict in notifier

* ot_activation_date not required

* update contacts list

* rename class

* comment out golden creation comment
2024-05-09 15:25:42 -07:00
Daniel Smith 2453dec040
New email template for automated origin trial request failures (#3854)
* Email template for request failures

* newline

* use StageDict for template

* simplify name

* fix test

* Update main.py
2024-05-09 14:16:14 -07:00
Daniel Smith 82eab3fa5f
Migrate OT Process reminders to Chromestatus (#3835)
* migrate OT process reminder emails

* add OT process reminders cron job

* Add testing for each email

* add test param

* more tests

* fix date format

* changes suggested by @jrobbins

* simplify get_trials function

* fix test
2024-05-09 12:52:02 -07:00
Daniel Smith 47e20b38eb
New "OT extension approved" email template (#3813)
* New "OT extension approved" email template

* send to requester email and OT support

* update test to remove inconsistency

* changes suggested by @jrobbins

* fix tests
2024-04-24 10:15:04 -07:00
Daniel Smith d4c323f921
Add "OT extended" notification template (#3758)
* add "OT extended" notification template

* changes suggested by @jrobbins
2024-03-28 21:38:50 -07:00
Raja Majumdar 3612489dc7
fixed Toast is briefly displayed on page load (#3725)
* fixed Toast is briefly displayed on page load

* updated fix for Toast is briefly displayed on page load

* updated the test html renderings
2024-03-26 18:40:06 -07:00
Daniel Smith 88a3c1d0b0
Update intent template for extensions (#3688)
* separate ot and extension intents

* correct stage types

* change name for deprecation trial

* Update form-field-enums.js
2024-03-06 10:13:15 -08:00
Jason Robbins 694a563377
Add specific template for comment notificatons. (#3615)
* Add specific template for comment notificatons.

* Added style

* Finished rebase
2024-01-29 13:13:23 -08:00
Jason Robbins 835c9c83a5
Define template for assigned review notifications (#3612)
* Define specific template for assigned review notifications

* Add missing parameter and use commas in lists

* Added style

* Comments swapped to match the code
2024-01-29 11:59:29 -08:00
Jason Robbins d08ccf0290
Add style attributes to emails. (#3616) 2024-01-29 09:09:34 -08:00
Jason Robbins 457ca010d2
Define a specific notification for review requests (#3587)
* Initial code

* fixed tests
2024-01-15 11:52:36 -08:00
Jason Robbins 3f670e5aa1
Remove outdated info from email templates and make consistent. (#3582)
* Remove outdated info from email templates and make consistent.

* Update templates/accuracy_notice_email.html

Co-authored-by: Kyle Ju <kyleju@google.com>

* Update templates/accuracy_notice_email.html

Co-authored-by: Kyle Ju <kyleju@google.com>

* Updated goldens

---------

Co-authored-by: Kyle Ju <kyleju@google.com>
2024-01-12 16:11:25 -08:00
Jason Robbins b1faf89ba2
Switch from roboto to system-ui font. (#3561) 2023-12-27 13:40:09 -08:00
Jason Robbins 99e7b3bd55
Notify reviewers of overdue reviews (#3560)
* Progress

* fixes and template

* Added tests
2023-12-26 15:30:05 -08:00
Yann Dago 860c36beed
Small enterprise UI features (#3503)
* Hide deleted features from enterprise release notes

* Rename Chrome OS to ChromeOS

* Add hyperlink to feature in release notes
2023-11-27 11:20:19 -05:00
Daniel Smith 2469c9afc8
Add extension requests to OT requests admin page (#3420) 2023-10-17 17:40:20 -07:00
Daniel Smith 49b70583f4
Display OT creation request note on admin page (#3384)
* display ot request note on admin page

* update to OT Support email

* fix test
2023-10-02 11:50:14 -07:00
Jason Robbins b7523698ac
Fix typo that omitted wpt_descr from I2S. (#3372) 2023-09-28 11:36:37 -07:00
Daniel Smith dbba7f8c20
OT requests admin page (#3352)
* parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414849 -0700

parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414839 -0700

parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414831 -0700

parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414745 -0700

Documentation for feature links (#3317)

* Add documentation for feature links

* Update documentation for feature links

npm: bump tar from 6.1.15 to 6.2.0 (#3318)

Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.0.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.15...v6.2.0)

---
updated-dependencies:
- dependency-name: tar
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump eslint from 8.48.0 to 8.49.0 (#3319)

Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.49.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.48.0...v8.49.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump @babel/register from 7.22.5 to 7.22.15 (#3320)

Bumps [@babel/register](https://github.com/babel/babel/tree/HEAD/packages/babel-register) from 7.22.5 to 7.22.15.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.15/packages/babel-register)

---
updated-dependencies:
- dependency-name: "@babel/register"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump rollup from 3.28.1 to 3.29.1 (#3321)

Bumps [rollup](https://github.com/rollup/rollup) from 3.28.1 to 3.29.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v3.28.1...v3.29.1)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Enforce rollout milestones to have a minimum value of 100 (#3316)

Revert "temporarily remove OT cron" (#3322)

This reverts commit 5da4d251a9.

Update cron description (#3323)

* Update cron.yaml

* Update cron.yaml

Update chromedash-feature-detail.js (#3324)

Record vote activities with amendments instead of text. (#3314)

* Record vote activities with amendments instead of text.

* Stop checking comments_only

Add support for testing mobile (i.e. narrow window). (#3325)

* Add support for testing mobile (i.e. narrow window).

* Cleanup

Ensure all available features for a release note are fetched (#3328)

- Add new query parameter releaseNotesMilestone to the GET /features route
- Ensure all shipping and enterprise features are returned from the milestone specified in releaseNotesMilestone until the latest available feature
- Update front end logic to wait for a channel to be selected before getting the features for the release notes
- Update front end logic to fetch policies each time the target milestone is changed

Add 3 more fields for OT creation (#3327)

* Add 3 more fields for OT creation

* `stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

* remove test line

Add indexes needed for enterprise release notes. (#3329)

Hide enterprise features from /features page (#3330)

Enterprise features were shown on /features when they should never be shown there.
This PR filters out enterprise features from the features sent to /features

Ensure milestone comparison is made between two int types (#3331)

Add `ot_feedback_submission_url` field (#3333)

Add 3 more fields for OT creation

`stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

remove test line

Add basic UI for trial creation request

Add `ot_feedback_submission_url` to ot creation

ot button only shows on ot stage details

Update chromedash-feature-detail.js

fix OT button

cancel button returns to feature detail

add ot milestone fields

Update chromedash-feature-detail.js

Add action_requested field for creation/extension

show button disabled if already requested

trial association cron clears ot action requests

`/admin/ot_requests.html`

Fix base.css unix perms. (#3338)

don't write to the same entity multiple times (#3345)

npm: bump @babel/preset-env from 7.22.15 to 7.22.20 (#3340)

Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.22.15 to 7.22.20.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-preset-env)

---
updated-dependencies:
- dependency-name: "@babel/preset-env"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump @lit-labs/context from 0.4.0 to 0.4.1 (#3341)

Bumps [@lit-labs/context](https://github.com/lit/lit/tree/HEAD/packages/labs/context) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/lit/lit/releases)
- [Changelog](https://github.com/lit/lit/blob/main/packages/labs/context/CHANGELOG.md)
- [Commits](https://github.com/lit/lit/commits/@lit-labs/context@0.4.1/packages/labs/context)

---
updated-dependencies:
- dependency-name: "@lit-labs/context"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump sass from 1.66.1 to 1.67.0 (#3342)

Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.67.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.66.1...1.67.0)

---
updated-dependencies:
- dependency-name: sass
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

npm: bump @playwright/test from 1.37.1 to 1.38.0 (#3343)

Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.37.1 to 1.38.0.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.37.1...v1.38.0)

---
updated-dependencies:
- dependency-name: "@playwright/test"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add test of entering a blink_component name (#3349)

* Add test to enter blink component

* Update the README a bit.

* Change name of test, update images.

* Delete commented out code.

npm: bump @babel/core from 7.22.11 to 7.22.20 (#3344)

Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.11 to 7.22.20.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-core)

---
updated-dependencies:
- dependency-name: "@babel/core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Add `ot_owner_email` and `ot_display_name` fields

Add 3 more fields for OT creation

`stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

remove test line

Add basic UI for trial creation request

Update chromedash-feature-detail.js

cancel button returns to feature detail

add ot milestone fields

fix test

Add "overdue" to the tooltip on overdue gate chips. (#3350)

* Add "overdue" to the tooltip on overdue gate chips.

* Also remove gate name.

Add `ot_action_requested` field to denote sent requests (#3336)

* Add 3 more fields for OT creation

* `stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

* remove test line

* Add basic UI for trial creation request

* Add `ot_feedback_submission_url` to ot creation

* ot button only shows on ot stage details

* Update chromedash-feature-detail.js

* fix OT button

* cancel button returns to feature detail

* add ot milestone fields

* Update chromedash-feature-detail.js

* Add action_requested field for creation/extension

* Refined requests admin page

Add `ot_owner_email` and `ot_display_name` field (#3351)

* Add 3 more fields for OT creation

* `stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

* remove test line

* Add basic UI for trial creation request

* Add `ot_feedback_submission_url` to ot creation

* ot button only shows on ot stage details

* Update chromedash-feature-detail.js

* fix OT button

* cancel button returns to feature detail

* add ot milestone fields

* Update chromedash-feature-detail.js

* Squashed commit of the following:

commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 20 15:06:53 2023 -0700

    Update chromedash-feature-detail.js

commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 20 15:00:01 2023 -0700

    add ot milestone fields

commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 09:18:46 2023 -0700

    cancel button returns to feature detail

commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 09:02:06 2023 -0700

    fix OT button

commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 08:49:21 2023 -0700

    Update chromedash-feature-detail.js

commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 08:44:07 2023 -0700

    ot button only shows on ot stage details

commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Fri Sep 15 16:04:52 2023 -0700

    Add `ot_feedback_submission_url` to ot creation

commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Fri Sep 15 14:16:22 2023 -0700

    Add basic UI for trial creation request

commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 12:50:19 2023 -0700

    remove test line

commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 12:46:44 2023 -0700

    `stage_description` -> `ot_description`

    With a more detailed description of the field and its relation to OT

commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 10:53:06 2023 -0700

    Add 3 more fields for OT creation

* Add `ot_owner_email` and `ot_display_name` fields

* fix test

User email automatically added to OT contacts list (#3339)

* Add 3 more fields for OT creation

* `stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

* remove test line

* Add basic UI for trial creation request

* Add `ot_feedback_submission_url` to ot creation

* ot button only shows on ot stage details

* Update chromedash-feature-detail.js

* fix OT button

* cancel button returns to feature detail

* add ot milestone fields

* Update chromedash-feature-detail.js

* Squashed commit of the following:

commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 20 15:06:53 2023 -0700

    Update chromedash-feature-detail.js

commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 20 15:00:01 2023 -0700

    add ot milestone fields

commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 09:18:46 2023 -0700

    cancel button returns to feature detail

commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 09:02:06 2023 -0700

    fix OT button

commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 08:49:21 2023 -0700

    Update chromedash-feature-detail.js

commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Mon Sep 18 08:44:07 2023 -0700

    ot button only shows on ot stage details

commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Fri Sep 15 16:04:52 2023 -0700

    Add `ot_feedback_submission_url` to ot creation

commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Fri Sep 15 14:16:22 2023 -0700

    Add basic UI for trial creation request

commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 12:50:19 2023 -0700

    remove test line

commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 12:46:44 2023 -0700

    `stage_description` -> `ot_description`

    With a more detailed description of the field and its relation to OT

commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date:   Wed Sep 13 10:53:06 2023 -0700

    Add 3 more fields for OT creation

* Add `ot_owner_email` and `ot_display_name` fields

* Add 3 more fields for OT creation

* `stage_description` -> `ot_description`

With a more detailed description of the field and its relation to OT

* remove test line

* Add basic UI for trial creation request

* user email automatically added to ot contacts list

* update to use new `ot_owner_email` field

* fix test

---------

Co-authored-by: Ping <5123601+pingren@users.noreply.github.com>
2023-09-26 09:35:56 -07:00
Daniel LaLiberte 0baad0b731
Dlaliberte playwright 06 22 (#3184)
* Initial install of playwright visual tests

* Close to working.

* who knows...

* after updates

* Extend devcontainer docker compose file for playwright (#3192)

* Extend devcontainer docker compose file for playwright

Create another docker compose file for playwright.
That new one extends the existing docker compose

Should be able to run:

`npm run pwtests`

* adjust gh action

* adjust gh action

* remove volumes

* add timeout

* fix volumes

* Fix docker compose environment

* ignore stuff and volume mounting

* Attempting to login reliably

* Auto cleanups.

* Finally starting to work

* Thought it was getting better, but maybe not

* Seems reliable now

* Higher success rate

* Add test of entering feature name. Remove new feature page content test.

* Add playwright-report dir to Dockerfile.

* Comment out mkdir -p /work/playwright-report line.

* Update screenshots.

* Increasing timeout for entering feature name

* try running as user (#3248)

* try running as user

* again

* try

* change volume ownership

* tidy up

* Adjust login process to be more reliable.

* Add 5 second delay before first test runs.

* Wait longer for first login.

* Add auto-logout during login if already logged in

* Screenshot after login click

* Add testName to screenshots. Upload artifacts. Fix form method="POST".

* Add doc to README for Updating the test_html_rendering files.

* Maybe increase chance of login.

* Add a couple more delays.

* Repeat auto-logout during login until no longer logged in, before logging in again.

* Add some more delays.

* Use loginButton.click().  Add delay before after-click screenshot.

* Add console info an errors to login process.

* Capture console messages, relay to terminal.

* Capture console messages properly.

* Add some more console messages during login.

* Ignore error on jsonValue.

* Reduce most delays. Add more logs. Add top-level playwright call.

* More logging to figure out why login fails

* More logging to detect if ever logged in.

* Add more logging to each stage of testing

* Use history.replaceState before changing location.

* Use location.reload() after a timeout.

* After login, just load home page.

* Add playwright-report to artifacts.

* Turn off playwright-report during CI

* Log response after login

* Only log first response after request that should log in.

* Look for 'currentuser/permissions' request/response.

* Delay after mock_login and before reload of home page

* Comment out header and cookie logs.

* Act like logged when in DEV_MODE and login attempted.

* Fix mock mock login.

* Undo fake mock_login.

* rearrange docker (#3265)

* Updates after changes by James.

* Fix previous updates.

* Remove pwtests-shutdown from "stop" command.

* Remove pwtest from client-src/elements. (moved to packages/playwright/tests)

* update paths for run.sh

* Add pwtests-shutdown to top-level stop command.

* Remove "playwright" from ./wait-for-app.sh

* Add logging of user login status.

* add playwright_display for debugging

* add server debugging

* Remove extra "/__screenshots__" in path.

* Update the path for test-results artifacts in the playwright.yml

* add health checks

* fix action

* fix run.sh

* Add beforeAll method, disabled.

* add dsadmin

* Add top level pwtests command, not working yet.

* cleanup and undo changes

* use transactions

* always reuse server

* temp: limit the workers

* Partial cleanup.  Reduce timeouts and delays a bit.

* More cleanup.  Reduce timeout/delay.

* Update the correct README file.  Update html rendering tests.

* Remove unnecessary changes.

* set script-shell to fix source not found and call npm run setup (#3292)

* set script-shell to fix source not found and call npm run setup

There has always been `source: not found` in the previous CI jobs

The tests previously worked because
npm run deps installs the requirements into the default environment and not the virtual environment.
And since we actually did not call `source` correctly, it was okay because
the default environment had the packages installed.

The problem started to arise because we started to call `source`
correctly in some places but not all places. This fixes by setting the
shell consistently whenever we call `source`

More info:
https://morgan.cugerone.com/blog/troubleshooting-source-not-found-when-in-the-context-of-package-json-scripts/

* do each separately

* Revert "do each separately"

This reverts commit 4fc75f7407.

* do ci job

* consistent to the right datastore mode

* verbose

* kill the emulator

* remove verbose

* Reenable Google login

* Finish reenabling Google signin button. Add margin for Firefox.

* Only show Google signin if playwright is not active

* Preserve url on login.  Use default num of workers.  Retry tests in CI

* Some updates after comments

* optimize docker changes

* Rename account-indicator. Shorten some delays.

* revert the workers

* Make playwright.yml push and pull_request triggers be like others.

* Use getByTestId instead of locator with data-testid.

---------

Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
Co-authored-by: James Scott <jamescscott@google.com>
2023-09-06 15:35:06 -04:00
Jason Robbins f2d56ed262
Defaut to opening the menu drawer on the old feature list page. (#3216)
* Defaut to opening the menu drawer on the old feature list page.

* Remade template test golden

* Update templates/features.html

Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>

* Remade template test golden

---------

Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
2023-07-26 18:50:55 -07:00
Daniel Smith 86a1e7d52d
Add ot fields in the trial creation questionnaire (#3194) 2023-07-26 08:09:18 -07:00
Kyle Ju e6263c9e88
Fix button active css on features page (#3165)
Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-07-13 12:14:24 -07:00
Jason Robbins 816922ca08
Revert "Work around sl-select bug. (#3139)" (#3153)
This reverts commit 4ad8db28dd.
2023-07-12 11:43:16 -07:00
Kyle Ju 34f875b1f6
Move EventListener to _base.html (#3152)
* Move eventlistener

* Fix tests

* Fix tests

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-07-11 18:22:54 -07:00
Jason Robbins 4ad8db28dd
Work around sl-select bug. (#3139) 2023-07-09 09:52:06 -07:00
Kyle Ju 6d49152057
Hamburger menu on desktop and Mobile (#3112)
* UI ready

* Address comments and add tests

* Add drawer to all features page

---------

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2023-07-06 11:30:51 -07:00
Jason Robbins f99d66bd5c
Add fields for finch flag name and non-finch justification. (#3108) 2023-06-22 09:48:50 -07:00
Daniel Smith ad9386cdb9
Remove the rest of old schema references (#2910)
* Remove the rest of old schema references

* Keep maintenance scripts

* move script Route
2023-04-12 22:46:41 -07:00
James C Scott III f33576a5f3
Migrate admin/blink.html to SPA [5/5] (#2743)
* Migrate admin/blink.html to SPA

Add implementations of the three new API routes
Remove old code for templated admin/blink.html

* Remove old handler and template

* start of tests

* fix tests

* temp

* separate into smaller elements

* add more python tests

* fix lint for optional values

* add tests

* fix lint error

* update model names

* use global

* fix test

* fix jsdoc from renaming

* address feedback
2023-03-24 18:25:18 -04:00
James C Scott III 4a2f9f6a75
Manual changes to support using openapi [3/5] (#2771)
* Manual changes to support using openapi

.devcontainer/Dockerfile
- Install java in devcontainer

.devcontainer/devcontainer.json
- Make devcontainer automatically install VSCode OpenAPI plugin mentioned in #2769
- Make devcontainer automatically install VSCode plugin for Lit

client-src/elements/chromedash-app.js
- Use the generated client in the frontend.
- Leverage lit-labs/context to provide the client.
  - Docs about context and use-cases: https://lit.dev/docs/data/context/

client-src/elements/chromedash-app_test.js
- Add tests for the changes in client-src/elements/chromedash-app.js

client-src/contexts/openapi-context.js
- Declare a context for the openapi client.

framework/basehandlers.py
- add do_put function. previously, all other HTTP verbs had a `do_<verb>` version except PUT.
- Add put function that uses defensive_jsonify. This enables XSSI for PUT requests.
  - This needed change is safe to do because the only route using PUT is the admin/blink page which I am migrating into the SPA.

gulpfile.babel.js
- Fix usage of rollupBabel. Previously, @rollup/plugin-node-resolve's default export was named rollupBabel. Which is the wrong package. Fixed to use @rollup/plugin-babel
- Using the correct parameters to rollupBabel from https://www.npmjs.com/package/@rollup/plugin-babel
- Add client-src/contexts/*.js to lint and watch targets
- Add custom onwarn for rollup that comes from using the generated frontend code. Check comment for explanation

package.json
- Add lit-labs/context. Needed for changes in client-src/contexts/openapi-context.js
- Tell NPM to use the generated javascript changes via the `workspaces` key.
  - Instead of adding as a dependency like [I initially did here](ccd5c8e71b (diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R101)), rather keep the "dependencies" only for ones pulled from npm remotely.
  - workspaces are meant more for packages that comes from the filesystem
  - Docs: https://docs.npmjs.com/cli/v9/using-npm/workspaces?v=true

requirements.txt
- Tell pip to install the python package.

package-lock.json
- Generated changes from adding context and workspaces.

* revert accidental Werkzeug upgrade

* fix devcontainer

* Remove context & failed attempt at global

changes:
- Remove the context
- Move the openapi client to js-src
- modify gulp task to:
  - ignore the test file
  - add the openapi-client to the rollup task instead of the js task since it is a es6 module (because it has an import / require statement)
- Attempt to construct the object in the spa template. It failed to work at load time. More details below:

When trying to call my exported class at page load like the regular client, I get a not defined error.
There are thoughts about this:
- https://stackoverflow.com/a/75026222
- https://stackoverflow.com/a/53630402
- https://stackoverflow.com/a/69888825

This commit serves as an attempt to try it out

Turns out, script type "module" is automatically set to defer and cannot be disabled.

* add new rollup for cjs for openapi client

* add more tests

* fix middleware
2023-03-24 17:46:28 -04:00
Jason Robbins 030a96b1c2
Add roadmap check to prepub reminder email. (#2858)
* Add roadmap check to prepub reminder email.

* Use {{site_url}} for roadmap link
2023-03-23 18:18:40 -07:00
Daniel Smith 2d5bb78f0f
Update email templates to use new schema (#2837)
* Escalate accuracy verification notifications

* small comment change

* Remove unrelated change

* update templates to use new schema

* better type hinting

* update escalation check approach

* update intentpreview imports

* merge fix
2023-03-23 11:47:15 -07:00
Daniel Smith 772746640c
Escalate accuracy verification notifications after 3 weeks (#2832)
* Escalate accuracy verification notifications

* small comment change

* Remove unrelated change

* update escalation check approach

* remove unused import
2023-03-16 18:01:16 -07:00
Jason Robbins ff2ab3ab77
Add adoption fields to intent template. (#2805) 2023-03-08 17:08:49 -08:00
Kyle Ju 9001b06bdf
Add /newfeatures page rollout banner (#2580)
* Add rollout banner

* test template

Co-authored-by: Kyle Ju <kyleju@chromium.org>
2022-12-14 11:31:36 -08:00
Jason Robbins 6f06dddbee
Fix extra slash in prepub emails. (#2494) 2022-11-22 10:53:39 -08:00
Jason Robbins 4feea61213
Fix links to lighthouse docs (#2391)
* Fix links to lighthouse docs

* Update goldens
2022-10-25 09:16:46 -07:00
Jason Robbins e87c77ce8f
Show a message to anyone that visits /samples. (#2382)
* Show a message to anyone that visits /samples.

* fix test
2022-10-24 11:40:33 -07:00
Jason Robbins 7cb47fe0d8
Fix unclosed h3 in prepub email. (#2368) 2022-10-19 13:25:43 -07:00
James C Scott III ad9ee9ae31
Remove all references to django (#2358)
* Remove all references to django

Replace any functionality with flask

* more cleanup

* fix template test after removing empty comment

* remove unused test_app
2022-10-19 13:51:39 -04:00