* new Intents API and notifier for intent sending
* OpenAPI for Intents API
* Add request body for Intents API POST
* reference request object correctly
* Intents API tests
* notifier tests for intent posting
* fix tests
* changes suggested by @jrobbins
* changes suggested by @jcscottiii
* Fix tests and add new ones
* mypy and test fix
* Changes suggested by @jcscottiii
* Use OpenAPI object to create response
* Replace breaking_change by enterprise_impact on features
This change also removes rollout_impact on rollout stages as It
becomes redundant.
A migration plan is added where features that are marked as breaking
will have a medium impact and the highest rollout_impact will be
translated to the enterprise_impact of the corresponding feature.
The deprecated fields are not yet removed as they are needed for the
migration.
All code paths that relied on breaking_change being true will now rely
on enterprise_impact being at least at low impact.
* This new field is used to control the first milestone where a feature will be shown in the enterprise release notes.
* This field is set by default on enterprise features and can be modified only if the feature has not yet been in the release notes.
* This field cannot be set to a milestone that has already been released,
* For non-enterprise features that are marked as breaking change, this field is automatically added.
* When a feature is no longer a breaking change, if the feature had not been in the release notes, the field will be cleared.
* This PR also adds the possibility to do input checks by comparing a new value to the initial value of the field
* parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414849 -0700
parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414839 -0700
parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414831 -0700
parent 404a3ae89b
author Ping <5123601+pingren@users.noreply.github.com> 1694449778 +0800
committer Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com> 1695414745 -0700
Documentation for feature links (#3317)
* Add documentation for feature links
* Update documentation for feature links
npm: bump tar from 6.1.15 to 6.2.0 (#3318)
Bumps [tar](https://github.com/isaacs/node-tar) from 6.1.15 to 6.2.0.
- [Release notes](https://github.com/isaacs/node-tar/releases)
- [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md)
- [Commits](https://github.com/isaacs/node-tar/compare/v6.1.15...v6.2.0)
---
updated-dependencies:
- dependency-name: tar
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump eslint from 8.48.0 to 8.49.0 (#3319)
Bumps [eslint](https://github.com/eslint/eslint) from 8.48.0 to 8.49.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.48.0...v8.49.0)
---
updated-dependencies:
- dependency-name: eslint
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump @babel/register from 7.22.5 to 7.22.15 (#3320)
Bumps [@babel/register](https://github.com/babel/babel/tree/HEAD/packages/babel-register) from 7.22.5 to 7.22.15.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.15/packages/babel-register)
---
updated-dependencies:
- dependency-name: "@babel/register"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump rollup from 3.28.1 to 3.29.1 (#3321)
Bumps [rollup](https://github.com/rollup/rollup) from 3.28.1 to 3.29.1.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rollup/rollup/compare/v3.28.1...v3.29.1)
---
updated-dependencies:
- dependency-name: rollup
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Enforce rollout milestones to have a minimum value of 100 (#3316)
Revert "temporarily remove OT cron" (#3322)
This reverts commit 5da4d251a9.
Update cron description (#3323)
* Update cron.yaml
* Update cron.yaml
Update chromedash-feature-detail.js (#3324)
Record vote activities with amendments instead of text. (#3314)
* Record vote activities with amendments instead of text.
* Stop checking comments_only
Add support for testing mobile (i.e. narrow window). (#3325)
* Add support for testing mobile (i.e. narrow window).
* Cleanup
Ensure all available features for a release note are fetched (#3328)
- Add new query parameter releaseNotesMilestone to the GET /features route
- Ensure all shipping and enterprise features are returned from the milestone specified in releaseNotesMilestone until the latest available feature
- Update front end logic to wait for a channel to be selected before getting the features for the release notes
- Update front end logic to fetch policies each time the target milestone is changed
Add 3 more fields for OT creation (#3327)
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
Add indexes needed for enterprise release notes. (#3329)
Hide enterprise features from /features page (#3330)
Enterprise features were shown on /features when they should never be shown there.
This PR filters out enterprise features from the features sent to /features
Ensure milestone comparison is made between two int types (#3331)
Add `ot_feedback_submission_url` field (#3333)
Add 3 more fields for OT creation
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
remove test line
Add basic UI for trial creation request
Add `ot_feedback_submission_url` to ot creation
ot button only shows on ot stage details
Update chromedash-feature-detail.js
fix OT button
cancel button returns to feature detail
add ot milestone fields
Update chromedash-feature-detail.js
Add action_requested field for creation/extension
show button disabled if already requested
trial association cron clears ot action requests
`/admin/ot_requests.html`
Fix base.css unix perms. (#3338)
don't write to the same entity multiple times (#3345)
npm: bump @babel/preset-env from 7.22.15 to 7.22.20 (#3340)
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.22.15 to 7.22.20.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-preset-env)
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump @lit-labs/context from 0.4.0 to 0.4.1 (#3341)
Bumps [@lit-labs/context](https://github.com/lit/lit/tree/HEAD/packages/labs/context) from 0.4.0 to 0.4.1.
- [Release notes](https://github.com/lit/lit/releases)
- [Changelog](https://github.com/lit/lit/blob/main/packages/labs/context/CHANGELOG.md)
- [Commits](https://github.com/lit/lit/commits/@lit-labs/context@0.4.1/packages/labs/context)
---
updated-dependencies:
- dependency-name: "@lit-labs/context"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump sass from 1.66.1 to 1.67.0 (#3342)
Bumps [sass](https://github.com/sass/dart-sass) from 1.66.1 to 1.67.0.
- [Release notes](https://github.com/sass/dart-sass/releases)
- [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
- [Commits](https://github.com/sass/dart-sass/compare/1.66.1...1.67.0)
---
updated-dependencies:
- dependency-name: sass
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
npm: bump @playwright/test from 1.37.1 to 1.38.0 (#3343)
Bumps [@playwright/test](https://github.com/Microsoft/playwright) from 1.37.1 to 1.38.0.
- [Release notes](https://github.com/Microsoft/playwright/releases)
- [Commits](https://github.com/Microsoft/playwright/compare/v1.37.1...v1.38.0)
---
updated-dependencies:
- dependency-name: "@playwright/test"
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add test of entering a blink_component name (#3349)
* Add test to enter blink component
* Update the README a bit.
* Change name of test, update images.
* Delete commented out code.
npm: bump @babel/core from 7.22.11 to 7.22.20 (#3344)
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.22.11 to 7.22.20.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.22.20/packages/babel-core)
---
updated-dependencies:
- dependency-name: "@babel/core"
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add `ot_owner_email` and `ot_display_name` fields
Add 3 more fields for OT creation
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
remove test line
Add basic UI for trial creation request
Update chromedash-feature-detail.js
cancel button returns to feature detail
add ot milestone fields
fix test
Add "overdue" to the tooltip on overdue gate chips. (#3350)
* Add "overdue" to the tooltip on overdue gate chips.
* Also remove gate name.
Add `ot_action_requested` field to denote sent requests (#3336)
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Add action_requested field for creation/extension
* Refined requests admin page
Add `ot_owner_email` and `ot_display_name` field (#3351)
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Squashed commit of the following:
commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:06:53 2023 -0700
Update chromedash-feature-detail.js
commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:00:01 2023 -0700
add ot milestone fields
commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:18:46 2023 -0700
cancel button returns to feature detail
commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:02:06 2023 -0700
fix OT button
commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:49:21 2023 -0700
Update chromedash-feature-detail.js
commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:44:07 2023 -0700
ot button only shows on ot stage details
commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 16:04:52 2023 -0700
Add `ot_feedback_submission_url` to ot creation
commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 14:16:22 2023 -0700
Add basic UI for trial creation request
commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:50:19 2023 -0700
remove test line
commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:46:44 2023 -0700
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 10:53:06 2023 -0700
Add 3 more fields for OT creation
* Add `ot_owner_email` and `ot_display_name` fields
* fix test
User email automatically added to OT contacts list (#3339)
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Squashed commit of the following:
commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:06:53 2023 -0700
Update chromedash-feature-detail.js
commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:00:01 2023 -0700
add ot milestone fields
commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:18:46 2023 -0700
cancel button returns to feature detail
commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:02:06 2023 -0700
fix OT button
commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:49:21 2023 -0700
Update chromedash-feature-detail.js
commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:44:07 2023 -0700
ot button only shows on ot stage details
commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 16:04:52 2023 -0700
Add `ot_feedback_submission_url` to ot creation
commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 14:16:22 2023 -0700
Add basic UI for trial creation request
commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:50:19 2023 -0700
remove test line
commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:46:44 2023 -0700
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 10:53:06 2023 -0700
Add 3 more fields for OT creation
* Add `ot_owner_email` and `ot_display_name` fields
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* user email automatically added to ot contacts list
* update to use new `ot_owner_email` field
* fix test
---------
Co-authored-by: Ping <5123601+pingren@users.noreply.github.com>
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Squashed commit of the following:
commit 142f605e74
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:06:53 2023 -0700
Update chromedash-feature-detail.js
commit 83c98ea8a9
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 20 15:00:01 2023 -0700
add ot milestone fields
commit b50933fcb6
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:18:46 2023 -0700
cancel button returns to feature detail
commit 9047830f20
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 09:02:06 2023 -0700
fix OT button
commit b442dfd495
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:49:21 2023 -0700
Update chromedash-feature-detail.js
commit e78ed6bab1
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Mon Sep 18 08:44:07 2023 -0700
ot button only shows on ot stage details
commit a2d8df8047
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 16:04:52 2023 -0700
Add `ot_feedback_submission_url` to ot creation
commit cb0b1e621f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Fri Sep 15 14:16:22 2023 -0700
Add basic UI for trial creation request
commit a843707680
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:50:19 2023 -0700
remove test line
commit 1b471fad6f
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 12:46:44 2023 -0700
`stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
commit cc0308efc7
Author: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
Date: Wed Sep 13 10:53:06 2023 -0700
Add 3 more fields for OT creation
* Add `ot_owner_email` and `ot_display_name` fields
* fix test
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Add basic UI for trial creation request
* Add `ot_feedback_submission_url` to ot creation
* ot button only shows on ot stage details
* Update chromedash-feature-detail.js
* fix OT button
* cancel button returns to feature detail
* add ot milestone fields
* Update chromedash-feature-detail.js
* Add action_requested field for creation/extension
* Add 3 more fields for OT creation
* `stage_description` -> `ot_description`
With a more detailed description of the field and its relation to OT
* remove test line
* Initial install of playwright visual tests
* Close to working.
* who knows...
* after updates
* Extend devcontainer docker compose file for playwright (#3192)
* Extend devcontainer docker compose file for playwright
Create another docker compose file for playwright.
That new one extends the existing docker compose
Should be able to run:
`npm run pwtests`
* adjust gh action
* adjust gh action
* remove volumes
* add timeout
* fix volumes
* Fix docker compose environment
* ignore stuff and volume mounting
* Attempting to login reliably
* Auto cleanups.
* Finally starting to work
* Thought it was getting better, but maybe not
* Seems reliable now
* Higher success rate
* Add test of entering feature name. Remove new feature page content test.
* Add playwright-report dir to Dockerfile.
* Comment out mkdir -p /work/playwright-report line.
* Update screenshots.
* Increasing timeout for entering feature name
* try running as user (#3248)
* try running as user
* again
* try
* change volume ownership
* tidy up
* Adjust login process to be more reliable.
* Add 5 second delay before first test runs.
* Wait longer for first login.
* Add auto-logout during login if already logged in
* Screenshot after login click
* Add testName to screenshots. Upload artifacts. Fix form method="POST".
* Add doc to README for Updating the test_html_rendering files.
* Maybe increase chance of login.
* Add a couple more delays.
* Repeat auto-logout during login until no longer logged in, before logging in again.
* Add some more delays.
* Use loginButton.click(). Add delay before after-click screenshot.
* Add console info an errors to login process.
* Capture console messages, relay to terminal.
* Capture console messages properly.
* Add some more console messages during login.
* Ignore error on jsonValue.
* Reduce most delays. Add more logs. Add top-level playwright call.
* More logging to figure out why login fails
* More logging to detect if ever logged in.
* Add more logging to each stage of testing
* Use history.replaceState before changing location.
* Use location.reload() after a timeout.
* After login, just load home page.
* Add playwright-report to artifacts.
* Turn off playwright-report during CI
* Log response after login
* Only log first response after request that should log in.
* Look for 'currentuser/permissions' request/response.
* Delay after mock_login and before reload of home page
* Comment out header and cookie logs.
* Act like logged when in DEV_MODE and login attempted.
* Fix mock mock login.
* Undo fake mock_login.
* rearrange docker (#3265)
* Updates after changes by James.
* Fix previous updates.
* Remove pwtests-shutdown from "stop" command.
* Remove pwtest from client-src/elements. (moved to packages/playwright/tests)
* update paths for run.sh
* Add pwtests-shutdown to top-level stop command.
* Remove "playwright" from ./wait-for-app.sh
* Add logging of user login status.
* add playwright_display for debugging
* add server debugging
* Remove extra "/__screenshots__" in path.
* Update the path for test-results artifacts in the playwright.yml
* add health checks
* fix action
* fix run.sh
* Add beforeAll method, disabled.
* add dsadmin
* Add top level pwtests command, not working yet.
* cleanup and undo changes
* use transactions
* always reuse server
* temp: limit the workers
* Partial cleanup. Reduce timeouts and delays a bit.
* More cleanup. Reduce timeout/delay.
* Update the correct README file. Update html rendering tests.
* Remove unnecessary changes.
* set script-shell to fix source not found and call npm run setup (#3292)
* set script-shell to fix source not found and call npm run setup
There has always been `source: not found` in the previous CI jobs
The tests previously worked because
npm run deps installs the requirements into the default environment and not the virtual environment.
And since we actually did not call `source` correctly, it was okay because
the default environment had the packages installed.
The problem started to arise because we started to call `source`
correctly in some places but not all places. This fixes by setting the
shell consistently whenever we call `source`
More info:
https://morgan.cugerone.com/blog/troubleshooting-source-not-found-when-in-the-context-of-package-json-scripts/
* do each separately
* Revert "do each separately"
This reverts commit 4fc75f7407.
* do ci job
* consistent to the right datastore mode
* verbose
* kill the emulator
* remove verbose
* Reenable Google login
* Finish reenabling Google signin button. Add margin for Firefox.
* Only show Google signin if playwright is not active
* Preserve url on login. Use default num of workers. Retry tests in CI
* Some updates after comments
* optimize docker changes
* Rename account-indicator. Shorten some delays.
* revert the workers
* Make playwright.yml push and pull_request triggers be like others.
* Use getByTestId instead of locator with data-testid.
---------
Co-authored-by: James C Scott III <jcscottiii@users.noreply.github.com>
Co-authored-by: James Scott <jamescscott@google.com>
* Defaut to opening the menu drawer on the old feature list page.
* Remade template test golden
* Update templates/features.html
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
* Remade template test golden
---------
Co-authored-by: Daniel Smith <56164590+DanielRyanSmith@users.noreply.github.com>
* Allow deletion of enterprise features and stages
* Features can now be deleted by their creator
* Enterprise rollout stages can be deleted
* Refactor the edit all page to use the repeat directive so that the right elements are deleted
* Fix archived stages returned and stage not being created when feature has 0 stages in edit all
- Modify the "Add stage dialog" to receive a custom submit handler that replaces the default behavior of creating a new stage.
- Modify the edit all page to add a stage on the client only via a custom submit handler that it passes to the "Add stage dialog"
- Modify the form field names of stages added only on the client so that they can be created on submit
- Modify the server so that it creates new stages for the stages that were only created on the client
Jason Robbins
Daniel Smith
Jeffrey Yasskin
Raja Majumdar
Yann Dago
Daniel LaLiberte
Kyle Ju
Ping