Граф коммитов

1945 Коммитов

Автор SHA1 Сообщение Дата
James Lamb 61b3c30842
add rules for tests/ in CODEOWNERS (#3226) 2020-07-13 10:43:18 -05:00
Nikita Titov 4b74139ad9
[ci] bump R 4 version (#3225) 2020-07-13 17:22:16 +03:00
James Lamb 1c21d12eb3
removing custom R-to-C++ interface (#3223) 2020-07-12 21:16:30 -05:00
James Lamb 2792923d35
[R-package] Add version floor of R 3.5 (fixes #3212) (#3216) 2020-07-11 22:37:31 -05:00
James Lamb 7b935430d8
[R-package] remove unused Suggests dependencies (#3217) 2020-07-10 08:41:55 -05:00
guanqun e7a2b66f9c
typo fix (#3174) 2020-07-09 16:01:10 +08:00
Lewington-pitsos 2ee77ba07c
[docs] Improve some phrasing in the installation guide (#3214)
* Improve some phrasing

* implement requested changes
2020-07-08 21:48:47 +03:00
Hongbin Shi adda5c5330
Remove extra semicolons (#3215) 2020-07-08 16:04:22 +08:00
Guolin Ke aef50f8614
[python] fix early_stopping_round = 0 (#3211)
* Update engine.py

* Update sklearn.py
2020-07-07 19:48:08 +03:00
Belinda Trotta 1e2013a306
Fix integer overflow in auc_mu. (#3209) 2020-07-07 17:55:40 +08:00
James Lamb d8bc0fc7e5
[ci][docs][R-package] catch builds that have not updated docs (#3205)
* [ci] [R-package] catch builds that have not updated docs

* drop reliance on .Renviron

* remove docs changes

* Update .ci/test_r_package.sh

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* make all R tasks start with r-package

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2020-07-06 00:32:37 +03:00
Nikita Titov bf01f53a01
[ci] bump gcc version for macOS (#3208)
* update gcc version

* Update setup.sh

* fix GitHub Actions
2020-07-05 15:30:49 -05:00
Belinda Trotta 4f8c32d9a6
[R-package] Interface for interaction constraints (#3136)
* Add interaction constraints functionality.

* Minor fixes.

* Minor fixes.

* Change lambda to function.

* Fix gpu bug, remove extra blank lines.

* Fix gpu bug.

* Fix style issues.

* Try to fix segfault on MACOS.

* Fix bug.

* Fix bug.

* Fix bugs.

* Change parameter format for R.

* Fix R style issues.

* Change string formatting code.

* Change docs to say R package not supported.

* Refactor check_interaction_constraints into separate function, add validation.

* Fix error messages.

* Add tests.

* Update docs.

* Fix tests, minor refactoring.

* Fix style issues.

* Fix R style issue.

* Remove old code.

* Fix existing test and add new one.

* Fix R lint error.
2020-07-02 13:45:44 -05:00
shiyu1994 cfc5e4fe8b
store the true split gain in tree model (#3196) 2020-07-02 13:09:10 +08:00
Guolin Ke ddf8c104a4
Allow the minimal feature to 1 in column sampling (#3197)
Co-authored-by: StrikerRUS <nekit94-12@hotmail.com>
2020-07-02 00:57:33 +03:00
James Lamb 314b9d2467
[R-package] [ci] Fix MiKTeX downloads (fixes #3198) (#3199)
* [R-package] [ci] Fix MiKTeX downloads (fixes #3198)

* use v2
2020-07-01 19:28:02 +03:00
Ilya Matiach 9f367d11ad
adding sparse support to TreeSHAP in lightgbm (#3000)
* adding sparse support to TreeSHAP in lightgbm

* updating based on comments

* updated based on comments, used fromiter instead of frombuffer

* updated based on comments

* fixed limits import order

* fix sparse feature contribs to work with more than int32 max rows

* really fixed int64 max error and build warnings

* added sparse test with >int32 max rows

* fixed python side reshape check on sparse data

* updated based on latest comments

* fixed comments

* added CSC INT32_MAX validation to test, fixed comments
2020-06-28 19:19:19 +03:00
Belinda Trotta d563aff9a6
Fix bug with interaction constraints (#3189)
* Fix bug: crashes when interaction_constraints is nonempty and not all features are used.

* Fix python lint error.
2020-06-28 14:46:06 +08:00
Alex 7284946614
[python][scikit-learn] new stacking tests and make number of features a property (#3173)
* modify attribute and include stacking tests

* backwards compatibility

* check sklearn version

* move stacking import

* Number of input features (#3173)

* Number of input features (#3173)

* Number of input features (#3173)

* Number of input features (#3173)

Split number of features and stacking tests.

* Number of input features (#3173)

Modify test name.

* Number of input features (#3173)

Update stacking tests for review comments.

* Number of input features (#3173)

* Number of input features (#3173)

* Number of input features (#3173)

* Number of input features (#3173)

Modify classifier test.

* Number of input features (#3173)

* Number of input features (#3173)

Check score.
2020-06-27 21:26:13 +03:00
Nikita Titov 5d2cc516a0
[docs] document option to build a static library (#3190) 2020-06-27 16:36:55 +03:00
James Lamb 068a67d8e4
[R-package][ci] update to R 4.0.2 for Windows CI jobs (fixes #3191) (#3193)
* first attempt

* update to R 4.0.2

* no duplicate builds

* [R-package] [ci] update to R 4.0.2 for Windows CI jobs (fixes #3191)
2020-06-27 15:40:45 +03:00
Darby Payne 2e2757f183
Adding static library option (#3171) 2020-06-26 22:32:36 +03:00
James Lamb be85f56ffc
[R-package] fix R CMD check NOTE about leftover files (#3181)
* [R-package] fix R CMD check NOTE about leftover files

* update number of allowed notes
2020-06-23 09:01:02 -05:00
Belinda Trotta bca2da9728
Interaction constraints (#3126)
* Add interaction constraints functionality.

* Minor fixes.

* Minor fixes.

* Change lambda to function.

* Fix gpu bug, remove extra blank lines.

* Fix gpu bug.

* Fix style issues.

* Try to fix segfault on MACOS.

* Fix bug.

* Fix bug.

* Fix bugs.

* Change parameter format for R.

* Fix R style issues.

* Change string formatting code.

* Change docs to say R package not supported.

* Remove R functionality, moving to separate PR.

* Keep track of branch features in tree object.

* Only track branch features when feature interactions are enabled.

* Fix lint error.

* Update docs and simplify tests.
2020-06-23 16:39:48 +03:00
Nikita Titov f5e516493e
[ci][docs] added GitHub Actions badge and simplified condition in config (#3179)
* added GitHub Actions badge

* simplified condition in config
2020-06-23 01:18:32 +03:00
James Lamb 85b2843970
[R-package] [ci] cut nrounds in unit tests (#3169) 2020-06-23 00:25:10 +03:00
Nikita Titov fa2de89bb6
[docs][scikit-learn] removed duplicated docstrings (#3164)
* Revert "[ci][docs] temporarily pin Sphinx version (#3157)"

This reverts commit b3a84df5af.

* removed duplicated docstrings
2020-06-23 00:06:46 +03:00
Nikita Titov b6ec745892
[ci] update Boost version (#3175) 2020-06-22 23:37:39 +03:00
Nikita Titov 454aa336d0
[ci][docs] fix broken links (#3176)
* Update make.bat

* Update README.rst

* Update .linkcheckerrc

* Update GPU-Windows.rst

* Update GPU-Windows.rst
2020-06-22 11:36:15 -05:00
James Lamb 8696a490de
[ci] Move R Windows CI to GitHub Actions (#3168)
* [ci] Move R Windows CI to GitHub Actions

* fix OS filter

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* remove trailing semicolon

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2020-06-21 20:08:58 -05:00
James Lamb e83042f206
[R-package] Add support for R 4.0 (fixes #3064, fixes #3024) (#3065)
* [R-package] replaced gendef.exe with R code to create R.def (fixes #3064)

* fix broken things

* trying to add R4.0 docs

* changed make

* fixing make paths

* update notes on environment variables

* fix linting

* fixes to CI

* fixing build_cmd and other stuff

* fix bad substitution

* fix Azure Linux builds

* I am bad at bash

* simplifying

* only testing R

* getting better logs

* mingw32

* docs

* toolchain

* using msys

* fix visual studio condition

* toolchain test

* full CI

* fix if-elses

* bump allowed NOTEs

* search for Rscript

* updates to docs

* use processx

* fix mismatched arguments

* move CI to GitHub Actions

* minor changes

* fix workflow file

* fix templating

* fix Azure DevOps

* debugging windows builds

* dont shQuote file name

* all GitHub Actions jobs

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* minor cleanup

* remove objdump printing

* make file.remove() invisible

* Apply suggestions from code review

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

* reduce duplicated paths in docs

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2020-06-14 08:56:34 +08:00
Nikita Titov e706bec7da
[ci] avoid VS warning for R builds (#3162) 2020-06-12 00:44:43 +03:00
Nikita Titov f30e0bb3d9
refactor LGBM_DatasetGetFeatureNames (#3022) 2020-06-11 03:05:01 +03:00
Nikita Titov b3a84df5af
[ci][docs] temporarily pin Sphinx version (#3157) 2020-06-11 01:52:09 +03:00
Guolin Ke 8092c9fe7a
Update tree.cpp (#3148) 2020-06-09 17:56:15 +08:00
Nikita Titov ce95d9ca8a
fix error C3861: '_BitScanReverse': identifier not found (#3141) 2020-06-06 00:57:12 +03:00
Nikita Titov ac5f5e56d0
Revert "re-order includes (fixes #3132) (#3133)" (#3153)
This reverts commit 656d2676c2.
2020-06-05 18:53:07 +03:00
James Lamb 675b552d53
[R-package] fix best_score using custom evaluation (fixes #3112) (#3117) 2020-06-04 08:57:12 -05:00
Michael Mayer 9d433033f2
[R-package] Turn matrix to storage mode "double" (#3140)
* Turn matrix to storage mode "double"

* added "test_Predictor.R" to R tests with check for integer storage mode during prediction

* Explicit integers in test_Preditor to avoid TravisCI failure

* properly aligning comment on storage.mode

Co-authored-by: James Lamb <jaylamb20@gmail.com>

* split double assignment into two lines

Co-authored-by: James Lamb <jaylamb20@gmail.com>
2020-06-03 21:49:04 -05:00
Alex a2a38b6cd5
[python][scikit-learn] add new attribute for used number of features (#3129)
* update number of features attribute

Fixes issue related to https://github.com/scikit-learn/scikit-learn/issues/17353 (see SLEP010 https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep010/proposal.html).

* Update sklearn.py

* set public attribute in fit method

Reverted ```n_features``` property, and inserted the public attribute ```n_features_in_```.

* Update documentation

* Update python-package/lightgbm/sklearn.py

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2020-06-02 21:09:58 +03:00
James Lamb 075513fa27
[ci] make MiKTeX downloads more reliable (#3124)
* [ci] make MiKTeX downloads more reliable

* switch to Powershell

* remove  extra slash

* fixing stuff

* revert install change

* Update .ci/test_r_package_windows.ps1

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>

Co-authored-by: Nikita Titov <nekit94-08@mail.ru>
2020-06-01 22:34:53 -05:00
James Lamb bcbf2527ca
[ci] use GitHub Actions for R CI jobs (fixes #2353) (#3119)
* GitHub Actions

* ok

* fixing on list

* stuff

* directories

* directories

* things

* env variables

* working dir

* running a bunch of tasks

* more builds

* PATH

* actually use R task

* TASK

* be right, often

* doing stuff

* trying stuff

* more paths

* conda activate

* updating PATH

* trying bash

* where the hell is activate

* WHERE IS ACTIVATE

* set up conda

* more conda

* PLEASE WORK

* installing cpplint

* try r-package

* R version

* try windows job

* make windows work

* use powershell

* exe

* use conda

* conda init powershell

* different conda approach

* make it work

* cleaning up

* init powershell

* fixing windows

* more windows

* build directory

* no way right

* maybe it will work

* trying Visual Studio

* do this

* Windows is interesting

* put back check-output

* set compiler

* stuff

* more fixes

* fix the broken things

* updating jobs

* continuing

* poweshell is bad

* ok so maybe not powershell

* cmon now

* ok so

* fixing env variables

* maybe this

* MINGW job

* cleaning up

* conda init powershell

* moving more R stuff into GitHub Actions

* everything else

* use powershell

* cmon now powershell

* ttry to Continue

* override powershell

* peg MiKTeX URL

* what is happening

* try powershell -File

* trying stuff

* path

* more testing of output

* Matches uppercase

* more regex stuff

* this is getting ridiculous

* back to powershell I guess

* more commands

* this might work

* adding more reliable miktex download

* trying to download miktex

* installing httr

* fix error in MiKTeX script

* remove comments

* redirect output

* redirect output

* move linting back to Travis

* change redirection

* switch back to just mac and linux

* put linting exclude back

* renamed R_TRAVIS_LINUX

* revert changes to non-R tasks and update events

* simplify
2020-06-01 17:53:39 -05:00
James Lamb 656d2676c2
re-order includes (fixes #3132) (#3133) 2020-06-01 22:13:32 +03:00
James Lamb f82e943c9f
[ci] remove unused environment variable in CI setups (#3125) 2020-05-29 02:23:41 +03:00
Ilya Matiach 8ead7cc1ca
memory corruption fix for distributed data parallel version before SyncUpGlobalBestSplit (#3110)
* memory corruption fix for distributed data parallel version before SyncUpGlobalBestSplit

* updated based on comments

* updated voting and feature parallel based on comments

* fixing macos failure

* rename variable
2020-05-26 19:28:12 +03:00
James Lamb 51b84df8d7
[R-package] fix issue where early stopping thinks higher MAPE is desirable (fixes #3099) (#3101)
* [R-package] fix issue where early stopping thinks higher MAPE is desirable (fixes #3099)

* fix linting

* only use main metrics

* fix tests
2020-05-24 21:24:38 -05:00
James Lamb 4d43e96bbc
[R-package] move R source files into R-package, reduce duplication in build_r.R (#3087)
* [R-package] move R source files into R-package

* fix linting warning

* stuff
2020-05-24 21:23:38 -05:00
guanqun cd70bad46c
fix a bug when we set the default score (#3114) 2020-05-25 09:34:45 +08:00
James Lamb 74e5ec4b9e
fix MSVC warning about control paths (fixes #3067) (#3068)
* [R-package] fix MSVC warning about control paths (fixes #3067)

* linting

* simplify
2020-05-22 21:37:02 -05:00
odimka 7fe10fa10b
Fixed machine list parsing: s/find_first_of/find (#3108) 2020-05-22 10:37:20 +08:00