By default, fake .dSYM files
will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds.
mac_want_real_dsym can be used to override this.
mac_real_dsym can't be set directly, because it's not a % variable.
According to https://codereview.chromium.org/113999, it can't be made a
% variable now, because of a bug in % handling in GYP that leads to
mac_real_dsym being unconditionally set to 1 for some targets.
BUG=148383
TBR=thakis
Review URL: https://codereview.chromium.org/11636014
git-svn-id: http://src.chromium.org/svn/trunk/src/build@173896 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
will be generated for regular builds, and dsymutils will be used to create .dSYMs for ASan builds.
mac_want_real_dsym can be used to override this.
mac_real_dsym can't be set directly, because it's not a % variable.
According to https://codereview.chromium.org/113999, it can't be made a
% variable now, because of a bug in % handling in GYP that leads to
mac_real_dsym being unconditionally set to 1 for some targets.
BUG=148383
Review URL: https://chromiumcodereview.appspot.com/11587012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@173749 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previously many custom GYP_DEFINES were needed to get a
chrome build for linux/arm. This adds these as sensible
defaults. This allows chrome for arm to be built with
with only target_arch=arm set in GYP_DEFINES.
In order to set a default sysroot based on target_arch
this change also defines target_arch one level deeper
in common.gypi.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11465030
git-svn-id: http://src.chromium.org/svn/trunk/src/build@172377 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Previous attempt; expanded since then:
https://chromiumcodereview.appspot.com/10332156/
* The search string has "sourceid=chrome-mobile" on Android devices.
* SearchTermsDataAndroid added to handle the data values that Android
needs to store for RLZ tracking.
* UiThreadSearchTermsData calls Android specific functions when being
asked for rlz= or client= strings.
* ENABLE_RLZ is moved around (or removed) in some cases to allow use of
the fields even when the RLZ library is not in use.
* The RLZ unit test is changed to account for the way Android sets the
RLZ string.
* A new SearchClient unit test is added to check that setting client
strings works.
BUG=145065
Review URL: https://chromiumcodereview.appspot.com/11448005
git-svn-id: http://src.chromium.org/svn/trunk/src/build@171954 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
to catch memory problems early, easily, and cleanly.
This is disabled by default.
Because of gyp limitations, the flag is to force-disable the feature, but there is no flag to force-enable it.
BUG=30715
TEST=none
Review URL: https://codereview.chromium.org/11266019
git-svn-id: http://src.chromium.org/svn/trunk/src/build@171063 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently if you set profiling=1 content_shell will load,
it will just load to a white screen (and attempts to sample
the binary with perf will not get proper stacks).
This adds -mapcs and -marm per the AndroidPerf wiki docs.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11316228
git-svn-id: http://src.chromium.org/svn/trunk/src/build@170249 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is used for normal builds to strip out lots of unneeded symbols and
minimize binary size. However, for shared library build, this causes
needed symbols to be excluded and subsequent so's to fail linking.
BUG=158821
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11413110
git-svn-id: http://src.chromium.org/svn/trunk/src/build@169060 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The new naming scheme simply appends .pdb to the target (e.g. foo.dll.pdb and
foo.exe.pdb). This is beneficial for a couple reasons:
* no more chrome_dll.pdb and chrome_exe.pdb silliness
* also avoids this issue if we end up with similarly named targets in the
future (target.dll and target.exe)
* ninja already does this, and, by extension, either ninja needs to be broken
to use the old scheme, or the we fix the broken in the existing system.
One less difference between msvs and ninja.
Fixes for chrome-internal stuff: https://chromereviews.googleplex.com/5681015
BUG=
Review URL: https://codereview.chromium.org/11384003
git-svn-id: http://src.chromium.org/svn/trunk/src/build@168341 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This change decouples the logic that associates the app launcher and
settings app with windows-only builds, and consolidates the list of
app_list sources in chrome_browser_ui.gypi.
BUG=160839
TEST=on Windows: compiles with -Denable_app_list=0 (with no app launcher function), and
on Windows: compiles with -Denable_settings_app=0 (with app launcher but no settings app in it)
on ChromeOS: compiles (functional ChromeOS launcher)
Review URL: https://chromiumcodereview.appspot.com/11293267
git-svn-id: http://src.chromium.org/svn/trunk/src/build@167853 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Seems like a clobber might be enough to fix the issues caused by this CL.
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020TBR=pastarmovj@google.com
Review URL: https://codereview.chromium.org/11377023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166405 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Reverted because it is assumed to be the cause for multiple compile failures on mac and linux.
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/11377020
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166369 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Fixes crash in arm codegen.
Doesn't warn on -Wno-arc-abi.
Nicer diagnostics for nested macro instantiations.
Includes asan support for android on linux (shout if you need that on mac).
Fixes issue with debug information in .S files.
Renames -faddress-sanitizer to -fsanitize=address (continue to use -faddress-sanitizer in chromium for now, until we've updated all third-party gyp files)
BUG=159712,159452,159475,159502,159598,59580
TBR=hans
Review URL: https://codereview.chromium.org/11361133
git-svn-id: http://src.chromium.org/svn/trunk/src/build@166365 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is not yet used, but helps lay the groundwork for building chrome/
targets for iOS.
This uses exclude-all-and-include since Chrome for iOS uses only a subset
of chrome/browser/, so the include list will be much more manageable and
maintainable than an exclude list.
BUG=156699
Review URL: https://chromiumcodereview.appspot.com/11361056
git-svn-id: http://src.chromium.org/svn/trunk/src/build@165802 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This doesn't work yet without upstream protobuf changes,
but with this infrastructure in place it's going to be
easier to test further updates.
Google Chrome will of course use the bundled version,
there's no change here.
BUG=157155
TEST=none
Review URL: https://codereview.chromium.org/11231046
git-svn-id: http://src.chromium.org/svn/trunk/src/build@165257 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is not yet used, but helps lay the groundwork for building chrome/
targets for iOS.
This uses exclude-all-and-include since Chrome for iOS uses only a very
small portion of chrome/browser/ui/, so the include list will be much more
manageable and maintainable than an exclude list.
BUG=156699
Review URL: https://chromiumcodereview.appspot.com/11339010
git-svn-id: http://src.chromium.org/svn/trunk/src/build@164908 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The intention is to allow to build iOS Chrome/tests with asan=1, which is only possible with a custom Clang at the moment.
The resulting binaries can't be shipped to users, but can be used to debug memory corruptions.
Review URL: https://codereview.chromium.org/11273012
git-svn-id: http://src.chromium.org/svn/trunk/src/build@164619 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This centralizes this definition and removes it from the various places it is currently replicated. This also allows external projects that rely on Chromium base to compile successfully, as otherwise this (required) definition is missing.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11190060
git-svn-id: http://src.chromium.org/svn/trunk/src/build@163299 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
SDK to verify when an SDK path is set. The SDK path supersedes whatever
find_sdk is supposed to find.
Also: Reorganize the SDK and deployment target variables to be scoped more
appropriately. Add a mac_sdk_min variable to set the main argument to
find_sdk.
Review URL: https://chromiumcodereview.appspot.com/11068023
git-svn-id: http://src.chromium.org/svn/trunk/src/build@160536 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The envsetup configuration for building WebView using the Android build
system has rotted. Rather than try to share the non_sdk_build_init code,
just repeat the (few) parts we need to avoid setting all the parts that
are inappropriate, and fix the parts that are wrong or outdated.
Also, upstream the common.gypi settings that are specific to the WebView
build.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11026038
git-svn-id: http://src.chromium.org/svn/trunk/src/build@160188 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
It stores mapping between object's starting addresses and their
allocated types when a build option 'clang_type_profiler=1' is
specified. It enables information like
"an object at 0x37f3c88 is an instance of std::string."
Nothing is changed when the option is not specified.
It depends on a modified version of the LLVM/Clang compiler
introduced at deps/third_party/llvm-allocated-type.
BUG=123758
TEST=build with clang_type_profiler=1 and run type_profiler_unittests and type_profiler_map_unittests manually.
Review URL: https://chromiumcodereview.appspot.com/10411047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@158752 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
If the DoneCallback returns false, breakpad should reinstall the old
signal handlers. Specifically, it will reinstall the Android tombstone
handler. This change ensure that on Android we always return false from
these callbacks. When this happens, the minidump should still be
created/uploaded as normal.
Also, just prior to returning we log a Chrome build fingerprint. This
should appear in the log just above the tombstone.
Requires breakpad DEPS roll to >=1025
(http://breakpad.appspot.com/440002/) to work correctly, but fails
safely without it.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10908115
git-svn-id: http://src.chromium.org/svn/trunk/src/build@156063 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Restructures content_app.gypi, content_common.gypi, and content_tests.gypi
slightly to support building them for iOS.
One target, content_browsertests, is excluded entirely for iOS.
More files will be added to the iOS build later, once the content/ build
is working for iOS.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10917130
git-svn-id: http://src.chromium.org/svn/trunk/src/build@155759 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
1474: Emacs mode for gyp: font-lock edition.
1475: Tidy up default toolset for msbuild-based builds.
1476: add -Gstandalone flag
1477: Enable pretty xml generation.
1478: msvs: Ensure trailing slash on IntermediateDir and OutputDir.
1479: mac ninja&make: Pass OTHER_LDFLAGS to libtool for static libraries.
Also don't pass -faddress-sanitizer to libtool.
BUG=113085
Review URL: https://chromiumcodereview.appspot.com/10876059
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153250 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Is causing warnings for Official build in PDF code. Boo.
-----------------
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429TBR=scottmg@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10872063
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153223 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Can't quite be fully enabled yet due to not-yet-fixed third party
dependencies. Without it enabled, other packages regress while we're fixing
things. So, add a flag for now so warnings-freeness can be ratcheted forward
by having it on for most packages, but off for a few.
Also, disable warning in qcms (fixed upstream by a large refactoring, not
worth rolling for), and disable two minor warnings in yasm (patch posted
upstream for a few months, but maintainer does not seem motivated to merge).
Fix release-only warning in leveldatabase/env_chromium.cc. Was calling exit(1)
in a leaky destructor.
Fix a warning in lzma_sdk (missing an include).
Disable a silly warning in Release builds of skia and memory_watcher (that
/GS is not working because optimization is disabled).
Warning are currently tolerated in libvpx and mesa.
Cannot be committed until http://chromiumcodereview.appspot.com/10823426/ has
landed.
R=thakis@chromium.org
BUG=126483,140121, 143877
TEST=
Review URL: https://chromiumcodereview.appspot.com/10827429
git-svn-id: http://src.chromium.org/svn/trunk/src/build@153092 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
without this CL
fastbuild=1 => no debug information
win_z7=1 => debug information available (with /Z7)
fastbuild=1 win_z7 => *.obj has debug info, but linker doesn't generate debug info in *.exe. it would be useless, and just makes build slower
This CL makes win_z7 wins against fastbuild.
R=scottmg,arthurhsu
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10866016
git-svn-id: http://src.chromium.org/svn/trunk/src/build@152953 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The enable_themes and enable_extensions gyp variables were in a different
scope that prevented the grit_defines from having the correct value when
evaluating the condition. Moves the variable assignment into the same
scope as the variable declaration and now everything is happy.
TEST=touch chrome/browser/browser_resources.grd && \
make chrome_resources (check about_version does not have theme icon)
BUG=
Review URL: https://chromiumcodereview.appspot.com/10828396
git-svn-id: http://src.chromium.org/svn/trunk/src/build@152455 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
supports the debug MSVS libc dll. Also disabled debug build inlining
and FPO to support increasing debug build optimization.
Re-add unit_tests to the "Windows Tests (DrMemory)" bot. (The
unit_tests cannot be linked with static_library, which is why they
were removed from the bot.)
BUG=137180
R=rnk@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10834341
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151770 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL removes our custom GYP flag and modifies the build so both the SRPC and IPC proxies are built side by side. In addition, NaClBrowser now checks the '--enable-nacl-ipc-proxy' flag to determine which IRT to load. The IPC proxy's name is of the form 'nacl_ipc_irt_*'.
BUG=116317
TEST=builds and runs NaCl apps with --enable-nacl-ipc-proxy
TBR=bbudge@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831316
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151693 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Before this change we build Release builds size-optimized code with DCHECK,
while we almost never use the Debug build which is not size-optimized.
Now change Debug build to build size-optimized code with DCHECK but still
temporarily keep Release build and default configuration unchanged before
everyone (the bots, scripts and developers) knows how to deal with this change.
Next steps will be:
Step 2: update developer scripts and buildbot scripts to handle the new
configuration.
Step 3: change Release configuration to no DCHECK and change default
configuration to Debug.
After all steps finish, this new configuration will better match Chromium
and WebKit (e.g. better matches the DEBUG and RELEASE tags in WebKit layout
test expectations), and makes it easier to build a performance build.
Review URL: https://chromiumcodereview.appspot.com/10827273
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151589 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This CL removes our custom GYP flag and modifies the build so both the SRPC and IPC proxies are built side by side. In addition, NaClBrowser now checks the '--enable-nacl-ipc-proxy' flag to determine which IRT to load. The IPC proxy's name is of the form 'nacl_ipc_irt_*'.
BUG=116317
TEST=builds and runs NaCl apps with --enable-nacl-ipc-proxy
Review URL: https://chromiumcodereview.appspot.com/10836220
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151581 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Now, to build with goma, you must:
1) Set $GOMA_DIR
2) Specify Goma in the path such as:
PATH=$GOMA_DIR/android/:$PATH ninja -j250 -C out/Release base_unittests_apk
"2)" above is necessary temporarily until the *_target variables are removed from build/android/envsetup.sh
Review URL: https://chromiumcodereview.appspot.com/10834296
git-svn-id: http://src.chromium.org/svn/trunk/src/build@151532 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Currently third_party/zlib/zlib.gyp uses the system libz if:
os_posix == 1 and OS != "mac" and OS != "ios" and OS != "openbsd"
I'm assuming that Android sets os_posix==1 and therefore this change is
a no-op. But it consolidates control of this variable in a single
location.
BUG=none
https://chromiumcodereview.appspot.com/10837100/
git-svn-id: http://src.chromium.org/svn/trunk/src/build@150355 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
These gyp defines are set unconditionally in envsetup, which means they
are not in fact part of the "environment" but just the defaults for the
Android build. Move them into common.gypi instead to make this clear.
Several of them were already the correct setting and can simply be
removed.
The makefiles generated by gyp are identical before and after this
change.
Review URL: https://chromiumcodereview.appspot.com/10825131
git-svn-id: http://src.chromium.org/svn/trunk/src/build@149609 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This broke the WebKit Mac bot, as the directory it works in is different there
compared to the Chromium configuration. Determine the source's root through the
DEPTH define, and then walk up in the build/mac/ directory.
BUG=
TEST=WebKit Mac builder doesn't break after a Chromium DEPS roll.
Review URL: https://chromiumcodereview.appspot.com/10824105
git-svn-id: http://src.chromium.org/svn/trunk/src/build@149181 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Having to manually set mac_sdk was a FAQ when Xcode 4 was released. Now
we're using the 10.6 SDK by default, but Xcode 4.4 ships only with the
10.7 and 10.8 SDKs, so it'll likely become a FAQ again. Automatically
set mac_sdk to something sensible.
(People who explicitly say "mac_sdk=10.6" will have to stop doing so
when they switch to Xcode 4.4.)
BUG=121162
TEST=Build without mac_sdk in GYP_DEFINES. Something useful happens
with Xcode 3.2.6, Xcode 4, Xcode 4.4.
Review URL: https://chromiumcodereview.appspot.com/10824055
git-svn-id: http://src.chromium.org/svn/trunk/src/build@148817 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Now requires you to specifically change the GYP_GENERATORS to specify Ninja. The original change broke because gyp ran for both make and ninja and the webkit bot determines whether to use ninja by the presence of build.ninja (thanks to Peter for figuring this out)
BUG=137569,136693
Review URL: https://chromiumcodereview.appspot.com/10827073
git-svn-id: http://src.chromium.org/svn/trunk/src/build@148790 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This is useful for cases where Xcode doesn't know about the SDK, possibly
because the SDK is installed outside of Xcode altogether. For example, Xcode
4.4 does not include a copy of the 10.6 SDK, so if you have a copy of the 10.6
SDK present at /SDKs/MacOSX10.6.sdk, you can put this in ~/.gyp/include.gypi:
{
'variables': {
'mac_sdk_path': '/SDKs/MacOSX10.6.sdk',
},
}
Review URL: https://chromiumcodereview.appspot.com/10831039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@148680 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Includes:
1) Allowing overridding of android_ndk_sysroot (addition of "%" in
variable name).
2) Disable NOTIMPLEMENTED output for official builds (see base/logging.h)
3) Add clang build configurations
4) Remove unnecessary cflags from regular build.
5) Include crtbegin_so.o and crtend_so.so for _type=="loadable_module"
which is needed for ppapi_tests.
BUG=137569
Review URL: https://chromiumcodereview.appspot.com/10808042
git-svn-id: http://src.chromium.org/svn/trunk/src/build@147986 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The gyp settings for libjpeg currently have a number of problems ...
- Settings for using the system libjpeg are replicated in the gyp files for both libjpeg and libjpeg_turbo.
- The default setting for use_system_libjpeg is different depending on whether libjpeg or libjpeg_turbo is in use. This is unintuitive, as libjpeg_turbo is a drop-in replacement for libjpeg.
This patch improves the situation ...
- Improve documentation about the interaction between use_system_libjpeg and use_libjpeg_turbo.
- Use the libjpeg gyp file whenever use_system_libjpeg==1. This means that the settings for using the system libjpeg are only needed here. (A later patch will remove them from libjpeg_turbo's gyp file). It also means that the libjpeg_turbo repository can be excluded when use_system_libjpeg==1.
- Move all settings concerned with use_system_libjpeg to the libjpeg gyp file.
Note that with this change, we lose the OS-specific defaults for use_system_libjpeg when use_libjpeg_turbo==0. These defaults are currently not used, as use_libjpeg_turbo==1 always.
Review URL: https://chromiumcodereview.appspot.com/10696082
git-svn-id: http://src.chromium.org/svn/trunk/src/build@147254 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
- Use of the system zlib is already the default, but set it explicitly here in
case the default changes.
- Use of the system ICU was fixed in r145879, so we now make use of it.
Also remove static_link_system_icu, which is not used.
Review URL: https://chromiumcodereview.appspot.com/10777006
git-svn-id: http://src.chromium.org/svn/trunk/src/build@146565 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
The initial iOS version was over-ambitious, and doesn't yet build. To
get the build working, this:
- only builds base:base on iOS, not base:*, and
- disables warnings-as-errors in third-party code for iOS, since
at least NSS and ICU have warnings for iOS.
This also adds nss.gyp to the iOS build, now that its gyp support
has landed
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10704153
git-svn-id: http://src.chromium.org/svn/trunk/src/build@146120 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
This enables DCHECK, NOTREACHED, and other debugging code on Android
non-official release builds. Since all Android builds are done in
release mode, we don't set NDEBUG according to whether the build is in
release or debug mode. Rather we set NDEBUG for official builds only.
This requires a change to skia.gyp to define SK_RELEASE exactly the
same when building skia and its direct dependencies:
SK_RELEASE should be defined in skia.gyp only when use_system_skia is
set to 1 because system skia is always in release mode. When building
with chromium version of skia (which is what we do now) this should
not be defined and left to the skia headers to figure out whether to
include debug code or not (they define SK_RELEASE only if NDEBUG was
defined).
BUG=http://b/6712716
Review URL: https://chromiumcodereview.appspot.com/10695047
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145789 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
For the directx it probes in src\third_party\directxsdk if you have the dxsdk there and
for the regular sdk it probems in src\third_party\platformsdk_win8
If it does not find them it takes an educated guess.
The gyp variables windows_sdk_path and directx_sdk_path can be overriden from the environment if
the defaults are wrong.
BUG=none
TEST=chrome builds
Review URL: https://chromiumcodereview.appspot.com/10690072
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145619 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Moves targets that will likely never exist for iOS to a !ios condition block. For the rest of the targets, moves all dependencies to a !ios condition block, with the plan being to move many of them back to the main dependencies section as they come online.
While this is arguably uglier than using a separate file in the short term, in the long term the targets will look essentially like this just with many of the dependencies moved back where they were, so this is a clearer step toward the final state.
Note that this target won't actually build yet; this is just enough that 'gclient runhooks' will succeed.
BUG=None
TEST=None (an FYI bot building all.gyp:All will follow later)
Review URL: https://chromiumcodereview.appspot.com/10695060
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145205 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
First clang roll in a few weeks, so lots of new stuff:
* better 'unused' warnings. Now catches e.g. "AutoLock(&lock);"
* better 'uninitialized' warnings
* template type eliding in diagnostics
* TLS attribute support
* New -Wunused-private-field warning (disabled for now)
* style plugin has better warning for implicit destructors
* method_iterator interface changed back to what it was, update plugin again
* Warn on member variable self assignments
BUG=135207
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10689041
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145022 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
There are basically three categories of changes here:
1) Most OS==mac becomes OS==mac or OS==ios
2) Some Xcode-related settings move into OS==mac blocks since Xcode is no longer Mac-only
3) Addition of iOS-specific settings (SDK, compile flags, etc)
BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10704039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@145008 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
Change common.gypi to pass scale_factors=2x to grit on Mac
(as a side effect, the close button on about:settings now looks
good).
Change bookmark_manager/main.html to type="chrome_html"
so that it gets the 2x image auto-treatment that's documented at
sites.google.com/a/chromium.org/dev/developers/design-documents/high-dpi-resources
The icon in the upper left corner of about:bookmarks looks good
with this change, but the tree icons don't yet because cr/ui/tree.js
needs js code changes to make HiDPI icons work.
BUG=134372,123162
TEST=Open bookmark manager. Almost all images look good in HiDPI.
Review URL: https://chromiumcodereview.appspot.com/10662039
git-svn-id: http://src.chromium.org/svn/trunk/src/build@144305 4ff67af0-8c30-449e-8e8b-ad334ec8d88c
scottmg@chromium.org
qsr@chromium.org
phajdan.jr@chromium.org
glider@chromium.org
wjia@chromium.org
benwells@chromium.org
ivankr@chromium.org
sbc@chromium.org
sebmarchand@chromium.org
yfriedman@chromium.org
fischman@chromium.org
dfalcantara@chromium.org
danakj@chromium.org
vadimt@chromium.org
nileshagrawal@chromium.org
erikwright@chromium.org
felipeg@chromium.org
thakis@chromium.org
sgurun@chromium.org
eseidel@chromium.org
sky@chromium.org
chrisha@chromium.org
iannucci@chromium.org
torne@chromium.org
mirandac@chromium.org
tapted@chromium.org
thestig@chromium.org
hans@chromium.org
scottmg@google.com
brettw@chromium.org
pastarmovj@google.com
eugenis@chromium.org
ilevy@chromium.org
blundell@chromium.org
stuartmorgan@chromium.org
hbono@chromium.org
michaelbai@chromium.org
zhaoqin@google.com
alexeypa@chromium.org
jamesr@chromium.org
pkl@chromium.org
mark@chromium.org
shashishekhar@chromium.org
michaelbai@google.com
glotov@chromium.org
saintlou@chromium.org
maruel@chromium.org
msarda@chromium.org
mihaip@chromium.org
dmikurube@chromium.org
tony@chromium.org
joi@chromium.org
cjhopman@chromium.org
droger@chromium.org
xhwang@chromium.org
ukai@chromium.org
wangxianzhu@chromium.org
tedchoc@chromium.org
lliabraa@chromium.org
peter@chromium.org
bruening@google.com
flackr@chromium.org
bbudge@chromium.org
pkotwicz@chromium.org
agl@chromium.org
newt@chromium.org
rsesek@chromium.org
rohitrao@chromium.org
milanb@chromium.org
benm@chromium.org
gman@chromium.org
steveblock@chromium.org
aruslan@chromium.org
cpu@chromium.org
bradnelson@google.com
rsleevi@chromium.org
hashimoto@chromium.org