-Wmicrosoft-unqualified-friend still fires in one place in ICU,
I'll enable it once I've fixed that.
-Wno-microsoft-enum-value doesn't look like a very useful
warning, maybe we should improve the warning instead of
enabling it.
BUG=505296
R=rnk@chromium.org
Review URL: https://codereview.chromium.org/1311693002 .
Cr-Original-Commit-Position: refs/heads/master@{#345090}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3c872b12c094d27d5044f49d735099f54c188ea
This matches gyp. The flag is not needed on Windows and Mac. (It probably isn't
needed on Android either.)
BUG=263960
Review URL: https://codereview.chromium.org/1295023004
Cr-Original-Commit-Position: refs/heads/master@{#344275}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 64dff6deeae1788cdc60b5c02e82c527385dfe7a
When specifying both --libs-only-l and --libs-only-L to
pkg-config, the results from the latter are not included.
This feels like a bug in pkg-config, reported upstream:
https://bugs.freedesktop.org/show_bug.cgi?id=91689
Our pkg-config.py wrapper can use --libs instead of the
flags mentioned above- this includes flags from both but
maybe also some additional flags (eg -rdynamic).
BUG=522564
Review URL: https://codereview.chromium.org/1291803008
Cr-Original-Commit-Position: refs/heads/master@{#344260}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5c7b1a39088d8b2f78132b5488319d986abd16a
There is a google_play_services_library variable that should be used
instead of hardcoding the java target.
Added another such variable for resources
BUG=521624
Review URL: https://codereview.chromium.org/1299003003
Cr-Original-Commit-Position: refs/heads/master@{#344183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6cd230bdd3ebabff123c44e01ef0384fa1ac1b2b
The shared library flags currently being passed should only be passed in
component builds. The location of dylibs in a non-component build is already
known so it’s superfluous to specify additional search paths via rpath.
-search_paths_first is the default on ld starting with the Xcode4 toolchain.
-L. isn’t needed since the absolute path of the dylib is being specified at link time.
R=mark,dpranke,thakis
BUG=345021
Review URL: https://codereview.chromium.org/1298783003
Cr-Original-Commit-Position: refs/heads/master@{#343793}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 465929bd9eccfd0de10965867e0378eee4a24dd5
This adds support for some of test binaries needed in the
'archive_gpu_tests=true' config of a GYP build:
- content_gl_tests
- gles2_conform_tests
- gl_tests
- tab_capture_end2end_tests
There is still more work to be done (telemetry_gpu_tests,
angle_end2end_tests, angle_deqp_*_tests).
R=brettw@chromium.org
BUG=519778
Review URL: https://codereview.chromium.org/1285063002
Cr-Original-Commit-Position: refs/heads/master@{#343095}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dbdd9d8a60cde386ab1ccab51bd2d818c5b45657
Previously, GN was using the sdk version as the deployment target,
which meant gn-built binaries couldn't run on OS X versions
older than 10.10 after updating the SDK to 10.10.
With this fix, mac GN matches the behavior of Mac GYP.
BUG=463170
Review URL: https://codereview.chromium.org/1285493004
Cr-Original-Commit-Position: refs/heads/master@{#342908}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e194adc1f7bdeeb500dcd357283d512651b6bf1b
The first reland caused Webkit layout test errors on 10.8 and 10.9. Those
errors have been fixed.
Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}
TBR=thakis@chromium.org,amineer@chromium.org
BUG=463170, 515836
Review URL: https://codereview.chromium.org/1268803004
Cr-Original-Commit-Position: refs/heads/master@{#342870}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9cbe267748e0360f8c994a1c7209f86f33b944f
toolchain.gni introduces:
root_shlib_dir, shlib_prefix, and shlib_extension
The original goal of this change was to put shlibs under lib/ for Linux / Android, since that's where GYP puts them. However, the lack of support for loadable_module (or more specifically - per target output directory) in GN makes this infeasible at the moment.
This change also mitigates a subtle bug where on Android the unstripped .so is used mistakenly instead of the lib.stripped/ version. It also fixes shlib's link_output being set to the unstripped .so rather than the stripped .so (on Android).
BUG=509771
Review URL: https://codereview.chromium.org/1236503002
Cr-Original-Commit-Position: refs/heads/master@{#342697}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c3cd5e6fe977af4a3c8b20ccb332896b2c888354
iOS uses the same linker as Mac and thus should use the same linker flags
in Release mode (is_debug=false).
Fix the following error when linking base_unittest in Release mode:
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -arch x86_64 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.0.sdk -stdlib=libc++ -mios-simulator-version-min=7.0 -Wl,-O1 -Wl,--gc-sections -Wl,--as-needed -o ./base_unittests.app/base_unittests -Wl,-filelist,./base_unittests.app/base_unittests.rsp -framework UIKit -framework QuartzCore -framework OpenGLES -framework CoreFoundation -framework CoreGraphics -framework CoreText -framework Foundation
ld: unknown option: -O1
BUG=459705
Review URL: https://codereview.chromium.org/1274633004
Cr-Original-Commit-Position: refs/heads/master@{#342523}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5d2e00bce19e2fae5e1fa0419d78e92570026304
I've taken ad591c629a
and merged it onto Chromium ToT, with a few lint and other cleanups,
and one fix to make sure that Mac still compiled (which may have broken
iOS, haven't tested yet).
R=brettw@chromium.org, sdfresne@chromium.org
BUG=459705
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1250913002
Cr-Original-Commit-Position: refs/heads/master@{#342297}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a29462a04dabad3fc20dc922227c46b36459912
This is set in GYP for all compiler invocations. In GN it was only set in one place in content. This brings GN closer to GYP.
Review URL: https://codereview.chromium.org/1269253003
Cr-Original-Commit-Position: refs/heads/master@{#342230}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d5b2103b272a6ad9ad183e710ff82835226c18b
There seem to be more compiler flags to tweak for other target
architectures, but with this I could at least build & run chrome_apk
with is_clang=true
BUG=402625
Review URL: https://codereview.chromium.org/1258923012
Cr-Original-Commit-Position: refs/heads/master@{#342227}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91d9b7ee4e51168ef413265e33b8fe25253a1758
This ICU roll only renames component_mode -> is_component_build
Update other users of the component_mode string to is_component_build.
Rename the declaration to be local to BUILDCONFIG.gn (prefixed with '_').
Removes a bitrotted GN unit test around component handing (it wasn't
testing anything useful any more since we removed the built-in
component function).
Review URL: https://codereview.chromium.org/1275583002
Cr-Original-Commit-Position: refs/heads/master@{#342204}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a08763777c45ca4e7a00a846266bbfed31ef673
When set to 1, this will NOT activate the field trial test specified
in the fieldtrial_testing_config_*.json. This gives Chromium
packagers the flexibility to disable field trial testing config for
their package as we have on our Google Chrome build.
BUG=515686
Review URL: https://codereview.chromium.org/1266113002
Cr-Original-Commit-Position: refs/heads/master@{#341845}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d2e44fe0e7994b083504c249b654e20d76228e0
Chromecast builds need to explicitly set |enable_browser_cdms| to true
and |enable_pepper_cdms| to false. Rather than introduce a global
is_chromecast variable, as we have in GYP, allow |enable_pepper_cdms| to
be set in args.gn.
BUG= b/17615224
Review URL: https://codereview.chromium.org/1266693005
Cr-Original-Commit-Position: refs/heads/master@{#341776}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9bacb78d7d0a453ff5d23df7fd30b7b75cded17d
Renamed USE_PLATFORM_SPELLCHECKER preprocessor flag to
USE_BROWSER_SPELLCHECKER to more accurately reflect the fact
that the browser side contains other services such as red
underlines that will be leveraged by any spellchecker.
BUG=415302
Review URL: https://codereview.chromium.org/1263423006
Cr-Original-Commit-Position: refs/heads/master@{#341771}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 990eb97f091d9719b2061de67b7e585f6a967d8b
Uses forward_variables_from for some obvious cases not including the Android build, and use the template() function in the component() definition.
Remove uses of component_mode since I want to delete that.
Review URL: https://codereview.chromium.org/1265263002
Cr-Original-Commit-Position: refs/heads/master@{#341767}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a09029884e02a3c027a485877886cf75969f6b3d
Convert from "disable"=true to "enable"=false for clarity.
Add hints to GN build for debugging.
Removed the !is_android check in the iterator debugging. This is redundant with the is_linux check (is_linux used to be set for Android which is why this code got written).
Review URL: https://codereview.chromium.org/1256783007
Cr-Original-Commit-Position: refs/heads/master@{#341608}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e134d6c0f0f778251e38615bda7b241f077c5455
The Finch test 'CDL1VsCLD2' is a test to make sure that CLD2 is not
worse than CLD1 in terms of performance or accuracy. This test is no
longer executed on any platforms. Let's remove this for code health.
CLD version '0' is used to represent to use the Finch trial, and this
CL removes the cases of version 0 from gn, gypi and C++ files.
BUG=515358
Review URL: https://codereview.chromium.org/1259883007
Cr-Original-Commit-Position: refs/heads/master@{#341496}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92a5d22913c2ac3082d57d4eefa9911961588b41
Reason for revert:
I believe this is causing a lot of issues with layout, no idea why though.
https://code.google.com/p/chromium/issues/detail?id=515836
Original issue's description:
> Reland #1: Switch the default build configuration to use the 10.10 SDK.
>
> All known problems have been fixed since the first attempt to land this CL.
>
> Original issue's description:
> > mac: Switch the default build configuration to use the 10.10 SDK.
> >
> > This change is intended to be temporary. The goal is to release a Canary
> > compiled against the 10.10 SDK, and then to revert this CL.
> >
> > BUG=463170
> >
> > Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> > Cr-Commit-Position: refs/heads/master@{#340992}
>
> TBR=thakis@chromium.org,amineer@chromium.org
> BUG=463170
>
> Committed: https://crrev.com/345c0cf47947f209e628941b38d76dca90aee49d
> Cr-Commit-Position: refs/heads/master@{#341261}
TBR=amineer@chromium.org,thakis@chromium.org,erikchen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463170
Review URL: https://codereview.chromium.org/1266603007
Cr-Original-Commit-Position: refs/heads/master@{#341306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2f573334aa30d92dc04dd35fab41ed4658b87b36
All known problems have been fixed since the first attempt to land this CL.
Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}
TBR=thakis@chromium.org,amineer@chromium.org
BUG=463170
Review URL: https://codereview.chromium.org/1257643005
Cr-Original-Commit-Position: refs/heads/master@{#341261}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 345c0cf47947f209e628941b38d76dca90aee49d
Reason for revert:
Causes gclient runhooks to fail on bots that don't have the 10.10 SDK (even though they don't need to compile)
Original issue's description:
> mac: Switch the default build configuration to use the 10.10 SDK.
>
> This change is intended to be temporary. The goal is to release a Canary
> compiled against the 10.10 SDK, and then to revert this CL.
>
> BUG=463170
>
> Committed: https://crrev.com/42ba22e0b8e87f758804537f64db23ff6438e451
> Cr-Commit-Position: refs/heads/master@{#340992}
TBR=thakis@chromium.org,amineer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=463170
Review URL: https://codereview.chromium.org/1254123003
Cr-Original-Commit-Position: refs/heads/master@{#341003}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 53e1ddcd0f7bd0934157e149903feb1893e9aac7
This change is intended to be temporary. The goal is to release a Canary
compiled against the 10.10 SDK, and then to revert this CL.
BUG=463170
Review URL: https://codereview.chromium.org/1246743003
Cr-Original-Commit-Position: refs/heads/master@{#340992}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 42ba22e0b8e87f758804537f64db23ff6438e451
Now supporting various flavors of WinRT in the target_os argument.
Setting compiler and linker flags so cc files are compiled
to support C++/CX syntax.
This is part of a larger effort to port WebRTC to WinRT.
Review URL: https://codereview.chromium.org/1150183009
Cr-Original-Commit-Position: refs/heads/master@{#340893}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 56f81e32556d513af513eac0710f2e85877ffa3b
This fixes the incremental build error by disabling the warning (see the code for a detailed description).
It adds conditions for goma and official builds which match GYP.
Review URL: https://codereview.chromium.org/1261953002
Cr-Original-Commit-Position: refs/heads/master@{#340769}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 48d359b13c0f60e444280afc03df8dfeb8ebe41d
Reason for revert:
I believe the GN build failure was caused by a different patch of brettw's.
Original issue's description:
> Revert of Enable C4018 globally for the GN build, and disable per-target. (patchset #4 id:60001 of https://codereview.chromium.org/1246103007/)
>
> Reason for revert:
> Speculative revert based on windows gn bots failing with
>
> http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/10113
>
> FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/base/base/precompile.c.obj.rsp /c ../../build/precompile.cc /Foobj/base/base/precompile.c.obj /Fdobj/base/base_c.pdb
> e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : error C2220: warning treated as error - no 'object' file generated
> e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : warning C4206: nonstandard extension used : translation unit is empty
> ninja: build stopped: subcommand failed.
>
> In theory this warning shouldn't have affected other warnings, but there are no other clear candidates.
>
> Original issue's description:
> > Enable C4018 globally for the GN build, and disable per-target.
> >
> > This matches what the GYP build does.
> >
> > BUG=398202
> > TEST=none
> >
> > Committed: https://crrev.com/d408e1965f8e03629738039289ab7779c42a318c
> > Cr-Commit-Position: refs/heads/master@{#340590}
>
> TBR=brettw@chromium.org,erg@chromium.org,pkasting@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=398202
>
> Committed: https://crrev.com/4bf2ca554347fc20e1649e5ff4cf700d9fbd713a
> Cr-Commit-Position: refs/heads/master@{#340623}
TBR=brettw@chromium.org,erg@chromium.org,ccameron@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=398202
Review URL: https://codereview.chromium.org/1259253006
Cr-Original-Commit-Position: refs/heads/master@{#340745}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0d79de12da6b9fcb6f2b6337064637bd1ad05ba5
VC++ 2015 has a /DEBUG:FASTLINK option that can significantly
improve link performance on developer machines. Compared to normal
VS 2015 links it reduces elapsed time by 33-55% and reduces peak
working set by 65-90%. PDB sizes are reduced by 65-72%.
/DEBUG:FASTLINK works by having PDB files reference symbols in
.obj and .lib files instead of copying the debug information. This
means that PDBs only work on the machine they were created on, and
only as long as the .obj and .lib files exist, but this constraint
matches local-developer-builds very nicely.
/DEBUG:FASTLINK has an (undocumented) restriction that it is disabled
if /PROFILE is selected.
For GYP builds this feature is enabled with GYP_DEFINES=win_fastlink=1
For gn builds this feature is enabled with is_win_fastlink = true in
args.gn.
This switch is not supported on VC++ 2013
This connect bug requests a tool to de-fastlink a PDB so that it can
be shared/deployed for debugging on other machines:
https://connect.microsoft.com/VisualStudio/feedback/details/1598471
BUG=440500
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1254723012
Cr-Original-Commit-Position: refs/heads/master@{#340733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 24a5806209d95faea058684b03a2d5f42c18ecae
Adds the precompiled header config to most large-ish targets in the build, but keeps the config a no-op (so no precompiled headers will be used but this can bw switched with a one-line change).
Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them.
I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower).
For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static.
This is a reland of https://codereview.chromium.org/1250273002/ with the config disabled for easier re-landing and iterating
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=dpranke
Review URL: https://codereview.chromium.org/1258273004
Cr-Original-Commit-Position: refs/heads/master@{#340728}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc8b2a244ab981b264a86f5f2a64464089e05e32
Reason for revert:
Speculative revert based on windows gn bots failing with
http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/10113
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/base/base/precompile.c.obj.rsp /c ../../build/precompile.cc /Foobj/base/base/precompile.c.obj /Fdobj/base/base_c.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn__dbg_\build\src\build\precompile.cc(8) : warning C4206: nonstandard extension used : translation unit is empty
ninja: build stopped: subcommand failed.
In theory this warning shouldn't have affected other warnings, but there are no other clear candidates.
Original issue's description:
> Enable C4018 globally for the GN build, and disable per-target.
>
> This matches what the GYP build does.
>
> BUG=398202
> TEST=none
>
> Committed: https://crrev.com/d408e1965f8e03629738039289ab7779c42a318c
> Cr-Commit-Position: refs/heads/master@{#340590}
TBR=brettw@chromium.org,erg@chromium.org,pkasting@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=398202
Review URL: https://codereview.chromium.org/1257583007
Cr-Original-Commit-Position: refs/heads/master@{#340623}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4bf2ca554347fc20e1649e5ff4cf700d9fbd713a
This reverts commit 8f3218985dde74063ccc362da47803be163f3165.
It looks like this may have broken incremental builds on Win.
TBR=brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1256223003
Cr-Original-Commit-Position: refs/heads/master@{#340620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ba63a918a644773af77dc657792d6440e8afbc1
Turns on precompiled header support in the GN build on Windows, and adds the precompiled header config to most large-ish targets in the build.
Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them.
I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower).
For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1250273002
Cr-Original-Commit-Position: refs/heads/master@{#340535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8f3218985dde74063ccc362da47803be163f3165
We already disable warning C4996 (function was declared deprecated) but
with the Windows 10 SDK we also have to disable the very similar warning
C4995 (function was marked as #pragma deprecated). It's not clear why
there are two mechanisms with two different warnings, but there you are.
These are the warnings I saw:
printing\backend\win_helper.h(152): warning C4995: 'StartXpsPrintJob': name was marked as #pragma deprecated
printing\backend\win_helper.h(160): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated
printing\backend\win_helper.cc(69): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated
printing\backend\win_helper.cc(299): warning C4995: 'StartXpsPrintJob': name was marked as #pragma deprecated
printing\backend\win_helper.cc(307): warning C4995: 'IXpsPrintJob': name was marked as #pragma deprecated
R=thakis@chromium.org
BUG=491424
Review URL: https://codereview.chromium.org/1249113004
Cr-Original-Commit-Position: refs/heads/master@{#340157}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3e5c69bd1c1e8230dc4e481d91d293bb4cee19b9
Hooks up the allocator shim on Windows. The GN build uses the Windows heap like GYP does.
This makes tcmalloc actually compile on Windows if you manually request it, although it doesn't actually seem to work correctly. I added an assert noting this if you try to set the flag on Windows. Note that this is never run by default on GYP and we may never want it.
This sets the ALLOCATOR_SHIM for the one media file that uses it.
Review URL: https://codereview.chromium.org/1246083005
Cr-Original-Commit-Position: refs/heads/master@{#339798}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5444db5ddf7eb68a5241e84f8f179c6d2739aaa5
Adds manifest data for content shell. The result matches the GYP build.
Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome.
BUG=510612
TBR=dpranke@chromium.org
Reland of https://codereview.chromium.org/1240893004/ with no cloud print or remoting changes
Review URL: https://codereview.chromium.org/1238293005
Cr-Original-Commit-Position: refs/heads/master@{#339709}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e2220c02f2bbd3116b7b718aad627f37ad59b92
Adds manifest data for content shell. The result matches the GYP build.
Attaches a default manifest to all tests in the GN build. The GYP build's tests have manifests that specify elevation only. In GN it also specifies Windows and common control compat that matches what we ship with Chrome.
Moved the common control compat files that were duplicated to a shared place in build/win, update cloud_print and remoting which had their own copies to use this shared one.
BUG=510612
Review URL: https://codereview.chromium.org/1240893004
Cr-Original-Commit-Position: refs/heads/master@{#339663}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c34cad367a0557d8b029fb81d04cc37b5979fee0
This CL adds Accessibility support to Chromium browser for linux platform. It
successfully exposes an AX Tree for content. You can test this with chrome://accessibility.
This is just the initial CL to get the accessibility support on Linux. Other interfaces need
to be implemented to make it useful for accessibility tools.
ATK_COMPONENT & ATK_VALUE Interfaces has been implemented in this CL.
Content:
<html>
<body>
<input type="checkbox">
</body>
</html>
AX Tree:
[document web] enabled focusable focused id=1
++[section] enabled id=4
++++[check box] enabled focusable id=5
BUG=463671
Review URL: https://codereview.chromium.org/1128183010
Cr-Original-Commit-Position: refs/heads/master@{#339435}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 792fba03a8605accd9016cc0a6fb4a7ce52dedc6
A GN change for precompiled headers meant that cflags_c aren't passed automaticall to the Objective C compiler, and cflags_cc aren't passed to the Objective C++ compiler.
Copies the c/cc flags over to the objc/objcc variables in the compiler setup.
TBR=dpranke@chromium.org
BUG=511323
Review URL: https://codereview.chromium.org/1233683003
Cr-Original-Commit-Position: refs/heads/master@{#339348}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 839f4802a610edc83e5c6bd9c178208b3715324c
The header is now meant to be an interface for any
system that would like to use its own spellchecker
instead of the hunspell library.
Split the implementation into two source files, one for mac and one for android.
The android implementation is just method stubs for now.
Updated related build files and #include references.
Part 1 of a 3 part breakdown of https://codereview.chromium.org/1204293003.
The breakdown will also include some changes to the original CL.
BUG=415302
Review URL: https://codereview.chromium.org/1230933002
Cr-Original-Commit-Position: refs/heads/master@{#339195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 684453c5ecb33796629becb77b64591d939e4458
Reason for revert:
Cast tests failing on ToT after this.
Original issue's description:
> Make instrumentation test dependency on a support APK explicit
>
> Add an argument (support_apk_name) to the GYP and GN
> instrumentation_test_apk targets to provide a support APK. The
> argument is optional, but when present, the build will fail if the
> APK is not installable
>
> BUG=501797
>
> Committed: https://crrev.com/0ac9fec88bf9a042410192b304ae1bc252df8aa7
> Cr-Commit-Position: refs/heads/master@{#339046}
TBR=jbudorick@chromium.org,cjhopman@chromium.org,dgn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501797
Review URL: https://codereview.chromium.org/1237983004
Cr-Original-Commit-Position: refs/heads/master@{#339170}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 72c598c090ae4f8df7c55bae7acc8dfea46ba0c6
Add an argument (support_apk_name) to the GYP and GN
instrumentation_test_apk targets to provide a support APK. The
argument is optional, but when present, the build will fail if the
APK is not installable
BUG=501797
Review URL: https://codereview.chromium.org/1208483004
Cr-Original-Commit-Position: refs/heads/master@{#339046}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ac9fec88bf9a042410192b304ae1bc252df8aa7
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Original-Commit-Position: refs/heads/master@{#339002}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d967d55cf7a0f78e6ace9ec681d2d082e631810b
C4589 fires when a derived class illegally calls the constructor for
its virtual base class. Unfortunately it fires inappropriately.
If Base has a pure-virtual function and Derived is dllexported and
derives virtually from the base class then the compiler-generated
copy constructor will illegally initialize the virtual base class.
The warning is:
warning C4589 : Constructor of abstract class 'Derived' ignores
initializer for virtual base class 'Base'
note : This diagnostic occurred in the compiler generated function
'Derived::Derived(const Derived &)'
While this warning can be potentially useful (it found bad code in
crbug.com/510497) it mostly fires inappropriately. Here is repro code:
class __declspec(dllexport) Base {
virtual void SomeFunction() = 0;
};
class __declspec(dllexport) Derived : virtual public Base {
// Deleting the assignment operator avoids the warning
//Derived(const Derived&) = delete;
// Overriding SomeFunction avoids the warning
//void SomeFunction() override {};
};
The bug has been reported.
R=thakis@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1234253003
Cr-Original-Commit-Position: refs/heads/master@{#338964}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d5b9a8565675b8969dd34b6aa765adcd443b5527
This warns on code of the form:
#endif RANDOM_TEXT
MIDL generated code tends to emit code in this pattern, so suppress
this warning when compiling MIDL generated files.
BUG=504663
R=thakis@chromium.org
TBR=dtseng, robertshield, weitaosu
Review URL: https://codereview.chromium.org/1233453008
Cr-Original-Commit-Position: refs/heads/master@{#338435}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be8d6f52672bf61324b2ac988ef7776ade9d1628
Reason for revert:
Broke Clang build on Windows according to http://crbug.com/505319#c30.
Those warnings should be fixed before relanding.
Original issue's description:
> Clang on Windows: Remove -Wno-unused-variable.
>
> Unused variables are now errors. However, since lots of third-party code
> has unused variables, added a blanket suppression to all third-party
> code.
>
> BUG=505319
>
> Committed: https://crrev.com/3371ccbd9d83e1031c5891520e88acbc9c1859a0
> Cr-Commit-Position: refs/heads/master@{#338242}
TBR=garykac@chromium.org,thakis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=505319
Review URL: https://codereview.chromium.org/1228093005
Cr-Original-Commit-Position: refs/heads/master@{#338253}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff68a3ba6f2dc9b226047b3355c135f73352570e
Unused variables are now errors. However, since lots of third-party code
has unused variables, added a blanket suppression to all third-party
code.
BUG=505319
Review URL: https://codereview.chromium.org/1226573002
Cr-Original-Commit-Position: refs/heads/master@{#338242}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3371ccbd9d83e1031c5891520e88acbc9c1859a0
(OS=="linux" or chromeos==1) can be folded into just a
simple *OS=="linux") test because chromeos builds assume
that OS is always set to linux.
Review URL: https://codereview.chromium.org/1012483004
Cr-Original-Commit-Position: refs/heads/master@{#338239}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 810079fac67ffb02451cdf3c776011aa373b2fd4
It defines YY_USE_CONST when building mesa to fix this warning, disables
-Wincompatible-pointer-types for the other third-party libraries that
trigger it and fixes some underspecified dependencies in
third_party/libwebp.
BUG=504696
Review URL: https://codereview.chromium.org/1226583002
Cr-Original-Commit-Position: refs/heads/master@{#338227}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c98d446e81bcc18cf4241325c8719ccdc0b7abf3
This will hopefully fix symbolization on the asan/android bots.
This also brings in somewhat major changes in how the asan runtime is
built on OS X; hopefully it won't break the mac asan bots.
libcxx(abi) grew CMake files, which is great – except it adds the libcxx(abi)
tests to `check-all`, and they don't pass in bootstrap mode on OS X.
So delete libcxx(abi) before starting the main build. (It's only needed on OS X
for bundling libcxx with the compiler so it can run on 10.6, and that's all done
after the first build.)
This also adds support for __nullable and Objective-C generics.
BUG=502974,499448
TBR=hans
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1229653005
Cr-Original-Commit-Position: refs/heads/master@{#338220}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: dd2dc4c908b9c05b33a1aa54761603f9f5bf96f5
Add new class RLZTrackerDelegate that abstract access to embedder
specific singletons and informations and provide an implementation for
Chrome based on the previous implementation.
Split rlz_unittest.cc in tests of the RLZTracker and Chrome
implementation of the RLZTrackerDelegate interface and move the
RLZTracker tests into the component.
Add a new gyp/gn variable "enable_rlz_support". This variable is true on
the platforms that support RLZ (currently Windows, Mac, iOS and
ChromeOS). Use it to build library and unit tests even when the RLZ
support is not enabled in the Chrome binary (this is still controlled by
"enable_rlz" and depends on the branding).
Enable the tests on iOS and convert rlz_tracker_ios.mm to a C++ file.
TEST=Run unit_tests and components_unittests on a platform that supports
RLZ (Windows, Mac, iOS or ChromeOS) and check that they pass. Then build
Chrome with "enable_rlz" and manually checks that RLZ are sent with
searches as expected.
BUG=504841,508148
Review URL: https://codereview.chromium.org/1212163011
Cr-Original-Commit-Position: refs/heads/master@{#338040}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 311a46585ee5b77486ef42d947bc7cc7566558b1
Newer version of GLib define *get_instance_private symbols in
the G_DEFINE_TYPE macros. These symbols might be unused in cases
where a GObject class doesn't access its instances private data,
triggering -Wunused-function warnings.
BUG=504375
TEST=compile with gn on linux with GLib >= 2.37
Review URL: https://codereview.chromium.org/1216153005
Cr-Original-Commit-Position: refs/heads/master@{#338001}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 991e92d77c0b9f46c6a5d3f6facd12861c9e1828
Nico Weber
jbudorick
agrieve
mostynb
dgn
mmaliszkiewicz
andybons
sebmarchand
dpranke
erikchen
bajones
sdefresne
brettw
petermayo
davidben
danduong
ochang
slan
dylanking
sherouk
hajimehoshi
dmurph
fredlebel
pkasting
brucedawson
ccameron
tfarina
avayvod
shreeram.k
abarth
rnk
yusufo
hongchan
sammc
Daniel Cheng
mgiuca
l.gombos
benwells
lionel.g.landwerlin