Reason for revert:
This breaks compile step on official.desktop.continuous for all OS trunk.
crbug.com/633775
Original issue's description:
> [Sync] Merge sync_unit_tests into components_unit_tests, take 2.
>
> This change was previously landed and reverted because some bot configs
> in the build repo needed to be updated first.
>
> BUG=626114
> TBR=dpranke,jam,slan
>
> Committed: https://crrev.com/9f7c262325b965be2a51475650d542c9791eee9d
> Cr-Commit-Position: refs/heads/master@{#409060}
>
> patch from issue 2186733002 at patchset 60001 (http://crrev.com/2186733002#ps60001)
>
> Committed: https://crrev.com/9131f18a585a66ad327af8089d3fb80c10388948
> Cr-Commit-Position: refs/heads/master@{#409356}
TBR=dpranke@chromium.org,jam@chromium.org,slan@chromium.org,maxbogue@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=626114,633775
Review-Url: https://codereview.chromium.org/2201273002
Cr-Original-Commit-Position: refs/heads/master@{#409386}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 523ee7dd9be18c54a45ca4ff499d57e1cac4495c
There are a bunch of subfolder reorganizations going along with this:
- engine/ -> engine_impl/
- sessions/ -> sessions_impl/
- util/ -> base/
- internal_api/public/base/ -> base/
- internal_api/public/sessions/ -> sessions/
- internal_api/public/engine/ -> engine/
- internal_api/public/events/ -> engine/events/
- internal_api/public/util/ -> base/
- internal_api/public/ -> core/
- internal_api/ -> core_impl/
This change was generated using the following script:
http://pastebin.com/vVAkRCkh
Because this patch is so large, some review was done in split CLs:
Manual changes: http://crrev.com/2155763002
Sync internal changes: http://crrev.com/2156693002
Sync external changes: http://crrev.com/2148293004
This is a minimal change to support file movement; it doesn't do
anything like merging sync_unit_tests into component_unit_tests,
which will be done in a followup.
The gyp files are not sorted because they're all going to be removed
very soon anyways.
BUG=626114
R=jam@chromium.org, zea@chromium.org
TBR=jam
Review URL: https://codereview.chromium.org/2130453004 .
Cr-Original-Commit-Position: refs/heads/master@{#408497}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fef332d69faf129b64689e30304061322ca9bcad
Reason for revert:
Investigate effect on Win7 startup.cold.blank_page metrics.
BUG=501799,625516
Original issue's description:
> [gin] Unify snapshot loading on Windows and other platforms.
>
> Removes extra v8 snapshot and natives validation on Windows. All platforms
> have the same validation henceforth.
>
> BUG=501799
>
> Committed: https://crrev.com/10b5a96b363a6ff23176d27a2e7fb1bba300f089
> Cr-Commit-Position: refs/heads/master@{#403430}
TBR=jochen@chromium.org,ben@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=501799
Review-Url: https://codereview.chromium.org/2141043002
Cr-Original-Commit-Position: refs/heads/master@{#405111}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a653192101213ec193c87e63ee119ab0dda3dd4
Removes extra v8 snapshot and natives validation on Windows. All platforms
have the same validation henceforth.
BUG=501799
Review-Url: https://codereview.chromium.org/2103903002
Cr-Original-Commit-Position: refs/heads/master@{#403430}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10b5a96b363a6ff23176d27a2e7fb1bba300f089
This is required for the ongoing work to add crashpad integration in
chrome_elf and remove the crashpad integration from chrome.exe
As chrome_elf loads very early in the process, we cannot depend on
functionality from base which pulls in additional dependencies from
user32, etc.
I also added a target called install_static_unittests which contains tests
for the new functionality in install_static. The MatchPattern test has
been moved from chrome_elf to this executable.
The utf8_to_utf16 and utf16_to_utf8 functions in install_static are now public functions as they are
needed by crashpad.
The other changes in this patch are for getting the install_static
executable to run on the windows bots.
BUG=604923
TBR=dpranke
Review-Url: https://codereview.chromium.org/2017853002
Cr-Original-Commit-Position: refs/heads/master@{#396612}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f2e54a999d4bd88062e27c61f995bac80cc025b1
Created by flipping enable_app_list to '0' everywhere except ChromeOS,
ensuring it passes CQ, then flipping it back.
Mostly just splitting app_list source files out to their own gyp
variables.
This will allow us to test new code needed for previously supported
platforms. The code will be required as soon as enable_app_list is
flipped to 0. E.g. calls to --show-app-list will just show chrome://apps
instead.
Builds upon initial work in https://codereview.chromium.org/1747773002/
BUG=600915
COLLABORATOR=wierichs@google.com
Review-Url: https://codereview.chromium.org/1861233003
Cr-Original-Commit-Position: refs/heads/master@{#393474}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d13e0cdf6fc5fddb580968adb2a5b9c5379a4404
Some were obsolete, some I implemented in this patch. Some I left as-is if they applied to Mac or iOS.
A few items are TODOs for when transition is complete. I changed these to "TODO(GYP_GONE)"
This patch only addresses ~25% of the build.
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review-Url: https://codereview.chromium.org/1953523002
Cr-Original-Commit-Position: refs/heads/master@{#391943}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9427f9e3edb7be9bd540bb35b3d3156c08c3df6
This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).
next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)
This CL is based on https://codereview.chromium.org/1902233003 which
was reverted because it broke Win Builder. To avoid this problem, this
CL adds next_version_mini_installer.exe to the list of files excluded
from the checkbins step.
BUG=605177
Review-Url: https://codereview.chromium.org/1928983002
Cr-Original-Commit-Position: refs/heads/master@{#390503}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb048bff9ec1ecdb632386878c33168a77b75895
Reason for revert:
Broke the Win builder: https://build.chromium.org/p/chromium/builders/Win/builds/42817
Failed step checkbins:
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /DYNAMICBASE... FAIL
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /NXCOMPAT... PASS
Checking C:\b\build\slave\Win\build\src\out\Release\next_version_mini_installer.exe for /SAFESEH... PASS
Original issue's description:
> Add next_version_mini_installer target.
>
> This target generates next_version_mini_installer.exe, which has a
> higher version number than mini_installer.exe. This new installer
> will be used to test various update scenarios (using test_installer.py).
>
> next_version_mini_installer needs to be added to the list of
> dependencies of MiniInstallerTest before tests start using it.
> (build/scripts/slave/recipe_modules/chromium_tests/steps.py)
>
> BUG=605177
TBR=grt@chromium.org,dpranke@chromium.org,zmin@chromium.org,eclipse0072015@gmail.com,fdoray@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=605177
Review-Url: https://codereview.chromium.org/1926893002
Cr-Original-Commit-Position: refs/heads/master@{#390191}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8abd1270fc4140053ab7d77bd3f88eec7e9dcfe9
This target generates next_version_mini_installer.exe, which has a
higher version number than mini_installer.exe. This new installer
will be used to test various update scenarios (using test_installer.py).
next_version_mini_installer needs to be added to the list of
dependencies of MiniInstallerTest before tests start using it.
(build/scripts/slave/recipe_modules/chromium_tests/steps.py)
BUG=605177
Review-Url: https://codereview.chromium.org/1902233003
Cr-Original-Commit-Position: refs/heads/master@{#390158}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f60b933129fc5da66040af05cd22701dfcea8a28
Reason for revert:
Caused a compile error on Win:
https://build.chromium.org/p/chromium/builders/Win/builds/42776
ninja: error: '../../chrome/tools/crash_service/main.cc', needed by 'obj/chrome/tools/crash_service/crash_service.main.obj', missing and no known rule to make it
Original issue's description:
> Remove CAPS
>
> One less crash_service, which is especially confusing because there's two
> crash_service targets and also a content_shell_crash_service.exe.
>
> TBR=sky
>
> Committed: https://crrev.com/7e3c4177dd1de27b69109d45ce7f87f0524bc70f
> Cr-Commit-Position: refs/heads/master@{#389907}
TBR=dpranke@chromium.org,sky@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1921973006
Cr-Original-Commit-Position: refs/heads/master@{#389916}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6084075b5b792b3cf779a814b3fc089a07c331bd
One less crash_service, which is especially confusing because there's two
crash_service targets and also a content_shell_crash_service.exe.
TBR=sky
Review URL: https://codereview.chromium.org/1858883004
Cr-Original-Commit-Position: refs/heads/master@{#389907}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e3c4177dd1de27b69109d45ce7f87f0524bc70f
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388829}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 540b8c11b0418e42e79fa27b84ac4f3c0f7770fa
Reason for revert:
This added the new test to some FYI bots (but nowhere else?) and claimed that the binary can run on swarming but it doesn't add a _run target or an isolate file to actually run it on swarming. As a consequence, the FYI bots this added the test to that still use gyp now all fail their "isolate tests" step. Example: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/4976
Original issue's description:
> Introduce components/display_compositor
>
> We would like to share BufferQueue, GLHelper and later other parts
> of content/browser/compositor in Mus. This CL introduces a new
> display_compositor component and moves BufferQueue, GLHelper and
> friends to components/display_compositor.
>
> BUG=601867
> TBR=ben@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
> NOTRY=true
> NOTREECHECKS=true
TBR=ben@chromium.org,piman@chromium.org,sky@chromium.org,xhwang@chromium.org,tkent@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601867
Review URL: https://codereview.chromium.org/1904773004
Cr-Original-Commit-Position: refs/heads/master@{#388760}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b844a929a8e624c6391d5efab8aea49bb883874
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388662}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec03489356fa45add604aaca28f277a0c9f83dee
Reason for revert:
Broke Windows x64 build.
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): error C2220: warning treated as error - no 'object' file generated
c:\b\build\slave\win_x64_builder__dbg_\build\src\components\display_compositor\buffer_queue_unittest.cc(142): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data
https://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20%28dbg%29/builds/20984/steps/compile/logs/stdio
Original issue's description:
> Introduce components/display_compositor
>
> We would like to share BufferQueue, GLHelper and later other parts
> of content/browser/compositor in Mus. This CL introduces a new
> display_compositor component and moves BufferQueue, GLHelper and
> friends to components/display_compositor.
>
> BUG=601867
> TBR=ben@chromium.org
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=piman@chromium.org,sky@chromium.org,xhwang@chromium.org,ben@chromium.org,fsamuel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=601867
Review URL: https://codereview.chromium.org/1905863002
Cr-Original-Commit-Position: refs/heads/master@{#388661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 442ab50b0b4a5ca8d8b634d6b79dea960918f1f0
We would like to share BufferQueue, GLHelper and later other parts
of content/browser/compositor in Mus. This CL introduces a new
display_compositor component and moves BufferQueue, GLHelper and
friends to components/display_compositor.
BUG=601867
TBR=ben@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1902463002
Cr-Original-Commit-Position: refs/heads/master@{#388641}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ea767b706b88fbeb77655c2193d593dfef54660a
Reason for revert:
Something is still using the net_docs target, which was removed; builds are failing on the bots (but didn't fail on any try jobs above--see green).
Original issue's description:
> Include class relationship diagrams in network stack documentation.
>
> This CL includes class relationship diagrams for most of the
> classes mentioned in life_of_a_url_request.md and a sketch of the
> object relationships inside socket pools. It also removes the net_docs
> target (which wasn't really being used) and adds information for debugging
> markdown changes and updating SVG files from dot source.
>
> BUG=None
> R=eroman@chromium.org
> R=mmenke@chromium.org
>
> Committed: https://crrev.com/fb2fd16bec430431971d14658ef3800b23f0ab3f
> Cr-Commit-Position: refs/heads/master@{#385934}
TBR=eroman@chromium.org,mmenke@chromium.org,scottmg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1875583002
Cr-Original-Commit-Position: refs/heads/master@{#385941}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88c6adb3c6e51ab5d5b9ab8d75d3c373c5f58518
This CL includes class relationship diagrams for most of the
classes mentioned in life_of_a_url_request.md and a sketch of the
object relationships inside socket pools. It also removes the net_docs
target (which wasn't really being used) and adds information for debugging
markdown changes and updating SVG files from dot source.
BUG=None
R=eroman@chromium.orgR=mmenke@chromium.org
Review URL: https://codereview.chromium.org/1859793002
Cr-Original-Commit-Position: refs/heads/master@{#385934}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fb2fd16bec430431971d14658ef3800b23f0ab3f
That change added display_unittests on swarming to several testing/buildbot
json files, but didn't update gn_migration.gypi to make sure
display_unittests_run runs on all platforms (so when the test was prepared
for swarming, the corresponding .isolated file might not yet have been
created).
Should fix e.g. the red isolate_tests step on
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/5203
BUG=597105
TBR=robliao
Review URL: https://codereview.chromium.org/1836353007
Cr-Original-Commit-Position: refs/heads/master@{#383963}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f9318e2cf3a367967014a354e0d280bdf66247c
Thought I could clean up the android_webview/tools dir a little bit.
It basically has some random tools as well as the WebViewShell apks
so I moved all the apks into a shared folder.
- Moved all WebViewShell Apks into tools/system_webview_shell
- Moved WebViewShell/test/ to system_webview_shell/test/data/ to better
match the naming of test data elsewhere
- Removed DEPRECATED_java_in_dir from tools/BUILD.gn.
- Updated gn_migration.gypi since GN targets exist for the WebView
Shell apks.
BUG=
Review URL: https://codereview.chromium.org/1785283005
Cr-Original-Commit-Position: refs/heads/master@{#382390}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49971fcb594aaa7181e001b3111cd3bf6410fb67
The purpose of this app is to be launched and push other apps to
the background during Android telemetry tests. It is just a
super simple Android app.
BUG=586148
Review URL: https://codereview.chromium.org/1744423002
Cr-Original-Commit-Position: refs/heads/master@{#380680}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5e98301e0ee9a7a7388df01a1dfa366a95840ed
grt
maxbogue
kozyatinskiy
mathp
bnc
oth
davidben
amistry
ananta
Hans Wennborg
tapted
brettw
markdittmer
Nico Weber
fdoray
jdonnelly
scottmg
creis
penghuang
machenbach
fsamuel
tkent
svaldez
mfomitchev
ben
pcc
cwallez
rdsmith
enne
tfarina
mikecase
sergeyu
emircan
dewittj
yzshen