0 configs already ran on Swarming
8 used to run locally and were converted:
- chromium.linux.json: Android GN
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.fyi.json: Linux TSan Tests
- chromium.win.json: XP Tests (1)
Ran:
./manage.py --convert ipc_mojo_unittests
BUG=98637
Review URL: https://codereview.chromium.org/1222243003
Cr-Original-Commit-Position: refs/heads/master@{#337431}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 15593557f4f387d91dc7726511a20cb999c81561
Also add gn_unittests_run to build/gn_migration.gypi, which
I forgot in https://codereview.chromium.org/1214533005/
Also reshuffle build/gn_migration.gypi to use consistent conditionals.
0 configs already ran on Swarming
6 used to run locally and were converted:
- chromium.fyi.json: ClangToTMac tester
- chromium.fyi.json: ClangToTMacASan tester
- chromium.mac.json: Mac10.6 Tests
- chromium.mac.json: Mac10.8 Tests
- chromium.mac.json: Mac10.9 Tests
- chromium.mac.json: Mac10.9 Tests (dbg)
Ran:
./manage.py --convert sandbox_mac_unittests
BUG=98637
TBR=cpu
Review URL: https://codereview.chromium.org/1218203002
Cr-Original-Commit-Position: refs/heads/master@{#337057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92a101b6d732b8af7f12f19459e382181586373a
As long as new OOBE is not going to be implemented anymore, webui_generator and
new OOBE placeholder can be removed.
BUG=none
Review URL: https://codereview.chromium.org/1181703008
Cr-Original-Commit-Position: refs/heads/master@{#335356}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 99949d7685baa13912a4cd759e45d712d8707329
In cloud_print/service/service.gyp the targets:
cloud_print_service
cloud_print_service_config
cloud_print_service_setup
are only useful on Windows but are defined on all platforms.
Attempting to build any of these targets on other platforms will
result in a build error as the 'win/*' sources are removed by glob
meaning that cloud_print_resources.gyp:cloud_print_version_resources
has no sources, resulting in cloud_print_service_exe_version.rc
not being created, causing this source not to be found.
This also explicitly calls out the dependency of these three targets
on the cloud_print_version_resources target to create the
cloud_print_service_exe_version.rc file.
TBR=dpranke@chromium.org
The gn_migration.gypi change just updates where the targets are.
Review URL: https://codereview.chromium.org/1153263002
Cr-Original-Commit-Position: refs/heads/master@{#335254}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f5a2156812c318825b6438258d9f882fc63ecd16
Some of these files were forked in the initial Mandoline landing. After we forked the application code, we now had two implementations of some of these files. We only need one.
Review URL: https://codereview.chromium.org/1142323003
Cr-Original-Commit-Position: refs/heads/master@{#330690}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0080299638e998a7cb9cdd3f5aadcf6b6ffe707b
This CL adds a unit testing harness for ui/gl tests.
In order to ensure that the bots do not break once they start running
these unit tests, gl_unittests currently it does not run any tests.
Once the bots successfully run gl_unittests, we can safely add tests
using the trybots to make sure the added tests actually work.
R=danakj@chromium.org, sievers@chromium.org
BUG=482067
Review URL: https://codereview.chromium.org/1121353002
Cr-Original-Commit-Position: refs/heads/master@{#328407}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 781489a282f6f7e19d7d449500cd2e91b2bc46a5
Changes from the first coommit.
- Define right dependencies to xdisplaycheck
- Fix build rules for midi_unittests_apk to run on Android
- Rebase error fixes (build rule deopendency adjustments)
Original commit is:
https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331
Original description follows:
Split MIDI related stuffs from media as a component in build files.
Also, MIDI related unit tests are split into midi_unittests.
BUG=475869
TEST=git cl try
TEST=ninja midi_unittests_apk && ./build/android/test_runner.py gtest midi_unittests
Review URL: https://codereview.chromium.org/1065743003
Cr-Original-Commit-Position: refs/heads/master@{#327712}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6475779990f6ffdfa33d42b0bd97818df5e8d3c
The 'gn_all' target in src/BUILD.gn didn't actually build everything,
which could be confusing. This patch renames the target to 'both_gn_and_gyp'
which should make the intent clearer, and reworks the accompanyhing
targets in both the GN and GYP builds to match.
R=jam@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1104213005
Cr-Original-Commit-Position: refs/heads/master@{#327411}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ddc17490a20df0ed22f96995d4f007c7b437d77f
This reverts commit 45a0dc0b75b52e026eb15526ef441edc5dbe9ba5.
> Intercept base::File Open/Close
>
> When a file descriptor is opened by the base::File, all calls to close(3) from
> the same dynamic library will hit a CHECK unless they are made from a
> whitelist of callsites belonging to base::File.
>
> There is a handy protect_file_posix.gypi introduced to make it easy to enable
> on Chrome-for-Android.
>
> This 'linker magic' is somewhat crazy, so:
> 1. it will be *removed *when crbug.com/424562 is fixed
> 2. it should only be used by a whitelist of binaries/libraries (in the
> opensource part: libchromeshell only)
>
> BUG=424562
>
> Review URL: https://codereview.chromium.org/676873004
>
> Cr-Commit-Position: refs/heads/master@{#304592}
Reason: crashes are not numerous, not much sense to fix, some explanations found
elsewhere.
BUG=424562
Review URL: https://codereview.chromium.org/1101723004
Cr-Original-Commit-Position: refs/heads/master@{#327051}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e1ceecf5545568261956de95fda59270a91d4ef0
Reason for revert:
Very sorry to have to revert this after so much work, but midi_unittests has been consistently broken on Android Tests bot e.g. https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25597
Original issue's description:
> Web MIDI: split build rules for media/midi
>
> Split MIDI related stuffs from media as a component in build files.
> Also, MIDI related unit tests are split into midi_unittests.
>
> BUG=475869
> TEST=git cl try
>
> Committed: https://crrev.com/31624cad1a3b5cf26950b864837ba44b3aa38331
> Cr-Commit-Position: refs/heads/master@{#326247}
TBR=phajdan.jr@chromium.org,dalecurtis@chromium.org,dpranke@chromium.org,boliu@chromium.org,damienv@chromium.org,jam@chromium.org,thestig@chromium.org,lcwu@chromium.org,gunsch@chromium.org,toyoshim@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=475869
Review URL: https://codereview.chromium.org/1085843003
Cr-Original-Commit-Position: refs/heads/master@{#326343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 60006f2c430e17fc8338ff370a1c88cdc61b7f07
Split MIDI related stuffs from media as a component in build files.
Also, MIDI related unit tests are split into midi_unittests.
BUG=475869
TEST=git cl try
Review URL: https://codereview.chromium.org/1065743003
Cr-Original-Commit-Position: refs/heads/master@{#326247}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 31624cad1a3b5cf26950b864837ba44b3aa38331
This is a re-land of crrev.com/1082083005
The previous remoting webapp GN build files were not enabled and at
least 6 months out of date. This cl fixes the problem by bringing
the build rules up to date and enables the webapp build.
It also starts to move all the remoting-specific build rules into
the remoting dir rather than having them in the main build.gn file.
BUG=
Review URL: https://codereview.chromium.org/1096783002
Cr-Original-Commit-Position: refs/heads/master@{#325733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3eddb5b20af3eb8ae4393ad64fccfd4d69127679
A recent change set linux_dump_symbols=1 on the trybots
and was then reverted:
https://codereview.chromium.org/1081103005
The causes the ARM/Linux builder to fail since it was
attempting to run the target (ARM) dump_syms binary on
x86. This change makes dump_syms a host binary so that
it can run at build time.
BUG=476781
TEST=linux_arm_compile trybot
Review URL: https://codereview.chromium.org/1061473003
Cr-Original-Commit-Position: refs/heads/master@{#325661}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe4acac6ff5547d7674e6681c9b556528520fdf7
Reason for revert:
Suspected of breaking the build. For details, see https://code.google.com/p/chromium/issues/detail?id=477869
Original issue's description:
> [Chromoting] Enable remoting webapp main.html GN build.
>
> The previous remoting webapp GN build files were not enabled and at
> least 6 months out of date. This cl fixes the problem by bringing
> the build rules up to date and enables the webapp build.
>
> It also starts to move all the remoting-specific build rules into
> the remoting dir rather than having them in the main build.gn file.
>
> BUG=
>
> Committed: https://crrev.com/62ee8a9cfebbc8bdc037aaa3b37ebfbb45e02472
> Cr-Commit-Position: refs/heads/master@{#325551}
TBR=dpranke@chromium.org,garykac@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/1090023004
Cr-Original-Commit-Position: refs/heads/master@{#325556}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 76302d920e57d6d0c368d827a78817aecea541ba
The previous remoting webapp GN build files were not enabled and at
least 6 months out of date. This cl fixes the problem by bringing
the build rules up to date and enables the webapp build.
It also starts to move all the remoting-specific build rules into
the remoting dir rather than having them in the main build.gn file.
BUG=
Review URL: https://codereview.chromium.org/1082083005
Cr-Original-Commit-Position: refs/heads/master@{#325551}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62ee8a9cfebbc8bdc037aaa3b37ebfbb45e02472
I am reverting all CLs that could have caused this failure:
http://build.chromium.org/p/chromium.linux/builders/
Android%20Tests%20%28dbg%29/builds/27276
I will start re-landing vindicated CLs shortly.
Revert "Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit eb48d65705e44b80d1d7a3b4f21c567802c102bb.
Revert "Supply build properties to run-bisect-perf regression for android bisects."
This reverts commit 9d70bb94984b02c17678ccf482d1a7b7c760a43f.
Revert "[cros New-GAIA] Webview login and new GAIA endpoint enabled by default"
This reverts commit 29061783f8b59f1e78286a87a3bb7d18129f639a.
Revert "Prime the landing pad for the new video rendering pipeline."
This reverts commit 45a3c93f745eabf6c1b1cbdac87ed4350a919e76.
Revert "Implement separate error dialog for cws widget container"
This reverts commit 7ed1f876f6f4d79ac074b25f2066d514603aa18d.
Revert "Create device_bluetooth watchlist; add scheib."
This reverts commit 40514c99cd45d1c8e9caef3245d42533d9810179.
Revert "Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information."
This reverts commit a687f31a786645508622482e9033f497364a43cd.
Revert "Created new URLRequestContext for secure proxy check."
This reverts commit 652eabf1141c00594aa6e9ed81beb980aec89198.
Revert "Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)"
This reverts commit 488846cd562f444831982d82ef0bc9ca0dd79028.
Revert "Sync: Add Android test for downloading a bookmark"
This reverts commit 9c052713563111ac3d6cc64d4b5cfdfa27c202f4.
Revert "ScreenOrientationController to start observing even without an internal display."
This reverts commit 31fed68a524d49f99cebf02dca6ad49019e9900c.
Revert "Fix MB configurations for Mac and Win GN bots."
This reverts commit 31a66f3e705d20a39033a7b7d7f09a60517e6b9d.
Revert "Add tool/perf/measurements path to check for CQ jobs."
This reverts commit 99e1ac1d217174dad7a862f6a0fc44950d503737.
Revert "Implement Notification.data for persistent notifications."
This reverts commit 539f51d6af62097059c34b1c19dfbc4352413ad7.
Revert "Fix playback rate calculations for WallClockTimeSource."
This reverts commit 3ec02d642465872d9ab7d7db600d0480a57b3cab.
Revert "Roll src/third_party/pdfium eddab44:b330016"
This reverts commit 81d51e253cfacd5648cca9f12b605e63971a9ab1.
Revert "cc: Make DisplayItemList::Append replay into an SkPicture"
This reverts commit ec7c07e57bc5f91e3ba0bdeba8b6f534978615b0.
Revert "Clean up URLFetcher unit tests, part 5."
This reverts commit 8eeb3bf4a02be612cacb3cdbb5c223d909939527.
BUG=None
TBR=akuegel
Review URL: https://codereview.chromium.org/1083683003
Cr-Original-Commit-Position: refs/heads/master@{#325411}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 919dce4400651813d5ff6e8a85b944a5987adcb7
This is not a functional change, it only updates the interfaces and
call sites in preparation for switching to a vsync based video
rendering pipeline.
Some notes:
- Plumbs a VideoRendererSink into the the rendering pipeline; similar to
how we have an AudioRendererSink.
- A couple VideoRendererSink mocks are introduced which will be short
lived. Like audio, we will need fakes which can pump consumption tasks.
- The "PaintCB" callback has been temporarily placed on the new sink
interface such that in the field experiments can be run comparing the
performance of the video rendering approaches.
- Finally nukes Player_X11 since setting up a vsync renderer just for
unused tool code isn't worth the effort.
- Since compositor callbacks may stop due to visibility changes, the
new VideoRendererImpl will use a countdown timer to pump video playback
as frames expire; expired frames will not count as dropped.
- Since canvas/WebGL requires frame updates in the background a new
method has been added to VideoFrameCompositor to return the current
frame if it was updated with 250ms, or to request a new one and return
the updated one.
Subsequent work:
- sunnyps@ will be switching VideoFrameProviderClientImpl over to using
a BeginFrameObserver, which will ultimately drive the Render() callbacks.
- dalecurtis@ will land the VideoRendererAlgorithm which powers the new
rendering pipeline.
BUG=439548
TEST=everything works as is.
Review URL: https://codereview.chromium.org/1053113002
Cr-Original-Commit-Position: refs/heads/master@{#325306}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 45a3c93f745eabf6c1b1cbdac87ed4350a919e76
Reason for revert:
Actually, given the complexity of this change (not a one-line Cast fix) and the fact that we have broken Cast trybots running @ 100% right now (http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/), I'm going to revert this. I'm working on a brief patch of what I expect would need to be done for Cast and will upload/mail shortly.
Original issue's description:
> Prime the landing pad for the new video rendering pipeline.
>
> This is not a functional change, it only updates the interfaces and
> call sites in preparation for switching to a vsync based video
> rendering pipeline.
>
> Some notes:
> - Plumbs a VideoRendererSink into the the rendering pipeline; similar to
> how we have an AudioRendererSink.
> - A couple VideoRendererSink mocks are introduced which will be short
> lived. Like audio, we will need fakes which can pump consumption tasks.
> - The "PaintCB" callback has been temporarily placed on the new sink
> interface such that in the field experiments can be run comparing the
> performance of the video rendering approaches.
> - Finally nukes Player_X11 since setting up a vsync renderer just for
> unused tool code isn't worth the effort.
> - Since compositor callbacks may stop due to visibility changes, the
> new VideoRendererImpl will use a countdown timer to pump video playback
> as frames expire; expired frames will not count as dropped.
> - Since canvas/WebGL requires frame updates in the background a new
> method has been added to VideoFrameCompositor to return the current
> frame if it was updated with 250ms, or to request a new one and return
> the updated one.
>
> Subsequent work:
> - sunnyps@ will be switching VideoFrameProviderClientImpl over to using
> a BeginFrameObserver, which will ultimately drive the Render() callbacks.
> - dalecurtis@ will land the VideoRendererAlgorithm which powers the new
> rendering pipeline.
>
> BUG=439548
> TEST=everything works as is.
>
> Committed: https://crrev.com/e7f41df2541aea7c99f7965874f9c5ce901899e5
> Cr-Commit-Position: refs/heads/master@{#325183}
TBR=xhwang@chromium.org,sunnyps@chromium.org,brianderson@chromium.org,enne@chromium.org,dpranke@chromium.org,danakj@chromium.org,dalecurtis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439548
Review URL: https://codereview.chromium.org/1052493005
Cr-Original-Commit-Position: refs/heads/master@{#325187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 24413fda915450e43423cfe3902f887b6a937ae8
This is not a functional change, it only updates the interfaces and
call sites in preparation for switching to a vsync based video
rendering pipeline.
Some notes:
- Plumbs a VideoRendererSink into the the rendering pipeline; similar to
how we have an AudioRendererSink.
- A couple VideoRendererSink mocks are introduced which will be short
lived. Like audio, we will need fakes which can pump consumption tasks.
- The "PaintCB" callback has been temporarily placed on the new sink
interface such that in the field experiments can be run comparing the
performance of the video rendering approaches.
- Finally nukes Player_X11 since setting up a vsync renderer just for
unused tool code isn't worth the effort.
- Since compositor callbacks may stop due to visibility changes, the
new VideoRendererImpl will use a countdown timer to pump video playback
as frames expire; expired frames will not count as dropped.
- Since canvas/WebGL requires frame updates in the background a new
method has been added to VideoFrameCompositor to return the current
frame if it was updated with 250ms, or to request a new one and return
the updated one.
Subsequent work:
- sunnyps@ will be switching VideoFrameProviderClientImpl over to using
a BeginFrameObserver, which will ultimately drive the Render() callbacks.
- dalecurtis@ will land the VideoRendererAlgorithm which powers the new
rendering pipeline.
BUG=439548
TEST=everything works as is.
Review URL: https://codereview.chromium.org/1053113002
Cr-Original-Commit-Position: refs/heads/master@{#325183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7f41df2541aea7c99f7965874f9c5ce901899e5
This involves restructuring the remoting conditionals in gn_all and
gyp_remaining a fair amount, but otherwise no real surprises here.
There are a few chromeos-specific unittest targets in content that
we still need to port, but otherwise the port is as complete as desktop
linux.
BUG=433082
Review URL: https://codereview.chromium.org/1069903002
Cr-Original-Commit-Position: refs/heads/master@{#325097}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6293d2503965332696a292ff8a8da0a8f2a7ecc5
Reason for revert:
Seems to have broken the Win x64 debug builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)/builds/7600
Original issue's description:
> Get gn_all/gyp_remaining working for Windows.
>
> This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.
>
> A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.
>
> R=brettw@chromium.org
> BUG=354261
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
>
> Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c
> Cr-Commit-Position: refs/heads/master@{#324285}
TBR=brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=354261
Review URL: https://codereview.chromium.org/1071603005
Cr-Original-Commit-Position: refs/heads/master@{#324291}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2fbb13254941a8a0c33695cbfde0389c53828e3b
This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before.
A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL.
R=brettw@chromium.org
BUG=354261
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1064333002
Cr-Original-Commit-Position: refs/heads/master@{#324285}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaef8f504d6e2a55626e2fb8b6c233f1d756d65c
There are a few targets we build in a GYP build of Chromium that
we don't actually need and shouldn't be building. We will track
them in a 'gyp_only' target to indicate that they don't need to
be ported to GN.
TBR=brettw@chromium.org
BUG=461019
Review URL: https://codereview.chromium.org/1041163004
Cr-Original-Commit-Position: refs/heads/master@{#323170}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: aa9e60e1e08b558a89d0883cdc807ea48f934492
The bulk of the test suite requires internal test files, and so
we'll defer porting it to GN to a later date, but for now at
least we'll have a skeleton to hang that work on.
R=kbr@chromium.org
BUG=471903, 461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1041363002
Cr-Original-Commit-Position: refs/heads/master@{#322976}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e0422842dc0deae15c616006ada98782d2a67b40
This updates the gn_all and gyp_remaining targets to reflect the current
status.
R=tfarina@chromium.org, brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/1040543002
Cr-Original-Commit-Position: refs/heads/master@{#322654}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c09ccaa95ba1a2212f27fd86cd2650526a82a9ea
This also adapts net GN targets to use the new size_t->int warning suppression config in //build/config/compiler instead of a locally defined config.
BUG=
Review URL: https://codereview.chromium.org/936313002
Cr-Original-Commit-Position: refs/heads/master@{#320187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 707a56a6f0e56138fcef5db3ba7ace1ac3cb83eb
Remove components.gpy:session_manager_component from global dependency
list since it is already included if chromeos==1 or use_ash==1.
BUG=none
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg;tryserver.chromium.linux:linux_ecs_ozone
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/986383003
Cr-Original-Commit-Position: refs/heads/master@{#320181}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8c6aa8edcb4af22c634df10faffb41ae004cba0e
I think, when explicitly declaring a dependency on a target
(like gn_all does on build_utf8_validator_tables), if the target
is unconditionally only built in the host toolset, the dependency
needs to also say that; my initial version of the dependency did
not do that, leading gyp_chromium to fail in obscure ways.
R=thakis@chromium.org
BUG=465198
Review URL: https://codereview.chromium.org/990093002
Cr-Original-Commit-Position: refs/heads/master@{#319666}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b02cf778cdb3066ed3cbb9b2d70413a1577033e
This patch adds a whole bunch of small targets that
had either already been done but weren't mentioned
in the 'gn_all' group, or needed to be done.
In theory this should produce no change on any platform
other than Linux, except for one small windows target.
R=brettw@chromium.orgTBR=dtu@chromium.org
BUG=432959
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/975123003
Cr-Original-Commit-Position: refs/heads/master@{#319580}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: db5527d777f1e0cdbaec2bca579bec33aaf7497e
This patch re-lands the original change plus the fixes I
had to introduce the 'gn_all' and 'gyp_remaining' targets
in the GYP build. This patch is thus reverting
378e940e (#318636).
The code was actually correct at #318636 but was failing
on the iOS bots due to problems w/ their recipes that have
since been fixed.
TBR=brettw@chromium.org
BUG=461019
Review URL: https://codereview.chromium.org/977703003
Cr-Original-Commit-Position: refs/heads/master@{#318960}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5b90c6fdbd3097080752fcf15f2f0e5ae4d3aec3
It looks like these patches might be confusing the
analyze step on the ios bots. I don't understand
the errors I'm seeing on them, but they seem to
have started when the first of these patches landed,
so I'm going to try reverting them and see what happens.
This reverts:
"Rework how the gn migration targets are included from all.gyp."
commit 91cb1747a84d80acc9fc5045c971986f1799e02b (#318599).
"Fix a build failing in the x86 linux builds ..."
commit 425ba073036f96f04aea09c9836826ccb2e124e4. (#318626)
"Fix nacl-only targets in gn_migration.gypi"
commit ad333257fe8e7d9b632f728de5fe6db9feb9a64d. (#318631)
TBR=brettw@chromium.org
BUG=461019
NOTRY=true
Review URL: https://codereview.chromium.org/971633002
Cr-Original-Commit-Position: refs/heads/master@{#318636}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 378e940e74d07896695b6bd1582de760bab7c3b1
If NaCl is disabled, we get a build failure in the
x86 Linux builds when trying to build monacl_shell
(which isn't defined).
This patch fixes the issue by not trying to include
the gn_migration targets *and* by not trying to
build monacl_shell when nacl is disabled, both of
which were wrong.
Also, this patch fixes an issue in 'analyze' where it
was trying to analyze build_utf8_validator_tables
and not #host.
TBR=brettw@chromium.org
BUG=462945, 461019
Review URL: https://codereview.chromium.org/966223002
Cr-Original-Commit-Position: refs/heads/master@{#318626}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 425ba073036f96f04aea09c9836826ccb2e124e4
This change splits out the targets being used to track the gn
migration from all.gyp into a separate, new file
(gn_migration.gypi), and reworks their structure to
1) better match the gn_all target in src/BUILD.gn,
2) identify the targets built by 'all' in gyp that
are not yet explicitly listed in the gn_all target
(the new 'add_to_gn_all' target),
3) identify the targets left to be converted.
The 'add_to_gn_all' targets will simply be moved to gn_all in
a follow-up CL.
Right now these targets will be linux-only, but follow-up CLs
will expand them to the other configurations.
This CL should produce no actual changes in the builds.
R=brettw@chromium.org
BUG=461019
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg
Review URL: https://codereview.chromium.org/962343002
Cr-Original-Commit-Position: refs/heads/master@{#318599}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91cb1747a84d80acc9fc5045c971986f1799e02b
bruening
grt
thakis
tapted
maruel
jbroman
dzhioev
bungeman
tonychun
jochen
yfriedman
jackhou
sudarsana.nagineni
jam
pvalenzuela
tfarina
dyen
toyoshim
dpranke
pasko
aboxhall
garykac
sbc
maniscalco
Bartosz Fabianowski
dalecurtis
gunsch
rockot
ananta
dnicoara