- Pass command as list of args or set shell=True when needed.
- Set check_return=True where appropriate.
BUG=chromium:628617,catapult:#3242
Review-Url: https://codereview.chromium.org/2760923002
Cr-Original-Commit-Position: refs/heads/master@{#458097}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 43cc0fba21372346c981396d719443b05e7a2a0c
Reason for revert:
Breaks code editing in Android Studio, see http://crbug/700438 for more info.
Original issue's description:
> Android: Support Android Studio 2.3
>
> Also fixes excludes filters not working. For files whose directory is
> not fully included in the target, add those individually instead.
>
> BUG=700438
>
> Review-Url: https://codereview.chromium.org/2746103004
> Cr-Commit-Position: refs/heads/master@{#457093}
> Committed: f9fca7ca02TBR=wnwen@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=700438
Review-Url: https://codereview.chromium.org/2758683003
Cr-Original-Commit-Position: refs/heads/master@{#457866}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 136f215ed31f9e748b388b5e79bf0e4888f62acc
This flag will allow devs having access to the internal Chrome for
Android repo to choose whether to use it in their builds.
BUG=702323
Review-Url: https://codereview.chromium.org/2753273002
Cr-Original-Commit-Position: refs/heads/master@{#457749}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1e190d78a2084aa849819a8921d76e8dfe67e19
This CL enables static analysis support for Clang builds on Windows.
Developers can opt-in to receiving analysis text by setting
"use_clang_static_analyzer = true" in their GN build
args. The solution works with Goma.
* Added flags to Clang portions of build/toolchain/win/BUILD.gn.
* Added options to the Analysis wrapper script to handle clang-cl.exe's
flag style.
BUG=687243
Review-Url: https://codereview.chromium.org/2748793004
Cr-Original-Commit-Position: refs/heads/master@{#457566}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5847e4bdf3b65ccc136bc42ef00d573f2adb50fb
Previously, command-line flags to be passed to the test had to be
passed via:
- (gtests) --test-arguments <string>
- (instrumentation tests) --device-flags{,-file} <file>
This CL changes it s.t. any flags not recognized by the test runner
are passed down to the binary. It also removes --device-flags and
deprecates --test-arguments.
BUG=700366
Review-Url: https://codereview.chromium.org/2752493002
Cr-Original-Commit-Position: refs/heads/master@{#457513}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7d30806cf9bcb492d60dab0b3987aba72ff59f87
Reason for revert:
Increases time by a great deal.
Original issue's description:
> Use logdog butler subcommand to run tests.
>
> Previously we ran tests, without setting butler environment variables.
> This will run into NotBootstrappedError when we try to upload test
> results through logdog.
>
> In this cl, we use logdog butler subcommand to run tests, which will set
> butler environment variables before hand.
>
> BUG=692287
>
> Review-Url: https://codereview.chromium.org/2695963003
> Cr-Commit-Position: refs/heads/master@{#456976}
> Committed: de2df28c86TBR=mikecase@chromium.org,dnj@chromium.org,jbudorick@chromium.org,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692287
Review-Url: https://codereview.chromium.org/2749643008
Cr-Original-Commit-Position: refs/heads/master@{#457257}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d58d09ff7ef678920db1110ae5a0230f7d7cdb52
Currently the gtest results output has the 'DISABLED_' prefix on
disabled tests. This CL strips the 'DISABLED_' prefix for gtest results
output, which matches gtest results on desktop produced by
//base/test/launcher.
BUG=698143
Review-Url: https://codereview.chromium.org/2754463004
Cr-Original-Commit-Position: refs/heads/master@{#457155}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d0287a23d5d61345ca9c246b5119ab78e80305eb
Also fixes excludes filters not working. For files whose directory is
not fully included in the target, add those individually instead.
BUG=700438
Review-Url: https://codereview.chromium.org/2746103004
Cr-Original-Commit-Position: refs/heads/master@{#457093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9fca7ca0225a5c4ef021046526bf75e2cade80d
No intended behavior change. -DUSE_EXTERNAL_POPUP should no longer be
on every single compiler invocation, but only on the ones that need it.
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2751763002
Cr-Original-Commit-Position: refs/heads/master@{#457057}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 18e4264101591745752da096923f3133e6fc21e4
This adds support for sharding via GTEST_SHARD_INDEX and
GTEST_TOTAL_SHARDS (along with their equivalent --test-launcher-*
command-line options), matching the behavior of //base/test/launcher
for both gtests and instrumentation tests.
BUG=692200
Review-Url: https://codereview.chromium.org/2743873003
Cr-Original-Commit-Position: refs/heads/master@{#457001}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 84188b5c73a3bd70944aac7028dbdd449e9e5b73
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Original-Commit-Position: refs/heads/master@{#456976}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: de2df28c86b13227040aba5f9f5a1d1f869b81eb
Reason for revert:
Broken the official rpm builders (https://bugs.chromium.org/p/chromium/issues/detail?id=701585) and also causes an apparent regressing in the number of static initializes.
Original issue's description:
> Reland of Update linux sysroot images from debian/wheezy to debian/jessie (patchset #1 id:1 of https://codereview.chromium.org/2743253004/ )
>
> Reason for revert:
> Linux bot has now been upgraded
>
> Original issue's description:
> > Revert of Update linux sysroot images from debian/wheezy to debian/jessie (patchset #8 id:140001 of https://codereview.chromium.org/2361223002/ )
> >
> > Reason for revert:
> > Broke the linux builder which it seems is still on Precise.
> >
> > Original issue's description:
> > > Update linux sysroot images from debian/wheezy to debian/jessie
> > >
> > > BUG=564904
> > >
> > > Review-Url: https://codereview.chromium.org/2361223002
> > > Cr-Commit-Position: refs/heads/master@{#456441}
> > > Committed: 8d4f1d731f
> >
> > TBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=564904
> >
> > Review-Url: https://codereview.chromium.org/2743253004
> > Cr-Commit-Position: refs/heads/master@{#456449}
> > Committed: 189891d210
>
> TBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=564904
>
> Review-Url: https://codereview.chromium.org/2755483002
> Cr-Commit-Position: refs/heads/master@{#456758}
> Committed: 79d4fc169aTBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564904
Review-Url: https://codereview.chromium.org/2754443003
Cr-Original-Commit-Position: refs/heads/master@{#456900}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d93f0e0cabc7d2d4570b60d97434e32749c5723f
This adds a basic navigation bar fixed to the bottom of the
BottomSheet. Changing BottomSheet content will be done in a
follow up CL(s).
BUG=699598
Review-Url: https://codereview.chromium.org/2738843003
Cr-Original-Commit-Position: refs/heads/master@{#456833}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4a2aaa37f0366b0a4673fa57867cda86f65118c9
Reason for revert:
Linux bot has now been upgraded
Original issue's description:
> Revert of Update linux sysroot images from debian/wheezy to debian/jessie (patchset #8 id:140001 of https://codereview.chromium.org/2361223002/ )
>
> Reason for revert:
> Broke the linux builder which it seems is still on Precise.
>
> Original issue's description:
> > Update linux sysroot images from debian/wheezy to debian/jessie
> >
> > BUG=564904
> >
> > Review-Url: https://codereview.chromium.org/2361223002
> > Cr-Commit-Position: refs/heads/master@{#456441}
> > Committed: 8d4f1d731f
>
> TBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=564904
>
> Review-Url: https://codereview.chromium.org/2743253004
> Cr-Commit-Position: refs/heads/master@{#456449}
> Committed: 189891d210TBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564904
Review-Url: https://codereview.chromium.org/2755483002
Cr-Original-Commit-Position: refs/heads/master@{#456758}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 79d4fc169a9af62228134cf4c60714dbbe4659dd
It's been used to add a conditional dep on ui/gl, but we chrome depends on
that unconditionally already.
It's also been used to call glFinish() under the following conditions in
the glResizeCHROMIUM handler:
!defined(UI_COMPOSITOR_IMAGE_TRANSPORT)
UI_COMPOSITOR_IMAGE_TRANSPORT was always set on Linux and Chrome OS, which
means this code only ran on Android, and I'm not sure if we use
glResizeCHROMIUM there.
BUG=700681
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2748533002
Cr-Original-Commit-Position: refs/heads/master@{#456746}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 81e3d61f4f273627a7fb9d6d7f2bbbc382c95d7e
No intended behavior change. After this change, -DENABLE_WEBRTC won't be passed
to all translation units but only to those in targets containing translation
units reading it.
BUG=none
TBR=avi
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2745943002
Cr-Original-Commit-Position: refs/heads/master@{#456738}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 49a841a4fa2889833c8181cc18eae546db9370f7
Reason for revert:
Relanding since this revert doesn't appear to have helped:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
Original issue's description:
> Revert of Remove enable_vulkan from build/config, and move it to the buildflag_header system. (patchset #8 id:140001 of https://codereview.chromium.org/2744973002/ )
>
> Reason for revert:
> Speculative revert for linux tests failure:
> https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
>
> Original issue's description:
> > Remove enable_vulkan from build/config, and move it to the buildflag_header system.
> >
> > No intended behavior change.
> >
> > TBR=avi
> > BUG=none
> > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2744973002
> > Cr-Commit-Position: refs/heads/master@{#456525}
> > Committed: 7f118188c1
>
> TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=none
>
> Review-Url: https://codereview.chromium.org/2742263004
> Cr-Commit-Position: refs/heads/master@{#456562}
> Committed: 0192171168TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2746363002
Cr-Original-Commit-Position: refs/heads/master@{#456613}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: db0a348759ea9c97783c516344a1d96880ceb359
Reason for revert:
Speculative revert for linux tests failure:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests
Original issue's description:
> Remove enable_vulkan from build/config, and move it to the buildflag_header system.
>
> No intended behavior change.
>
> TBR=avi
> BUG=none
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Review-Url: https://codereview.chromium.org/2744973002
> Cr-Commit-Position: refs/heads/master@{#456525}
> Committed: 7f118188c1TBR=dyen@chromium.org,danakj@chromium.org,jbauman@chromium.org,avi@chromium.org,piman@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review-Url: https://codereview.chromium.org/2742263004
Cr-Original-Commit-Position: refs/heads/master@{#456562}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0192171168e7afc337edc13c150eca4152185cd5
This will be used primarily on perf bots to download APKs used for
tracking per-milestone patch size growth.
BUG=695188
Review-Url: https://codereview.chromium.org/2750603003
Cr-Original-Commit-Position: refs/heads/master@{#456502}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2850476323ae769b612011f3d99a2d17759a2952
In component builds where DEPOT_TOOLS_WIN_TOOLCHAIN=0 the VS toolchain
script would copy *most* of the UCRT DLLs, but not all of them. It would
fail to copy the api-ms-win-crt-*.dll files. This was not noticed
because these only need to be copied in if you make the mini_installer
target, and if you had previously done generated your output directory
with DEPOT_TOOLS_WIN_TOOLCHAIN=1 then the files would be copied in then,
and retained.
This changes the script to copy from %WINDOWSSDKDIR%\Redist\ucrt\DLLs
directory, or the default location if this variable is not set. This
path is used elsewhere, why copy_cdb_to_output.py and is supported by
both values of DEPOT_TOOLS_WIN_TOOLCHAIN. If the SDK is installed in a
non-default location then DEPOT_TOOLS_WIN_TOOLCHAIN=0 users will have to
ensure that WINDOWSSDKDIR is set.
Local testing confirms that the set of files copied is now identical for
DEPOT_TOOLS_WIN_TOOLCHAIN=0/1 (the file versions are different due to
SDK updates but that is known and expected).
BUG=692300
Review-Url: https://codereview.chromium.org/2743423002
Cr-Original-Commit-Position: refs/heads/master@{#456484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 46cd6d9361fffc104929e0ed654576eb3b286f14
Reason for revert:
Broke the linux builder which it seems is still on Precise.
Original issue's description:
> Update linux sysroot images from debian/wheezy to debian/jessie
>
> BUG=564904
>
> Review-Url: https://codereview.chromium.org/2361223002
> Cr-Commit-Position: refs/heads/master@{#456441}
> Committed: 8d4f1d731fTBR=phajdan.jr@chromium.org,thestig@chromium.org,thomasanderson@google.com,dpranke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=564904
Review-Url: https://codereview.chromium.org/2743253004
Cr-Original-Commit-Position: refs/heads/master@{#456449}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 189891d210bb98c91e155d4794dffa03d95f1e15
Some apk targets directly depend on their resources (e.g.
//android_webview/test:android_webview_apk). These are not picked up by
javac and need to be added to gradle in order to allow editing of all
resources.
BUG=682846
Review-Url: https://codereview.chromium.org/2724093003
Cr-Original-Commit-Position: refs/heads/master@{#456416}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f37993e1a795b3d8d72bb858a8ccb0a74b82400b
This way, ENABLE_WAYLAND_SERVER isn't defined globally, but only where
it's needed (chrome/common and deps). No intended behavior change.
BUG=none
Review-Url: https://codereview.chromium.org/2741783007
Cr-Original-Commit-Position: refs/heads/master@{#456293}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a6fa3d313a9e5a445c2ed406bc87e0affaa3cc63
Building with VS 2017 using a packaged toolchain is not yet supported
but if you try to do it you get a surprising result - the VS 2013
toolchain gets downloaded. This adds a 2013 check to avoid this, and
also simplifies/corrects an existing 2017 check and comment.
This lets us fail-fast if a user tries the VS 2017 depot-tools
combination before it is supported.
BUG=683729
Review-Url: https://codereview.chromium.org/2741783006
Cr-Original-Commit-Position: refs/heads/master@{#456226}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fead74a8e3d55044bc89fe96500275a0b5e3f24c
This CL replaces the Clang 'c++-analyzer' Perl script with logic added to the Python wrapper script. This gives us the hooks we need to run analysis builds with "gomacc" (necessary for distributed builds) and gives us a convenient place to specify analyzer config flags which aren't exposed by scan-build.
Adds a warning suppression rule which prevents the analyzer from raising false positives from stdlib code (code w/namespace "std").
Other changes:
* Modify Goma portions of the GCC toolchain GNI to build paths to
the Clang static analyzer.
* Create an exception for ASM tool invocations, which don't play
well with the analysis command line flags.
* Removed 'scan-build' DEP.
BUG=687245
R=thakis@chromium.org,wez@chromium.org
Review-Url: https://codereview.chromium.org/2667853004
Cr-Original-Commit-Position: refs/heads/master@{#456136}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6694c0e5e6727606e83542d3d471f3967fdb0128
The VS 2015 Update 3, 14393 SDK landmine currently fires if you move to
building with VS 2017. That is undesirable. For local builds it is
unnecessary. For bot builds we need to fix the long-standing bug whereby
Windows compiler changes fail to trigger builds, rather than relying on
this landmine quirk.
R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2742603002
Cr-Original-Commit-Position: refs/heads/master@{#455812}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8f32820f092fb4b91778feb1304c6161fec14658
Reason for revert:
Reverting :( this since using find_depot_tools doesnt work on some bots. Will have to find alternative and reland.
Original issue's description:
> Add failure screenshots and render test images to results detail.
>
> Review-Url: https://codereview.chromium.org/2701473003
> Cr-Commit-Position: refs/heads/master@{#453039}
> Committed: 191a06d04aTBR=yolandyan@chromium.org,hzl@chromium.org,hzl@google.com,jbudorick@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
Review-Url: https://codereview.chromium.org/2737223002
Cr-Original-Commit-Position: refs/heads/master@{#455639}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 85c3c4f9fdb6de0dcda6f8c5e9d460ef09dd292d
The VS 2017 vcvarsall.bat file is quite fragile. It fails if
vcvarsall.bat from a previous release has been run in the same command
prompt, and this failure is not detected by setup_toolchain.py. The
problem occurs because the new vcvarsall.bat won't overwrite an
existing VSINSTALLDIR. The fix is to clear it from the environment if it
is set.
The main test was to try to build with VS 2017 after running the VS 2015
vcvarsall.bat. Trimmed output is shown here:
> where cl
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64_x86\cl.exe
C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\cl.exe
> set gyp
GYP_MSVS_VERSION=2017
> gn clean out\release & gn gen out\release & ninja -v -C out\release ..\..\build\precompile.cc^^
Done. Made 5496 targets from 1254 files in 4078ms
ninja: Entering directory `out\release'
...
[15/15 0.439s] ... \Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64/cl.exe ...
I also verified that I can switch between 2015 and 2017 builds with just
a "gn gen" to reset the toolchain.
> set GYP_MSVS_VERSION=2015
> gn gen out\release
> ninja -v -C out\release ..\..\build\precompile.cc^^
ninja: Entering directory `out\release'
[1/1 0.140s ] ... "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64/cl.exe" ...
> set GYP_MSVS_VERSION=2017
> gn gen out\release
Done. Made 5496 targets from 1254 files in 3768ms
> ninja -v -C out\release ..\..\build\precompile.cc^^
ninja: Entering directory `out\release'
[1/1 0.131s ] ... \Microsoft Visual Studio\2017\Professional\VC\Tools\MSVC\14.10.25017\bin\HostX64\x64/cl.exe ...
R=scottmg@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2738993003
Cr-Original-Commit-Position: refs/heads/master@{#455630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1d57799fb3aa77b04cc79982dca0261d6b7d673e
The script was originally //third_party/skia/gn/gn_to_cmake.py
Planning to use it to enable editing native files in android studio.
Currently script does not allow full build, intended for editing only.
BUG=694699
Review-Url: https://codereview.chromium.org/2733353003
Cr-Original-Commit-Position: refs/heads/master@{#455521}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a45e8b336d2b214cfd5db0b3e3b5b85b688ce8db
agrieve
perezju
estevenson
dgn
kmarshall
mikecase
thakis
thomasanderson
jbudorick
hzl
pcc
shenghuazhang
wnwen
maxmorin
kcwu
sbc
twellington
qyearsley
brucedawson
sakal
glider
thestig
ymzhang
thomasanderson
jcivelli