Crushed sprite resources and layers were only used for Contextual
Search. CS no longer has a use for a the animated sprite, so this
removes the crushed sprite resources and layers and replaces
the CS use with a static icon.
BUG=707001
Review-Url: https://codereview.chromium.org/2798123002
Cr-Original-Commit-Position: refs/heads/master@{#462861}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7ce5ab6e1b8c7f699c838b8086d42ed1866d21ba
All platforms now specify whether to emit frame pointers by default, rather than
relying on default compiler options.
This CL moves the logic from config("default_stack_frames") into compiler.gni.
The former is actually the right place for the logic to live, but there exists
code that relies on whether a frame pointer is emitted by default. Right now,
that logic is being duplicated/guessed by the code in question. This CL at least
unifies the logic in a single location.
There current exists code that uses a preprocessor definition
HAVE_TRACE_STACK_FRAME_POINTERS. Despite the name, the code really wants to know
if most stacks can be unwound using stack pointers. I've renamed it to
CAN_UNWIND_WITH_FRAME_POINTERS. Arguably, any code that uses
CAN_UNWIND_WITH_FRAME_POINTERS is broken and should be removed, since it relies
on the assumption that all stacks will either have or not have frame pointers,
but that can vary TU by TU.
BUG=706116, 706654
Review-Url: https://codereview.chromium.org/2782063005
Cr-Original-Commit-Position: refs/heads/master@{#462622}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f7c8a0df4253be5271276dc7f3c1da5ce9b677c1
This CL filters encoded binary protobuf signaled by "***BINARY RUN
STATS***" and program class information signaled by "ProgramClass:".
This extra output is introduced by updating proguard.
BUG=674152
Review-Url: https://codereview.chromium.org/2801443002
Cr-Original-Commit-Position: refs/heads/master@{#462620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 749473a927734754dfcb323b16bdf747b7248d5a
No need to build intermediate (possibly quite large) strings. This
might also help with large objects failing to pickle.
BUG=680935
Review-Url: https://codereview.chromium.org/2805533003
Cr-Original-Commit-Position: refs/heads/master@{#462553}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: be6dcf5eec3df0153f9e67b0b1a15cf4416144b7
Building with the wheezy sysroot and is_clang=false results in errors
like this:
../../base/process/process_iterator.h:12:16: fatal error: list: No
such file or directory
#include <list>
[1] added a restriction that use_sysroot must be false when building
with is_clang=false. However, as of [2], the wheezy sysroot has been
removed, and these compilation errors are not present on the Jessie
sysroot. This CL removes the restriction added by [1].
[1] https://codereview.chromium.org/1476923005
[2] https://codereview.chromium.org/2597523003
BUG=575778
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2804633005
Cr-Original-Commit-Position: refs/heads/master@{#462343}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c2c8a4d94797d67f76e061be40cfed0378eccd81
It was disabled in BUILD.gn, because there are known failures,
but recently Clang enabled it by default, so we have to opt out.
Eventually, we need to clean up these failures and reenable the
check as it's useful.
BUG=708216,708707
Review-Url: https://codereview.chromium.org/2797253002
Cr-Original-Commit-Position: refs/heads/master@{#462187}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 69faa6a6ffc1ceebf4d499618a5d17c8a1e7af67
When passing --headless to avd.py, it fails to start an emulator
and this message is printed:
qemu-system-i386: -audio: invalid option
Taking out the -no-audio option allows the emulator to launch
successfully.
BUG=NONE
Review-Url: https://codereview.chromium.org/2799453003
Cr-Original-Commit-Position: refs/heads/master@{#462106}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e5a1eaf77cc75b28dc7c40a14fdc412fe9a58242
9104d53d1c60 Fix thread startup in snapshot reader test
542a91e20e39 Fix the race causing flaky CrashpadClient tests
270490ff79df win: Be more careful about child process exit codes
6c8a3f700738 win: Use a semaphore for synchronization in
ProcessSnapshotTest
f14eda221fe7 win: Be more careful about exit codes in end_to_end_test.py
449dfc4b5dc1 Remove BUG_LINE_FORMAT from codereview.settings
d6837b2b869f mac: Fix SystemSnapshotMacTest.TimeZone on macOS 10.12.4
96dc950eaf26 posix: Add ScopedMmap for managing memory-mapped regions
3127026a95c1 Convert generate_doxygen.sh to generate_doxygen.py
1a6ae8ce0ba8 posix: Don’t accumulate zombies in ProcessInfo.Forked
test
aa2bc55777b9 posix: Allow ScopedMmap::ResetAddrLen() to deal with
overlap
385fe6615f11 posix: DCHECK for (addr + len) overflow in
ScopedMmap::ResetAddrLen()
c39e4dc9769e mac: Remove obsolete comment about
mach_msg_header_t::msgh_reserved
46883516231e “Promote” test::Paths::Executable() to
Paths::Executable()
fa8ef92dc7f1 linux: Add ProcessMemory which reads another process'
memory
4b450c813795 test: Use (actual, [un]expected) in gtest
{ASSERT,EXPECT}_{EQ,NE}
76a67a37b1d0 Add the --monitor-self argument to crashpad_handler
45305395ad87 win: Determine length of unloaded module names
8f07f7481ab4 handler: Add --monitor-self-annotations
b4095401639e handler: Reuse existing annotations SimpleStringDictionary
BUG=crashpad:30,crashpad:143
Review-Url: https://codereview.chromium.org/2804713002
Cr-Original-Commit-Position: refs/heads/master@{#462093}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a4d005995302373474923a31d642c8f49071a0ce
Previously we store the logcat into a temporary directory, which will be
deleted shortly. That means logcat will not be viewable in the isolated
directory.
In this cl, we are storing the logcat in the isolated directory, for
later easier view. This is a temporary fix before result details is
enabled.
BUG=707387
Review-Url: https://codereview.chromium.org/2797773003
Cr-Original-Commit-Position: refs/heads/master@{#461898}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ae14459caaa7f3b049b3d44be2c209890773213
The NMR1 SDK has been published upstream, so BuildInfo#isGreaterThanN is
no longer needed. This patch also removes reflection for
UserManager#isDemoUser() and ShortcutManager#reportShortcutUsed(),
and updates AndroidManifest.xml to remove the conditional include
of launchershortcut.xml and network_security_config.xml.
BUG=707302
Review-Url: https://codereview.chromium.org/2785373004
Cr-Original-Commit-Position: refs/heads/master@{#461787}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df46c2242e4635dc77fce945bfc0ea0089efee31
Previously, we only logged gtest stdout as part of parsing the
stdout to determine the test results. When using XML parsing
(i.e., when a user passed --enable-xml-result-parsing), stdout
was not logged.
This CL ensures we log the stdout in both cases.
BUG=707373
Review-Url: https://codereview.chromium.org/2793133003
Cr-Original-Commit-Position: refs/heads/master@{#461705}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 00314619b481948fcaeed5cf5e607232a7e55d2d
Adding frameworks jar build from the android-7.1.1_r28 tag
in AOSP.
Bug:707823
Change-Id: Ifbe2c91aa1b495b0959b5de026bc9fd690474b12
Reviewed-on: https://chromium-review.googlesource.com/466631
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Commit-Queue: Michael Case <mikecase@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#461605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a2b501b65e0987b4f2a23561a4906eb02f955a40
- Better explain what this component does.
- Add a detailed description for replace_gn_files.py.
- Format text to fit in 72 columns.
- Mention GN build files.
Review-Url: https://codereview.chromium.org/2783293002
Cr-Original-Commit-Position: refs/heads/master@{#461186}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5864d312aa006009fb4734c59320f04f2d6dceb2
Adding support to use Robolectric's play-services shadow
classes. Removing a custom shadow class we had in Chromium
now that the same shadow is available in Robolectric.
BUG=693660
Review-Url: https://codereview.chromium.org/2760743002
Cr-Original-Commit-Position: refs/heads/master@{#460906}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 476fddc51fb5cf133f2ce351c6805e65f4cbc4dd
When doing x64 builds of Chrome with VC++ we compile some modules
(currently just libyuv) with clang, in order to get inline assembly
support. This causes problems on /analyze builds because clang-cl
doesn't understand the /analyze compiler switches. This change
disables /analyze for those files that are compiled with clang.
With this change I can do a /analyze build of libyuv without
hitting any errors, but warnings are emitted as appropriate.
R=brettw@chromium.org
BUG=427616
Review-Url: https://codereview.chromium.org/2786733005
Cr-Original-Commit-Position: refs/heads/master@{#460874}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bb4bb0ebf2bfc2881100122e1513ee3f694744a0
sbc
twellington
jochen
erikchen
zpeng
perezju
jbudorick
agrieve
thomasanderson
krasin
sanfin
mark
wnwen
hzl
baxley
sandv
kjellander
Mike Case
michaeldo
wychen
brucedawson
Nico Weber
thestig
rsesek
mikecase
findit-for-me
jshin