It appears the "*" path in the case statement is never
matched due to the double-quotes (tested with bash 4.3.11 on
Trusty 14.04). Removing the quoting aligns with other case
statements in the script, and solves the problem. This bug
made https://codereview.chromium.org/2650823010 not have any
effect, which was discovered when deploying ARM 64 bots for
WebRTC.
BUG=684356,webrtc:7024
Review-Url: https://codereview.chromium.org/2790453002
Cr-Original-Commit-Position: refs/heads/master@{#460733}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 95504aea9818ec4e593358d0373f9c41531a3b67
Create an OWNERS file for this directory and add myself as well. This is
preparation for using a shared FreeType between Blink and PDFium, but
not actually used as a depedency to any Windows targets yet.
BUG=700926
Review-Url: https://codereview.chromium.org/2781773003
Cr-Original-Commit-Position: refs/heads/master@{#460211}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e15f5107bfba9080481fd78ed35c69c81fc41ac3
Currently, logcats are very difficult to find in bot logs. Adding
logging to log the logdog links.
In the future, these links will get moved out of the python logs
and into the result detail HTML page.
Review-Url: https://codereview.chromium.org/2777103004
Cr-Original-Commit-Position: refs/heads/master@{#460151}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2753f4dd3d49fddb16c538feddb125c92cc0fe23
llvm-ar is faster and is capable of handling
LLVM bitcode files without a need for a Gold plugin.
BUG=660216,607968
Review-Url: https://codereview.chromium.org/2766333002
Cr-Original-Commit-Position: refs/heads/master@{#460129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8968cd5170f4a22b1c508ffa3bc240b346c44b1b
When building a custom framework, the framework and the framework_dir
flags need to be added to the command-line of every linkable target
the depends directly or indirectly on it. GN propagates properly the
framework as it knows about "libs", but the -F flag added to ldflags
need to be propagated using all_dependent_configs.
BUG=704946
Review-Url: https://codereview.chromium.org/2778813002
Cr-Original-Commit-Position: refs/heads/master@{#460071}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5376139411f2b362d24abc27425f3827697a46d4
Chrome has not built with VS 2013 for a while now, so no need to carry
that baggage around as we add VS 2017 support.
Review-Url: https://codereview.chromium.org/2771333002
Cr-Original-Commit-Position: refs/heads/master@{#459876}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e7c0d998d5416b380ffefe1f6acd6126e35d11ed
This change contains two parts, for full-symbol (symbol_level=2, default)
and reduced-symbol (symbol_level=1) debug builds. It has no effect on release
builds.
1.) For symbol_level=2, pass -Wl,--gdb-index to the linker. This lets the linker
write an index that lets it load binaries much faster.
gdb startup time for target chrome from goes from 60s to 10s and time from
`run` in gdb to the program actually starting from 270s to 45s.
In return, this slows down linking a bit, but for target chrome in a
debug build, it increases link time from 37s to 42s, which is better than
making people who want to use gdb wait several minutes every time they start
gdb.
There's some history here: We used to pass -Wl,--gdb-index long ago, and
then removed it in https://codereview.chromium.org/335903002/, with the
recommendation that people who want to use gdb could run build/gdb-add-index.
But running `gdb-add-index chrome` takes 73s nowadays, a lot more than the 5s
that gold needs. (Back then, gdb-add-index was faster, and gold, due to us
not yet defaulting to component builds in debug builds, was slower. Also,
people were on an older default Ubuntu and used an older gdb version.)
People who don't use gdb should use symbol_level=1 for their builds anyhow
(and bots do too), so this small regression in link time shouldn't affect
them.
Remove the explicit gdb_index gn arg now that this has a good default.
2) For symbol_level=1, make this mode actually work again after the gn swtich.
In symbol_level=1 builds, gn would pass `-g1 -gsplit-dwarf` to clang (*).
Surprisingly, -gsplit-dwarf implies -g2 with clang, so the -g1 gets
overriden by -g2 immediately.
Before this, symbol_level=1 in debug builds would produce full debug info.
Since all bots set symbol_level=1, this might help with build speed
on debug bots. For people who set this locally, it'll also speed up
gdb startup time for target chrome from 39s to 13s and time from
`run` in gdb to the program actually starting from 255s to 35s.
*: clang always writes stack debug info to both .o and .dwo files, and lets
the linker link them into the executable, so -g1 -gsplit-dwarf would make
no sense. This was used as justification to make -gsplit-dwarf imply -g2,
as it otherwise wouldn't have an effect.
BUG=374952
R=piman@chromium.org, tansell@chromium.org
Review-Url: https://codereview.chromium.org/2770933009
Review-Url: https://codereview.chromium.org/2770933009 .
Cr-Original-Commit-Position: refs/heads/master@{#459824}
Committed: 7b26c51270
Cr-Original-Original-Commit-Position: refs/heads/master@{#459790}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b9f7581b93ae8096afed29d415791803caf2e2e3
Reason for revert:
Suspicion that it cause a compile failure on https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29%2832%29/builds/65207
Original issue's description:
> linux: Improve gdb startup time for debug builds from over 4 minutes to 35s.
>
> This change contains two parts, for full-symbol (symbol_level=2, default)
> and reduced-symbol (symbol_level=1) debug builds. It has no effect on release
> builds.
>
> 1.) For symbol_level=2, pass -Wl,--gdb-index to the linker. This lets the linker
> write an index that lets it load binaries much faster.
> gdb startup time for target chrome from goes from 60s to 10s and time from
> `run` in gdb to the program actually starting from 270s to 45s.
> In return, this slows down linking a bit, but for target chrome in a
> debug build, it increases link time from 37s to 42s, which is better than
> making people who want to use gdb wait several minutes every time they start
> gdb.
>
> There's some history here: We used to pass -Wl,--gdb-index long ago, and
> then removed it in https://codereview.chromium.org/335903002/, with the
> recommendation that people who want to use gdb could run build/gdb-add-index.
> But running `gdb-add-index chrome` takes 73s nowadays, a lot more than the 5s
> that gold needs. (Back then, gdb-add-index was faster, and gold, due to us
> not yet defaulting to component builds in debug builds, was slower. Also,
> people were on an older default Ubuntu and used an older gdb version.)
>
> People who don't use gdb should use symbol_level=1 for their builds anyhow
> (and bots do too), so this small regression in link time shouldn't affect
> them.
>
> Remove the explicit gdb_index gn arg now that this has a good default.
>
> 2) For symbol_level=1, make this mode actually work again after the gn swtich.
> In symbol_level=1 builds, gn would pass `-g1 -gsplit-dwarf` to clang (*).
> Surprisingly, -gsplit-dwarf implies -g2 with clang, so the -g1 gets
> overriden by -g2 immediately.
>
> Before this, symbol_level=1 in debug builds would produce full debug info.
> Since all bots set symbol_level=1, this might help with build speed
> on debug bots. For people who set this locally, it'll also speed up
> gdb startup time for target chrome from 39s to 13s and time from
> `run` in gdb to the program actually starting from 255s to 35s.
>
> *: clang always writes stack debug info to both .o and .dwo files, and lets
> the linker link them into the executable, so -g1 -gsplit-dwarf would make
> no sense. This was used as justification to make -gsplit-dwarf imply -g2,
> as it otherwise wouldn't have an effect.
>
> BUG=374952
>
> Review-Url: https://codereview.chromium.org/2770933009
> Cr-Commit-Position: refs/heads/master@{#459790}
> Committed: 7b26c51270TBR=dpranke@chromium.org,piman@chromium.org,tansell@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=374952
Review-Url: https://codereview.chromium.org/2776193002
Cr-Original-Commit-Position: refs/heads/master@{#459800}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 745ab003bddd9043058e1f19db831a9b4f0f6dbf
This change contains two parts, for full-symbol (symbol_level=2, default)
and reduced-symbol (symbol_level=1) debug builds. It has no effect on release
builds.
1.) For symbol_level=2, pass -Wl,--gdb-index to the linker. This lets the linker
write an index that lets it load binaries much faster.
gdb startup time for target chrome from goes from 60s to 10s and time from
`run` in gdb to the program actually starting from 270s to 45s.
In return, this slows down linking a bit, but for target chrome in a
debug build, it increases link time from 37s to 42s, which is better than
making people who want to use gdb wait several minutes every time they start
gdb.
There's some history here: We used to pass -Wl,--gdb-index long ago, and
then removed it in https://codereview.chromium.org/335903002/, with the
recommendation that people who want to use gdb could run build/gdb-add-index.
But running `gdb-add-index chrome` takes 73s nowadays, a lot more than the 5s
that gold needs. (Back then, gdb-add-index was faster, and gold, due to us
not yet defaulting to component builds in debug builds, was slower. Also,
people were on an older default Ubuntu and used an older gdb version.)
People who don't use gdb should use symbol_level=1 for their builds anyhow
(and bots do too), so this small regression in link time shouldn't affect
them.
Remove the explicit gdb_index gn arg now that this has a good default.
2) For symbol_level=1, make this mode actually work again after the gn swtich.
In symbol_level=1 builds, gn would pass `-g1 -gsplit-dwarf` to clang (*).
Surprisingly, -gsplit-dwarf implies -g2 with clang, so the -g1 gets
overriden by -g2 immediately.
Before this, symbol_level=1 in debug builds would produce full debug info.
Since all bots set symbol_level=1, this might help with build speed
on debug bots. For people who set this locally, it'll also speed up
gdb startup time for target chrome from 39s to 13s and time from
`run` in gdb to the program actually starting from 255s to 35s.
*: clang always writes stack debug info to both .o and .dwo files, and lets
the linker link them into the executable, so -g1 -gsplit-dwarf would make
no sense. This was used as justification to make -gsplit-dwarf imply -g2,
as it otherwise wouldn't have an effect.
BUG=374952
Review-Url: https://codereview.chromium.org/2770933009
Cr-Original-Commit-Position: refs/heads/master@{#459790}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7b26c51270cebd5de672a155b34f30bc8282c35a
This reduces our installed APK size from ~90MB to 65 on ATV. It
reduces earth OTA size by 1.5MB and earth cast_shell size by 5MB.
Leave unwind tables for builds where we regularly use a debugger (x86
and ATV debug).
BUG=internal b/36082628
Review-Url: https://codereview.chromium.org/2770833003
Cr-Original-Commit-Position: refs/heads/master@{#459619}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a13b58bb24fb7bc0bbc7d68296ef11a64df4989e
This change adds a hash for the VS 2017 RTM toolchain download in depot
tools. This allows Googlers to use VS 2017 to build Chrome without
needing to install it, and lets build machines use VS 2017 (although
they continue to default to VS 2015.
The package was created on a Windows Server 2016 VM. One would hope that
the OS used wouldn't matter, but ...? Previous installs of VS 2015 or
the platform SDK are likely to leave files lying around that will alter
the hash so a clean VM is needed. Then follow these steps:
Install VS 2017 Professional RTM, selecting the "Desktop development with
C++" component, and add the MFC and ATL support option.
After this is done you need to install the debugger packages from the
Windows 10 SDK. Go to:
https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk
and be sure to check the Debugging Tools option. Once the installers
have downloaded you can find the x86 and x64 debugger installers in the
download directory in "Windows Kits\10\StandaloneSDK\Installers" - run
them both.
Then run the packaging script, like this:
> python depot_tools\win_toolchain\package_from_installed.py 2017
Note that this packages the 10.0.14393.0 SDK, but this is not the same
10.0.14393.0 SDK that was used in the previous VS 2015 packaging. The
SDK was updated without changing the version number. Most of the changes
should not matter, but be aware.
To use this package set these two environment variables:
DEPOT_TOOLS_WIN_TOOLCHAIN=1
GYP_MSVS_VERSION=2017
Then run "gclient runhooks" to download the new package. The .ninja
files will not automatically update so you may need to run gn gen on
your output directories.
The 'chrome' target should build cleanly without warnings. However
VS 2017 is not yet a supported toolchain so warnings may appear. You
may want to use the treat_warnings_as_errors = false build flag.
To run VS 2017 tests on the buildbots you need to change the
CURRENT_DEFAULT_TOOLCHAIN_VERSION in build\vs_toolchain.py to '2017'
and you need to add a landmine to force a rebuild.
The build process was tested on two separate VMs to ensure that the
results were consistent. They were.
BUG=683729
Review-Url: https://codereview.chromium.org/2777643002
Cr-Original-Commit-Position: refs/heads/master@{#459593}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 560bb951d9a6625633fcad4e4168fb7054bb4dfa
This was automated using a script [1] that does the following:
- Rename relevant files in the following folders from website_settings* to
page_info*:
- chrome/browser/ui/page_info
- chrome/browser/ui/cocoa/page_info
- chrome/browser/ui/views/page_info
- chrome/browser/ui/android/page_info
- chrome/android/java/res/layout
- Run `./tools/git/mass-rename.py` to update e.g. includes, build files, header
guards.
- mass-rename.py does not handle test files (https://crbug.com/701529) or
Java, so those are handled separately, either in an early step are as part
of the later renames.
- `page_info_bubble_controller.h` needs a separate header guard fix.
- Use `sed` to rename classes, enums, non-UMA strings, and comments *WebsiteSettings* to *PageInfo* across the entire Chromium project.
- Since several content settings classes are also called "WebsiteSettings", this is done by taking a full list of all occurrences of full tokens containing "WebsiteSettings", "website_settings", or "website settings" and whitelisting individual replacements.
- To avoid modifying strings, all lines containing the relevant tokens *following at least one quote mark on the same line* are preserved, except two individually handled cases. There do not appear to be any affected multi-line strings.
- `git cl format`
- Remove two long-standing TODO comments about this rename, in:
- PageInfoPopup.java
- page_info_bubble_controller.h
This CL does not attempt to reflow comments; all changes stay within 80 lines, though.
[1] https://github.com/lgarron/website-settings-to-page-info/blob/master/page_info.fish
BUG=571506
TBR=jochen@chromium.org
Review-Url: https://codereview.chromium.org/2754383004
Cr-Original-Commit-Position: refs/heads/master@{#459562}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 617a30f35e5cec5df6c15a8d7fbb222cdbabcccc
MSVC complains if you use noexcept with no exception handling mode specified (as we do).
This code disables the warning. noexcept on move constructors allows better optimizations
in some cases.
http://en.cppreference.com/w/cpp/language/noexcept_spec
Updates a few common classes' move constructors to use this.
Reland of https://codereview.chromium.org/2771643002 with landmine. There were some
reports of PCH headers not getting updated and the warning change no taking effect.
I investigated briefly but could not see why PCH dependencies are incorrect.
Review-Url: https://codereview.chromium.org/2769283002
Cr-Original-Commit-Position: refs/heads/master@{#459455}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f78cc27d15ccbd1fd0c5c93aa03b939cd89b9b89
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Commit-Position: refs/heads/master@{#456976}
Committed: de2df28c86
patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001)
Review-Url: https://codereview.chromium.org/2767833002
Cr-Original-Commit-Position: refs/heads/master@{#459281}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9b15df5f68a23a7c75af0e09ee52b4add1a6f1d6
3eaee58970c2 doc: Update Android developer documentation for NDK 14
87c75552ad70 Implement ProcessInfo for Linux/Android
bad4fd00113a linux: Fix ProcessInfo for x86[_64]
48781dc182c2 linux: Fix process start time computation
9be4745be0f7 linux: Lazily initialize ProcessInfo’s Is64Bit() and
StartTime()
d7467ba7e485 linux: Use user_regs instead of pt_regs for 32-bit ARM in
ProcessInfo
5938c6e9933a linux: Support ProcessInfo::Is64Bit() for ARM on pre-3.5.0
Linux
82009cd14de5 android: Support builds with NDK API versions older than 21
(compat)
b10d9118dea4 minidump: Ignore attempts to add user streams with type
collisions
51b21d887467 Add DelimitedFileReader and use it in Linux/Android’s
ProcessInfo
00b64427523b Make file_io reads more rational and predictable
4f90f1514692 Remove WeakStdioFileReader and WeakStdioFileWriter
88bc09fb8615 posix: Fix StdioFileHandle() for GCC
14138936b5c4 test: Compare ProcessInfo::Arguments() to main()’s
argc/argv on POSIX
bc5b7b06db68 Fix racy WorkerThread test
542306626df8 minidump: Make the MemoryListStream the caboose once again
39f13a77a449 Make run_tests.py work with paths instead of configuration
names
3983b80ca2fc util/file: Handle oversized reads and writes gracefully
e4cad9e51483 doc: Standardize on “macOS” in comments
c1157e87f164 Crashpad overview design doc
af66c4b74028 Add overview design doc link to root README.md
cca10659c739 android: Fix gmock-using tests’ use of MOCK_METHODn()
with clang
db8c54e142d9 android: Add gyp_crashpad_android.py for easier Android
development
013d5e14a30c #include <stddef.h> where offsetof() is used
7a7815506bf2 GCC fix: Don’t use arraysize() on packed structs
fa3413e14a22 GCC fix for -Wunused-but-set-variable
810d4815df8a minidump: Allow for user extension streams computed at
crash time
cedfd7b9cd71 android: Don’t use OPEN_MAX
f8ef834ef5dd android: Support “unified headers” with GCC build
8e37886d418d linux: Don’t make assumptions about the CPU revision
BUG=crashpad:30, crashpad:167, crashpad:169, crashpad:171, chromium:703890
Review-Url: https://codereview.chromium.org/2773813002
Cr-Original-Commit-Position: refs/heads/master@{#459244}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a53e839bbe97b3936efad635e8feed3551cf545
Convenient when running it locally and you want it to be fast, but you
don't want to disable via --no-output-dir so that it still looks at .pak
files.
Review-Url: https://codereview.chromium.org/2764913002
Cr-Original-Commit-Position: refs/heads/master@{#459115}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6935a6b5c4cac7b654a002b7c80c133d458bfe39
Reason for revert:
Seems to have broken Windows build with args.gn as:
> is_debug = true
> is_component_build = true
> enable_nacl = false
> is_chrome_branded = true
> symbol_level = 2
> target_cpu = "x86"
> is_win_fastlink = true
> is_clang = false
> win_console_app = true
> win_linker_timing = true
Original issue's description:
> Enable noexcept on Windows, use for a few move constructors.
>
> MSVC complains if you use noexcept with no exception handling mode specified (as we do).
> This code disables the warning. noexcept on move constructors allows better optimizations
> in some cases.
> http://en.cppreference.com/w/cpp/language/noexcept_spec
>
> Updates a few common classes' move constructors to use this.
>
> Review-Url: https://codereview.chromium.org/2771643002
> Cr-Commit-Position: refs/heads/master@{#458956}
> Committed: 76aac97386TBR=brucedawson@chromium.org,lfg@chromium.org,brettw@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2769703007
Cr-Original-Commit-Position: refs/heads/master@{#459101}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 12c27f45b2cd8fea6c833a47d5270da42d791740
This is an attempt to reland a change that was attempted
several times already. It now includes changes to the
linux packaging expectations which previously caused
failed on the official bots.
TESTED=ninja linux_packages_all
BUG=701894
Review-Url: https://codereview.chromium.org/2748183005
Cr-Original-Commit-Position: refs/heads/master@{#459062}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 94c4fa81c45284d0fe1e5616f52fcad56745077b
If anyone still needs them, please tell me about your use case
(and feel free to revert).
Ran `git ls-files -- '*.isolate' | xargs git rm`
BUG=703799
NOTRY=true
TBR=jochen,davidben
Review-Url: https://codereview.chromium.org/2766673003
Cr-Original-Commit-Position: refs/heads/master@{#458595}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f526c497b9eae3805d18f71c1cefdf88cfaf8ab5
Original issue:
https://codereview.chromium.org/2757293002
Reason for reland:
Updated arg names properly.
APK patch size estimates will be used on certain perf builders, and will
track estimated patch size based on a reference APK (built by the same
builder) for the current milestone.
BUG=695188
Review-Url: https://codereview.chromium.org/2764913003
Cr-Original-Commit-Position: refs/heads/master@{#458488}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0700eafcdc29d804767a7eeb5f20e7abd87fbb00
This allows to reuse some codegen work when
linking multiple targets with the intersecting set of
object files, resulting in a reduce of overall build time.
This creates a thinlto-cache directory inside src/out/<gn-config-name>/ and keeping a lot of llvmcache* files there.
BUG=672158
Review-Url: https://codereview.chromium.org/2761893002
Cr-Original-Commit-Position: refs/heads/master@{#458418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 33d8074e449407ac84ad0e6f3ea7ab3dbda19f28
Reason for revert:
Didn't update arg names properly.
Original issue's description:
> Android: Add APK patch size estimates to resource_sizes.py.
>
> APK patch size estimates will be used on certain perf builders, and will
> track estimated patch size based on a reference APK (built by the same
> builder) for the current milestone.
>
> BUG=695188
>
> Review-Url: https://codereview.chromium.org/2757293002
> Cr-Commit-Position: refs/heads/master@{#458181}
> Committed: d5240cc0a6TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695188
Review-Url: https://codereview.chromium.org/2764923002
Cr-Original-Commit-Position: refs/heads/master@{#458403}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9a2f897d567a9cf89932703ee62982b3bc63400d
Introduces the beginnings of an embedder API for the Service Manager,
consisting of a single entry point (service_manager::Main) which in
turn delegates to its embedder for arbitrary initialization and
process execution logic.
This is the first of several incremental steps to remove content from
the generic process startup flow. Future patches will rework various
main entry points to go through service_manager::Main directly, rather
than going ContentMain -> service_manager::Main.
This will also allow us to introduce new process types which run the
Service Manager or arbitrary services directly without touching any
part of content.
BUG=654986
Review-Url: https://codereview.chromium.org/2613653003
Review-Url: https://codereview.chromium.org/2613653003
Cr-Original-Commit-Position: refs/heads/master@{#458331}
Committed: c6026704ff
Cr-Original-Original-Commit-Position: refs/heads/master@{#458252}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 60d92c2f3ff60c2fcc0b3cddd05738403fb1f0c3
Reason for revert:
Introduced crashes of webkit_tests on Mac.
BUG=703465
Original issue's description:
> Move some basic early process init into Service Manager
>
> Introduces the beginnings of an embedder API for the Service Manager,
> consisting of a single entry point (service_manager::Main) which in
> turn delegates to its embedder for arbitrary initialization and
> process execution logic.
>
> This is the first of several incremental steps to remove content from
> the generic process startup flow. Future patches will rework various
> main entry points to go through service_manager::Main directly, rather
> than going ContentMain -> service_manager::Main.
>
> This will also allow us to introduce new process types which run the
> Service Manager or arbitrary services directly without touching any
> part of content.
>
> BUG=654986
>
> Review-Url: https://codereview.chromium.org/2613653003
> Cr-Commit-Position: refs/heads/master@{#458252}
> Committed: c6026704ffTBR=jam@chromium.org,rockot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=654986
Review-Url: https://codereview.chromium.org/2763883002
Cr-Original-Commit-Position: refs/heads/master@{#458278}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c92dd551abe4a1581981b945076719dff7b4422
Previously we ran tests, without setting butler environment variables.
This will run into NotBootstrappedError when we try to upload test
results through logdog.
In this cl, we use logdog butler subcommand to run tests, which will set
butler environment variables before hand.
BUG=692287
Review-Url: https://codereview.chromium.org/2695963003
Cr-Commit-Position: refs/heads/master@{#456976}
Committed: de2df28c86
patch from issue 2695963003 at patchset 820001 (http://crrev.com/2695963003#ps820001)
Review-Url: https://codereview.chromium.org/2753993002
Cr-Original-Commit-Position: refs/heads/master@{#458264}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1ad3437632699fb98fdd46a3ba6ad8d63cf10ee5
Introduces the beginnings of an embedder API for the Service Manager,
consisting of a single entry point (service_manager::Main) which in
turn delegates to its embedder for arbitrary initialization and
process execution logic.
This is the first of several incremental steps to remove content from
the generic process startup flow. Future patches will rework various
main entry points to go through service_manager::Main directly, rather
than going ContentMain -> service_manager::Main.
This will also allow us to introduce new process types which run the
Service Manager or arbitrary services directly without touching any
part of content.
BUG=654986
Review-Url: https://codereview.chromium.org/2613653003
Cr-Original-Commit-Position: refs/heads/master@{#458252}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c6026704ff452d402924ce2d88b0168baf227b1e
APK patch size estimates will be used on certain perf builders, and will
track estimated patch size based on a reference APK (built by the same
builder) for the current milestone.
BUG=695188
Review-Url: https://codereview.chromium.org/2757293002
Cr-Original-Commit-Position: refs/heads/master@{#458181}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d5240cc0a6bd41103e36d53cd56de9994bec89d4
Pawel Hajdan, Jr
kjellander
krasin
wychen
brucedawson
drott
thomasanderson
mikecase
sdefresne
machenbach
satorux
thakis
jwd
Andrii Shyshkalov
halliwell
sbc
lgarron
thomasanderson
brettw
lambroslambrou
hzl
mark
wittman
agrieve
scottmg
yolandyan
jbudorick
estevenson
rockot
horo