The Request class in deterministic_dispatcher.h was made moveable to support
its inclusion in a circular_deque. There was some minor cleanup of this
class.
Typedefs around changed code were converted to using statements.
Some unnecessary <deque> includes were removed. An unnecessary <list>
include is removed from remoting/protocol/message_decoder.h, and a
<list> include was addedto remoting/protocol/message_decoder_unittest.cc
which was depending on this.
TBR=stevenjb (chromeos/network owners)
Bug: 757232
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I654daa3f575b21fbfd6db225d0c321bc5781f96f
Reviewed-on: https://chromium-review.googlesource.com/676201
Commit-Queue: Brett Wilson <brettw@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504232}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55ff1475eca8778624b684dd98b172f7bc49a22b
Fixes the diff phase appending an argument to the base phase's args
list.
Bug: 759087
Change-Id: I951b5ae961604caf3ce8510a993b6363488d8e7f
Reviewed-on: https://chromium-review.googlesource.com/682994
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 135012ca72159afec2ee2a6fd95d05d5b2c28316
Previously, for tags that are unknown, we will include the logcat only
when its priority level is e(error). This condition makes us lose a lot of
usefull logcat, because the condition basically means we do not include
logcat by default. It was a whitelist only.
In this cl, I am removing this condition. Thus for all tags that are
unknown, we will include the logcat no matter what its priority level
is. This way we will make sure that no important logcats are lost, and
will include logcat by default.
In the future, if we find that we have included too many logcats and
want to blacklist a tag, we can simply add <tag>:S into the
LOGCAT_FILTERS to blacklist the logcat with that tag.
Bug: 766743
Change-Id: I970a646a65b06fb66009a90c9a49df122c74d31d
Reviewed-on: https://chromium-review.googlesource.com/680894
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504149}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 91eb1791edaf1200176bb6039dfc1950025ad509
In order to use the JNI generation script from WebRTC, we need to remove
any hardcoded includes of Chromium files.
Bug: webrtc:8278
Change-Id: I4dd27c82a7957986e92c6db380479e44b49bb69e
Reviewed-on: https://chromium-review.googlesource.com/681938
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Magnus Jedvert <magjed@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504143}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c8aa4fd70d5b503ac84c2681eaf9241b98fe9057
This reverts commit 21f6df2a9bbb8c7bc60186c2ae1792b8361e1c5d.
Reason for revert: This added a dependency between //build and //testing that complicates life for //v8. Need time to evaluate what the best fix it.
Original change's description:
> Add jumbo_test template
>
> We already support jumbo_source_set, jumbo_component and
> jumbo_static_library so this is just another common template with a
> non-default configuration.
>
> This is needed in some form for jumbo in blink unittests.
>
> Bug: 761475
> Change-Id: I443fedb4a41c43cf21102e2a2f8ced937961665c
> Reviewed-on: https://chromium-review.googlesource.com/671369
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Daniel Bratell <bratell@opera.com>
> Cr-Commit-Position: refs/heads/master@{#503193}
TBR=dpranke@chromium.org,bratell@opera.com,brucedawson@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 761475
Change-Id: Ie58618afa061107ccb28e29cda6e1c50e91629ba
Reviewed-on: https://chromium-review.googlesource.com/681716
Reviewed-by: Daniel Bratell <bratell@opera.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#504075}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e4ff3e734c7a074cac36ba5dd7582d5c5852b70f
Makes diff_resource_sizes.py print out the stdout and stderr of the
resource_sizes.py subprocesses in the event of a failure. Currently,
it only outputs that the subprocess returned 1, which is not useful
for debugging.
Bug:
Change-Id: I53eb7e14cebabe91c275ba346b8de01e8a5bc014
Reviewed-on: https://chromium-review.googlesource.com/679738
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503947}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a9d1079900cafffd023a213b8a5087bf5fe7c18c
All known blockers for VS 2017 as the default compiler for Chrome on
Windows have been addressed. Switching to VS 2017 will give us:
- Better C++ conformance and various bug fixes, especially around
constexpr
- Faster fastlink links and fixes to linker bugs which can cause
incremental linking to fail
- Newer STL header files for increased STL conformance
- Debugger stability fixes (it is quite possible to debug VS 2015
binaries with VS 2017 but using the same toolchain for both is
preferable)
Note that many of these benefits apply even in the context of switching
to clang - faster links are always good, and increased VS conformance
makings switching between VS and clang easier.
Test switches to VS 2017 have been done enough times to make us
reasonably confident that the switch will go smoothly. If not then it
can be easily reverted. If the switch sticks then the documentation
pages will need to be updated.
Note that the Windows 10 Creators Update SDK will be made required soon
after this change.
Bug: 683729
Change-Id: Ib1cd215618983f12f2bdb141211028464ded1175
Reviewed-on: https://chromium-review.googlesource.com/678859
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503915}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d7af1e3aba05d9839ecffa52585b6e4808212142
Adds support for specifying the paths in diff_resource_sizes.py
using paths starting with //.
Bug: 759087
Change-Id: Id3874ad465d6dfdcea7e203fa16eaa4b8f1b7cff
Reviewed-on: https://chromium-review.googlesource.com/678442
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503827}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 852269e4248a18baa095b5f55249d0b24df1b694
VS 2015 does not implement CFG checks for longjmp but VS 2017 does. This
means that the VS 2017 linker, by default, requires that all source
files that use setjmp must be compiled with /guard:cf. This has
implications for clang-cl and for binary size so this change disables
CFG checks for longjmp.
That is, this is a linker flag change that affects runtime behavior so
that VS 2017 generated binaries will behave the same way as VS 2015
generated binaries.
Bug: 766236
Change-Id: I1c959858bceead4ccb28f273bf24926244d38083
Reviewed-on: https://chromium-review.googlesource.com/678063
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503825}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 20cc6ec55cf1322cb1afe3e87728d16df8f63834
And use it for webapk runtime library so that it can add
deps on other libraries and have them be included.
Change-Id: Idabab58de049dee19b6ae41918655b86cb008724
Reviewed-on: https://chromium-review.googlesource.com/673094
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503749}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 99638cbc274bcd00540fdda7c708b9c99fe5e97d
And tweak the log message to not log "having to wait" when the process
has died.
Hit this timeout in the context of apk_operations.py, where it was
creating the instance and then immediately sending a line to it.
Change-Id: I6c3868b389bf4f7d6b6dbd37932a2f0dcecb2982
Reviewed-on: https://chromium-review.googlesource.com/676660
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503748}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ac1986b32351290a8a90d688f5604bca8d3a464b
Chrome on iOS needs to build the same app (exact same binary)
with different application icons (i.e. with different compiled
asset catalogs).
Add a "variants" property to "ios_app_bundle" template that
contains a list of scope, each defining the variant "name" and
the list of additional "bundle_deps".
When the "variants" property is defined, the executable will
be linked once, but n application bundles will be generated in
$root_out_dir/variants/$variant_name and a copy of the first
variant will be created in $root_out_dir.
The hardlink.py script is used to copy the first variant (it
tries to use hardlink if possible, but fallback to copy if it
fails).
Bug: 764286
Change-Id: I0ea18e757c891ae884ba22c07fe20946715d1d0a
Reviewed-on: https://chromium-review.googlesource.com/677386
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503710}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7aac0a1de0b0c010efde682ad414770eb04eb4b0
A new property bundle_contents_dir was added to create_bundle to
allow distinction between the bundle directory and the directory
where the content should be added.
On iOS, this property should be equal to $bundle_root_dir, while
on macOS it should be equal to $bundle_root_dir/Contents. This
will allow creating bundles in a sub-directory of $root_out_dir.
Bug: 764286
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I7742d7b69b3a306ddd405e5dc7e6feab98e26454
Reviewed-on: https://chromium-review.googlesource.com/675603
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503679}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6f8fe3dc09d5768956728b89ff4fb71dff1e92bb
Reference to BootstrapApplication in ActivityThread needed to be
updated to the RealApplication.
Bug: 765773
Change-Id: I2d26dd691a09bc18b4b409a0d9a3d928609a0671
Reviewed-on: https://chromium-review.googlesource.com/677281
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8ea0345a1c60f213e63c1e0efdd4dcee48fd21b1
Noticably slower when applied to all messages.
Change-Id: I7a64c65d6d412aa4771303641f6222d2a7361a95
Reviewed-on: https://chromium-review.googlesource.com/676659
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503470}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6a32221cf9cface36273aa8698daf20cc5198026
This is a reland of 597f4baeedd9daaf67c4d229d48a326626a914f3
This is safe to re-land now as V8's DCHECK implementation has been
diverted into the base DCHECK implementation in SyzyASAN builds.
Original change's description:
> Default to dcheck_always_on=true in is_syzyasan builds.
>
> This causes all SyzyASAN builds to enable DCHECKs. Previous CLs have
> landed to make the this combination result in binaries which default to
> evaluating DCHECKs without treating them as fatal, unless configured to
> at run-time.
>
> Bug: 596231
> Change-Id: I15f23ba3af63c572691e9ddf96cd82780b6bac60
> Reviewed-on: https://chromium-review.googlesource.com/644358
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#498735}
TBR: scottmg@chromium.org
Bug: 596231
Change-Id: Ie7530419c30e9c9f4c50ff8d8b23db7476d30cb0
Reviewed-on: https://chromium-review.googlesource.com/677004
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Robert Shield <robertshield@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503444}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71c72ca703fcb9fb0754c2bb0e1403f7982250ea
Logcat output from apk wrapper is now colored according to pid and
severity.
NOTRY=true # android_n5x is flaking.
BUG=758670
Change-Id: I16f8c01ebad82fd232601649ba0ecfd380759882
Reviewed-on: https://chromium-review.googlesource.com/668038
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503288}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1bb0b4c3eb45a2fa1c69d720555b222d4e68ac00
Adds a shebang to diff_resource_sizes.py and makes the file executable
since the bots run the file directly instead of passing it to python,
causing the bot that's currently using it to fail.
Bug: 759087
Change-Id: I5c546084834dccbf1c076056a1fd386becb8d08d
Reviewed-on: https://chromium-review.googlesource.com/675871
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503247}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 26fe601d299ed3738c440c69d81ba66782a63c7b
We already support jumbo_source_set, jumbo_component and
jumbo_static_library so this is just another common template with a
non-default configuration.
This is needed in some form for jumbo in blink unittests.
Bug: 761475
Change-Id: I443fedb4a41c43cf21102e2a2f8ced937961665c
Reviewed-on: https://chromium-review.googlesource.com/671369
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#503193}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 21f6df2a9bbb8c7bc60186c2ae1792b8361e1c5d
This is a reland of ab6406625331e73b54e0c6a70b195efb3101cfae
Original change's description:
> Render snippets in ArticleSnippetsTest in isolation
>
> Remove the "snippets" render that shows all cards together, because
> multiple, non-article sections are not realistic in the modern design
> anymore.
>
> Rebaseline other renders:
> * Use relative timestamp instead of Jan 17, 1970
> * Use only single-card backgrounds for pre-modern cards
> * Update modern card background color after https://crrev.com/497799
> * Update pre-modern text color after https://crrev.com/500684
>
> Also move card contents in the modern layout except for the rounded
> corners into a RelativeLayout, to avoid a circular dependency between
> the height of the containing layout and the position of the bottom
> corner (see https://developer.android.com/reference/android/widget/RelativeLayout.html).
>
> Bug: 757735
> Change-Id: I81add3d5bdd8ffec61b9e8aa2ff3a9caa44ccf91
> Reviewed-on: https://chromium-review.googlesource.com/628562
> Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Peter Conn <peconn@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500975}
TBR: perezju@chromium.org
Bug: 757735
Change-Id: I0ea32d6b8008f40ae4917c6306c0706621e3b54f
Reviewed-on: https://chromium-review.googlesource.com/671084
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503184}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec2d0bb8a8b040d019ecc195a2ceebfa18d0ee39
SDCH code has been disabled in Chrome since M59. SDCH code is being removed from
Chrome in M63.
This CL is to remove it from .gn, .gitignore, licenses.py and
check_gn_headers_whitelist.txt.
Bug: 762686
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I0986a75b548fd6c1ec2e6806a8f6cd38ad2058f6
Reviewed-on: https://chromium-review.googlesource.com/674666
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503153}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcdc7ba645a5c12c7d8fbfed8bdf2c86fcad13d1
Change ios_app_bundle template to merge the generated Info.plist
with the partial .plist created by the asset catalog compiler to
support compiling application icon to Assets.car as is required
for application built with iOS 11.0 SDK.
Quote args of compile_xcasset.py in build/toolchain/mac/BUILD.gn
as some of them may be empty or contain shell special characters
(mostly spaces).
Bug: 764286
Change-Id: I453f3cbb34c82483bace9900c49e0f3b351b2635
Reviewed-on: https://chromium-review.googlesource.com/671050
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503129}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d73f3454a10aa2d20f50f1b145148380649e7849
The asset catalog compiler (actool) can generate a partial Info.plist
file that needs to be merged with the application Info.plist at build
time (this is needed to support application icon in Assets.car).
Add a --partial-info-plist flag to compile_xcassets.py that can be
used to control the path of the generated partial Info.plist. Also
inspect the list of asset catalogs to be compiled and pass correct
flags to enable their proper treatment by actool (.appiconset and
.launchimage are the only two supported currently).
If --partial-info-plist is not passed or empty, and the compiler
need this flag (i.e. if any special asset catalog is compiled), then
the script create a temporary file and pass it to the compiler.
Bug: 764286
Change-Id: I3f51e5b6ac65919275a3fafb3408d02686105e21
Reviewed-on: https://chromium-review.googlesource.com/668976
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503110}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2d534feab40dd363424f5437ec4ba3579e172d55
This also aims to eliminate _USE_MATH_DEFINES entirely by removing the last
vestiges of M_PI (at least, from the directories that can depend on ui/gfx).
Bug: none
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iae16aa804aeb80a750af34b457d426b92dd6c302
Reviewed-on: https://chromium-review.googlesource.com/657905
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503069}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9f3cebe6abf575ef8bda227a7dee4faa6cd312b
The tests on chromium.swarm don't specify the logdog butler CIPD package,
so the butler isn't available. logdog_wrapper handled this gracefully
prior to crrev.com/897b028076ce36caf579d72ffa7f8524262688a2. This CL
makes it do so again.
TBR=bpastene@chromium.org
Bug: 721889
Change-Id: I9aa1196098c52f2e829c1c1f8fcff950e1469a33
Reviewed-on: https://chromium-review.googlesource.com/672670
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6651aff71ddd37cc86bcb99e459a718da06d759e
-mstackrealign implied -fno-omit-frame-pointer which greatly
shrank the unwind tables (.eh_frame section). Removing the flag
(in crrev.com/499401) therefore improved code size but requires
emission of full unwind tables, significantly impacting overall
binary size. When building for x86 Android and optimizing for
size and generating unwind tables, this fix enables frame pointers.
Bug: 762629
Change-Id: I43515e6159a2aa1ef06e362c52f6525d2d67bf4f
Reviewed-on: https://chromium-review.googlesource.com/657566
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502860}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a0c6c3f8dd59d7392d60ad37879ffc4490458704
The file build/config/ios/imageset.gni was introduced to avoid
breaking the downstream build after the file rename. Remove it
as the downstream code has been fixed to use the new path.
Bug: 764286
Change-Id: I0dbaccca19f87017ed1a34ee7eeb37d94e1aaad9
Reviewed-on: https://chromium-review.googlesource.com/671384
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502837}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b1684ed101d2ed6c4833dbfa538ec0001ab29bd3
The CL https://chromium-review.googlesource.com/578630 configured
all platform to use C11 but did not remove the code enabling C99
on iOS/macOS. This caused iOS/macOS to use an older standard.
Bug: 766484
Change-Id: I31090257abe4feb770a0b088cfa657e2b42ca624
Reviewed-on: https://chromium-review.googlesource.com/671349
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502832}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7b0bfa078e3aff89974e6772cf2fa4e670e4f136
This also switches from running tests through the butler to
running tests alongside the butler s.t. we can independently
control process lifetimes.
Bug: 721889
Change-Id: I176b7340d9b3f097ad660b66ea64ffb4816287a8
Reviewed-on: https://chromium-review.googlesource.com/667808
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502757}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 897b028076ce36caf579d72ffa7f8524262688a2
Includes a Fuchsia SDK update, and a lot of mx_ -> zx_, et al.
Sets CHROMIUM_ROLLING_MAGENTA_TO_ZIRCON=1 as a global define
temporarily to support for 3-sided rolls of third_party DEPS.
Requires https://chromium-review.googlesource.com/c/v8/v8/+/668751 to
have landed and rolled.
Requires boringssl roll with similar change to have landed
https://chromium-review.googlesource.com/c/chromium/src/+/668704.
R=dcheng@chromium.org,nick@chromium.org,tsepez@chromium.org,rockot@chromium.org
TBR=nick@chromium.org
Bug: 765754, 707030
Change-Id: I6c2ad37b3c5b13c2a3a98da6e1ff9160ad2de949
Reviewed-on: https://chromium-review.googlesource.com/669139
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502678}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fe0e9f46ab247ff5a28a823f344c93230953018f
It breaks CrOS builds which use a different version of Clang, which
doesn't support this flag.
This is a stop-gap fix; Linux CrOS builds do use the Chromium version of
Clang, and we want them to have this flag, but there doesn't seem to be
a straight-forward way to distinguish between these compiler versions
from the build system.
Landing to unbreak the build for now until a better solution is found.
TBR=llozano
Bug: 766311,765793
Change-Id: I3e040161f6987b502b28e97f41fcde2d464da72c
Reviewed-on: https://chromium-review.googlesource.com/671810
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502668}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 308178955214516b259876b56fff9bfc78b97e7f
Trying harder to exclude CrOS build configs that don't use
Chromium's Clang.
Note to CrOS folks: If this breaks build configs that are not
tested upstream, please ping me and/or llozano before reverting.
This is a reland of 32750c1251012624a87fb97098bd0f6a60ffa8ed
Original change's description:
> Clang: enable -instcombine-lower-dbg-declare=1
>
> This enables better optimized debug info for address-taken values
> at the cost of potentially inaccurate debug info in some situations.
>
> We believe turning this on is the right trade-off for developers
> debugging Chromium on all platforms, but especially on Windows where
> values that are available in MSVC's debug info would otherwise show
> as unavailable when using Clang.
>
> The goal (crbug.com/765793) is to make Clang's optimized
> debug info good enough in all cases that this compromise is not
> necessary.
>
> Note: This requires Clang r313108 or later.
>
> Bug: 761633, 753736, 765793
> Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d
> Reviewed-on: https://chromium-review.googlesource.com/669314
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502428}
TBR=thakis
Bug: 761633, 753736, 765793
Change-Id: I2c3670873f1bd1d75cf1c41191b170983f41e0d0
Reviewed-on: https://chromium-review.googlesource.com/671523
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502646}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 074fa51f85b15ad2e2d6c804a03825d48dbeb063
This is a no-op for now. Also rename the initialization method to be
more specific.
Bug: 765428
Change-Id: I7cc24844de89a888df13c31141b476da71196304
Reviewed-on: https://chromium-review.googlesource.com/671026
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502630}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 10da07c8de893d2d1dc5de5df5f4c3afd43bf35c
The asset catalog compiler may generate a partial Info.plist file
to merge with the bundle Info.plist; add support for creating the
bundle Info.plist to codesign.py script.
Bug: 764286
Change-Id: Ie2664f7b81907deca9c65dfb37834da8dcb15e69
Reviewed-on: https://chromium-review.googlesource.com/671224
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502605}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54d19130114243bc339f5fb256dcff7ea99a5b7a
Add additional templates to compiled .appiconset and .launchimage
asset catalog types and rename the file defining the templates to
build/config/ios/asset_catalog.gni.
Leave a forwarding .gni named build/config/ios/imageset.gni as the
downstream code still reference this path. The file will be removed
in a followup CL once the downstream code has been fixed to use the
new path.
TBR=yuweih@chromium.org (for remoting/ios/app/resources/BUILD.gn)
Bug: 764286
Change-Id: Ia229d1bcbbcbeb828103ff283197120da2a21b85
Reviewed-on: https://chromium-review.googlesource.com/671264
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502603}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 39ee46494805e717c7aca8f35f4d7acadaf43ce0
This CL adds "vectorDrawables.useSupportLibrary = true" to build.gradle
that is used by Android Studio to fix warning issued for XML
app:srcCompat attribute. Chromium build already uses support library
for vector drawables.
Bug: 620034
Change-Id: I92fb56f83f854de42577a13c3fe8d51b5d1fe263
Reviewed-on: https://chromium-review.googlesource.com/668401
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502590}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c182fd2bbdaedfe3caa046fcb849ae5c35745b0c
This reverts commit 8707de2d756841d799483ceff0427e316961f468.
Reason for revert: media_unittests is crashing in vpx_internal_error
https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/15967
Original change's description:
> Make VS 2017 the default compiler on Windows
>
> All known blockers for VS 2017 as the default compiler for Chrome on
> Windows have been addressed. Switching to VS 2017 will give us:
>
> - Better C++ conformance and various bug fixes, especially around
> constexpr
> - Faster fastlink links and fixes to linker bugs which can cause
> incremental linking to fail
> - Newer STL header files for increased STL conformance
> - Debugger stability fixes (it is quite possible to debug VS 2015
> binaries with VS 2017 but using the same toolchain for both is
> preferable)
>
> Note that many of these benefits apply even in the context of switching
> to clang - faster links are always good, and increased VS conformance
> makings switching between VS and clang easier.
>
> Test switches to VS 2017 have been done enough times to make us
> reasonably confident that the switch will go smoothly. If not then it
> can be easily reverted. If the switch sticks then the documentation
> pages will need to be updated.
>
> Note that the Windows 10 Creators Update SDK will be made required soon
> after this change.
>
> Bug: 683729
> Change-Id: I79fdd9e44c6bb7ef25ab6bcb88845ac18e5cf56f
> Reviewed-on: https://chromium-review.googlesource.com/665637
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502421}
TBR=dpranke@chromium.org,brucedawson@chromium.org,scottmg@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 683729
Change-Id: Icf40a84f30941980b1c9e038cc4336b057ea10c0
Reviewed-on: https://chromium-review.googlesource.com/670283
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502535}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: eaccacb6302f7b0ea235fd7d1ff3aa7eaf8b20ef
This reverts commit 32750c1251012624a87fb97098bd0f6a60ffa8ed.
Reason for revert: This CL breaks most of the informational builds https://uberchromegw.corp.google.com/i/chromeos.chrome/waterfall?reload=300. See an example here: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/veyron_minnie-tot-chrome-pfq-informational/builds/6039
Original change's description:
> Clang: enable -instcombine-lower-dbg-declare=1
>
> This enables better optimized debug info for address-taken values
> at the cost of potentially inaccurate debug info in some situations.
>
> We believe turning this on is the right trade-off for developers
> debugging Chromium on all platforms, but especially on Windows where
> values that are available in MSVC's debug info would otherwise show
> as unavailable when using Clang.
>
> The goal (crbug.com/765793) is to make Clang's optimized
> debug info good enough in all cases that this compromise is not
> necessary.
>
> Note: This requires Clang r313108 or later.
>
> Bug: 761633, 753736, 765793
> Change-Id: Ia0ed38c499fac282a3c8ab27c5fd5571fdfab84d
> Reviewed-on: https://chromium-review.googlesource.com/669314
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#502428}
TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org
Change-Id: I4fea2ab8ec9571d4afb66cd3912c5975e0b9395c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 761633, 753736, 765793
Reviewed-on: https://chromium-review.googlesource.com/669825
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502484}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5487d51f9175a69613e7b715be437ece3c1d88e5
And also add a special case to ReTrace regex to deobfuscate a junit
message.
Bug: 765714
Change-Id: I2ba53b00a563f67eef7eb1910b2f894746abfb3a
Reviewed-on: https://chromium-review.googlesource.com/669011
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502476}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: fc9e7a90fdeb4371bfc97e13a8d1db5217697576
Nico Weber
Brett Wilson
bsheedy
Zhiling Huang
Magnus Jedvert
Andrew Grieve
Daniel Bratell
Bruce Dawson
Sylvain Defresne
John Budorick
Eric Stevenson
Wez
Hans Wennborg
Peter Wen
Bernhard Bauer
Helen Li
Shenghua Zhang
Peter Kasting
Paul Jensen
Frank Barchard
Scott Graham
Boris Sazonov
Xiaoqian Dai