Previously, when parsing test filter files, test launcher allowed
comments only on separate lines. For example:
# Comment
-DisabledTest
Now it's possible to add comments on any line, e.g.:
-DisabledTest # Comment
Change-Id: I973a8abf5894d6b75ebeefe0cc7df4ebf70ab027
Reviewed-on: https://chromium-review.googlesource.com/622168
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497635}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d567ae212a4cf9f297cac8f7ec5263aec16ebcc
The cast device builds need to be built with our libc++ since we use c++
based shared libraries.
The public cast linux bots are not arm based, so they will still be
built with the chromium libc++.
Change-Id: I303aec285e04c88758080188cc940608a1df4f27
Reviewed-on: https://chromium-review.googlesource.com/622075
Commit-Queue: Mike Bjorge <mbjorge@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497620}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1a29219dd0f49dbfffd2876d8d379959df45dd0
The changes for cronet test apk AndroidManifest and our junit runner
is because the netty jar depended by cronet test apk doesn't include
the classes needed by netty's classes. This would throw exceptions
when we try to list out tests through our junit runner and the runner
try to load all the packages it can find when `-e package` is not
specified.
This is a refactor of the CL 616025 that was reverted because this
issue.
Bug: 755721
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Ic6d2471c94b84d9f5b2a2a5b98a4f1f5ad7067b3
Reviewed-on: https://chromium-review.googlesource.com/629697
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497606}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 561eb0e9fc0408e11ac9f1566595252b0e55b551
Now that VC++ 2017 15.3.2 is packaged up we can try again to have VC++
2017 as the default compiler. This will be reverted at the end of the
weekend. If the clang workaround for 727447 is reverted then this will
also test whether that code-gen bug is fixed.
R=thakis@chromium.org
BUG=683729,727447
Change-Id: I74b070a0f8b5c58348309e1bea553136499c6922
Reviewed-on: https://chromium-review.googlesource.com/636325
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497599}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ec9a1e6ce2708f93ea08f82dd76a1f556310af91
Might be convenient to not always have to build wrappers.
Bug: 749239
Change-Id: I5b81e5ca5060e5a5ad222f29649a3bfe622da73a
Reviewed-on: https://chromium-review.googlesource.com/627196
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497560}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0ffb5547ab782127323bf647a7deea4c7ae15483
- Pass all program counters for a given binary to a single addr2line
invocation, to reduce I/O overhead symbolizing deep stacks for
large binaries.
- Remove multiprocessing from the symbolize step, to simplify it.
- Create the stripped binaries and bootfs in the build directory.
Bug:
Change-Id: Ie473fee1734180a21408e69d6cc0db2379eaa7a1
Reviewed-on: https://chromium-review.googlesource.com/633323
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497553}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 62ca702f74da454947cdf5a6a14b4a9dcaa5b637
This will pave the way to have our .isolate files include
unstripped libs for symbolization purposes.
Bug: 629042
Change-Id: I1889e331a4801794e5027f6ddf295a0435561d62
Reviewed-on: https://chromium-review.googlesource.com/633746
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497494}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65593f235472b992e2dfdd8da1cf28d7da54e256
This change switches the VS 2017 package to use the 10.0.15063.468 SDK
and VS 2017 Update 3.2 (includes fix to code-gen bug hit when building
clang with VC++ 2017).
Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.
Compiler was packaged up by downloading VS 2017 Update 3.2, from
https://www.visualstudio.com/vs/, and then running this
command (executable name was different):
vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
--add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
--passive
Then the Windows 10.0.15063.468 SDK installer was used to install the
Debuggers package.
Then the packaging script was run like this:
python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0
VS 2015 builds are still the default so this makes no immediate difference.
R=scottmg@chromium.org
BUG=683729,727447
Change-Id: Ie615737503ff3a502c6c4df3651c7511db901ffc
Reviewed-on: https://chromium-review.googlesource.com/628243
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497477}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1a56a637268fb862ea7c4fbfd8fc2d89c4b9eff4
Previously the stack in stdout of instrumentation tests is not
symbolized.
In this cl, I use the symbolize in instrumentation test instance to
symbolize the stack.
Bug: 743268
Change-Id: Ibe8575d8a35dc897976b386dbd75ff573e14a7d1
Reviewed-on: https://chromium-review.googlesource.com/631036
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497155}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 881a0cd6dd3c6c69fdf86d22ffdfed0b0459498c
Only removes strings unused by android from being included in the apk.
Now that components strings is linted, no more unused strings will be
added as future CL owners will be responsible for removing the string
from android if they remove the last usage in android code.
Bug: 731159
Change-Id: Idd3cef1d13f48fa047b00a5abc5c5c965921dd63
Reviewed-on: https://chromium-review.googlesource.com/628958
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497139}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a03ea151a1c2441a27f686ccba6ad241b21e4311
Chrome on Android needs strings in java libraries to be actually used by
that java library target. We make use of android lint to hold the line
against unused resources. A follow-up CL will remove the global
suppression for components strings as well as its unused strings for
android.
This is important especially for android since each string generates
non-trivial amount of overhead due to the android system, on the order
of 3+ kilobytes for each string regardless of length.
Individual components should avoid using strings in android java files
and opt to use native strings instead, but this CL fixes the two
components that do use android-specific strings in their android code.
Bug: 731159
Change-Id: I4bfa7e0ba068bd996d710f7b6b8c8f01e0bb773d
Reviewed-on: https://chromium-review.googlesource.com/624436
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497053}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 6207a505a3788afcaedb8d50702123a1a8f9a1b4
This is already supported in android.jinja. This adds support for java
excludes in java_library targets.
This is not enough to solve the bug but at least moves us forward.
Bug: webrtc:8148
Change-Id: I2a7551b7c53c6c42004d0729b6f5ea2d53482944
Reviewed-on: https://chromium-review.googlesource.com/632617
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Sami Kalliomäki <sakal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#497040}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b7686b473ec3eced2422cb543533ca77aa8ebc2
This reverts commit 9d96ef6894f46439e73300cdecf8ba30285e77f6.
Reason for revert: blocks rolls into clank on ToT bot.
BUG=758505
Original change's description:
> Android: Add logging_ext.py module.
>
> Adds color in a better way to pylib code.
> Additionally added some more useful test logs (such as whether
> tests pass/fail as they are run and predicted time remaining).
>
> Adding -quiet option which will make the logs as they were
> previously.
>
> Change-Id: I0cec6334a38544ccbb4a4fde6df65b6b56c2547d
> Reviewed-on: https://chromium-review.googlesource.com/603916
> Commit-Queue: Michael Case <mikecase@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#496922}
TBR=mikecase@chromium.org,agrieve@chromium.org,yolandyan@chromium.org,jbudorick@chromium.org
Change-Id: I11ca3412b5b3516bfd7107aa3f0732e7331b9941
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/631724
Reviewed-by: Anthony Berent <aberent@chromium.org>
Commit-Queue: Anthony Berent <aberent@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496992}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d55737c8d3fa961756f4d089ebc1cba10a67592c
Adds color in a better way to pylib code.
Additionally added some more useful test logs (such as whether
tests pass/fail as they are run and predicted time remaining).
Adding -quiet option which will make the logs as they were
previously.
Change-Id: I0cec6334a38544ccbb4a4fde6df65b6b56c2547d
Reviewed-on: https://chromium-review.googlesource.com/603916
Commit-Queue: Michael Case <mikecase@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496922}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d96ef6894f46439e73300cdecf8ba30285e77f6
Previously the port for testserver spawner for hardcoded in
test_runner.py. This means that tests may fail if that port is used when
the test is started. Now the port is allocated dynamically.
Bug: 731302
Change-Id: Ib22e2470cbe952aa25b1b02cf2f5c6a551ebae20
Reviewed-on: https://chromium-review.googlesource.com/627243
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496764}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 13f58d7d848ee2312dcce9ac32966e81c9b0d8cf
The previous fix in https://chromium-review.googlesource.com/623528
did not resolve the problem with the Android build, because
apparently `is_android` can be both true and false at different
stages of the build, due to it being a cross-compile.
Bug: webrtc:8109
Change-Id: I810398b17824f03c30aa53c8dfe23428657d1957
Reviewed-on: https://chromium-review.googlesource.com/628057
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496658}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c640649c92c185e05f03ba9e157fd3d3d45f0701
Previously the stack trace inside logcat is not symbolized, making it
difficult to debug.
This cl creates a logcat_symbolizer that symbolizes the stack trace in a logcat with
the new stack_symbolizer and replaces the unsymbolized stack trace in logcat
with the symbolized stace trace. The logcat_symbolizer will be called when we record
logcat during test runs.
Bug: 657040
Change-Id: Ie6c762a088a8e32dbb7095eb661d3a8a25918baf
Reviewed-on: https://chromium-review.googlesource.com/592492
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496496}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 433f98bc954b5c375337a67998e971393878a0d3
This change switches the VS 2017 package to use the 10.0.15063.468 SDK
and the non-preview release of VS 2017 Update 3.
Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.
Compiler was packaged up by downloading VS 2017 Update 3, from
https://www.visualstudio.com/vs/, and then running this
command (executable name was different):
vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
--add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
--passive
Then the Windows 10.0.15063.468 SDK installer was used to install the
Debuggers package.
Then the packaging script was run like this:
python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0
VS 2015 builds are still the default so this makes no immediate difference.
R=scottmg@chromium.org
BUG=683729
Change-Id: I9a53d1739f0a3684efc719c03022c32a2e95175e
Reviewed-on: https://chromium-review.googlesource.com/614920
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496414}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0269b680ee726032e7b2bd0e46923ef2ba08a7b9
- Now test_runner.py generates net-test-server-config instead of
net-test-server-ports as that's what will be expected by the tests
after https://chromium-review.googlesource.com/c/619813.
- Now test_runner ensures that testserver is stopped even if tests fail
to stop it.
- Updated WaitUntil() to limit waiting time instead of number of
attempts.
Bug: 731302
Change-Id: I51fa7436f672ee0f52c3b866e4d266de1a456574
Reviewed-on: https://chromium-review.googlesource.com/620286
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496388}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3b261234953ca1ef7658a72a987f4ec07b7f4525
This CL also:
- updates an outdated ANDROID_SDK_VERSION constant
- fixes findbugs errors that had crept into the build
Bug: 755685
Change-Id: I46783270cec8fae51add80c69117e2e12434eea0
Reviewed-on: https://chromium-review.googlesource.com/619038
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496354}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 27eb8dc48592c57bb94268a45985c956ffa2fbfa
Additionally:
* Fixes the device cache complaining about being out-of-date when the
--all error is shown.
* Adds a bit of color
Bug: 749239
Change-Id: I07a572b3bbf2d1f0b9760adc07383193a67d076c
Reviewed-on: https://chromium-review.googlesource.com/615126
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496297}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 711b3f2fc767848a1cff0f180640b85ed5cf06d7
WebRTC wanted the override for C++11 but it heavily relies on Chromium's
Android test framework, which uses C++14, so C++11 is not an option.
This will be used here:
https://chromium.googlesource.com/external/webrtc/+/master/.gn#43
We can't seem to override it ourselves in the .gn file.
Bug: webrtc:8109
Change-Id: I3761357c252067379ebea550b3ac4c1c53b022c0
Reviewed-on: https://chromium-review.googlesource.com/623528
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Henrik Kjellander <kjellander@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496278}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 54619c78b350b5d2f0cfad182b90be613ec2042c
When redesigning stripping of path prefixes on the app binary name, I
managed to miss a ":", resulting in all binary names under "/system/"
being truncated to a single character...
Bug:
Change-Id: I7e58d5b6593e5cb37b065c9fbc0d63448f29fb0e
Reviewed-on: https://chromium-review.googlesource.com/624814
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496068}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f00ec4f4edbc6ee285f1469814651b16b678d7f2
Adds some ignore patterns for Feedback-related files in order to
suppress warnings based on FeedbackOptions.Building having a
@VisibleForTesting annotation.
BUG=757124
Change-Id: Id5af9082815bebe7e40ef60c6268ae2c00b09690
Reviewed-on: https://chromium-review.googlesource.com/622350
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#496019}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f1b879ae6d4fd0c5ec7c26fb749e5ad32da9bb63
Most, if not all, of these un-specified suppressions have caused binary
size regressions due to resources that are no longer used but still
shipped to end-users. They should be removed and replaced with very
limited ones added for the ones absolutely necessary.
Components is a mess right now and will be in a later CL.
Bug: 731159
Change-Id: I161adac459f9e3a3be4f3b715b7af2d2997476c8
Reviewed-on: https://chromium-review.googlesource.com/616844
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ted Choc (OOO 8.21-25) <tedchoc@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495988}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a93afb3bbedab0616e8ecaf06109b169b080be3f
This CL fixes javac:interface_classpath so that it does not create
non-existent entries for jar files in deps_info:extra_classpath_jars.
This change also enables Desugar to use javac:interface_classpath
instead of deps_info:java:full_classpath
Bug: 728443, 756176
Change-Id: I579c09ef846f914cbcff3dcaf392e418983dc562
Reviewed-on: https://chromium-review.googlesource.com/621808
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495970}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c96c282264cc9cd6cf16ed60895d8b148ef011f0
This will upload crashes to staging.
Example report:
https://crash-staging.corp.google.com/browse?q=reportid=%2732b1540312c908a3%27
Adding product keys will be done in another CL.
Bug: 751134
Change-Id: I9a8446be5314be39afd2053060c30ed7a19c4b2e
Reviewed-on: https://chromium-review.googlesource.com/616565
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495951}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 96ed6102741ace7d9981a7578c0bc84d7b156b38
Losing symbolized stacks was annoying, and it didn't turn out to be that
useful to be able to type stuff into d8, so just revert interactive
mode so that d8 and headless_shell get symbolized stacks again.
Bug: 731217
Change-Id: Ib6213be3f6185f95f193218d4fb25b7a08db98c7
Reviewed-on: https://chromium-review.googlesource.com/621304
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495718}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 08098c41886a24eb813bc3981f8b9e94c4973614
Refactors existing test code and adds new test rules to allow existing
VR instrumentation tests to run in CustomTabActivity and WebappActivity
in addition to ChromeTabbedActivity using JUnit4 test parameterization.
The additional support is only enabled on two tests in this CL so that
there isn't any significant impact on runtime on the capacity-crunched
bots.
Bug: 729828
Change-Id: Ia25e35704b18925c68c6eacd4e824c07163c8913
Reviewed-on: https://chromium-review.googlesource.com/611773
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495386}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 57bd09b266854a20ea782c556381c6c3a6fea619
Depending on how a process is launched, it may end up with the name
of its process object describing:
- The fully qualified path, i.e. /system/<name>
- The CWD-relative path, i.e. ./<name>
- The PATH-relative path, i.e. just <name>
This change handles both ./ and /system/ prefixes, while also allowing
names without those prefixes to pass-through in the hope that we can
find their corresponding symbols.
Change-Id: Ied5f76f0bbab25c7da3464b62f74ad26084a2848
Reviewed-on: https://chromium-review.googlesource.com/619108
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495267}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 31aee4b1455294d8bcc9ee343a83f67587995967
This reverts commit 4e387c15744541f99764f79ad411d4204febf487.
Reason for revert: Might be the cause of failure on Cronet test bots
Original change's description:
> Fix test listing not finding downstream tests
>
> Remove the package filter for test listing that was added for
> performance reason, the filter ignore any package that is not under
> org.chromium. Removing this filter cause test listing time to increase
> by 2.4 seconds.
>
> Bug: 755721
> Change-Id: I20fe19136916bfb6e21ce6ae6f8fd52b70820003
> Reviewed-on: https://chromium-review.googlesource.com/616025
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Yoland Yan <yolandyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494630}
TBR=yolandyan@chromium.org,jbudorick@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 755721, 756255
Change-Id: Ieb4825e1a4fff304f588213c20c8c3a8381080bb
Reviewed-on: https://chromium-review.googlesource.com/619006
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495231}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0483c565d7801f47bcd660490586312521322b7a
XCUITest test runner requires XCTAutomationSupport.framework to be
running on Xcode 9, so copying it to the generated test runner bundle.
Bug: 709289
Change-Id: I583d5e90a5912044b1818fda62a2fd6ddcc04678
Reviewed-on: https://chromium-review.googlesource.com/616265
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495197}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9aaaa1ff8ff5f3e07723e0c8779b79e91d161bde
This is a reland of 550f26061a53fd69ada8fafc13170dff06e5e544
Original change's description:
> Move some VR Telemetry setup into shared state
>
> Moves the VrCore installation and setup out of run_benchmark
> and into the shared state class used by VR benchmarks. Has some
> ugly temporary hacks to make presubmit happy that will be removed
> in a follow-up CL that moves the remaining of setup code out of
> run_benchmark, allowing us to remove the file completely.
>
> This CL relies on the following Catapult CL being submitted
> beforehand: https://codereview.chromium.org/2995713002/
>
> Bug: 726906
> Change-Id: Ib5969b1657aa11b9b640ea4f7420ff746991f0c1
> Reviewed-on: https://chromium-review.googlesource.com/608984
> Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#494603}
Bug: 726906
Change-Id: I2ec5475b0e04023fb50ff8cc3d17bd77a8a07f37
Reviewed-on: https://chromium-review.googlesource.com/617820
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495196}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e95bb966ef5e097fab7a2897e474908ad25712e7
This CL links XCUITest target with the host application target by
specifying the relationship via the TEST_TARGET_NAME attribute and
adding the application target as a dependency target in the generated
Xcode project.
Bug: 709289
Change-Id: I24c5c6b2da849c9279bc95dec0f499f4c07e0e53
Reviewed-on: https://chromium-review.googlesource.com/564078
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2a757db179b70f03920f6441f96ecebc50949eaf
This reverts commit f6a5016d0313daf6e798a568c31124e159569bb5.
Reason for revert: Speculative revert for failing webkit tests at https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/4057.
Original change's description:
> (Reland)[Bindings] Create and use V8 context snapshots.
>
> This CL does two things.
>
> 1. In compile time, creates a snapshot file, which consists of V8 contexts.
> 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext().
>
> We expect this speeds up context creation for 3 times faster on Android.
> Detailed information is described in the design doc [1].
>
>
> [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30
>
>
> This CL is a re-land of https://chromium-review.googlesource.com/c/594608/
> Test expectations are changed due to http://crbug.com/705364
>
> BUG=588893, 617892, 705364
> TBR=rkc, jochen, dchen, kinuko, eroman, thakis
>
> Change-Id: I8e98ff881a2219380edc3c48de38bc661c139fb1
> Reviewed-on: https://chromium-review.googlesource.com/596167
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#495105}
TBR=rkc@chromium.org,dcheng@chromium.org,peria@chromium.org,kinuko@chromium.org,thakis@chromium.org,eroman@chromium.org,yukishiino@chromium.org,haraken@chromium.org,yangguo@chromium.org,jochen@chromium.org
Change-Id: I1050b0b84372ec683f3409ef77b9e9c45e39528f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 588893, 617892, 705364
Reviewed-on: https://chromium-review.googlesource.com/618746
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#495122}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f0d13c9a82041e4c47245aff80556cf3c0c7a7ac
Sergey Ulanov
Mike Bjorge
Yoland Yan
Bruce Dawson
Andrew Grieve
Wez
Paweł Hajdan, Jr
Egor Pasko
Sami Kalliomäki
Justin Cohen
Zhiling Huang
Peter Wen
Anthony Berent
Mike Case
Yuke Liao
Oleh Prypin
Bo Liu
Scott Graham
John Budorick
Hitoshi Yoshida
Donn Denman
Felix
Olivier Robin
Nico Weber
bsheedy
Helen Li
Max Morin