Storing the histogram name was done to see if there was any correlation
between the last-updated histogram and the corrupted one. There isn't.
This is also triggering tsan because it's shared space with no
concurrency protection.
Bug: 754599, 744734
Change-Id: I444c64f50f2464542ea71f922c3c9302208910f7
Reviewed-on: https://chromium-review.googlesource.com/612122
Commit-Queue: Brian White <bcwhite@chromium.org>
Commit-Queue: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine (very slow) <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493801}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5f3071f939b2ec29d9a1161389c60eb71a83d7e0
This DLL doesn't exist in the Anniversary Update SDK, so it's probably
fine to assume that it's not required by dbghelp.dll.
Bug: 748166
Change-Id: Ic611fcde7114da4457f28fd735bf74ab9b9be6a6
Reviewed-on: https://chromium-review.googlesource.com/610307
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493773}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 71914fe37299192c5863d9503241e3e26cbef358
With the recent addition of apk wrapper scripts, the
bin/install_foo_incremental scripts are now just confusing.
This changes them to instead be .json files.
BUG=749239
Change-Id: Id58c4f5501ce485381d3f912291dbfa729e11e61
Reviewed-on: https://chromium-review.googlesource.com/609141
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493663}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a54c4bd8807fa54a6b9fe5d5959270cfe5385f7f
Fuchsia: modify scripts to run non-test executables
* Move most test runner functionality to "runner_common.py", with
the exception of gtest-specific logic.
* Move the test-specific "main()" portions into "test_runner.py".
* Add "exe_runner.py", a very thin wrapper around the test_common
functionality.
* Use stripped executables for building the bootfs file, which results
in a substantially smaller file size (10x difference!)
It's necessary for running larger executables like "headless_shell",
which are enormous when unstripped, resulting in long mkbootfs times
and higher RAM requirements for in-memory tmpfs disks. The unstripped
executable remains intact alongside the stripped executable, for
backtrace symbolization.
* Add a GN template "fuchsia_executable_runner", which generates
executable runner scripts on non-test targets.
Bug: 746674,752364
Change-Id: Ia39c3d7fdf9bb574049f0112df84951c2e048f41
Reviewed-on: https://chromium-review.googlesource.com/602410
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493524}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 143e53fb43b6dfbee260273daaa4b033c3edf1ec
These are all unreferenced.
Change-Id: I67a51c0eb85c58f8f1705436345c6b22f2f827d6
Reviewed-on: https://chromium-review.googlesource.com/610262
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493486}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e111333d1cfd0625b9bb20627533eff5cc1e835d
Creates new TestTraceEvent.java class, with some of the functionality of the old (unused) PerfTraceEvent.
This is used within the JUnit4 test runner to track tests, and added by the Python test runner code to its trace output.
Bug:
Change-Id: Ie0b6c180a4c7f77a13e1bd08a4e641cc1a3db3ef
Reviewed-on: https://chromium-review.googlesource.com/578707
Reviewed-by: Michael Case <mikecase@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Nick Ward <npward@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#493465}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 85689988f176cc19c6274416b9fe45b284397ba1
Adds support for Java 8 using Desugar. Android Studio 3.0 is required
for Desugar. enforceUniquePackageName is no longer needed by the new
gradle version. This feature is behind "--canary" flag for now.
Bug: webrtc:8084, chromium:730711
Change-Id: Iba24880fef303aa627307356f2e26b78e153a960
Reviewed-on: https://chromium-review.googlesource.com/609066
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Sami Kalliomäki <sakal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8f75411b306ddbb870d85c39dc03024b7bd5ec74
The output directory was just plain wrong.
File caching speeds up incremental install some.
Using a custom gdb directory makes for less re-downloading of libs.
BUG=749239
Change-Id: Ifb181a5d9218973d65e124f04bdb9e5fb94e75c1
Reviewed-on: https://chromium-review.googlesource.com/609162
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493242}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d8e9a0d88ab866e34098a71f7e13ccea4ee868e6
Previously in-app backtraces would emit lines of the form:
<frame#> <absolute-PC> <binary>+<relative-PC>
#00 0x147788a0eb50 app:/system/ipc_tests+0x901b50
and these would be followed by test_runner-generated lines of the form:
<frame#>: <function> at <filename>:<line-number>
#00: StackTrace at /usr/local/google/home/wez/Projects/git-cr-fuchsia/src/out/gnDebug/../../base/debug/stack_trace_fuchsia.cc:170
with ?? substituted for elements which cannot be symbolized.
This CL has raw backtraces consumed by the test_runner script, with same
symbolized output as shown above, and a fall-back to the form:
<frame#> <binary>+<relative-PC>
for the case of unresolvable symbols.
Bug: 752255
Change-Id: I53e2c415a42ea1d49471a2e9b177cca47b1639a3
Reviewed-on: https://chromium-review.googlesource.com/604640
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493217}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 8d8c30870f07f9d2c047259888c2933fc74140b0
Reverts some Fuchsia bits of https://chromium-review.googlesource.com/c/582074
Also only default use_custom_libcxx to true on Linux if is_clang
(which on our bots is always the case), so that we can assume that
this flag is available. (If gcc ever adds a -nostdlib++ flag, we
can undo this part.)
Bug: 750434,724204
Change-Id: Ib548b403703f6dc77e5ec09c7ee14e360fb09b72
Reviewed-on: https://chromium-review.googlesource.com/606790
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#493055}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ff69d3018c42eb994533de337f81d417a0209913
This CL adds Java 8 support for Chrome on Android by removing use_java8
and process_java8 flags. The Java 8 support is achieved by using
Desugar to rewrite Java 8 bytecode to be compatible with Java 7.
Currently Java 8 feature "default and static methods"
(crbug.com/728443) is not supported. And Java 7 feature
"try-with-resources" (crbug.com/751776) still needs to be guarded by
API level checks, otherwise resulting in lint errors about new APIs.
Bug: 730711
Change-Id: I6efb898d225f3062338ad19c6ac565df6b40449e
Reviewed-on: https://chromium-review.googlesource.com/598539
Commit-Queue: Felix <zpeng@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492727}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e1fdb3865b3107b2ef7169fefd2d17cadfdfb47f
This reverts commit 0e0bd52f773b7e06fa9237154110d9963d5aea03.
Reason for revert: The dragdrop data provider needs to be upstreamed from port CL before this will build.
Original change's description:
> Modify GN feature args for Fuchsia.
>
> Turn off some features when is_fuchsia=true. The features may be
> re-added in the future as progress continues on the Chromium port
> and the OS itself.
>
> It's necessary for bringing headless_shell to a buildable state.
>
>
> R: scottmg@chromium.org,thakis@chromium.org
> Bug: 750917
> Change-Id: I7011dfa559474d7eacce9482ae02c3330d113e94
> Reviewed-on: https://chromium-review.googlesource.com/596621
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Scott Graham <scottmg@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Bill Budge <bbudge@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492531}
TBR=bbudge@chromium.org,dalecurtis@chromium.org,thakis@chromium.org,thestig@chromium.org,kmarshall@chromium.org,skyostil@chromium.org,scottmg@chromium.org,altimin@chromium.org
Change-Id: I0c7ac7b55bf18127cc2ad52c90b1b9f301900def
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 750917
Reviewed-on: https://chromium-review.googlesource.com/606747
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492689}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f423b4deb515f78c7868ec4b39c091cd28b669dd
Turn off some features when is_fuchsia=true. The features may be
re-added in the future as progress continues on the Chromium port
and the OS itself.
It's necessary for bringing headless_shell to a buildable state.
R: scottmg@chromium.org,thakis@chromium.org
Bug: 750917
Change-Id: I7011dfa559474d7eacce9482ae02c3330d113e94
Reviewed-on: https://chromium-review.googlesource.com/596621
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492531}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 0e0bd52f773b7e06fa9237154110d9963d5aea03
chrome_test_server_spawner is used by net_unittests to spawn test
server on the host. Previuously it had dependencies on Android. Moved
it to build/util/common and refactored Android dependency, so the
same code can be used when running these tests on Fuchsia bots.
Bug: 731302
Change-Id: Ie4069b6cc0f1dc98b96f62fdf6a1b692a86b3997
Reviewed-on: https://chromium-review.googlesource.com/603669
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492498}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9cd680e72a411c5a565098251d42863c43aef17f
xdpyinfo from the package x11-utils is necessary for run-webkit-tests.
BUG=749222
R=dpranke@chromium.org
Change-Id: I4ee4d880895e56c947741debdaa2095f03efc91e
Reviewed-on: https://chromium-review.googlesource.com/601354
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d79de41d48ab8813d3793d8df5c6bafe4d77b6ab
net_test_support_apk needs cert files on the device in order to support
HTTPS in EmbeddedTestServer. This change should ensure that such runtime
dependencies of support APKs get pushed to the device when necessary.
Change-Id: I40f38540a0d3490a451a9697e250d7935484e50d
Reviewed-on: https://chromium-review.googlesource.com/602691
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492418}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 23a8c0ec81c609a6bee19574780ff606653a937f
This points out a potential (but rare) problem with referencing static
fields of a non-exported base, through the base's non-exported inline
functions, or directly. The warning is subtle enough that people just
suppressed it when they saw it, so it's not worth it.
Bug: 752837
Change-Id: Ia9b8307f77e155416bdfdad28ff33df3081a434b
Reviewed-on: https://chromium-review.googlesource.com/603773
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492411}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4b77236a76acca2eb885b5021a0ede75efe29962
Because chromium compilation may be using some unique features on loongson platform,
in order to distinguish between other mips platforms, so add loongson3 mips_arch_variant.
Bug: nobug
R= dpranke@chromium.org
Change-Id: I8ecb522979655c2e578215bed706816221385be1
Reviewed-on: https://chromium-review.googlesource.com/593493
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492319}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f808fa2ee42b46124ed104dd46cd407632a492e0
Currently public libc++ symbol visibility is only disabled for the
static build of libc++ itself; however, dynamic libraries that link in
libc++ and pull in it's header files also need to avoid leaking symbols
or else dynamic libraries will resolve internal-only libc++ symbols
from the executable.
Move these definitions from //buildtools//third_party/libc++/BUILD.gn
to //build/config/posix/BUILD.gn
This change needs to land alongside or before
https://chromium-review.googlesource.com/c/601422R=pcc@chromium.org, thakis@chromium.org, thomasanderson@chromium.org
Bug: 751360
Change-Id: I78ff6902e014150a56da9d908869199e1bce226a
Reviewed-on: https://chromium-review.googlesource.com/601529
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492215}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2440912f23c01e661b47341bb322f50f67cb153b
This is a reland of cfa74c5047c1a580a16e7de8950762a0c67c1a3f
Reverted in https://chromium-review.googlesource.com/c/596807
Reason for reland:
Downstream has a fix for the issue.
Deletes google_play_services_library GN variable. This should reduce
compile times a bit, but mostly is just a good idea in general.
TBR=paulmiller@chromium.org
Bug: 752238
Change-Id: I0c4c9548256166aa90280850f84fa17385c1ad9c
Reviewed-on: https://chromium-review.googlesource.com/600636
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#492021}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2ae3701ed1f5331e0cbc69bb2bd375c4d3375fe9
This CL allow test information that was once listed by parsing proguard dump or
dexdump to be produced by JUnit runner run all the tests without executing them.
The TestListInstrumentationRunListener is registered in the
BaseChromiumAndroidJUnitRunner and will write all tests to a json file which
then will be pulled to host side by host side runner script
BUG: 640116
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Iea277ea8c7a1d07a2367b1e0a286ce77199935be
Reviewed-on: https://chromium-review.googlesource.com/590694
Commit-Queue: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491839}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2909d207648a69f60e8bcf55d1669c424c5d6c6c
Fuchsia: stub out missing ProcessMetrics methods.
The absence of Fuchsia stubs for these methods produced linker errors
when compiling the headless shell.
R: scottmg@chromium.org
Bug: 750948
Change-Id: If9e13e80e17852fe7692164b2cd0c728bdded9f3
Reviewed-on: https://chromium-review.googlesource.com/596624
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491799}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bf7ca7a186a15260b25a171ba83e49e93a6c905d
This CL fixes:
* Parsing the release file to obtain the desired SHA256 sum when there
are multiple hash algorithms listed in different orders.
* Removes a list of directories to relativize symlinks and replaces it
with a direct check on the directory nesting.
BUG=751812
R=thestig@chromium.org
Change-Id: If3692f0633ba7ad059ab3c7d0945f4b7ef11786e
Reviewed-on: https://chromium-review.googlesource.com/598931
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491506}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 651ac81c816861f48eab99f8730862bd027ae790
Users who specify an 'ios' solution in .gclient will pull the iOS toolchain.
This is used by 'ios' bots to pull the toolchain. But macOS developers who
happen to specify an 'ios' solution will also pull the iOS toolchain. This CL is
a temporary hack to work around this: if the machine appears to be a corp
machine, always pull the macOS toolchain.
Bug: 742527
Change-Id: Ic49785078f0e15c06f44f61a0daab54dd552ec9e
Reviewed-on: https://chromium-review.googlesource.com/598776
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491498}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a211039cca8b7afe0edc753d051772a5ec9d63d7
This adds code to query the process' debug symbol maps for offsets
and produces an externally symbolizable backtrace using that data.
R: thakis@chromium.org,wez@chromium.org
CC: jamesr@chromium.org
Bug: 706592
Change-Id: I7b3257ff154671b2eb1c90f7ab91947f55cfa873
Reviewed-on: https://chromium-review.googlesource.com/575290
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491470}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: abf2e85ada60eb318e91976a8845288d0cec959f
Our experiments show that Desugar, a Google-developed open-source tool,
outperforms Retrolambda in both APK sizes and Java method counts. This
CL replaces Retrolambda with Desugar in our experimental Java 8 support.
BUG=730711
Review-Url: https://codereview.chromium.org/2985523002
Cr-Original-Commit-Position: refs/heads/master@{#491183}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1a159a003ca82e0b0bd653078dbde80757bf9e2c
This CL reverts the changes in sysroot-creator.sh and
rolls the sysroots forward to reflect the change.
BUG=749077
R=thestig@chromium.org
Change-Id: Ia9ba4427666dbf9268138f7ec7a2f77df70a172f
Reviewed-on: https://chromium-review.googlesource.com/596419
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491148}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e8df45bfd5386216b9b6ff178b26461902c7ae3a
This reverts commit cfa74c5047c1a580a16e7de8950762a0c67c1a3f.
Reason for revert: Broke downstream compile
Original change's description:
> Android: Make all targets depend on specific play services targets
>
> Deletes google_play_services_library GN variable. This should reduce
> compile times a bit, but mostly is just a good idea in general.
>
> Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f
> Reviewed-on: https://chromium-review.googlesource.com/585450
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Paul Miller <paulmiller@chromium.org>
> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Michael Case <mikecase@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490968}
TBR=lambroslambrou@chromium.org,nyquist@chromium.org,mariakhomenko@chromium.org,mikecase@chromium.org,agrieve@chromium.org,paulmiller@chromium.org,jochen@chromium.org
Change-Id: I404413dfe809a6918015d109524c4995ec202789
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 751199
Reviewed-on: https://chromium-review.googlesource.com/596807
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491075}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c865af52f097f5651b7fa7d2dc4537f24bd21779
Not the normal simple update-the-hash SDK update. Changes:
- Use our own libunwind (as it's been removed from the Fuchsia SDK);
- Use the toolchain hash as a version #define instead of the .stamp in
sysroot (which has been removed). The Fuchsia team builds with -MD to
cause rebuilds after ABI changes, Chromium builds with -MMD. The
global define ensures we rebuild on SDK updates;
- Update clang version to '6.0.0' to get correct builtins lib;
- Update docs for pulling SDK from prebuilt package, rather than doing
local builds.
- Don't include libc++ and libunwind .so into the runner disk image, as
we link to them statically now.
Bug: 707030, 750392
Change-Id: I6702ce208e23288107db00d80f4bed7f875820ae
Reviewed-on: https://chromium-review.googlesource.com/594270
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#491035}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 131568b82901daf84658a300210a9002949b54a2
This reverts commit 59784d15a14347cd2e36769429ea0178f5c464b6.
Reason for revert: it breaks compilation (linking of v8_context_snapshot_generator), see https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/19741
Original change's description:
> (Reland)[Bindings] Create and use V8 context snapshots.
>
> This CL does two things.
>
> 1. In compile time, creates a snapshot file, which consists of V8 contexts.
> 2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext().
>
> We expect this speeds up context creation for 3 times faster on Android.
> Detailed information is described in the design doc [1].
>
>
> [1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30
>
>
> This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it)
> Test expectations are changed due to http://crbug.com/705364
>
> BUG=588893, 617892, 705364
> TBR=rkc, jochen, dchen, kinuko, eroman, thakis
>
> Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f
> Reviewed-on: https://chromium-review.googlesource.com/594608
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490955}
TBR=rkc@chromium.org,dcheng@chromium.org,peria@chromium.org,kinuko@chromium.org,thakis@chromium.org,eroman@chromium.org,yukishiino@chromium.org,haraken@chromium.org,jochen@chromium.org
Change-Id: I67f166ae37b2103100c066334586a3b49a3a21e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 588893, 617892, 705364
Reviewed-on: https://chromium-review.googlesource.com/596087
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490973}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f043c3f6c2e9ea2e3903964a3b917276661085d
Deletes google_play_services_library GN variable. This should reduce
compile times a bit, but mostly is just a good idea in general.
Change-Id: Ia991772db4a8549490926ad46808ceefaf12853f
Reviewed-on: https://chromium-review.googlesource.com/585450
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Michael Case <mikecase@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490968}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cfa74c5047c1a580a16e7de8950762a0c67c1a3f
This CL does two things.
1. In compile time, creates a snapshot file, which consists of V8 contexts.
2. Creates v8::Context from the snapshot in LocalWindowProxy::CreateContext().
We expect this speeds up context creation for 3 times faster on Android.
Detailed information is described in the design doc [1].
[1] Design doc: https://docs.google.com/document/d/1jpQQX0piaxcHJPWakp_Kr_03g5Gnma5h5-Kdlqu7jVQ/edit#heading=h.k6iklq6rvd30
This CL is a re-land of https://codereview.chromium.org/2841443005 (and the 1st patch is same with it)
Test expectations are changed due to http://crbug.com/705364
BUG=588893, 617892, 705364
TBR=rkc, jochen, dchen, kinuko, eroman, thakis
Change-Id: If85e68a6498f7d35a0c59f4af9323ba72fc36d5f
Reviewed-on: https://chromium-review.googlesource.com/594608
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490955}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 59784d15a14347cd2e36769429ea0178f5c464b6
Brian White
Sebastien Marchand
Andrew Grieve
Kevin Marshall
Nick Ward
Sami Kalliomäki
Michael Giuffrida
Wez
Nico Weber
Scott Graham
F
Sergey Ulanov
Tom Anderson
John Budorick
Wang Qing
Vlad Tsyrklevich
Yoland Yan
kapishnikov
erikchen
Aaron Gable
Oleh Prypin
Aleksandr Derbenev
Benjamin Pastene
Jan Krcal
Hitoshi Yoshida
Julien Brianceau