b42854dfe134 Fix Doxygen after 8c802aace407
bf52da0f1bc1 posix: Fix Semaphore::TimedWait wait time
d2d10d1dc8f3 posix: Use std::trunc() from <cmath> instead of trunc()
7819ecbed662 posix: Use trunc() from <math.h> instead of std::trunc()
f37b382687c0 linux/android: Reenable util test, and enable snapshot test
a8493c9b3148 android: Fix FloatContext::NativeFpxregs for x86 with
unified headers
376cddee9eea doc: Update for NDK r15b
6823f6783082 Limit alignas to 64
3d6f7bcf90f5 Enable x86 optimizations for zlib
13e8672410d8 Update mini_chromium to ee67585e3115
1c87c92932d0 linux: Add ProcessMemoryRange to restrict memory reads to a
range
4224be41d7d1 linux: Add ElfImageReader to read ELF images via
ProcessMemory
a79791969d03 linux: Add MemoryMap::FindFileMmapStart
041a50d75c4c linux: Add DebugRendezvous to read dynamic linker data
structures
6ab73e0ad8ac linux: #include appropriate headers for ElfImageReader
5536baff1392 linux: Use PTRACE_GET_THREAD_AREA for x86
ThreadInfo.GetThreadArea
6b5f139d88ce linux: Add ProcessReader
7be6b8ea1ded Add functions to convert native x86 contexts to Crashpad
CPUContexts
bde35ca918ba Add MemorySnapshotLinux
37f20f7b1400 Add ThreadSnapshotLinux
9299d409ab0a linux: Refactor reading start time from the stat file
90e4649f0dfa linux: Sort alphabetically in util .gyp files
01b347732e0e linux: Collect CPU times in ProcStatReader and use in
ProcessReader
281be63d0074 Standardize on static constexpr for arrays when possible
7e6a0145b17b mac handler: Record the number of open files in the handler
process
6dac7ecdf58e Use constexpr at function scope
8f0636288a0e Use constexpr at namespace scope
b653f8615321 Fix Windows build after 8f0636288a0e
a06ca92083f5 Switch CQ to use the new swarmbucket (LUCI) builders
3a5837c77379 #include "build/build_config.h" where necessary
c332e7ffdab6 Fix Doxygen usage in util/misc/lexing.h
1d443b822364 Revert "Switch CQ to use the new swarmbucket (LUCI)
builders"
c9319008b609 Disable the win x86 tests in the CQ until they are swarmed
43a1e46a31f5 Tweak the README wording
7f038ebbd2df #include "build/build_config.h" where necessary
Change-Id: Ib6fe73caf333ecda8f1311ca212dae41affa534d
Reviewed-on: https://chromium-review.googlesource.com/592694
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490857}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f9b9fe1cfc5ae9e3cc39361e6e3ed0e928391d8e
As the main sources has switched to C++14, nocompile tests should also
switch to it.
Bug: 554717
Change-Id: Ib06b3e931b78d545e709d6f7b886ca895840fbd9
Reviewed-on: https://chromium-review.googlesource.com/593372
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490826}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cffd16beb3874844101953c888e7d497c94a05cb
The major blockers for this were that gcc+libc++ (android) and
clang+libstdc++4.8 (linux) didn't compile in this mode. We've
since switched android from gcc to clang, and linux from libstdc++
to libc++, so this works fine everywhere now.
Off-waterfall bots setting `enable_custom_libcxx` to false need to
make sure that they use a libstdc++ newer than 4.8 (like the
simplechrome chromeos bots), else they'll get build errors -- see
the blocker bugs of the linked bug below.
We'll use the same process for C++14 that we used for C++11, we'll
list new features at http://chromium-cpp.appspot.com/, disallow
everything at first, and then allow things over time. So don't use
any C++14 stuff for now.
This doesn't affect the Windows bots; cl.exe (and clang-cl.exe)
have implicitly always allowed C++14.
Bug: 554717
Change-Id: Ibf2a19168a35b5aad2449af9abdc44a56997aeef
Reviewed-on: https://chromium-review.googlesource.com/583635
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490676}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 5a9b923e371351d2ca64b47b9cac5f39d4fb7e86
This is the only build configuration that still uses libstdc++4.8.
Does not affect the simplechrome build (which is what we ship,
and which uses a newer libstdc++).
Bug: 554841
Change-Id: If8acb3c59445214ba78d6f076cd9698b52a37b59
Reviewed-on: https://chromium-review.googlesource.com/591775
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490649}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d82eb4601227635631686c93b5e9ac376ab8ee6f
This CL adds a hack that removes the symbol __cxa_thread_atexit_impl
from libc.so in the sysroots. In addition, it also rolls the sysroots
and updates the expected deps to reflect the symbol no longer being
required.
BUG=749077
R=thestig@chromium.org
Change-Id: I7501d45b8ecff66e97287002bea9ee1e351348c5
Reviewed-on: https://chromium-review.googlesource.com/592279
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490541}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: c2e32f4639a6c56eef7fc4f65160ac2896eca0f1
A notification will be sent to chromium-dev if this sticks.
Some blink baselines shift due to different rounding behaviour. In the
majority of cases, this means the Windows and Mac/Linux baselines now
become identical.
This also switches win_clang bots to use MSVC as compiler, to make sure
things stay compilable with MSVC.
Known problems:
* Build times without goma are slower (but you can do goma builds with
debug info now, which are faster).
* Incremental linking of webcore.dll doesn't work (see crbug.com/717207
and crbug.com/560475)
BUG=82385,709690
Change-Id: I67421a5aee2259cf98b93d34d69a3314dbd98304
Reviewed-on: https://chromium-review.googlesource.com/588077
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490494}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d2c91228a51bdf37ae3b2e501fb53c0528f1629c
Zip overhead is larger than you'd think :/. ~400kb for Chrome apks.
Change-Id: I873bbed846116f6df918eb2de9a440d19878483a
Reviewed-on: https://chromium-review.googlesource.com/590270
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490466}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 767a6f5a890a6028a1d8a8f30cea242b568e6cee
Handle Java assert failure by modifying the bytecode of jar file.
Create package org.chromium.build that have all java target depend on it.
Reland for CL https://codereview.chromium.org/2971063003/
BUG=672945
Change-Id: I9e22961c257e3a4c1b95a7b9add7e776164c7713
Reviewed-on: https://chromium-review.googlesource.com/580403
Commit-Queue: Ran Ji <ranj@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490420}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7c1e906dff6f894589b40fd2fde6a3d387cf8ef7
This has a bunch of minor advantages:
1. It's less code
2. It's a build step less per windows_manifest
3. rc.exe is no longer explicitly required in the build, which means
just distributing lld-link is enough on non-Windows hosts,
we don't need to distribute an mt-like program (assuming lld-link
internally doesn't need to shell out to mt).
No intended behavior change.
Bug: 495204,749768
Change-Id: Ie079b82bc6217bc85942827f2c2843bb893d7186
Reviewed-on: https://chromium-review.googlesource.com/588387
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490255}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9ad0916c64be00ef8ba7f7f6a9b3c78813e17f21
The downstream version of play services requires this to support
AndroidManifest.xml merging.
BUG=643967
Change-Id: I3a8662aedc8c5c6cbc4ce0e895f92ab5cbedb7e1
Reviewed-on: https://chromium-review.googlesource.com/584129
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490230}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9eec19d03d142ed912e3efe6439bc2bb642fead9
We're currently losing some tests in single-device shards when a
test times out. run_tests_on_device for that shard fails, no other
shard is available to run the remaining tests within that try, and
the tests without @RetryOnFailure don't get rerun in the subsequent
tries.
This CL attempts to address this issue by:
1. Only killing the shard on receiving a DeviceUnreachableError or
an exception not emitted by devil. (The former indicates that
we probably won't be able to use the device at all in the run,
while the latter indicates an unexpected condition that should
likely result in termination.) This should allow the single
device to continue running tests within a try even if a test
times out.
2. Always retrying tests that didn't run.
No-Tree-Checks: true
Bug: 748145
Change-Id: Id120877e78b36443ed4cf8b979f17d52ea7d59ab
Reviewed-on: https://chromium-review.googlesource.com/585866
Commit-Queue: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490159}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 76c3c6cc2b52ca5f9909e30fc7127a9891d9585e
inverse_depth.py used to be used for gn bindings generation in gyp days.
compiler_version.py used to be used to detect gcc 4.6.
Bug:
Change-Id: Iac94f46c7cdd889730cd8e52351ea899705552a0
Reviewed-on: https://chromium-review.googlesource.com/588135
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490022}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a3cf4d27ce27706c9cb253216a98f0bafd20096e
Reason for revert:
Reverting as the likely cause of many webview
layout test runner failures - see crbug.com/749468
Original issue's description:
> List Java Instru Test Information From JUnit Runner
>
> This CL allow test information that was once listed by parsing proguard dump or
> dexdump to be produced by JUnit runner run all the tests without executing them.
> The TestListInstrumentationRunListener is registered in the
> BaseChromiumAndroidJUnitRunner and will write all tests to a json file which
> then will be pulled to host side by host side runner script
>
> BUG=640116
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
>
> Review-Url: https://codereview.chromium.org/2935503002
> Cr-Commit-Position: refs/heads/master@{#489826}
> Committed: 682e23394cTBR=jbudorick@chromium.org,mikecase@chromium.org,nyquist@chromium.org,xunjieli@chromium.org,yolandyan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=640116
Review-Url: https://codereview.chromium.org/2991833003
Cr-Original-Commit-Position: refs/heads/master@{#489896}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bc3d1a8c8dbb2d67ae97235bb4c4243dd74d3e00
Include the *.so files in lib.unstripped and the *.so files that are in apks so that we have the right symbols when symbolizing tombstones.
BUG=743268
Review-Url: https://codereview.chromium.org/2974163002
Cr-Original-Commit-Position: refs/heads/master@{#489882}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 55fc2af69da5f96e351e5aea26cfe75b95cf1887
This CL allow test information that was once listed by parsing proguard dump or
dexdump to be produced by JUnit runner run all the tests without executing them.
The TestListInstrumentationRunListener is registered in the
BaseChromiumAndroidJUnitRunner and will write all tests to a json file which
then will be pulled to host side by host side runner script
BUG=640116
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2935503002
Cr-Original-Commit-Position: refs/heads/master@{#489826}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 682e23394ce75a8b9d19a5ee351f401706e5cff7
Adds a '--device' flag to Fuchsia run scripts. This causes the script
to run the Fuchsia SDK's bootserver instead of launching QEMU. If a
configured device is then connected to the bootserver the kernel and
boot image are sent to the device, and the tests run by autorun, the
same as in the QEMU case. (Press Alt-F1 to switch to 'debuglog' to see
the output on-device.)
Bug: 707029, 706592, 749242
Change-Id: I0a84885232463ee4cf316c6399edd6155ce97536
Reviewed-on: https://chromium-review.googlesource.com/585411
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489812}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 05b3b6349f8febd0d4bbda554962514c1913876e
This has a bunch of minor advantages:
1. It's less code
2. It's a build step less per windows_manifest
3. /manifest:embed automatically sets 1 or 2 based on /dll, so
clients of windows_manifest() clients no longer need to set type
4. rc.exe is no longer required for every single binary, which
helps bootstrapping of cross-building some chrome/win binaries
on non-win
No intended behavior change.
TBR=sergeyu,grt
Bug: 495204
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I13cd9103829fa535997fa7a7e5ec009dbc1b8039
Reviewed-on: https://chromium-review.googlesource.com/585109
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489729}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 132e149a98b37ee78eaf86434dbe37f22fa40d4c
This CL strips the carriage return from $APP_DATA_DIR by using
"adb_shell" instead of "$ADB" shell
BUG=748637
Change-Id: Icfc4f863f1866dbc4fd4c6f05e425352436b66c8
Reviewed-on: https://chromium-review.googlesource.com/585308
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489636}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 910974935304cfd94382d35ca9e1b5f56a989058
Since jumbo chunks were divided before headers were filtered out, the
actual chunk sizes were not deterministic and much smaller than expected.
This patch filters headers first, and halves the chunk size to get the same
actual chunks.
Bug: 747368
Change-Id: Ia537af07f7226a87d8de1309bf494914789609e4
Reviewed-on: https://chromium-review.googlesource.com/581289
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#489598}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1741b755a959e3732a6b6d422c488b7fb1067699
This makes goldens specific to both the device model and Android SDK
version and enables render tests on the Nexus 5 Kitkat. It also removes
the golden images for Nexus 5Xs since chrome_public_test_apk is not
run on Nexus 5Xs on the CQ.
Bug: 641973
Change-Id: I46dd428489820f814355d51d266d256fcf189c4c
Reviewed-on: https://chromium-review.googlesource.com/583067
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489597}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 75d5cc55de99398763e312c2da1ac669a717606b
In cross builds of chrome/win, the host and target toolchains currently
have the same name. To fix this, rename clang_x64 to win_clang_x64.
Because the toolchain name is also referenced in libyuv, this requires
a five-sided change:
1. Introduce variable containing the toolchain name in src.git
2. Change libyuv to refer to the variable
3. Rename toolchain in src.git (including in the newly introduced var)
4. Let libyuv refer to the new name directly
5* Remove variable again
(See also https://codereview.chromium.org/2463143002)
Bug: 748501
Change-Id: I8fe3557fb6a200116ba4c4d6dc3338f895fd3757
Reviewed-on: https://chromium-review.googlesource.com/585592
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489426}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9f072955094ffe6fbab3e864286ab6b1dcdf8f8c
In cross builds of chrome/win, the host and target toolchains currently
have the same name. To fix this, rename clang_x64 to win_clang_x64.
Because the toolchain name is also referenced in libyuv, this requires
a five-sided change:
1. Introduce variable containing the toolchain name in src.git
2. Change libyuv to refer to the variable
3* Rename toolchain in src.git (including in the newly introduced var)
4. Let libyuv refer to the new name directly
5. Remove variable again
(See also https://codereview.chromium.org/2463143002)
TBR=pastarmovj,wfh,dschuff
Bug: 748501
Change-Id: Ifad35c6d2d0c29404637421a36a2a6bfeaa113c5
Reviewed-on: https://chromium-review.googlesource.com/585151
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489403}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 94d731c12e243640231fcebfe14109c1a897465d
In cross builds of chrome/win, the host and target toolchains currently
have the same name. To fix this, rename clang_x64 to win_clang_x64.
Because the toolchain name is also referenced in libyuv, this requires
a five-sided change:
1* Introduce variable containing the toolchain name in src.git
2. Change libyuv to refer to the variable
3. Rename toolchain in src.git (including in the newly introduced var)
4. Let libyuv refer to the new name directly
5. Remove variable again
(See also https://codereview.chromium.org/2463143002)
Bug: 748501
Change-Id: Ia54b2f3f6cb37524c698ad8e3b411d77db612188
Reviewed-on: https://chromium-review.googlesource.com/584811
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489318}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 88ef4818de0b999a15969413c0b490a1f14bcd16
This SDK is built automatically by the Fuchsia team bot, rather than
having Cr-Fuchsia or Fuchsia do manual things to build it.
It's still manually tested though.
Bug: 707030
Change-Id: I3d4aa101e91e0fc447824a239fbc4c007d84ff6b
Reviewed-on: https://chromium-review.googlesource.com/584094
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489229}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: db3c2b654c3dd2836f5d38d1644a86b9380056ae
Fixes AndroidManifest.xml not being rebuilt when a dependent manifest is
change (for incremental builds).
BUG=643967
Change-Id: Idac20e9c9d409ad5ad14ab575f8ee520ecc6b532
Reviewed-on: https://chromium-review.googlesource.com/582937
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489196}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: f8a3108b74daf9d5334fa1d9c4255f8004eb2b26
Two changes:
1.) Stop bundling libstdc++.so.
This was needed when the bots were still on trusty. Now that they're all
on precise, the system libstdc++ is new enough to run clang.
The motivation is that clang currently transitively depends on system
libicuuc, which depends on a newer libstdc++ than the one we bundle.
So currently, clang fails to start on Ubuntu 16+.
2.) Built libclang_rt.ios.a with arm64 code too.
TBR=hans
Bug: 723919,747726
Change-Id: Ie123a2f6c80d539e4a246c5c0073d8560a66b5ba
Reviewed-on: https://chromium-review.googlesource.com/582976
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489167}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: d1b349921b612c35fa6c8d67443bd8155b790b5b
Regressed at https://chromium-review.googlesource.com/c/582047/, or
possibly b29655da29
when bootstrap was rolled in (?).
bootstrap already runs autorun in apps.config, so don't add a second
run of the test binary.
Bug: 731302, 706592
Change-Id: I6847942b64598777424ab2b106d2c7e1ba3ca8f5
Reviewed-on: https://chromium-review.googlesource.com/583928
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489105}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 7e821e1a89eac8982aa1d8fd3a3fbb31660309cf
Handle ctrl-C and timeouts for Fuchsia test symbolization.
Currently the symbolization worker processes fight over who gets
to receive SIGINT when the user presses ctrl-C during symbolization.
This change makes the parent process, the one that spawned the
children, solely responsible for receiving the signal and killing
the child processes.
R: sergeyu@chromium.org
Bug: 740201
Change-Id: I76721d18dda35a8d5b28ace24687c07ea0f68b87
Reviewed-on: https://chromium-review.googlesource.com/578747
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489035}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9d6ed67929770fd6541ac6bd82904ae1610fe745
Now that the Fuchsia SDK includes configs for the "bootstrap"
service, migrate to launching the test binary via bootstrap, rather
than launching it directly as an "initial app". This makes the
system services launched by the default bootstrap configuration
available to the test binary.
Bug: 731302
Change-Id: Ie17d123f7de91ea49a8bd11ddf67a6bd903dfdfb
Reviewed-on: https://chromium-review.googlesource.com/582047
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489031}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: df97778dec61a7c5bd0702f7f352e33514bc33cb
In the large thumbnail and modern layouts the edges of suggestions
thumbnails touch the edge of the suggestions card. If these images have
a white background they blend in with the background around the card.
This CL adds ThumbnailGradient which checks if 40% of the border
pixels are light (each of their RGB values are greater than 0xcc). In
this case a gradient overlay is added to the Drawable.
Bug: 737966
Change-Id: I356ad8ec85a24dfaf875567f3db7c51e9ce0d2e6
Reviewed-on: https://chromium-review.googlesource.com/575985
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Alexei Svitkine (slow) <asvitkine@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488996}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 92161965ac5f6db21899578657b46e73ce1d04e7
Apparently some bots, such as Linux GPU TSAN have TSAN stack
traces where base::Histogram::AddCount appears as just
AddCount (while other functions are fully qualified.)
So this adds to the suppression added in
https://chromium-review.googlesource.com/c/581418 to ignore
these errors.
BUG=744734
Change-Id: I1e353894193cd3992c3a965013891bcb9f9105a8
Reviewed-on: https://chromium-review.googlesource.com/583227
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488971}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9773bf1cbf291511a4aef6ec782bb20a4ebc6b7d
Ran `tools/clang/scripts/upload_revision.py 308728`.
This changes the clang version from 5.0.0 to 6.0.0, so simplify
some things that dealt with both numbers.
This changes clang to no longer look for libc++ headers in the
Fuchsia SDK. To keep things building, use "our" libc++, like
on linux (use_custom_libcxx). This in turn means we pass
-nodefaultlibs to the linker, which sadly also disables the
automatic linking of clang_rt.builtins, so do that manually now.
(In exchange, we no longer need to pass in -resource-dir.)
This makes -Wformat fire in Google Toolbox for Mac in iOS builds,
so disable -Wformat in that config for now.
Bug: 746303,746505,747638,747643,724204
Change-Id: I6196a2a173a1b4871f22d0ce92436d0197fd7845
Reviewed-on: https://chromium-review.googlesource.com/582074
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488946}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 1c688af81fcfa4c072dcca79e698641839e8a42f
We're moving everything inside //webrtc/ to // and we need to update
gtk's visibility list.
See go/webrtc-repo-in-chrome for details.
Bug: chromium:611808
Change-Id: Id829993e70b3545885c52fae90bcf57f931aad39
Reviewed-on: https://chromium-review.googlesource.com/579988
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488881}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 4a527bd95e7db06654a6742062a4a23b0407bfa2
This change:
- Does a separate pass on all histograms, validating them, before
starting to prepare their deltas. This will confirm that data is
bad already before we start processing them (i.e. verify that it's
not the processing code having some side effect).
- Counts the number of corrupted histograms to tell us if it's a single
bad value or more widespread corruption.
- Keeps track of the last histogram that someone logged something to,
so that we could have a trail of the last thing that happened before
corruption.
- Moves a previously added instrumentation call to within the correct if
block.
BUG=736675,744734
Change-Id: I4b860ad6e977c1555409bd628f9e4e5147e61654
Reviewed-on: https://chromium-review.googlesource.com/581418
Commit-Queue: Alexei Svitkine (slow) <asvitkine@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488815}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e8a3a3bbec7e6f3876a33baa9124213a82371b0
Tom Anderson
Mark Mentovai
tzik
Nico Weber
Shenghua Zhang
agrieve
Hans Wennborg
Brian Sheedy
Ran Ji
blundell
peria
John Budorick
Mike Bjorge
Alexander Timin
Trent Apted
awdf
hzl
yolandyan
Scott Graham
Eric Stevenson
Peter Kotwicz
Daniel Bratell
Peter E Conn
Kevin Marshall
Sergey Ulanov
Alexei Svitkine
Edward Lemur